[Bug 57767] Websocket client proprietary configuration

2017-09-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57767 --- Comment #14 from J Fernandez --- (In reply to Remy Maucherat from comment #13) > Ok, so that's obviously the big item (IMO), that looks good. > I'm not convinced that digest is useful anymore, do you think it is ? On

[Bug 61489] Disable creation of command line parameters from GET parameters in the URL for CGIServlet

2017-09-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61489 --- Comment #5 from Christopher Schultz --- (In reply to jm009 from comment #4) > I don't understand... > My patch already uses . Sorry, you are correct. I did not read the patch closely enough. -- You are

[Bug 61189] CGIServlet should be able to set specific environment variables

2017-09-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61189 --- Comment #5 from jm009 --- Created attachment 35297 --> https://bz.apache.org/bugzilla/attachment.cgi?id=35297=edit Variable name in . This patch implements your second suggestion. For the moment it is my preferred

[Bug 61189] CGIServlet should be able to set specific environment variables

2017-09-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61189 --- Comment #4 from jm009 --- Created attachment 35296 --> https://bz.apache.org/bugzilla/attachment.cgi?id=35296=edit All variable declarations in one . So here is a patch, that would implement your first suggestion.

Release plans

2017-09-05 Thread Mark Thomas
Hi all, I'm planning to complete the Tomcat Native 1.2.14 release tomorrow, update 8.5.x and 9.0.x to use it and then tag them. If there is anything you want me to hold the tags for, please let me know. Mark - To unsubscribe,

[Bug 61489] Disable creation of command line parameters from GET parameters in the URL for CGIServlet

2017-09-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61489 --- Comment #4 from jm009 --- I don't understand... My patch already uses . The patch as it is makes the feature disabled by default. -- You are receiving this mail because: You are the assignee for the bug.

[Bug 61489] Disable creation of command line parameters from GET parameters in the URL for CGIServlet

2017-09-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61489 Christopher Schultz changed: What|Removed |Added Keywords|

[Bug 61489] Disable creation of command line parameters from GET parameters in the URL for CGIServlet

2017-09-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61489 --- Comment #3 from Christopher Schultz --- I like the idea of locking this down, but requiring a rebuild-from-source to change the setting isn't acceptable. Can you add a new to control this behavior? +1 for

[Bug 61189] CGIServlet should be able to set specific environment variables

2017-09-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61189 Christopher Schultz changed: What|Removed |Added Keywords|

[Bug 61189] CGIServlet should be able to set specific environment variables

2017-09-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61189 --- Comment #3 from Christopher Schultz --- I don't like the use of unique names that don't have any meaning, like `environment-variable-N`. Might I suggest one or the other of these schemes:

[Bug 57767] Websocket client proprietary configuration

2017-09-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57767 Christopher Schultz changed: What|Removed |Added Keywords|

[Bug 57767] Websocket client proprietary configuration

2017-09-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57767 --- Comment #13 from Remy Maucherat --- Ok, so that's obviously the big item (IMO), that looks good. I'm not convinced that digest is useful anymore, do you think it is ? On the plus side, you did it already, on the minus side

Re: Dynamic reloading of SSL certificates

2017-09-05 Thread Romain Manni-Bucau
Hello guys, wonder if this thread went anywhere? Would be very neat to have a let's encrypt integration (don't know if it would be a listener to declare to have automatic reloading or just a flag on the SSL config but it would ease deploying self hosted instances). Romain Manni-Bucau

[Bug 61201] CGIServlet adds too much to the SCRIPT_NAME environment variable if script followed by extra path

2017-09-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61201 jm009 changed: What|Removed |Added Status|RESOLVED|REOPENED

[Bug 61491] New: IllegalArgumentException thrown by PerMessageDeflate sendMessagePart()

2017-09-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61491 Bug ID: 61491 Summary: IllegalArgumentException thrown by PerMessageDeflate sendMessagePart() Product: Tomcat 8 Version: 8.5.20 Hardware: PC Status: NEW

buildbot success in on tomcat-trunk

2017-09-05 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/2670 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

svn commit: r1807334 - /tomcat/trunk/test/org/apache/coyote/http2/TestAbstractStream.java

2017-09-05 Thread markt
Author: markt Date: Tue Sep 5 10:29:11 2017 New Revision: 1807334 URL: http://svn.apache.org/viewvc?rev=1807334=rev Log: Fix NPEs in tests after refactoring Modified: tomcat/trunk/test/org/apache/coyote/http2/TestAbstractStream.java Modified:

buildbot failure in on tomcat-trunk

2017-09-05 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/2669 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

svn commit: r1807331 - in /tomcat/trunk/java/org/apache/coyote/http2: Http2Protocol.java Http2UpgradeHandler.java

2017-09-05 Thread markt
Author: markt Date: Tue Sep 5 09:44:09 2017 New Revision: 1807331 URL: http://svn.apache.org/viewvc?rev=1807331=rev Log: Refactor: Obtain ping configuration directly from protocol Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2Protocol.java

svn commit: r1807327 - in /tomcat/trunk/java/org/apache/coyote/http2: Http2Protocol.java Http2UpgradeHandler.java

2017-09-05 Thread markt
Author: markt Date: Tue Sep 5 09:43:54 2017 New Revision: 1807327 URL: http://svn.apache.org/viewvc?rev=1807327=rev Log: Refactor: Configure local settings directly from protocol Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2Protocol.java

svn commit: r1807328 - in /tomcat/trunk/java/org/apache/coyote/http2: Http2Protocol.java Http2UpgradeHandler.java

2017-09-05 Thread markt
Author: markt Date: Tue Sep 5 09:43:59 2017 New Revision: 1807328 URL: http://svn.apache.org/viewvc?rev=1807328=rev Log: Refactor: Access concurrency control directly from protocol Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2Protocol.java

svn commit: r1807329 - in /tomcat/trunk/java/org/apache/coyote/http2: Http2Protocol.java Http2UpgradeHandler.java Stream.java

2017-09-05 Thread markt
Author: markt Date: Tue Sep 5 09:44:04 2017 New Revision: 1807329 URL: http://svn.apache.org/viewvc?rev=1807329=rev Log: Refactor: Obtain limits directly from protocol Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2Protocol.java

svn commit: r1807325 - in /tomcat/trunk: java/org/apache/coyote/http2/Http2AsyncUpgradeHandler.java java/org/apache/coyote/http2/Http2Protocol.java java/org/apache/coyote/http2/Http2UpgradeHandler.jav

2017-09-05 Thread markt
Author: markt Date: Tue Sep 5 09:43:44 2017 New Revision: 1807325 URL: http://svn.apache.org/viewvc?rev=1807325=rev Log: Refactor: Make Http2Protocol available to Http2UpgradeHandler. This will enable some duplicated properties to be removed. Modified:

svn commit: r1807326 - in /tomcat/trunk/java/org/apache/coyote/http2: Http2AsyncUpgradeHandler.java Http2Protocol.java Http2UpgradeHandler.java

2017-09-05 Thread markt
Author: markt Date: Tue Sep 5 09:43:49 2017 New Revision: 1807326 URL: http://svn.apache.org/viewvc?rev=1807326=rev Log: Refactor: Obtain timeouts directly from protocol Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2AsyncUpgradeHandler.java

svn commit: r1807324 - in /tomcat/trunk/java/org/apache/coyote: AbstractProcessor.java ajp/AbstractAjpProtocol.java ajp/AjpProcessor.java http11/AbstractHttp11Protocol.java http11/Http11Processor.java

2017-09-05 Thread markt
Author: markt Date: Tue Sep 5 09:43:38 2017 New Revision: 1807324 URL: http://svn.apache.org/viewvc?rev=1807324=rev Log: Refactor: Make adapter reference final Modified: tomcat/trunk/java/org/apache/coyote/AbstractProcessor.java

[Bug 61489] Disable creation of command line parameters from GET parameters in the URL for CGIServlet

2017-09-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61489 --- Comment #2 from jm009 --- Created attachment 35293 --> https://bz.apache.org/bugzilla/attachment.cgi?id=35293=edit Make evaluation of enableCmdLineArguments in outer if. In fact the evaluation of "boolean

[Bug 61489] Disable creation of command line parameters from GET parameters in the URL for CGIServlet

2017-09-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61489 jm009 changed: What|Removed |Added Summary|Disable creation of command |Disable creation of

[Bug 61189] CGIServlet should be able to set specific environment variables

2017-09-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61189 --- Comment #2 from jm009 --- Created attachment 35291 --> https://bz.apache.org/bugzilla/attachment.cgi?id=35291=edit Allow to configure CGI specific environment variables. This patch makes configuration of

[Bug 61489] Disable creation of command line parameters from GET parameters in the URL

2017-09-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61489 --- Comment #1 from jm009 --- Why I suggest to disable this feature by default: 1) I never saw a servlet that uses this feature 2) I suppose, this feature comes from the beginnings of the internet, when people wanted

[Bug 61489] New: Disable creation of command line parameters from GET parameters in the URL

2017-09-05 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61489 Bug ID: 61489 Summary: Disable creation of command line parameters from GET parameters in the URL Product: Tomcat 9 Version: unspecified Hardware: All