[GitHub] tomcat issue #84: Add tomcat in the cloud abstract implementation
Github user jfclere commented on the issue: https://github.com/apache/tomcat/pull/84 See also in https://github.com/jgroups-extras/jgroups-kubernetes/blob/master/src/main/java/org/jgroups/protocols/kubernetes/stream/StreamProvider.java it seems we are reusing their internal interface, what doesn't look quite good, AKA it looks like an implementation detail of the Kubernetes logic. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 61668] Possible NullPointerException in org.apache.coyote.http11.AbstractHttp11Protocol
https://bz.apache.org/bugzilla/show_bug.cgi?id=61668 Esin Yakub changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #3 from Esin Yakub --- Thanks for the quick reaction guys! -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GUMP@vmgump-vm3]: Project tomcat-trunk-validate (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-validate has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 42 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-validate : Tomcat 9.x, a web server implementing the Java Servlet 4.0, ... Full details are available at: http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-validate/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on checkstyle exists, no need to add for property checkstyle.jar. -INFO- Failed with reason build failed The following work was performed: http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-validate/gump_work/build_tomcat-trunk_tomcat-trunk-validate.html Work Name: build_tomcat-trunk_tomcat-trunk-validate (Type: Build) Work ended in a state of : Failed Elapsed: 32 secs Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs -Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-8.5-SNAPSHOT.jar -Dexecute.validate=true validate [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-8.5-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-20171109.jar:/srv/gump/packages/commons-collections3/commons-collections-3.2.1.jar:/srv/gump/public/workspace/commons-cli/target/commons-cli-1.5-SNAPSHOT.jar:/srv/gump/public/workspace/commons-lang-trunk/target/commons-lang3-3.8-SNAPSHOT.jar:/srv/g ump/public/workspace/apache-commons/logging/target/commons-logging-20171109.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-20171109.jar:/srv/gump/public/workspace/google-guava/guava/target/guava-HEAD-jre-SNAPSHOT.jar - [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-trunk/test/org/apache/el/TestValueExpressionImpl.java:34: Extra separation in import group before 'org.junit.Test' [ImportOrder] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-trunk/test/org/apache/el/lang/TestELArithmetic.java:26: Extra separation in import group before 'org.junit.Assert' [ImportOrder] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-trunk/test/org/apache/el/lang/TestELSupport.java:30: Extra separation in import group before 'org.junit.Assert' [ImportOrder] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-trunk/test/org/apache/el/parser/TestELParser.java:30: Extra separation in import group before 'org.junit.Ignore' [ImportOrder] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-trunk/test/org/apache/jasper/compiler/TestAttributeParser.java:24: Extra separation in import group before 'org.junit.Test' [ImportOrder] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-trunk/test/org/apache/jasper/compiler/TestCompiler.java:29: Extra separation in import group before 'org.junit.Test' [ImportOrder] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-trunk/test/org/apache/jasper/compiler/TestGenerator.java:36: Extra separation in import group before 'org.junit.Assert' [ImportOrder] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-trunk/test/org/apache/jasper/compiler/TestJspConfig.java:24: Extra separation in import group before 'org.junit.Test' [ImportOrder] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-trunk/test/org/apache/jasper/compiler/TestParser.java:25: Extra separation in import group before 'org.junit.Assert' [ImportOrder] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-trunk/test/org/apache/jasper/compiler/TestParserNoStrictWhitespace.java:26: Extra separation in import group before 'org.junit.Test' [ImportOrder] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-trunk/test/org/apache/jasper/compiler/TestScriptingV
[GUMP@vmgump-vm3]: Project tomcat-tc8.0.x-validate (in module tomcat-8.0.x) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc8.0.x-validate has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 42 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-tc8.0.x-validate : Tomcat 8.x, a web server implementing the Java Servlet 3.1, ... Full details are available at: http://vmgump-vm3.apache.org/tomcat-8.0.x/tomcat-tc8.0.x-validate/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on checkstyle exists, no need to add for property checkstyle.jar. -INFO- Failed with reason build failed The following work was performed: http://vmgump-vm3.apache.org/tomcat-8.0.x/tomcat-tc8.0.x-validate/gump_work/build_tomcat-8.0.x_tomcat-tc8.0.x-validate.html Work Name: build_tomcat-8.0.x_tomcat-tc8.0.x-validate (Type: Build) Work ended in a state of : Failed Elapsed: 34 secs Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Dbase.path=/srv/gump/public/workspace/tomcat-8.0.x/tomcat-build-libs -Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-8.5-SNAPSHOT.jar -Dexecute.validate=true validate [Working Directory: /srv/gump/public/workspace/tomcat-8.0.x] CLASSPATH: /usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-8.5-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-20171109.jar:/srv/gump/packages/commons-collections3/commons-collections-3.2.1.jar:/srv/gump/public/workspace/commons-cli/target/commons-cli-1.5-SNAPSHOT.jar:/srv/gump/public/workspace/commons-lang-trunk/target/commons-lang3-3.8-SNAPSHOT.jar:/srv/g ump/public/workspace/apache-commons/logging/target/commons-logging-20171109.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-20171109.jar:/srv/gump/public/workspace/google-guava/guava/target/guava-HEAD-jre-SNAPSHOT.jar - [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-8.0.x/test/org/apache/el/TestValueExpressionImpl.java:34: Extra separation in import group before 'org.junit.Test' [ImportOrder] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-8.0.x/test/org/apache/el/lang/TestELArithmetic.java:26: Extra separation in import group before 'org.junit.Assert' [ImportOrder] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-8.0.x/test/org/apache/el/lang/TestELSupport.java:30: Extra separation in import group before 'org.junit.Assert' [ImportOrder] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-8.0.x/test/org/apache/el/parser/TestELParser.java:28: Extra separation in import group before 'org.junit.Test' [ImportOrder] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-8.0.x/test/org/apache/jasper/compiler/TestAttributeParser.java:24: Extra separation in import group before 'org.junit.Test' [ImportOrder] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-8.0.x/test/org/apache/jasper/compiler/TestCompiler.java:29: Extra separation in import group before 'org.junit.Test' [ImportOrder] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-8.0.x/test/org/apache/jasper/compiler/TestGenerator.java:36: Extra separation in import group before 'org.junit.Assert' [ImportOrder] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-8.0.x/test/org/apache/jasper/compiler/TestJspConfig.java:24: Extra separation in import group before 'org.junit.Test' [ImportOrder] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-8.0.x/test/org/apache/jasper/compiler/TestParser.java:25: Extra separation in import group before 'org.junit.Assert' [ImportOrder] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-8.0.x/test/org/apache/jasper/compiler/TestParserNoStrictWhitespace.java:26: Extra separation in import group before 'org.junit.Test' [ImportOrder] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-8.0.x/test/org/apache/jasper/compiler/Tes
[GUMP@vmgump-vm3]: Project tomcat-tc7.0.x-validate (in module tomcat-7.0.x) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-validate has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 42 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-tc7.0.x-validate : Tomcat 7.x, a web server implementing Java Servlet 3.0, ... Full details are available at: http://vmgump-vm3.apache.org/tomcat-7.0.x/tomcat-tc7.0.x-validate/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on checkstyle exists, no need to add for property checkstyle.jar. -INFO- Failed with reason build failed The following work was performed: http://vmgump-vm3.apache.org/tomcat-7.0.x/tomcat-tc7.0.x-validate/gump_work/build_tomcat-7.0.x_tomcat-tc7.0.x-validate.html Work Name: build_tomcat-7.0.x_tomcat-tc7.0.x-validate (Type: Build) Work ended in a state of : Failed Elapsed: 32 secs Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Dbase.path=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-build-libs -Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-8.5-SNAPSHOT.jar -Dexecute.validate=true validate [Working Directory: /srv/gump/public/workspace/tomcat-7.0.x] CLASSPATH: /usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-8.5-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-20171109.jar:/srv/gump/packages/commons-collections3/commons-collections-3.2.1.jar:/srv/gump/public/workspace/commons-cli/target/commons-cli-1.5-SNAPSHOT.jar:/srv/gump/public/workspace/commons-lang-trunk/target/commons-lang3-3.8-SNAPSHOT.jar:/srv/g ump/public/workspace/apache-commons/logging/target/commons-logging-20171109.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-20171109.jar:/srv/gump/public/workspace/google-guava/guava/target/guava-HEAD-jre-SNAPSHOT.jar - [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-7.0.x/test/org/apache/el/TestELInJsp.java:23: Extra separation in import group before 'org.junit.Assert' [ImportOrder] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-7.0.x/test/org/apache/el/TestMethodExpressionImpl.java:30: Extra separation in import group before 'org.junit.Before' [ImportOrder] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-7.0.x/test/org/apache/el/TestValueExpressionImpl.java:34: Extra separation in import group before 'org.junit.Test' [ImportOrder] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-7.0.x/test/org/apache/el/lang/TestELArithmetic.java:24: Extra separation in import group before 'org.junit.Test' [ImportOrder] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-7.0.x/test/org/apache/el/lang/TestELSupport.java:29: Extra separation in import group before 'org.junit.Assert' [ImportOrder] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-7.0.x/test/org/apache/el/parser/TestELParser.java:28: Extra separation in import group before 'org.junit.Test' [ImportOrder] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-7.0.x/test/org/apache/jasper/compiler/TestAttributeParser.java:24: Extra separation in import group before 'org.junit.Test' [ImportOrder] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-7.0.x/test/org/apache/jasper/compiler/TestCompiler.java:28: Extra separation in import group before 'org.junit.Assert' [ImportOrder] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-7.0.x/test/org/apache/jasper/compiler/TestGenerator.java:37: Extra separation in import group before 'org.junit.Assert' [ImportOrder] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-7.0.x/test/org/apache/jasper/compiler/TestJspConfig.java:24: Extra separation in import group before 'org.junit.Test' [ImportOrder] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-7.0.x/test/org/apache/jasper/compiler/TestParser.java:26: Extra sep
[Bug 61465] jvm crashed in org.apache.tomcat.util.net.AprEndpoint$Sendfile.run()
https://bz.apache.org/bugzilla/show_bug.cgi?id=61465 --- Comment #5 from merlin <910225...@qq.com> --- (In reply to merlin from comment #4) > year,it does not happen again after we updated to latest version 8.5.20 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 61465] jvm crashed in org.apache.tomcat.util.net.AprEndpoint$Sendfile.run()
https://bz.apache.org/bugzilla/show_bug.cgi?id=61465 --- Comment #4 from merlin <910225...@qq.com> --- year,it does not happen again after we updated to latest version -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 61740] New: Intermittent NIO HTTP/2 errors
https://bz.apache.org/bugzilla/show_bug.cgi?id=61740 Bug ID: 61740 Summary: Intermittent NIO HTTP/2 errors Product: Tomcat 9 Version: 9.0.1 Hardware: PC Status: NEW Severity: normal Priority: P2 Component: Connectors Assignee: dev@tomcat.apache.org Reporter: david.frank...@infinitecampus.com Target Milestone: - Created attachment 35509 --> https://bz.apache.org/bugzilla/attachment.cgi?id=35509&action=edit screenshot of bug, code to reproduce (hopefully) I’m trying to troubleshoot an intermittent response error using Tomcat 8.5.23 or 9.0.1 when using HTTP/2. Basically we noticed that when running in HTTP/2 random css, js or html pages would error out causing small bugs that would go away on refresh. We were finally able to isolate it to a test case that "usually" reproduces the error. The test case uses 100 iframes to draw 10 table cells that each get colored green by a seperate css file so in total it makes 1101 requests. If some of those requests don't make it and then it displays red on that cell. (See attached image in the zip of the error in action). I reproduced it using the latest version of Firefox with caching disabled so that it makes every request independently. It is very hard to reproduce in Chrome since it tends to ignore no-caching settings. I've also found it easier to reproduce using a client that has Windows 10 and a powerful computer. A less powerful client running Windows 7 had difficulty reproducing the error but still could after enough tries. So Tomcat running on Windows x64 and fresh download of either 9.0.1 or 8.5.23 with stock configuration I enable HTTP/2 with: And put the test files in the ROOT app and then hit https://localhost:8443/newtest.html until the error happens. As you can see in the image, some of the responses have 0 bytes and they will display in red, some of the responses have response bodies but no HTTP status code, some have HTTP 200 but no response body. When there is no http status returned the access log records these as 500 errors. I can't find any meaningful exception with catalina debug logging turned on. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat issue #76: added SessionInitializerFilter
Github user isapir commented on the issue: https://github.com/apache/tomcat/pull/76 @markt-asf Can you please pull this patch in? It'd be great to have it available in Tomcat 9. Thanks. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56026] RemoteEndpoint.Async#sendText(String, SendHandler) not thread safe
https://bz.apache.org/bugzilla/show_bug.cgi?id=56026 Ryan changed: What|Removed |Added CC||ryan.slomin...@gmail.com -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 61736] NIO BlockPoller may stay at events() method for too long time
https://bz.apache.org/bugzilla/show_bug.cgi?id=61736 --- Comment #2 from Mark Thomas --- Thanks for the detailed report. To have such a complicated issue explained so clearly - and with a patch! - is extremely helpful. I can see how the problem happens and I can also see how your proposed patch addresses it. I'm not concerned about delaying new events to the next loop. The events queue is a custom implementation so I want to look to see if that makes an alternative fix possible but I haven't found anything so far (and probably won't). -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 61736] NIO BlockPoller may stay at events() method for too long time
https://bz.apache.org/bugzilla/show_bug.cgi?id=61736 --- Comment #1 from Mark Thomas --- See https://github.com/apache/tomcat/pull/81 for a proposed patch. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat issue #84: Add tomcat in the cloud abstract implementation
Github user markt-asf commented on the issue: https://github.com/apache/tomcat/pull/84 This needs a wider discussion on the dev list first. However I do have some initial high level comments: - The choice of package is unexpected - Headers need to be standard ASF headers - Author details need to be removed - At least one file appears to have been written by someone other than the person submitting the pull request. That is a huge red flag as it is not clear that the person submitted the pull request has the necessary rights to do so. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 61717] Wepapp deployment errors are not logged to context log
https://bz.apache.org/bugzilla/show_bug.cgi?id=61717 Mark Thomas changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #1 from Mark Thomas --- I can't reproduce this. If you still see this issue please provides the steps to reproduce this on a clean install of the latest 8.5.x release. I suggest reproduce this by making the minimal necessary changes to the web.xml of the host-manager app. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 61696] Initialize Nashorn ScriptEngine with SecurityManager cause a "Security Violation, attempt to use Restricted Class: jdk.internal.dynalink.support.messages".
https://bz.apache.org/bugzilla/show_bug.cgi?id=61696 Mark Thomas changed: What|Removed |Added Resolution|--- |INVALID OS||All Status|NEW |RESOLVED --- Comment #1 from Mark Thomas --- Thanks for the test case. It really helped make progress on this one quickly. I as sure as I can be that this is a Nashorn bug. The creation of the static Logger in jdk.internal.dynalink.support.Guards needs to be in a privileged block. Everything in the Nashorn environment runs in a sandbox with limited privileges. Stepping through the code I see that, at the point the code tries to create the logger, a ProtectionDomain in place with very minimal privileges. As a work-around, try pre-loading the Guards class. You can use the memory leak prevention listener to do this: I'm marking this as invalid as I believe the root cause lies outside of Tomcat -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 61736] NIO BlockPoller may stay at events() method for too long time
https://bz.apache.org/bugzilla/show_bug.cgi?id=61736 ZILONG SONG changed: What|Removed |Added Severity|enhancement |major -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 61736] New: NIO BlockPoller may stay at events() method for too long time
https://bz.apache.org/bugzilla/show_bug.cgi?id=61736 Bug ID: 61736 Summary: NIO BlockPoller may stay at events() method for too long time Product: Tomcat 8 Version: 8.0.47 Hardware: PC OS: Mac OS X 10.1 Status: NEW Severity: enhancement Priority: P2 Component: Connectors Assignee: dev@tomcat.apache.org Reporter: sz...@qq.com Target Milestone: Created attachment 35508 --> https://bz.apache.org/bugzilla/attachment.cgi?id=35508&action=edit An Http Client which is able to send data in controlled packet size and packet interval. When using tomcat in NIO mode as a server to receive files, and if the files are transferred via a non-stable network (there is an obvious interval between neighbor TCP packets), then the traffic always hang for a great while with zero window reported from server. Following are the steps to reproduce the problem. 1. Configure the server tcp receive window size. $ cat /proc/sys/net/ipv4/tcp_rmem 102420488192 2. Put the following JSP into the ROOT project. (in the path $CATALINA_HOME/webapps/ROOT/consume.jsp) <%@ page import="org.apache.commons.io.IOUtils" %><% final ServletInputStream inputStream = request.getInputStream(); byte[] content = IOUtils.toByteArray(inputStream); %>ok The IOUtils is a class from commons-io 3. Start tomcat in NIO mode with the following settings Server version:Apache Tomcat/8.0.46 Server built: Aug 10 2017 10:10:31 UTC Server number: 8.0.46.0 OS Name: Linux OS Version:3.10.0-229.el7.x86_64 Architecture: amd64 Java Home: /usr/jdk1.8.0_121/jre JVM Version: 1.8.0_121-b13 JVM Vendor:Oracle Corporation Command line argument: -Xms256m Command line argument: -Xmx256m Command line argument: -Xmn128m Command line argument: -Xss1m 4. Capture the TCP traffics. tcpdump -i any -w tcp.cap port 8080 5. Start a client. sending data with http in chunks with the following settings: chunk size 1024 byte time to rest between chunks 50 ms chunk count per request 100 parallel requests100 total requests 1 6. Then we will got a lot of zero window packets, which lasts several seconds. No. stream Time Source Destination ackwinLength Info 469817 3201 15:09:04.175309172.16.1.4 172.16.1.5 1 29696 57 [TCP segment of a reassembled PDU] 469904 3201 15:09:04.214945172.16.1.5 172.16.1.4 4238 1024 54 8080→58750 [ACK] Seq=1 Ack=4238 Win=1024 Len=0 470091 3201 15:09:04.437137172.16.1.4 172.16.1.5 1 29696 1078 [TCP Window Full] [TCP segment of a reassembled PDU] 470092 3201 15:09:04.437142172.16.1.5 172.16.1.4 5262 0 54 [TCP ZeroWindow] 8080→58750 [ACK] Seq=1 Ack=5262 Win=0 Len=0 470334 3201 15:09:04.657120172.16.1.4 172.16.1.5 1 29696 54 [TCP Keep-Alive] 58750→8080 [ACK] Seq=5261 Ack=1 Win=29696 Len=0 470335 3201 15:09:04.657123172.16.1.5 172.16.1.4 5262 0 54 [TCP ZeroWindow] 8080→58750 [ACK] Seq=1 Ack=5262 Win=0 Len=0 470620 3201 15:09:05.098135172.16.1.4 172.16.1.5 1 29696 54 [TCP Keep-Alive] 58750→8080 [ACK] Seq=5261 Ack=1 Win=29696 Len=0 470621 3201 15:09:05.098141172.16.1.5 172.16.1.4 5262 0 54 [TCP ZeroWindow] 8080→58750 [ACK] Seq=1 Ack=5262 Win=0 Len=0 471017 3201 15:09:05.979136172.16.1.4 172.16.1.5 1 29696 54 [TCP Keep-Alive] 58750→8080 [ACK] Seq=5261 Ack=1 Win=29696 Len=0 471018 3201 15:09:05.979140172.16.1.5 172.16.1.4 5262 0 54 [TCP ZeroWindow] 8080→58750 [ACK] Seq=1 Ack=5262 Win=0 Len=0 471619 3201 15:09:07.743148172.16.1.4 172.16.1.5 1 29696 54 [TCP Keep-Alive] 58750→8080 [ACK] Seq=5261 Ack=1 Win=29696 Len=0 471620 3201 15:09:07.743151172.16.1.5 172.16.1.4 5262 0 54 [TCP ZeroWindow] 8080→58750 [ACK] Seq=1 Ack=5262 Win=0 Len=0 475765 3201 15:09:08.545625172.16.1.5 172.16.1.4 5262 3072 54 [TCP Window Update] 8080→58750 [ACK] Seq=1 Ack=5262 Win=3072 Len=0 475781 3201 15:09:08.545815172.16.1.4 172.16.1.5 1 29696 490[TCP segment of a reassembled PDU] 475782 3201 15:09:08.545821172.16.1.5 172.16.1.4 5698 3072 54 8080→58750 [ACK] Seq=1 Ack=5698 Win=3072 Len=0 475784 3201 15:09:08.545825172.16.1.4
[GitHub] tomcat issue #83: Bug 61668 - Possible NullPointerException in AbstractHttp1...
Github user markt-asf commented on the issue: https://github.com/apache/tomcat/pull/83 Thanks for the proposed patch. I opted for a more general solution in StringUtils since fixing that problem there should - in theory - prevent it appearing anywhere else StringUtils is used. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat pull request #83: Bug 61668 - Possible NullPointerException in Abstra...
Github user markt-asf closed the pull request at: https://github.com/apache/tomcat/pull/83 --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 61668] Possible NullPointerException in org.apache.coyote.http11.AbstractHttp11Protocol
https://bz.apache.org/bugzilla/show_bug.cgi?id=61668 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #2 from Mark Thomas --- Thanks for the report. This has been fixed in: - 9.0.x for 9.0.2 onwards - 8.5.x for 8.5.24 onwards -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1814568 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/util/buf/StringUtils.java test/org/apache/coyote/http11/TestAbstractHttp11Protocol.java test/org/apache/tomcat/util/buf/TestS
Author: markt Date: Wed Nov 8 11:08:58 2017 New Revision: 1814568 URL: http://svn.apache.org/viewvc?rev=1814568&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61668 Refactor StringUtils to better handle null inputs. Add test cases for bug and all StringUtils methods. Added: tomcat/tc8.5.x/trunk/test/org/apache/coyote/http11/TestAbstractHttp11Protocol.java - copied unchanged from r1814567, tomcat/trunk/test/org/apache/coyote/http11/TestAbstractHttp11Protocol.java tomcat/tc8.5.x/trunk/test/org/apache/tomcat/util/buf/TestStringUtils.java - copied unchanged from r1814567, tomcat/trunk/test/org/apache/tomcat/util/buf/TestStringUtils.java Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/buf/StringUtils.java tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml Propchange: tomcat/tc8.5.x/trunk/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Wed Nov 8 11:08:58 2017 @@ -1,2 +1,2 @@ /tomcat/tc8.0.x/trunk:1809644 -/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739492,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409 ,1741501,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744149,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747 404,1747506,1747536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1 756289,1756408-1756410,1756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-17615
svn commit: r1814567 - in /tomcat/trunk: java/org/apache/tomcat/util/buf/StringUtils.java test/org/apache/coyote/http11/TestAbstractHttp11Protocol.java test/org/apache/tomcat/util/buf/TestStringUtils.
Author: markt
Date: Wed Nov 8 11:06:39 2017
New Revision: 1814567
URL: http://svn.apache.org/viewvc?rev=1814567&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61668
Refactor StringUtils to better handle null inputs.
Add test cases for bug and all StringUtils methods.
Added:
tomcat/trunk/test/org/apache/coyote/http11/TestAbstractHttp11Protocol.java
(with props)
tomcat/trunk/test/org/apache/tomcat/util/buf/TestStringUtils.java (with
props)
Modified:
tomcat/trunk/java/org/apache/tomcat/util/buf/StringUtils.java
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/java/org/apache/tomcat/util/buf/StringUtils.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/buf/StringUtils.java?rev=1814567&r1=1814566&r2=1814567&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/buf/StringUtils.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/buf/StringUtils.java Wed Nov 8
11:06:39 2017
@@ -23,7 +23,8 @@ import java.util.function.Function;
/**
* Utility methods to build a separated list from a given set (not
* java.util.Set) of inputs and return that list as a string or append it to an
- * existing StringBuilder.
+ * existing StringBuilder. If the given set is null or empty, an empty string
+ * will be returned.
*/
public final class StringUtils {
@@ -35,11 +36,17 @@ public final class StringUtils {
public static String join(String[] array) {
+if (array == null) {
+return EMPTY_STRING;
+}
return join(Arrays.asList(array));
}
public static void join(String[] array, char separator, StringBuilder sb) {
+if (array == null) {
+return;
+}
join(Arrays.asList(array), separator, sb);
}
@@ -51,7 +58,7 @@ public final class StringUtils {
public static String join(Collection collection, char separator) {
// Shortcut
-if (collection.isEmpty()) {
+if (collection == null || collection.isEmpty()) {
return EMPTY_STRING;
}
@@ -68,12 +75,18 @@ public final class StringUtils {
public static void join(T[] array, char separator, Function
function,
StringBuilder sb) {
+if (array == null) {
+return;
+}
join(Arrays.asList(array), separator, function, sb);
}
public static void join(Iterable iterable, char separator,
Function function,
StringBuilder sb) {
+if (iterable == null) {
+return;
+}
boolean first = true;
for (T value : iterable) {
if (first) {
Added:
tomcat/trunk/test/org/apache/coyote/http11/TestAbstractHttp11Protocol.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/coyote/http11/TestAbstractHttp11Protocol.java?rev=1814567&view=auto
==
--- tomcat/trunk/test/org/apache/coyote/http11/TestAbstractHttp11Protocol.java
(added)
+++ tomcat/trunk/test/org/apache/coyote/http11/TestAbstractHttp11Protocol.java
Wed Nov 8 11:06:39 2017
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.coyote.http11;
+
+import org.junit.Test;
+
+public class TestAbstractHttp11Protocol {
+
+@Test
+public void testGetSslProtocol() {
+Http11Nio2Protocol protocol = new Http11Nio2Protocol();
+protocol.getSSLProtocol();
+}
+}
Propchange:
tomcat/trunk/test/org/apache/coyote/http11/TestAbstractHttp11Protocol.java
--
svn:eol-style = native
Added: tomcat/trunk/test/org/apache/tomcat/util/buf/TestStringUtils.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/util/buf/TestStringUtils.java?rev=1814567&view=auto
==
--- tomcat/trunk/test/org/apache/tomcat/util/buf/TestStringUtils.java (added)
+++ tomcat/trunk/test/org/apache/tomcat/util/buf/TestStringUtils.java Wed Nov
8 11:06:39 2017
@@ -0,0
svn commit: r1814563 - /tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java
Author: markt
Date: Wed Nov 8 10:08:50 2017
New Revision: 1814563
URL: http://svn.apache.org/viewvc?rev=1814563&view=rev
Log:
Add some Javadoc to silence an Eclipse nag
Modified:
tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java
Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java?rev=1814563&r1=1814562&r2=1814563&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java
(original)
+++ tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java Wed Nov
8 10:08:50 2017
@@ -805,6 +805,14 @@ class Http2UpgradeHandler extends Abstra
}
+/**
+ * Process send file (if supported) for the given stream. The appropriate
+ * request attributes should be set before calling this method.
+ *
+ * @param streamThe stream to process
+ *
+ * @return The result of the send file processing
+ */
protected SendfileState processSendfile(Stream stream) {
return SendfileState.DONE;
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 61524] NullPointerException in Http11OutputBuffer
https://bz.apache.org/bugzilla/show_bug.cgi?id=61524 --- Comment #5 from Mark Thomas --- We still need a (simple) test case for this. My analysis from comment #1 still applies. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 61465] jvm crashed in org.apache.tomcat.util.net.AprEndpoint$Sendfile.run()
https://bz.apache.org/bugzilla/show_bug.cgi?id=61465 Mark Thomas changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEEDINFO|RESOLVED --- Comment #3 from Mark Thomas --- No further feedback after 2 months. I'm assuming that an upgrade fixed this. If not, please re-open this and provide the steps to reproduce. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 61723] The code of method _jspService(HttpServletRequest, HttpServletResponse) is exceeding the 65535 bytes limit
https://bz.apache.org/bugzilla/show_bug.cgi?id=61723 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Mark Thomas --- Changes were made to the way code was generated for JSPs to resolve some bugs (that were also spec compliance issues) with resource clean-up if a tag throws an Exception. We minimised the impact of these as much as we can but the end result is still that the generated code is larger than it was before. There are some useful pointers in this thread. http://markmail.org/thread/5gh57ststsbjqbza Note: trimSpaces - true should be zero impact and might help enablePooling - false is likely to have a negative performance impact -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
