date:20180827

[Bug 62657] Protocol handler destroy failed

2018-08-27 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=62657

--- Comment #3 from quaff  ---
Finally I find it cause by VPN software, but I don't know why tomcat8.0 is not
affected.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 62633] WsSession leaks if cache Session are used for group sending

2018-08-27 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=62633

--- Comment #3 from saiya <1005136...@qq.com> ---
(In reply to Mark Thomas from comment #1)
> The provided sample application does not demonstrate a memory leak in Apache
> Tomcat. WsSession objects are retained while the session is open and
> released once the session is closed.
> 
> The provided sample application does contain several memory leaks due to the
> failure to stop threads.

If I execute the following code in the onClose, I can solve it.

try {
Field wsFrame = WsSession.class.getDeclaredField("wsFrame");
wsFrame.setAccessible(true);
WsFrameServer wsFrameServer = (WsFrameServer)
wsFrame.get(wsSession);

Field socketWrapper =
WsFrameServer.class.getDeclaredField("socketWrapper");
socketWrapper.setAccessible(true);
SocketWrapperBase socketWrapperBase = (SocketWrapperBase)
socketWrapper.get(wsFrameServer);

Field endpoint =
SocketWrapperBase.class.getDeclaredField("endpoint");
endpoint.setAccessible(true);
AbstractEndpoint abstractEndpoint = (AbstractEndpoint)
endpoint.get(socketWrapperBase);
NioEndpoint nioEndpoint = (NioEndpoint)abstractEndpoint;

AbstractEndpoint.Handler handler = nioEndpoint.getHandler();
handler.release(socketWrapperBase);

} catch (IllegalAccessException | NoSuchFieldException e) {
e.printStackTrace();
}

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1839373 - in /tomcat/jk/trunk: native/STATUS.txt native/common/jk_version.h native/configure.ac native/iis/README native/netscape/README tools/dist/binaries/windows/README.html xdocs/misc

2018-08-27 Thread markt

Author: markt
Date: Mon Aug 27 20:50:05 2018
New Revision: 1839373

URL: http://svn.apache.org/viewvc?rev=1839373=rev
Log:
Update version number for next dev cycle

Modified:
tomcat/jk/trunk/native/STATUS.txt
tomcat/jk/trunk/native/common/jk_version.h
tomcat/jk/trunk/native/configure.ac
tomcat/jk/trunk/native/iis/README
tomcat/jk/trunk/native/netscape/README
tomcat/jk/trunk/tools/dist/binaries/windows/README.html
tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml

Modified: tomcat/jk/trunk/native/STATUS.txt
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/STATUS.txt?rev=1839373=1839372=1839373=diff
==
--- tomcat/jk/trunk/native/STATUS.txt (original)
+++ tomcat/jk/trunk/native/STATUS.txt Mon Aug 27 20:50:05 2018
@@ -18,7 +18,8 @@ Last modified at [$Date$]
 
 Release:
 
-1.2.44  : development in progress
+1.2.45  : development in progress
+1.2.44  : release in progress
 1.2.43  : released March 6, 2018
 1.2.42  : released October 5, 2016
 1.2.41  : released August 11, 2015

Modified: tomcat/jk/trunk/native/common/jk_version.h
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/common/jk_version.h?rev=1839373=1839372=1839373=diff
==
--- tomcat/jk/trunk/native/common/jk_version.h (original)
+++ tomcat/jk/trunk/native/common/jk_version.h Mon Aug 27 20:50:05 2018
@@ -26,7 +26,7 @@
 /** START OF AREA TO MODIFY BEFORE RELEASING */
 #define JK_VERMAJOR 1
 #define JK_VERMINOR 2
-#define JK_VERFIX   44
+#define JK_VERFIX   45
 
 /* set JK_VERISRELEASE to 1 when release (do not forget to commit!) */
 #define JK_VERISRELEASE 0

Modified: tomcat/jk/trunk/native/configure.ac
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/configure.ac?rev=1839373=1839372=1839373=diff
==
--- tomcat/jk/trunk/native/configure.ac (original)
+++ tomcat/jk/trunk/native/configure.ac Mon Aug 27 20:50:05 2018
@@ -23,7 +23,7 @@ AC_PREREQ(2.59)
 
 dnl package and version.
 dnl synchronization with common/jk_version.h ?
-AC_INIT([mod_jk], [1.2.44])
+AC_INIT([mod_jk], [1.2.45])
 
 AC_CONFIG_SRCDIR([common/jk_worker.h])
 AC_CONFIG_HEADER(common/config.h)

Modified: tomcat/jk/trunk/native/iis/README
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/iis/README?rev=1839373=1839372=1839373=diff
==
--- tomcat/jk/trunk/native/iis/README (original)
+++ tomcat/jk/trunk/native/iis/README Mon Aug 27 20:50:05 2018
@@ -56,7 +56,7 @@ RELEASING
 
 Construct the binary distributions
 
-  set VER=1.2.44
+  set VER=1.2.45
   mkdir tomcat-connectors-%VER%-windows-i386-iis
   copy ..\LICENSE tomcat-connectors-%VER%-windows-i386-iis\
   copy ..\NOTICE tomcat-connectors-%VER%-windows-i386-iis\

Modified: tomcat/jk/trunk/native/netscape/README
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/netscape/README?rev=1839373=1839372=1839373=diff
==
--- tomcat/jk/trunk/native/netscape/README (original)
+++ tomcat/jk/trunk/native/netscape/README Mon Aug 27 20:50:05 2018
@@ -25,7 +25,7 @@ The steps that you need to take are:
   directory or edit the nsapi.dsp and replace all $(IPLANET_HOME)
   occurrences with the real path
3. Execute the following command:
-  nmake -f Makefile.vc [SO_VERSION=-1.2.44]
+  nmake -f Makefile.vc [SO_VERSION=-1.2.45]
 
 An alternative will be to open the isapi workspace file (nsapi.dsw) in msdev 
and
 build it using the build menu.

Modified: tomcat/jk/trunk/tools/dist/binaries/windows/README.html
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/tools/dist/binaries/windows/README.html?rev=1839373=1839372=1839373=diff
==
--- tomcat/jk/trunk/tools/dist/binaries/windows/README.html (original)
+++ tomcat/jk/trunk/tools/dist/binaries/windows/README.html Mon Aug 27 20:50:05 
2018
@@ -27,7 +27,7 @@
connector to fail.
 
 
-The current stable release is 1.2.44
+The current stable release is 1.2.45
 
 See the Apache Tomcat Connectors
 http://tomcat.apache.org/connectors-doc/miscellaneous/changelog.html;>changelog

Modified: tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml?rev=1839373=1839372=1839373=diff
==
--- tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml (original)
+++ tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml Mon Aug 27 20:50:05 2018
@@ -40,6 +40,8 @@
   new documentation project for JK was started.
   
 
+
+

[Git migration] Documentation

2018-08-27 Thread Mark Thomas

We refer to svn in various places. Main web site, docs, BUILDING.txt etc.

The issue is when do we update the various docs. The main website we can
update whenever, but the version specific docs normally only get updated
when we do a release.

My suggested solution is to do the migration and once we are happy that
the git repo is correct and we formally make it the master then we:
- update the main web site ASAP
- [ANNOUNCE] email to the community
- Release 9.0.x, 8.5.x and 7.0.x ASAP with updated docs that refer to
  git rather than svn.

An added benefit is going through the release process soon after the
migration should highlight any issues (I'm not expecting any) quickly.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [Git migration] Developer process

2018-08-27 Thread Mark Thomas

On 31/05/18 19:16, Igal Sapir wrote:
> On 5/31/2018 3:00 AM, Mark Thomas wrote:
>> Hi,
>>
>> The next issue to resolve for the Git migration is developer process.
>>
>> Note that this does not cover branch names, merge strategy etc. This is
>> issue is about the options available for developers to organise their
>> local development environment. The key question is how to efficiently
>> switch between trunk, 8.5.x and 7.0.x.
>>
>> To some extent this will be personal preference. However, it would be
>> useful to have some recommendations to give folks a starting point.
>>
>> Options discussed previously include:
>> - multiple clones
>> - git worktree
> According to this blog post [1] Git Worktrees are a better solution.  It
> looks like Worktrees were added in order to address the shortfalls of
> maintaining multiple clones.
> 
> There is a warning, however, about using Worktrees on repos that contain
> submodules [2], and I don't know if that applies to the Tomcat repos or
> not, so that's something to look out for.

It has been a while. I'm going to add these two links to the migration
notes on the wiki. Googling "git worktree" returns a bunch of other
posts as well.

Onwards with the migration...

Mark

> 
> Igal
> 
> [1]
> https://spin.atomicobject.com/2016/06/26/parallelize-development-git-worktrees/
> 
> [2]
> https://blog.github.com/2015-07-29-git-2-5-including-multiple-worktrees-and-triangular-workflows/
> 
> 
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 62657] Protocol handler destroy failed

2018-08-27 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=62657

Mark Thomas  changed:

   What|Removed |Added

 OS||All
 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #2 from Mark Thomas  ---
Works for me with Tomact 9.0.11, OSX 10.13.6 and Oracle JDK 1.8.0_181.

This looks like some sort of environmental issue. Please use the users list for
debugging.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 62657] Protocol handler destroy failed

2018-08-27 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=62657

Mark Thomas  changed:

   What|Removed |Added

 OS||Mac OS X 10.13
   Hardware|PC  |Macintosh

--- Comment #1 from Mark Thomas  ---
Update OS/hardware to align with bug description.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release JK 1.2.44

2018-08-27 Thread Rainer Jung


Am 24.08.2018 um 18:56 schrieb Mark Thomas:

Tag:
http://svn.apache.org/viewvc/tomcat/jk/tags/JK_1_2_44/

Source:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/jk/


This is a maintenance release with a handful of bug fixes and some
clean-up. It also includes Windows binaries for IIS.


The proposed JK 1.2.44 release is:
[ ] Broken - do not release
[X] Stable - go ahead and release as 1.2.44


+1 and thanks for RM!

Regards,

Rainer

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: JDK 11: First Release Candidate available

2018-08-27 Thread Rory O'Donnell


Thanks Mark for confirming fix.

Rgds,Rory


On 24/08/2018 18:19, Mark Thomas wrote:

On 24/08/18 10:30, Rory O'Donnell wrote:

Hi Mark,

*JDK 11 build 28 is our first JDK 11 Release Candidate [1]
*

  * JDK 11 Early Access  build 28 is available at : - jdk.java.net/11/

*FOSS fixes in recent builds.*




  * *Apache Tomcat *  -JDK-8208642
    (b27)
  o *Hope you can confirm that all is ok ?*

Confirmed.

Tests that previous failed passed with:

Oracle JDK 11 build 28

OpenJDK 11 build 28

OpenJDK 12 build 8

Thanks for the fix.

Mark


--
Rgds,Rory O'Donnell
Quality Engineering Manager
Oracle EMEA , Dublin, Ireland


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 62657] New: Protocol handler destroy failed

2018-08-27 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=62657

Bug ID: 62657
   Summary: Protocol handler destroy failed
   Product: Tomcat 9
   Version: 9.0.11
  Hardware: PC
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
  Assignee: dev@tomcat.apache.org
  Reporter: zhouyanm...@gmail.com
  Target Milestone: -

I'm trying upgrade tomcat from 8.0.44 to 9.0.11 to resolve #62515, tomcat9 will
throws exception while shutting down with oracle jdk_1.8.0_181 on macbook pro
(macOS 10.13.6), upgrading to jdk_10.0.2 can fix first exception. Both
exception cannot be reproduced on ubuntu. 
step to produce:
1. unzip official distribution package
2. bin/startup.sh
3. bin/shutdown.sh

It will produce:
27-Aug-2018 16:26:07.632 INFO [main]
org.apache.catalina.core.StandardServer.await A valid shutdown command was
received via the shutdown port. Stopping the Server instance.
27-Aug-2018 16:26:07.633 INFO [main] org.apache.coyote.AbstractProtocol.pause
Pausing ProtocolHandler ["http-nio-8080"]
27-Aug-2018 16:26:07.638 INFO [main] org.apache.coyote.AbstractProtocol.pause
Pausing ProtocolHandler ["ajp-nio-8009"]
27-Aug-2018 16:26:07.639 INFO [main]
org.apache.catalina.core.StandardService.stopInternal Stopping service
[Catalina]
27-Aug-2018 16:26:07.652 INFO [main] org.apache.coyote.AbstractProtocol.stop
Stopping ProtocolHandler ["http-nio-8080"]
27-Aug-2018 16:26:07.655 INFO [main] org.apache.coyote.AbstractProtocol.stop
Stopping ProtocolHandler ["ajp-nio-8009"]
27-Aug-2018 16:26:07.656 INFO [main] org.apache.coyote.AbstractProtocol.destroy
Destroying ProtocolHandler ["http-nio-8080"]
27-Aug-2018 16:26:07.657 SEVERE [main]
org.apache.catalina.util.LifecycleBase.handleSubClassException Failed to
destroy component [Connector[HTTP/1.1-8080]]
 org.apache.catalina.LifecycleException: Protocol handler destroy failed
at
org.apache.catalina.connector.Connector.destroyInternal(Connector.java:994)
at
org.apache.catalina.util.LifecycleBase.destroy(LifecycleBase.java:322)
at
org.apache.catalina.core.StandardService.destroyInternal(StandardService.java:546)
at
org.apache.catalina.util.LifecycleBase.destroy(LifecycleBase.java:322)
at
org.apache.catalina.core.StandardServer.destroyInternal(StandardServer.java:860)
at
org.apache.catalina.util.LifecycleBase.destroy(LifecycleBase.java:322)
at org.apache.catalina.startup.Catalina.stop(Catalina.java:756)
at org.apache.catalina.startup.Catalina.start(Catalina.java:717)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:350)
at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:492)
Caused by: java.io.IOException: Thread signal failed
at sun.nio.ch.NativeThread.signal(Native Method)
at
sun.nio.ch.ServerSocketChannelImpl.implCloseSelectableChannel(ServerSocketChannelImpl.java:292)
at
java.nio.channels.spi.AbstractSelectableChannel.implCloseChannel(AbstractSelectableChannel.java:234)
at
java.nio.channels.spi.AbstractInterruptibleChannel.close(AbstractInterruptibleChannel.java:115)
at sun.nio.ch.ServerSocketAdaptor.close(ServerSocketAdaptor.java:137)
at
org.apache.tomcat.util.net.NioEndpoint.doCloseServerSocket(NioEndpoint.java:348)
at org.apache.tomcat.util.net.NioEndpoint.unbind(NioEndpoint.java:331)
at
org.apache.tomcat.util.net.AbstractEndpoint.destroy(AbstractEndpoint.java:1165)
at
org.apache.coyote.AbstractProtocol.destroy(AbstractProtocol.java:611)
at
org.apache.catalina.connector.Connector.destroyInternal(Connector.java:990)
... 13 more

27-Aug-2018 16:26:07.658 INFO [main] org.apache.coyote.AbstractProtocol.destroy
Destroying ProtocolHandler ["ajp-nio-8009"]

If I set bindOnInit="false" on Connector, It will produce:
27-Aug-2018 16:33:21.753 INFO [main]
org.apache.catalina.core.StandardServer.await A valid shutdown command was
received via the shutdown port. Stopping the Server instance.
27-Aug-2018 16:33:21.753 INFO [main] org.apache.coyote.AbstractProtocol.pause
Pausing ProtocolHandler ["http-nio-8080"]
27-Aug-2018 16:33:21.760 SEVERE [http-nio-8080-Acceptor-0]
org.apache.tomcat.util.net.Acceptor.run Socket accept failed
 java.nio.channels.AsynchronousCloseException
at
java.nio.channels.spi.AbstractInterruptibleChannel.end(AbstractInterruptibleChannel.java:205)
at
sun.nio.ch.ServerSocketChannelImpl.accept(ServerSocketChannelImpl.java:257)
at
org.apache.tomcat.util.net.NioEndpoint.serverSocketAccept(NioEndpoint.java:446)
at

[Bug 62657] Protocol handler destroy failed

[Bug 62633] WsSession leaks if cache Session are used for group sending

svn commit: r1839373 - in /tomcat/jk/trunk: native/STATUS.txt native/common/jk_version.h native/configure.ac native/iis/README native/netscape/README tools/dist/binaries/windows/README.html xdocs/misc

[Git migration] Documentation

Re: [Git migration] Developer process

[Bug 62657] Protocol handler destroy failed

[Bug 62657] Protocol handler destroy failed

Re: [VOTE] Release JK 1.2.44

Re: JDK 11: First Release Candidate available

[Bug 62657] New: Protocol handler destroy failed

10 matches

Site Navigation

Mail list logo

Footer information