svn commit: r1843361 - /tomcat/trunk/build.xml

2018-10-09 Thread remm
Author: remm Date: Tue Oct 9 22:44:05 2018 New Revision: 1843361 URL: http://svn.apache.org/viewvc?rev=1843361=rev Log: Fix ant javadoc. Modified: tomcat/trunk/build.xml Modified: tomcat/trunk/build.xml URL:

[Bug 62748] Add support for TLS 1.3 (RFC 8446)

2018-10-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62748 --- Comment #20 from Christopher Schultz --- Using OpenJDK 11, a simple https:// protocol test works for both configurations "TLSv1.2+TLSv1.3" and simply "TLSv1.3". In the former case, Firefox/Chrome connect using TLSv1.2. For the latter case,

[Bug 62748] Add support for TLS 1.3 (RFC 8446)

2018-10-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62748 --- Comment #19 from Michael Osipov --- Try sslscan(1), it can also do an HTTP request: https://github.com/rbsec/sslscan -- You are receiving this mail because: You are the assignee for the bug.

[Bug 62748] Add support for TLS 1.3 (RFC 8446)

2018-10-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62748 --- Comment #18 from Christopher Schultz --- When using my ssltest tool[1] with OpenJDK 11, I get the following output when configured with protocols="TLSv1.2+TLSv1.3": Host [localhost] resolves to addresses [127.0.0.1], [0:0:0:0:0:0:0:1]

[Bug 62748] Add support for TLS 1.3 (RFC 8446)

2018-10-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62748 --- Comment #17 from Christopher Schultz --- A quick test with Firefox 62 and Chrome 69 shows that they are still connecting using TLSv1.2. -- You are receiving this mail because: You are the assignee for the bug.

[Bug 62748] Add support for TLS 1.3 (RFC 8446)

2018-10-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62748 --- Comment #16 from Christopher Schultz --- A quick smoke-test using openssl appears to work. -- You are receiving this mail because: You are the assignee for the bug. - To

svn commit: r1843334 - in /tomcat/trunk/java/org/apache: catalina/tribes/membership/cloud/CertificateStreamProvider.java tomcat/util/net/jsse/PEMFile.java

2018-10-09 Thread remm
Author: remm Date: Tue Oct 9 19:27:09 2018 New Revision: 1843334 URL: http://svn.apache.org/viewvc?rev=1843334=rev Log: Fix use of client key algorithm parameter. Modified: tomcat/trunk/java/org/apache/catalina/tribes/membership/cloud/CertificateStreamProvider.java

Re: svn commit: r1843328 - /tomcat/trunk/java/org/apache/catalina/tribes/membership/cloud/CertificateStreamProvider.java

2018-10-09 Thread Rémy Maucherat
On Tue, Oct 9, 2018 at 9:05 PM Mark Thomas wrote: > On 09/10/18 19:58, Rémy Maucherat wrote: > > On Tue, Oct 9, 2018 at 8:56 PM Mark Thomas wrote: > > > >> On 09/10/18 19:55, ma...@apache.org wrote: > >>> Author: markt > >>> Date: Tue Oct 9 18:55:17 2018 > >>> New Revision: 1843328 > >>> > >>>

svn commit: r1843330 - in /tomcat/trunk/java/org/apache: catalina/tribes/membership/cloud/CloudMembershipService.java naming/factory/LookupFactory.java tomcat/dbcp/dbcp2/managed/BasicManagedDataSource

2018-10-09 Thread markt
Author: markt Date: Tue Oct 9 19:15:38 2018 New Revision: 1843330 URL: http://svn.apache.org/viewvc?rev=1843330=rev Log: Fix a few deprecation warnings when compiling with Java 11 (others remain that are harder to fix). Modified:

svn commit: r1843329 - /tomcat/trunk/java/org/apache/catalina/tribes/membership/cloud/CertificateStreamProvider.java

2018-10-09 Thread markt
Author: markt Date: Tue Oct 9 19:07:25 2018 New Revision: 1843329 URL: http://svn.apache.org/viewvc?rev=1843329=rev Log: Revert previous change. It will break with the defaults. Modified: tomcat/trunk/java/org/apache/catalina/tribes/membership/cloud/CertificateStreamProvider.java

Re: svn commit: r1843328 - /tomcat/trunk/java/org/apache/catalina/tribes/membership/cloud/CertificateStreamProvider.java

2018-10-09 Thread Mark Thomas
On 09/10/18 19:58, Rémy Maucherat wrote: > On Tue, Oct 9, 2018 at 8:56 PM Mark Thomas wrote: > >> On 09/10/18 19:55, ma...@apache.org wrote: >>> Author: markt >>> Date: Tue Oct 9 18:55:17 2018 >>> New Revision: 1843328 >>> >>> URL: http://svn.apache.org/viewvc?rev=1843328=rev >>> Log: >>> Fix

Re: svn commit: r1843328 - /tomcat/trunk/java/org/apache/catalina/tribes/membership/cloud/CertificateStreamProvider.java

2018-10-09 Thread Rémy Maucherat
On Tue, Oct 9, 2018 at 8:56 PM Mark Thomas wrote: > On 09/10/18 19:55, ma...@apache.org wrote: > > Author: markt > > Date: Tue Oct 9 18:55:17 2018 > > New Revision: 1843328 > > > > URL: http://svn.apache.org/viewvc?rev=1843328=rev > > Log: > > Fix unused code warning > > My IDE popped up a

Re: svn commit: r1843328 - /tomcat/trunk/java/org/apache/catalina/tribes/membership/cloud/CertificateStreamProvider.java

2018-10-09 Thread Mark Thomas
On 09/10/18 19:55, ma...@apache.org wrote: > Author: markt > Date: Tue Oct 9 18:55:17 2018 > New Revision: 1843328 > > URL: http://svn.apache.org/viewvc?rev=1843328=rev > Log: > Fix unused code warning My IDE popped up a warning that this parameter was unused. I think I have fixed this

svn commit: r1843328 - /tomcat/trunk/java/org/apache/catalina/tribes/membership/cloud/CertificateStreamProvider.java

2018-10-09 Thread markt
Author: markt Date: Tue Oct 9 18:55:17 2018 New Revision: 1843328 URL: http://svn.apache.org/viewvc?rev=1843328=rev Log: Fix unused code warning Modified: tomcat/trunk/java/org/apache/catalina/tribes/membership/cloud/CertificateStreamProvider.java Modified:

svn commit: r1843327 - in /tomcat/trunk/java/org/apache/catalina/tribes/membership/cloud: AbstractStreamProvider.java CloudMembershipService.java InsecureStreamProvider.java

2018-10-09 Thread markt
Author: markt Date: Tue Oct 9 18:53:53 2018 New Revision: 1843327 URL: http://svn.apache.org/viewvc?rev=1843327=rev Log: Fix IDE warnings Modified: tomcat/trunk/java/org/apache/catalina/tribes/membership/cloud/AbstractStreamProvider.java

svn commit: r1843325 - /tomcat/trunk/res/checkstyle/org-import-control.xml

2018-10-09 Thread markt
Author: markt Date: Tue Oct 9 18:50:56 2018 New Revision: 1843325 URL: http://svn.apache.org/viewvc?rev=1843325=rev Log: Modify import controls so they do not overlap which prevents the reversal of deny/allow ordering from causing failures in Gump which uses the latest Checkstyle code

svn commit: r1843315 - in /tomcat/trunk/java/org/apache/tomcat/util/json: JSONParser.java JSONParserTokenManager.java JavaCharStream.java ParseException.java Token.java TokenMgrError.java

2018-10-09 Thread markt
Author: markt Date: Tue Oct 9 17:37:23 2018 New Revision: 1843315 URL: http://svn.apache.org/viewvc?rev=1843315=rev Log: Silence IDE warnings Modified: tomcat/trunk/java/org/apache/tomcat/util/json/JSONParser.java tomcat/trunk/java/org/apache/tomcat/util/json/JSONParserTokenManager.java

[Bug 62748] Add support for TLS 1.3 (RFC 8446)

2018-10-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62748 --- Comment #15 from Mark Thomas --- I've applied those patches with some minor modifications to: - fix the problem described in bug 62794 - ensure that the a warning is displayed when explicitly configuring TLSv1.3 but TLSv1.3 is not

Re: [Bug 62794] Tomcat request-read fails when using TLSv1.3 with APR connector

2018-10-09 Thread Mark Thomas
On 09/10/18 18:25, bugzi...@apache.org wrote: > https://bz.apache.org/bugzilla/show_bug.cgi?id=62794 > > Mark Thomas changed: > >What|Removed |Added > > Status|NEW

[Bug 62748] Add support for TLS 1.3 (RFC 8446)

2018-10-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62748 Mark Thomas changed: What|Removed |Added CC||ch...@christopherschultz.ne

[Bug 62794] Tomcat request-read fails when using TLSv1.3 with APR connector

2018-10-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62794 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1843314 - in /tomcat/trunk: java/org/apache/tomcat/jni/ java/org/apache/tomcat/util/net/ java/org/apache/tomcat/util/net/jsse/ java/org/apache/tomcat/util/net/openssl/ webapps/docs/ webap

2018-10-09 Thread markt
Author: markt Date: Tue Oct 9 17:23:48 2018 New Revision: 1843314 URL: http://svn.apache.org/viewvc?rev=1843314=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62748 Add TLS 1.3 support (CLIENT-CERT untested) Modified: tomcat/trunk/java/org/apache/tomcat/jni/SSL.java

svn commit: r1843313 - in /tomcat/native/trunk: native/include/ssl_private.h native/src/sslcontext.c native/src/sslutils.c xdocs/miscellaneous/changelog.xml

2018-10-09 Thread markt
Author: markt Date: Tue Oct 9 17:19:33 2018 New Revision: 1843313 URL: http://svn.apache.org/viewvc?rev=1843313=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62748 Add TLS 1.3 support (CLIENT-CERT untested) Modified: tomcat/native/trunk/native/include/ssl_private.h

svn commit: r1843309 [2/2] - in /tomcat/trunk: ./ java/org/apache/catalina/tribes/membership/cloud/ java/org/apache/tomcat/util/json/ res/checkstyle/ webapps/docs/

2018-10-09 Thread remm
Added: tomcat/trunk/java/org/apache/tomcat/util/json/JavaCharStream.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/json/JavaCharStream.java?rev=1843309=auto == ---

svn commit: r1843309 [1/2] - in /tomcat/trunk: ./ java/org/apache/catalina/tribes/membership/cloud/ java/org/apache/tomcat/util/json/ res/checkstyle/ webapps/docs/

2018-10-09 Thread remm
Author: remm Date: Tue Oct 9 16:36:54 2018 New Revision: 1843309 URL: http://svn.apache.org/viewvc?rev=1843309=rev Log: Switch from Noggit to a javacc parser generated from a public domain json grammar. Added: tomcat/trunk/java/org/apache/tomcat/util/json/

Re: SVN Workflow and Backporting

2018-10-09 Thread Igal Sapir
On Tue, Oct 9, 2018 at 2:31 AM Mark Thomas wrote: > On 09/10/18 05:55, Igal Sapir wrote: > > On Mon, Oct 8, 2018 at 3:04 AM Mark Thomas wrote: > > > >> On 06/10/18 23:08, Igal Sapir wrote: > >>> I am rather new to SVN, and actually use it mostly via GIT, i.e. `git > svn > >>> rebase` and `git

Re: Setting up dev environment

2018-10-09 Thread Harsha Suranjith Amarasiri
Thanks Violeta , Marek, I want to contribute to Tomcat project, therefore I want to setup the development environment and learn the internals. For dependency management and build process I have always used Maven and Gradle, therefore Ant is kind of new to me. However I figured out what's

buildbot failure in on tomcat-trunk

2018-10-09 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/3634 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

Re: svn commit: r1843285 - in /tomcat/trunk: TOMCAT-NEXT.txt build.properties.default build.xml java/org/apache/catalina/tribes/membership/cloud/KubernetesMembershipProvider.java res/checkstyle/org-im

2018-10-09 Thread Rémy Maucherat
On Tue, Oct 9, 2018 at 3:56 PM wrote: > Author: remm > Date: Tue Oct 9 13:56:25 2018 > New Revision: 1843285 > > URL: http://svn.apache.org/viewvc?rev=1843285=rev > Log: > Switch from OpenJSON to Noggit. > > Modified: > tomcat/trunk/TOMCAT-NEXT.txt >

svn commit: r1843285 - in /tomcat/trunk: TOMCAT-NEXT.txt build.properties.default build.xml java/org/apache/catalina/tribes/membership/cloud/KubernetesMembershipProvider.java res/checkstyle/org-import

2018-10-09 Thread remm
Author: remm Date: Tue Oct 9 13:56:25 2018 New Revision: 1843285 URL: http://svn.apache.org/viewvc?rev=1843285=rev Log: Switch from OpenJSON to Noggit. Modified: tomcat/trunk/TOMCAT-NEXT.txt tomcat/trunk/build.properties.default tomcat/trunk/build.xml

[Bug 62748] Add support for TLS 1.3 (RFC 8446)

2018-10-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62748 --- Comment #13 from Mark Thomas --- Note that it is likely that additional patches will be required to get CLIENT_CERT working. -- You are receiving this mail because: You are the assignee for the bug.

Re: Setting up dev environment

2018-10-09 Thread Marek Czernek
Hi, What are you trying to achieve? If you want to develop Tomcat source code, i.e. debug/develop code that will be a part of the Tomcat code base, then as Violeta suggested, you could use the ant command (or simply import Tomcat source code into Idea and build/run the code via command

[Bug 62794] Tomcat request-read fails when using TLSv1.3 with APR connector

2018-10-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62794 --- Comment #1 from Mark Thomas --- I have found the problem. It is related to how Tomcat Native tracks the renegotiation status and that TLS 1.3 doesn't use renegotiation. I have a working fix. I am currently reviewing the overall patch and

Re: Setting up dev environment

2018-10-09 Thread Violeta Georgieva
Hi, На вт, 9.10.2018 г. в 11:58 ч. Harsha Suranjith Amarasiri < harshasuranj...@gmail.com> написа: > > Hi all, > > I need to set up tomcat development environment on Intellij Idea running on > Windows 10 - 64 bit OS. > > I have searched, searched and searched and I cannot find a resource that >

Re: svn commit: r1842849 - in /tomcat/trunk: java/org/apache/tomcat/jni/Library.java test/org/apache/tomcat/util/net/TesterSupport.java test/org/apache/tomcat/util/net/openssl/TestOpenSSLConf.java

2018-10-09 Thread Mark Thomas
On 09/10/18 07:04, Igal Sapir wrote: > Mark, > > On Mon, Oct 8, 2018 at 2:52 AM Mark Thomas wrote: > >> On 05/10/18 19:46, Christopher Schultz wrote: >> > +1 a lack of { } is too big a possible bug source to ignore. >>> I just tried enabling the CheckStyle test for this. There were

[Bug 62808] "function-signature" text containing line breaks causes JasperException

2018-10-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62808 --- Comment #1 from Mark Thomas --- There was a regression in 7.0.91 that is fixed for 7.0.92 in this area. I suspect this is the same issue but need to test it to be sure. -- You are receiving this mail because: You are the assignee for the

Re: SVN Workflow and Backporting

2018-10-09 Thread Mark Thomas
On 09/10/18 05:55, Igal Sapir wrote: > On Mon, Oct 8, 2018 at 3:04 AM Mark Thomas wrote: > >> On 06/10/18 23:08, Igal Sapir wrote: >>> I am rather new to SVN, and actually use it mostly via GIT, i.e. `git svn >>> rebase` and `git svn dcommit`. >>> >>> What is the best way to backport specific

svn commit: r1843232 - in /tomcat/trunk: java/org/apache/catalina/tribes/membership/cloud/KubernetesMembershipProvider.java test/org/apache/catalina/tribes/membership/cloud/ test/org/apache/catalina/t

2018-10-09 Thread remm
Author: remm Date: Tue Oct 9 09:21:51 2018 New Revision: 1843232 URL: http://svn.apache.org/viewvc?rev=1843232=rev Log: Refactor to add a json test. The json isn't a separate text file since I cannot put the license text in it. Added:

Re: [GUMP@vmgump-vm3]: Project tomcat-trunk (in module tomcat-trunk) failed

2018-10-09 Thread Rémy Maucherat
On Tue, Oct 9, 2018 at 4:45 AM Bill Barker wrote: > The following work was performed: > > http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk/gump_work/build_tomcat-trunk_tomcat-trunk.html > Work Name: build_tomcat-trunk_tomcat-trunk (Type: Build) > Work ended in a state of : Failed >

Setting up dev environment

2018-10-09 Thread Harsha Suranjith Amarasiri
Hi all, I need to set up tomcat development environment on Intellij Idea running on Windows 10 - 64 bit OS. I have searched, searched and searched and I cannot find a resource that will help me accomplish that. Also is there a developer quickstart for tomcat project ? It would be massively

[Bug 62150] Behavior of relative paths with RequestDispatcher has changed

2018-10-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62150 Manish Kumar Sharma changed: What|Removed |Added CC||manishks...@gmail.com -- You

[Bug 62809] New: cannot remote deploy with Ant DeployTask

2018-10-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62809 Bug ID: 62809 Summary: cannot remote deploy with Ant DeployTask Product: Tomcat 9 Version: 9.0.12 Hardware: PC Status: NEW Severity: normal Priority: P2

Re: SVN Workflow and Backporting

2018-10-09 Thread Rainer Jung
Am 09.10.2018 um 06:55 schrieb Igal Sapir: On Mon, Oct 8, 2018 at 3:04 AM Mark Thomas wrote: On 06/10/18 23:08, Igal Sapir wrote: I am rather new to SVN, and actually use it mostly via GIT, i.e. `git svn rebase` and `git svn dcommit`. What is the best way to backport specific patches from

Re: svn commit: r1842849 - in /tomcat/trunk: java/org/apache/tomcat/jni/Library.java test/org/apache/tomcat/util/net/TesterSupport.java test/org/apache/tomcat/util/net/openssl/TestOpenSSLConf.java

2018-10-09 Thread Igal Sapir
Mark, On Mon, Oct 8, 2018 at 2:52 AM Mark Thomas wrote: > On 05/10/18 19:46, Christopher Schultz wrote: > > >>> +1 a lack of { } is too big a possible bug source to ignore. > > > >> I just tried enabling the CheckStyle test for this. There were > >> just under three thousand errors. > > > >>