[Bug 62273] Add support for alternate URL specification

2018-11-19 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62273

--- Comment #31 from sureshkarthiece  ---
(In reply to Christopher Schultz from comment #15)
> (In reply to Trevor Robinson from comment #14)
> > This is not acceptable to be put into a bugfix version.
> 
> Um... this should UN-BREAK things, not break things. I don't think you want
> to wait until Tomcat 10 for your brackets to start working again, do you?

Any progress going on to support square brackets in tomcat?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] tomcat issue #134: Display generate date when showing every message in Html ...

2018-11-19 Thread rmaucher
Github user rmaucher commented on the issue:

https://github.com/apache/tomcat/pull/134
  
Correct, this doesn't give the right info, I thought it did. Still not that 
convinced though, you don't see that kind of timestamp often (if at all), right 
?


---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GUMP@vmgump-vm3]: Project tomcat-trunk-test-nio (in module tomcat-trunk) failed

2018-11-19 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-test-nio has an issue affecting its community integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-test-nio :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...


Full details are available at:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-test-nio/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on bnd exists, no need to add for property bndlib.jar.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/logs-NIO
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO/logs]



The following work was performed:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-test-nio/gump_work/build_tomcat-trunk_tomcat-trunk-test-nio.html
Work Name: build_tomcat-trunk_tomcat-trunk-test-nio (Type: Build)
Work ended in a state of : Failed
Elapsed: 23 mins 29 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only -Dsun.zip.disableMemoryMapping=true 
org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Djava.net.preferIPv4Stack=/srv/gump/public/workspace/tomcat-trunk/true 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-3.1-SNAPSHOT.jar
 -Dtest.reports=output/logs-NIO -Dexecute.test.nio2=false 
-Dexamples.sources.skip=true 
-Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.7.3a-201803300640/ecj-4.7.3a.jar
 -Dbndlib.jar=/srv/gump/packages/bnd/bndlib-4.0.0/biz.aQute.bndlib-4.0.0.jar 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/target/commons-daemon-1.1.1-SNAPSHOT.jar
 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-master/dest-20181119/bin/openssl
 -Dtest.temp=output/test-tmp-NIO 
 -Dtest.accesslog=true -Dexecute.test.nio=true 
-Dbnd.jar=/srv/gump/packages/bnd/bnd-4.0.0/biz.aQute.bnd-4.0.0.jar 
-Dexecute.test.apr=false -Dtest.excludePerformance=true -Dtest.relaxTiming=true 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-4.1-SNAPSHOT.jar
 -Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jaspic-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-trunk/output

[GitHub] tomcat issue #134: Display generate date when showing every message in Html ...

2018-11-19 Thread michael-o
Github user michael-o commented on the issue:

https://github.com/apache/tomcat/pull/134
  
> How I can get the "Date" header without reloading the page when the 
DevTools are closed (by default)?

As far as I can see, you can't

> Doesn't the "Modified" section in "Right-click + Pageinfo" in Firefox 
shows every time a different date ?
If yes, then I can's see how it's helpfull.

Correct, that information is quite pointless.

> I think I don't get why someone would like to checksum the response of 
Html Manager - can you give some examples?

While this is correct, we don't know what people are doing with the manager.


---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1846928 - /tomcat/trunk/java/org/apache/jasper/JspC.java

2018-11-19 Thread markt
Author: markt
Date: Mon Nov 19 17:26:00 2018
New Revision: 1846928

URL: http://svn.apache.org/viewvc?rev=1846928&view=rev
Log:
The docBase is required and has been for ~15 years (r305684)

Modified:
tomcat/trunk/java/org/apache/jasper/JspC.java

Modified: tomcat/trunk/java/org/apache/jasper/JspC.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/JspC.java?rev=1846928&r1=1846927&r2=1846928&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/JspC.java (original)
+++ tomcat/trunk/java/org/apache/jasper/JspC.java Mon Nov 19 17:26:00 2018
@@ -1769,7 +1769,7 @@ public class JspC extends Task implement
 /**
  * Find the WEB-INF dir by looking up in the directory tree.
  * This is used if no explicit docbase is set, but only files.
- * XXX Maybe we should require the docbase.
+ *
  * @param f The path from which it will start looking
  */
 protected void locateUriRoot( File f ) {
@@ -1804,8 +1804,7 @@ public class JspC extends Task implement
 }
 
 // If there is no acceptable candidate, uriRoot will
-// remain null to indicate to the CompilerContext to
-// use the current working/user dir.
+// remain null.
 }
 
 if (uriRoot != null) {
@@ -1814,9 +1813,7 @@ public class JspC extends Task implement
 }
 }
 } catch (IOException ioe) {
-// since this is an optional default and a null value
-// for uriRoot has a non-error meaning, we can just
-// pass straight through
+// Missing uriRoot will be handled in the caller.
 }
 }
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1846901 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/coyote/http2/LocalStrings.properties

2018-11-19 Thread remm
Author: remm
Date: Mon Nov 19 14:40:15 2018
New Revision: 1846901

URL: http://svn.apache.org/viewvc?rev=1846901&view=rev
Log:
Fix bad replacement

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/java/org/apache/coyote/http2/LocalStrings.properties

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Nov 19 14:40:15 2018
@@ -1,2 +1,2 @@
 /tomcat/tc8.0.x/trunk:1809644
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739492,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409
 
,1741501,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744149,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747
 
404,1747506,1747536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1
 
756289,1756408-1756410,1756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-176205
 
3,1762123,1762168,1762172,1762182,1762201-1762202,1762204,1762208,1762288,1762296,1762324,1762348,1762353,1762362,1762374,1762492,1762503,1762505,1762541,1762608,1762710,1762753,1762766,1762769,1762944,1762947,1762953,1763167,1763179,1763232,1763259,1763271-1763272,1763276-1763277,1763319-1763320,1763370,1763372,1763375,1763377,1763393,1763412,1763430,1763450,1763462,1763505,1763511-1763512,1763516,1763518,1763520,1763529,1763559,1763565,1763568,1763574,1763619,1763634-1763635,176

svn commit: r1846900 - /tomcat/trunk/java/org/apache/coyote/http2/LocalStrings.properties

2018-11-19 Thread remm
Author: remm
Date: Mon Nov 19 14:39:32 2018
New Revision: 1846900

URL: http://svn.apache.org/viewvc?rev=1846900&view=rev
Log:
Fix bad replacement

Modified:
tomcat/trunk/java/org/apache/coyote/http2/LocalStrings.properties

Modified: tomcat/trunk/java/org/apache/coyote/http2/LocalStrings.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http2/LocalStrings.properties?rev=1846900&r1=1846899&r2=1846900&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http2/LocalStrings.properties [UTF-8] 
(original)
+++ tomcat/trunk/java/org/apache/coyote/http2/LocalStrings.properties [UTF-8] 
Mon Nov 19 14:39:32 2018
@@ -69,7 +69,7 @@ http2Parser.processFramePushPromise=Conn
 http2Parser.processFrameSettings.ackWithNonZeroPayload=Settings frame received 
with the ACK flag set and payload present
 http2Parser.processFrameSettings.invalidPayloadSize=Settings frame received 
with a payload size of [{0}] which is not a multiple of 6
 http2Parser.processFrameWindowUpdate.debug=Connection [{0}], Stream [{1}], 
Window size increment [{2}]
-http2Parser.processFrameWindowUpdate.invalidIncrement=Window update frame 
received with an invalid increment size of [0]
+http2Parser.processFrameWindowUpdate.invalidIncrement=Window update frame 
received with an invalid increment size of [{0}]
 http2Parser.processFrameWindowUpdate.invalidPayloadSize=Window update frame 
received with an invalid payload size of [{0}]
 http2Parser.swallow.debug=Connection [{0}], Stream [{1}], Swallowed [{2}] bytes
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] tomcat issue #134: Display generate date when showing every message in Html ...

2018-11-19 Thread ljader
Github user ljader commented on the issue:

https://github.com/apache/tomcat/pull/134
  
Thank you all for the comments - could you help me with getting them right?

1. How I can get the "Date" header without reloading the page when the 
DevTools are **closed** (by default)?

2. Doesn't the "Modified" section in "Right-click + Pageinfo" in Firefox 
shows **every time a different** date ?
If yes, then I can's see how it's helpfull.

3. I think I don't get why someone would like to checksum the response of 
Html Manager - can you give some examples? Isn't the `manager/text` designed to 
automate?

Thinking about my 3rd question, I want to clarify that my change only 
affects (or what I originaly intended)
is to change only the `manager/html` - NOT the `manager/text`


---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62924] tomcat-users.xml has open file descriptors and opens tomcat-users.xml all the time

2018-11-19 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62924

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from Mark Thomas  ---
Thanks for the report.

Fixed in:
- trunk for 9.0.14 onwards

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1846892 - in /tomcat/trunk: java/org/apache/catalina/users/LocalStrings.properties java/org/apache/catalina/users/MemoryUserDatabase.java webapps/docs/changelog.xml

2018-11-19 Thread markt
Author: markt
Date: Mon Nov 19 11:52:26 2018
New Revision: 1846892

URL: http://svn.apache.org/viewvc?rev=1846892&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=62928
Fix file descriptor leak introduced in the code that monitors tomcat-users.xml 
for modifications.

Modified:
tomcat/trunk/java/org/apache/catalina/users/LocalStrings.properties
tomcat/trunk/java/org/apache/catalina/users/MemoryUserDatabase.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/catalina/users/LocalStrings.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/users/LocalStrings.properties?rev=1846892&r1=1846891&r2=1846892&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/users/LocalStrings.properties [UTF-8] 
(original)
+++ tomcat/trunk/java/org/apache/catalina/users/LocalStrings.properties [UTF-8] 
Mon Nov 19 11:52:26 2018
@@ -13,6 +13,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+memoryUserDatabase.fileClose=Failed to close [{0}]
 memoryUserDatabase.fileDelete=Failed to delete [{0}]
 memoryUserDatabase.fileNotFound=The specified user database [{0}] could not be 
found
 memoryUserDatabase.notPersistable=User database is not persistable - no write 
permissions on directory

Modified: tomcat/trunk/java/org/apache/catalina/users/MemoryUserDatabase.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/users/MemoryUserDatabase.java?rev=1846892&r1=1846891&r2=1846892&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/users/MemoryUserDatabase.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/users/MemoryUserDatabase.java Mon Nov 
19 11:52:26 2018
@@ -653,9 +653,10 @@ public class MemoryUserDatabase implemen
 }
 
 URI uri = ConfigFileLoader.getSource().getURI(getPathname());
+URLConnection uConn = null;
 try {
 URL url = uri.toURL();
-URLConnection uConn = url.openConnection();
+uConn = url.openConnection();
 
 if (this.lastModified != uConn.getLastModified()) {
 writeLock.lock();
@@ -675,6 +676,15 @@ public class MemoryUserDatabase implemen
 }
 } catch (Exception ioe) {
 log.error(sm.getString("memoryUserDatabase.reloadError", id, uri), 
ioe);
+} finally {
+if (uConn != null) {
+try {
+// Can't close a uConn directly. Have to do it like this.
+uConn.getInputStream().close();
+} catch (IOException ioe) {
+log.warn(sm.getString("memoryUserDatabase.fileClose", 
pathname), ioe);
+}
+}
 }
 }
 

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1846892&r1=1846891&r2=1846892&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Mon Nov 19 11:52:26 2018
@@ -100,6 +100,10 @@
   
 Fix more storeconfig issues with duplicated SSL attributes. (remm)
   
+  
+62924: Fix file descriptor leak introduced in the code that
+monitors tomcat-users.xml for modifications. (markt)
+  
 
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62924] tomcat-users.xml has open file descriptors and opens tomcat-users.xml all the time

2018-11-19 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62924

--- Comment #3 from Remy Maucherat  ---
There is nothing that can be closed here, and the URL is a regular file URL.
However, calling getLastModified on it indeed leaks a descriptor. There's a
problem somewhere and more investigation is needed, but this is odd.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] tomcat issue #134: Display generate date when showing every message in Html ...

2018-11-19 Thread markt-asf
Github user markt-asf commented on the issue:

https://github.com/apache/tomcat/pull/134
  
How easy it is to get hold of the last modified date does vary by browser 
but - given that Tomcat already provides this in the headers - I don't see much 
benefit here. And micheal-o's comment on checksumming is a valid one.


---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1846889 - in /tomcat/trunk: res/ide-support/eclipse/eclipse.classpath res/ide-support/idea/tomcat.iml res/ide-support/netbeans/nb-tomcat-build.properties res/ide-support/netbeans/project.

2018-11-19 Thread markt
Author: markt
Date: Mon Nov 19 09:31:14 2018
New Revision: 1846889

URL: http://svn.apache.org/viewvc?rev=1846889&view=rev
Log:
Update ECJ dependency in IDE support files.
Patch provided by Lukasz Jader
This closes #133

Modified:
tomcat/trunk/res/ide-support/eclipse/eclipse.classpath
tomcat/trunk/res/ide-support/idea/tomcat.iml
tomcat/trunk/res/ide-support/netbeans/nb-tomcat-build.properties
tomcat/trunk/res/ide-support/netbeans/project.xml
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/res/ide-support/eclipse/eclipse.classpath
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/res/ide-support/eclipse/eclipse.classpath?rev=1846889&r1=1846888&r2=1846889&view=diff
==
--- tomcat/trunk/res/ide-support/eclipse/eclipse.classpath (original)
+++ tomcat/trunk/res/ide-support/eclipse/eclipse.classpath Mon Nov 19 09:31:14 
2018
@@ -24,7 +24,7 @@
 
 
 
-
+
 
 
 

Modified: tomcat/trunk/res/ide-support/idea/tomcat.iml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/res/ide-support/idea/tomcat.iml?rev=1846889&r1=1846888&r2=1846889&view=diff
==
--- tomcat/trunk/res/ide-support/idea/tomcat.iml (original)
+++ tomcat/trunk/res/ide-support/idea/tomcat.iml Mon Nov 19 09:31:14 2018
@@ -70,7 +70,7 @@
 
   
 
-  
+  
 
 
 

Modified: tomcat/trunk/res/ide-support/netbeans/nb-tomcat-build.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/res/ide-support/netbeans/nb-tomcat-build.properties?rev=1846889&r1=1846888&r2=1846889&view=diff
==
--- tomcat/trunk/res/ide-support/netbeans/nb-tomcat-build.properties (original)
+++ tomcat/trunk/res/ide-support/netbeans/nb-tomcat-build.properties Mon Nov 19 
09:31:14 2018
@@ -37,7 +37,7 @@ nb-test.io-method=org.apache.coyote.http
 # it is not possible to retrieve the classpaths from the build to
 # use in the NetBeans targets, so they must be explicitly declared
 
-nb-test.classpath=${test.classes}:${tomcat.build}/webapps/examples/WEB-INF/classes:${base.path}/junit-4.11/junit-4.11.jar:${base.path}/easymock-3.2/easymock-3.2.jar:${base.path}/hamcrest-1.3/hamcrest-core-1.3.jar:${base.path}/ecj-4.7.3a/ecj-4.7.3a.jar:${tomcat.classes}
+nb-test.classpath=${test.classes}:${tomcat.build}/webapps/examples/WEB-INF/classes:${base.path}/junit-4.11/junit-4.11.jar:${base.path}/easymock-3.2/easymock-3.2.jar:${base.path}/hamcrest-1.3/hamcrest-core-1.3.jar:${base.path}/ecj-4.9/ecj-4.9.jar:${tomcat.classes}
 
 # Extra properties used by the Tomcat project additional NetBeans targets.
 

Modified: tomcat/trunk/res/ide-support/netbeans/project.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/res/ide-support/netbeans/project.xml?rev=1846889&r1=1846888&r2=1846889&view=diff
==
--- tomcat/trunk/res/ide-support/netbeans/project.xml (original)
+++ tomcat/trunk/res/ide-support/netbeans/project.xml Mon Nov 19 09:31:14 2018
@@ -178,7 +178,7 @@
 -->
 
 java
-${base.path}/jaxrpc-1.1-rc4/geronimo-spec-jaxrpc-1.1-rc4.jar:${base.path}/wsdl4j-1.6.3/wsdl4j-1.6.3.jar:${base.path}/ecj-4.7.3a/ecj-4.7.3a.jar:${ant.includes}/
+${base.path}/jaxrpc-1.1-rc4/geronimo-spec-jaxrpc-1.1-rc4.jar:${base.path}/wsdl4j-1.6.3/wsdl4j-1.6.3.jar:${base.path}/ecj-4.9/ecj-4.9.jar:${ant.includes}/
 1.7
 
 

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1846889&r1=1846888&r2=1846889&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Mon Nov 19 09:31:14 2018
@@ -129,7 +129,8 @@
   
 
   
-Update the Eclipse Compiler for Java to 4.9. (markt)
+Update the Eclipse Compiler for Java to 4.9. Additional patch by Lukasz
+Jader. (markt)
   
 
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62912] Tomcat adds a space character in the Content-Type header if this one has a ; character right after

2018-11-19 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62912

--- Comment #11 from Franos  ---
Hello,

I have looked at that.
Thanks.

My worry is that it's scheduled for Tomcat 10.
We really need that on Tomcat 8.5.x and 9.x branches.

Best Regards.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org