Extras

2019-01-09 Thread Rémy Maucherat
Hi,

So I'm looking at random small items as possible cleanups and ... The
extras came up.

At some point (15 years ago) the idea was to have a smaller JAR and avoid
bloat, but right now I don't see the point of keeping them out of the
regular catalina.jar (and thus reduce the complexity of the build a bit):
- a listener to configure JMX remote (possibly not as useless as it sounds
for cloud stuff even though they like their Jolokia since it's json)
- some webservices naming factory (ok, so I guess it's not very useful, but
only +15kB or so)

Did I miss something ?

Rémy


[Bug 60195] No javadoc in Maven Central

2019-01-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60195

--- Comment #1 from Michael Osipov  ---
Still true:
https://repo1.maven.org/maven2/org/apache/tomcat/tomcat-jdbc/8.5.35/

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



buildbot success in on tomcat-trunk

2019-01-09 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/3957

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
triggered this build
Build Source Stamp: [branch tomcat/trunk] 1850844
Blamelist: markt

Build succeeded!

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] tomcat pull request #136: authtype -> authType

2019-01-09 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/tomcat/pull/136


---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1850844 - /tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java

2019-01-09 Thread markt
Author: markt
Date: Wed Jan  9 10:37:10 2019
New Revision: 1850844

URL: http://svn.apache.org/viewvc?rev=1850844&view=rev
Log:
Trivial reformatting to use camel case
Patch provided by yangli
This closes #136 

Modified:
tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java

Modified: tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java?rev=1850844&r1=1850843&r2=1850844&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java Wed Jan  
9 10:37:10 2019
@@ -870,9 +870,9 @@ public class CoyoteAdapter implements Ad
 }
 
 // Set the authorization type
-String authtype = req.getAuthType().toString();
-if (authtype != null) {
-request.setAuthType(authtype);
+String authType = req.getAuthType().toString();
+if (authType != null) {
+request.setAuthType(authType);
 }
 }
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



buildbot failure in on tomcat-trunk

2019-01-09 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building 
. Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/3956

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
triggered this build
Build Source Stamp: [branch tomcat/trunk] 1850829
Blamelist: markt

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



buildbot success in on tomcat-85-trunk

2019-01-09 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-85-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/tomcat-85-trunk/builds/1601

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-85-commit' 
triggered this build
Build Source Stamp: [branch tomcat/tc8.5.x/trunk] 1850830
Blamelist: markt

Build succeeded!

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63041] shutdown.sh exits non 0 requires KILLSIG from OS

2019-01-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63041

Mark Thomas  changed:

   What|Removed |Added

 CC||patrik@gmx.net

--- Comment #11 from Mark Thomas  ---
*** Bug 63063 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1850831 - /tomcat/tc7.0.x/trunk/bin/catalina.sh

2019-01-09 Thread markt
Author: markt
Date: Wed Jan  9 09:11:19 2019
New Revision: 1850831

URL: http://svn.apache.org/viewvc?rev=1850831&view=rev
Log:
Correct a regression in the fix for bug 53930 that prevented Tomcat from 
working correctly with systemd.
Patch provided by Patrik S.

Modified:
tomcat/tc7.0.x/trunk/bin/catalina.sh

Modified: tomcat/tc7.0.x/trunk/bin/catalina.sh
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/bin/catalina.sh?rev=1850831&r1=1850830&r2=1850831&view=diff
==
--- tomcat/tc7.0.x/trunk/bin/catalina.sh (original)
+++ tomcat/tc7.0.x/trunk/bin/catalina.sh Wed Jan  9 09:11:19 2019
@@ -451,7 +451,7 @@ elif [ "$1" = "start" ] ; then
   -Dcatalina.home="\"$CATALINA_HOME\"" \
   -Djava.io.tmpdir="\"$CATALINA_TMPDIR\"" \
   org.apache.catalina.startup.Bootstrap "$@" start \
-  2\>\&1 \& echo \$! \>\"$catalina_pid_file\" \; \} $catalina_out_command 
"&"
+  2\>\&1 \&\& echo \$! \>\"$catalina_pid_file\" \; \} 
$catalina_out_command "&"
 
   else
 eval \{ $_NOHUP "\"$_RUNJAVA\"" "\"$LOGGING_CONFIG\"" $LOGGING_MANAGER 
$JAVA_OPTS $CATALINA_OPTS \
@@ -461,7 +461,7 @@ elif [ "$1" = "start" ] ; then
   -Dcatalina.home="\"$CATALINA_HOME\"" \
   -Djava.io.tmpdir="\"$CATALINA_TMPDIR\"" \
   org.apache.catalina.startup.Bootstrap "$@" start \
-  2\>\&1 \& echo \$! \>\"$catalina_pid_file\" \; \} $catalina_out_command 
"&"
+  2\>\&1 \&\& echo \$! \>\"$catalina_pid_file\" \; \} 
$catalina_out_command "&"
 
   fi
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63041] shutdown.sh exits non 0 requires KILLSIG from OS

2019-01-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63041

Mark Thomas  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED

--- Comment #12 from Mark Thomas  ---
Thanks for the report and to Patrik S. for the analysis.

This has been fixed in:
- trunk for 9.0.15 onwards
- 8.5.x for 8.5.38 onwards
- 7.0.x for 7.0.93 onwards

(note the bug was never present in a released version of 7.0.x)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1850830 - in /tomcat/tc8.5.x/trunk: ./ bin/catalina.sh webapps/docs/changelog.xml

2019-01-09 Thread markt
Author: markt
Date: Wed Jan  9 09:07:08 2019
New Revision: 1850830

URL: http://svn.apache.org/viewvc?rev=1850830&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63041
Correct a regression in the fix for bug 53930 that prevented Tomcat from 
working correctly with systemd.
Patch provided by Patrik S.

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/bin/catalina.sh
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Wed Jan  9 09:07:08 2019
@@ -1,2 +1,2 @@
 /tomcat/tc8.0.x/trunk:1809644
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739492,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409
 
,1741501,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744149,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745535,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747
 
404,1747506,1747536,1747924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1
 
756289,1756408-1756410,1756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-176205
 
3,1762123,1762168,1762172,1762182,1762201-1762202,1762204,1762208,1762288,1762296,1762324,1762348,1762353,1762362,1762374,1762492,1762503,1762505,1762541,1762608,1762710,1762753,1762766,1762769,1762944,1762947,1762953,1763167,1763179,1763232,1763259,1763271-1763272,1763276-1763277,1763319-1763320,

svn commit: r1850829 - in /tomcat/trunk: bin/catalina.sh webapps/docs/changelog.xml

2019-01-09 Thread markt
Author: markt
Date: Wed Jan  9 09:04:56 2019
New Revision: 1850829

URL: http://svn.apache.org/viewvc?rev=1850829&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63041
Correct a regression in the fix for bug 53930 that prevented Tomcat from 
working correctly with systemd.
Patch provided by Patrik S.

Modified:
tomcat/trunk/bin/catalina.sh
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/bin/catalina.sh
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/bin/catalina.sh?rev=1850829&r1=1850828&r2=1850829&view=diff
==
--- tomcat/trunk/bin/catalina.sh (original)
+++ tomcat/trunk/bin/catalina.sh Wed Jan  9 09:04:56 2019
@@ -476,7 +476,7 @@ elif [ "$1" = "start" ] ; then
   -Dcatalina.home="\"$CATALINA_HOME\"" \
   -Djava.io.tmpdir="\"$CATALINA_TMPDIR\"" \
   org.apache.catalina.startup.Bootstrap "$@" start \
-  2\>\&1 \& echo \$! \>\"$catalina_pid_file\" \; \} $catalina_out_command 
"&"
+  2\>\&1 \&\& echo \$! \>\"$catalina_pid_file\" \; \} 
$catalina_out_command "&"
 
   else
 eval \{ $_NOHUP "\"$_RUNJAVA\"" "\"$LOGGING_CONFIG\"" $LOGGING_MANAGER 
$JAVA_OPTS $CATALINA_OPTS \
@@ -486,7 +486,7 @@ elif [ "$1" = "start" ] ; then
   -Dcatalina.home="\"$CATALINA_HOME\"" \
   -Djava.io.tmpdir="\"$CATALINA_TMPDIR\"" \
   org.apache.catalina.startup.Bootstrap "$@" start \
-  2\>\&1 \& echo \$! \>\"$catalina_pid_file\" \; \} $catalina_out_command 
"&"
+  2\>\&1 \&\& echo \$! \>\"$catalina_pid_file\" \; \} 
$catalina_out_command "&"
 
   fi
 

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1850829&r1=1850828&r2=1850829&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Wed Jan  9 09:04:56 2019
@@ -189,6 +189,11 @@
 provided with Apache Tomcat. Includes contributions from Victor Caetano
 and Dabilo. (markt)
   
+  
+63041: Correct a regression in the fix for 53930
+that prevented Tomcat from working correctly with systemd. Patch
+provided by Patrik S. (markt)
+  
 
   
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63063] 8.5.37 does not longer start because of error in catalina.sh start section with new redirect to $catalina_out_command eval code code block

2019-01-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63063

Mark Thomas  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #3 from Mark Thomas  ---


*** This bug has been marked as a duplicate of bug 63041 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63041] shutdown.sh exits non 0 requires KILLSIG from OS

2019-01-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63041

--- Comment #10 from Mark Thomas  ---
The issue isn't obvious but is observable on Ubuntu.

I agree that "\&" -> to "\&\&" is the correct fix. I'll get that implemented
and back-ported.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63049] Add support in system properties override from command line

2019-01-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63049

--- Comment #2 from Mark Thomas  ---
dev@ list thread:
https://lists.apache.org/thread.html/8317a1a0d12b48b5746ee8e9e2eded1c00a0b458d3ecbc585c914f2b@%3Cdev.tomcat.apache.org%3E

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org