svn commit: r1852097 - /tomcat/tc7.0.x/trunk/test/org/apache/tomcat/websocket/TestWsWebSocketContainerGetOpenSessions.java

2019-01-24 Thread markt
Author: markt Date: Fri Jan 25 07:51:30 2019 New Revision: 1852097 URL: http://svn.apache.org/viewvc?rev=1852097=rev Log: Ensure new test compiles under Java 6 Modified: tomcat/tc7.0.x/trunk/test/org/apache/tomcat/websocket/TestWsWebSocketContainerGetOpenSessions.java Modified:

[GUMP@vmgump-vm3]: Project tomcat-tc7.0.x-test-bio (in module tomcat-7.0.x) failed

2019-01-24 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-test-bio has an issue affecting its community

[Bug 49159] Improve ThreadLocal memory leak clean-up

2019-01-24 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=49159 --- Comment #21 from Joker --- (In reply to Sylvain Laurent from comment #11) > Created attachment 26108 [details] > tc7 renew threads one by one in a bounded time > > New patch with further improvements : now the behavior is more >

[GUMP@vmgump-vm3]: Project tomcat-tc7.0.x-test-apr (in module tomcat-7.0.x) failed

2019-01-24 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-test-apr has an issue affecting its community

[GUMP@vmgump-vm3]: Project tomcat-tc7.0.x-test-nio (in module tomcat-7.0.x) failed

2019-01-24 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-test-nio has an issue affecting its community

[GUMP@vmgump-vm3]: Project tomcat-tc7.0.x-test-bio (in module tomcat-7.0.x) failed

2019-01-24 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-test-bio has an issue affecting its community

buildbot failure in on tomcat-7-trunk

2019-01-24 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-7-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-7-trunk/builds/1246 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

[Bug 57974] getOpenSessions() bug

2019-01-24 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=57974 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|REOPENED

svn commit: r1852082 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/websocket/ java/org/apache/tomcat/websocket/server/ test/org/apache/tomcat/websocket/ webapps/docs/

2019-01-24 Thread markt
Author: markt Date: Thu Jan 24 23:11:32 2019 New Revision: 1852082 URL: http://svn.apache.org/viewvc?rev=1852082=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=57974 Re-work code that supports Session.getOpenSessions() to ensure that both client-side and server-side calls behave as

svn commit: r1852080 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/tomcat/websocket/ java/org/apache/tomcat/websocket/server/ test/org/apache/tomcat/websocket/ webapps/docs/

2019-01-24 Thread markt
Author: markt Date: Thu Jan 24 23:01:49 2019 New Revision: 1852080 URL: http://svn.apache.org/viewvc?rev=1852080=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=57974 Re-work code that supports Session.getOpenSessions() to ensure that both client-side and server-side calls behave as

svn commit: r1852079 - in /tomcat/trunk: java/org/apache/tomcat/websocket/ java/org/apache/tomcat/websocket/server/ test/org/apache/tomcat/websocket/ webapps/docs/

2019-01-24 Thread markt
Author: markt Date: Thu Jan 24 22:54:41 2019 New Revision: 1852079 URL: http://svn.apache.org/viewvc?rev=1852079=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=57974 Re-work code that supports Session.getOpenSessions() to ensure that both client-side and server-side calls behave as

Re: [Bug 62912] Tomcat adds a space character in the Content-Type header if this one has a ; character right after

2019-01-24 Thread Mark Thomas
On 24/01/2019 18:26, Christopher Schultz wrote: > Mark, > > On 1/23/19 16:55, VP Brand wrote: >> On 23/01/2019 21:48, bugzi...@apache.org wrote: >>> https://bz.apache.org/bugzilla/show_bug.cgi?id=62912 >>> >>> --- Comment #14 from Mark Thomas --- Created >>> attachment 36389 --> >>>

Re: [Bug 62912] Tomcat adds a space character in the Content-Type header if this one has a ; character right after

2019-01-24 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 1/23/19 16:55, VP Brand wrote: > On 23/01/2019 21:48, bugzi...@apache.org wrote: >> https://bz.apache.org/bugzilla/show_bug.cgi?id=62912 >> >> --- Comment #14 from Mark Thomas --- Created >> attachment 36389 --> >>

[Bug 63104] As per servlet api doc ServletContext.getResource should throw MalformedURLException but for some urls tomcat 8 is throwing IllegalArgumentException which is deviation for api.

2019-01-24 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63104 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

[Bug 63104] As per servlet api doc ServletContext.getResource should throw MalformedURLException but for some urls tomcat 8 is throwing IllegalArgumentException which is deviation for api.

2019-01-24 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63104 Gajendra changed: What|Removed |Added Resolution|REMIND |--- Status|RESOLVED

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-24 Thread Mark Thomas
On 24/01/2019 15:22, Rainer Jung wrote: > Checked in as 1852036. My tests looked good (no crashes), but it would > be useful to rerun the original memleak checks against the patched code. Will do. Mark > > Regards, > > Rainer > > Am 24.01.2019 um 15:54 schrieb Rainer Jung: >> Am 24.01.2019

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-24 Thread Rainer Jung
Checked in as 1852036. My tests looked good (no crashes), but it would be useful to rerun the original memleak checks against the patched code. Regards, Rainer Am 24.01.2019 um 15:54 schrieb Rainer Jung: Am 24.01.2019 um 15:51 schrieb Rainer Jung: Am 24.01.2019 um 14:16 schrieb Mark Thomas:

svn commit: r1852036 - in /tomcat/native/trunk/native: include/ssl_private.h src/ssl.c src/sslutils.c

2019-01-24 Thread rjung
Author: rjung Date: Thu Jan 24 15:20:49 2019 New Revision: 1852036 URL: http://svn.apache.org/viewvc?rev=1852036=rev Log: Fix crashes due to dublicate pool destruction, once via the parent pool and once later via the Finalizer. Crash is new in 1.2.20 due to the use of a new child pool to fix a

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-24 Thread Rainer Jung
Am 24.01.2019 um 15:51 schrieb Rainer Jung: Am 24.01.2019 um 14:16 schrieb Mark Thomas: On 24/01/2019 13:01, Rainer Jung wrote: Am 24.01.2019 um 13:37 schrieb Mark Thomas: It can happen in normal usage. I saw it once. It happens on Connector stop so it could be worse. My memory leak fix

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-24 Thread Rainer Jung
Am 24.01.2019 um 14:16 schrieb Mark Thomas: On 24/01/2019 13:01, Rainer Jung wrote: Am 24.01.2019 um 13:37 schrieb Mark Thomas: It can happen in normal usage. I saw it once. It happens on Connector stop so it could be worse. My memory leak fix is definitely the root cause. Any thoughts on

[Bug 62695] Provide sha512 checksums for Tomcat releases published to Maven

2019-01-24 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62695 Mark Thomas changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #2 from Mark

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-24 Thread Mark Thomas
On 24/01/2019 13:01, Rainer Jung wrote: > Am 24.01.2019 um 13:37 schrieb Mark Thomas: >> It can happen in normal usage. I saw it once. It happens on Connector >> stop so it could be worse. My memory leak fix is definitely the root >> cause. Any thoughts on a possible fix? > > Currently

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-24 Thread Rainer Jung
Am 24.01.2019 um 13:37 schrieb Mark Thomas: On 24/01/2019 12:18, Rainer Jung wrote: Am 21.01.2019 um 15:49 schrieb Mark Thomas: Version 1.2.20 includes the following changes compared to 1.2.19: - Fixed memory leak associated with the use of OpenSSL BIO (used when    OpenSSL provides the TLS

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-24 Thread Mark Thomas
On 24/01/2019 12:18, Rainer Jung wrote: > Am 21.01.2019 um 15:49 schrieb Mark Thomas: >> Version 1.2.20 includes the following changes compared to 1.2.19: >> >> - Fixed memory leak associated with the use of OpenSSL BIO (used when >>    OpenSSL provides the TLS functionality for the NIO and NIO2

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-24 Thread Rémy Maucherat
On Thu, Jan 24, 2019 at 1:29 PM Rainer Jung wrote: > Am 21.01.2019 um 15:49 schrieb Mark Thomas: > > Version 1.2.20 includes the following changes compared to 1.2.19: > > > > - Fixed memory leak associated with the use of OpenSSL BIO (used when > >OpenSSL provides the TLS functionality for

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-24 Thread Rainer Jung
Am 21.01.2019 um 15:49 schrieb Mark Thomas: Version 1.2.20 includes the following changes compared to 1.2.19: - Fixed memory leak associated with the use of OpenSSL BIO (used when OpenSSL provides the TLS functionality for the NIO and NIO2 connectors) Various other fixes and

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-24 Thread Rainer Jung
I added some debug logging to native and the Java classes and the picture looks understandable now. Here the example from NIO and TestCustomSsl: - test testCustomTrustManagerNone creates OpenSSLEngine 7f560c39, ssl 4298850656 and con->pool 4309969128 from parent pool aprPool = c->pool

buildbot success in on tomcat-7-trunk

2019-01-24 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-7-trunk while building . Full details are available at: https://ci.apache.org/builders/tomcat-7-trunk/builds/1245 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

Tomcat WebSocket client file descriptors leak

2019-01-24 Thread vtarasov
Hello! We found the leak of Tomcat WebSocket client file descriptors. File descriptors are not closed when the connection between server and client is broken abnormally (from the server side if the server process is killed for example). Test project and how to reproduce you can find in my

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-24 Thread Rainer Jung
Am 24.01.2019 um 11:17 schrieb Rémy Maucherat: On Thu, Jan 24, 2019 at 10:49 AM Rainer Jung wrote: The other possibility - since the crash often happens in the finalizer - that there is double destruction between normal code and finalizer code. OpenSSLEngine.shutdown is obviously very

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-24 Thread Rainer Jung
Am 24.01.2019 um 11:09 schrieb Mark Thomas: Thanks Rainer. This is all very helpful. I agree that r1851094 is the most likely cause. Unfortunately, I haven't been able to reproduce this reliably. Can you confirm APR and OpenSSL versions you used? APR 1.6.5 OpenSSL 1.0.2q In

[GUMP@vmgump-vm3]: Project tomcat-tc7.0.x-test-apr (in module tomcat-7.0.x) failed

2019-01-24 Thread Bill Barker
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.7.3a-201803300640/ecj-4.7.3a.jar -Dtest.apr.loc=/srv/gump/public/workspace/tomcat-native-1.2-1.0.2/dest-20190124/lib -Dtest.relaxTiming=true -Dexecute.test.nio=false -Dtest.accesslog=true -Dtomcat-dbcp.jar=/srv/gump/public/workspace/tomcat-7.0.x

svn commit: r1852009 - /tomcat/tc7.0.x/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java

2019-01-24 Thread markt
Author: markt Date: Thu Jan 24 10:29:32 2019 New Revision: 1852009 URL: http://svn.apache.org/viewvc?rev=1852009=rev Log: Fix failing test after bz 63003 fix Modified: tomcat/tc7.0.x/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java Modified:

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-24 Thread Rémy Maucherat
On Thu, Jan 24, 2019 at 10:49 AM Rainer Jung wrote: > The other possibility - since the crash often happens in the > finalizer - that there is double destruction between normal code and > finalizer code. > OpenSSLEngine.shutdown is obviously very risky, and after some problems it is now fully

Re: [Bug 62912] Tomcat adds a space character in the Content-Type header if this one has a ; character right after

2019-01-24 Thread Mark Thomas
On 23/01/2019 22:42, Igal Sapir wrote: > On 1/23/2019 1:56 PM, Mark Thomas wrote: >> >> >>> On 23/01/2019 21:48, bugzi...@apache.org wrote: https://bz.apache.org/bugzilla/show_bug.cgi?id=62912 --- Comment #14 from Mark Thomas --- Created attachment 36389    -->

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-24 Thread Mark Thomas
Thanks Rainer. This is all very helpful. I agree that r1851094 is the most likely cause. Unfortunately, I haven't been able to reproduce this reliably. Can you confirm APR and OpenSSL versions you used? I'll leave the 1.2.20 vote open for now (in case we track the root cause elsewhere) but I

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-24 Thread Rainer Jung
Addition: - running the same tests just replacing tcnative 1.2.20 by 1.2.19 does not crash - running the same 1.2.20 test on Linux (SLES11) also crashes, but this time not in TestCustomSsl for NIO and NIO2, but instead a few TLS tests only NIO2: [junit] Test

svn commit: r1852006 - in /tomcat/trunk/java/org/apache/catalina/mbeans: JmxRemoteLifecycleListener.java LocalStrings.properties

2019-01-24 Thread remm
Author: remm Date: Thu Jan 24 09:20:50 2019 New Revision: 1852006 URL: http://svn.apache.org/viewvc?rev=1852006=rev Log: Revert unintended commit (this is for making regular JMX more friendly as an alternative to Jolokia). Modified:

svn commit: r1852005 - in /tomcat/trunk: java/org/apache/catalina/mbeans/JmxRemoteLifecycleListener.java java/org/apache/catalina/mbeans/LocalStrings.properties res/tomcat-maven/README.md res/tomcat-m

2019-01-24 Thread remm
Author: remm Date: Thu Jan 24 09:15:03 2019 New Revision: 1852005 URL: http://svn.apache.org/viewvc?rev=1852005=rev Log: Add a bit more docs and a yaml example for the image. Added: tomcat/trunk/res/tomcat-maven/tomcat.yaml (with props) Modified:

[Bug 63104] As per servlet api doc ServletContext.getResource should throw MalformedURLException but for some urls tomcat 8 is throwing IllegalArgumentException which is deviation for api.

2019-01-24 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63104 Gajendra changed: What|Removed |Added Resolution|WONTFIX |REMIND --- Comment #2 from Gajendra ---

[GUMP@vmgump-vm3]: Project tomcat-tc7.0.x-test-nio (in module tomcat-7.0.x) failed

2019-01-24 Thread Bill Barker
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.7.3a-201803300640/ecj-4.7.3a.jar -Dtest.relaxTiming=true -Dexecute.test.nio=true -Dtest.accesslog=true -Dtomcat-dbcp.jar=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps/tomcat-dbcp-20190124.jar -Deasymock.jar=/srv/gump/packages/easymock3