[Bug 63191] RemoteEndpoint.Async#sendText(String, SendHandler) never calls the callback

2019-03-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63191 --- Comment #7 from Boris Petrov --- In the GitHub thread I also explained that I tried putting try/catch around the sendText call exactly because sometimes the callback is not called but rather an exception is thrown:

[Bug 63191] RemoteEndpoint.Async#sendText(String, SendHandler) never calls the callback

2019-03-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63191 --- Comment #6 from Mark Thomas --- There are some error conditions that (as per the spec) mean that the javax.websocket.RemoteEndpoint.Async.sendText callback is never called. So yes, it is perfectly possible for the bug to be elsewhere.

[Bug 63205] Unable to load certificate store on openjdk

2019-03-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63205 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[GitHub] markt-asf commented on issue #141: Update BUILDING and CONTRIBUTING docs after the svn->git migration.

2019-03-01 Thread GitBox
markt-asf commented on issue #141: Update BUILDING and CONTRIBUTING docs after the svn->git migration. URL: https://github.com/apache/tomcat/pull/141#issuecomment-468826081 +1 This is an automated message from the Apache Git

[Bug 63191] RemoteEndpoint.Async#sendText(String, SendHandler) never calls the callback

2019-03-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63191 --- Comment #5 from Boris Petrov --- I'm not sure I understand. If you do believe my claim that a call to javax.websocket.RemoteEndpoint.Async.sendText never calls the callback, is it possible the bug to be anywhere else other than Tomcat? I

[GitHub] csutherl commented on issue #141: Update BUILDING and CONTRIBUTING docs after the svn->git migration.

2019-03-01 Thread GitBox
csutherl commented on issue #141: Update BUILDING and CONTRIBUTING docs after the svn->git migration. URL: https://github.com/apache/tomcat/pull/141#issuecomment-468824644 Do we want to accept this commit so that the docs mostly reflect our current state and fire off a discussion re:

[Bug 63205] Unable to load certificate store on openjdk

2019-03-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63205 --- Comment #2 from Mark Thomas --- Hmm. It is a ~two line patch for us which we'd need to apply in 3 places (or provide a utility function which might even be more code). I'll ping our Oracle contacts and see if we can get a fix for this

Re: JDK 12: First Release Candidate available

2019-03-01 Thread Mark Thomas
Rory, We have received a report [1] of users being affected by a known JRE bug [2]. I've done some local testing and I believe it affects all current Java versions. We can work-around it but it would be much better if this was fixed in the JRE. Is there any chance the priority of [2] could be

[tomcat] branch master updated (3f418c7 -> c084c08)

2019-03-01 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 3f418c7 Correct grammatical error add c084c08 Iterate refactoring and test with CI No new revisions were added

Re: Git migration read for testing

2019-03-01 Thread Mark Thomas
On 01/03/2019 20:58, Rémy Maucherat wrote: > On Fri, Mar 1, 2019 at 9:50 PM Mark Thomas wrote: > >> On 01/03/2019 19:54, Mark Thomas wrote: >>> On 01/03/2019 19:00, Coty Sutherland wrote: The email notifications work for when we push commits to the repository, but it looks like we're

Re: Git migration read for testing

2019-03-01 Thread Rémy Maucherat
On Fri, Mar 1, 2019 at 9:50 PM Mark Thomas wrote: > On 01/03/2019 19:54, Mark Thomas wrote: > > On 01/03/2019 19:00, Coty Sutherland wrote: > >> The email notifications work for when we push commits to the repository, > >> but it looks like we're missing emails when PRs are opened. > > > > ACK.

Re: Git migration read for testing

2019-03-01 Thread Mark Thomas
On 01/03/2019 19:54, Mark Thomas wrote: > On 01/03/2019 19:00, Coty Sutherland wrote: >> The email notifications work for when we push commits to the repository, >> but it looks like we're missing emails when PRs are opened. > > ACK. I'll talk to infra. Fixed. FYI we have the option to route

[GitHub] markt-asf commented on issue #141: Update BUILDING and CONTRIBUTING docs after the svn->git migration.

2019-03-01 Thread GitBox
markt-asf commented on issue #141: Update BUILDING and CONTRIBUTING docs after the svn->git migration. URL: https://github.com/apache/tomcat/pull/141#issuecomment-468806277 Test ping. This is an automated message from the

[Bug 63191] RemoteEndpoint.Async#sendText(String, SendHandler) never calls the callback

2019-03-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63191 --- Comment #4 from Mark Thomas --- So far, you haven't provided any evidence to back up a claim of a Tomcat bug. That the changes between CometD 3 and CometD 4 trigger the issue look to be valid based on the evidence provided. The claim that

[Bug 63191] RemoteEndpoint.Async#sendText(String, SendHandler) never calls the callback

2019-03-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63191 --- Comment #3 from Boris Petrov --- Thank you for the detailed answer. I'll start with the end of your message. In the GitHub issue I answered a couple of days ago with the following message: I downgraded to CometD 3.1.8 and the problem

Re: Git migration read for testing

2019-03-01 Thread Mark Thomas
On 01/03/2019 19:00, Coty Sutherland wrote: > The email notifications work for when we push commits to the repository, > but it looks like we're missing emails when PRs are opened. ACK. I'll talk to infra. Mark > > On Wed, Feb 27, 2019 at 9:03 AM Rémy Maucherat wrote: > >> On Wed, Feb 27,

Re: Git migration read for testing

2019-03-01 Thread Coty Sutherland
The email notifications work for when we push commits to the repository, but it looks like we're missing emails when PRs are opened. On Wed, Feb 27, 2019 at 9:03 AM Rémy Maucherat wrote: > On Wed, Feb 27, 2019 at 11:09 AM Mark Thomas wrote: > > > On 27/02/2019 09:44, Rémy Maucherat wrote: > >

buildbot success in on tomcat-trunk

2019-03-01 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/4101 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

[tomcat] branch master updated: Correct grammatical error

2019-03-01 Thread csutherl
This is an automated email from the ASF dual-hosted git repository. csutherl pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 3f418c7 Correct grammatical error 3f418c7 is

[Bug 63194] Tomcat 7.0.93: org.apache.tomcat.util.net.TestClientCertTls13: UnsatisfiedLinkError

2019-03-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63194 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED OS|

[tomcat] branch 7.0.x updated: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63194

2019-03-01 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new 14ddc76 Fix

[Bug 63210] Tomcat failing to shutdown if EvictionTimer thread is running

2019-03-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63210 --- Comment #7 from Remy Maucherat --- I was not aware the inline executor optimization was a 9.0 only feature, so the big difference is actually there. To get the same deployment thread behavior on Tomcat 9, you can enable parallel deployment

[Bug 63191] RemoteEndpoint.Async#sendText(String, SendHandler) never calls the callback

2019-03-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63191 Mark Thomas changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #2 from Mark

[tomcat] branch master updated: Revert again for now

2019-03-01 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 23d554f Revert again for now 23d554f is

Buildbot

2019-03-01 Thread Mark Thomas
All, One of the unexpected side-effects of switching to git is that the test logs generated by buildbot [1] are no longer in sequentially named directories. This is because git hashes, unlike subversion revision numbers, are not sequential. I will be switching the buildbot configuration to use