[Bug 63236] Reduce duplicate Strings

2019-03-07 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63236 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[tomcat] branch 7.0.x updated: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63236

2019-03-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new 25b1c2c Fix https://bz.apache.org/bugzilla/show_bu

[tomcat] branch 8.5.x updated: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63236

2019-03-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 2e13d46 Fix https://bz.apache.org/bugzilla/show_bu

[tomcat] branch master updated: SSL engines need additional buffer space on input

2019-03-07 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 9e4932c SSL engines need additional buffer space

[GitHub] [tomcat] philwebb commented on issue #143: Apply deduplication to certain loaded and created Strings

2019-03-07 Thread GitBox
philwebb commented on issue #143: Apply deduplication to certain loaded and created Strings URL: https://github.com/apache/tomcat/pull/143#issuecomment-470668078 @markt-asf Thanks Mark! This is an automated message from the A

[GitHub] [tomcat] philwebb commented on issue #143: Apply deduplication to certain loaded and created Strings

2019-03-07 Thread GitBox
philwebb commented on issue #143: Apply deduplication to certain loaded and created Strings URL: https://github.com/apache/tomcat/pull/143#issuecomment-470667817 @rmannibucau I've opened another issue for that https://bz.apache.org/bugzilla/show_bug.cgi?id=63237. If I get a second I'll tr

[tomcat] branch master updated: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63236

2019-03-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 5ccd4eb Fix https://bz.apache.org/bugzilla/show_

[GitHub] [tomcat] markt-asf commented on issue #143: Apply deduplication to certain loaded and created Strings

2019-03-07 Thread GitBox
markt-asf commented on issue #143: Apply deduplication to certain loaded and created Strings URL: https://github.com/apache/tomcat/pull/143#issuecomment-470662734 I've been running YourKit with allocation tracking enabled and tracking each of the duplicated strings to the root cause. I sta

[GitHub] [tomcat] markt-asf closed pull request #143: Apply deduplication to certain loaded and created Strings

2019-03-07 Thread GitBox
markt-asf closed pull request #143: Apply deduplication to certain loaded and created Strings URL: https://github.com/apache/tomcat/pull/143 This is an automated message from the Apache Git Service. To respond to the message

Re: Tomcat Site Redesign

2019-03-07 Thread Igal Sapir
I made the text darker (#333) and pulled the date to the right as on the current site. On Thu, Mar 7, 2019 at 9:50 AM Igal Sapir wrote: > Konstantin, > > Thank you for your feedback: > > On Thu, Mar 7, 2019 at 3:29 AM Konstantin Kolinko > wrote: > >> пн, 4 мар. 2019 г. в 09:02, Igal Sapir : >>

Re: Tomcat Site Redesign

2019-03-07 Thread Igal Sapir
Konstantin, Thank you for your feedback: On Thu, Mar 7, 2019 at 3:29 AM Konstantin Kolinko wrote: > пн, 4 мар. 2019 г. в 09:02, Igal Sapir : > > > > I have uploaded the Tomcat site redesign to a temporary location for > review: > > http://people.apache.org/~isapir/mockups/tomcat-site/ > > 1. Ov

[GitHub] [tomcat] markt-asf commented on issue #142: Defer creation of encodingToCharsetCache

2019-03-07 Thread GitBox
markt-asf commented on issue #142: Defer creation of encodingToCharsetCache URL: https://github.com/apache/tomcat/pull/142#issuecomment-470607054 No. Not an system property ;). Seriously, I think there is a way that we can improve start-up time without impacting the vast majority

[GitHub] [tomcat] rmaucher commented on issue #142: Defer creation of encodingToCharsetCache

2019-03-07 Thread GitBox
rmaucher commented on issue #142: Defer creation of encodingToCharsetCache URL: https://github.com/apache/tomcat/pull/142#issuecomment-470602748 You submitted three items, and indeed I am not convinced by this one. Looking back to the old BZs, there was also there the conclusion that the c

Re: https://tomcat.apache.org/migration-X.html "View Differences"-Button returns 403/404

2019-03-07 Thread Mark Thomas
On 07/03/2019 14:38, Mark Thomas wrote: > On 07/03/2019 14:03, Christoph Hanke wrote: >> Hi, >> >> The "View Differences"-Button on the >> https://tomcat.apache.org/migration-X.html returns a error page (403 for >> Versions 7 and 9  and a 404 for Version8) >> >> e.g. >> >> https://tomcat.apache.org

buildbot success in on tomcat-7-trunk

2019-03-07 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-7-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-7-trunk/builds/1281 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchSch

Re: https://tomcat.apache.org/migration-X.html "View Differences"-Button returns 403/404

2019-03-07 Thread Mark Thomas
On 07/03/2019 14:03, Christoph Hanke wrote: > Hi, > > The "View Differences"-Button on the > https://tomcat.apache.org/migration-X.html returns a error page (403 for > Versions 7 and 9  and a 404 for Version8) > > e.g. > > https://tomcat.apache.org/migration-9.html refering to > > https://gitbo

[GitHub] [tomcat] philwebb commented on issue #142: Defer creation of encodingToCharsetCache

2019-03-07 Thread GitBox
philwebb commented on issue #142: Defer creation of encodingToCharsetCache URL: https://github.com/apache/tomcat/pull/142#issuecomment-470546205 > Besides the 31ms startup time, it's still worse in every way compared to the current code. I'm really not sure what I'm supposed to do wi

[tomcat] branch 8.5.x updated (882a7b4 -> c98a643)

2019-03-07 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a change to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 882a7b4 Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63223 new 25fb200 Avoid keystores with OpenSSL and reg

https://tomcat.apache.org/migration-X.html "View Differences"-Button returns 403/404

2019-03-07 Thread Christoph Hanke
Hi, The "View Differences"-Button on the https://tomcat.apache.org/migration-X.html returns a error page (403 for Versions 7 and 9  and a 404 for Version8) e.g. https://tomcat.apache.org/migration-9.html refering to https://gitbox.apache.org/repos/asf?p=tomcat.git&a=blobdiff&f=conf%2Fcatalina.p

[tomcat] branch master updated: Try to process certificates using JSSE before OpenSSL

2019-03-07 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 7b41d6e Try to process certificates using JSSE be

Re: [tomcat] branch master updated: Avoid keystores with OpenSSL and regular certificates

2019-03-07 Thread Rémy Maucherat
On Thu, Mar 7, 2019 at 1:48 PM Mark Thomas wrote: > On 07/03/2019 12:18, r...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > > > remm pushed a commit to branch master > > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > > > > The fo

Re: [tomcat] branch master updated: Avoid keystores with OpenSSL and regular certificates

2019-03-07 Thread Mark Thomas
On 07/03/2019 12:18, r...@apache.org wrote: > This is an automated email from the ASF dual-hosted git repository. > > remm pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > The following commit(s) were added to refs/heads/master by this push: >

[tomcat] branch master updated: Avoid keystores with OpenSSL and regular certificates

2019-03-07 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new e87cf37 Avoid keystores with OpenSSL and regular

[GitHub] [tomcat] y987425112 commented on issue #145: Adding volatile keywords to member variables

2019-03-07 Thread GitBox
y987425112 commented on issue #145: Adding volatile keywords to member variables URL: https://github.com/apache/tomcat/pull/145#issuecomment-470504073 ``` package com.ydy.thread.volatile2; public class VolatileTest2 { public static void main(String[] args) {

[GitHub] [tomcat] y987425112 removed a comment on issue #145: Adding volatile keywords to member variables

2019-03-07 Thread GitBox
y987425112 removed a comment on issue #145: Adding volatile keywords to member variables URL: https://github.com/apache/tomcat/pull/145#issuecomment-470503719 package com.ydy.thread.volatile2; public class VolatileTest2 { public static void main(String[] args) {

[GitHub] [tomcat] y987425112 commented on issue #145: Adding volatile keywords to member variables

2019-03-07 Thread GitBox
y987425112 commented on issue #145: Adding volatile keywords to member variables URL: https://github.com/apache/tomcat/pull/145#issuecomment-470503719 package com.ydy.thread.volatile2; public class VolatileTest2 { public static void main(String[] args) { Task t

[GitHub] [tomcat] markt-asf closed pull request #145: Adding volatile keywords to member variables

2019-03-07 Thread GitBox
markt-asf closed pull request #145: Adding volatile keywords to member variables URL: https://github.com/apache/tomcat/pull/145 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [tomcat] markt-asf commented on issue #145: Adding volatile keywords to member variables

2019-03-07 Thread GitBox
markt-asf commented on issue #145: Adding volatile keywords to member variables URL: https://github.com/apache/tomcat/pull/145#issuecomment-470502673 The claims made above are incorrect. They fail to take account of the requirement that > However, compilers are allowed to reorder th

[GitHub] [tomcat] rainerjung commented on issue #145: Adding volatile keywords to member variables

2019-03-07 Thread GitBox
rainerjung commented on issue #145: Adding volatile keywords to member variables URL: https://github.com/apache/tomcat/pull/145#issuecomment-470501897 Yes of course, because the threads do not oby to the rules I have described. From my comment: "Changes done by thread T1 while holding any l

[tomcat] branch 7.0.x updated: Fix back-port for BZ63206 / 6e3551b

2019-03-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new be024ab Fix back-port for BZ63206 / 6e3551b be024a

[Bug 63223] org.apache.coyote.http2.Http2UpgradeHandler.pruneClosedStreams

2019-03-07 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63223 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

[tomcat] branch 8.5.x updated: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63223

2019-03-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 882a7b4 Fix https://bz.apache.org/bugzilla/show_bu

Re: svn commit: r1854025 - in /tomcat/trunk/java/org/apache/tomcat/util/net: AbstractJsseEndpoint.java SSLUtilBase.java jsse/JSSEUtil.java openssl/OpenSSLUtil.java

2019-03-07 Thread Rémy Maucherat
On Thu, Feb 21, 2019 at 10:29 AM wrote: > Author: markt > Date: Thu Feb 21 09:29:29 2019 > New Revision: 1854025 > > URL: http://svn.apache.org/viewvc?rev=1854025&view=rev > Log: > Refactor creation of SSLContext to include configuration > There's probably an issue with that strategy. I have one

[tomcat] branch 8.5.x updated: Align HTTP/2 code with master to simplify back-ports

2019-03-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 4c782c5 Align HTTP/2 code with master to simplify

[tomcat] branch master updated: Remove temporary debug code that is no longer being used

2019-03-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new cc367b6 Remove temporary debug code that is no l

Re: Tomcat Site Redesign

2019-03-07 Thread Konstantin Kolinko
пн, 4 мар. 2019 г. в 09:02, Igal Sapir : > > I have uploaded the Tomcat site redesign to a temporary location for review: > http://people.apache.org/~isapir/mockups/tomcat-site/ 1. Overall: Thank you for your effort, but I do not like it. At all. 2. Impressions: 1) The text is not as readable as

[tomcat] branch 8.5.x updated: Align HTTP/2 code with trunk to simplify back-ports

2019-03-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new e529749 Align HTTP/2 code with trunk to simplify b

[GitHub] [tomcat] y987425112 commented on issue #145: Adding volatile keywords to member variables

2019-03-07 Thread GitBox
y987425112 commented on issue #145: Adding volatile keywords to member variables URL: https://github.com/apache/tomcat/pull/145#issuecomment-470489493 ``` package com.ydy.thread.volatile2; public class VolatileTest { public static void main(String[] args) throws Exception {

[GitHub] [tomcat] y987425112 removed a comment on issue #145: Adding volatile keywords to member variables

2019-03-07 Thread GitBox
y987425112 removed a comment on issue #145: Adding volatile keywords to member variables URL: https://github.com/apache/tomcat/pull/145#issuecomment-470488862 ``` package com.ydy.thread.volatile2; public class VolatileTest { public static void main(String[] args) throws Ex

[GitHub] [tomcat] y987425112 commented on issue #145: Adding volatile keywords to member variables

2019-03-07 Thread GitBox
y987425112 commented on issue #145: Adding volatile keywords to member variables URL: https://github.com/apache/tomcat/pull/145#issuecomment-470488862 ``` package com.ydy.thread.volatile2; public class VolatileTest { public static void main(String[] args) throws Exception {

[GitHub] [tomcat] y987425112 removed a comment on issue #145: Adding volatile keywords to member variables

2019-03-07 Thread GitBox
y987425112 removed a comment on issue #145: Adding volatile keywords to member variables URL: https://github.com/apache/tomcat/pull/145#issuecomment-470488340 `package com.ydy.thread.volatile2; public class VolatileTest { public static void main(String[] args) throws Exceptio

[GitHub] [tomcat] y987425112 commented on issue #145: Adding volatile keywords to member variables

2019-03-07 Thread GitBox
y987425112 commented on issue #145: Adding volatile keywords to member variables URL: https://github.com/apache/tomcat/pull/145#issuecomment-470488340 `package com.ydy.thread.volatile2; public class VolatileTest { public static void main(String[] args) throws Exception {

buildbot success in on tomcat-85-trunk

2019-03-07 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-85-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-85-trunk/builds/1688 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchS

buildbot success in on tomcat-trunk

2019-03-07 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/4118 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchSchedul

[GitHub] [tomcat] rainerjung commented on issue #145: Adding volatile keywords to member variables

2019-03-07 Thread GitBox
rainerjung commented on issue #145: Adding volatile keywords to member variables URL: https://github.com/apache/tomcat/pull/145#issuecomment-470482121 My understanding always was, that reordering must obey as-if-serial semantics for any single thread. The complexity only kicks in when check

[tomcat] branch master updated: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63223

2019-03-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 38ef1f6 Fix https://bz.apache.org/bugzilla/show_

[tomcat] branch 8.5.x updated: Fix broken HTTP/2 push

2019-03-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 4938ddc Fix broken HTTP/2 push 4938ddc is describe

[tomcat] branch master updated: Fix broken HTTP/2 push

2019-03-07 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new d8aae21 Fix broken HTTP/2 push d8aae21 is descri

[GitHub] [tomcat] y987425112 opened a new pull request #145: Adding volatile keywords to member variables

2019-03-07 Thread GitBox
y987425112 opened a new pull request #145: Adding volatile keywords to member variables URL: https://github.com/apache/tomcat/pull/145 The semantics of the Java programming language allow compilers and microprocessors to perform optimizations that can interact with incorrectly synchroni

[GitHub] [tomcat] rmaucher commented on issue #142: Defer creation of encodingToCharsetCache

2019-03-07 Thread GitBox
rmaucher commented on issue #142: Defer creation of encodingToCharsetCache URL: https://github.com/apache/tomcat/pull/142#issuecomment-470434736 Besides the 31ms startup time, it's still worse in every way compared to the current code. --