[Bug 63367] Static content with trailing decimal in the URL shown as not found (404 response)

2019-04-19 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63367

Konstantin Kolinko  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #1 from Konstantin Kolinko  ---
Tomcat 8.0 has reached End of Life and is no longer supported.


>
>   allowLinking="true"
>

BTW, the above fragment has "allowLinking" misplaced, so that it is interpreted
as text content of an XML element and thus it is ignored by Tomcat.

An attribute of an XML element should precede the '>' symbol of its opening
tag.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63367] New: Static content with trailing decimal in the URL shown as not found (404 response)

2019-04-19 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63367

Bug ID: 63367
   Summary: Static content with trailing decimal in the URL shown
as not found (404 response)
   Product: Tomcat 8
   Version: 8.0.24
  Hardware: Other
OS: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: Connectors
  Assignee: dev@tomcat.apache.org
  Reporter: mark.re...@ucop.edu
  Target Milestone: 

Hello,

I find that Tomcat 8 will not serve up static content with a trailing decimal
in
the URL.  A response code of 404 is served up, not the static content.

My configuration is a symbolic link in the webapps/ directory. e.g.

 

   allowLinking="true"

 

A sample request URL that will fail is the following.  Note that the file
"externalData/trailingDot." exists on the file system.

 http://localhost:8080/externalData/trailingDot.

I have tried to URL encode the period in the request, but the problem still
exists.



Instance information

Server version: Apache Tomcat/8.0.24
Server built:   Jul 1 2015 20:19:55 UTC
Server number:  8.0.24.0
OS Name:Linux
OS Version: 4.14.104-78.84.amzn1.x86_64
Architecture:   amd64
JVM Version:1.8.0_201-b09
JVM Vendor: Oracle Corporation

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



buildbot success in on tomcat-trunk

2019-04-19 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while 
building tomcat. Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/4240

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
triggered this build
Build Source Stamp: [branch master] 2ac1717d0cfd39449c22cd2155be66f432cb7caa
Blamelist: remm 

Build succeeded!

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[tomcat] branch master updated: Javadoc fix

2019-04-19 Thread remm
This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/master by this push:
 new 2ac1717  Javadoc fix
2ac1717 is described below

commit 2ac1717d0cfd39449c22cd2155be66f432cb7caa
Author: remm 
AuthorDate: Fri Apr 19 19:04:49 2019 +0200

Javadoc fix
---
 java/org/apache/tomcat/util/net/NioSelectorPool.java | 6 ++
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/java/org/apache/tomcat/util/net/NioSelectorPool.java 
b/java/org/apache/tomcat/util/net/NioSelectorPool.java
index e6b3a17..ea365d9 100644
--- a/java/org/apache/tomcat/util/net/NioSelectorPool.java
+++ b/java/org/apache/tomcat/util/net/NioSelectorPool.java
@@ -141,9 +141,7 @@ public class NioSelectorPool {
  * @param socketThe socket to write data to
  * @param selector  The selector to use for blocking, if null then a 
busy write will be initiated
  * @param writeTimeout  The timeout for this write operation in 
milliseconds, -1 means no timeout
- * @param block true to perform a blocking write
- *  otherwise a non-blocking write will be performed
- * @return int - returns the number of bytes written
+ * @return the number of bytes written
  * @throws EOFException if write returns -1
  * @throws SocketTimeoutException if the write times out
  * @throws IOException if an IO Exception occurs in the underlying socket 
logic
@@ -212,7 +210,7 @@ public class NioSelectorPool {
  * @param socket SocketChannel - the socket to write data to
  * @param selector Selector - the selector to use for blocking, if null 
then a busy read will be initiated
  * @param readTimeout long - the timeout for this read operation in 
milliseconds, -1 means no timeout
- * @return int - returns the number of bytes read
+ * @return the number of bytes read
  * @throws EOFException if read returns -1
  * @throws SocketTimeoutException if the read times out
  * @throws IOException if an IO Exception occurs in the underlying socket 
logic


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



buildbot failure in on tomcat-trunk

2019-04-19 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building 
tomcat. Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/4239

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
triggered this build
Build Source Stamp: [branch master] f9884366b9ed9273c8faf74502c1ef2d64c19b47
Blamelist: remm 

BUILD FAILED: failed compile

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[tomcat] branch master updated: More code cleanups

2019-04-19 Thread remm
This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/master by this push:
 new f988436  More code cleanups
f988436 is described below

commit f9884366b9ed9273c8faf74502c1ef2d64c19b47
Author: remm 
AuthorDate: Fri Apr 19 17:59:12 2019 +0200

More code cleanups

No real change. Add an attribute to eventually replace a system property
(the system property still sets the default value). Remove unused block
parameter. Fix a lot of legacy code formatting.
---
 .../tomcat/util/net/NioBlockingSelector.java   | 188 +
 java/org/apache/tomcat/util/net/NioEndpoint.java   |   2 +-
 .../apache/tomcat/util/net/NioSelectorPool.java| 171 ++-
 .../apache/tomcat/util/net/SecureNioChannel.java   |   2 +-
 webapps/docs/config/http.xml   |  10 ++
 5 files changed, 223 insertions(+), 150 deletions(-)

diff --git a/java/org/apache/tomcat/util/net/NioBlockingSelector.java 
b/java/org/apache/tomcat/util/net/NioBlockingSelector.java
index 252bf0e..d723c7a 100644
--- a/java/org/apache/tomcat/util/net/NioBlockingSelector.java
+++ b/java/org/apache/tomcat/util/net/NioBlockingSelector.java
@@ -49,9 +49,6 @@ public class NioBlockingSelector {
 protected Selector sharedSelector;
 
 protected BlockPoller poller;
-public NioBlockingSelector() {
-
-}
 
 public void open(String name, Selector selector) {
 sharedSelector = selector;
@@ -63,7 +60,7 @@ public class NioBlockingSelector {
 }
 
 public void close() {
-if (poller!=null) {
+if (poller != null) {
 poller.disable();
 poller.interrupt();
 poller = null;
@@ -71,13 +68,14 @@ public class NioBlockingSelector {
 }
 
 /**
- * Performs a blocking write using the bytebuffer for data to be written
+ * Performs a blocking write using the byte buffer for data to be written
  * If the selector parameter is null, then it will perform a 
busy write that could
  * take up a lot of CPU cycles.
+ *
  * @param buf ByteBuffer - the buffer containing the data, we will write 
as long as (buf.hasRemaining()==true)
  * @param socket SocketChannel - the socket to write data to
  * @param writeTimeout long - the timeout for this write operation in 
milliseconds, -1 means no timeout
- * @return int - returns the number of bytes written
+ * @return the number of bytes written
  * @throws EOFException if write returns -1
  * @throws SocketTimeoutException if the write times out
  * @throws IOException if an IO Exception occurs in the underlying socket 
logic
@@ -98,11 +96,12 @@ public class NioBlockingSelector {
 int keycount = 1; //assume we can write
 long time = System.currentTimeMillis(); //start the timeout timer
 try {
-while ( (!timedout) && buf.hasRemaining()) {
+while (!timedout && buf.hasRemaining()) {
 if (keycount > 0) { //only write if we were registered for a 
write
 int cnt = socket.write(buf); //write the data
-if (cnt == -1)
+if (cnt == -1) {
 throw new EOFException();
+}
 written += cnt;
 if (cnt > 0) {
 time = System.currentTimeMillis(); //reset our timeout 
timer
@@ -110,29 +109,33 @@ public class NioBlockingSelector {
 }
 }
 try {
-if ( att.getWriteLatch()==null || 
att.getWriteLatch().getCount()==0) att.startWriteLatch(1);
-poller.add(att,SelectionKey.OP_WRITE,reference);
-
att.awaitWriteLatch(AbstractEndpoint.toTimeout(writeTimeout),TimeUnit.MILLISECONDS);
+if (att.getWriteLatch() == null || 
att.getWriteLatch().getCount() == 0) {
+att.startWriteLatch(1);
+}
+poller.add(att, SelectionKey.OP_WRITE, reference);
+
att.awaitWriteLatch(AbstractEndpoint.toTimeout(writeTimeout), 
TimeUnit.MILLISECONDS);
 } catch (InterruptedException ignore) {
 // Ignore
 }
-if ( att.getWriteLatch()!=null && 
att.getWriteLatch().getCount()> 0) {
+if (att.getWriteLatch() != null && 
att.getWriteLatch().getCount() > 0) {
 //we got interrupted, but we haven't received notification 
from the poller.
 keycount = 0;
-}else {
+} else {
 //latch countdown has happened
 keycount = 1;
 att.resetWriteLatch();
 }
 
-if (writeTimeout > 0 && 

buildbot success in on tomcat-trunk

2019-04-19 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while 
building tomcat. Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/4238

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
triggered this build
Build Source Stamp: [branch master] 4377d2db4078f4ae7a3ac33b4a4d058fe2965863
Blamelist: remm 

Build succeeded!

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[tomcat] branch master updated: Simplify non blocking write

2019-04-19 Thread remm
This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/master by this push:
 new 4377d2d  Simplify non blocking write
4377d2d is described below

commit 4377d2db4078f4ae7a3ac33b4a4d058fe2965863
Author: remm 
AuthorDate: Fri Apr 19 16:34:53 2019 +0200

Simplify non blocking write

Non blocking read uses a straight read, and I couldn't see why write
wouldn't be able to do the same thing, the called code is 100%
equivalent once block is false: it doesn't do anything except call the
channel write.
Note: if it works fine, it should be possible to remove the block flag
in NioSelectorPool as it is now unused (it is always true when it is
called).
---
 java/org/apache/tomcat/util/net/NioEndpoint.java | 54 +---
 1 file changed, 30 insertions(+), 24 deletions(-)

diff --git a/java/org/apache/tomcat/util/net/NioEndpoint.java 
b/java/org/apache/tomcat/util/net/NioEndpoint.java
index 5ba1c1a..bfa53bb 100644
--- a/java/org/apache/tomcat/util/net/NioEndpoint.java
+++ b/java/org/apache/tomcat/util/net/NioEndpoint.java
@@ -1310,33 +1310,39 @@ public class NioEndpoint extends 
AbstractJsseEndpoint
 
 @Override
 protected void doWrite(boolean block, ByteBuffer from) throws 
IOException {
-long writeTimeout = getWriteTimeout();
-Selector selector = null;
-try {
-selector = pool.get();
-} catch (IOException x) {
-// Ignore
-}
-try {
-pool.write(from, getSocket(), selector, writeTimeout, block);
-if (block) {
-// Make sure we are flushed
-do {
-if (getSocket().flush(true, selector, writeTimeout)) {
-break;
-}
-} while (true);
+if (block) {
+long writeTimeout = getWriteTimeout();
+Selector selector = null;
+try {
+selector = pool.get();
+} catch (IOException x) {
+// Ignore
 }
-updateLastWrite();
-} finally {
-if (selector != null) {
-pool.put(selector);
+try {
+pool.write(from, getSocket(), selector, writeTimeout, 
block);
+if (block) {
+// Make sure we are flushed
+do {
+if (getSocket().flush(true, selector, 
writeTimeout)) {
+break;
+}
+} while (true);
+}
+} finally {
+if (selector != null) {
+pool.put(selector);
+}
+}
+// If there is data left in the buffer the socket will be 
registered for
+// write further up the stack. This is to ensure the socket is 
only
+// registered for write once as both container and user code 
can trigger
+// write registration.
+} else {
+if (getSocket().write(from) == -1) {
+throw new EOFException();
 }
 }
-// If there is data left in the buffer the socket will be 
registered for
-// write further up the stack. This is to ensure the socket is only
-// registered for write once as both container and user code can 
trigger
-// write registration.
+updateLastWrite();
 }
 
 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



JDK 13 - Early Access build 17 is available

2019-04-19 Thread Rory O'Donnell


*Hi Mark, *

*OpenJDK builds *- JDK 13 - Early Access build 17 is available at 
http://jdk.java.net/13/


 * These early-access , open-source builds are provided under the
 o GNU General Public License, version 2, with the Classpath
   Exception .
 * Changes in this build
   

 * Release notes [1]

*Significant changes since the last availability email*

 * build 16 - Update the default enabled cipher suites preference
   (JDK-8163326 )
 * build 16 - Add new keytool -showinfo -tls command for displaying TLS
   configuration information (JDK-8219861
   )
 * build 15  -*New Japanese Era Name **(JDK-8205432
   )*
 * build 15  - Accessing REIWA era in java.time.chrono.JapaneseEra
   (JDK-8174268 )
 * build 15  - Duplicated RSA services are no longer supported by
   SunJSSE provider (JDK-8220016
   )
 * build 15  - Use server cipher suites preference by default
   (JDK-8168261 )
 * build 15  - The Swing Motif Look and Feel is deprecated and
   unsupported on macOS (JDK-8177960
   )
 * build 15  - Remove support for javadoc "frames" mode (JDK-8215599
   )

Bug fix reported by Open Source Projects  :

 * build 15  - Unable to read certain PKCS12 keystores from
   SequenceInputStream (JDK-8157404)
   

*April 2019 CPU Released*

 * As part of the Apr 2019 Critical Patch Update we released OpenJDK
   12.0.1  under the GNU General Public License, version 2, with the
   Classpath Exception . [2]
 * One change previously announced in the Java Cryptographic Roadmap [3]

*Request for feedback *-  switch expressions in JDK 12  , feedback via 
amber-dev list [4]


Rgds,Rory

[1] http://jdk.java.net/13/release-notes
[2] http://jdk.java.net/12
[3] https://java.com/en/jre-jdk-cryptoroadmap.html
[4] https://mail.openjdk.java.net/pipermail/jdk-dev/2019-April/002770.html

--
Rgds, Rory O'Donnell
Quality Engineering Manager
Oracle EMEA, Dublin, Ireland



buildbot failure in on tomcat-trunk

2019-04-19 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building 
tomcat. Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/4237

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
triggered this build
Build Source Stamp: [branch master] 6b64ef1c99eb870e111d71000ee4291c46e2c1cc
Blamelist: remm 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[tomcat] branch master updated: Improve BlockPoller thread name

2019-04-19 Thread remm
This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/master by this push:
 new 6b64ef1  Improve BlockPoller thread name
6b64ef1 is described below

commit 6b64ef1c99eb870e111d71000ee4291c46e2c1cc
Author: remm 
AuthorDate: Fri Apr 19 11:38:03 2019 +0200

Improve BlockPoller thread name

Associate BlockPoller thread name with its NIO connector for better
readability.
---
 java/org/apache/tomcat/util/net/NioBlockingSelector.java | 6 ++
 java/org/apache/tomcat/util/net/NioEndpoint.java | 2 +-
 java/org/apache/tomcat/util/net/NioSelectorPool.java | 4 ++--
 webapps/docs/changelog.xml   | 4 
 4 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/java/org/apache/tomcat/util/net/NioBlockingSelector.java 
b/java/org/apache/tomcat/util/net/NioBlockingSelector.java
index 6702557..252bf0e 100644
--- a/java/org/apache/tomcat/util/net/NioBlockingSelector.java
+++ b/java/org/apache/tomcat/util/net/NioBlockingSelector.java
@@ -43,8 +43,6 @@ public class NioBlockingSelector {
 private static final Log log = 
LogFactory.getLog(NioBlockingSelector.class);
 protected static final StringManager sm = 
StringManager.getManager(NioBlockingSelector.class);
 
-private static final AtomicInteger threadCounter = new AtomicInteger();
-
 private final SynchronizedStack keyReferenceStack =
 new SynchronizedStack<>();
 
@@ -55,12 +53,12 @@ public class NioBlockingSelector {
 
 }
 
-public void open(Selector selector) {
+public void open(String name, Selector selector) {
 sharedSelector = selector;
 poller = new BlockPoller();
 poller.selector = sharedSelector;
 poller.setDaemon(true);
-poller.setName("NioBlockingSelector.BlockPoller-" + 
threadCounter.incrementAndGet());
+poller.setName(name + "-BlockPoller");
 poller.start();
 }
 
diff --git a/java/org/apache/tomcat/util/net/NioEndpoint.java 
b/java/org/apache/tomcat/util/net/NioEndpoint.java
index 0df2846..5ba1c1a 100644
--- a/java/org/apache/tomcat/util/net/NioEndpoint.java
+++ b/java/org/apache/tomcat/util/net/NioEndpoint.java
@@ -233,7 +233,7 @@ public class NioEndpoint extends 
AbstractJsseEndpoint
 // Initialize SSL if needed
 initialiseSsl();
 
-selectorPool.open();
+selectorPool.open(getName());
 }
 
 // Separated out to make it easier for folks that extend NioEndpoint to
diff --git a/java/org/apache/tomcat/util/net/NioSelectorPool.java 
b/java/org/apache/tomcat/util/net/NioSelectorPool.java
index ee2f454..0bcdf8d 100644
--- a/java/org/apache/tomcat/util/net/NioSelectorPool.java
+++ b/java/org/apache/tomcat/util/net/NioSelectorPool.java
@@ -112,12 +112,12 @@ public class NioSelectorPool {
 }
 }
 
-public void open() throws IOException {
+public void open(String name) throws IOException {
 enabled = true;
 getSharedSelector();
 if (SHARED) {
 blockingSelector = new NioBlockingSelector();
-blockingSelector.open(getSharedSelector());
+blockingSelector.open(name, getSharedSelector());
 }
 
 }
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 34fcdee..5f5051e 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -113,6 +113,10 @@
 Change default value of pollerThreadCount of NIO
 to 1. (remm)
   
+  
+Associate BlockPoller thread name with its NIO connector for better
+readability. (remm)
+  
 
   
 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[tomcat] branch master updated: Change NIO poller thread count default to 1

2019-04-19 Thread remm
This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/master by this push:
 new 9116e05  Change NIO poller thread count default to 1
9116e05 is described below

commit 9116e05bd04099512312993a27f89b74689b142a
Author: remm 
AuthorDate: Fri Apr 19 11:25:10 2019 +0200

Change NIO poller thread count default to 1

I don't see the benefit of the weird default (which is basically always
2, and I don't understand why it is better than 1). Maybe it was useful
in the past. Given a socket is associated with a poller, if something
(somehow) goes wrong, then this would create a partially responsive
server which is not really better but makes problems harder to detect.
If I missed something, I am 100% ok to revert it (but I would be
interested in the performance study that says 2 is better than 1 here).
---
 java/org/apache/tomcat/util/net/NioEndpoint.java | 10 +++---
 webapps/docs/changelog.xml   |  4 
 webapps/docs/config/http.xml |  2 +-
 3 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/java/org/apache/tomcat/util/net/NioEndpoint.java 
b/java/org/apache/tomcat/util/net/NioEndpoint.java
index e84a34f..0df2846 100644
--- a/java/org/apache/tomcat/util/net/NioEndpoint.java
+++ b/java/org/apache/tomcat/util/net/NioEndpoint.java
@@ -147,7 +147,7 @@ public class NioEndpoint extends 
AbstractJsseEndpoint
 /**
  * Poller thread count.
  */
-private int pollerThreadCount = 
Math.min(2,Runtime.getRuntime().availableProcessors());
+private int pollerThreadCount = 1;
 public void setPollerThreadCount(int pollerThreadCount) { 
this.pollerThreadCount = pollerThreadCount; }
 public int getPollerThreadCount() { return pollerThreadCount; }
 
@@ -166,8 +166,12 @@ public class NioEndpoint extends 
AbstractJsseEndpoint
  * @return The next poller in sequence
  */
 public Poller getPoller0() {
-int idx = Math.abs(pollerRotater.incrementAndGet()) % pollers.length;
-return pollers[idx];
+if (pollerThreadCount == 1) {
+return pollers[0];
+} else {
+int idx = Math.abs(pollerRotater.incrementAndGet()) % 
pollers.length;
+return pollers[idx];
+}
 }
 
 
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 9992f8a..34fcdee 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -109,6 +109,10 @@
 When running on newer JREs that don't support SSLv2Hello, don't warn
 that it is not available unless explicitly configured. (markt)
   
+  
+Change default value of pollerThreadCount of NIO
+to 1. (remm)
+  
 
   
 
diff --git a/webapps/docs/config/http.xml b/webapps/docs/config/http.xml
index 9e68e39..039335d 100644
--- a/webapps/docs/config/http.xml
+++ b/webapps/docs/config/http.xml
@@ -735,7 +735,7 @@
 
   
 (int)The number of threads to be used to run for the polling events.
-Default value is 1 per processor but not more than 2.
+Default value is 1.
 When accepting a socket, the operating system holds a global lock. So 
the benefit of
 going above 2 threads diminishes rapidly. Having more than one thread 
is for
 system that need to accept connections very rapidly. However usually 
just


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63365] New: Not check the keystore configuration

2019-04-19 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63365

Bug ID: 63365
   Summary: Not check the keystore configuration
   Product: Tomcat 8
   Version: 8.5.x-trunk
  Hardware: PC
OS: Mac OS X 10.1
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
  Assignee: dev@tomcat.apache.org
  Reporter: lqjack...@gmail.com
  Target Milestone: 

When configuration in the server.xml for ssl support. however the key store in
not found in the file system. 

Once the client request to the https, then the exception will throws : 

2019-04-19 17:13:07.640[][ERROR][AbstractAsyncMQ:575]consumer worker[17] error
as:service health check result is false
us.zoom.async.mq.client.exception.ServiceUnavailableException: service health
check result is false
at
us.zoom.async.mq.client.obj.QueueMessageCarrier.doHealthCheck(QueueMessageCarrier.java:66)
~[asyncmq-client-2.6.jar:?]
at
us.zoom.async.mq.client.AbstractAsyncMQ$ConsumerWorker.run(AbstractAsyncMQ.java:532)
[asyncmq-client-2.6.jar:?]
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
[?:1.8.0_66]
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[?:1.8.0_66]
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
[?:1.8.0_66]
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
[?:1.8.0_66]
at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
2019-04-19 17:13:07.640[][ERROR][AbstractAsyncMQ:575]consumer worker[17] error
as:service health check result is false
us.zoom.async.mq.client.exception.ServiceUnavailableException: service health
check result is false
at
us.zoom.async.mq.client.obj.QueueMessageCarrier.doHealthCheck(QueueMessageCarrier.java:66)
~[asyncmq-client-2.6.jar:?]
at
us.zoom.async.mq.client.AbstractAsyncMQ$ConsumerWorker.run(AbstractAsyncMQ.java:532)
[asyncmq-client-2.6.jar:?]
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
[?:1.8.0_66]
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[?:1.8.0_66]
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
[?:1.8.0_66]
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
[?:1.8.0_66]
at java.lang.Thread.run(Thread.java:745) [?:1.8.0_66]
2019-04-19 17:13:10.703[][ERROR][ApiUtil:63]it seems asyncmq server is
unavailable , so sleep [60]s then will try again!
2019-04-19 17:13:10.703[][ERROR][ApiUtil:63]it seems asyncmq server is
unavailable , so sleep [60]s then will try again!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63362] GlobalRequestProcessor statistics in MBean does not count Websocket communication

2019-04-19 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63362

Remy Maucherat  changed:

   What|Removed |Added

 OS||All
   Severity|normal  |enhancement

--- Comment #1 from Remy Maucherat  ---
Yes, this only tracks non upgraded HTTP/1.1 activity at this time.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[tomcat] branch 7.0.x updated: Fix failing unit test

2019-04-19 Thread markt
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 7.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/7.0.x by this push:
 new 7503eec  Fix failing unit test
7503eec is described below

commit 7503eece8f05053c279840b402af5e4e5c903f44
Author: Mark Thomas 
AuthorDate: Fri Apr 19 08:30:52 2019 +0100

Fix failing unit test

Not all of the interfaces implemented by StandardContext in 8.5.x
onwards exist in 7.0.x. Switch the tests for those to check that they
are not present.
---
 test/org/apache/tomcat/util/TestIntrospectionUtils.java | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/test/org/apache/tomcat/util/TestIntrospectionUtils.java 
b/test/org/apache/tomcat/util/TestIntrospectionUtils.java
index 64864f6..2468178 100644
--- a/test/org/apache/tomcat/util/TestIntrospectionUtils.java
+++ b/test/org/apache/tomcat/util/TestIntrospectionUtils.java
@@ -62,7 +62,8 @@ public class TestIntrospectionUtils {
 
 @Test
 public void testIsInstanceStandardContext06() {
-Assert.assertTrue(IntrospectionUtils.isInstance(
+// This interface doesn't exist in 7.0.x
+Assert.assertFalse(IntrospectionUtils.isInstance(
 StandardContext.class, "org.apache.catalina.JmxEnabled"));
 }
 
@@ -83,7 +84,8 @@ public class TestIntrospectionUtils {
 
 @Test
 public void testIsInstanceStandardContext09() {
-Assert.assertTrue(IntrospectionUtils.isInstance(
+// This interface doesn't exist in 7.0.x
+Assert.assertFalse(IntrospectionUtils.isInstance(
 StandardContext.class, "org.apache.tomcat.ContextBind"));
 }
 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [GUMP@vmgump-vm3]: Project tomcat-tc7.0.x-test-bio (in module tomcat-7.0.x) failed

2019-04-19 Thread Mark Thomas
On 19/04/2019 02:01, Bill Barker wrote:
> To whom it may engage...



>[concat] Testsuites with failed tests:
>[concat] TEST-org.apache.tomcat.util.TestIntrospectionUtils.BIO.txt

My bad. I'm on it.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org