[GUMP@vmgump-vm3]: Project tomcat-trunk-test-apr (in module tomcat-trunk) failed

2019-05-15 Thread Bill Barker
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-apr has an issue affecting its community integration.

[Bug 63441] Changes made to newly created session not replicated

2019-05-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63441 --- Comment #1 from Mark Thomas --- Just a note that the problem statement is correct but the analysis is not. I'm still digging into what is going wrong. -- You are receiving this mail because: You are the assignee for the bug.

[GitHub] [tomcat] ChristopherSchultz commented on issue #162: Add support for same-site cookie attribute

2019-05-15 Thread GitBox
ChristopherSchultz commented on issue #162: Add support for same-site cookie attribute URL: https://github.com/apache/tomcat/pull/162#issuecomment-492771440 +1 for making `SameSiteCookies` into an `enum`. It will also protect against a malicious application causing Tomcat to emit a

buildbot success in on tomcat-trunk

2019-05-15 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/4358 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

[tomcat] branch master updated: Fix javadoc

2019-05-15 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 76830b1 Fix javadoc 76830b1 is described below

buildbot failure in on tomcat-trunk

2019-05-15 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/4357 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

[tomcat] branch master updated: Remove bad looking fields access

2019-05-15 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 7b7442d Remove bad looking fields access 7b7442d

[Bug 63389] Enable Servlet Warmup for Containerization

2019-05-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63389 --- Comment #9 from Mark Thomas --- Since this is synchronous, we can use the exit code to signal success or failure. -- You are receiving this mail because: You are the assignee for the bug.

[Bug 63389] Enable Servlet Warmup for Containerization

2019-05-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63389 --- Comment #8 from Christopher Schultz --- I have a slight objection to the term "warmup" being used, here. Can we call it something else? Nothing brilliant comes to mind. "updown"? "startstop"? "launchtest"? Perhaps such a special launch

[Bug 63441] New: Changes made to newly created session not replicated

2019-05-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63441 Bug ID: 63441 Summary: Changes made to newly created session not replicated Product: Tomcat 9 Version: 9.0.x Hardware: All OS: All Status: NEW

[Bug 63362] GlobalRequestProcessor statistics in MBean does not count Websocket communication

2019-05-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63362 --- Comment #4 from marek.gregor --- Our code has implementation of feeding metrics with sent/received number of bytes from web server. Generally the metrics is important to check amount of data transferred from/to web application in elegant

[Bug 63362] GlobalRequestProcessor statistics in MBean does not count Websocket communication

2019-05-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63362 --- Comment #3 from Remy Maucherat --- I guess it would have to be counted in the SocketWrapper, but is that kind of metric useful at all these days ? We know/expect it will be some random large amount, and that's all it will say. At the same

[Bug 63237] Consider processing mbeans-descriptors.xml at compile time

2019-05-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63237 --- Comment #7 from Mark Thomas --- Has the ability to disable JMX made this enhancement request obsolete? -- You are receiving this mail because: You are the assignee for the bug.

[Bug 63362] GlobalRequestProcessor statistics in MBean does not count Websocket communication

2019-05-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63362 --- Comment #2 from Mark Thomas --- What is the request here? Are new statistics required? Are changes to how the existing statistics are calculated required? Specifics would help us to evaluate the request. The current statistics were

buildbot success in on tomcat-trunk

2019-05-15 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/4356 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

Re: Registry instance aligned on Tomcat/Server lifecycle?

2019-05-15 Thread Mark Thomas
On 15/05/2019 13:48, Romain Manni-Bucau wrote: > Oki, I can hear it is a lot of work for a small gain, however, at least, > it is possible to ensure the disable method is re-callable (actually > setting the registry instance) and that there is an enableRegistry() > method. It is ok and cheap IMO

[GitHub] [tomcat] markt-asf commented on issue #162: Add support for same-site cookie attribute

2019-05-15 Thread GitBox
markt-asf commented on issue #162: Add support for same-site cookie attribute URL: https://github.com/apache/tomcat/pull/162#issuecomment-492644191 Thanks for the updates. I have a few comments on the updated PR: - You can reduce the code duplication by using CookieProcessorBase -

Re: [tomcat] branch master updated: Fix build

2019-05-15 Thread Rémy Maucherat
On Wed, May 15, 2019 at 2:25 PM Mark Thomas wrote: > On 15/05/2019 12:56, r...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > > > remm pushed a commit to branch master > > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > > > > The

Re: Registry instance aligned on Tomcat/Server lifecycle?

2019-05-15 Thread Romain Manni-Bucau
Oki, I can hear it is a lot of work for a small gain, however, at least, it is possible to ensure the disable method is re-callable (actually setting the registry instance) and that there is an enableRegistry() method. It is ok and cheap IMO to have a global reference counting and force it to be

Re: [tomcat] branch master updated: Fix build

2019-05-15 Thread Mark Thomas
On 15/05/2019 12:56, r...@apache.org wrote: > This is an automated email from the ASF dual-hosted git repository. > > remm pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > The following commit(s) were added to refs/heads/master by this push:

[tomcat] branch master updated: Keep the try catch just in case

2019-05-15 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new bd2ed0f Keep the try catch just in case bd2ed0f

[tomcat] branch master updated: Fix build

2019-05-15 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 4691266 Fix build 4691266 is described below

Re: Registry instance aligned on Tomcat/Server lifecycle?

2019-05-15 Thread Mark Thomas
On 15/05/2019 10:35, Romain Manni-Bucau wrote: > 9.0.20 got a disableRegistry method in Registry class (for JMX server > interaction), > I wonder if it is possible to enhance it a bit to make it instance bound > to the server instead of being global. > > It would enable to start/stop/restart

buildbot failure in on tomcat-trunk

2019-05-15 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/4355 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchScheduler

[tomcat] branch master updated: Refactor socket wrapper close

2019-05-15 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new c2d6278 Refactor socket wrapper close c2d6278 is

Registry instance aligned on Tomcat/Server lifecycle?

2019-05-15 Thread Romain Manni-Bucau
Hi guys, 9.0.20 got a disableRegistry method in Registry class (for JMX server interaction), I wonder if it is possible to enhance it a bit to make it instance bound to the server instead of being global. It would enable to start/stop/restart servers potentially deactivating/activating JMX

[tomcat] branch master updated: Fix IDE warnings

2019-05-15 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 7848be1 Fix IDE warnings 7848be1 is described

[Bug 63389] Enable Servlet Warmup for Containerization

2019-05-15 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63389 --- Comment #7 from Mark Thomas --- Thinking about this some more, I think the best way to handle this is with a new "warmup" command. Implemented in a similar manner to configtest it would call server.start() followed by server.stop(). --

Re: Punishing bad clients with delays

2019-05-15 Thread Mark Thomas
On 14/05/2019 21:57, Christopher Schultz wrote: > Mark, > > On 5/14/19 15:47, Mark Thomas wrote: >> On 14/05/2019 20:38, Igal @ Lucee.org wrote: >>> On 5/14/2019 12:15 PM, Christopher Schultz wrote: > >> > > Then, Tomcat observes that the servlet or filter wants to put > the response