date:20190722

https://bz.apache.org/bugzilla/show_bug.cgi?id=63585

TechieElvin  changed:

   What|Removed |Added

 OS||All

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 63585] New: Component are not perform don't worried about it we can help you

https://bz.apache.org/bugzilla/show_bug.cgi?id=63585

Bug ID: 63585
   Summary: Component are not perform don't worried about it we
can help you
   Product: Tomcat Connectors
   Version: 1.2.43
  Hardware: PC
Status: NEW
  Severity: normal
  Priority: P2
 Component: JK2
  Assignee: dev@tomcat.apache.org
  Reporter: w...@8mailpro.com
  Target Milestone: ---

Brother printer support phone number is an independent supplier of remote
technical assistance for third-party goods and our brother support phone number
+1-855-560-0666 helps you instantly.

http://brothercustomerservice.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 63583] New: Resolevd issue

https://bz.apache.org/bugzilla/show_bug.cgi?id=63583

Bug ID: 63583
   Summary: Resolevd issue
   Product: Tomcat 7
   Version: 7.0.92
  Hardware: PC
Status: NEW
  Severity: normal
  Priority: P2
 Component: Servlet & JSP API
  Assignee: dev@tomcat.apache.org
  Reporter: w...@8mailpro.com
  Target Milestone: ---

Open Default PST Document -- When PST document is stored in the default
location
Select PST Document Immediately -- When you know the Precise location of your
PST file
Locate All Your PST Documents -- If you unaware about PST file location, then
go with this option

http://800helpnumbers.com/microsoft-customer-service-phone-number/

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 7.0.95

2019-07-22 Thread Violeta Georgieva

На чт, 11.07.2019 г. в 21:39 ч. Violeta Georgieva 
написа:
>
> The proposed Apache Tomcat 7.0.95 release is now available for voting.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat7/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.95/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1223/
> The git tag is:
> https://github.com/apache/tomcat/tree/7.0.95
> 647a7ebfa4922b9fa213fe642e6180395bbfc135
>
> The proposed 7.0.95 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 7.0.95 Stable

Regards,
Violeta

>

[Bug 63579] New: o.a.catalina.webresources.StandardRoot.validate generates an IllegalArgumentException leading to a 500

https://bz.apache.org/bugzilla/show_bug.cgi?id=63579

Bug ID: 63579
   Summary: o.a.catalina.webresources.StandardRoot.validate
generates an IllegalArgumentException leading to a 500
   Product: Tomcat 9
   Version: 9.0.22
  Hardware: PC
OS: Mac OS X 10.1
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
  Assignee: dev@tomcat.apache.org
  Reporter: a...@forallsecure.com
  Target Milestone: -

Tomcat can generate a 500 response when validating the request path. The issue
can be reproduced with the following command, assuming tomcat is listening on
8080:

```
$ echo -ne "GET *; HTTP/1.1\r\nHost:\r\n\r\n" | nc localhost 8080
HTTP/1.1 500
Content-Type: text/html;charset=utf-8
Content-Language: en
Content-Length: 1973
Date: Mon, 22 Jul 2019 14:38:08 GMT
Connection: close

HTTP Status 500 – Internal Server
Errorh1
{font-family:Tahoma,Arial,sans-serif;color:white;background-color:#525D76;font-size:22px;}
h2
{font-family:Tahoma,Arial,sans-serif;color:white;background-color:#525D76;font-size:16px;}
h3
{font-family:Tahoma,Arial,sans-serif;color:white;background-color:#525D76;font-size:14px;}
body {font-family:Tahoma,Arial,sans-serif;color:black;background-color:white;}
b {font-family:Tahoma,Arial,sans-serif;color:white;background-color:#525D76;} p
{font-family:Tahoma,Arial,sans-serif;background:white;color:black;font-size:12px;}
a {color:black;} a.name {color:black;} .line
{height:1px;background-color:#525D76;border:none;}HTTP
Status 500 – Internal Server ErrorType
Exception ReportMessage The resource path [*] is not
validDescription The server encountered an unexpected condition
that prevented it from fulfilling the
request.Exceptionjava.lang.IllegalArgumentException: The
resource path [*] is not valid
   
org.apache.catalina.webresources.StandardRoot.validate(StandardRoot.java:252)
   
org.apache.catalina.webresources.StandardRoot.getResource(StandardRoot.java:213)
   
org.apache.catalina.webresources.StandardRoot.getResource(StandardRoot.java:207)
   
org.apache.catalina.servlets.DefaultServlet.serveResource(DefaultServlet.java:832)
   
org.apache.catalina.servlets.DefaultServlet.doGet(DefaultServlet.java:497)
javax.servlet.http.HttpServlet.service(HttpServlet.java:634)
   
org.apache.catalina.servlets.DefaultServlet.service(DefaultServlet.java:477)
javax.servlet.http.HttpServlet.service(HttpServlet.java:741)
org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)
Note The full stack trace of the root cause is available in the
server logs.Apache
Tomcat/9.0.22-dev
```

I'm running tomcat from source after compiling it with ant. Version is 'Apache
Tomcat/9.0.22-dev', and commit is ed26bdbaf639a17c02a1e864d2c0553ed3f95971 from
Jul 22.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 63578] New: o.a.coyote.http11.Http11Processor.prepareRequest: various inputs triggering 500 response code

https://bz.apache.org/bugzilla/show_bug.cgi?id=63578

Bug ID: 63578
   Summary: o.a.coyote.http11.Http11Processor.prepareRequest:
various inputs triggering 500 response code
   Product: Tomcat 9
   Version: 9.0.22
  Hardware: Macintosh
Status: NEW
  Severity: minor
  Priority: P2
 Component: Connectors
  Assignee: dev@tomcat.apache.org
  Reporter: a...@forallsecure.com
  Target Milestone: -

Created attachment 36672
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=36672=edit
Inputs triggering 500 responses.

Http11Processor.prepareRequest generates 500 responses instead of 400 on
various inputs:
- Invalid Expect and Transfer-encoding headers can lead to a NullPtrException
- Invalid Content-length headers can lead to an InvalidArgumentException and a
NumberFormatException
- Large numbers of headers and/or cookies can lead to an IllegalStateException
or an InvalidArgumentException  

I'm attaching the inputs that resulted in 500 responses. You can replay them
with `cat .request | nc localhost 8080`, assuming tomcat listens on
8080. The responses are attached in the respective `.response` file.
The responses include the stacktraces that led to the 500.

I'm running tomcat from source after compiling it with ant. Version is 'Apache
Tomcat/9.0.22-dev', and commit is ed26bdbaf639a17c02a1e864d2c0553ed3f95971 from
Jul 22.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch 7.0.x updated: Correct parsing of host names that contain bytes in the range 128 to 255

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 7.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/7.0.x by this push:
 new cca76f5  Correct parsing of host names that contain bytes in the range 
128 to 255
cca76f5 is described below

commit cca76f56fe384072edddce7a474f4366410c8f12
Author: Mark Thomas 
AuthorDate: Mon Jul 22 15:02:00 2019 +0100

Correct parsing of host names that contain bytes in the range 128 to 255
---
 java/org/apache/tomcat/util/http/parser/Host.java | 6 --
 webapps/docs/changelog.xml| 9 +
 2 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/java/org/apache/tomcat/util/http/parser/Host.java 
b/java/org/apache/tomcat/util/http/parser/Host.java
index f4f5848..1400de1 100644
--- a/java/org/apache/tomcat/util/http/parser/Host.java
+++ b/java/org/apache/tomcat/util/http/parser/Host.java
@@ -96,7 +96,8 @@ public class Host {
 @Override
 public int read(char[] cbuf, int off, int len) throws IOException {
 for (int i = off; i < off + len; i++) {
-cbuf[i] = (char) bytes[pos++];
+// Want output in range 0 to 255, not -128 to 127
+cbuf[i] = (char) (bytes[pos++] & 0xFF);
 }
 return len;
 }
@@ -111,7 +112,8 @@ public class Host {
 @Override
 public int read() throws IOException {
 if (pos < end) {
-return bytes[pos++];
+// Want output in range 0 to 255, not -128 to 127
+return bytes[pos++] & 0xFF;
 } else {
 return -1;
 }
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 20ccf3c..7fabf5b 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -60,6 +60,15 @@
   issues do not "pop up" wrt. others).
 -->
 
+  
+
+  
+Correct parsing of invalid host names that contain bytes in the range
+128 to 255 and reject them with a 400 response rather than triggering 
an
+internal error that results in a 500 response. (markt)
+  
+
+  
 
 
   


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch 8.5.x updated: Correct parsing of host names that contain bytes in the range 128 to 255

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/8.5.x by this push:
 new b447e51  Correct parsing of host names that contain bytes in the range 
128 to 255
b447e51 is described below

commit b447e5104033a37b7cbae684180be5d548d5df40
Author: Mark Thomas 
AuthorDate: Mon Jul 22 15:02:00 2019 +0100

Correct parsing of host names that contain bytes in the range 128 to 255
---
 java/org/apache/tomcat/util/http/parser/Host.java | 6 --
 webapps/docs/changelog.xml| 5 +
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/java/org/apache/tomcat/util/http/parser/Host.java 
b/java/org/apache/tomcat/util/http/parser/Host.java
index f4f5848..1400de1 100644
--- a/java/org/apache/tomcat/util/http/parser/Host.java
+++ b/java/org/apache/tomcat/util/http/parser/Host.java
@@ -96,7 +96,8 @@ public class Host {
 @Override
 public int read(char[] cbuf, int off, int len) throws IOException {
 for (int i = off; i < off + len; i++) {
-cbuf[i] = (char) bytes[pos++];
+// Want output in range 0 to 255, not -128 to 127
+cbuf[i] = (char) (bytes[pos++] & 0xFF);
 }
 return len;
 }
@@ -111,7 +112,8 @@ public class Host {
 @Override
 public int read() throws IOException {
 if (pos < end) {
-return bytes[pos++];
+// Want output in range 0 to 255, not -128 to 127
+return bytes[pos++] & 0xFF;
 } else {
 return -1;
 }
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 476c45b..456e553 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -76,6 +76,11 @@
 types that do not support it, which can occur when using the NIO
 inherited channel capability. Submitted by František Kučera. (remm)
   
+  
+Correct parsing of invalid host names that contain bytes in the range
+128 to 255 and reject them with a 400 response rather than triggering 
an
+internal error that results in a 500 response. (markt)
+  
 
   
   


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch master updated: Correct parsing of host names that contain bytes in the range 128 to 255

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/master by this push:
 new ed26bdb  Correct parsing of host names that contain bytes in the range 
128 to 255
ed26bdb is described below

commit ed26bdbaf639a17c02a1e864d2c0553ed3f95971
Author: Mark Thomas 
AuthorDate: Mon Jul 22 15:02:00 2019 +0100

Correct parsing of host names that contain bytes in the range 128 to 255
---
 java/org/apache/tomcat/util/http/parser/Host.java | 6 --
 webapps/docs/changelog.xml| 5 +
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/java/org/apache/tomcat/util/http/parser/Host.java 
b/java/org/apache/tomcat/util/http/parser/Host.java
index c393fda..c3c3465 100644
--- a/java/org/apache/tomcat/util/http/parser/Host.java
+++ b/java/org/apache/tomcat/util/http/parser/Host.java
@@ -101,7 +101,8 @@ public class Host {
 @Override
 public int read(char[] cbuf, int off, int len) throws IOException {
 for (int i = off; i < off + len; i++) {
-cbuf[i] = (char) bytes[pos++];
+// Want output in range 0 to 255, not -128 to 127
+cbuf[i] = (char) (bytes[pos++] & 0xFF);
 }
 return len;
 }
@@ -116,7 +117,8 @@ public class Host {
 @Override
 public int read() throws IOException {
 if (pos < end) {
-return bytes[pos++];
+// Want output in range 0 to 255, not -128 to 127
+return bytes[pos++] & 0xFF;
 } else {
 return -1;
 }
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 4315b90..9cf2619 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -89,6 +89,11 @@
 types that do not support it, which can occur when using the NIO
 inherited channel capability. Submitted by František Kučera. (remm)
   
+  
+Correct parsing of invalid host names that contain bytes in the range
+128 to 255 and reject them with a 400 response rather than triggering 
an
+internal error that results in a 500 response. (markt)
+  
 
   
   


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[CONF] Apache Tomcat > Memory Related Bugs

2019-07-22 Thread Konstantin Kolinko (Confluence)

Title: Message Title

There's 1 new edit on this page

Memory Related Bugs

Konstantin Kolinko edited this page

Here's the version comment

Konstantin Kolinko edited at 01:48 PM

Correct links. Replace JAVA_OPTS with CATALINA_OPTS and explain.

Here's what changed:

... This page discusses various memory issues. In a nutshell - if your computer has less than 128MB of ram - you will probably have trouble. Anyhow, also read the following threads for other memory related issues:

Memory requirements
java.lang.OutOfMemoryError during deploy
Memory requirementsMemory Mgmt Tomcat Tracking memory usage over time
TODO: Links above no longer work - need to pull them from other mailing list archive if they are correct JSP Recompilation If your application uses JSPs which are frequently recompiled at runtime, e.g. headers that change value hourly, please make sure to read the JSP HOW-TO page and RELEASE NOTES documents. You may wish to tune the JSP compiler configuration to prevent memory leaks. Of course, these are documents you should have read by now anyways.. Questions How do I adjust memory settings? First look at java -X to determine what parameters to set. Then you can set them via the environment variable JAVACATALINA_OPTS. Read a comment at the top of the files catalina.bat or catalina.sh for more information on CATALINA_OPTS. Note that there also exists environment variable JAVA_OPTS, but it should not be used to set the memory settings. The difference is that JAVA_OPTS settings are used for all Tomcat management commands. When you stop Apache Tomcat (using shutdown.sh or catalina.sh stop command), a small short-lived Java process is created that notifies the main Java process of Tomcat that it has to shut down. This small Java process does not need the same memory settings as the main process. The small process uses the settings from JAVA_OPTS. The main process uses the settings from both JAVA_OPTS and CATALINA_OPTS. If you launch Tomcat in any other way that does not use catalina.bat or catalina.sh to prepare a command line for Java (e.g. you launch java directly from within an IDE, or you use a Service Wrapper to run Tomcat as a service on Windows), see their options on how to provide settings for the java executable. E.g. Apache Commons Daemon service wrapper for Windows has a GUI configuration dialog that can be opened by running tomcat9w.exe or a similar command. Why do I get OutOfMemoryError errors? Many reasons.

You're out of memory. Simple as that - add more to your heap.
You're out of memory. You have code which is hanging onto object references and the garbage collector can't do its job. Get a profiler to debug this one.
You ran out of file descriptors. If you are on a *nix system, it has been observed that an OutOfMemoryError can be thrown if you run out of file descriptors. This can occur if your threshold is too low. The ulimit program can help you out here. You also may need to account for socket connections too when thinking about these thresholds. Google is your friend for getting more information about this topic.
You have too many threads running. Some OS's have a limit to the number of threads which may be executed by a single process. (Which is what the JVM is.) Refer to your OS docs for more information on how to raise this threshold.
If you have a lot of servlets or JSP's, you may need to increase your permanent generation. By default, it is 64MB. Doubling it to be -XX:MaxPermSize=256m might be a good start.
Your OS limits the amount of memory your process may take. OK, this one is grasping at straws.
Not actually a reason - but on your particular platform, look at the java -X options. They may be VERY helpful.
How much memory is Tomcat/webapp/??? using?

To find out how much memory Tomcat is using, you might be able to use the Runtime class provided by the JDK.
You can't find out how much memory a webapp is using. The JVM doesn't give us these detail.
You can't find out how much memory a ??? is using. The JVM doesn't give us these detail.
That being said, a memory profiling tool might prove the above statements wrong - but you probably don't want to use them in a production environment.
...

Go to page history

View page

Stop watching space
•

Manage notifications

This message was sent by Atlassian Confluence 6.15.2

Re: JDK 13 enters Rampdown Phase Two

2019-07-22 Thread Rory O'Donnell


Thanks Mark.

On 22/07/2019 14:10, Mark Thomas wrote:

Tomcat 9 builds and the unit tests pass with 13-ea30 and 14-ea6.

Mark


--
Rgds, Rory O'Donnell
Quality Engineering Manager
Oracle EMEA, Dublin, Ireland


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: JDK 13 enters Rampdown Phase Two

On 22/07/2019 11:11, Rory O'Donnell wrote:
>  Hi Mark,
> 
> Any issues to report on JDK 13 , would like to hear the status as we are
> now in rampdown phase 2 ?

None I am aware of.

Tomcat 9 builds and the unit tests pass with 13-ea30 and 14-ea6.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[CONF] Apache Tomcat > All about bugs

2019-07-22 Thread Konstantin Kolinko (Confluence)

Title: Message Title

There's 1 new edit on this page

All about bugs

Konstantin Kolinko edited this page

Here's the version comment

Konstantin Kolinko edited at 12:52 PM

Fix links

Here's what changed:

... If you think you found a bug, readread this page this page. Questions

I have a bug, what do I do?
Why does feature ABC work in Servlet Container XYZ but not in Tomcat?
I submitted a bug, why is it ignored?
What does it mean to contact the user list?
... Unless you have the source code reference in Tomcat which is wrong, it may not be a bug. E-mail the Tomcat user list and confirm its a bug. Also read this first from the tomcat site about reporting a bug. ... If you are reading this - you were probably instructed to contact the user list for help. Bugzilla is not a support forum. Bugzilla is intended to fix "real bugs" in Tomcat. It is not intended to help you diagnose errors you are experiencing. The outcome of a diagnosis can be a new bug in Bugzilla. Configuration questions do not belong in Bugzilla. See Tomcat User for what the Tomcat User list is. ...

Go to page history

View page

Stop watching space
•

Manage notifications

This message was sent by Atlassian Confluence 6.15.2

buildbot success in on tomcat-85-trunk

2019-07-22 Thread buildbot

The Buildbot has detected a restored build on builder tomcat-85-trunk while 
building tomcat. Full details are available at:
https://ci.apache.org/builders/tomcat-85-trunk/builds/1847

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: asf946_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-85-commit' 
triggered this build
Build Source Stamp: [branch 8.5.x] c1102da7c632112472feebd3c3f50f704d5f40bd
Blamelist: Mark Thomas 

Build succeeded!

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-85-trunk

On 22/07/2019 11:43, Mark Thomas wrote:
> On 22/07/2019 11:09, build...@apache.org wrote:
>> The Buildbot has detected a new failure on builder tomcat-85-trunk while 
>> building tomcat. Full details are available at:
>> https://ci.apache.org/builders/tomcat-85-trunk/builds/1846
>>
>> Buildbot URL: https://ci.apache.org/
>>
>> Buildslave for this Build: asf946_ubuntu
>>
>> Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-85-commit' 
>> triggered this build
>> Build Source Stamp: [branch 8.5.x] 4fc25e552e0d2a8da718bcc3f975f0092341093a
>> Blamelist: Mark Thomas 
>>
>> BUILD FAILED: failed shell_11
> 
> I think the problem here is that repository.a.o has updated its cert and
> Java 7 doesn't have the CA in the trusted certs list.
> 
> Need to confirm that this is the problem and then think about a way to
> work around this...

I fixed this using the javax.net.ssl.trustStore system property that I
pointed to the Java 8 CA file (overriding the default Java 7 one).

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch 7.0.x updated: Polish. Align with 8.5.x. Improve Java doc.

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 7.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/7.0.x by this push:
 new b048600  Polish. Align with 8.5.x. Improve Java doc.
b048600 is described below

commit b0486003b5f65f4e823d7a70e81905f1ea572252
Author: Mark Thomas 
AuthorDate: Mon Jul 22 12:12:40 2019 +0100

Polish. Align with 8.5.x. Improve Java doc.
---
 java/javax/servlet/Filter.java | 31 ---
 1 file changed, 24 insertions(+), 7 deletions(-)

diff --git a/java/javax/servlet/Filter.java b/java/javax/servlet/Filter.java
index b36b37d..fec7e0a 100644
--- a/java/javax/servlet/Filter.java
+++ b/java/javax/servlet/Filter.java
@@ -49,12 +49,20 @@ public interface Filter {
  * Called by the web container to indicate to a filter that it is being
  * placed into service. The servlet container calls the init method exactly
  * once after instantiating the filter. The init method must complete
- * successfully before the filter is asked to do any filtering work. 
- * 
+ * successfully before the filter is asked to do any filtering work.
+ * 
  * The web container cannot place the filter into service if the init 
method
- * either
- * 1.Throws a ServletException 
- * 2.Does not return within a time period defined by the web container
+ * either:
+ * 
+ * Throws a ServletException
+ * Does not return within a time period defined by the web
+ * container
+ * 
+ *
+ * @param filterConfig The configuration information associated with the
+ * filter instance being initialised
+ *
+ * @throws ServletException if the initialisation fails
  */
 public void init(FilterConfig filterConfig) throws ServletException;
 
@@ -78,7 +86,17 @@ public interface Filter {
  * next entity in the filter chain to block the request processing
  * 5. Directly set headers on the response after invocation of the next
  * entity in the filter chain.
- **/
+ *
+ * @param request  The request to process
+ * @param response The response associated with the request
+ * @param chainProvides access to the next filter in the chain for this
+ * filter to pass the request and response to for further
+ * processing
+ *
+ * @throws IOException if an I/O error occurs during this filter's
+ * processing of the request
+ * @throws ServletException if the processing fails for any other reason
+ */
 public void doFilter(ServletRequest request, ServletResponse response,
 FilterChain chain) throws IOException, ServletException;
 
@@ -96,5 +114,4 @@ public interface Filter {
  * state in memory.
  */
 public void destroy();
-
 }


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch 8.5.x updated: Polish. Align with master.

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/8.5.x by this push:
 new c1102da  Polish. Align with master.
c1102da is described below

commit c1102da7c632112472feebd3c3f50f704d5f40bd
Author: Mark Thomas 
AuthorDate: Mon Jul 22 12:12:07 2019 +0100

Polish. Align with master.

Primarily to trigger CI
---
 java/javax/servlet/Filter.java | 1 -
 1 file changed, 1 deletion(-)

diff --git a/java/javax/servlet/Filter.java b/java/javax/servlet/Filter.java
index 8fd90b0..fec7e0a 100644
--- a/java/javax/servlet/Filter.java
+++ b/java/javax/servlet/Filter.java
@@ -114,5 +114,4 @@ public interface Filter {
  * state in memory.
  */
 public void destroy();
-
 }


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: buildbot failure in on tomcat-85-trunk

On 22/07/2019 11:09, build...@apache.org wrote:
> The Buildbot has detected a new failure on builder tomcat-85-trunk while 
> building tomcat. Full details are available at:
> https://ci.apache.org/builders/tomcat-85-trunk/builds/1846
> 
> Buildbot URL: https://ci.apache.org/
> 
> Buildslave for this Build: asf946_ubuntu
> 
> Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-85-commit' 
> triggered this build
> Build Source Stamp: [branch 8.5.x] 4fc25e552e0d2a8da718bcc3f975f0092341093a
> Blamelist: Mark Thomas 
> 
> BUILD FAILED: failed shell_11

I think the problem here is that repository.a.o has updated its cert and
Java 7 doesn't have the CA in the trusted certs list.

Need to confirm that this is the problem and then think about a way to
work around this...

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch master updated: Update French translations

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/master by this push:
 new 3d98ad9  Update French translations
3d98ad9 is described below

commit 3d98ad98aea2ee10f1578b6b2b16bd716e0c4bc1
Author: Mark Thomas 
AuthorDate: Mon Jul 22 11:16:44 2019 +0100

Update French translations

Translations provided by remm
---
 java/org/apache/catalina/connector/LocalStrings_fr.properties |  1 +
 java/org/apache/catalina/core/LocalStrings_fr.properties  |  2 ++
 java/org/apache/catalina/manager/LocalStrings_fr.properties   |  8 
 .../tribes/membership/cloud/LocalStrings_fr.properties|  2 +-
 java/org/apache/coyote/http2/LocalStrings_fr.properties   | 11 ++-
 webapps/docs/changelog.xml|  4 
 6 files changed, 22 insertions(+), 6 deletions(-)

diff --git a/java/org/apache/catalina/connector/LocalStrings_fr.properties 
b/java/org/apache/catalina/connector/LocalStrings_fr.properties
index fc9be44..5259484 100644
--- a/java/org/apache/catalina/connector/LocalStrings_fr.properties
+++ b/java/org/apache/catalina/connector/LocalStrings_fr.properties
@@ -80,6 +80,7 @@ inputBuffer.streamClosed=Le flux a été fermé
 outputBuffer.writeNull=L'argument String dans write(String, int, int) ne doit 
pas être null
 
 request.asyncNotSupported=Un filtre ou un Servlet de la chaîne actuelle ne 
supporte pas le mode asynchrone
+request.fragmentInDispatchPath=Le fragment dans le chemin de dispatch [{0}] a 
été enlevé
 request.illegalWrap=L'enrobeur de la réponse doit enrober la requête obtenue à 
partir de getRequest()
 request.notAsync=Il est interdit d'appeler cette méthode si la requête 
actuelle n'est pas en mode asynchrone (isAsyncStarted() a renvoyé false)
 
diff --git a/java/org/apache/catalina/core/LocalStrings_fr.properties 
b/java/org/apache/catalina/core/LocalStrings_fr.properties
index c6b9536..f4bb7d9 100644
--- a/java/org/apache/catalina/core/LocalStrings_fr.properties
+++ b/java/org/apache/catalina/core/LocalStrings_fr.properties
@@ -58,6 +58,8 @@ applicationFilterConfig.release=Impossible de détruite le 
filtre nommé [{0}] d
 applicationFilterRegistration.nullInitParam=Impossible de fixer le paramètre 
d''initialisation du filtre, à cause d''un nom ou d''une valeur nulle, nom 
[{0}], valeur [{1}]
 applicationFilterRegistration.nullInitParams=Impossible de fixer les 
paramètres d''initialisation du filtre, à cause d''un nom ou d''une valeur 
nulle, nom [{0}], valeur [{1}]
 
+applicationHttpRequest.fragmentInDispatchPath=Le fragment dans le chemin de 
dispatch [{0}] a été enlevé
+
 applicationPushBuilder.methodInvalid=La méthode HTTP pour une requête push 
doit être à la fois être sans danger et pouvoir être mise en cache, mais [{0}] 
ne correspond pas
 applicationPushBuilder.methodNotToken=Les méthodes HTTP doivent être des 
"token", mais [{0}] contient un caractère invalide dans un token.
 
diff --git a/java/org/apache/catalina/manager/LocalStrings_fr.properties 
b/java/org/apache/catalina/manager/LocalStrings_fr.properties
index a685e5b..8666b20 100644
--- a/java/org/apache/catalina/manager/LocalStrings_fr.properties
+++ b/java/org/apache/catalina/manager/LocalStrings_fr.properties
@@ -168,11 +168,11 @@ Version de l''OS: [{2}]\n\
 Architecture de l''OS: [{3}]\n\
 Version de la JVM: [{4}]\n\
 Fournisseur de la JVM: [{5}]
-managerServlet.sessiondefaultmax=Interval par défaut de maximum de session 
inactive [{0}] minutes
+managerServlet.sessiondefaultmax=La valeur par défaut du délai d''inactivité 
maximum d''une sessions est de [{0}] minutes
 managerServlet.sessions=OK - Information de session pour l''application au 
chemin de contexte [{0}]
-managerServlet.sessiontimeout=[{0}] minutes: [{1}] sessions
-managerServlet.sessiontimeout.expired=[{0}] minutes: [{1}] sessions were 
expired
-managerServlet.sessiontimeout.unlimited=unlimited time: [{0}] sessions
+managerServlet.sessiontimeout=Inactivité pendant [{0}] minutes: [{1}] sessions
+managerServlet.sessiontimeout.expired=Inactivité pendant [{0}] minutes: [{1}] 
sessions ont été expirées
+managerServlet.sessiontimeout.unlimited=Délai illimité: [{0}] sessions
 managerServlet.sslConnectorCerts=OK - Information sur le connecteur et la 
chaîne de certificats
 managerServlet.sslConnectorCiphers=OK - Information sur le connecteur et les 
chiffres SSL
 managerServlet.sslConnectorTrustedCerts=OK - Information sur le Connecteur / 
Certificat de confiance
diff --git 
a/java/org/apache/catalina/tribes/membership/cloud/LocalStrings_fr.properties 
b/java/org/apache/catalina/tribes/membership/cloud/LocalStrings_fr.properties
index 1c0521e..dfa115f 100644
--- 
a/java/org/apache/catalina/tribes/membership/cloud/LocalStrings_fr.properties
+++ 
b/java/org/apache/catalina/tribes/membership/cloud/LocalStrings_fr.properties
@@ -19,7 +19,7 @@

JDK 13 enters Rampdown Phase Two

2019-07-22 Thread Rory O'Donnell


 Hi Mark,

Any issues to report on JDK 13 , would like to hear the status as we are 
now in rampdown phase 2 ?


**OpenJDK builds *- JDK 13 Early Access build 30 **is now available **at 
: - jdk.java.net/13/*


 * Per the JDK 13 schedule [1], we are now in Rampdown Phase Two.
 o For more details , see Mark Reinhold's email to jdk-dev mailing
   list [2]
 o The overall feature set is frozen, no further JEPs will be
   targeted to this release.
 o Per the JDK Release Process [3] we now turn our focus to P1 and
   P2 bugs.

 * I want to draw your attention to some noteable changes in previous
   builds of JDK 13. These changes  are important for those that
   develop/maintain their own socket implementation
   (java.net.SocketImpl) or use the setSocketImplFactory or
   setSocketFactory APIs to change the system-wide socket implementation:

 o http://jdk.java.net/13/release-notes#JDK-8224477 - delivered in
   build 23
 o http://jdk.java.net/13/release-notes#JDK-8216978 - delivered in
   build 20
 o http://jdk.java.net/13/release-notes#JDK-8220493 - delivered in
   build 13

**OpenJDK builds *- JDK 14 Early Access build 6 is **now available **at 
: - jdk.java.net/14/*


 * These early-access, open-source builds are provided under the
 o GNU General Public License, version 2, with the Classpath
   Exception .
 * Changes of interest since last email
 o 8225239: Refactor NetworkInterface lookups
 o 8226409: Enable argument profiling for sun.misc.Unsafe.put*/get*
 * JEP targeted to JDK 14:
 o JEP352: Non-Volatile Mapped
 * Bug fixes reported by Open Source Projects  :
 o JDK-8227080 - fixed in b5 -reported by Eclipse Jetty

The Java Crypto Roadmap 
 has been updated :


 * Released - 16-July-2019 - Release Affected JDK 7u231 - Disabled
   Kerberos DES encryption by default
 * Targeted Date - 2020 - Targeted Release - JDK 8 - Transport Layer
   Security (TLS) 1.3

Rgds,Rory

[1] http://openjdk.java.net/projects/jdk/13/#Schedule
[2] https://mail.openjdk.java.net/pipermail/jdk-dev/2019-July/003170.html


--
Rgds, Rory O'Donnell
Quality Engineering Manager
Oracle EMEA, Dublin, Ireland

buildbot failure in on tomcat-85-trunk

2019-07-22 Thread buildbot

The Buildbot has detected a new failure on builder tomcat-85-trunk while 
building tomcat. Full details are available at:
https://ci.apache.org/builders/tomcat-85-trunk/builds/1846

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: asf946_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-85-commit' 
triggered this build
Build Source Stamp: [branch 8.5.x] 4fc25e552e0d2a8da718bcc3f975f0092341093a
Blamelist: Mark Thomas 

BUILD FAILED: failed shell_11

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch 7.0.x updated: Polish. Fix indent.

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 7.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/7.0.x by this push:
 new e5bb09c  Polish. Fix indent.
e5bb09c is described below

commit e5bb09c3d6fb0edb742e8b0eb441ca7ee9cb5316
Author: Mark Thomas 
AuthorDate: Mon Jul 22 11:02:00 2019 +0100

Polish. Fix indent.
---
 java/javax/servlet/AsyncContext.java | 55 +---
 1 file changed, 39 insertions(+), 16 deletions(-)

diff --git a/java/javax/servlet/AsyncContext.java 
b/java/javax/servlet/AsyncContext.java
index 7ec7817..45b3ebf 100644
--- a/java/javax/servlet/AsyncContext.java
+++ b/java/javax/servlet/AsyncContext.java
@@ -22,15 +22,15 @@ package javax.servlet;
  */
 public interface AsyncContext {
 public static final String ASYNC_REQUEST_URI =
-"javax.servlet.async.request_uri";
+"javax.servlet.async.request_uri";
 public static final String ASYNC_CONTEXT_PATH  =
-"javax.servlet.async.context_path";
+"javax.servlet.async.context_path";
 public static final String ASYNC_PATH_INFO =
-"javax.servlet.async.path_info";
+"javax.servlet.async.path_info";
 public static final String ASYNC_SERVLET_PATH =
-"javax.servlet.async.servlet_path";
+"javax.servlet.async.servlet_path";
 public static final String ASYNC_QUERY_STRING =
-"javax.servlet.async.query_string";
+"javax.servlet.async.query_string";
 
 ServletRequest getRequest();
 
@@ -39,23 +39,41 @@ public interface AsyncContext {
 boolean hasOriginalRequestAndResponse();
 
 /**
- *
- * @throws IllegalStateException
+ * @throws IllegalStateException if this method is called when the request
+ * is not in asynchronous mode. The request is in asynchronous mode after
+ * {@link javax.servlet.http.HttpServletRequest#startAsync()} or
+ * {@link javax.servlet.http.HttpServletRequest#startAsync(ServletRequest,
+ * ServletResponse)} has been called and before {@link #complete()} or any
+ * other dispatch() method has been called.
  */
 void dispatch();
 
 /**
+ * @param path The path to which the request/response should be dispatched
+ * relative to the {@link ServletContext} from which this async
+ * request was started.
  *
- * @param path
- * @throws IllegalStateException
+ * @throws IllegalStateException if this method is called when the request
+ * is not in asynchronous mode. The request is in asynchronous mode after
+ * {@link javax.servlet.http.HttpServletRequest#startAsync()} or
+ * {@link javax.servlet.http.HttpServletRequest#startAsync(ServletRequest,
+ * ServletResponse)} has been called and before {@link #complete()} or any
+ * other dispatch() method has been called.
  */
 void dispatch(String path);
 
 /**
+ * @param path The path to which the request/response should be dispatched
+ * relative to the specified {@link ServletContext}.
+ * @param context The {@link ServletContext} to which the request/response
+ *should be dispatched.
  *
- * @param context
- * @param path
- * @throws IllegalStateException
+ * @throws IllegalStateException if this method is called when the request
+ * is not in asynchronous mode. The request is in asynchronous mode after
+ * {@link javax.servlet.http.HttpServletRequest#startAsync()} or
+ * {@link javax.servlet.http.HttpServletRequest#startAsync(ServletRequest,
+ * ServletResponse)} has been called and before {@link #complete()} or any
+ * other dispatch() method has been called.
  */
 void dispatch(ServletContext context, String path);
 
@@ -72,12 +90,17 @@ public interface AsyncContext {
 throws ServletException;
 
 /**
- * Get timeout in milliseconds. 0 or less indicates no timeout.
+ * Set the timeout.
+ *
+ * @param timeout The timeout in milliseconds. 0 or less indicates no
+ *timeout.
  */
-long getTimeout();
+void setTimeout(long timeout);
 
 /**
- * Set timeout in milliseconds. 0 or less indicates no timeout.
+ * Get the current.
+ *
+ * @return The timeout in milliseconds. 0 or less indicates no timeout.
  */
-void setTimeout(long timeout);
+long getTimeout();
 }


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch 8.5.x updated: Polish. Fix indent.

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/8.5.x by this push:
 new 4fc25e5  Polish. Fix indent.
4fc25e5 is described below

commit 4fc25e552e0d2a8da718bcc3f975f0092341093a
Author: Mark Thomas 
AuthorDate: Mon Jul 22 11:01:33 2019 +0100

Polish. Fix indent.
---
 java/javax/servlet/AsyncContext.java | 10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/java/javax/servlet/AsyncContext.java 
b/java/javax/servlet/AsyncContext.java
index 9f7a24f..45b3ebf 100644
--- a/java/javax/servlet/AsyncContext.java
+++ b/java/javax/servlet/AsyncContext.java
@@ -22,15 +22,15 @@ package javax.servlet;
  */
 public interface AsyncContext {
 public static final String ASYNC_REQUEST_URI =
-"javax.servlet.async.request_uri";
+"javax.servlet.async.request_uri";
 public static final String ASYNC_CONTEXT_PATH  =
-"javax.servlet.async.context_path";
+"javax.servlet.async.context_path";
 public static final String ASYNC_PATH_INFO =
-"javax.servlet.async.path_info";
+"javax.servlet.async.path_info";
 public static final String ASYNC_SERVLET_PATH =
-"javax.servlet.async.servlet_path";
+"javax.servlet.async.servlet_path";
 public static final String ASYNC_QUERY_STRING =
-"javax.servlet.async.query_string";
+"javax.servlet.async.query_string";
 
 ServletRequest getRequest();
 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [tomcat] branch master updated: Polish. Fix indent.

On 22/07/2019 09:46, ma...@apache.org wrote:

> commit 4e1459f207ac8081d2420d2c1407f5d7d82d70b0
> Author: Mark Thomas 
> AuthorDate: Mon Jul 22 09:44:46 2019 +0100
> 
> Polish. Fix indent.
> 
> Trivial commit to trigger a CI build

I've just built Tomcat Native 1.2.23 on the machine we use for CI builds
and updated the buildbot config to use 1.2.23.

This commit is primarily so we can check that the APR tests now execute.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch master updated: Polish. Fix indent.

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/master by this push:
 new 4e1459f  Polish. Fix indent.
4e1459f is described below

commit 4e1459f207ac8081d2420d2c1407f5d7d82d70b0
Author: Mark Thomas 
AuthorDate: Mon Jul 22 09:44:46 2019 +0100

Polish. Fix indent.

Trivial commit to trigger a CI build
---
 java/javax/servlet/AsyncContext.java | 10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/java/javax/servlet/AsyncContext.java 
b/java/javax/servlet/AsyncContext.java
index 4e6bc08..dd61fad 100644
--- a/java/javax/servlet/AsyncContext.java
+++ b/java/javax/servlet/AsyncContext.java
@@ -22,17 +22,17 @@ package javax.servlet;
  */
 public interface AsyncContext {
 public static final String ASYNC_REQUEST_URI =
-"javax.servlet.async.request_uri";
+"javax.servlet.async.request_uri";
 public static final String ASYNC_CONTEXT_PATH  =
-"javax.servlet.async.context_path";
+"javax.servlet.async.context_path";
 public static final String ASYNC_MAPPING =
 "javax.servlet.async.mapping";
 public static final String ASYNC_PATH_INFO =
-"javax.servlet.async.path_info";
+"javax.servlet.async.path_info";
 public static final String ASYNC_SERVLET_PATH =
-"javax.servlet.async.servlet_path";
+"javax.servlet.async.servlet_path";
 public static final String ASYNC_QUERY_STRING =
-"javax.servlet.async.query_string";
+"javax.servlet.async.query_string";
 
 ServletRequest getRequest();
 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [Bug 61180] Change log level of sessionIdGeneratorBase.createRandom to warn rather than info

On 22/07/2019 07:22, bugzi...@apache.org wrote:
> https://bz.apache.org/bugzilla/show_bug.cgi?id=61180
> 
> --- Comment #8 from Oliver Skene <0ltlj...@besttempmail.com> ---

Spam comment deleted. User disabled.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Graal and Tomcat Native

2019-07-22 Thread Giorgio Zoppi

Just a comment the function choosenum is not safe, the rand() is not a good
PRG, i would use if it is possible arc4random in bsd/linux.
Best Regards,
Giorgio.

El lun., 22 jul. 2019 a las 9:12, jean-frederic clere ()
escribió:

> On 18/07/2019 11:05, Rainer Jung wrote:
> > Hi Jean-Frederic and Rémy,
> >
> > I do not have a real answer, but a workaround. It is possible to get the
> > same result without any printf style functions or atoi, just by doing
> > arithmetics. But: maybe then the crash simply moves to another position.
>
> That is what happened, I have now:
> +++
> Thread 20 "apr-8443-exec-2" received signal SIGSEGV, Segmentation fault.
> [Switching to Thread 0x7fffaf7fe700 (LWP 11074)]
> 0x0169aa0d in free ()
> Missing separate debuginfos, use: dnf debuginfo-install
> sssd-client-2.2.0-3.fc30.x86_64 zlib-1.2.11-15.fc30.x86_64
> (gdb) bt
> #0  0x0169aa0d in free ()
> #1  0x016956cd in _dlerror_run ()
> #2  0x0169528d in __dlsym ()
> +++
>
> >
> > In src/ssl.c you can use:
> >
> > static int ssl_rand_choosenum(int l, int h)
> > {
> > double dbl;
> > int i;
> >
> > dbl = 1.0 * (rand() % RAND_MAX) * (h - l);
> > i = (dbl / RAND_MAX + 0.5) + 1;
> > if (i < l) i = l;
> > if (i > h) i = h;
> > return i;
> > }
> >
> > This will also be much faster.
>
> Cool, Please commit the improvement ;-)
>
> >
> > I tested the formula against the original one for each value of l and h
> > Note, that currently the function is always called with l==0 and h==127!
> > So you could also drop the h and l params and use fixed values, but of
> > course would loose future flexibility.
> >
> > between 0 and 499 (and h>=l) and for each seed between 0 and 499 on twi
> > different architectures (Linux 64 Bit on x64 and Solaris Sparc 32 Bit).
> > You can run the following test program to convince yourself about the
> > formula correctness on your platform:
> >
> > #include 
> > #include 
> >
> > #define MAX_SEED 500
> > #define MAX_BOUNDARY 500
> > #define FEEDBACK 10
> >
> > int main ()
> > {
> > int seed;
> > int l;
> > int h;
> > int i1;
> > int i2;
> > int rand_orig;
> > int rand_reduced;
> > double rand_normalized;
> > double rand_prod;
> > char buf[50];
> > long count = 0;
> >
> > fprintf(stdout, "RAND_MAX is %d\n", RAND_MAX);
> > fprintf(stdout, "Number of tests to run: %ld\n",
> > 1L*MAX_BOUNDARY*MAX_BOUNDARY/2*MAX_SEED);
> > fprintf(stdout, "Feedback dot every %d tests\n", FEEDBACK);
> > fprintf(stdout, "Expect %d feedback dots\n",
> > 1L*MAX_BOUNDARY*MAX_BOUNDARY/2*MAX_SEED / FEEDBACK);
> >
> > fprintf(stdout,
> > "l\th\tseed\trand\tred\tnorm\torig\tnew\tprod\tround\n");
> > fflush(stdout);
> >
> > for (seed = 0; seed < MAX_SEED; seed++) {
> > srand(seed);
> > for (l = 0; l < MAX_BOUNDARY; l++) {
> > for (h = l; h < MAX_BOUNDARY; h++) {
> > rand_orig = rand();
> > rand_reduced = rand_orig % RAND_MAX;
> >
> > rand_normalized = ((double)rand_reduced / RAND_MAX) * (h
> > - l);
> > /* %.0f does rounding */
> > sprintf(buf, "%.0f", rand_normalized);
> > i1 = atoi(buf) + 1;
> > if (i1 < l) i1 = l;
> > if (i1 > h) i1 = h;
> >
> > rand_prod = 1.0 * rand_reduced * (h - l);
> > i2 = (rand_prod / RAND_MAX + 0.5) + 1;
> > if (i2 < l) i2 = l;
> > if (i2 > h) i2 = h;
> >
> > if (i1 != i2) {
> > fprintf(stdout,
> "%d\t%d\t%d\t%d\t%d\t%f\t%d\t%d\t%f\n",
> > l, h, seed, rand_orig, rand_reduced,
> > rand_normalized,
> > i1, i2, rand_prod);
> > }
> > count++;
> > if (count % FEEDBACK == 0) {
> > fprintf(stderr, ".");
> > fflush(stderr);
> > }
> > }
> > }
> > }
> > }
> >
> > Regards,
> >
> > Rainer
> >
> > Am 18.07.2019 um 08:57 schrieb jean-frederic clere:
> >> On 12/07/2019 11:21, Rémy Maucherat wrote:
> >>> On Thu, Jul 11, 2019 at 11:01 PM Rainer Jung  >>> > wrote:
> >>>
> >>>  Am 11.07.2019 um 22:10 schrieb Rémy Maucherat:
> >>>  > On Thu, Jul 11, 2019 at 8:42 PM Rainer Jung
> >>>  mailto:rainer.j...@kippdata.de>
> >>>  >  >>> >>
> >>>  wrote:
> >>>  >
> >>>  > Hi Rémy,
> >>>  >
> >>>  > When one looks up the macros in native/include/tcn.h, this
> >>> boils
> >>>  > down to
> >>>  > the following returning null:
> >>>  >
> >>>  > (*env)->FindClass(env, "org/apache/tomcat/jni/FileInfo")
> >>>  >
> >>>  > So our own FileInfo class can not be found. FindClass docs
> >>>  indicate its
> >>>

Re: Graal and Tomcat Native

2019-07-22 Thread jean-frederic clere

On 18/07/2019 11:05, Rainer Jung wrote:
> Hi Jean-Frederic and Rémy,
> 
> I do not have a real answer, but a workaround. It is possible to get the
> same result without any printf style functions or atoi, just by doing
> arithmetics. But: maybe then the crash simply moves to another position.

That is what happened, I have now:
+++
Thread 20 "apr-8443-exec-2" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fffaf7fe700 (LWP 11074)]
0x0169aa0d in free ()
Missing separate debuginfos, use: dnf debuginfo-install
sssd-client-2.2.0-3.fc30.x86_64 zlib-1.2.11-15.fc30.x86_64
(gdb) bt
#0  0x0169aa0d in free ()
#1  0x016956cd in _dlerror_run ()
#2  0x0169528d in __dlsym ()
+++

> 
> In src/ssl.c you can use:
> 
> static int ssl_rand_choosenum(int l, int h)
> {
>     double dbl;
>     int i;
> 
>     dbl = 1.0 * (rand() % RAND_MAX) * (h - l);
>     i = (dbl / RAND_MAX + 0.5) + 1;
>     if (i < l) i = l;
>     if (i > h) i = h;
>     return i;
> }
> 
> This will also be much faster.

Cool, Please commit the improvement ;-)

> 
> I tested the formula against the original one for each value of l and h
> Note, that currently the function is always called with l==0 and h==127!
> So you could also drop the h and l params and use fixed values, but of
> course would loose future flexibility.
> 
> between 0 and 499 (and h>=l) and for each seed between 0 and 499 on twi
> different architectures (Linux 64 Bit on x64 and Solaris Sparc 32 Bit).
> You can run the following test program to convince yourself about the
> formula correctness on your platform:
> 
> #include 
> #include 
> 
> #define MAX_SEED 500
> #define MAX_BOUNDARY 500
> #define FEEDBACK 10
> 
> int main ()
> {
>     int seed;
>     int l;
>     int h;
>     int i1;
>     int i2;
>     int rand_orig;
>     int rand_reduced;
>     double rand_normalized;
>     double rand_prod;
>     char buf[50];
>     long count = 0;
> 
>     fprintf(stdout, "RAND_MAX is %d\n", RAND_MAX);
>     fprintf(stdout, "Number of tests to run: %ld\n",
> 1L*MAX_BOUNDARY*MAX_BOUNDARY/2*MAX_SEED);
>     fprintf(stdout, "Feedback dot every %d tests\n", FEEDBACK);
>     fprintf(stdout, "Expect %d feedback dots\n",
> 1L*MAX_BOUNDARY*MAX_BOUNDARY/2*MAX_SEED / FEEDBACK);
> 
>     fprintf(stdout,
> "l\th\tseed\trand\tred\tnorm\torig\tnew\tprod\tround\n");
>     fflush(stdout);
> 
>     for (seed = 0; seed < MAX_SEED; seed++) {
>     srand(seed);
>     for (l = 0; l < MAX_BOUNDARY; l++) {
>     for (h = l; h < MAX_BOUNDARY; h++) {
>     rand_orig = rand();
>     rand_reduced = rand_orig % RAND_MAX;
> 
>     rand_normalized = ((double)rand_reduced / RAND_MAX) * (h
> - l);
>     /* %.0f does rounding */
>     sprintf(buf, "%.0f", rand_normalized);
>     i1 = atoi(buf) + 1;
>     if (i1 < l) i1 = l;
>     if (i1 > h) i1 = h;
> 
>     rand_prod = 1.0 * rand_reduced * (h - l);
>     i2 = (rand_prod / RAND_MAX + 0.5) + 1;
>     if (i2 < l) i2 = l;
>     if (i2 > h) i2 = h;
> 
>     if (i1 != i2) {
>     fprintf(stdout, "%d\t%d\t%d\t%d\t%d\t%f\t%d\t%d\t%f\n",
>     l, h, seed, rand_orig, rand_reduced,
> rand_normalized,
>     i1, i2, rand_prod);
>     }
>     count++;
>     if (count % FEEDBACK == 0) {
>     fprintf(stderr, ".");
>     fflush(stderr);
>     }
>     }
>     }
>     }
> }
> 
> Regards,
> 
> Rainer
> 
> Am 18.07.2019 um 08:57 schrieb jean-frederic clere:
>> On 12/07/2019 11:21, Rémy Maucherat wrote:
>>> On Thu, Jul 11, 2019 at 11:01 PM Rainer Jung >> > wrote:
>>>
>>>  Am 11.07.2019 um 22:10 schrieb Rémy Maucherat:
>>>  > On Thu, Jul 11, 2019 at 8:42 PM Rainer Jung
>>>  mailto:rainer.j...@kippdata.de>
>>>  > >> >>
>>>  wrote:
>>>  >
>>>  >     Hi Rémy,
>>>  >
>>>  >     When one looks up the macros in native/include/tcn.h, this
>>> boils
>>>  >     down to
>>>  >     the following returning null:
>>>  >
>>>  >     (*env)->FindClass(env, "org/apache/tomcat/jni/FileInfo")
>>>  >
>>>  >     So our own FileInfo class can not be found. FindClass docs
>>>  indicate its
>>>  >     searched in the CLASSPATH although I'm not sure whether its
>>>  really the
>>>  >     classpath or some search paths of a class loader hierarchy.
>>>  >
>>>  >     You might want to add the JVM commandline flag
>>>  "-verbose:class" for any
>>>  >     easy way to track class loading.
>>>  >
>>>  >     I didn't really grok what you meant with "define in JNI
>>>  configuration".
>>>  >     For normal JVMs the code just works, so what might be

[Bug 61180] Change log level of sessionIdGeneratorBase.createRandom to warn rather than info