[GitHub] [tomcat] qixiaobo commented on a change in pull request #192: Fix typo

2019-08-19 Thread GitBox
qixiaobo commented on a change in pull request #192: Fix typo
URL: https://github.com/apache/tomcat/pull/192#discussion_r315514055
 
 

 ##
 File path: java/org/apache/catalina/core/StandardWrapper.java
 ##
 @@ -1253,7 +1253,7 @@ public synchronized void unload() throws 
ServletException {
 return;
 unloading = true;
 
-// Loaf a while if the current instance is allocated
+// Load a while if the current instance is allocated
 
 Review comment:
   Means have a break ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] KangZhiDong closed pull request #192: Fix typo

2019-08-19 Thread GitBox
KangZhiDong closed pull request #192: Fix typo
URL: https://github.com/apache/tomcat/pull/192
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] gmshake commented on a change in pull request #192: Fix typo

2019-08-19 Thread GitBox
gmshake commented on a change in pull request #192: Fix typo
URL: https://github.com/apache/tomcat/pull/192#discussion_r315478754
 
 

 ##
 File path: java/org/apache/catalina/core/StandardWrapper.java
 ##
 @@ -1253,7 +1253,7 @@ public synchronized void unload() throws 
ServletException {
 return;
 unloading = true;
 
-// Loaf a while if the current instance is allocated
+// Load a while if the current instance is allocated
 
 Review comment:
   Not typo here :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63671] libtcnative does not compile with OpenSSL < 1.1.0 and APR w/o threading support

2019-08-19 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63671

Michael Osipov  changed:

   What|Removed |Added

 CC||micha...@apache.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63671] New: libtcnative does not compile with OpenSSL < 1.1.0 and APR w/o threading support

2019-08-19 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63671

Bug ID: 63671
   Summary: libtcnative does not compile with OpenSSL < 1.1.0 and
APR w/o threading support
   Product: Tomcat Native
   Version: unspecified
  Hardware: All
OS: HP-UX
Status: NEW
  Severity: normal
  Priority: P2
 Component: Library
  Assignee: dev@tomcat.apache.org
  Reporter: micha...@apache.org
  Target Milestone: ---

Compile APR 1.6.x or 1.7.0 without pthreads, try to compile libtcnative with
OpenSSL 1.0.2 and that APR version, you get:

> /net/home/osipovmi/opt/build/libtool --silent --mode=compile --tag=CC 
> /opt/aCC/bin/aCC -Ae -g   -DHAVE_CONFIG_H  -DHPUX11 -D_REENTRANT 
> -D_HPUX_SOURCE -D_LARGEFILE64_SOURCE  -I/net/home/osipovmi/opt/include -g 
> -DHAVE_OPENSSL -I/net/home/osipovmi/opt/include  -I./include 
> -I/opt/java8/include -I/opt/java8/include/hpux -I/opt/openssl/include  
> -I/net/home/osipovmi/opt/include   -o src/ssl.lo -c src/ssl.c && touch 
> src/ssl.lo
> "src/ssl.c", line 62: error #2020: identifier "apr_thread_mutex_t" is 
> undefined
>   apr_thread_mutex_t *mutex;
>   ^
> 
> "src/ssl.c", line 359: warning #2223-D: function 
> "apr_threadkey_private_delete"
>   declared implicitly
>   apr_threadkey_private_delete(thread_exit_key);
>   ^
> 
> "src/ssl.c", line 437: error #2020: identifier "apr_thread_mutex_t" is
>   undefined
>   static apr_thread_mutex_t **ssl_lock_cs;
>  ^
> 
> "src/ssl.c", line 447: warning #2223-D: function "apr_thread_mutex_lock"
>   declared implicitly
>   apr_thread_mutex_lock(ssl_lock_cs[type]);
>   ^
> 
> "src/ssl.c", line 450: warning #2223-D: function "apr_thread_mutex_unlock"
>   declared implicitly
>   apr_thread_mutex_unlock(ssl_lock_cs[type]);
>   ^
> 
> "src/ssl.c", line 478: warning #2223-D: function "apr_os_thread_current"
>   declared implicitly
>   return (unsigned long)(apr_os_thread_current());
>  ^
> 
> "src/ssl.c", line 486: warning #2223-D: function "apr_threadkey_private_set"
>   declared implicitly
>   apr_threadkey_private_set(NULL, thread_exit_key);
>   ^
> 
> "src/ssl.c", line 490: warning #2223-D: function "apr_threadkey_private_set"
>   declared implicitly
>   apr_threadkey_private_set(thread_exit_key, thread_exit_key);
>   ^
> 
> "src/ssl.c", line 495: warning #2223-D: function "apr_threadkey_private_set"
>   declared implicitly
>   apr_threadkey_private_set(thread_exit_key, thread_exit_key);
>   ^
> 
> "src/ssl.c", line 559: warning #2223-D: function "apr_thread_mutex_create"
>   declared implicitly
>   rv = apr_thread_mutex_create(&(value->mutex), APR_THREAD_MUTEX_DEFAULT,
>^
> 
> "src/ssl.c", line 559: error #2020: identifier "APR_THREAD_MUTEX_DEFAULT" is
>   undefined
>   rv = apr_thread_mutex_create(&(value->mutex), APR_THREAD_MUTEX_DEFAULT,
> ^
> 
> "src/ssl.c", line 579: warning #2223-D: function "apr_thread_mutex_lock"
>   declared implicitly
>   apr_thread_mutex_lock(l->mutex);
>   ^
> 
> "src/ssl.c", line 582: warning #2223-D: function "apr_thread_mutex_unlock"
>   declared implicitly
>   apr_thread_mutex_unlock(l->mutex);
>   ^
> 
> "src/ssl.c", line 593: warning #2223-D: function "apr_thread_mutex_destroy"
>   declared implicitly
>   rv = apr_thread_mutex_destroy(l->mutex);
>^
> 
> "src/ssl.c", line 612: warning #2223-D: function "apr_thread_mutex_create"
>   declared implicitly
>   apr_thread_mutex_create(&(ssl_lock_cs[i]),
>   ^
> 
> "src/ssl.c", line 613: error #2020: identifier "APR_THREAD_MUTEX_DEFAULT" is
>   undefined
>   APR_THREAD_MUTEX_DEFAULT, p);
>   ^
> 
> "src/ssl.c", line 802: warning #2223-D: function 
> "apr_threadkey_private_create"
>   declared implicitly
>   err = apr_threadkey_private_create(&thread_exit_key, _ssl_thread_exit,
> ^
> 
> 4 errors detected in the compilation of "src/ssl.c".
> gmake[1]: *** [/net/home/osipovmi/tomcat-native/native/build/rules.mk:206: 
> src/ssl.lo] Error 1
> gmake[1]: Leaving directory '/net/home/osipovmi/tomcat-native/native'
> gmake: *** [/net/home/osipovmi/tomcat-native/native/build/rules.mk:118: 
> all-recursive] Error 1

I have verified this on HP-UX, but this will be an issue on any OS where the
threading support has been disable for some reason.

If libtcnative requires threading support for these muteces, check at configure
time for:

> ./apr.h:#define APR_HAS_THREADS   0

and additionally fail at compile time with #ifndef and #error.

-- 
You are receiving this mail because:
You are the

[ANN] Apache Tomcat 9.0.24 available

2019-08-19 Thread Mark Thomas
The Apache Tomcat team announces the immediate availability of Apache
Tomcat 9.0.24.

Apache Tomcat 9 is an open source software implementation of the Java
Servlet, JavaServer Pages, Java Unified Expression Language, Java
WebSocket and JASPIC technologies.

Apache Tomcat 9.0.24 is a bugfix and feature release. The notable
changes compared to 9.0.22 include:

- Expand Graal native image support to include JNDI, JSPs and JULI

- Expand the HTTP/2 excessive overhead protection to cover various forms
  of abusive client behaviour and close the connection if any such
  behaviour is detected.

- Security improvements to the Windows installer including a change in
  the default user from Local System to Local Service.

Please refer to the change log for the complete list of changes:
http://tomcat.apache.org/tomcat-9.0-doc/changelog.html


Downloads:
http://tomcat.apache.org/download-90.cgi

Migration guides from Apache Tomcat 7.x and 8.x:
http://tomcat.apache.org/migration.html

Enjoy!

- The Apache Tomcat team


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r35285 - /release/tomcat/tomcat-9/v9.0.22/

2019-08-19 Thread markt
Author: markt
Date: Mon Aug 19 07:59:01 2019
New Revision: 35285

Log:
Drop 9.0.22 from mirrors

Removed:
release/tomcat/tomcat-9/v9.0.22/


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1865415 [2/2] - in /tomcat/site/trunk: docs/ xdocs/

2019-08-19 Thread markt
Modified: tomcat/site/trunk/docs/whichversion.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/whichversion.html?rev=1865415&r1=1865414&r2=1865415&view=diff
==
--- tomcat/site/trunk/docs/whichversion.html (original)
+++ tomcat/site/trunk/docs/whichversion.html Mon Aug 19 07:54:22 2019
@@ -1,234 +1,233 @@
 
 
-
-
-
-
-
-Apache Tomcat® - Which Version Do I Want?
-
-
-
-
-
-
-
-
-
-
-
-http://tomcat.apache.org/";>
-
-Apache Tomcat®
-
-
-https://www.apache.org/foundation/contributing.html"; target="_blank" 
class="pull-left">https://www.apache.org/images/SupportApache-small.png"; class="support-asf" 
alt="Support Apache">http://www.apache.org/"; target="_blank" 
class="pull-left">
-
-
-
-
-
-
-
-https://www.google.com/search"; 
method="get">
-
-GO
-
-
-
-https://www.apache.org/events/current-event.html";>https://www.apache.org/events/current-event-234x60.png"; alt="Next ASF 
event">
-
-  Save the date!
+
+
+
+
+
+Apache Tomcat® - Which Version Do I Want?
+
+
+
+
+
+
+
+
+
+
+
+http://tomcat.apache.org/";>
+Apache Tomcat®
+
+
+https://www.apache.org/foundation/contributing.html"; target="_blank" 
class="pull-left">https://www.apache.org/images/SupportApache-small.png"; class="support-asf" 
alt="Support Apache">http://www.apache.org/"; target="_blank" 
class="pull-left">
+
+
+
+
+
+
+
+https://www.google.com/search"; method="get">
+
+GO
+
+
+
+https://www.apache.org/events/current-event.html";>https://www.apache.org/events/current-event-234x60.png"; alt="Next ASF 
event">
+  Save the date!
 
-
-
-
-Apache Tomcat
-
-
-Home
-
-
-Taglibs
-
-
-Maven Plugin
-
-
-
-
-Download
-
-
-Which version?
-
-
-https://tomcat.apache.org/download-90.cgi";>Tomcat 9
-
-
-https://tomcat.apache.org/download-80.cgi";>Tomcat 8
-
-
-https://tomcat.apache.org/download-70.cgi";>Tomcat 7
-
-
-https://tomcat.apache.org/download-connectors.cgi";>Tomcat Connectors
-
-
-https://tomcat.apache.org/download-native.cgi";>Tomcat Native
-
-
-https://tomcat.apache.org/download-taglibs.cgi";>Taglibs
-
-
-https://archive.apache.org/dist/tomcat/";>Archives
-
-
-
-
-Documentation
-
-
-Tomcat 9.0
-
-
-

svn commit: r1865415 [1/2] - in /tomcat/site/trunk: docs/ xdocs/

2019-08-19 Thread markt
Author: markt
Date: Mon Aug 19 07:54:22 2019
New Revision: 1865415

URL: http://svn.apache.org/viewvc?rev=1865415&view=rev
Log:
Update site for 9.0.24 release

Modified:
tomcat/site/trunk/docs/doap_Tomcat.rdf
tomcat/site/trunk/docs/download-90.html
tomcat/site/trunk/docs/index.html
tomcat/site/trunk/docs/migration-9.html
tomcat/site/trunk/docs/oldnews.html
tomcat/site/trunk/docs/whichversion.html
tomcat/site/trunk/xdocs/doap_Tomcat.rdf
tomcat/site/trunk/xdocs/download-90.xml
tomcat/site/trunk/xdocs/index.xml
tomcat/site/trunk/xdocs/migration-9.xml
tomcat/site/trunk/xdocs/oldnews.xml
tomcat/site/trunk/xdocs/whichversion.xml

Modified: tomcat/site/trunk/docs/doap_Tomcat.rdf
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/doap_Tomcat.rdf?rev=1865415&r1=1865414&r2=1865415&view=diff
==
--- tomcat/site/trunk/docs/doap_Tomcat.rdf (original)
+++ tomcat/site/trunk/docs/doap_Tomcat.rdf Mon Aug 19 07:54:22 2019
@@ -60,8 +60,8 @@
 
   
 Latest Stable 9.0.x Release
-2019-07-09
-9.0.22
+2019-08-17
+9.0.24
   
 
 

Modified: tomcat/site/trunk/docs/download-90.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/download-90.html?rev=1865415&r1=1865414&r2=1865415&view=diff
==
--- tomcat/site/trunk/docs/download-90.html (original)
+++ tomcat/site/trunk/docs/download-90.html Mon Aug 19 07:54:22 2019
@@ -219,7 +219,7 @@
 Quick Navigation
 
 
-[define v]9.0.22[end]
+[define v]9.0.24[end]
 https://www.apache.org/dist/tomcat/tomcat-9/KEYS";>KEYS |
 [v] |
 Browse |

Modified: tomcat/site/trunk/docs/index.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/index.html?rev=1865415&r1=1865414&r2=1865415&view=diff
==
--- tomcat/site/trunk/docs/index.html (original)
+++ tomcat/site/trunk/docs/index.html Mon Aug 19 07:54:22 2019
@@ -243,60 +243,61 @@ project logo are trademarks of the Apach
 
 
 
-
-2019-07-29 Tomcat 7.0.96 Released
+
+2019-08-17 Tomcat 9.0.24 Released
 
 
 
-The Apache Tomcat Project is proud to announce the release of version 7.0.96 of
-Apache Tomcat. This release contains a number of bug fixes and improvements
-compared to version 7.0.94.
+The Apache Tomcat Project is proud to announce the release of version 9.0.24
+of Apache Tomcat. The notable changes compared to 9.0.22 include:
+
+
+
+Expand Graal native image support to include JNDI, JSPs and JULI
+
+Expand the HTTP/2 excessive overhead protection to cover various forms
+of abusive client behaviour and close the connection if any such
+behaviour is detected.
+
+Security improvements to the Windows installer including a change in
+the default user from Local System to Local Service.
+
+
 
 
 
 Full details of these changes, and all the other changes, are available in the
-Tomcat 7 
changelog.
+Tomcat 9
+changelog.
 
 
 
 
 
-https://tomcat.apache.org/download-70.cgi";>Download
+https://tomcat.apache.org/download-90.cgi";>Download
 
 
 
 
-
-2019-07-09 Tomcat 9.0.22 Released
+
+2019-07-29 Tomcat 7.0.96 Released
 
 
 
-The Apache Tomcat Project is proud to announce the release of version 9.0.22
-of Apache Tomcat. The notable changes compared to 9.0.21 include:
-
-
-
-Add user buildable optional modules for easier CDI 2 and JAX-RS support.
-Also include a new documentation page describing how to use it.
-
-Update to Tomcat Native 1.2.23 including Windows binaries built with 
OpenSSL
-1.1.1c.
-
-Update to Eclipse Complier for Java 4.12.
-
-
+The Apache Tomcat Project is proud to announce the release of version 7.0.96 of
+Apache Tomcat. This release contains a number of bug fixes and improvements
+compared to version 7.0.94.
 
 
 
 Full details of these changes, and all the other changes, are available in the
-Tomcat 9
-changelog.
+Tomcat 7 
changelog.
 
 
 
 
 
-https://tomcat.apache.org/download-90.cgi";>Download
+https://tomcat.apache.org/download-70.cgi";>Download
 
 
 

Modified: tomcat/site/trunk/docs/migration-9.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/migration-9.html?rev=1865415&r1=1865414&r2=1865415&view=diff
==
--- tomcat/site/trunk/docs/migration-9.html (original)
+++ tomcat/site/trunk/docs/migration-9.html Mon Aug 19 07:54:22 2019
@@ -871,8 +871,9 @@ of Apache Tomcat.
 9.0.17
 9.0.19
 9.0.20
-9.0.21
-9.0.22
+9.0.21
+9.0.22
+9.0.24
 , new version:
 
 9.0.0.M1
@@ -909,7 +910,8 @@ of Apache Tomcat.
 9.0.19
 9.0.20
 9.0.21
-9.0.22
+9.0.22
+9.0.24
 trunk (unreleased)
 
 

Modified: tomcat/site/trunk/docs/oldnews.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/oldnews.h

svn commit: r1865412 - in /tomcat/site/trunk: ./ docs/tomcat-9.0-doc/ docs/tomcat-9.0-doc/api/ docs/tomcat-9.0-doc/api/org/apache/catalina/ docs/tomcat-9.0-doc/api/org/apache/catalina/ant/ docs/tomcat

2019-08-19 Thread markt
Author: markt
Date: Mon Aug 19 07:24:41 2019
New Revision: 1865412

URL: http://svn.apache.org/viewvc?rev=1865412&view=rev
Log:
Update docs for 9.0.24 release


[This commit notification would consist of 74 parts, 
which exceeds the limit of 50 ones, so it was shortened to the summary.]

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org