[Bug 62641] libtool invocations should use --tag=CC

2019-08-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62641
Bug 62641 depends on bug 62640, which changed state.

Bug 62640 Summary: libtool invocations should use --tag=CC
https://bz.apache.org/bugzilla/show_bug.cgi?id=62640

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63690] [HTTP/2] The socket [*] associated with this connection has been closed.

2019-08-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63690

--- Comment #2 from Boris Petrov  ---
Created attachment 36734
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=36734=edit
Log

This is a dump of the logging for `org.apache.coyote.http2`.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63690] [HTTP/2] The socket [*] associated with this connection has been closed.

2019-08-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63690

--- Comment #1 from Mark Thomas  ---
Enable debug logging for org.apache.coyote.http2 and provide the output for a
single, failed request.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



buildbot failure in on tomcat-trunk

2019-08-23 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building 
tomcat. Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/4566

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: asf946_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
triggered this build
Build Source Stamp: [branch master] f068f80ae3a9e865974abaddd6192880ecdf3ff9
Blamelist: Rainer Jung 

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[tomcat] branch 8.5.x updated: Fix trivial typo in changelog.

2019-08-23 Thread rjung
This is an automated email from the ASF dual-hosted git repository.

rjung pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/8.5.x by this push:
 new 4fc4825  Fix trivial typo in changelog.
4fc4825 is described below

commit 4fc4825f8c2d739cefe67a3c29f4907ab6a35922
Author: Rainer Jung 
AuthorDate: Fri Aug 23 20:05:00 2019 +0200

Fix trivial typo in changelog.
---
 webapps/docs/changelog.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 6fed418..1b66477 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -128,7 +128,7 @@
   
   
 57665: Add support for the X-Forwarded-Host
-header to the RemoteIpFilter and 
RemotepValve.
+header to the RemoteIpFilter and 
RemoteIpValve.
 (markt)
   
   


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[tomcat] branch master updated: Fix small typo in changelog.

2019-08-23 Thread rjung
This is an automated email from the ASF dual-hosted git repository.

rjung pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/master by this push:
 new f068f80  Fix small typo in changelog.
f068f80 is described below

commit f068f80ae3a9e865974abaddd6192880ecdf3ff9
Author: Rainer Jung 
AuthorDate: Fri Aug 23 19:52:56 2019 +0200

Fix small typo in changelog.
---
 webapps/docs/changelog.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index bd0919c..f3431f4 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -103,7 +103,7 @@
   
   
 57665: Add support for the X-Forwarded-Host
-header to the RemoteIpFilter and 
RemotepValve.
+header to the RemoteIpFilter and 
RemoteIpValve.
 (markt)
   
   


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63690] New: [HTTP/2] The socket [*] associated with this connection has been closed.

2019-08-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63690

Bug ID: 63690
   Summary: [HTTP/2] The socket [*] associated with this
connection has been closed.
   Product: Tomcat 9
   Version: 9.0.x
  Hardware: PC
OS: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: Connectors
  Assignee: dev@tomcat.apache.org
  Reporter: boris_pet...@live.com
  Target Milestone: -

Tomcat is version 9.0.24, APR 1.7.0, Tomcat Native 1.2.23.

When using HTTP/2, doing a multipart post request from any browser causes this
exception 99% of the cases:

~~~
javax.ws.rs.ProcessingException: Failed to buffer the message content input
stream.
at
org.glassfish.jersey.message.internal.InboundMessageContext.bufferEntity(InboundMessageContext.java:907)
at user-code(SourceFile:58)
...
Caused by: org.apache.catalina.connector.ClientAbortException:
java.io.IOException: The socket [140,613,069,382,992] associated with this
connection has been closed.
at
org.apache.catalina.connector.InputBuffer.realReadBytes(InputBuffer.java:340)
at
org.apache.catalina.connector.InputBuffer.checkByteBufferEof(InputBuffer.java:632)
at org.apache.catalina.connector.InputBuffer.read(InputBuffer.java:362)
at
org.apache.catalina.connector.CoyoteInputStream.read(CoyoteInputStream.java:132)
at
org.apache.catalina.connector.CoyoteInputStream.read(CoyoteInputStream.java:110)
at
org.glassfish.jersey.message.internal.ReaderWriter.writeTo(ReaderWriter.java:92)
at
org.glassfish.jersey.message.internal.InboundMessageContext.bufferEntity(InboundMessageContext.java:894)
... 52 common frames omitted
Caused by: java.io.IOException: The socket [140,613,069,382,992] associated
with this connection has been closed.
at
org.apache.tomcat.util.net.AprEndpoint$AprSocketWrapper.doWrite(AprEndpoint.java:2315)
at
org.apache.tomcat.util.net.SocketWrapperBase.doWrite(SocketWrapperBase.java:793)
at
org.apache.tomcat.util.net.SocketWrapperBase.writeBlocking(SocketWrapperBase.java:529)
at
org.apache.tomcat.util.net.SocketWrapperBase.write(SocketWrapperBase.java:454)
at
org.apache.coyote.http2.Http2UpgradeHandler.writeWindowUpdate(Http2UpgradeHandler.java:770)
at
org.apache.coyote.http2.Stream$StreamInputBuffer.doRead(Stream.java:1122)
at org.apache.coyote.Request.doRead(Request.java:551)
at
org.apache.catalina.connector.InputBuffer.realReadBytes(InputBuffer.java:336)
... 58 common frames omitted
~~~

Switching back to HTTP/1.1 by commenting out `` in `conf/server.xml` fixes
the issue.

I've no idea what could I have done wrong. GET requests are working fine as
well as not-multipart post ones (or perhaps they are not so big and that's why
they work). Not sure if that matters.

Please tell me how can I help to debug the issue. Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63689] New: Variable DISPLAYNAME in service.bat is empty instead of containing service display name.

2019-08-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63689

Bug ID: 63689
   Summary: Variable DISPLAYNAME in service.bat is empty instead
of containing service display name.
   Product: Tomcat 9
   Version: 9.0.24
  Hardware: PC
Status: NEW
  Severity: normal
  Priority: P2
 Component: Packaging
  Assignee: dev@tomcat.apache.org
  Reporter: tschoen...@am-soft.de
  Target Milestone: -

service.bat from Tomcat 9.0.24 contains the following line:

> --DisplayName "%DISPLAYNAME%" ^

The problem is that this variable is used only ones and never defined anywhere.
The same named file in Tomcat 8.0.53 additionally uses lines like the
following:

> set SERVICE_NAME=%1
> set DISPLAYNAME=Apache Tomcat 8.0 %1

While most parts of the service are registered properly in Tomcat 9, it's not
visible in the GUI service manager started using services.msc in the end. The
problem was introduced in Bug 63285 in the following commit:

https://github.com/apache/tomcat/commit/7ac5fc8a59c10e7de1ee6d4b85c1ee797942a1e7#diff-e7a950755e93b9d7b1d4f61f74c93fc2

DISPLAYNAME was available before and got removed during C some lines of code:

> if "x%1x" == "x--userx" goto runAsUser
> set SERVICE_NAME=%1
> set DISPLAYNAME=Apache Tomcat @VERSION_MAJOR_MINOR@ %1
> shift

https://github.com/apache/tomcat/commit/7ac5fc8a59c10e7de1ee6d4b85c1ee797942a1e7#diff-e7a950755e93b9d7b1d4f61f74c93fc2L111

Now:

> if "x%1x" == "x--userx" goto runAsUser
> set SERVICE_NAME=%1
> shift

https://github.com/apache/tomcat/commit/7ac5fc8a59c10e7de1ee6d4b85c1ee797942a1e7#diff-e7a950755e93b9d7b1d4f61f74c93fc2R55

Tomcat 8.5.45 has the same problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[tomcat] branch master updated: Update Korean translations

2019-08-23 Thread woonsan
This is an automated email from the ASF dual-hosted git repository.

woonsan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/master by this push:
 new a006961  Update Korean translations
a006961 is described below

commit a006961d28b92dcac93adb1f3afe4a74f7b79be0
Author: Woonsan Ko 
AuthorDate: Fri Aug 23 09:49:58 2019 -0400

Update Korean translations
---
 java/org/apache/catalina/filters/LocalStrings_ko.properties | 2 ++
 java/org/apache/catalina/realm/LocalStrings_ko.properties   | 1 +
 java/org/apache/catalina/valves/LocalStrings_ko.properties  | 2 ++
 java/org/apache/coyote/http11/LocalStrings_ko.properties| 2 ++
 java/org/apache/coyote/http2/LocalStrings_ko.properties | 1 +
 5 files changed, 8 insertions(+)

diff --git a/java/org/apache/catalina/filters/LocalStrings_ko.properties 
b/java/org/apache/catalina/filters/LocalStrings_ko.properties
index 859c7c1..bf28787 100644
--- a/java/org/apache/catalina/filters/LocalStrings_ko.properties
+++ b/java/org/apache/catalina/filters/LocalStrings_ko.properties
@@ -55,6 +55,8 @@ httpHeaderSecurityFilter.committed=HttpHeaderSecurityFilter에 
진입할 때에,
 remoteCidrFilter.invalid=[{0}]을(를) 위해, 유효하지 않은 설정이 제공되었습니다. 상세 정보는 이전 메시지들을 
확인하십시오.
 remoteCidrFilter.noRemoteIp=클라이언트가 IP 주소를 가지고 있지 않습니다. 요청이 거절되었습니다.
 
+remoteIpFilter.invalidHostHeader=HTTP 헤더 [{1}] 내에 유효하지 않은 값이 발견되었습니다: [{0}]
+remoteIpFilter.invalidHostWithPort=HTTP 헤더 [{1}] 내의 호스트 값 [{0}]이(가) 포트 번호를 
포함하고 있는데, 이는 무시될 것입니다.
 remoteIpFilter.invalidNumber=파라미터 [{0}]을(를) 위해 불허되는 숫자입니다: [{1}]
 
 requestFilter.deny=프로퍼티 [{1}]에 기반하여, [{0}]을(를) 위한 요청이 거부되었습니다.
diff --git a/java/org/apache/catalina/realm/LocalStrings_ko.properties 
b/java/org/apache/catalina/realm/LocalStrings_ko.properties
index 92f86d7..6944e54 100644
--- a/java/org/apache/catalina/realm/LocalStrings_ko.properties
+++ b/java/org/apache/catalina/realm/LocalStrings_ko.properties
@@ -102,6 +102,7 @@ realmBase.cannotGetRoles=Principal [{0}](으)로부터 역할들을 얻을 수 
 realmBase.createUsernameRetriever.ClassCastException=클래스 [{0}]이(가) 
X509UsernameRetriever 타입이 아닙니다.
 realmBase.createUsernameRetriever.newInstance=타입이 [{0}]인 객체를 생성할 수 없습니다.
 realmBase.credentialHandler.customCredentialHandler=커스텀 CredentialHandler가 
설정되어 있기에, 프로퍼티 [{0}]을(를) 값 [{1}](으)로 설정할 수 없습니다.
+realmBase.credentialNotDelegated=인증서 저장 옵션이 요청되었지만, 사용자 [{0}]을(를) 위한 인증서 대리 
처리가 사용 가능하지 않습니다.
 realmBase.delegatedCredentialFail=사용자 [{0}]을(를) 위한 대리 인증서를 얻을 수 없습니다.
 realmBase.digest=사용자의 credentials를 digest하는 중 오류 발생
 realmBase.forbidden=요청된 리소스에 대한 접근이 거부되었습니다.
diff --git a/java/org/apache/catalina/valves/LocalStrings_ko.properties 
b/java/org/apache/catalina/valves/LocalStrings_ko.properties
index c684f35..a989cfe 100644
--- a/java/org/apache/catalina/valves/LocalStrings_ko.properties
+++ b/java/org/apache/catalina/valves/LocalStrings_ko.properties
@@ -130,6 +130,8 @@ jdbcAccessLogValve.exception=접근 엔트리를 추가하는 중 예외 발생
 remoteCidrValve.invalid=[{0}]을(를) 위해 유효하지 않은 설정이 제공되었습니다. 상세 정보를 보시려면 이전 메시지들을 
확인하십시오.
 remoteCidrValve.noRemoteIp=클라이언트가 IP 주소를 가지고 있지 않습니다. 요청은 거절되었습니다.
 
+remoteIpValve.invalidHostHeader=HTTP 헤더 [{1}] 내에 유효하지 않은 값이 발견되었습니다: [{0}]
+remoteIpValve.invalidHostWithPort=HTTP 헤더 [{1}] 내의 호스트 값 [{0}]이(가) 포트 번호를 
포함했는데, 이는 무시될 것입니다.
 remoteIpValve.invalidPortHeader=HTTP 헤더 [{1}] 내에 유효하지 않은 포트 번호 값입니다: [{0}]
 
 requestFilterValve.configInvalid=Remote[Addr|Host]Valve를 위해 하나 이상의 유효하지 않은 설정이 
제공되었는데, 이는 해당 Valve와 부모 컨테이너들이 시작되지 못하게 했습니다.
diff --git a/java/org/apache/coyote/http11/LocalStrings_ko.properties 
b/java/org/apache/coyote/http11/LocalStrings_ko.properties
index 235c194..b7fb81e 100644
--- a/java/org/apache/coyote/http11/LocalStrings_ko.properties
+++ b/java/org/apache/coyote/http11/LocalStrings_ko.properties
@@ -26,8 +26,10 @@ http11processor.request.inconsistentHosts=요청 행(request 
line)에 지정된
 http11processor.request.invalidScheme=HTTP 요청이 유효하지 않은 스킴을 가진 절대 URI를 포함했습니다.
 http11processor.request.invalidUri==HTTP 요청이 유효하지 않은 URI를 포함했습니다.
 http11processor.request.invalidUserInfo=HTTP 요청이, 유효하지 않은 userinfo를 가진 절대 URI를 
포함했습니다.
+http11processor.request.multipleContentLength=해당 요청이 복수 개의 Content-Length 헤더들을 
포함했습니다.
 http11processor.request.multipleHosts=요청이 여러 개의 호스트 헤더들을 포함했습니다.
 http11processor.request.noHostHeader=HTTP/1.1 요청이 호스트 헤더를 제공하지 않았습니다.
+http11processor.request.nonNumericContentLength=해당 요청이 숫자가 아닌 Content-Length 
헤더 값을 포함했습니다.
 http11processor.request.prepare=요청을 준비하는 중 오류 발생
 http11processor.request.process=요청 처리 중 오류 발생
 http11processor.response.finish=응답을 완료하는 중 오류 발생
diff --git a/java/org/apache/coyote/http2/LocalStrings_ko.properties 
b/java/org/apache/coyote/http2/LocalStrings_ko.properties
index e47f17e..23b2f67 100644
--- a/java/org/apache/coyote/http2/LocalStrings_ko.properties
+++ b/java/org/apache/coyote/http2/LocalStrings_ko.properties
@@ -44,6 +44,7 @@ hpackdecoder.tableSizeUpdateNotAtStart=테이블 크기 변경은, 반드시 헤
 hpackdecoder.zeroNotValidHeaderTableIndex=0은 

Re: buildbot failure in on tomcat-7-trunk

2019-08-23 Thread Mark Thomas
To save others digging:

https://ci.apache.org/projects/tomcat/tomcat7/logs/1431/TEST-org.apache.catalina.connector.TestCoyoteAdapterRequestFuzzing.APR.txt

One of the fuzzing tests triggered a connection reset rather than a
clean close. Worth digging into why but not a major issue.

Mark


On 22/08/2019 10:40, build...@apache.org wrote:
> The Buildbot has detected a new failure on builder tomcat-7-trunk while 
> building tomcat. Full details are available at:
> https://ci.apache.org/builders/tomcat-7-trunk/builds/1431
> 
> Buildbot URL: https://ci.apache.org/
> 
> Buildslave for this Build: asf946_ubuntu
> 
> Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-7-commit' 
> triggered this build
> Build Source Stamp: [branch 7.0.x] 29fd3a45b909ba2a10792f9641b50ac81c285762
> Blamelist: Mark Thomas 
> 
> BUILD FAILED: failed compile_1
> 
> Sincerely,
>  -The Buildbot
> 
> 
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org