[Bug 63710] HTTP 304 NOT MODIFIED should not set Content-Length

2019-08-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63710

--- Comment #2 from Boris Petrov  ---
Is it possible that the default Tomcat configuration adds this header?

When I run our integration tests (which use the embedded Tomcat), this header
is not present in these responses. However, in production the header is there.

How do I debug who adds it?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63691] Add a no-op JarScanner

2019-08-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63691

--- Comment #2 from Igal Sapir  ---
(In reply to Mark Thomas from comment #1)
> Why not just do
> 
> System.setProperty("tomcat.util.scan.StandardJarScanFilter.jarsToSkip","*.
> jar") ?

IIRC then that still reads the directories and then filters them out. 
Currently I am using the following:

  context.setJarScanner(
new JarScanner() {
  @Override
  public void scan(JarScanType scanType, ServletContext context,
JarScannerCallback callback) {}

   @Override
   public JarScanFilter getJarScanFilter() { return null; }

   @Override
   public void setJarScanFilter(JarScanFilter jarScanFilter) {}
  }
  );

It might be negligible compared to the System property that you cited but then
again the addition is very minor as well.

If you still think that it's not useful then that's fine and we can just close
this ticket as rejected.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63691] Add a no-op JarScanner

2019-08-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63691

Mark Thomas  changed:

   What|Removed |Added

 OS||All

--- Comment #1 from Mark Thomas  ---
Why not just do

System.setProperty("tomcat.util.scan.StandardJarScanFilter.jarsToSkip","*.jar")
?

Untested but you get the idea. Still one line of code for end users and no need
to add an entire new class to Tomcat.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63685] WebappClassLoaderBase and StandardRoot reload classes from jar files on each call of getResource, getResourceAsStream and etc. that hit application startup performance

2019-08-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63685

--- Comment #1 from Mark Thomas  ---
It is expected that a class file is read once and once only when the class is
loaded into memory. Therefore there is no point caching the contents of a class
file.

What use case requires that classes are loaded as resource files rather than
classes? If there is sufficient justification we can always add an option to
cache class files.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63710] HTTP 304 NOT MODIFIED should not set Content-Length

2019-08-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63710

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #1 from Mark Thomas  ---
The default servlet does not do this.

Tomcat does not do this if a Servlet returns a 304 response.

An application may well do this but that would be an application issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



buildbot success in on tomcat-trunk

2019-08-30 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while 
building tomcat. Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/4573

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: asf946_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
triggered this build
Build Source Stamp: [branch master] f58a40f7372fcd4ddc278b969cc0f00d62edeeb8
Blamelist: remm 

Build succeeded!

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[tomcat] branch master updated: Add explicit config for ws upgrade handler

2019-08-30 Thread remm
This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/master by this push:
 new f58a40f  Add explicit config for ws upgrade handler
f58a40f is described below

commit f58a40f7372fcd4ddc278b969cc0f00d62edeeb8
Author: remm 
AuthorDate: Fri Aug 30 16:56:23 2019 +0200

Add explicit config for ws upgrade handler

If an endpoint is not manually accessed, the reflection info is missing.
---
 res/tomcat-maven/tomcat-reflection.json | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/res/tomcat-maven/tomcat-reflection.json 
b/res/tomcat-maven/tomcat-reflection.json
index bf3de8a..00478e0 100644
--- a/res/tomcat-maven/tomcat-reflection.json
+++ b/res/tomcat-maven/tomcat-reflection.json
@@ -46,5 +46,6 @@
 { "name":"org.apache.naming.factory.EjbFactory", "methods" : [{"name": 
"","parameterTypes":[]}] },
 { "name":"org.apache.naming.factory.ResourceEnvFactory", "methods" : [{"name": 
"","parameterTypes":[]}] },
 { "name":"org.apache.naming.factory.ResourceFactory", "methods" : [{"name": 
"","parameterTypes":[]}] },
-{ "name":"org.apache.naming.factory.TransactionFactory", "methods" : [{"name": 
"","parameterTypes":[]}] }
+{ "name":"org.apache.naming.factory.TransactionFactory", "methods" : [{"name": 
"","parameterTypes":[]}] },
+{ "name":"org.apache.tomcat.websocket.server.WsHttpUpgradeHandler", "methods" 
: [{"name": "","parameterTypes":[] }] }
 ]


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63690] [HTTP/2] The socket [*] associated with this connection has been closed.

2019-08-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63690

Boris Petrov  changed:

   What|Removed |Added

Version|9.0.x   |9.0.24

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63710] New: HTTP 304 NOT MODIFIED should not set Content-Length

2019-08-30 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63710

Bug ID: 63710
   Summary: HTTP 304 NOT MODIFIED should not set Content-Length
   Product: Tomcat 9
   Version: 9.0.24
  Hardware: PC
OS: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
  Assignee: dev@tomcat.apache.org
  Reporter: boris_pet...@live.com
  Target Milestone: -

Tomcat seems to set the `Content-Length` header to 0 when the HTTP response
code is 304 (Not Modified). This should not be done. Some references:

https://trac.nginx.org/nginx/ticket/459
https://github.com/playframework/playframework/issues/3899

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [Bug 63699] craigwende...@gmail.com

2019-08-30 Thread Mark Thomas
On 30/08/2019 05:25, bugzi...@apache.org wrote:
> https://bz.apache.org/bugzilla/show_bug.cgi?id=63699

And this idiot has been blocked from Bugzilla.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org