[Bug 63625] Unable to start Tomcat 7.0.96 (stop by 0xc0000005)

2019-09-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63625

--- Comment #21 from Rainer Jung  ---
Probably this one:

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-daemon.git


The following commit(s) were added to refs/heads/master by this push:
 new 4228b53  Correct regression in DAEMON-401
4228b53 is described below

commit 4228b53ec99ae4e7f1d96242fbc8d4a27316fd57
Author: Mark Thomas 
AuthorDate: Tue Sep 3 22:30:37 2019 +0100

Correct regression in DAEMON-401

An incorrect calling convention (__stdcall rather than __cdecl) caused
memory corruption when running as a 32-bit process.
---
 src/changes/changes.xml | 4 
 src/native/windows/include/apxwin.h | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 17e040e..6ce7717 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -42,6 +42,10 @@
   
 jsvc. Correct debug log message that reports change in umask.
   
+  
+Procrun. Correct a regression in the previous fix for this issue that
+caused 32-bit services to crash on start-up.
+   
 
 
   
diff --git a/src/native/windows/include/apxwin.h
b/src/native/windows/include/apxwin.h
index cbd4ac9..1d70063 100644
--- a/src/native/windows/include/apxwin.h
+++ b/src/native/windows/include/apxwin.h
@@ -118,7 +118,7 @@ LPSTR   MzWideToAscii(LPCWSTR ws, LPSTR s);
 LPSTR   WideToANSI(LPCWSTR ws);
 LPSTR   MzWideToANSI(LPCWSTR ws);

-typedef int (__stdcall *WPUTENV) (const wchar_t *env);
+typedef int (*WPUTENV) (const wchar_t *env);

 typedef struct APXMULTISZ APXMULTISZ;
 typedef APXMULTISZ*   LPAPXMULTISZ;



Regards,

Rainer

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63625] Unable to start Tomcat 7.0.96 (stop by 0xc0000005)

2019-09-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63625

--- Comment #20 from Christopher Schultz  ---
(In reply to Mark Thomas from comment #19)
> Tx. I've fixed this in DAEMON and confirmed that it does fix the issue. I'm
> leaving this open until Tomcat is updated to use a Daemon release with the
> fix.

Would you mind posting the commit id for that? I'd like to see the change you
made. It's not often you have to override the compiler to specify a calling
convention on the CALLER's side...

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63625] Unable to start Tomcat 7.0.96 (stop by 0xc0000005)

2019-09-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63625

--- Comment #19 from Mark Thomas  ---
Tx. I've fixed this in DAEMON and confirmed that it does fix the issue. I'm
leaving this open until Tomcat is updated to use a Daemon release with the fix.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63689] Variable DISPLAYNAME in service.bat is empty instead of containing service display name.

2019-09-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63689

Mark Thomas  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED
 OS||All

--- Comment #1 from Mark Thomas  ---
Thanks for the report and the analysis.

Fixed in:
- master for 9.0.25 onwards
- 8.5.x for 8.5.46 onwards

It was also fixed in 7.0.x but the bg was never included in a release.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[tomcat] branch 7.0.x updated: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63689 display name

2019-09-03 Thread markt
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 7.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/7.0.x by this push:
 new abe297c  Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63689 
display name
abe297c is described below

commit abe297c8d9295354506ff193742fcd29a2e61190
Author: Mark Thomas 
AuthorDate: Tue Sep 3 20:37:52 2019 +0100

Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63689 display name

Correct a regression in the fix for
https://bz.apache.org/bugzilla/show_bug.cgi?id=63285 that meant the
display name was not set.
---
 bin/service.bat | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bin/service.bat b/bin/service.bat
index 0aee372..d9188ec 100755
--- a/bin/service.bat
+++ b/bin/service.bat
@@ -210,7 +210,7 @@ if exist "%CATALINA_HOME%\bin\%DEFAULT_SERVICE_NAME%.exe" (
 
 "%EXECUTABLE%" //IS//%SERVICE_NAME% ^
 --Description "Apache Tomcat @VERSION@ Server - 
https://tomcat.apache.org/; ^
---DisplayName "%DISPLAYNAME%" ^
+--DisplayName "Apache Tomcat @VERSION_MAJOR_MINOR@ %SERVICE_NAME%" ^
 --Install "%EXECUTABLE%" ^
 --LogPath "%CATALINA_BASE%\logs" ^
 --StdOutput auto ^


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[tomcat] branch 8.5.x updated: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63689 display name

2019-09-03 Thread markt
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/8.5.x by this push:
 new 3cf8893  Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63689 
display name
3cf8893 is described below

commit 3cf88939bfb684a4755aa05ec3b07d7a736757f9
Author: Mark Thomas 
AuthorDate: Tue Sep 3 20:37:52 2019 +0100

Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63689 display name

Correct a regression in the fix for
https://bz.apache.org/bugzilla/show_bug.cgi?id=63285 that meant the
display name was not set.
---
 bin/service.bat| 2 +-
 webapps/docs/changelog.xml | 5 +
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/bin/service.bat b/bin/service.bat
index 0aee372..d9188ec 100755
--- a/bin/service.bat
+++ b/bin/service.bat
@@ -210,7 +210,7 @@ if exist "%CATALINA_HOME%\bin\%DEFAULT_SERVICE_NAME%.exe" (
 
 "%EXECUTABLE%" //IS//%SERVICE_NAME% ^
 --Description "Apache Tomcat @VERSION@ Server - 
https://tomcat.apache.org/; ^
---DisplayName "%DISPLAYNAME%" ^
+--DisplayName "Apache Tomcat @VERSION_MAJOR_MINOR@ %SERVICE_NAME%" ^
 --Install "%EXECUTABLE%" ^
 --LogPath "%CATALINA_BASE%\logs" ^
 --StdOutput auto ^
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 2b1c5db..115f12a 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -111,6 +111,11 @@
 Fix JSSE_OPTS quoting in catalina.bat.
 Contributed by Peter Uhnak. (fschumacher)
   
+  
+63689: Correct a regression in the fix for 63285
+that meant that when installing a service, the service display name was
+not set. (markt)
+  
 
   
 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[tomcat] branch master updated: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63689 display name

2019-09-03 Thread markt
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/master by this push:
 new e8d992d  Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63689 
display name
e8d992d is described below

commit e8d992d3d6b32cb24e1f6319b57a86bd12b251db
Author: Mark Thomas 
AuthorDate: Tue Sep 3 20:37:52 2019 +0100

Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63689 display name

Correct a regression in the fix for
https://bz.apache.org/bugzilla/show_bug.cgi?id=63285 that meant the
display name was not set.
---
 bin/service.bat| 2 +-
 webapps/docs/changelog.xml | 5 +
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/bin/service.bat b/bin/service.bat
index 0aee372..d9188ec 100755
--- a/bin/service.bat
+++ b/bin/service.bat
@@ -210,7 +210,7 @@ if exist "%CATALINA_HOME%\bin\%DEFAULT_SERVICE_NAME%.exe" (
 
 "%EXECUTABLE%" //IS//%SERVICE_NAME% ^
 --Description "Apache Tomcat @VERSION@ Server - 
https://tomcat.apache.org/; ^
---DisplayName "%DISPLAYNAME%" ^
+--DisplayName "Apache Tomcat @VERSION_MAJOR_MINOR@ %SERVICE_NAME%" ^
 --Install "%EXECUTABLE%" ^
 --LogPath "%CATALINA_BASE%\logs" ^
 --StdOutput auto ^
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 18277ca..f5038b7 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -92,6 +92,11 @@
 Fix JSSE_OPTS quoting in catalina.bat.
 Contributed by Peter Uhnak. (fschumacher)
   
+  
+63689: Correct a regression in the fix for 63285
+that meant that when installing a service, the service display name was
+not set. (markt)
+  
 
   
 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63685] WebappClassLoaderBase and StandardRoot reload classes from jar files on each call of getResource, getResourceAsStream and etc. that hit application startup performance

2019-09-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63685

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org