Re: Possible bug in Http11Processor/SocketWrapperBase

2019-10-12 Thread Michael Osipov
Am 2019-10-11 um 17:06 schrieb Mark Thomas: On 11/10/2019 13:21, Michael Osipov wrote: Folks, while working on BZ-63835 I have noticed an odd thing and I'd like someone to review whether my code/understanding is wrong or the one already present in Tomcat. we have a total of 100 requests

Re: [VOTE] Private branches in the official Tomcat git repository

2019-10-12 Thread Michael Osipov
Am 2019-10-12 um 15:57 schrieb Konstantin Kolinko: пт, 11 окт. 2019 г. в 17:21, Rémy Maucherat : Hi, This vote is to regulate the use of branches in the official Tomcat repository beyond branches that are approved by the community such as 8.5.x and 7.0.x. It is possible to do development in

Re: [VOTE] Private branches in the official Tomcat git repository

2019-10-12 Thread Felix Schumacher
Am 11.10.19 um 16:43 schrieb Rémy Maucherat: > On Fri, Oct 11, 2019 at 4:30 PM Michael Osipov > wrote: > > Am 2019-10-11 um 16:20 schrieb Rémy Maucherat: > > Hi, > > > > This vote is to regulate the use of branches in the official Tomcat > >

Re: [VOTE] Private branches in the official Tomcat git repository

2019-10-12 Thread Guoxiong Li
> If we call them not "private" branches, but "feature" branches The "feature" branches is a better name to state these branches. If the feature branch could be created and named after passing a vote which could prevent excessive branches and bad branch name, the branches would be better

Re: [VOTE] Private branches in the official Tomcat git repository

2019-10-12 Thread Romain Manni-Bucau
Le sam. 12 oct. 2019 à 15:57, Konstantin Kolinko a écrit : > пт, 11 окт. 2019 г. в 17:21, Rémy Maucherat : > > > > Hi, > > > > This vote is to regulate the use of branches in the official Tomcat > repository beyond branches that are approved by the community such as 8.5.x > and 7.0.x. It is

Re: [VOTE] Private branches in the official Tomcat git repository

2019-10-12 Thread Konstantin Kolinko
пт, 11 окт. 2019 г. в 17:21, Rémy Maucherat : > > Hi, > > This vote is to regulate the use of branches in the official Tomcat > repository beyond branches that are approved by the community such as 8.5.x > and 7.0.x. It is possible to do development in private branches directly in > the

[Bug 63833] NPE in DBCP when attempting to connect to a database that doesn't exist

2019-10-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63833 --- Comment #6 from Konstantin Kolinko --- (In reply to Christopher Schultz from comment #4) It is much better to keep discussion in one place in Bugzilla, rather than scattered among maybe several PRs. I was wondering why this bug report is

[Bug 63833] NPE in DBCP when attempting to connect to a database that doesn't exist

2019-10-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63833 --- Comment #5 from Guoxiong Li --- I once submitted a PR to solve a issue. But the PR was not good enough to merge so that the committer solved the issue by himself and closed my PR without merging. As a result, I attach the patch to this BZ

[Bug 63835] Add support for Keep-Alive header

2019-10-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63835 --- Comment #6 from Michael Osipov --- (In reply to Mark Thomas from comment #5) > The proposal never went past draft 03 in 2012. I'm wondering why. Me too. > The max parameter is already deprecated in draft 03. I don't think Tomcat > should

[Bug 63833] NPE in DBCP when attempting to connect to a database that doesn't exist

2019-10-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63833 --- Comment #4 from Christopher Schultz --- Both reviews and edits can all be done in a PR. Why attach successive patches to this BZ issue when you plan in issuing a PR anyway? -- You are receiving this mail because: You are the assignee for

Re: [VOTE] Private branches in the official Tomcat git repository

2019-10-12 Thread Rainer Jung
Am 11.10.2019 um 16:20 schrieb Rémy Maucherat: Hi, This vote is to regulate the use of branches in the official Tomcat repository beyond branches that are approved by the community such as 8.5.x and 7.0.x. It is possible to do development in private branches directly in the official Tomcat

Re: [VOTE] Private branches in the official Tomcat git repository

2019-10-12 Thread Romain Manni-Bucau
[No] (non binding). As a big github user, i expect main repo to not have unofficially supported code. I work with this kind of setup (for CI) and it is a mess at all layers compared to natural PR structure IMHO. Le sam. 12 oct. 2019 à 02:05, Chuck Caldarale a écrit : > On Oct 11, 2019, at

[Bug 63833] NPE in DBCP when attempting to connect to a database that doesn't exist

2019-10-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63833 Guoxiong Li changed: What|Removed |Added Attachment #36823|0 |1 is obsolete|