buildbot success in on tomcat-trunk

The Buildbot has detected a restored build on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/4754 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The

[tomcat] branch master updated: Fix test

This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 9d7cb54 Fix test 9d7cb54 is described below

[Bug 63859] AJP cping/cpong mode failing on Tomcat 9.x

https://bz.apache.org/bugzilla/show_bug.cgi?id=63859 --- Comment #19 from Mark Thomas --- Thanks for those logs. The Tomcat debug logs were useful. I'm now reasonably sure Tomcat is closing the connection because of an IOException. However, the logs don't show the exception. I have extended the

[tomcat] branch master updated: Refactor endpoint close/destroySocket API

This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new a8388e7 Refactor endpoint close/destroySocket

[tomcat] branch 8.5.x updated: Additional debug logging to investigate bug 63859

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new e92da8e Additional debug logging to investigate

[tomcat] branch master updated: Additional debug logging to investigate bug 63859

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 203057c Additional debug logging to investigate

Re: [VOTE] Release Apache Tomcat 8.5.49

On 19/11/2019 19:29, Rémy Maucherat wrote: > On Tue, Nov 19, 2019 at 5:58 PM Mark Thomas > wrote: > > On 19/11/2019 00:44, Konstantin Kolinko wrote: > > I think the single pollset change should not be backported to > Tomcat 7. > > I am OK with it being

Re: [VOTE] Release Apache Tomcat 8.5.49

On Tue, Nov 19, 2019 at 5:58 PM Mark Thomas wrote: > On 19/11/2019 00:44, Konstantin Kolinko wrote: > > вт, 19 нояб. 2019 г. в 01:42, Mark Thomas : > >> > >> On 18/11/2019 22:01, Rémy Maucherat wrote: > >>> On Mon, Nov 18, 2019 at 10:22 PM Mark Thomas >>> > wrote: > >>

buildbot failure in on tomcat-trunk

The Buildbot has detected a new failure on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/4751 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchScheduler

[tomcat] branch master updated: Adjust changelog to reflect which releases actually contain which improvements to the CSRF prevention filter.

This is an automated email from the ASF dual-hosted git repository. schultz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 1f5b578 Adjust changelog to reflect which

[tomcat] branch master updated: Move initialization of CSRF REST nonce header name context attribute into the RestCsrfPreventionFilter where it belongs.

This is an automated email from the ASF dual-hosted git repository. schultz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new f651d87 Move initialization of CSRF REST

Re: [tomcat] branch master updated: Add missing changelog for CSRF prevention filter changes.

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Mark, On 11/19/19 12:41, Mark Thomas wrote: >> All, >> >> This claims that these changes are being added in 9.0.30 which is >> only partially correct. Some of these changes were made in 9.0.29 >> which is currently under release-vote. >> >> I

[tomcat] branch master updated: Allow customization of the CSRF prevention filter's request parameter name.

This is an automated email from the ASF dual-hosted git repository. schultz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 707e194 Allow customization of the CSRF

buildbot success in on tomcat-trunk

The Buildbot has detected a restored build on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/4749 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The

Re: [tomcat] branch master updated: Add missing changelog for CSRF prevention filter changes.

> All, > > This claims that these changes are being added in 9.0.30 which is only > partially correct. Some of these changes were made in 9.0.29 which is > currently under release-vote. > > I wasn't sure how everyone felt about me changing the changelog for a > release that is already kind of

Re: [tomcat] branch master updated: Add missing changelog for CSRF prevention filter changes.

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, This claims that these changes are being added in 9.0.30 which is only partially correct. Some of these changes were made in 9.0.29 which is currently under release-vote. I wasn't sure how everyone felt about me changing the changelog for a

[tomcat] branch master updated: Add missing changelog for CSRF prevention filter changes.

This is an automated email from the ASF dual-hosted git repository. schultz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new decb12b Add missing changelog for CSRF

[tomcat] branch master updated: Post-review from kkolonko: fix typo in constant name, push initialization down into subclass.

This is an automated email from the ASF dual-hosted git repository. schultz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new cab2a8e Post-review from kkolonko: fix typo

[tomcat] branch master updated: Add logging to CSRF prevention listener.

This is an automated email from the ASF dual-hosted git repository. schultz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new a783e4e Add logging to CSRF prevention

Re: [tomcat] branch master updated: Improve CSRF prevention filter by exposing the request's current nonce to the request.

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Konstantin, Thanks for the review. On 11/16/19 16:12, Konstantin Kolinko wrote: > сб, 16 нояб. 2019 г. в 18:55, : > >> >> This is an automated email from the ASF dual-hosted git >> repository. >> >> schultz pushed a commit to branch master in

Re: [VOTE] Release Apache Tomcat 8.5.49

On 19/11/2019 00:44, Konstantin Kolinko wrote: > вт, 19 нояб. 2019 г. в 01:42, Mark Thomas : >> >> On 18/11/2019 22:01, Rémy Maucherat wrote: >>> On Mon, Nov 18, 2019 at 10:22 PM Mark Thomas >> > wrote: >> >>> Is porting the multipoller removal to 7.0 really doable ? >> >>

buildbot failure in on tomcat-trunk

The Buildbot has detected a new failure on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/4748 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchScheduler

[tomcat] branch 8.5.x updated: Fix broken link.

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 16d6a19 Fix broken link. 16d6a19 is described

[tomcat] branch master updated: Fix broken link.

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new f403a56 Fix broken link. f403a56 is described

[Bug 63932] Content compression breaks contract of ETag

https://bz.apache.org/bugzilla/show_bug.cgi?id=63932 --- Comment #14 from Michael Osipov --- (In reply to Remy Maucherat from comment #12) > Doing cosmetic configuration changes like this is not a good idea. When the > subelements of Connector were introduced, it was out of necessity to >

[Bug 63932] Content compression breaks contract of ETag

https://bz.apache.org/bugzilla/show_bug.cgi?id=63932 --- Comment #13 from Michael Osipov --- (In reply to Konstantin Kolinko from comment #11) > (In reply to Michael Osipov from comment #8) > > > > I get the feeling that compression configuration must be moved sooner or > > later to a

Re: [VOTE] Release Apache Tomcat 9.0.29

On 16/11/2019 19:56, Mark Thomas wrote: The proposed Apache Tomcat 9.0.29 release is now available for voting. The major changes compared to the 9.0.27 release are: - Improvements to Async error handling - Stricter processing of HTTP headers when looking for specific token values - Fix

[Bug 63859] AJP cping/cpong mode failing on Tomcat 9.x

https://bz.apache.org/bugzilla/show_bug.cgi?id=63859 --- Comment #18 from Aurelien Pernoud --- Of course I didn't mention that but the catalina logs is the one from tom_tst01_srv09 ! -- You are receiving this mail because: You are the assignee for the bug.

[Bug 63859] AJP cping/cpong mode failing on Tomcat 9.x

Pernoud --- Hi, I've reproduced the bug with mode CI after one day... do definitely related to CI I think :) I uploaded a new zip in your dropboy with : mod_jk.log.20191119 from both nodes You0'll see both of them have some "(tom_tst01_srv09) timeout in reply cpong after 100

[Bug 63932] Content compression breaks contract of ETag

https://bz.apache.org/bugzilla/show_bug.cgi?id=63932 --- Comment #12 from Remy Maucherat --- Doing cosmetic configuration changes like this is not a good idea. When the subelements of Connector were introduced, it was out of necessity to implement SNI, not to beautify. It caused a lot of bugs

[Bug 63932] Content compression breaks contract of ETag

https://bz.apache.org/bugzilla/show_bug.cgi?id=63932 --- Comment #11 from Konstantin Kolinko --- (In reply to Michael Osipov from comment #8) > > I get the feeling that compression configuration must be moved sooner or > later to a subelement beneath a connector. Enabling compression globally

[tomcat] branch master updated: Polish. Align with 8.5.x.

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 913e941 Polish. Align with 8.5.x. 913e941 is

[tomcat] branch 8.5.x updated (a3cc1b7 -> 8120030)

This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from a3cc1b7 Increment version for next dev cycle new 4508e70 Refactor APR Poller to remove use of multiple pollsets

[tomcat] 02/02: Remove extra space

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 81200306c3a20a1b38c9c3795b23efae5b8edff3 Author: Mark Thomas AuthorDate: Tue Nov 19 13:24:38 2019 + Remove extra

[tomcat] 01/02: Refactor APR Poller to remove use of multiple pollsets

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 4508e70e4fcf542c6071ef77c13cd7141abb9bf4 Author: Mark Thomas AuthorDate: Tue Nov 19 13:18:36 2019 + Refactor APR

[Bug 63625] Unable to start Tomcat 7.0.96 (stop by 0xc0000005)

https://bz.apache.org/bugzilla/show_bug.cgi?id=63625 --- Comment #27 from Tony Yan --- Thank you very much for such quick response, Mark. I will download the Commons Daemon 1.2.1. And thanks all the people for the contributions in this fix. -- You are receiving this mail because: You are the

[Bug 63939] CORS filter incorrectly implements same/local origin check

https://bz.apache.org/bugzilla/show_bug.cgi?id=63939 Michael Osipov changed: What|Removed |Added CC||micha...@apache.org -- You are

[Bug 63939] New: CORS filter incorrectly implements same/local origin check

https://bz.apache.org/bugzilla/show_bug.cgi?id=63939 Bug ID: 63939 Summary: CORS filter incorrectly implements same/local origin check Product: Tomcat 9 Version: 9.0.x Hardware: All OS: All

[Bug 63931] The remote endpoint was in state [TEXT_FULL_WRITING] which is an invalid state

https://bz.apache.org/bugzilla/show_bug.cgi?id=63931 --- Comment #8 from Saurav Singh --- Hey Mark! Sorry if my tone of comment #6 sounds something different which wasn't meant to be its just being impatient. When i raised the bug with Apche i didn't think of cost involved; its apache

[Bug 63938] CORS filter adds headers to non-CORS request

https://bz.apache.org/bugzilla/show_bug.cgi?id=63938 Michael Osipov changed: What|Removed |Added CC||micha...@apache.org -- You are

[Bug 63931] The remote endpoint was in state [TEXT_FULL_WRITING] which is an invalid state

https://bz.apache.org/bugzilla/show_bug.cgi?id=63931 --- Comment #7 from Mark Thomas --- >From the tone of comment #6 you appear to have forgotten that everyone here is a volunteer, providing you with help and assistance (at no cost) to use the software that you have been given (also at no

[Bug 63938] New: CORS filter adds headers to non-CORS request

https://bz.apache.org/bugzilla/show_bug.cgi?id=63938 Bug ID: 63938 Summary: CORS filter adds headers to non-CORS request Product: Tomcat 9 Version: 9.0.x Hardware: All OS: All Status: NEW Severity: normal

Re: Possible optimization for class loading?

On 17/11/2019 16:34, Rainer Jung wrote: > Am 17.11.2019 um 17:21 schrieb Konstantin Kolinko: >> Looking into AbstractFileResourceSet.file() from the above stacktrace, >> some check are already there, e.g. "mustExist" flag. I see that >> DirResourceSet.getResource(DirResourceSet.java:101) calls

Re: Bundling of localized messages

> Is there a particular reason (a) the translations are in a separate > JAR file - i.e. not in catalina.jar and (b) they are separated by > language? Perhaps the thought was that, knowing that you don't need > e.g. Korean means you can remove the JAR file from some kind of > bare-ones

[Bug 63932] Content compression breaks contract of ETag

https://bz.apache.org/bugzilla/show_bug.cgi?id=63932 --- Comment #10 from Michael Osipov --- (In reply to Remy Maucherat from comment #9) > (In reply to Mark Thomas from comment #5) > > Where things get "interesting" is when resources set their own, strong ETag. > > It looks to me that the

[Bug 63937] New: CORS preflight request not possible on authenticated endpoints

https://bz.apache.org/bugzilla/show_bug.cgi?id=63937 Bug ID: 63937 Summary: CORS preflight request not possible on authenticated endpoints Product: Tomcat 9 Version: 9.0.x Hardware: All OS: All

[Bug 63937] CORS preflight request not possible on authenticated endpoints

https://bz.apache.org/bugzilla/show_bug.cgi?id=63937 Michael Osipov changed: What|Removed |Added CC||micha...@apache.org -- You are

[Bug 63932] Content compression breaks contract of ETag

https://bz.apache.org/bugzilla/show_bug.cgi?id=63932 --- Comment #9 from Remy Maucherat --- (In reply to Mark Thomas from comment #5) > Where things get "interesting" is when resources set their own, strong ETag. > It looks to me that the simplest solution would be for the container > provided

[Bug 63932] Content compression breaks contract of ETag

https://bz.apache.org/bugzilla/show_bug.cgi?id=63932 Michael Osipov changed: What|Removed |Added CC||micha...@apache.org -- You are

[Bug 63932] Content compression breaks contract of ETag

https://bz.apache.org/bugzilla/show_bug.cgi?id=63932 --- Comment #8 from Michael Osipov --- (In reply to Konstantin Kolinko from comment #6) > (In reply to Mark Thomas from comment #5) > > Please take care, as Julian did, to be specific about whether you are > > talking about weak or strong

[Bug 63932] Content compression breaks contract of ETag

https://bz.apache.org/bugzilla/show_bug.cgi?id=63932 --- Comment #7 from Michael Osipov --- (In reply to Mark Thomas from comment #5) > Please take care, as Julian did, to be specific about whether you are > talking about weak or strong validators. > > RFC 7232 states (section 2.1) > >

[Bug 63625] Unable to start Tomcat 7.0.96 (stop by 0xc0000005)

https://bz.apache.org/bugzilla/show_bug.cgi?id=63625 --- Comment #26 from Mark Thomas --- (In reply to Tony Yan from comment #25) > Does it mean that Tomcat 7.0.96 32bit is not working because the Tomcat7.exe > has defect? Yes. You can download Commons Daemon 1.2.1 and rename the 32-bit