[GitHub] [tomcat] KangZhiDong commented on issue #279: Optimize concurrency

2020-04-21 Thread GitBox
KangZhiDong commented on issue #279: URL: https://github.com/apache/tomcat/pull/279#issuecomment-617485732 > What is the basis for this change? > While the thread is in `wait()`, `notify()` should only be called if one of the conditions in the surrounding `if(...)` is no longer true.

[GitHub] [tomcat] KangZhiDong commented on issue #279: Optimize concurrency

2020-04-21 Thread GitBox
KangZhiDong commented on issue #279: URL: https://github.com/apache/tomcat/pull/279#issuecomment-617483507 > What is the basis for this change? > While the thread is in `wait()`, `notify()` should only be called if one of the conditions in the surrounding `if(...)` is no longer true.

[GitHub] [tomcat] markt-asf commented on issue #279: Optimize concurrency

2020-04-21 Thread GitBox
markt-asf commented on issue #279: URL: https://github.com/apache/tomcat/pull/279#issuecomment-617338009 What is the basis for this change? While the thread is in `wait()`, `notify()` should only be called if one of the conditions in the surrounding `if(...)` is no longer true. I'd

[GitHub] [tomcat] KangZhiDong opened a new pull request #279: Optimize concurrency

2020-04-21 Thread GitBox
KangZhiDong opened a new pull request #279: URL: https://github.com/apache/tomcat/pull/279 more performance This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [tomcat] markt-asf commented on issue #278: display build status on the readme file

2020-04-21 Thread GitBox
markt-asf commented on issue #278: URL: https://github.com/apache/tomcat/pull/278#issuecomment-617270786 For the full list: http://tomcat.apache.org/ci.html This is an automated message from the Apache Git Service. To

[GitHub] [tomcat] govi20 commented on issue #278: display build status on the readme file

2020-04-21 Thread GitBox
govi20 commented on issue #278: URL: https://github.com/apache/tomcat/pull/278#issuecomment-617266944 My assumption was Travis is the only CI. We can add status' at bottom just like apache/spark readme. This is an automated

[Bug 64366] [sse] NPE while closing async http/2 connector

2020-04-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64366 --- Comment #4 from Mark Thomas --- When I try this on both Tomcat 10.0.x and 9.0.x I get a variation of the following: 21-Apr-2020 17:20:36.818 WARNING [Thread-4] org.apache.catalina.loader.WebappClassLoaderBase.clearReferencesThreads The

[GitHub] [tomcat] rmaucher commented on issue #277: Refuse adding invalid HTTP 2.0 headers

2020-04-21 Thread GitBox
rmaucher commented on issue #277: URL: https://github.com/apache/tomcat/pull/277#issuecomment-617239514 I will maintain my -1 For starters, any such HTTP/2 specific nonsense safety nets need to be added to StreamProcessor.prepareHeaders instead of other random locations.

[GitHub] [tomcat] markt-asf commented on issue #278: display build status on the readme file

2020-04-21 Thread GitBox
markt-asf commented on issue #278: URL: https://github.com/apache/tomcat/pull/278#issuecomment-617224872 This assumes Travis is the primary CI system for Tomcat. It isn't. I'm not against this information being added somewhere to the readme file but it needs to make clear Travis is not

[GitHub] [tomcat] govi20 opened a new pull request #278: display build status on the readme file

2020-04-21 Thread GitBox
govi20 opened a new pull request #278: URL: https://github.com/apache/tomcat/pull/278 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[tomcat] branch 7.0.x updated: Add more descriptive error messages in DefaultServlet/JspServlet for SC_NOT_FOUND

2020-04-21 Thread michaelo
This is an automated email from the ASF dual-hosted git repository. michaelo pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new f73fe83 Add more descriptive error messages in

[tomcat] branch master updated: Add more descriptive error messages in DefaultServlet/JspServlet for SC_NOT_FOUND

2020-04-21 Thread michaelo
This is an automated email from the ASF dual-hosted git repository. michaelo pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new ddcc3dd Add more descriptive error messages

[tomcat] branch 8.5.x updated: Add more descriptive error messages in DefaultServlet/JspServlet for SC_NOT_FOUND

2020-04-21 Thread michaelo
This is an automated email from the ASF dual-hosted git repository. michaelo pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 70544d1 Add more descriptive error messages in

[tomcat] branch 9.0.x updated: Add more descriptive error messages in DefaultServlet/JspServlet for SC_NOT_FOUND

2020-04-21 Thread michaelo
This is an automated email from the ASF dual-hosted git repository. michaelo pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 564434d Add more descriptive error messages in

[tomcat-jakartaee-migration] branch master updated: Change the curve of the EC key to run the tests on OpenJDK 15 or later

2020-04-21 Thread ebourg
This is an automated email from the ASF dual-hosted git repository. ebourg pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git The following commit(s) were added to refs/heads/master by this push: new 102f42a Change the curve

Re: StoreConfig and creating context.xml files

2020-04-21 Thread Rémy Maucherat
On Tue, Apr 21, 2020 at 9:27 AM Mark Thomas wrote: > On 20/04/2020 23:01, Rémy Maucherat wrote: > > On Mon, Apr 20, 2020 at 9:46 PM Mark Thomas > > wrote: > > > > Hi, > > > > I'm working in the issue reported on users@ > > > > I've fixed the errors described

[Bug 64366] [sse] NPE while closing async http/2 connector

2020-04-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64366 --- Comment #2 from Claude Brisson --- Created attachment 37190 --> https://bz.apache.org/bugzilla/attachment.cgi?id=37190=edit Servlet keeping running services -- You are receiving this mail because: You are the assignee for the bug.

[Bug 64366] [sse] NPE while closing async http/2 connector

2020-04-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64366 --- Comment #3 from Claude Brisson --- The web application *should* close long-living connections, and tomcat *should* report the problem, I agree. The point is whether tomcat can do better than report an NPE. I attached a simple servlet.

buildbot success in on tomcat-9-trunk

2020-04-21 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-9-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-9-trunk/builds/183 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The

[GitHub] [tomcat] michael-o commented on a change in pull request #277: Filter invalid HTTP 2.0 headers from response

2020-04-21 Thread GitBox
michael-o commented on a change in pull request #277: URL: https://github.com/apache/tomcat/pull/277#discussion_r412098476 ## File path: java/org/apache/coyote/Response.java ## @@ -435,6 +435,20 @@ private boolean checkSpecialHeader( String name, String value) {

[tomcat] 01/02: Add missing JARs. Patch provided by Brian Burch.

2020-04-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit e5cf33b8ab264368f523d08af5d84bddbaa989b0 Author: Mark Thomas AuthorDate: Tue Apr 21 10:05:45 2020 +0100 Add missing

[tomcat] branch 8.5.x updated (acd0cc3 -> 4815be4)

2020-04-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from acd0cc3 Log a warning if addind CredentialHandler to CombinedRealm new e5cf33b Add missing JARs. Patch provided

[tomcat] 02/02: Fix saving of context.xml file from Manager app

2020-04-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 4815be414ab82af37fca351422b9af82a175aa15 Author: Mark Thomas AuthorDate: Tue Apr 21 11:50:51 2020 +0100 Fix saving

[tomcat] branch 9.0.x updated: Fix saving of context.xml file from Manager app

2020-04-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 22c0ead Fix saving of context.xml file from

[tomcat] branch master updated: Fix saving of context.xml file from Manager app

2020-04-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 1a03823 Fix saving of context.xml file from

[GitHub] [tomcat] arkanovicz commented on issue #277: Filter invalid HTTP 2.0 headers from response

2020-04-21 Thread GitBox
arkanovicz commented on issue #277: URL: https://github.com/apache/tomcat/pull/277#issuecomment-617075551 > Could you expand the SSE acronym please. I want to make sure I understand you correctly. [Server-Side Events](https://html.spec.whatwg.org/multipage/server-sent-events.html)

buildbot failure in on tomcat-9-trunk

2020-04-21 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-9-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-9-trunk/builds/182 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The

[GitHub] [tomcat] arkanovicz commented on a change in pull request #277: Filter invalid HTTP 2.0 headers from response

2020-04-21 Thread GitBox
arkanovicz commented on a change in pull request #277: URL: https://github.com/apache/tomcat/pull/277#discussion_r412030387 ## File path: java/org/apache/coyote/Response.java ## @@ -61,6 +62,11 @@ */ private static final Locale DEFAULT_LOCALE = Locale.getDefault();

[Bug 64366] [sse] NPE while closing async http/2 connector

2020-04-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64366 Mark Thomas changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #1 from Mark

[Bug 64335] org.apache.catalina.realm.TestJNDIRealm debug fails missing dependent jars

2020-04-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64335 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[tomcat] branch 9.0.x updated: Add missing JARs. Patch provided by Brian Burch.

2020-04-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 8e63f02 Add missing JARs. Patch provided by Brian

[tomcat] branch master updated: Add missing JARs. Patch provided by Brian Burch.

2020-04-21 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 8ab1eec Add missing JARs. Patch provided by

[Bug 64335] org.apache.catalina.realm.TestJNDIRealm debug fails missing dependent jars

2020-04-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64335 Mark Thomas changed: What|Removed |Added Attachment #37164|0 |1 is patch|

[Bug 64312] Many memberDisappeared messages are logged on all nodes of the cluster with JDK versions 12 or above, even when system is idle

2020-04-21 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64312 Mark Thomas changed: What|Removed |Added Resolution|--- |WORKSFORME Status|REOPENED

[GitHub] [tomcat] martin-g commented on a change in pull request #277: Filter invalid HTTP 2.0 headers from response

2020-04-21 Thread GitBox
martin-g commented on a change in pull request #277: URL: https://github.com/apache/tomcat/pull/277#discussion_r411969053 ## File path: java/org/apache/coyote/Response.java ## @@ -61,6 +62,11 @@ */ private static final Locale DEFAULT_LOCALE = Locale.getDefault();

Re: StoreConfig and creating context.xml files

2020-04-21 Thread Mark Thomas
On 20/04/2020 23:01, Rémy Maucherat wrote: > On Mon, Apr 20, 2020 at 9:46 PM Mark Thomas > wrote: > > Hi, > > I'm working in the issue reported on users@ > > I've fixed the errors described there and have got to the point where >

[GitHub] [tomcat] martin-g commented on a change in pull request #276: Add s390x Travis support

2020-04-21 Thread GitBox
martin-g commented on a change in pull request #276: URL: https://github.com/apache/tomcat/pull/276#discussion_r411923652 ## File path: .travis.yml ## @@ -32,14 +36,7 @@ addons: - libtool-bin install: -- ARCH=`uname -p` -- echo $ARCH --

[GitHub] [tomcat] markt-asf commented on issue #277: Filter invalid HTTP 2.0 headers from response

2020-04-21 Thread GitBox
markt-asf commented on issue #277: URL: https://github.com/apache/tomcat/pull/277#issuecomment-616991103 @arkanovicz You can ignore requests to retest this. I was able to recreate the issue with curl using the steps you describe. Could you expand the SSE acronym please. I want to