Re: flaky HTTP2 test

2020-06-24 Thread Raymond Auge
Sorry folks, but here are two more intermittent Http2 test failures: 2020-06-25T01:09:24.3494270Z[concat] Testsuites with failed tests: 2020-06-25T01:09:24.3496415Z[concat] TEST-org.apache.coyote.http2.TestHttp2Section_5_3.NIO2.txt 2020-06-25T01:09:24.3497981Z[concat]

[Bug 63545] enhancement - add a new pattern attribute for logging user roles

2020-06-24 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63545 --- Comment #5 from Christopher Schultz --- I'm skeptical of the usefulness of this patch, but I won't stop anyone from applying it. I have a short review of the patch as presented. Request.java: I am -1 on this change - public Principal

[Bug 63545] enhancement - add a new pattern attribute for logging user roles

2020-06-24 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63545 --- Comment #4 from Christopher Schultz --- What about roles containing commas? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe,

[Bug 63505] enhancement - support of stored procedures for DataSourceRealm authentication

2020-06-24 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63505 --- Comment #4 from Christopher Schultz --- There might be some refactoring that could help, here. It seems that mostly you are overriding the getPassword(Connection,String) and getRoles(Connection,String) methods from DataSourceRealm, right?

[Bug 63493] enhancement - add JMX counters to monitor authentication and authorization

2020-06-24 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63493 --- Comment #3 from Christopher Schultz --- The patch isn't high-load-safe because the counters are vanilla ints and you use ++ for increment. I think you'd at least need to use AtomicInt. You might want to consider AtomicLong... those

[GitHub] [tomcat] rotty3000 commented on pull request #307: github actions

2020-06-24 Thread GitBox
rotty3000 commented on pull request #307: URL: https://github.com/apache/tomcat/pull/307#issuecomment-649013143 FYI the latest iteration of this runs on Java 8 - 15-ea + windows in 11 minutes https://github.com/rotty3000/tomcat/actions/runs/146537422 The arbitrary reduction was made

[Bug 63362] GlobalRequestProcessor statistics in MBean does not count Websocket communication

2020-06-24 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63362 --- Comment #6 from Mark Thomas --- Working on this. On HTTP/2 at the moment. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe,

Re: flaky HTTP2 test

2020-06-24 Thread Raymond Auge
Sorry about that. I've copied the entire build log here https://gist.github.com/rotty3000/475d92ece3f41123e7092ab31ce30f53 Hopefully you can see that one? - Ray On Wed, Jun 24, 2020 at 11:35 AM Eduardo Quintanilla wrote: > The link does not work. > > HTTP Status: 400 > Response:

RE: flaky HTTP2 test

2020-06-24 Thread Eduardo Quintanilla
The link does not work. HTTP Status: 400 Response: {"count":11,"value":"Uri expired"} Eduardo Quintanilla Software Developer From: Raymond Auge Sent: miƩrcoles, 24 de junio de 2020 10:29 a. m. To: Tomcat Developers List Subject: Re: flaky HTTP2 test You'll notice that in the same run that

Re: flaky HTTP2 test

2020-06-24 Thread Raymond Auge
You'll notice that in the same run that test passed on JDK 14 and 15-ea. - Ray On Wed, Jun 24, 2020 at 11:26 AM Raymond Auge wrote: > See >

Re: flaky HTTP2 test

2020-06-24 Thread Raymond Auge
See https://pipelines.actions.githubusercontent.com/hQhYuytC86T1GsTs7qTvThq2ESqStTSskvOzwdA12PGOh7ZWVy/_apis/pipelines/1/runs/14/signedlogcontent/7?urlExpires=2020-06-24T15%3A25%3A51.1449322Z=HMACV1=O2PyO3WhK3FTDVz3t1sTeAGHP7IOlnynp8PZIfw%2BsOQ%3D and search for "Running

Re: flaky HTTP2 test

2020-06-24 Thread Mark Thomas
On 24/06/2020 15:56, Raymond Auge wrote: > Hey all, > > The test > org.apache.coyote.http2.TestHttp2Limits > seems to be flaky. Haven't seen any issues with it recently either locally or with on of the other CI systems. Do you have a log from a failure case? Mark > > I'm playing with github

Re: Tomcat 9 and response.setTrailerFields

2020-06-24 Thread Mark Thomas
Sorry. Auto completed to wrong list. Mark On 24/06/2020 16:10, Mark Thomas wrote: > On 24/06/2020 15:59, Julian Reschke wrote: >> >> Hi, >> >> I just tried to figure out whether Tomcat 9 will let be send trailer >> fields in a chunked HTTP/1.1 response, using >> >>

Re: Tomcat 9 and response.setTrailerFields

2020-06-24 Thread Mark Thomas
On 24/06/2020 15:59, Julian Reschke wrote: > > Hi, > > I just tried to figure out whether Tomcat 9 will let be send trailer > fields in a chunked HTTP/1.1 response, using > >

flaky HTTP2 test

2020-06-24 Thread Raymond Auge
Hey all, The test org.apache.coyote.http2.TestHttp2Limits seems to be flaky. I'm playing with github actions as per https://github.com/apache/tomcat/pull/307 and I've observed that this test arbitrarily passes or fails. For now I will filter it out of my POC but I figured it might be relevant

[GitHub] [tomcat] rotty3000 commented on pull request #307: github actions

2020-06-24 Thread GitBox
rotty3000 commented on pull request #307: URL: https://github.com/apache/tomcat/pull/307#issuecomment-648872489 FYI, tomcat seems to build and test (nio) fine on Java 8, 11, 14 & 15-ea! :+1: This is an automated message

[GitHub] [tomcat] rotty3000 commented on pull request #307: github actions

2020-06-24 Thread GitBox
rotty3000 commented on pull request #307: URL: https://github.com/apache/tomcat/pull/307#issuecomment-648856220 I do not disagree that adding a third could be confusing. What I like about actions in addition to the points you've made is: - runs on forks as well (which means I can

buildbot success in on tomcat-9-trunk

2020-06-24 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-9-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-9-trunk/builds/304 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The

[tomcat] branch 9.0.x updated: Fix incorrect argument processing

2020-06-24 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 0ab464c Fix incorrect argument processing 0ab464c

[tomcat] branch master updated: Fix incorrect argument processing

2020-06-24 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 0be0a6a Fix incorrect argument processing

[Bug 64544] add built libs to the bnd classpath for introspection

2020-06-24 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64544 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[tomcat] branch 9.0.x updated: Fix BZ 64544 - add built libs to the bnd classpath for introspection

2020-06-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 5efa602 Fix BZ 64544 - add built libs to the bnd

[tomcat] branch master updated: Fix BZ 64544 - add built libs to the bnd classpath for introspection

2020-06-24 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 18d048b Fix BZ 64544 - add built libs to the

[GitHub] [tomcat] markt-asf merged pull request #308: Fix BZ 64544 - add built libs to the bnd classpath for introspection

2020-06-24 Thread GitBox
markt-asf merged pull request #308: URL: https://github.com/apache/tomcat/pull/308 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tomcat] martin-g commented on pull request #307: github actions

2020-06-24 Thread GitBox
martin-g commented on pull request #307: URL: https://github.com/apache/tomcat/pull/307#issuecomment-648633491 So far we have: 1) Apache BuildBot as the official CI 2) Travis - for testing non-x86_64 architectures (at the moment: aarch64 and s390x) Do we need a third CI ?