buildbot failure in on tomcat-trunk
The Buildbot has detected a new failure on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/5308 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' triggered this build Build Source Stamp: [branch master] 928bd7295736c6f0e87915ec767b10370e6dd27b Blamelist: Raymond Augé BUILD FAILED: failed compile_1 Sincerely, -The Buildbot - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 64548] generate JPMS metadata
https://bz.apache.org/bugzilla/show_bug.cgi?id=64548 rotty3000 changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from rotty3000 --- Fixed at https://github.com/apache/tomcat/commit/928bd7295736c6f0e87915ec767b10370e6dd27b in master and at https://github.com/apache/tomcat/commit/39e74780c4292d51b544620e59124c2dfb1b9ab8 for 9.0.x -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 9.0.x updated: Fix BZ 64548 - generate JPMS metadata
This is an automated email from the ASF dual-hosted git repository.
rotty3000 pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 39e7478 Fix BZ 64548 - generate JPMS metadata
39e7478 is described below
commit 39e74780c4292d51b544620e59124c2dfb1b9ab8
Author: Raymond Augé
AuthorDate: Fri Jun 19 22:25:54 2020 -0400
Fix BZ 64548 - generate JPMS metadata
Signed-off-by: Raymond Augé
---
res/bnd/annotations-api.jar.tmp.bnd| 10 +-
res/bnd/build-defaults.bnd | 4 +++-
res/bnd/catalina-ha.jar.tmp.bnd| 10 +-
res/bnd/catalina-ssi.jar.tmp.bnd | 8
res/bnd/catalina-storeconfig.jar.tmp.bnd | 10 +-
res/bnd/catalina-tribes.jar.tmp.bnd| 10 +-
res/bnd/catalina.jar.tmp.bnd | 20 +++-
res/bnd/el-api.jar.tmp.bnd | 8
res/bnd/jasper-el.jar.tmp.bnd | 10 +-
res/bnd/jasper.jar.tmp.bnd | 11 ++-
res/bnd/jaspic-api.jar.tmp.bnd | 10 +-
res/bnd/jsp-api.jar.tmp.bnd| 8
res/bnd/servlet-api.jar.tmp.bnd| 8
res/bnd/tomcat-api.jar.tmp.bnd | 8
res/bnd/tomcat-coyote.jar.tmp.bnd | 10 +-
res/bnd/tomcat-dbcp.jar.tmp.bnd| 9 -
res/bnd/tomcat-embed-core.jar.tmp.bnd | 19 ++-
res/bnd/tomcat-embed-el.jar.tmp.bnd| 9 -
res/bnd/tomcat-embed-jasper.jar.tmp.bnd| 9 -
res/bnd/tomcat-embed-websocket.jar.tmp.bnd | 11 +--
res/bnd/tomcat-jni.jar.tmp.bnd | 10 +-
res/bnd/tomcat-juli.jar.tmp.bnd| 10 +-
res/bnd/tomcat-util-scan.jar.tmp.bnd | 10 +-
res/bnd/tomcat-util.jar.tmp.bnd| 10 +-
res/bnd/tomcat-websocket.jar.tmp.bnd | 10 +-
res/bnd/websocket-api.jar.tmp.bnd | 10 +-
webapps/docs/changelog.xml | 3 +++
27 files changed, 243 insertions(+), 22 deletions(-)
diff --git a/res/bnd/annotations-api.jar.tmp.bnd
b/res/bnd/annotations-api.jar.tmp.bnd
index 19db9f4..09151bf 100644
--- a/res/bnd/annotations-api.jar.tmp.bnd
+++ b/res/bnd/annotations-api.jar.tmp.bnd
@@ -32,4 +32,12 @@ Provide-Capability: \
Implementation-Version=1.3.${annotation.revision};\
Specification-Title='Common Annotations';\
Specification-Vendor='Oracle Corporation';\
-Specification-Version=1.3
\ No newline at end of file
+Specification-Version=1.3
+
+-jpms-module-info: \
+jakarta.annotation;\
+access=32;\
+version=${annotation.spec.version}
+-jpms-module-info-options: \
+ jakarta.annotation;\
+ substitute=annotations-api
diff --git a/res/bnd/build-defaults.bnd b/res/bnd/build-defaults.bnd
index cdefb9c..2eec204 100644
--- a/res/bnd/build-defaults.bnd
+++ b/res/bnd/build-defaults.bnd
@@ -28,4 +28,6 @@ X-Compile-Target-JDK: ${compile.target}
-includeresource.notice:
META-INF/NOTICE;literal="${replace;${cat;../META-INF/default.notice};@YEAR@;${year}}\n"
-includeresource.license: {META-INF/LICENSE=../META-INF/default.license}
--noclassforname: true
\ No newline at end of file
+-noclassforname: true
+
+module.name: org.apache.${replace;${Bundle-Name};-;.}
\ No newline at end of file
diff --git a/res/bnd/catalina-ha.jar.tmp.bnd b/res/bnd/catalina-ha.jar.tmp.bnd
index 824f99e..4b6c2db 100644
--- a/res/bnd/catalina-ha.jar.tmp.bnd
+++ b/res/bnd/catalina-ha.jar.tmp.bnd
@@ -24,4 +24,12 @@ Export-Package: \
org.apache.catalina.ha.context,\
org.apache.catalina.ha.deploy,\
org.apache.catalina.ha.session,\
-org.apache.catalina.ha.tcp
\ No newline at end of file
+org.apache.catalina.ha.tcp
+
+-jpms-module-info: \
+${module.name};\
+access=32;\
+version=${Bundle-Version}
+-jpms-module-info-options: \
+ ${module.name};\
+ substitute=catalina-ha
\ No newline at end of file
diff --git a/res/bnd/catalina-ssi.jar.tmp.bnd b/res/bnd/catalina-ssi.jar.tmp.bnd
index 87c0cbd..a8b0c3b 100644
--- a/res/bnd/catalina-ssi.jar.tmp.bnd
+++ b/res/bnd/catalina-ssi.jar.tmp.bnd
@@ -19,3 +19,11 @@ Bundle-Name: tomcat-ssi
Bundle-SymbolicName: org.apache.tomcat-ssi
Export-Package: \
org.apache.catalina.ssi
+
+-jpms-module-info: \
+${module.name};\
+access=32;\
+version=${Bundle-Version}
+-jpms-module-info-options: \
+${module.name};\
+substitute=catalina-ssi
\ No newline at end of file
diff --git a/res/bnd/catalina-storeconfig.jar.tmp.bnd
b/res/bnd/catalina-storeconfig.jar.tmp.bnd
index e21e689..d82fe37 100644
--- a/res/bnd/catalina-storeconfig.jar.tmp.bnd
+++ b/res/bnd/catalina-storeconfig.jar.tmp.bnd
@@ -17,4 +17,12 @@
Bundle-Name: tomcat-storeconfig
Bundle-SymbolicName: org.apache.tomcat-storeconfig
[tomcat] branch master updated (407105e -> 928bd72)
This is an automated email from the ASF dual-hosted git repository. rotty3000 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 407105e Remove obsolete commented out ideas add 928bd72 Fix BZ 64548 - generate JPMS metadata No new revisions were added by this update. Summary of changes: res/bnd/annotations-api.jar.tmp.bnd| 10 +- res/bnd/build-defaults.bnd | 4 +++- res/bnd/catalina-ha.jar.tmp.bnd| 10 +- res/bnd/catalina-ssi.jar.tmp.bnd | 8 res/bnd/catalina-storeconfig.jar.tmp.bnd | 10 +- res/bnd/catalina-tribes.jar.tmp.bnd| 10 +- res/bnd/catalina.jar.tmp.bnd | 20 +++- res/bnd/el-api.jar.tmp.bnd | 10 +- res/bnd/jasper-el.jar.tmp.bnd | 10 +- res/bnd/jasper.jar.tmp.bnd | 11 ++- res/bnd/jaspic-api.jar.tmp.bnd | 10 +- res/bnd/jsp-api.jar.tmp.bnd| 10 +- res/bnd/servlet-api.jar.tmp.bnd| 10 +- res/bnd/spec-defaults.bnd | 2 +- res/bnd/tomcat-api.jar.tmp.bnd | 8 res/bnd/tomcat-coyote.jar.tmp.bnd | 10 +- res/bnd/tomcat-dbcp.jar.tmp.bnd| 9 - res/bnd/tomcat-embed-core.jar.tmp.bnd | 21 +++-- res/bnd/tomcat-embed-el.jar.tmp.bnd| 11 +-- res/bnd/tomcat-embed-jasper.jar.tmp.bnd| 11 +-- res/bnd/tomcat-embed-websocket.jar.tmp.bnd | 11 +-- res/bnd/tomcat-jni.jar.tmp.bnd | 10 +- res/bnd/tomcat-juli.jar.tmp.bnd| 10 +- res/bnd/tomcat-util-scan.jar.tmp.bnd | 10 +- res/bnd/tomcat-util.jar.tmp.bnd| 10 +- res/bnd/tomcat-websocket.jar.tmp.bnd | 10 +- res/bnd/websocket-api.jar.tmp.bnd | 10 +- webapps/docs/changelog.xml | 3 +++ 28 files changed, 250 insertions(+), 29 deletions(-) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] rotty3000 merged pull request #317: Fix BZ 64548 - generate JPMS metadata
rotty3000 merged pull request #317: URL: https://github.com/apache/tomcat/pull/317 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1879778 - in /tomcat/site/trunk: docs/whoweare.html xdocs/whoweare.xml
Author: rotty3000 Date: Sat Jul 11 02:04:55 2020 New Revision: 1879778 URL: http://svn.apache.org/viewvc?rev=1879778=rev Log: Add myself to list Signed-off-by: Raymond Augé Modified: tomcat/site/trunk/docs/whoweare.html tomcat/site/trunk/xdocs/whoweare.xml Modified: tomcat/site/trunk/docs/whoweare.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/whoweare.html?rev=1879778=1879777=1879778=diff == --- tomcat/site/trunk/docs/whoweare.html (original) +++ tomcat/site/trunk/docs/whoweare.html Sat Jul 11 02:04:55 2020 @@ -43,6 +43,9 @@ A complete list of all the Apache Commit Jean-Francois Arcand (jfarcand at apache.org) +Raymond Aug (rotty3000 at apache.org) + + Bill Barker (billbarker at apache.org) Modified: tomcat/site/trunk/xdocs/whoweare.xml URL: http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/whoweare.xml?rev=1879778=1879777=1879778=diff == --- tomcat/site/trunk/xdocs/whoweare.xml (original) +++ tomcat/site/trunk/xdocs/whoweare.xml Sat Jul 11 02:04:55 2020 @@ -51,6 +51,9 @@ A complete list of all the Apache Commit Jean-Francois Arcand (jfarcand at apache.org) +Raymond Augé (rotty3000 at apache.org) + + Bill Barker (billbarker at apache.org) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] hazendaz commented on pull request #321: Simplify some #toString() methods
hazendaz commented on pull request #321: URL: https://github.com/apache/tomcat/pull/321#issuecomment-656901567 @ChristopherSchultz Sorry my point was that there was more than just one thing going on in this change. Some of the stringBuilders didn't do anything other than add entirely static items so those are all good cleanups on their own as no concatenation nor string builder was necessary. That was what I was referring to. Others switched it to concatenation. The compiler does handle it if the items are entirely static. However, if they are not, it's left to the runtime to figure out. If optimization doesn't matter in this area that is fine. Just pointing that out. As to better way to concat, use Strings class to join but that is java 8 and I'm sure its always better to keep tomcat so it's easily backported to prior versions that are not on java 8. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] rmaucher commented on pull request #321: Simplify some #toString() methods
rmaucher commented on pull request #321: URL: https://github.com/apache/tomcat/pull/321#issuecomment-65628 Optimizing isn't important here so this PR is an improvement even if it was slower. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] ChristopherSchultz commented on pull request #321: Simplify some #toString() methods
ChristopherSchultz commented on pull request #321:
URL: https://github.com/apache/tomcat/pull/321#issuecomment-656880783
> Bad idea on adding concatenation (rest is good).
I don't see any "added" concatenation. Some uses of `StringBuilder` have
been replaced with string concatenation which is a win for several reasons:
1. It's much easier to read + debug
2. The compiler can convert to using StringBuffer (old) StringBuilder
(newer) or StringConcatFactory (newest) instead of using the latest technique
some programmer most-recently read about
> That causes lots of extra object creation needlessly.
Citation needed. The compiler converts this:
return "foo" + 25 + "bar";
Into roughly this:
StringBuilder sb = new StringBuilder("foo");
sb.append(23);
sb.append("bar");
return sb.toString();
So going backward doesn't add anything.
> Concatenation is long known to be a problem.
A problem which the compiler is perfectly capable of handling. This part is
about readability and maintainability, which are being improved by the patch
IMO.
> This PR is doing 2 things, fixing real issues and then adding unnecessary
concatenation in others.
Please be specific: point to a single place where concatenation is being
added where it did not previously exist.
> There are better ways to do that without string builder
Such as?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 64593] New: Rewrites incorrectly 404 when there is no source context
https://bz.apache.org/bugzilla/show_bug.cgi?id=64593 Bug ID: 64593 Summary: Rewrites incorrectly 404 when there is no source context Product: Tomcat 8 Version: 8.5.57 Hardware: PC OS: All Status: NEW Severity: normal Priority: P2 Component: Catalina Assignee: dev@tomcat.apache.org Reporter: n...@worldofnic.org Target Milestone: If you enable rewrites, and put a rewrite.config in, where the source location does not match a valid context, the server issues a 404. The server then logs a 404 in the access log for the target location. I would argue that the server should perform the rewrite and return the target's content. However, if that is not what is meant to happen, then the logged 404 should be for the source URL, not the target. In "Bonus Step 8." below, you can see that the server _thinks_ the rewrite rule is present and that it has rewritten the request. Step 1. Enable Rewrite valve via Step 2. Add a rewrite.config to conf/Catalina/localhost containing: RewriteRule ^/source/(.*)$ /target/$1 [L] Step 3. Delete all webapps rm -rf webapps/* Step 4. Create webapps/target/index.html Step 5. Start server Step 6. Test Rewrite curl -I http://localhost:8080/source/index.html HTTP/1.1 404 Step 7. Observe rewritten path in logs: 0:0:0:0:0:0:0:1 - - [10/Jul/2020:18:44:06 +0100] "HEAD /target/index.html HTTP/1.1" 404 - Bonus Step 8. Enable FINE logging, and we get the following lines: 10-Jul-2020 19:27:36.803 FINE [Catalina-startStop-1] org.apache.catalina.valves.rewrite.RewriteValve.parse Add rule with pattern ^/source/(.*)$ and substitution /target/$1 org.apache.catalina.valves.rewrite.RewriteValve.invoke Rewrote /source/index.html as /target/index.html with rule pattern ^/source/(.*)$ -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] hazendaz commented on pull request #321: Simplify some #toString() methods
hazendaz commented on pull request #321: URL: https://github.com/apache/tomcat/pull/321#issuecomment-656784397 Bad idea on adding concatenation (rest is good). That causes lots of extra object creation needlessly. Concatenation is long known to be a problem. This PR is doing 2 things, fixing real issues and then adding unnecessary concatenation in others. While I'm not part of this team, I would suggest this be changed to only address the real issues and not add in concatenation. There are better ways to do that without string builder but this is likely this way to allow easy backports still to 7. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [Bug 64582] SecurityClassLoad - CoyoteOutputStream
On 10/07/2020 16:53, bugzi...@apache.org wrote: > https://bz.apache.org/bugzilla/show_bug.cgi?id=64582 > > --- Comment #2 from Rohit Singh --- I've blocked this idiot's account but I am going to leave the spam comment in place for a little while so i can use it to explore more permanent options for discouraging spam. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 64583] org.apache.tomcat.websocket.pojo.TestEncodingDecoding / testAnnotatedEndPoints - testEvent fails occasionally
https://bz.apache.org/bugzilla/show_bug.cgi?id=64583 --- Comment #10 from Rohit Singh --- This post contains useful info in every aspect. Thank you so much for the step by step practical advice here and in the post, keep regular, Keep posting on a regular basis and sharing your knowledge with others. https://www.pragnaspokenenglish.com/ -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 64582] SecurityClassLoad - CoyoteOutputStream
https://bz.apache.org/bugzilla/show_bug.cgi?id=64582 --- Comment #2 from Rohit Singh --- I think you provide the better information to us you. https://www.pragnaspokenenglish.com/ -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [tomcat] branch master updated: Use StringBuilder instead of StringBuffer
Hi Chris,
On Mon, Jul 6, 2020 at 5:12 PM Christopher Schultz <
ch...@christopherschultz.net> wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA256
>
> Martin,
>
> On 7/6/20 03:09, mgrigo...@apache.org wrote:
> > diff --git
> > a/java/org/apache/catalina/connector/CoyotePrincipal.java
> > b/java/org/apache/catalina/connector/CoyotePrincipal.java index
> > 1ae5608..93d7c02 100644 ---
> > a/java/org/apache/catalina/connector/CoyotePrincipal.java +++
> > b/java/org/apache/catalina/connector/CoyotePrincipal.java @@ -64,7
> > +64,7 @@ public class CoyotePrincipal implements Principal,
> > Serializable { public String toString() { StringBuilder sb = new
> > StringBuilder("CoyotePrincipal["); sb.append(this.name); -
> > sb.append("]"); +sb.append(']'); return sb.toString(); }
>
> Might I suggest further improvements?
>
> Step 1:
>
> public String toString() {
> return new StringBuilder("CoyotePrincipal[")
> .append(this.name);
> .append(']');
> .toString();
>
> It turns out that the generated bytecode is something like 2/3 as long
> as the sb.append(); sb.append(); sb.append(); code. JIT probably does
> the same thing eventually, but why not help it out?
>
> Step 2:
>
> public String toString() {
> return "CoyotePrincipal[" + this.name + ']';
> }
>
> This has a few advantages:
>
> 1. It's dead easy to read
>
> 2. The compiler makes the best decision as to how to perform the
> concatenation
>
> In very old versions of Java, you'll get StringBuffer concatenation as
> the pre-commit version. Later versions get you StringBuilder as
> post-commit version. Post 9.x-versions get you a call to
> StringConcatFactory.makeConcatWithConstants which is presumably even
> more efficient.
>
> I understand that this was supposed to be a small patch, but I think
> further improvements are possible in many cases like this one.
>
Agreed!
https://github.com/apache/tomcat/pull/321
Martin
>
> Thanks,
> - -chris
> -BEGIN PGP SIGNATURE-
> Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/
>
> iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAl8DMT8ACgkQHPApP6U8
> pFgUtA/+OoHnIgHBLoIOXqP5t10g/dBFxGrIpOUOe1MvIhWMdObcNIlZmnM1vv0Z
> xCRYXxGCj20xm4P/NEzvRlEPWfd0uvoZczr34JVPlgOWUBJeRHmLQ+KlGdCeuuKk
> cmxV4ZXZSt8bzVMufQ+N2RPOCGUvti2kin0CSj9BlygKuTAMuXgwVcyEo7XvLf3z
> 153dHylBL3ka5jo2lR4vYlj8U6PvzoZuLj3NAnrRZP3YttbQKimhXDcOg7zkeVP+
> GFINDBE+fux+s5P38vqRLqzA4JEDFfjsKzT4JV21BrSbxhdUbXyYE4RMhW+izKB8
> B/SJhBtEN1huED3GkZbg/DN0nYgY4vVeoHz4kdal1E5uVybG5SLj6xoz6tkRsayB
> pOHguW1ds8NLPJwHBEATq6YQOXGfqECbW+iWuP54F7eBzo57CiZWsnQPalpSo9pn
> mdBRbcfyI7z9vJFaiGCpudKGKK5+F1VFj6KELxZP7nAO0Lyhwapsai9TzLXLOTk1
> 8ReS5GENoZDrzrb3Gn/YCmdYAxdED9ejjkiY5qVjX3ZXWXaeytcz1h3bY2opV4Ks
> a+tahArWqI1t44cemejJuiXFZB0xrDjji6pnd3ZqZ4vG1TREKxK2hdLjuwP3vaw9
> fqt4d3E596rPtqF2e0aJLGfW+3iJ2r67c7DP9ARHMAdadMIi23U=
> =N+0c
> -END PGP SIGNATURE-
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>
[GitHub] [tomcat] martin-g opened a new pull request #321: Simplify some #toString() methods
martin-g opened a new pull request #321: URL: https://github.com/apache/tomcat/pull/321 Do not use StringBuilder when String concatenation is just fine. Append char instead of String when possible. Fix the toString of ExampleFilter This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 7.0.x updated: Remove obsolete commented out ideas
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 7.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/7.0.x by this push:
new 32d3e4b Remove obsolete commented out ideas
32d3e4b is described below
commit 32d3e4b8776a5aaac16bf17a801a5318c9145f26
Author: remm
AuthorDate: Fri Jul 10 16:09:26 2020 +0200
Remove obsolete commented out ideas
The NamingResources now hold and manage these.
---
.../org/apache/catalina/startup/ContextConfig.java | 51 --
1 file changed, 51 deletions(-)
diff --git a/java/org/apache/catalina/startup/ContextConfig.java
b/java/org/apache/catalina/startup/ContextConfig.java
index 3cc4807..aff9a02 100644
--- a/java/org/apache/catalina/startup/ContextConfig.java
+++ b/java/org/apache/catalina/startup/ContextConfig.java
@@ -959,22 +959,6 @@ public class ContextConfig implements LifecycleListener {
context.removeConstraint(securityConstraints[i]);
}
-// Removing Ejbs
-/*
-ContextEjb[] contextEjbs = context.findEjbs();
-for (i = 0; i < contextEjbs.length; i++) {
-context.removeEjb(contextEjbs[i].getName());
-}
-*/
-
-// Removing environments
-/*
-ContextEnvironment[] contextEnvironments = context.findEnvironments();
-for (i = 0; i < contextEnvironments.length; i++) {
-context.removeEnvironment(contextEnvironments[i].getName());
-}
-*/
-
// Removing errors pages
ErrorPage[] errorPages = context.findErrorPages();
for (i = 0; i < errorPages.length; i++) {
@@ -993,14 +977,6 @@ public class ContextConfig implements LifecycleListener {
context.removeFilterMap(filterMaps[i]);
}
-// Removing local ejbs
-/*
-ContextLocalEjb[] contextLocalEjbs = context.findLocalEjbs();
-for (i = 0; i < contextLocalEjbs.length; i++) {
-context.removeLocalEjb(contextLocalEjbs[i].getName());
-}
-*/
-
// Removing Mime mappings
String[] mimeMappings = context.findMimeMappings();
for (i = 0; i < mimeMappings.length; i++) {
@@ -1013,31 +989,6 @@ public class ContextConfig implements LifecycleListener {
context.removeParameter(parameters[i]);
}
-// Removing resource env refs
-/*
-String[] resourceEnvRefs = context.findResourceEnvRefs();
-for (i = 0; i < resourceEnvRefs.length; i++) {
-context.removeResourceEnvRef(resourceEnvRefs[i]);
-}
-*/
-
-// Removing resource links
-/*
-ContextResourceLink[] contextResourceLinks =
-context.findResourceLinks();
-for (i = 0; i < contextResourceLinks.length; i++) {
-context.removeResourceLink(contextResourceLinks[i].getName());
-}
-*/
-
-// Removing resources
-/*
-ContextResource[] contextResources = context.findResources();
-for (i = 0; i < contextResources.length; i++) {
-context.removeResource(contextResources[i].getName());
-}
-*/
-
// Removing security role
String[] securityRoles = context.findSecurityRoles();
for (i = 0; i < securityRoles.length; i++) {
@@ -1050,8 +1001,6 @@ public class ContextConfig implements LifecycleListener {
context.removeServletMapping(servletMappings[i]);
}
-// FIXME : Removing status pages
-
// Removing welcome files
String[] welcomeFiles = context.findWelcomeFiles();
for (i = 0; i < welcomeFiles.length; i++) {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 8.5.x updated: Remove obsolete commented out ideas
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new 9eff420 Remove obsolete commented out ideas
9eff420 is described below
commit 9eff420acff085bbada9ece0c88cddc360a66341
Author: remm
AuthorDate: Fri Jul 10 16:09:26 2020 +0200
Remove obsolete commented out ideas
The NamingResources now hold and manage these.
---
.../org/apache/catalina/startup/ContextConfig.java | 51 --
1 file changed, 51 deletions(-)
diff --git a/java/org/apache/catalina/startup/ContextConfig.java
b/java/org/apache/catalina/startup/ContextConfig.java
index 1d89e3f..846a2d0 100644
--- a/java/org/apache/catalina/startup/ContextConfig.java
+++ b/java/org/apache/catalina/startup/ContextConfig.java
@@ -849,22 +849,6 @@ public class ContextConfig implements LifecycleListener {
context.removeConstraint(securityConstraints[i]);
}
-// Removing Ejbs
-/*
-ContextEjb[] contextEjbs = context.findEjbs();
-for (i = 0; i < contextEjbs.length; i++) {
-context.removeEjb(contextEjbs[i].getName());
-}
-*/
-
-// Removing environments
-/*
-ContextEnvironment[] contextEnvironments = context.findEnvironments();
-for (i = 0; i < contextEnvironments.length; i++) {
-context.removeEnvironment(contextEnvironments[i].getName());
-}
-*/
-
// Removing errors pages
ErrorPage[] errorPages = context.findErrorPages();
for (i = 0; i < errorPages.length; i++) {
@@ -883,14 +867,6 @@ public class ContextConfig implements LifecycleListener {
context.removeFilterMap(filterMaps[i]);
}
-// Removing local ejbs
-/*
-ContextLocalEjb[] contextLocalEjbs = context.findLocalEjbs();
-for (i = 0; i < contextLocalEjbs.length; i++) {
-context.removeLocalEjb(contextLocalEjbs[i].getName());
-}
-*/
-
// Removing Mime mappings
String[] mimeMappings = context.findMimeMappings();
for (i = 0; i < mimeMappings.length; i++) {
@@ -903,31 +879,6 @@ public class ContextConfig implements LifecycleListener {
context.removeParameter(parameters[i]);
}
-// Removing resource env refs
-/*
-String[] resourceEnvRefs = context.findResourceEnvRefs();
-for (i = 0; i < resourceEnvRefs.length; i++) {
-context.removeResourceEnvRef(resourceEnvRefs[i]);
-}
-*/
-
-// Removing resource links
-/*
-ContextResourceLink[] contextResourceLinks =
-context.findResourceLinks();
-for (i = 0; i < contextResourceLinks.length; i++) {
-context.removeResourceLink(contextResourceLinks[i].getName());
-}
-*/
-
-// Removing resources
-/*
-ContextResource[] contextResources = context.findResources();
-for (i = 0; i < contextResources.length; i++) {
-context.removeResource(contextResources[i].getName());
-}
-*/
-
// Removing security role
String[] securityRoles = context.findSecurityRoles();
for (i = 0; i < securityRoles.length; i++) {
@@ -940,8 +891,6 @@ public class ContextConfig implements LifecycleListener {
context.removeServletMapping(servletMappings[i]);
}
-// FIXME : Removing status pages
-
// Removing welcome files
String[] welcomeFiles = context.findWelcomeFiles();
for (i = 0; i < welcomeFiles.length; i++) {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 9.0.x updated: Remove obsolete commented out ideas
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 6598898 Remove obsolete commented out ideas
6598898 is described below
commit 6598898e32b06547228c8187ba5fd9a32181ea2a
Author: remm
AuthorDate: Fri Jul 10 16:09:26 2020 +0200
Remove obsolete commented out ideas
The NamingResources now hold and manage these.
---
.../org/apache/catalina/startup/ContextConfig.java | 51 --
1 file changed, 51 deletions(-)
diff --git a/java/org/apache/catalina/startup/ContextConfig.java
b/java/org/apache/catalina/startup/ContextConfig.java
index 630b7c3..ebb65b0 100644
--- a/java/org/apache/catalina/startup/ContextConfig.java
+++ b/java/org/apache/catalina/startup/ContextConfig.java
@@ -1054,22 +1054,6 @@ public class ContextConfig implements LifecycleListener {
context.removeConstraint(securityConstraints[i]);
}
-// Removing Ejbs
-/*
-ContextEjb[] contextEjbs = context.findEjbs();
-for (i = 0; i < contextEjbs.length; i++) {
-context.removeEjb(contextEjbs[i].getName());
-}
-*/
-
-// Removing environments
-/*
-ContextEnvironment[] contextEnvironments = context.findEnvironments();
-for (i = 0; i < contextEnvironments.length; i++) {
-context.removeEnvironment(contextEnvironments[i].getName());
-}
-*/
-
// Removing errors pages
ErrorPage[] errorPages = context.findErrorPages();
for (i = 0; i < errorPages.length; i++) {
@@ -1088,14 +1072,6 @@ public class ContextConfig implements LifecycleListener {
context.removeFilterMap(filterMaps[i]);
}
-// Removing local ejbs
-/*
-ContextLocalEjb[] contextLocalEjbs = context.findLocalEjbs();
-for (i = 0; i < contextLocalEjbs.length; i++) {
-context.removeLocalEjb(contextLocalEjbs[i].getName());
-}
-*/
-
// Removing Mime mappings
String[] mimeMappings = context.findMimeMappings();
for (i = 0; i < mimeMappings.length; i++) {
@@ -1108,31 +1084,6 @@ public class ContextConfig implements LifecycleListener {
context.removeParameter(parameters[i]);
}
-// Removing resource env refs
-/*
-String[] resourceEnvRefs = context.findResourceEnvRefs();
-for (i = 0; i < resourceEnvRefs.length; i++) {
-context.removeResourceEnvRef(resourceEnvRefs[i]);
-}
-*/
-
-// Removing resource links
-/*
-ContextResourceLink[] contextResourceLinks =
-context.findResourceLinks();
-for (i = 0; i < contextResourceLinks.length; i++) {
-context.removeResourceLink(contextResourceLinks[i].getName());
-}
-*/
-
-// Removing resources
-/*
-ContextResource[] contextResources = context.findResources();
-for (i = 0; i < contextResources.length; i++) {
-context.removeResource(contextResources[i].getName());
-}
-*/
-
// Removing security role
String[] securityRoles = context.findSecurityRoles();
for (i = 0; i < securityRoles.length; i++) {
@@ -1145,8 +1096,6 @@ public class ContextConfig implements LifecycleListener {
context.removeServletMapping(servletMappings[i]);
}
-// FIXME : Removing status pages
-
// Removing welcome files
String[] welcomeFiles = context.findWelcomeFiles();
for (i = 0; i < welcomeFiles.length; i++) {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch master updated: Remove obsolete commented out ideas
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new 407105e Remove obsolete commented out ideas
407105e is described below
commit 407105e94eaac3a56d1e3e41cdfbbd654833494d
Author: remm
AuthorDate: Fri Jul 10 16:09:26 2020 +0200
Remove obsolete commented out ideas
The NamingResources now hold and manage these.
---
.../org/apache/catalina/startup/ContextConfig.java | 51 --
1 file changed, 51 deletions(-)
diff --git a/java/org/apache/catalina/startup/ContextConfig.java
b/java/org/apache/catalina/startup/ContextConfig.java
index 307d4b8..19a1d80 100644
--- a/java/org/apache/catalina/startup/ContextConfig.java
+++ b/java/org/apache/catalina/startup/ContextConfig.java
@@ -1054,22 +1054,6 @@ public class ContextConfig implements LifecycleListener {
context.removeConstraint(securityConstraints[i]);
}
-// Removing Ejbs
-/*
-ContextEjb[] contextEjbs = context.findEjbs();
-for (i = 0; i < contextEjbs.length; i++) {
-context.removeEjb(contextEjbs[i].getName());
-}
-*/
-
-// Removing environments
-/*
-ContextEnvironment[] contextEnvironments = context.findEnvironments();
-for (i = 0; i < contextEnvironments.length; i++) {
-context.removeEnvironment(contextEnvironments[i].getName());
-}
-*/
-
// Removing errors pages
ErrorPage[] errorPages = context.findErrorPages();
for (i = 0; i < errorPages.length; i++) {
@@ -1088,14 +1072,6 @@ public class ContextConfig implements LifecycleListener {
context.removeFilterMap(filterMaps[i]);
}
-// Removing local ejbs
-/*
-ContextLocalEjb[] contextLocalEjbs = context.findLocalEjbs();
-for (i = 0; i < contextLocalEjbs.length; i++) {
-context.removeLocalEjb(contextLocalEjbs[i].getName());
-}
-*/
-
// Removing Mime mappings
String[] mimeMappings = context.findMimeMappings();
for (i = 0; i < mimeMappings.length; i++) {
@@ -1108,31 +1084,6 @@ public class ContextConfig implements LifecycleListener {
context.removeParameter(parameters[i]);
}
-// Removing resource env refs
-/*
-String[] resourceEnvRefs = context.findResourceEnvRefs();
-for (i = 0; i < resourceEnvRefs.length; i++) {
-context.removeResourceEnvRef(resourceEnvRefs[i]);
-}
-*/
-
-// Removing resource links
-/*
-ContextResourceLink[] contextResourceLinks =
-context.findResourceLinks();
-for (i = 0; i < contextResourceLinks.length; i++) {
-context.removeResourceLink(contextResourceLinks[i].getName());
-}
-*/
-
-// Removing resources
-/*
-ContextResource[] contextResources = context.findResources();
-for (i = 0; i < contextResources.length; i++) {
-context.removeResource(contextResources[i].getName());
-}
-*/
-
// Removing security role
String[] securityRoles = context.findSecurityRoles();
for (i = 0; i < securityRoles.length; i++) {
@@ -1145,8 +1096,6 @@ public class ContextConfig implements LifecycleListener {
context.removeServletMapping(servletMappings[i]);
}
-// FIXME : Removing status pages
-
// Removing welcome files
String[] welcomeFiles = context.findWelcomeFiles();
for (i = 0; i < welcomeFiles.length; i++) {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [Bug 60030] Run away CPU with JSSE / OpenSSL with IE8
On 10/07/2020 07:42, bugzi...@apache.org wrote: > https://bz.apache.org/bugzilla/show_bug.cgi?id=60030 > > kylivo changed: Spam reverted and the account has been disabled. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 60030] Run away CPU with JSSE / OpenSSL with IE8
https://bz.apache.org/bugzilla/show_bug.cgi?id=60030 kylivo changed: What|Removed |Added URL||http://199.192.26.181 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
