Re: Use of "constants" in Manager to generate HTML/CSS content

2020-08-11 Thread Igal Sapir
Chris, On Mon, Aug 10, 2020 at 12:20 PM Martin Grigorov wrote: > > On Tue, Jul 28, 2020, 16:48 Christopher Schultz < > ch...@christopherschultz.net> wrote: > >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA256 >> >> All, >> >> I was looking at this PR[1] and wondering why we have huge swaths

[GitHub] [tomcat] stokito opened a new pull request #337: Bug fix: If-None-Match: 304 response should return a real resource ETag

2020-08-11 Thread GitBox
stokito opened a new pull request #337: URL: https://github.com/apache/tomcat/pull/337 In the scope of bef507e1b7ac2eb0ff012d0d40035e218a5839cc was added a bug: ``` curl -vv http://localhost:8080/tomcat.png -H 'If-None-Match: W/"5103-159588774"' > GET /tomcat.png HTTP/1.1

Re: [PROPOSAL] Remove the functional specs from docs webapp

2020-08-11 Thread Michael Osipov
Am 2020-08-11 um 21:04 schrieb Mark Thomas: On 11/08/2020 17:30, Michael Osipov wrote: Am 2020-08-10 um 17:46 schrieb Mark Thomas: Hi all, I'd like to propose removing all the functional spec pages from the documentation web application. +1 Can you list them specifically? I am a bit

Re: [PROPOSAL] Remove the functional specs from docs webapp

2020-08-11 Thread Mark Thomas
On 11/08/2020 17:30, Michael Osipov wrote: > Am 2020-08-10 um 17:46 schrieb Mark Thomas: >> Hi all, >> >> I'd like to propose removing all the functional spec pages from the >> documentation web application. > +1 > > Can you list them specifically? I am a bit lost which you exactly mean.

[Bug 64645] bin/service.bat doesn't handle wrongly configured JAVA_HOME

2020-08-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64645 --- Comment #3 from Mark Thomas --- For clarity, the only change required here is that the exit code should be non-zero. The validation of JAVA_HOME and JAVA_HOME vs JRE_HOME is sufficient. -- You are receiving this mail because: You are the

[GitHub] [tomcat] kamnani commented on pull request #331: Remove White Spaces and extra lines from the JSP files

2020-08-11 Thread GitBox
kamnani commented on pull request #331: URL: https://github.com/apache/tomcat/pull/331#issuecomment-672153051 @ChristopherSchultz Are there any updates on this ? This is an automated message from the Apache Git Service. To

Re: [tomcat] branch master updated: Improve entity tag handling

2020-08-11 Thread Mark Thomas
On 11/08/2020 18:06, Michael Osipov wrote: > Am 2020-08-11 um 18:53 schrieb Mark Thomas: >> On 11/08/2020 17:29, Michael Osipov wrote: >>> Am 2020-08-11 um 16:52 schrieb ma...@apache.org: >> >> >> commit bef507e1b7ac2eb0ff012d0d40035e218a5839cc Author: Mark Thomas AuthorDate: Tue

Re: [tomcat] branch master updated: Improve entity tag handling

2020-08-11 Thread Michael Osipov
Am 2020-08-11 um 18:53 schrieb Mark Thomas: On 11/08/2020 17:29, Michael Osipov wrote: Am 2020-08-11 um 16:52 schrieb ma...@apache.org: commit bef507e1b7ac2eb0ff012d0d40035e218a5839cc Author: Mark Thomas AuthorDate: Tue Aug 11 15:27:45 2020 +0100 Improve entity tag handling @@

Re: [tomcat] branch master updated: Improve entity tag handling

2020-08-11 Thread Mark Thomas
On 11/08/2020 17:29, Michael Osipov wrote: > Am 2020-08-11 um 16:52 schrieb ma...@apache.org: >> commit bef507e1b7ac2eb0ff012d0d40035e218a5839cc >> Author: Mark Thomas >> AuthorDate: Tue Aug 11 15:27:45 2020 +0100 >> >> Improve entity tag handling >> @@ -279,6 +280,8 @@ public class

buildbot success in on tomcat-9-trunk

2020-08-11 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-9-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-9-trunk/builds/360 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The

buildbot success in on tomcat-trunk

2020-08-11 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/5334 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The

[GitHub] [tomcat] markt-asf commented on pull request #330: BZ-64644 throw an Idle Session Event on idle timeout

2020-08-11 Thread GitBox
markt-asf commented on pull request #330: URL: https://github.com/apache/tomcat/pull/330#issuecomment-672078710 There needs to be a *really* good reason to essentially introduce a Tomcat specific extension to the Jakarta WebSocket specification and thie PR hasn't (yet) provided such a

Re: [tomcat] branch master updated: Improve entity tag handling

2020-08-11 Thread Michael Osipov
Am 2020-08-11 um 16:52 schrieb ma...@apache.org: This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push:

Re: [PROPOSAL] Remove the functional specs from docs webapp

2020-08-11 Thread Michael Osipov
Am 2020-08-10 um 17:46 schrieb Mark Thomas: Hi all, I'd like to propose removing all the functional spec pages from the documentation web application. My reasoning for this proposal is, in short, that we aren't using or maintaining these pages. I don't recall any discussion of these docs on

[GitHub] [tomcat] markt-asf commented on pull request #304: Use https URLs when possible

2020-08-11 Thread GitBox
markt-asf commented on pull request #304: URL: https://github.com/apache/tomcat/pull/304#issuecomment-672066549 Closing as this PR cannot be applied as-is. Anyone interested in following through on this should start a discussion on the dev list as per my previous comment.

[GitHub] [tomcat] markt-asf closed pull request #304: Use https URLs when possible

2020-08-11 Thread GitBox
markt-asf closed pull request #304: URL: https://github.com/apache/tomcat/pull/304 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[tomcat] branch 7.0.x updated: Fix indentation of versionLoggerListener.*

2020-08-11 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new 6f96d40 Fix indentation of

[tomcat] branch 8.5.x updated: Fix indentation of versionLoggerListener.*

2020-08-11 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 4b36bc7 Fix indentation of

[tomcat] branch 9.0.x updated: Fix indentation of versionLoggerListener.*

2020-08-11 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new beee990 Fix indentation of

[tomcat] branch master updated: Update changelog

2020-08-11 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 7110da9 Update changelog 7110da9 is described

[tomcat] branch master updated: Fix indentation of versionLoggerListener.*

2020-08-11 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new e6afc85 Fix indentation of

[GitHub] [tomcat] markt-asf merged pull request #328: Fix indentation of versionLoggerListener.*

2020-08-11 Thread GitBox
markt-asf merged pull request #328: URL: https://github.com/apache/tomcat/pull/328 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[tomcat] branch 7.0.x updated: Add missing Javadoc

2020-08-11 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new 005d790 Add missing Javadoc 005d790 is described

[tomcat] branch 8.5.x updated: Add missing Javadoc

2020-08-11 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new b50d633 Add missing Javadoc b50d633 is described

[tomcat] branch 9.0.x updated: Add missing Javadoc

2020-08-11 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new cfd498e Add missing Javadoc cfd498e is described

[tomcat] branch master updated: Add missing Javadoc

2020-08-11 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 7aec7a7 Add missing Javadoc 7aec7a7 is

buildbot failure in on tomcat-7-trunk

2020-08-11 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-7-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-7-trunk/builds/1746 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The

buildbot failure in on tomcat-9-trunk

2020-08-11 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-9-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-9-trunk/builds/359 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The

buildbot failure in on tomcat-trunk

2020-08-11 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/5333 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchScheduler

[GitHub] [tomcat] markt-asf closed pull request #325: BZ 64265 Fix and simplify weak ETag matching

2020-08-11 Thread GitBox
markt-asf closed pull request #325: URL: https://github.com/apache/tomcat/pull/325 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tomcat] markt-asf commented on pull request #325: BZ 64265 Fix and simplify weak ETag matching

2020-08-11 Thread GitBox
markt-asf commented on pull request #325: URL: https://github.com/apache/tomcat/pull/325#issuecomment-672005180 Simplifying the matching is the wrong approach. The matching needs to be tightened up to be more spec compliant. A change to that effect has now been implemented.

[tomcat] branch 7.0.x updated: Improve entity tag handling

2020-08-11 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 7.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/7.0.x by this push: new 52e2b0a Improve entity tag handling 52e2b0a is

[tomcat] branch 8.5.x updated: Improve entity tag handling

2020-08-11 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new cd0dc59 Improve entity tag handling cd0dc59 is

[tomcat] branch 9.0.x updated: Improve entity tag handling

2020-08-11 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 1960471 Improve entity tag handling 1960471 is

[tomcat] branch master updated: Improve entity tag handling

2020-08-11 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new bef507e Improve entity tag handling bef507e is

Re: [PROPOSAL] Remove the functional specs from docs webapp

2020-08-11 Thread Filip Hanik
+1 On Mon, Aug 10, 2020 at 08:46 Mark Thomas wrote: > Hi all, > > I'd like to propose removing all the functional spec pages from the > documentation web application. > > My reasoning for this proposal is, in short, that we aren't using or > maintaining these pages. > > I don't recall any

Re: [PROPOSAL] Remove the functional specs from docs webapp

2020-08-11 Thread Martin Grigorov
On Mon, Aug 10, 2020 at 6:46 PM Mark Thomas wrote: > Hi all, > > I'd like to propose removing all the functional spec pages from the > documentation web application. > > My reasoning for this proposal is, in short, that we aren't using or > maintaining these pages. > > I don't recall any

[Bug 64660] NullPointerException in AprEdpoint.java

2020-08-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64660 --- Comment #1 from mgrigorov --- The problem is that "socketWrapper" is null at https://github.com/apache/tomcat/blob/9.0.x/java/org/apache/tomcat/util/net/AprEndpoint.java#L725 SocketWrapperBase socketWrapper =

[Bug 64628] tomcat6/7/8/9 processorCache is no remove from the processors of RequestGroupInfo in concurrent release

2020-08-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64628 --- Comment #4 from Gavin.peng --- Thanks Mark Thomas 's help ,the cache size exceed shown in the attachment is tomcat6,the default cache size is -1 in tomcat6,so has many request processor cached the tomcat7/8/9 the default cache is is

[GitHub] [tomcat] markt-asf commented on a change in pull request #325: BZ 64265 Fix and simplify weak ETag matching

2020-08-11 Thread GitBox
markt-asf commented on a change in pull request #325: URL: https://github.com/apache/tomcat/pull/325#discussion_r468504398 ## File path: java/org/apache/catalina/servlets/DefaultServlet.java ## @@ -2611,6 +2574,44 @@ private PrecompressedResource(WebResource resource,

[Bug 64660] New: NullPointerException in AprEdpoint.java

2020-08-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64660 Bug ID: 64660 Summary: NullPointerException in AprEdpoint.java Product: Tomcat 9 Version: 9.0.37 Hardware: PC OS: Linux Status: NEW Severity: normal