[GitHub] [tomcat] mcgitty commented on pull request #367: HTML URL must match RemoteAddrValve allow pattern

2020-09-22 Thread GitBox
mcgitty commented on pull request #367: URL: https://github.com/apache/tomcat/pull/367#issuecomment-696835594 Hi Mark, I found the root cause of the issue. It is the confusion created by this paragraph: > A default Tomcat installation includes the Manager. To add an

[GitHub] [tomcat] jbampton commented on pull request #361: Add a GitHub action to lint the Markdown and YAML files.

2020-09-22 Thread GitBox
jbampton commented on pull request #361: URL: https://github.com/apache/tomcat/pull/361#issuecomment-696741586 Hey @markt-asf what do you think about this PR ? This is an automated message from the Apache Git Service. To

[GitHub] [tomcat] markt-asf commented on pull request #367: HTML URL must match RemoteAddrValve allow pattern

2020-09-22 Thread GitBox
markt-asf commented on pull request #367: URL: https://github.com/apache/tomcat/pull/367#issuecomment-696733828 The premise of this PR is incorrect. The allow pattern in the `RemoteAddrValve` has no relationship to the host name used to access the Tomcat instance. The pattern is matched

[GitHub] [tomcat] jbampton commented on pull request #362: Fix spelling

2020-09-22 Thread GitBox
jbampton commented on pull request #362: URL: https://github.com/apache/tomcat/pull/362#issuecomment-696680907 Hey @markt-asf I just rebased and we have 20 files changed only in the `.xsd` files. Seems to be the same twenty that was in your list.

[GitHub] [tomcat] kamnani commented on pull request #351: Remove White Spaces from the JSP files

2020-09-22 Thread GitBox
kamnani commented on pull request #351: URL: https://github.com/apache/tomcat/pull/351#issuecomment-696807874 @markt-asf I am sure you wouldn't be able to test this on proprietary code, because that will generate empty outputs/compile-errors after stripping out the important

[GitHub] [tomcat] markt-asf closed pull request #367: HTML URL must match RemoteAddrValve allow pattern

2020-09-22 Thread GitBox
markt-asf closed pull request #367: URL: https://github.com/apache/tomcat/pull/367 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tomcat] markt-asf commented on pull request #362: Fix spelling

2020-09-22 Thread GitBox
markt-asf commented on pull request #362: URL: https://github.com/apache/tomcat/pull/362#issuecomment-696726509 Great. Thanks for the confirmation. On that basis, I am going to close the PR. Thanks for all the fixes. This

[GitHub] [tomcat] markt-asf closed pull request #362: Fix spelling

2020-09-22 Thread GitBox
markt-asf closed pull request #362: URL: https://github.com/apache/tomcat/pull/362 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tomcat] kamnani commented on pull request #352: Optimizing Resource Lookup using Bloom Filter

2020-09-22 Thread GitBox
kamnani commented on pull request #352: URL: https://github.com/apache/tomcat/pull/352#issuecomment-696834567 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [tomcat] rmaucher commented on pull request #352: Optimizing Resource Lookup using Bloom Filter

2020-09-22 Thread GitBox
rmaucher commented on pull request #352: URL: https://github.com/apache/tomcat/pull/352#issuecomment-696769628 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [tomcat] kamnani commented on pull request #352: Optimizing Resource Lookup using Bloom Filter

2020-09-22 Thread GitBox
kamnani commented on pull request #352: URL: https://github.com/apache/tomcat/pull/352#issuecomment-696930075 > There's no cache here: the AbstractArchiveResourceSet already has a "JarFile archive" field, so it adds a new JarContents field with the same data and both get created and

[GitHub] [tomcat] rmaucher commented on pull request #352: Optimizing Resource Lookup using Bloom Filter

2020-09-22 Thread GitBox
rmaucher commented on pull request #352: URL: https://github.com/apache/tomcat/pull/352#issuecomment-696927281 There's no cache here: the AbstractArchiveResourceSet already has a "JarFile archive" field, so it adds a new JarContents field with the same data and both get created and

[ANN] Apache Tomcat 7.0.106 released

2020-09-22 Thread Violeta Georgieva
The Apache Tomcat team announces the immediate availability of Apache Tomcat 7.0.106. Apache Tomcat is an open source software implementation of the Java Servlet, JavaServer Pages, Java Expression Language and Java WebSocket technologies. This release contains a number of bug fixes and

svn commit: r41541 - /release/tomcat/tomcat-7/v7.0.105/

2020-09-22 Thread violetagg
Author: violetagg Date: Tue Sep 22 17:42:36 2020 New Revision: 41541 Log: Remove 7.0.105 Removed: release/tomcat/tomcat-7/v7.0.105/ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands,

svn commit: r1881938 - in /tomcat/site/trunk/docs: ./ tomcat-7.0-doc/ tomcat-7.0-doc/annotationapi/ tomcat-7.0-doc/annotationapi/javax/annotation/ tomcat-7.0-doc/annotationapi/javax/annotation/securit

2020-09-22 Thread violetagg
Author: violetagg Date: Tue Sep 22 17:38:49 2020 New Revision: 1881938 URL: http://svn.apache.org/viewvc?rev=1881938=rev Log: Update docs for Apache Tomcat 7.0.106 release. [This commit notification would consist of 398 parts, which exceeds the limit of 50 ones, so it was shortened to the

svn commit: r1881937 - in /tomcat/site/trunk: ./ docs/ xdocs/

2020-09-22 Thread violetagg
Author: violetagg Date: Tue Sep 22 17:25:52 2020 New Revision: 1881937 URL: http://svn.apache.org/viewvc?rev=1881937=rev Log: Updates (excluding docs) for 7.0.106 release Modified: tomcat/site/trunk/build.properties.default tomcat/site/trunk/docs/doap_Tomcat.rdf

[GitHub] [tomcat] mcgitty commented on pull request #367: HTML URL must match RemoteAddrValve allow pattern

2020-09-22 Thread GitBox
mcgitty commented on pull request #367: URL: https://github.com/apache/tomcat/pull/367#issuecomment-696835594 Hi Mark, I found the root cause of the issue. It is the confusion created by this paragraph: > A default Tomcat installation includes the Manager. To add an

[GitHub] [tomcat] kamnani commented on pull request #352: Optimizing Resource Lookup using Bloom Filter

2020-09-22 Thread GitBox
kamnani commented on pull request #352: URL: https://github.com/apache/tomcat/pull/352#issuecomment-696834567 > I made the change to use the Context instead of the Host, no issue there. > However, I'm not ok with the proposed changes as is. The problem for me is that I don't understand

[GitHub] [tomcat] kamnani commented on pull request #351: Remove White Spaces from the JSP files

2020-09-22 Thread GitBox
kamnani commented on pull request #351: URL: https://github.com/apache/tomcat/pull/351#issuecomment-696807874 @markt-asf I am sure you wouldn't be able to test this on proprietary code, because that will generate empty outputs/compile-errors after stripping out the important

Re: WsFilter is missing destroy method

2020-09-22 Thread Ralph Goers
Thanks, That took care of the problem. I was using an older version of the servlet-api jar that wasn’t marked “provided”. Ralph > On Sep 21, 2020, at 11:15 PM, Apache wrote: > > Interesting. Thanks, I will check in the morning. > > Ralph > >> On Sep 21, 2020, at 10:31 PM, Romain Manni-Bucau

buildbot failure in on tomcat-9-trunk

2020-09-22 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-9-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-9-trunk/builds/457 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The

[GitHub] [tomcat] rmaucher commented on pull request #352: Optimizing Resource Lookup using Bloom Filter

2020-09-22 Thread GitBox
rmaucher commented on pull request #352: URL: https://github.com/apache/tomcat/pull/352#issuecomment-696769628 I made the change to use the Context instead of the Host, no issue there. However, I'm not ok with the proposed changes as is. The problem for me is that I don't understand the

[GitHub] [tomcat] jbampton commented on pull request #361: Add a GitHub action to lint the Markdown and YAML files.

2020-09-22 Thread GitBox
jbampton commented on pull request #361: URL: https://github.com/apache/tomcat/pull/361#issuecomment-696741586 Hey @markt-asf what do you think about this PR ? This is an automated message from the Apache Git Service. To

[GitHub] [tomcat] markt-asf closed pull request #367: HTML URL must match RemoteAddrValve allow pattern

2020-09-22 Thread GitBox
markt-asf closed pull request #367: URL: https://github.com/apache/tomcat/pull/367 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tomcat] markt-asf commented on pull request #367: HTML URL must match RemoteAddrValve allow pattern

2020-09-22 Thread GitBox
markt-asf commented on pull request #367: URL: https://github.com/apache/tomcat/pull/367#issuecomment-696733828 The premise of this PR is incorrect. The allow pattern in the `RemoteAddrValve` has no relationship to the host name used to access the Tomcat instance. The pattern is matched

[tomcat] branch 8.5.x updated: Fix double counting in tracking of in-flight async requests

2020-09-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 78d9c76 Fix double counting in tracking of

[tomcat] branch master updated: Fix double counting in tracking of in-flight async requests

2020-09-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 6d44f6a Fix double counting in tracking of

[tomcat] branch 9.0.x updated: Fix double counting in tracking of in-flight async requests

2020-09-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 31ca5a1 Fix double counting in tracking of

[GitHub] [tomcat] markt-asf commented on pull request #362: Fix spelling

2020-09-22 Thread GitBox
markt-asf commented on pull request #362: URL: https://github.com/apache/tomcat/pull/362#issuecomment-696726509 Great. Thanks for the confirmation. On that basis, I am going to close the PR. Thanks for all the fixes. This

[GitHub] [tomcat] markt-asf closed pull request #362: Fix spelling

2020-09-22 Thread GitBox
markt-asf closed pull request #362: URL: https://github.com/apache/tomcat/pull/362 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tomcat] jbampton commented on pull request #362: Fix spelling

2020-09-22 Thread GitBox
jbampton commented on pull request #362: URL: https://github.com/apache/tomcat/pull/362#issuecomment-696680907 Hey @markt-asf I just rebased and we have 20 files changed only in the `.xsd` files. Seems to be the same twenty that was in your list.

[Bug 63815] Expansion of JAVA_OPTS in catalina.sh containing '*' stops startup on linux

2020-09-22 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63815 --- Comment #16 from Mark Thomas --- This has been fixed in the main development branch for openjdk 16. The fix should be in the next EA release. There is currently no information on whether or not the fix will be back-ported. Once the

[tomcat-jakartaee-migration] branch master updated: Fix warning

2020-09-22 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git The following commit(s) were added to refs/heads/master by this push: new c05cc61 Fix warning c05cc61

[tomcat-jakartaee-migration] branch master updated: Improve tests results

2020-09-22 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git The following commit(s) were added to refs/heads/master by this push: new 5bf42bb Improve tests

Re: Application-accesible Executors

2020-09-22 Thread Romain Manni-Bucau
Le mar. 22 sept. 2020 à 08:54, Martin Grigorov a écrit : > Hi Chris, > > On Fri, Sep 18, 2020 at 7:10 PM Christopher Schultz < > ch...@christopherschultz.net> wrote: > > > All, > > > > I've recently been thinking about application uses of servlet-async and > > Websocket for long-running

Re: Application-accesible Executors

2020-09-22 Thread Martin Grigorov
Hi Chris, On Fri, Sep 18, 2020 at 7:10 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > All, > > I've recently been thinking about application uses of servlet-async and > Websocket for long-running operations, or really for any interactions > where you want to allow the

Re: WsFilter is missing destroy method

2020-09-22 Thread Apache
Interesting. Thanks, I will check in the morning. Ralph > On Sep 21, 2020, at 10:31 PM, Romain Manni-Bucau > wrote: > > Hi Ralph, > > Did you check your api jar was matching tomcat impl version? destroy is in > the interface (default method): >