[Bug 64850] Add support to tomcat for JEP380: Unix domain sockets

2020-10-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64850

--- Comment #5 from Graham Leggett  ---
(In reply to Michael Osipov from comment #1)
> This could have happened years ago with
> https://github.com/kohlschutter/junixsocket. Do you plan to use with
> mod_proxy UDS support?

Yes.

Right now given that APR v1.6 and above support unix domain sockets it's
possible that tomcat-native either supports this now already, or can be made to
support this will minimal changes. On the case working out what changes are
needed.

The purpose of this ticket is to make sure Tomcat supports JEP380 when it's
ready.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 64850] Add support to tomcat for JEP380: Unix domain sockets

2020-10-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64850

--- Comment #4 from Graham Leggett  ---
(In reply to Christopher Schultz from comment #3)
> If you are that concerned about latency and
> throughput, remove the reverse proxy and go straight to Tomcat.

Performance is largely irrelevant in this case. Unix domain sockets give you
the unix permissions model, something you don't get with TCP.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



JPMS module names

2020-10-27 Thread Mark Thomas
Hi all,

We are starting to get JPMS related bug reports. Resolving the issues is
technically simple but depends on us deciding on the names to use for
the various modules.

The names we choose for our own modules are easy. Generally we are using
the same or derivation from the OSGi module name.

The names we use for the spec API modules are a little more tricky. We
need to (try and) remain aligned with the RI spec JARs.

It looks like Jakarta EE 9 onwards is going to have consistent naming
(at least it does for the modules we use). Java EE 8 / Jakarta EE 8 is a
bit more inconsistent.

I have put together a wiki page that documents the current position and
the naming I propose we use in Tomcat.

https://cwiki.apache.org/confluence/display/TOMCAT/JPMS+names

Comments (in this thread ideally) welcome.

Once we (appear to) have consensus I'll update the builds to use the new
names and start fixing the associated bugs.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [tomcat] branch 8.5.x updated: Restore try catch around Poller.events

2020-10-27 Thread Mark Thomas
On 27/10/2020 17:34, Rémy Maucherat wrote:
> On Tue, Oct 27, 2020 at 6:08 PM  wrote:
> 
>> This is an automated email from the ASF dual-hosted git repository.
>>
>> markt pushed a commit to branch 8.5.x
>> in repository https://gitbox.apache.org/repos/asf/tomcat.git
>>
>>
>> The following commit(s) were added to refs/heads/8.5.x by this push:
>>  new 1c07384  Restore try catch around Poller.events
>> 1c07384 is described below
>>
>> commit 1c0738407e4c3a73b312fae279046249c2dc025d
>> Author: remm 
>> AuthorDate: Tue Oct 27 16:52:26 2020 +0100
>>
>> Restore try catch around Poller.events
>>
>> This is a regression caused when the Poller.events method was
>> refactored.
>>
> 
> I never refactored Poller.events in 8.5, so it still had its blanket
> try/catch, so no possible problems. This is a rather recent regression
> overall.

Ah. I see that now. I'll revert that change.

Mark

> 
> Rémy
> 
> 
>> ---
>>  java/org/apache/tomcat/util/net/NioEndpoint.java | 8 
>>  webapps/docs/changelog.xml   | 5 +
>>  2 files changed, 9 insertions(+), 4 deletions(-)
>>
>> diff --git a/java/org/apache/tomcat/util/net/NioEndpoint.java
>> b/java/org/apache/tomcat/util/net/NioEndpoint.java
>> index 08b8a4e..fadec98 100644
>> --- a/java/org/apache/tomcat/util/net/NioEndpoint.java
>> +++ b/java/org/apache/tomcat/util/net/NioEndpoint.java
>> @@ -849,15 +849,15 @@ public class NioEndpoint extends
>> AbstractJsseEndpoint {
>>  }
>>  break;
>>  }
>> +// Either we timed out or we woke up, process events
>> first
>> +if (keyCount == 0) {
>> +hasEvents = (hasEvents | events());
>> +}
>>  } catch (Throwable x) {
>>  ExceptionUtils.handleThrowable(x);
>>  log.error("",x);
>>  continue;
>>  }
>> -// Either we timed out or we woke up, process events first
>> -if (keyCount == 0) {
>> -hasEvents = (hasEvents | events());
>> -}
>>
>>  Iterator iterator =
>>  keyCount > 0 ? selector.selectedKeys().iterator() :
>> null;
>> diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
>> index 606603d..6e732eb 100644
>> --- a/webapps/docs/changelog.xml
>> +++ b/webapps/docs/changelog.xml
>> @@ -91,6 +91,11 @@
>>  63362: Add collection of statistics for HTTP/2,
>> WebSocket and
>>  connections upgraded via the HTTP upgrade mechanism. (markt)
>>
>> +  
>> +Restore exception catch around Poller.events, as it would cause
>> +the NIO poller thread to exit. This is a regression caused when
>> +the Poller.events method was refactored. (remm)
>> +  
>>  
>>
>>
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>
>>
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 64850] Add support to tomcat for JEP380: Unix domain sockets

2020-10-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64850

--- Comment #3 from Christopher Schultz  ---
I honestly don't see the point of using UDS in Tomcat, ever. I'm not going to
stop anyone from trying it, but:

1. UDS only works within a single kernel (so no inter-host communication)
2. TCP localhost is *really fast* and essentially boils down to shared kernel
buffers

I'm sure performance data show that you can pump more bps through a UDS than
you can through TCP, but how many one-box-wonders are there still out there
that need to go REALLY FAST? If you are that concerned about latency and
throughput, remove the reverse proxy and go straight to Tomcat.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: svn/git for website

2020-10-27 Thread Christopher Schultz

Konstantin,

On 10/26/20 20:47, Konstantin Kolinko wrote:

пт, 2 окт. 2020 г. в 00:09, Mark Thomas :


Hi all,

The topic came up at the BoF session at the end of the Tomcat track of
migrating the website from svn to git. There were strong opinions both
for migrating and for sticking with svn.

As a middle ground I'd like to propose we ask Infra to create a git
mirror of the svn repo.

For those who favour git:
The git mirror would be read-only but it would be possible to:
- clone the git mirror
- make changes in git
- use git-svn to commit those changes back to svn
- then the mirror automatically replicates them back to git

For those who favour svn there would be no change.

If there is agreement on this approach, I volunteer to contact infra to
get it set up.


My proposal at BoF was for a partial mirror.

The issue is that

1. I think that this mirror is intended as a tool to collect feedback
/ patches from random people, and to lower barriers for contribution.

2. The full Tomcat site is large. It includes documentation for all
versions of Tomcat, including javadocs. Those pages are changed rarely
and are not needed for people who contribute small changes for the
site. The source code for those pages is elsewhere.


The question I have to ask, here is: why do we bother putting all those 
files in revision-control? The users guide for 4 different versions of 
Tomcat is not a problem, but the javadocs are just stupid to store.


Is there some policy we are following by having all those files in 
there? Or is it just to make sure that website "publication" is as 
simple as "svn checkout"?



3. Subversion has easy commands to cope with such large source trees.
This feature is called "sparse checkouts".

For our site the necessary commands are documented in README.txt.
Essentially, it is done with --depth and --set-depth arguments to "svn
checkout" and "svn update" commands

Speaking about Git, there are huge repositories [1] out there, but I
think that the majority of people are not accustomed to them.

[1] https://en.wikipedia.org/wiki/Monorepo

I see that Git developers recently did some work to make dealing with
such repositories simpler, with addition of "git sparse-checkout"
command in Git 2.25.0 [2], released in January 2020.

[2] https://github.com/git/git/blob/v2.25.0/Documentation/RelNotes/2.25.0.txt

Though I think that support in tools is still lacking. E.g. missing in
TortoiseGit. [3]

[3] https://gitlab.com/tortoisegit/tortoisegit/issues/1599


If we go with a full Git mirror or with migration to Git, then I think
that somebody has to prepare an update to README.txt.

If we go with a partial Git mirror, I think it could be named
"tomcat-site-dev", reserving the name "tomcat-site" for a full mirror
if we ever make one.


Ignored paths for git-svn are configured with "--ignore-paths"
argument or with "svn-remote..ignore-paths" configuration
option. [4]

[4] https://git-scm.com/docs/git-svn


Other notes:

4. Release managers use Subversion to publish the binaries.

Thus I expect that they are able to update the published documentation
with Subversion as well.

5. Publishing the javadocs generates small changes over a large number
of files. The script that generates the commit email notes that the
diff is huge and trims it all to a small summary.

If we ever migrate to Git, I wonder whether a similar script in Git is
able to cope with it.


We might also want to consider complicating the website-building process 
in order to simplify the repository. Yes, "disk space is cheap" but it's 
kind of ridiculous that we have all that derivative content in RCS, 
separate from its canonical source.


-chris

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 64849] Embedded EL module descriptor missing uses and provides clauses

2020-10-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64849

--- Comment #1 from Mark Thomas  ---
The first thing we are going to need to do is fix the JPMS names so they agree
with the names used by the spec APIs.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 64550] create a project module to launch Tomcat in JPMS

2020-10-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64550

Mark Thomas  changed:

   What|Removed |Added

   Severity|normal  |enhancement

--- Comment #1 from Mark Thomas  ---
Moving to enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 64549] create a project module to launch Tomcat in OSGi

2020-10-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64549

Mark Thomas  changed:

   What|Removed |Added

   Severity|normal  |enhancement

--- Comment #1 from Mark Thomas  ---
Moving to enahncement

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [tomcat] branch 8.5.x updated: Restore try catch around Poller.events

2020-10-27 Thread Rémy Maucherat
On Tue, Oct 27, 2020 at 6:08 PM  wrote:

> This is an automated email from the ASF dual-hosted git repository.
>
> markt pushed a commit to branch 8.5.x
> in repository https://gitbox.apache.org/repos/asf/tomcat.git
>
>
> The following commit(s) were added to refs/heads/8.5.x by this push:
>  new 1c07384  Restore try catch around Poller.events
> 1c07384 is described below
>
> commit 1c0738407e4c3a73b312fae279046249c2dc025d
> Author: remm 
> AuthorDate: Tue Oct 27 16:52:26 2020 +0100
>
> Restore try catch around Poller.events
>
> This is a regression caused when the Poller.events method was
> refactored.
>

I never refactored Poller.events in 8.5, so it still had its blanket
try/catch, so no possible problems. This is a rather recent regression
overall.

Rémy


> ---
>  java/org/apache/tomcat/util/net/NioEndpoint.java | 8 
>  webapps/docs/changelog.xml   | 5 +
>  2 files changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/java/org/apache/tomcat/util/net/NioEndpoint.java
> b/java/org/apache/tomcat/util/net/NioEndpoint.java
> index 08b8a4e..fadec98 100644
> --- a/java/org/apache/tomcat/util/net/NioEndpoint.java
> +++ b/java/org/apache/tomcat/util/net/NioEndpoint.java
> @@ -849,15 +849,15 @@ public class NioEndpoint extends
> AbstractJsseEndpoint {
>  }
>  break;
>  }
> +// Either we timed out or we woke up, process events
> first
> +if (keyCount == 0) {
> +hasEvents = (hasEvents | events());
> +}
>  } catch (Throwable x) {
>  ExceptionUtils.handleThrowable(x);
>  log.error("",x);
>  continue;
>  }
> -// Either we timed out or we woke up, process events first
> -if (keyCount == 0) {
> -hasEvents = (hasEvents | events());
> -}
>
>  Iterator iterator =
>  keyCount > 0 ? selector.selectedKeys().iterator() :
> null;
> diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
> index 606603d..6e732eb 100644
> --- a/webapps/docs/changelog.xml
> +++ b/webapps/docs/changelog.xml
> @@ -91,6 +91,11 @@
>  63362: Add collection of statistics for HTTP/2,
> WebSocket and
>  connections upgraded via the HTTP upgrade mechanism. (markt)
>
> +  
> +Restore exception catch around Poller.events, as it would cause
> +the NIO poller thread to exit. This is a regression caused when
> +the Poller.events method was refactored. (remm)
> +  
>  
>
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


[Bug 64850] Add support to tomcat for JEP380: Unix domain sockets

2020-10-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64850

Mark Thomas  changed:

   What|Removed |Added

   Severity|normal  |enhancement

--- Comment #2 from Mark Thomas  ---
Tomcat doesn't use the StandardProtocolFamily enum.

All casts to InetSocketAddress are preceded by a check that the cast is valid.

Supporting the configuration of a unix domain socket would require changes but
I don't see anything here that would break the existing code.

Moving this to an enhancement.

I'll note that Tomcat support will need to wait until there is at least an EA
release with an implementation and that support in Tomcat will need to be
optional until the minimum Java version required by Tomcat includes this
feature.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 64839] HTTP2: Exception in thread "http-nio-x.y.z-1090-ClientPoller" java.lang.NullPointerException

2020-10-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64839

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #15 from Mark Thomas  ---
Also back-ported to 8.5.x for 8.5.60 onwards.

As always, the next round of releases will start around the beginning of the
month once all the open issues have been addressed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[tomcat] branch 8.5.x updated: Restore try catch around Poller.events

2020-10-27 Thread markt
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/8.5.x by this push:
 new 1c07384  Restore try catch around Poller.events
1c07384 is described below

commit 1c0738407e4c3a73b312fae279046249c2dc025d
Author: remm 
AuthorDate: Tue Oct 27 16:52:26 2020 +0100

Restore try catch around Poller.events

This is a regression caused when the Poller.events method was
refactored.
---
 java/org/apache/tomcat/util/net/NioEndpoint.java | 8 
 webapps/docs/changelog.xml   | 5 +
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/java/org/apache/tomcat/util/net/NioEndpoint.java 
b/java/org/apache/tomcat/util/net/NioEndpoint.java
index 08b8a4e..fadec98 100644
--- a/java/org/apache/tomcat/util/net/NioEndpoint.java
+++ b/java/org/apache/tomcat/util/net/NioEndpoint.java
@@ -849,15 +849,15 @@ public class NioEndpoint extends 
AbstractJsseEndpoint {
 }
 break;
 }
+// Either we timed out or we woke up, process events first
+if (keyCount == 0) {
+hasEvents = (hasEvents | events());
+}
 } catch (Throwable x) {
 ExceptionUtils.handleThrowable(x);
 log.error("",x);
 continue;
 }
-// Either we timed out or we woke up, process events first
-if (keyCount == 0) {
-hasEvents = (hasEvents | events());
-}
 
 Iterator iterator =
 keyCount > 0 ? selector.selectedKeys().iterator() : null;
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 606603d..6e732eb 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -91,6 +91,11 @@
 63362: Add collection of statistics for HTTP/2, WebSocket 
and
 connections upgraded via the HTTP upgrade mechanism. (markt)
   
+  
+Restore exception catch around Poller.events, as it would cause
+the NIO poller thread to exit. This is a regression caused when
+the Poller.events method was refactored. (remm)
+  
 
   
   


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 64839] HTTP2: Exception in thread "http-nio-x.y.z-1090-ClientPoller" java.lang.NullPointerException

2020-10-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64839

--- Comment #14 from Arshiya  ---
Thanks a ton Remy!

Any update on the tentative release date of 9.0.40 please .

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 64839] HTTP2: Exception in thread "http-nio-x.y.z-1090-ClientPoller" java.lang.NullPointerException

2020-10-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64839

--- Comment #13 from Remy Maucherat  ---
A previous refactoring of the Poller.events() could cause this uncaught
exception to occur. This is fixed in 10.0.0-M10 and 9.0.40 where the NPE will
be logged properly and Tomcat should be able to continue processing requests.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[tomcat] branch 9.0.x updated: Restore try catch around Poller.events

2020-10-27 Thread remm
This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/9.0.x by this push:
 new 981a5f2  Restore try catch around Poller.events
981a5f2 is described below

commit 981a5f287720abeb67c3ae9f4336ec8da4f71f0f
Author: remm 
AuthorDate: Tue Oct 27 16:52:26 2020 +0100

Restore try catch around Poller.events

This is a regression caused when the Poller.events method was
refactored.
---
 java/org/apache/tomcat/util/net/NioEndpoint.java | 8 
 webapps/docs/changelog.xml   | 5 +
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/java/org/apache/tomcat/util/net/NioEndpoint.java 
b/java/org/apache/tomcat/util/net/NioEndpoint.java
index d7afa0e..827fa08 100644
--- a/java/org/apache/tomcat/util/net/NioEndpoint.java
+++ b/java/org/apache/tomcat/util/net/NioEndpoint.java
@@ -720,15 +720,15 @@ public class NioEndpoint extends 
AbstractJsseEndpoint
 }
 break;
 }
+// Either we timed out or we woke up, process events first
+if (keyCount == 0) {
+hasEvents = (hasEvents | events());
+}
 } catch (Throwable x) {
 ExceptionUtils.handleThrowable(x);
 log.error(sm.getString("endpoint.nio.selectorLoopError"), 
x);
 continue;
 }
-// Either we timed out or we woke up, process events first
-if (keyCount == 0) {
-hasEvents = (hasEvents | events());
-}
 
 Iterator iterator =
 keyCount > 0 ? selector.selectedKeys().iterator() : null;
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index ddd15a7..0689c1d 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -107,6 +107,11 @@
 63362: Add collection of statistics for HTTP/2, WebSocket 
and
 connections upgraded via the HTTP upgrade mechanism. (markt)
   
+  
+Restore exception catch around Poller.events, as it would cause
+the NIO poller thread to exit. This is a regression caused when
+the Poller.events method was refactored. (remm)
+  
 
   
   


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[tomcat] branch master updated: Restore try catch around Poller.events

2020-10-27 Thread remm
This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/master by this push:
 new 2212a10  Restore try catch around Poller.events
2212a10 is described below

commit 2212a103eedfcae932aff9488f84b6a5e8d0949f
Author: remm 
AuthorDate: Tue Oct 27 16:52:26 2020 +0100

Restore try catch around Poller.events

This is a regression caused when the Poller.events method was
refactored.
---
 java/org/apache/tomcat/util/net/NioEndpoint.java | 8 
 webapps/docs/changelog.xml   | 5 +
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/java/org/apache/tomcat/util/net/NioEndpoint.java 
b/java/org/apache/tomcat/util/net/NioEndpoint.java
index 1f1a8c8..c7edd6d 100644
--- a/java/org/apache/tomcat/util/net/NioEndpoint.java
+++ b/java/org/apache/tomcat/util/net/NioEndpoint.java
@@ -667,15 +667,15 @@ public class NioEndpoint extends 
AbstractJsseEndpoint
 }
 break;
 }
+// Either we timed out or we woke up, process events first
+if (keyCount == 0) {
+hasEvents = (hasEvents | events());
+}
 } catch (Throwable x) {
 ExceptionUtils.handleThrowable(x);
 log.error(sm.getString("endpoint.nio.selectorLoopError"), 
x);
 continue;
 }
-// Either we timed out or we woke up, process events first
-if (keyCount == 0) {
-hasEvents = (hasEvents | events());
-}
 
 Iterator iterator =
 keyCount > 0 ? selector.selectedKeys().iterator() : null;
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 6d09d75..f5adf81 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -107,6 +107,11 @@
 63362: Add collection of statistics for HTTP/2, WebSocket 
and
 connections upgraded via the HTTP upgrade mechanism. (markt)
   
+  
+Restore exception catch around Poller.events, as it would cause
+the NIO poller thread to exit. This is a regression caused when
+the Poller.events method was refactored. (remm)
+  
 
   
   


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 64839] HTTP2: Exception in thread "http-nio-x.y.z-1090-ClientPoller" java.lang.NullPointerException

2020-10-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64839

--- Comment #12 from Remy Maucherat  ---
I made a mistake, I was not looking at the right call to events(). So this
should be tightened up [although I don't see how it can end up in this
situation].

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 64839] HTTP2: Exception in thread "http-nio-x.y.z-1090-ClientPoller" java.lang.NullPointerException

2020-10-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64839

--- Comment #11 from Arshiya  ---
Thank you for the swift response Remy.

For a few hours the application accepts requests and processes fine , but
suddenly after this exception is logged , none of the requests are accepted
(tps drops to 0) .

Is this because the external client closes the connection causing this issue in
the Poller ?

If the issue is due to the environment , what can the suspect be on ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 64839] HTTP2: Exception in thread "http-nio-x.y.z-1090-ClientPoller" java.lang.NullPointerException

2020-10-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64839

--- Comment #10 from Remy Maucherat  ---
Ok, so this NPE will be caught and logged with no major consequences. There is
normally no way it could happen, however (the SocketChannel of the NioChannel
is null, which only happens for the closed channel, which is not supposed to be
in the poller).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 64839] HTTP2: Exception in thread "http-nio-x.y.z-1090-ClientPoller" java.lang.NullPointerException

2020-10-27 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64839

Arshiya  changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

--- Comment #9 from Arshiya  ---
Please find the trace of the NullPointerException:

Exception in thread "http-nio-x.y.x-1090-ClientPoller"
java.lang.NullPointerException
at org.apache.tomcat.util.net.NioEndpoint$Poller.events(NioEndpoint.java:614)
at org.apache.tomcat.util.net.NioEndpoint$Poller.run(NioEndpoint.java:730)
at java.lang.Thread.run(Thread.java:748)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org