Re: JPMS module names
Mark, On Thu, Oct 29, 2020 at 12:43 PM Mark Thomas wrote: > Hi all, > > Just a reminder that this is on the radar. I'll likely be looking to > make these changes early next week as part of the prep for the next > release round (I need to sort this to be able to fix BZ 64849 sensibly). > > Mark > > > On 27/10/2020 20:04, Mark Thomas wrote: > > Hi all, > > > > We are starting to get JPMS related bug reports. Resolving the issues is > > technically simple but depends on us deciding on the names to use for > > the various modules. > > > > The names we choose for our own modules are easy. Generally we are using > > the same or derivation from the OSGi module name. > > > > The names we use for the spec API modules are a little more tricky. We > > need to (try and) remain aligned with the RI spec JARs. > > > > It looks like Jakarta EE 9 onwards is going to have consistent naming > > (at least it does for the modules we use). Java EE 8 / Jakarta EE 8 is a > > bit more inconsistent. > > > > I have put together a wiki page that documents the current position and > > the naming I propose we use in Tomcat. > > > > https://cwiki.apache.org/confluence/display/TOMCAT/JPMS+names > > > > Comments (in this thread ideally) welcome. > +1. Your proposal looks good. Best, Igal > > > > Once we (appear to) have consensus I'll update the builds to use the new > > names and start fixing the associated bugs. > > > > Mark > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > > For additional commands, e-mail: dev-h...@tomcat.apache.org > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
[Bug 64863] stderr logfile is corrupted when running as Windows service
https://bz.apache.org/bugzilla/show_bug.cgi?id=64863 --- Comment #2 from scholzb-hb --- Thanks for the quick response. New issue: https://issues.apache.org/jira/browse/DAEMON-424 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 64858] Allow to deploy a WAR whose dependencies are on a Maven repository
https://bz.apache.org/bugzilla/show_bug.cgi?id=64858 --- Comment #6 from Gael Lalire --- Yes, WebResource are a terrific extension point. However it's a pity that scanners don't use it and rely on constructed jar: URL. Anyway I already use WebResource but I need an entry point. As long as JPMS named module are not activated I can overload Tomcat classes by a classpath hack. But with JPMS named module activated I cannot use an already defined package that why I propose this PR https://github.com/apache/tomcat/pull/375. Of course I created the extension point for my need, and it may be changed to a more generic way or split into multiple extension points. Anyway I'm sorry to read that such integration has (almost) no change to get merged and I would like to know why do you think that. I also saw you now provide generated named bundle through BND. I tested it and got 3 issues : - missing uses, you can either configure BND (el-api.jar.tmp.bnd) to add it or add "ExpressionFactory.class.getModule().addUses(ExpressionFactory.class);" in the ExpressionFactory class. - missing Module package on org.apache.tomcat.jasper.el, the includepackage option of jasper-el.jar.tmp.bnd seems ignored. - JSP compilation failed, but I did not look onto it yet -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
