[jira] [Resolved] (MTOMCAT-321) trimDirectiveWhitespaces does not apply for custom tags in Tomcat provided jasper lib

[Mark Thomas (Jira)]

 [ 
https://issues.apache.org/jira/browse/MTOMCAT-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Thomas resolved MTOMCAT-321.
-
Resolution: Invalid

This looks like a Tomcat issue rather than a Tomcat Maven plugin issue so 
please raise it via Tomcat's issue tracker: 
[http://tomcat.apache.org/bugreport.html]

Generally, if you can provide a minimal test case that demonstrates the bug 
that speeds up resolution of the issue.

> trimDirectiveWhitespaces does not apply for custom tags in Tomcat provided 
> jasper lib
> -
>
> Key: MTOMCAT-321
> URL: https://issues.apache.org/jira/browse/MTOMCAT-321
> Project: Apache Tomcat Maven Plugin
>  Issue Type: Bug
> Environment: tomcat.version  : 7.0.82.A.RELEASE
> spring.version :  4.3.17.RELEASE
> java.version :  1.8
>Reporter: Hicham
>Priority: Major
> Attachments: image-2020-11-27-14-03-02-603.png, 
> image-2020-11-27-14-08-01-135.png, image-2020-11-27-14-15-31-718.png, 
> image-2020-11-27-14-17-23-102.png
>
>
> Hello,
> We have a Spring based web application project where we have about 350 custom 
> tags under /WEB-INF/tags/. When inspecting the source page html, we can see a 
> lot of generated white spaces between html elements (around 5000 back to 
> lines added). 
> !image-2020-11-27-14-17-23-102.png|width=573,height=386!
> We already have done the configuration in the jsp level as follow 
> {code:java}
> 
>   
> *.jsp 
> 
>  true <
> !-- Remove additional whitespace due to JSP directives --> 
> true
>   
> 
> {code}
> And we also declared the <%@ page trimDirectiveWhitespaces="true" %> inside 
> our jsp  custom pages.
>  
> We want to trim white space in all custom tags, so we've added the directive 
> <%@ tag trimDirectiveWhitespaces="true" %>. And  we had some blocking issues 
> as this directive on tag level trim inner html element spaces !
> For example a radio button that have checked directive inside it  will be 
> like :
> 
> !image-2020-11-27-14-08-01-135.png|width=508,height=74!
>  
> You can notice that the checked is concatenated with the field 
> data-track-event.
>  
> We also tried the following configuration
> {code:java}
>  
> *.tag 
> true 
> 
> {code}
> But this is blocked by the JspConfig class.
> !image-2020-11-27-14-03-02-603.png|width=977,height=292!
>  
> So adding <%@ tag trimDirectiveWhitespaces="true" %>  to prevent those 
> generated white spaces in all our custom tags will have an expected errors 
> and very difficult to identify in our production code, as it will required a 
> lot of tests and analysis.
> And with this unexpected side effect of removing inner html element white 
> spaces, we are afraid to break all existing front end functionalities, like 
> checkout pages, user registration, order creations ... 
>  
> Can you please help on this issue by providing us with a fix or a workaround ?
> tomcat.version  : 7.0.82.A.RELEAS
> spring.version :  4.3.17.RELEASE7
> java.version : 1.8
> !image-2020-11-27-14-15-31-718.png|width=584,height=179!
> Best Regards



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[jira] [Updated] (MTOMCAT-321) trimDirectiveWhitespaces does not apply for custom tags in Tomcat provided jasper lib

[Hicham Mouloudi (Jira)]

 [ 
https://issues.apache.org/jira/browse/MTOMCAT-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hicham Mouloudi updated MTOMCAT-321:

Description: 
Hello,

We have a Spring based web application project where we have about 350 custom 
tags under /WEB-INF/tags/. When inspecting the source page html, we can see a 
lot of generated white spaces between html elements (around 5000 back to lines 
added). 

!image-2020-11-27-14-17-23-102.png|width=573,height=386!

We already have done the configuration in the jsp level as follow 
{code:java}

  
*.jsp 

 true <
!-- Remove additional whitespace due to JSP directives --> 
true
  

{code}
And we also declared the <%@ page trimDirectiveWhitespaces="true" %> inside our 
jsp  custom pages.

 

We want to trim white space in all custom tags, so we've added the directive 
<%@ tag trimDirectiveWhitespaces="true" %>. And  we had some blocking issues as 
this directive on tag level trim inner html element spaces !

For example a radio button that have checked directive inside it  will be like :



!image-2020-11-27-14-08-01-135.png|width=508,height=74!

 

You can notice that the checked is concatenated with the field data-track-event.

 

We also tried the following configuration
{code:java}
 
*.tag 
true 

{code}
But this is blocked by the JspConfig class.

!image-2020-11-27-14-03-02-603.png|width=977,height=292!

 

So adding <%@ tag trimDirectiveWhitespaces="true" %>  to prevent those 
generated white spaces in all our custom tags will have an expected errors and 
very difficult to identify in our production code, as it will required a lot of 
tests and analysis.

And with this unexpected side effect of removing inner html element white 
spaces, we are afraid to break all existing front end functionalities, like 
checkout pages, user registration, order creations ... 

 

Can you please help on this issue by providing us with a fix or a workaround ?

tomcat.version  : 7.0.82.A.RELEAS

spring.version :  4.3.17.RELEASE7

java.version : 1.8

!image-2020-11-27-14-15-31-718.png|width=584,height=179!

Best Regards

  was:
Hello,

We have a Spring based web application project where we have about 350 custom 
tags under /WEB-INF/tags/. When inspecting the source page html, we can see a 
lot of generated white spaces between html elements (around 5000 back to lines 
added). 

!image-2020-11-27-14-17-23-102.png|width=573,height=386!

We already have done the configuration in the jsp level as follow 
{code:java}

  
*.jsp 

 true <
!-- Remove additional whitespace due to JSP directives --> 
true
  

{code}
And we also declared the <%@ page trimDirectiveWhitespaces="true" %> inside our 
jsp  custom pages.

 

We want to trim white space in all custom tags, so we've added the directive 
<%@ tag trimDirectiveWhitespaces="true" %>. And  we had some blocking issues as 
this directive on tag level trim inner html element spaces !

For example a radio button that have checked directive inside it  will be like :



!image-2020-11-27-14-08-01-135.png|width=508,height=74!

 

You can notice that the checked is concatenated with the field data-track-event.

 

We also tried the following configuration
{code:java}
 
*.tag 
true 

{code}
But this is blocked by the JspConfig class.

!image-2020-11-27-14-03-02-603.png|width=977,height=292!

 

So adding <%@ tag trimDirectiveWhitespaces="true" %>  to prevent those 
generated white spaces in all our custom tags will have an expected error in 
our production code, as it will required a lot of test and analysis. And with 
this issue of removing inner html element white space we are afraid to break 
all existing front end functionalities, like checkout pages, user registration, 
order creations ... 

 

Can you please help on this issue by providing us with a fix or a workaround ?

tomcat.version  : 7.0.82.A.RELEAS

spring.version :  4.3.17.RELEASE7

java.version : 1.8

!image-2020-11-27-14-15-31-718.png|width=584,height=179!

Best Regards


> trimDirectiveWhitespaces does not apply for custom tags in Tomcat provided 
> jasper lib
> -
>
> Key: MTOMCAT-321
> URL: https://issues.apache.org/jira/browse/MTOMCAT-321
> Project: Apache Tomcat Maven Plugin
>  Issue Type: Bug
> Environment: tomcat.version  : 7.0.82.A.RELEASE
> spring.version :  4.3.17.RELEASE
> java.version :  1.8
>Reporter: Hicham Mouloudi
>Priority: Major
> Attachments: image-2020-11-27-14-03-02-603.png, 
> image-2020-11-27-14-08-01-135.png, image-2020-11-27-14-15-31-718.png, 
> image-2020-11-27-14-17-23-102.png
>
>
> Hello,
> We have a Spring based web application project where we have about 350 custom 
> tags under /WEB-INF/tags/. When inspecting the source page html, we can see a 
> lot of generated white spaces between html elements (around 

[jira] [Updated] (MTOMCAT-321) trimDirectiveWhitespaces does not apply for custom tags in Tomcat provided jasper lib

[Hicham Mouloudi (Jira)]

 [ 
https://issues.apache.org/jira/browse/MTOMCAT-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hicham Mouloudi updated MTOMCAT-321:

Description: 
Hello,

We have a Spring based web application project where we have about 350 custom 
tags under /WEB-INF/tags/. When inspecting the source page html, we can see a 
lot of generated white spaces between html elements (around 5000 back to lines 
added). 

!image-2020-11-27-14-17-23-102.png|width=573,height=386!

We already have done the configuration in the jsp level as follow 
{code:java}

  
*.jsp 

 true <
!-- Remove additional whitespace due to JSP directives --> 
true
  

{code}
And we also declared the <%@ page trimDirectiveWhitespaces="true" %> inside our 
jsp  custom pages.

 

We want to trim white space in all custom tags, so we've added the directive 
<%@ tag trimDirectiveWhitespaces="true" %>. And  we had some blocking issues as 
this directive on tag level trim inner html element spaces !

For example a radio button that have checked directive inside it  will be like :



!image-2020-11-27-14-08-01-135.png|width=508,height=74!

 

You can notice that the checked is concatenated with the field data-track-event.

 

We also tried the following configuration
{code:java}
 
*.tag 
true 

{code}
But this is blocked by the JspConfig class.

!image-2020-11-27-14-03-02-603.png|width=977,height=292!

 

So adding <%@ tag trimDirectiveWhitespaces="true" %>  to prevent those 
generated white spaces in all our custom tags will have an expected error in 
our production code, as it will required a lot of test and analysis. And with 
this issue of removing inner html element white space we are afraid to break 
all existing front end functionalities, like checkout pages, user registration, 
order creations ... 

 

Can you please help on this issue by providing us with a fix or a workaround ?

tomcat.version  : 7.0.82.A.RELEAS

spring.version :  4.3.17.RELEASE7

java.version : 1.8

!image-2020-11-27-14-15-31-718.png|width=584,height=179!

Best Regards

  was:
Hello,

We have a Spring based web application project where we have about 350 custom 
tags under /WEB-INF/tags/. When inspecting the source page html, we can see a 
lot of generated white spaces between html elements (around 5000 back to lines 
added). 

!image-2020-11-27-14-17-23-102.png|width=573,height=386!

We already have done the configuration in the jsp level as follow 
{code:java}

  
*.jsp 

 true <
!-- Remove additional whitespace due to JSP directives --> 
true
  

{code}
And we also declared the <%@ page trimDirectiveWhitespaces="true" %> inside our 
jsp  custom pages.

 

We want to trim white space in all custom tags, so we've added the directive 
<%@ tag trimDirectiveWhitespaces="true" %>. And  we had some blocking issues as 
this directive on tag level trim inner html element spaces !

For example a radio button that have checked directive inside it  will be like :



!image-2020-11-27-14-08-01-135.png|width=508,height=74!

 

You can notice that the checked is concatenated with the field data-track-event.

 

We also tried the following configuration
{code:java}
 
*.tag 
true 

{code}
But this is blocked by the JspConfig class.

!image-2020-11-27-14-03-02-603.png|width=977,height=292!

 

So adding <%@ tag trimDirectiveWhitespaces="true" %>  to prevent those 
generated white space in all our custom tags will have an expected error in our 
production code, as it will required a lot of test and analysis. And with this 
issue of removing inner html element white space we are afraid to break all 
existing front end functionalities, like checkout pages, user registration, 
order creations ... 

 

Can you please help on this issue by providing us with a fix or a workaround ?

tomcat.version  : 7.0.82.A.RELEAS

spring.version :  4.3.17.RELEASE7

java.version : 1.8

!image-2020-11-27-14-15-31-718.png|width=584,height=179!

Best Regards


> trimDirectiveWhitespaces does not apply for custom tags in Tomcat provided 
> jasper lib
> -
>
> Key: MTOMCAT-321
> URL: https://issues.apache.org/jira/browse/MTOMCAT-321
> Project: Apache Tomcat Maven Plugin
>  Issue Type: Bug
> Environment: tomcat.version  : 7.0.82.A.RELEASE
> spring.version :  4.3.17.RELEASE
> java.version :  1.8
>Reporter: Hicham Mouloudi
>Priority: Major
> Attachments: image-2020-11-27-14-03-02-603.png, 
> image-2020-11-27-14-08-01-135.png, image-2020-11-27-14-15-31-718.png, 
> image-2020-11-27-14-17-23-102.png
>
>
> Hello,
> We have a Spring based web application project where we have about 350 custom 
> tags under /WEB-INF/tags/. When inspecting the source page html, we can see a 
> lot of generated white spaces between html elements (around 5000 back to 
> lines added). 
> 

[jira] [Updated] (MTOMCAT-321) trimDirectiveWhitespaces does not apply for custom tags in Tomcat provided jasper lib

[Hicham Mouloudi (Jira)]

 [ 
https://issues.apache.org/jira/browse/MTOMCAT-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hicham Mouloudi updated MTOMCAT-321:

Description: 
Hello,

We have a Spring based web application project where we have about 350 custom 
tags under /WEB-INF/tags/. When inspecting the source page html, we can see a 
lot of generated white spaces between html elements (around 5000 back to lines 
added). 

!image-2020-11-27-14-17-23-102.png|width=573,height=386!

We already have done the configuration in the jsp level as follow 
{code:java}

  
*.jsp 

 true <
!-- Remove additional whitespace due to JSP directives --> 
true
  

{code}
And we also declared the <%@ page trimDirectiveWhitespaces="true" %> inside our 
jsp  custom pages.

 

We want to trim white space in all custom tags, so we've added the directive 
<%@ tag trimDirectiveWhitespaces="true" %>. And  we had some blocking issues as 
this directive on tag level trim inner html element spaces !

For example a radio button that have checked directive inside it  will be like :



!image-2020-11-27-14-08-01-135.png|width=508,height=74!

 

You can notice that the checked is concatenated with the field data-track-event.

 

We also tried the following configuration
{code:java}
 
*.tag 
true 

{code}
But this is blocked by the JspConfig class.

!image-2020-11-27-14-03-02-603.png|width=977,height=292!

 

So adding <%@ tag trimDirectiveWhitespaces="true" %>  to prevent those 
generated white space in all our custom tags will have an expected error in our 
production code, as it will required a lot of test and analysis. And with this 
issue of removing inner html element white space we are afraid to break all 
existing front end functionalities, like checkout pages, user registration, 
order creations ... 

 

Can you please help on this issue by providing us with a fix or a workaround ?

tomcat.version  : 7.0.82.A.RELEAS

spring.version :  4.3.17.RELEASE7

java.version : 1.8

!image-2020-11-27-14-15-31-718.png|width=584,height=179!

Best Regards

  was:
Hello,

We have a Spring based web application project where we have about 350 custom 
tags under /WEB-INF/tags/. When inspecting the source page html, we can see a 
lot of generated white spaces between html elements (around 5000 back to lines 
added). 

!image-2020-11-27-14-17-23-102.png|width=573,height=386!

We already have done the configuration in the jsp level as follow 
{code:java}

  
*.jsp 

 true <
!-- Remove additional whitespace due to JSP directives --> 
true
  

{code}
And we also declared the <%@ page trimDirectiveWhitespaces="true" %> inside our 
jsp  custom pages.

 

We want to trim white space in all custom tags, so we need to add <%@ tag 
trimDirectiveWhitespaces="true" %> we had some blocking issues as this 
directive on tag level trim inner html element spaces 

For example a radio button that have checked directive inside will be like 



!image-2020-11-27-14-08-01-135.png|width=508,height=74!

You can notice that the checked is concatenated with the field data-track-event.

 

We also tried the following configuration
{code:java}
 
*.tag 
true 

{code}
But this is blocked by the JspConfig class.

!image-2020-11-27-14-03-02-603.png|width=977,height=292!

 

So adding <%@ tag trimDirectiveWhitespaces="true" %>  to prevent those 
generated white space in all our custom tags will have an expected error in our 
production code, as it will required a lot of test and analysis. And with this 
issue of removing inner html element white space we are afraid to break all 
existing front end functionalities, like checkout pages, user registration, 
order creations ... 

 

Can you please help on this issue by providing us with a fix or a workaround ?

tomcat.version  : 7.0.82.A.RELEAS

spring.version :  4.3.17.RELEASE7

java.version : 1.8

!image-2020-11-27-14-15-31-718.png|width=584,height=179!

Best Regards


> trimDirectiveWhitespaces does not apply for custom tags in Tomcat provided 
> jasper lib
> -
>
> Key: MTOMCAT-321
> URL: https://issues.apache.org/jira/browse/MTOMCAT-321
> Project: Apache Tomcat Maven Plugin
>  Issue Type: Bug
> Environment: tomcat.version  : 7.0.82.A.RELEASE
> spring.version :  4.3.17.RELEASE
> java.version :  1.8
>Reporter: Hicham Mouloudi
>Priority: Major
> Attachments: image-2020-11-27-14-03-02-603.png, 
> image-2020-11-27-14-08-01-135.png, image-2020-11-27-14-15-31-718.png, 
> image-2020-11-27-14-17-23-102.png
>
>
> Hello,
> We have a Spring based web application project where we have about 350 custom 
> tags under /WEB-INF/tags/. When inspecting the source page html, we can see a 
> lot of generated white spaces between html elements (around 5000 back to 
> lines added). 
> 

[jira] [Updated] (MTOMCAT-321) trimDirectiveWhitespaces does not apply for custom tags in Tomcat provided jasper lib

[Hicham Mouloudi (Jira)]

 [ 
https://issues.apache.org/jira/browse/MTOMCAT-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hicham Mouloudi updated MTOMCAT-321:

Description: 
Hello,

We have a Spring based web application project where we have about 350 custom 
tags under /WEB-INF/tags/. When inspecting the source page html, we can see a 
lot of generated white spaces between html elements (around 5000 back to lines 
added). 

!image-2020-11-27-14-17-23-102.png|width=573,height=386!

We already have done the configuration in the jsp level as follow 
{code:java}

  
*.jsp 

 true <
!-- Remove additional whitespace due to JSP directives --> 
true
  

{code}
And we also declared the <%@ page trimDirectiveWhitespaces="true" %> inside our 
jsp  custom pages.

 

We want to trim white space in all custom tags, so we need to add <%@ tag 
trimDirectiveWhitespaces="true" %> we had some blocking issues as this 
directive on tag level trim inner html element spaces 

For example a radio button that have checked directive inside will be like 



!image-2020-11-27-14-08-01-135.png|width=508,height=74!

You can notice that the checked is concatenated with the field data-track-event.

 

We also tried the following configuration
{code:java}
 
*.tag 
true 

{code}
But this is blocked by the JspConfig class.

!image-2020-11-27-14-03-02-603.png|width=977,height=292!

 

So adding <%@ tag trimDirectiveWhitespaces="true" %>  to prevent those 
generated white space in all our custom tags will have an expected error in our 
production code, as it will required a lot of test and analysis. And with this 
issue of removing inner html element white space we are afraid to break all 
existing front end functionalities, like checkout pages, user registration, 
order creations ... 

 

Can you please help on this issue by providing us with a fix or a workaround ?

tomcat.version  : 7.0.82.A.RELEAS

spring.version :  4.3.17.RELEASE7

java.version : 1.8

!image-2020-11-27-14-15-31-718.png|width=584,height=179!

Best Regards

  was:
Hello,

We have a Spring based web application project where we have about 350 custom 
tags under /WEB-INF/tags/. When inspecting the source page html, we can see a 
lot of generated white spaces between html elements (arround 5000 back to lines 
added). 

We already have the configuration in the jsp level as follow 
{code:java}
  *.jsp  true 
 
true 
 
{code}
And we also declared the <%@ page trimDirectiveWhitespaces="true" %> inside our 
jsp  custom pages.

 

We want to trim white space in all custom tags, so we need to add <%@ tag 
trimDirectiveWhitespaces="true" %> we had some blocking issues as this 
directive on tag level trim inner html element spaces 

For example a radio button that have checked directive inside will be like 



!image-2020-11-27-14-08-01-135.png|width=508,height=74!

You can notice that the checked is concatenated with the field data-track-event.

 

We also tried the following configuration
{code:java}
 
*.tag 
true 

{code}
But this is blocked by the JspConfig class.

!image-2020-11-27-14-03-02-603.png|width=977,height=292!

 

So adding <%@ tag trimDirectiveWhitespaces="true" %>  to prevent those 
generated white space in all our custom tags will have an expected error in our 
production code, as it will required a lot of test and analysis. And with this 
issue of removing inner html element white space we are afraid to break all 
existing front end functionalities, like checkout pages, user registration, 
order creations ... 

 

Can you please help on this issue by providing us with a fix or a workaround ?

tomcat.version  : 7.0.82.A.RELEAS

spring.version :  4.3.17.RELEASE7

java.version : 1.8

!image-2020-11-27-14-15-31-718.png|width=584,height=179!

Best Regards


> trimDirectiveWhitespaces does not apply for custom tags in Tomcat provided 
> jasper lib
> -
>
> Key: MTOMCAT-321
> URL: https://issues.apache.org/jira/browse/MTOMCAT-321
> Project: Apache Tomcat Maven Plugin
>  Issue Type: Bug
> Environment: tomcat.version  : 7.0.82.A.RELEASE
> spring.version :  4.3.17.RELEASE
> java.version :  1.8
>Reporter: Hicham Mouloudi
>Priority: Major
> Attachments: image-2020-11-27-14-03-02-603.png, 
> image-2020-11-27-14-08-01-135.png, image-2020-11-27-14-15-31-718.png, 
> image-2020-11-27-14-17-23-102.png
>
>
> Hello,
> We have a Spring based web application project where we have about 350 custom 
> tags under /WEB-INF/tags/. When inspecting the source page html, we can see a 
> lot of generated white spaces between html elements (around 5000 back to 
> lines added). 
> !image-2020-11-27-14-17-23-102.png|width=573,height=386!
> We already have done the configuration in the jsp level as follow 
> {code:java}
> 
>   
> *.jsp 
> 
>  true <
> !-- Remove additional 

[jira] [Updated] (MTOMCAT-321) trimDirectiveWhitespaces does not apply for custom tags in Tomcat provided jasper lib

[Hicham Mouloudi (Jira)]

 [ 
https://issues.apache.org/jira/browse/MTOMCAT-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hicham Mouloudi updated MTOMCAT-321:

Attachment: image-2020-11-27-14-17-23-102.png

> trimDirectiveWhitespaces does not apply for custom tags in Tomcat provided 
> jasper lib
> -
>
> Key: MTOMCAT-321
> URL: https://issues.apache.org/jira/browse/MTOMCAT-321
> Project: Apache Tomcat Maven Plugin
>  Issue Type: Bug
> Environment: tomcat.version  : 7.0.82.A.RELEASE
> spring.version :  4.3.17.RELEASE
> java.version :  1.8
>Reporter: Hicham Mouloudi
>Priority: Major
> Attachments: image-2020-11-27-14-03-02-603.png, 
> image-2020-11-27-14-08-01-135.png, image-2020-11-27-14-15-31-718.png, 
> image-2020-11-27-14-17-23-102.png
>
>
> Hello,
> We have a Spring based web application project where we have about 350 custom 
> tags under /WEB-INF/tags/. When inspecting the source page html, we can see a 
> lot of generated white spaces between html elements (arround 5000 back to 
> lines added). 
> We already have the configuration in the jsp level as follow 
> {code:java}
>   *.jsp  
> true  
> true 
>  
> {code}
> And we also declared the <%@ page trimDirectiveWhitespaces="true" %> inside 
> our jsp  custom pages.
>  
> We want to trim white space in all custom tags, so we need to add <%@ tag 
> trimDirectiveWhitespaces="true" %> we had some blocking issues as this 
> directive on tag level trim inner html element spaces 
> For example a radio button that have checked directive inside will be like 
> 
> !image-2020-11-27-14-08-01-135.png|width=508,height=74!
> You can notice that the checked is concatenated with the field 
> data-track-event.
>  
> We also tried the following configuration
> {code:java}
>  
> *.tag 
> true 
> 
> {code}
> But this is blocked by the JspConfig class.
> !image-2020-11-27-14-03-02-603.png|width=977,height=292!
>  
> So adding <%@ tag trimDirectiveWhitespaces="true" %>  to prevent those 
> generated white space in all our custom tags will have an expected error in 
> our production code, as it will required a lot of test and analysis. And with 
> this issue of removing inner html element white space we are afraid to break 
> all existing front end functionalities, like checkout pages, user 
> registration, order creations ... 
>  
> Can you please help on this issue by providing us with a fix or a workaround ?
> tomcat.version  : 7.0.82.A.RELEAS
> spring.version :  4.3.17.RELEASE7
> java.version : 1.8
> !image-2020-11-27-14-15-31-718.png|width=584,height=179!
> Best Regards



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[jira] [Updated] (MTOMCAT-321) trimDirectiveWhitespaces does not apply for custom tags in Tomcat provided jasper lib

[Hicham Mouloudi (Jira)]

 [ 
https://issues.apache.org/jira/browse/MTOMCAT-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hicham Mouloudi updated MTOMCAT-321:

Environment: 
tomcat.version  : 7.0.82.A.RELEASE

spring.version :  4.3.17.RELEASE

java.version :  1.8



  was:
tomcat.version  : 7.0.82.A.RELEAS

spring.version :  4.3.17.RELEASE7

java.version :  1.8




> trimDirectiveWhitespaces does not apply for custom tags in Tomcat provided 
> jasper lib
> -
>
> Key: MTOMCAT-321
> URL: https://issues.apache.org/jira/browse/MTOMCAT-321
> Project: Apache Tomcat Maven Plugin
>  Issue Type: Bug
> Environment: tomcat.version  : 7.0.82.A.RELEASE
> spring.version :  4.3.17.RELEASE
> java.version :  1.8
>Reporter: Hicham Mouloudi
>Priority: Major
> Attachments: image-2020-11-27-14-03-02-603.png, 
> image-2020-11-27-14-08-01-135.png, image-2020-11-27-14-15-31-718.png
>
>
> Hello,
> We have a Spring based web application project where we have about 350 custom 
> tags under /WEB-INF/tags/. When inspecting the source page html, we can see a 
> lot of generated white spaces between html elements (arround 5000 back to 
> lines added). 
> We already have the configuration in the jsp level as follow 
> {code:java}
>   *.jsp  
> true  
> true 
>  
> {code}
> And we also declared the <%@ page trimDirectiveWhitespaces="true" %> inside 
> our jsp  custom pages.
>  
> We want to trim white space in all custom tags, so we need to add <%@ tag 
> trimDirectiveWhitespaces="true" %> we had some blocking issues as this 
> directive on tag level trim inner html element spaces 
> For example a radio button that have checked directive inside will be like 
> 
> !image-2020-11-27-14-08-01-135.png|width=508,height=74!
> You can notice that the checked is concatenated with the field 
> data-track-event.
>  
> We also tried the following configuration
> {code:java}
>  
> *.tag 
> true 
> 
> {code}
> But this is blocked by the JspConfig class.
> !image-2020-11-27-14-03-02-603.png|width=977,height=292!
>  
> So adding <%@ tag trimDirectiveWhitespaces="true" %>  to prevent those 
> generated white space in all our custom tags will have an expected error in 
> our production code, as it will required a lot of test and analysis. And with 
> this issue of removing inner html element white space we are afraid to break 
> all existing front end functionalities, like checkout pages, user 
> registration, order creations ... 
>  
> Can you please help on this issue by providing us with a fix or a workaround ?
> tomcat.version  : 7.0.82.A.RELEAS
> spring.version :  4.3.17.RELEASE7
> java.version : 1.8
> !image-2020-11-27-14-15-31-718.png|width=584,height=179!
> Best Regards



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[jira] [Created] (MTOMCAT-321) trimDirectiveWhitespaces does not apply for custom tags in Tomcat provided jasper lib

[Hicham Mouloudi (Jira)]

Hicham Mouloudi created MTOMCAT-321:
---

 Summary: trimDirectiveWhitespaces does not apply for custom tags 
in Tomcat provided jasper lib
 Key: MTOMCAT-321
 URL: https://issues.apache.org/jira/browse/MTOMCAT-321
 Project: Apache Tomcat Maven Plugin
  Issue Type: Bug
 Environment: tomcat.version  : 7.0.82.A.RELEAS

spring.version :  4.3.17.RELEASE7

java.version :  1.8


Reporter: Hicham Mouloudi
 Attachments: image-2020-11-27-14-03-02-603.png, 
image-2020-11-27-14-08-01-135.png, image-2020-11-27-14-15-31-718.png

Hello,

We have a Spring based web application project where we have about 350 custom 
tags under /WEB-INF/tags/. When inspecting the source page html, we can see a 
lot of generated white spaces between html elements (arround 5000 back to lines 
added). 

We already have the configuration in the jsp level as follow 
{code:java}
  *.jsp  true 
 
true 
 
{code}
And we also declared the <%@ page trimDirectiveWhitespaces="true" %> inside our 
jsp  custom pages.

 

We want to trim white space in all custom tags, so we need to add <%@ tag 
trimDirectiveWhitespaces="true" %> we had some blocking issues as this 
directive on tag level trim inner html element spaces 

For example a radio button that have checked directive inside will be like 



!image-2020-11-27-14-08-01-135.png|width=508,height=74!

You can notice that the checked is concatenated with the field data-track-event.

 

We also tried the following configuration
{code:java}
 
*.tag 
true 

{code}
But this is blocked by the JspConfig class.

!image-2020-11-27-14-03-02-603.png|width=977,height=292!

 

So adding <%@ tag trimDirectiveWhitespaces="true" %>  to prevent those 
generated white space in all our custom tags will have an expected error in our 
production code, as it will required a lot of test and analysis. And with this 
issue of removing inner html element white space we are afraid to break all 
existing front end functionalities, like checkout pages, user registration, 
order creations ... 

 

Can you please help on this issue by providing us with a fix or a workaround ?

tomcat.version  : 7.0.82.A.RELEAS

spring.version :  4.3.17.RELEASE7

java.version : 1.8

!image-2020-11-27-14-15-31-718.png|width=584,height=179!

Best Regards



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 63943] Add possibility to overwrite remote port with information from header value

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=63943

--- Comment #8 from Mark Thomas  ---
A little research suggests that this is usually included in the X-Forwarded-For
header rather than as a separate header. RFC 7239 uses that format as does
Azure. I haven't found any references to a dedicated header.

Any reason to to address this by adding support for port as well as address in
X-Forwarded-For ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 64938] response.setCharacterEncoding(null) should clear previous charset

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=64938

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #4 from Mark Thomas  ---
The current Javadoc certainly implies null is not valid here but I can see how
allowing it might be useful.

I've opened https://github.com/eclipse-ee4j/servlet-api/issues/377

Switching to NEEDINFO as the way forward will be guided by how the spec project
decides to clarify this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

JDK 16 Early Access build 26 is now available

[Rory O'Donnell]

Hi Mark,

OpenJDK 16 Early Access build 26**is now available at 
http://jdk.java.net/16


 * These early-access , open-source builds are provided under the
 o GNU General Public License, version 2, with the Classpath
   Exception .

 * Schedule: *JDK 16 Rampdown Phase One Starts on 2020/12/10 [1] *

 * Features [1]: Most recent Integrations:
 o Integrated JEP 389: Foreign Linker API (Incubator)
    with this release.
 + JEP 389 introduces an API that offers statically-typed,
   pure-Java access to native code.
 + This API, together with the JEP 383
   , will considerably
   simplify the otherwise error-prone process of binding to a
   native library.

**

 * Release Notes [2]

 * Changes in recent builds that maybe of interest:
 o Build 26
 + JDK-8202343: *Disable TLS 1.0 and 1.1*
 + JDK-8251317:**Support for CLDR version 38**
 + JDK-8212879: Make JVMTI TagMap table concurrent
 + JDK-8236926: Concurrently uncommit memory in G1
 + JDK-8243559: Removed Root Certificates with 1024-bit Keys
 + JDK-8253459: Argument index of zero or unrepresentable by
   int throws IllegalFormatException
 + JDK-8256643: Terminally deprecate ThreadGroup stop, destroy,
   isDestroyed, setDaemon and isDaemon
 o Build 25
 + JDK-8247781: Day period support added to java.time formats
 + JDK-8202471: (ann) Cannot read type annotations on generic
   receiver type's type variables *[**Reported by ByteBuddy]*
 + JDK-8255947: [macos] Signed macOS jpackage app doesn't
   filter spurious '-psn' argument *[**Reported by JOSM]*
 + JDK-8256063: Module::getPackages returns the set of package
   names in this module

 * JDK 16 - topics of interest
 o Inside Java Episode 7 “The Vector API” with John Rose and Paul
   Sandoz
 + https://inside.java/2020/11/17/podcast-007/
   
 o Biased locking Obsoletion update
 + https://inside.java/2020/11/17/biased-locking-obsoletion/
   
 * Project Loom with Ron Pressler
 o https://inside.java/2020/11/24/podcast-008/
 * Update on 64-bit ARM Support for Oracle OpenJDK and Oracle JDK
 o https://inside.java/2020/11/12/arm-support-update/
   

Project Lanai Early-Access: EA 7 Build 16-lanai+3-278 
 (2020/11/17)


 * These early-access builds are provided under the GNU General Public
   License, version 2, with the Classpath Exception
   
 * These EA builds are produced for the purpose of gathering feedback.
   Use for any other purpose is at your own risk.
 * Please send feedback via e-mail to lanai-...@openjdk.java.net
   . To send e-mail to this address
   you must first subscribe to the mailing list
   .

The Java Cryptographic Roadmap has been updated [3]:

 * Distrust TLS 1.0 and TLS 1.1 by default
 o TLS protocol versions 1.0 and 1.1 are no longer considered
   secure and have been superseded by more secure and modern
   versions (TLS 1.2 and 1.3). This change has been integrated with
   JDK 16 Early Access build 26.
 * Upgrade of default algorithms used to encrypt PKCS12 keystores
 o The new algorithms are based on AES-256 and SHA-256 and are
   stronger than the old algorithms which were based on RC2,
   DESede, and SHA-1.This change is already included in JDK 16
   Early Access build 23.

RgdsRory

[1] https://openjdk.java.net/projects/jdk/16/
[2] https://jdk.java.net/16/release-notes
[3] https://www.java.com/en/jre-jdk-cryptoroadmap.html

--
Rgds, Rory O'Donnell
Quality Engineering Manager
Oracle EMEA, Dublin, Ireland

[Bug 64938] response.setCharacterEncoding(null) should clear previous charset

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=64938

--- Comment #3 from Remy Maucherat  ---
According to the javadoc, null is probably not a valid value (it says:
"charset: a String specifying only the character set defined by IANA", so
"null" is obviously not one of these). Unlike other places, it is not specified
to throw an IAE or something like that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 64938] response.setCharacterEncoding(null) should clear previous charset

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=64938

--- Comment #2 from Mark Thomas  ---
The behaviour of other Servlet containers is irrelevant. What matters is the
Sevlet specification.

You could argue that the ServletResponse.setCharacterEncoding Javadoc does not
permit null to be passed as the character set. Neither does it define the
failure mode if an invalid character encoding is specified. This is one of the
many areas where the spec could be better defined.

One workaround may be to define the default character encoding in web.xml with:

UTF-8

rather than via the filter. Although that won't help if some resources require
UTF-8 to be set explicitly.

Another possible workaround is ServletResponse.reset().

The interplay of setLocale(), setContentType() and setChjaracterEncoding()
along with getWriter() and the web.xml default encoding (and probably at least
one other bit I have forgotten) means that this might not be as simple as it
first looks.

I can see the use case for being able to use null here so I'm planning on
looking at this later today with a view to implementing it. I'll also see if we
can get the Javadoc clarified that null undoes any previous call (assuming
getWriter() hasn't been called etc.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 64938] response.setCharacterEncoding(null) should clear previous charset

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=64938

--- Comment #1 from quaff  ---
Jetty is respect this

https://github.com/eclipse/jetty.project/blob/jetty-10.0.x/jetty-server/src/main/java/org/eclipse/jetty/server/Response.java#L1000

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 64938] New: response.setCharacterEncoding(null) should clear previous charset

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=64938

Bug ID: 64938
   Summary: response.setCharacterEncoding(null) should clear
previous charset
   Product: Tomcat 9
   Version: unspecified
  Hardware: PC
OS: Mac OS X 10.4
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
  Assignee: dev@tomcat.apache.org
  Reporter: zhouyanm...@gmail.com
  Target Milestone: -

I have a filter set response charset to UTF-8 globally, one of my servlets want
remove charset encoding from response Content-Type, for example 
response.setCharacterEncoding(null);
response.setContentType("application/wasm");
It still generate invalid "application/wasm;charset=UTF-8" because
"response.setCharacterEncoding(null)" is noop, currently there is no way to
clear previous charset.

https://github.com/apache/tomcat/blob/master/java/org/apache/coyote/Response.java#L502

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org