Re: [tomcat-jakartaee-migration] branch master updated: Make migrate.sh usable from any directory

2020-12-11 Thread Christopher Schultz
Martin, On 12/11/20 15:52, Martin Grigorov wrote: On Fri, Dec 11, 2020, 21:34 Christopher Schultz < ch...@christopherschultz.net> wrote: Rainer, On 12/11/20 14:19, Rainer Jung wrote: Hi Chris, Am 11.12.2020 um 19:53 schrieb Christopher Schultz: Rainer, On 12/11/20 06:19, Rainer Jung

Re: [tomcat-native] branch master updated: Update java code to align with 10.0.x

2020-12-11 Thread Rémy Maucherat
On Fri, Dec 11, 2020 at 5:50 PM Mark Thomas wrote: > On 11/12/2020 16:41, Rémy Maucherat wrote: > > On Fri, Dec 11, 2020 at 5:36 PM Mark Thomas wrote: > > > >> On 11/12/2020 16:24, Michael Osipov wrote: > >>> Am 2020-12-10 um 15:07 schrieb ma...@apache.org: > + * @deprecated The scope of

Re: [tomcat-jakartaee-migration] branch master updated: Make migrate.sh usable from any directory

2020-12-11 Thread Martin Grigorov
On Fri, Dec 11, 2020, 21:34 Christopher Schultz < ch...@christopherschultz.net> wrote: > Rainer, > > On 12/11/20 14:19, Rainer Jung wrote: > > Hi Chris, > > > > Am 11.12.2020 um 19:53 schrieb Christopher Schultz: > >> Rainer, > >> > >> On 12/11/20 06:19, Rainer Jung wrote: > >>> Am 11.12.2020 um

Re: [tomcat-jakartaee-migration] branch master updated: Make migrate.sh usable from any directory

2020-12-11 Thread Christopher Schultz
Rainer, On 12/11/20 14:19, Rainer Jung wrote: Hi Chris, Am 11.12.2020 um 19:53 schrieb Christopher Schultz: Rainer, On 12/11/20 06:19, Rainer Jung wrote: Am 11.12.2020 um 09:49 schrieb Martin Grigorov: On Fri, Dec 11, 2020 at 10:41 AM Martin Grigorov wrote: Hi Rainer, On Fri, Dec 11,

Re: [tomcat-jakartaee-migration] branch master updated: Make migrate.sh usable from any directory

2020-12-11 Thread Rainer Jung
Hi Chris, Am 11.12.2020 um 19:53 schrieb Christopher Schultz: Rainer, On 12/11/20 06:19, Rainer Jung wrote: Am 11.12.2020 um 09:49 schrieb Martin Grigorov: On Fri, Dec 11, 2020 at 10:41 AM Martin Grigorov wrote: Hi Rainer, On Fri, Dec 11, 2020 at 10:37 AM Rainer Jung wrote: Am

Re: [tomcat-jakartaee-migration] branch master updated: Make migrate.sh usable from any directory

2020-12-11 Thread Christopher Schultz
Rainer, On 12/11/20 06:19, Rainer Jung wrote: Am 11.12.2020 um 09:49 schrieb Martin Grigorov: On Fri, Dec 11, 2020 at 10:41 AM Martin Grigorov wrote: Hi Rainer, On Fri, Dec 11, 2020 at 10:37 AM Rainer Jung wrote: Am 11.12.2020 um 08:25 schrieb mgrigo...@apache.org: This is an automated

Re: [tomcat-jakartaee-migration] branch master updated: Make migrate.sh usable from any directory

2020-12-11 Thread Christopher Schultz
Martin, On 12/11/20 04:02, Martin Grigorov wrote: On Fri, Dec 11, 2020 at 10:53 AM Mark Thomas wrote: On 11/12/2020 08:49, Martin Grigorov wrote: On Fri, Dec 11, 2020 at 10:41 AM Martin Grigorov wrote: On Fri, Dec 11, 2020 at 10:37 AM Rainer Jung Maybe one could cd `dirname $0`

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE

2020-12-11 Thread Christopher Schultz
Mark, On 12/10/20 11:14, Mark Thomas wrote: [snip] > Doing conversion on the fly or at deployment/start-up time raises various issues that boil down to "How do we detect if conversion is required?" and "What are the performance impacts of doing so?". There are users who want to squeeze every

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE

2020-12-11 Thread Christopher Schultz
Mark, On 12/10/20 11:14, Mark Thomas wrote: On 10/12/2020 14:52, Romain Manni-Bucau wrote: Le jeu. 10 déc. 2020 à 15:49, Rémy Maucherat a écrit : On Thu, Dec 10, 2020 at 3:13 PM Mark Thomas wrote: On 10/12/2020 13:58, Christopher Schultz wrote: Since this is a developer tool and not a

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE

2020-12-11 Thread Christopher Schultz
Mark, On 12/10/20 09:13, Mark Thomas wrote: On 10/12/2020 13:58, Christopher Schultz wrote: Mark, On 12/10/20 06:39, Mark Thomas wrote: The proposed Apache Tomcat migration tool for Jakarta EE 0.1.0 is now available for voting. This is (potentially) the first release. It can be obtained

[GitHub] [tomcat] michael-o commented on pull request #382: Add support for unix domain sockets.

2020-12-11 Thread GitBox
michael-o commented on pull request #382: URL: https://github.com/apache/tomcat/pull/382#issuecomment-743337472 @minfrin Could you kindly add a test case for this? I would like to finalize this and checkout @martin-g's comments.

[Bug 64830] HTTP2 : GOAWAY sent with Protocol Error and Frame Size Error

2020-12-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64830 --- Comment #20 from Mark Thomas --- Looks like there is still an issue related to the HPACK decoder. I can see a debug log where the decoder reports a content-length that is not consistent with the value shown in the Wireshark trace. Still

Re: Objection to the deprecation of the tomcat-native/APR connector

2020-12-11 Thread Michael Osipov
Am 2020-12-09 um 14:36 schrieb Graham Leggett: On 01 Dec 2020, at 14:09, Mark Thomas wrote: I also object to the removal of OpenSSL code, for the same reason. It isn't being removed. The APR/Native library will be retained along with OpenSSL support for the NIO and NIO2. I expect the scope

Re: Objection to the deprecation of the tomcat-native/APR connector

2020-12-11 Thread Michael Osipov
Am 2020-12-06 um 11:03 schrieb Mark Thomas: On 05/12/2020 11:38, Michael Osipov wrote: A suitable roadmap for libtcnative would be: * Tag current patch version * Move to 1.3.0 and remove everything non-TLS/networking related out * Move to 1.4.0 drop OpenSSL support for < 1.1.1 because it

Re: [tomcat-native] branch master updated: Update java code to align with 10.0.x

2020-12-11 Thread Mark Thomas
On 11/12/2020 16:41, Rémy Maucherat wrote: > On Fri, Dec 11, 2020 at 5:36 PM Mark Thomas wrote: > >> On 11/12/2020 16:24, Michael Osipov wrote: >>> Am 2020-12-10 um 15:07 schrieb ma...@apache.org: + * @deprecated The scope of the APR/Native Library will be reduced in Tomcat + *

Re: [tomcat-native] branch master updated: Update java code to align with 10.0.x

2020-12-11 Thread Michael Osipov
Am 2020-12-11 um 17:41 schrieb Rémy Maucherat: On Fri, Dec 11, 2020 at 5:36 PM Mark Thomas wrote: On 11/12/2020 16:24, Michael Osipov wrote: Am 2020-12-10 um 15:07 schrieb ma...@apache.org: + * @deprecated The scope of the APR/Native Library will be reduced in Tomcat + *

Re: [tomcat-native] branch master updated: Update java code to align with 10.0.x

2020-12-11 Thread Michael Osipov
Am 2020-12-11 um 17:36 schrieb Mark Thomas: On 11/12/2020 16:24, Michael Osipov wrote: Am 2020-12-10 um 15:07 schrieb ma...@apache.org: ... You won't going to continue the APRLifecycleListener, will you? There will almost certainly need to be something like it. I had imagined it would get a

Re: [tomcat-native] branch master updated: Update java code to align with 10.0.x

2020-12-11 Thread Rémy Maucherat
On Fri, Dec 11, 2020 at 5:36 PM Mark Thomas wrote: > On 11/12/2020 16:24, Michael Osipov wrote: > > Am 2020-12-10 um 15:07 schrieb ma...@apache.org: > >> + * @deprecated The scope of the APR/Native Library will be reduced > >> in Tomcat > >> + * 10.1.x / Tomcat Native 2.x onwards

Re: [tomcat-native] branch master updated: Update java code to align with 10.0.x

2020-12-11 Thread Mark Thomas
On 11/12/2020 16:24, Michael Osipov wrote: > Am 2020-12-10 um 15:07 schrieb ma...@apache.org: >> + * @deprecated  The scope of the APR/Native Library will be reduced >> in Tomcat >> + *  10.1.x / Tomcat Native 2.x onwards to only include those >> + *  components required to

Re: [VOTE][RESULT] Release Apache Tomcat 10.0.0

2020-12-11 Thread Michael Osipov
Am 2020-12-08 um 18:17 schrieb Mark Thomas: The following votes were case: Binding: +1 (beta): remm, isapir, mturk, mgrigorov, ebourg, markt No other votes were cast. The vote therefore passes. Thanks to everyone who contributed to this release. So, from the subject people get the

Re: [VOTE] Release Apache Tomcat 10.0.0

2020-12-11 Thread Michael Osipov
Am 2020-12-06 um 10:44 schrieb Mark Thomas: On 05/12/2020 12:59, Michael Osipov wrote: Am 2020-12-03 um 11:43 schrieb Mark Thomas: The proposed Apache Tomcat 10.0.0 release is now available for voting. Apache Tomcat 10.x implements Jakarta EE 9 and, as such, the primary package for all the

Re: [tomcat-native] branch master updated: Update java code to align with 10.0.x

2020-12-11 Thread Michael Osipov
Am 2020-12-10 um 15:07 schrieb ma...@apache.org: + * @deprecated The scope of the APR/Native Library will be reduced in Tomcat + * 10.1.x / Tomcat Native 2.x onwards to only include those + * components required to provide OpenSSL integration with the NIO + *

[tomcat] branch 8.5.x updated: Fix BZ 64974 - non-blocking I/O + pipelining could drop requests

2020-12-11 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new ee14812 Fix BZ 64974 - non-blocking I/O +

[tomcat] branch 9.0.x updated: Fix BZ 64974 - non-blocking I/O + pipelining could drop requests

2020-12-11 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new f950a96 Fix BZ 64974 - non-blocking I/O +

[tomcat] branch master updated: Fix BZ 64974 - non-blocking I/O + pipelining could drop requests

2020-12-11 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new a5b3b07 Fix BZ 64974 - non-blocking I/O +

[Bug 64974] Tomcat losing HTTP pipeline requests if asking for available bytes

2020-12-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64974 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [tomcat-native] branch master updated: Add more information around minimum versions

2020-12-11 Thread Michael Osipov
Am 2020-12-10 um 13:21 schrieb ma...@apache.org: This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-native.git The following commit(s) were added to refs/heads/master by this push:

[Bug 64974] Tomcat losing HTTP pipeline requests if asking for available bytes

2020-12-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64974 --- Comment #6 from Mark Thomas --- Both isFinished() and available() appear to have problems differentiating between current request data and pipelined request data. I thought I had a trivial fix but it is breaking other tests. Still working

[Bug 64974] Tomcat losing HTTP pipeline requests if asking for available bytes

2020-12-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64974 --- Comment #5 from Remy Maucherat --- (In reply to Mark Thomas from comment #4) > I have a test case that replicates this now and some ideas for a potential > fix. > > Combining async and pipelining does seem an odd thing to do but I don't

[tomcat-native] branch master updated: Switch maven repo URL from http to https.

2020-12-11 Thread rjung
This is an automated email from the ASF dual-hosted git repository. rjung pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-native.git The following commit(s) were added to refs/heads/master by this push: new e348c0e Switch maven repo URL from http

Re: [VOTE] Release Apache Tomcat Native 1.2.26

2020-12-11 Thread Martin Grigorov
On Thu, Dec 10, 2020 at 11:10 PM Mark Thomas wrote: > Version 1.2.26 includes the following changes compared to 1.2.25 > > - Windows binaries built using 1.1.1i > > - BZ 64942 - expose support for unix domain sockets > > Various other fixes and improvements. See the changelog for details. > >

[Bug 64974] Tomcat losing HTTP pipeline requests if asking for available bytes

2020-12-11 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=64974 --- Comment #4 from Mark Thomas --- I have a test case that replicates this now and some ideas for a potential fix. Combining async and pipelining does seem an odd thing to do but I don't see any spec language that would prevent it. -- You

[GitHub] [tomcat] martin-g commented on pull request #382: Add support for unix domain sockets.

2020-12-11 Thread GitBox
martin-g commented on pull request #382: URL: https://github.com/apache/tomcat/pull/382#issuecomment-743173688 Here are the results for load testing APR protocol over TCP, both Tomcat and Vegeta running on the same machine: ``` echo "GET http://localhost:8080/testbed/plaintext; |

Re: [VOTE] Release Apache Tomcat Native 1.2.26

2020-12-11 Thread Rainer Jung
Am 10.12.2020 um 22:10 schrieb Mark Thomas: Version 1.2.26 includes the following changes compared to 1.2.25 - Windows binaries built using 1.1.1i - BZ 64942 - expose support for unix domain sockets Various other fixes and improvements. See the changelog for details. The proposed release

[GitHub] [tomcat] martin-g commented on pull request #382: Add support for unix domain sockets.

2020-12-11 Thread GitBox
martin-g commented on pull request #382: URL: https://github.com/apache/tomcat/pull/382#issuecomment-743166815 Load tested it with Vegeta: ``` $ echo "GET http://localhost/testbed/plaintext; | vegeta attack -unix-socket /tmp/tomcat-uds.sock -rate 0 -max-workers 128 -duration 30s

[GitHub] [tomcat] martin-g commented on pull request #382: Add support for unix domain sockets.

2020-12-11 Thread GitBox
martin-g commented on pull request #382: URL: https://github.com/apache/tomcat/pull/382#issuecomment-743160059 In my test application TLS is configured but it is not used/needed by UDS so HTTP2 does not work: ``` $ curl --http2 --unix-socket /tmp/tomcat-uds.sock

[GitHub] [tomcat] martin-g commented on pull request #382: Add support for unix domain sockets.

2020-12-11 Thread GitBox
martin-g commented on pull request #382: URL: https://github.com/apache/tomcat/pull/382#issuecomment-743155616 There is some issue with stopping an embedded Tomcat: ``` === Started ^CDec 11, 2020 11:59:45 AM org.apache.coyote.AbstractProtocol pause INFO: Pausing

[GitHub] [tomcat] martin-g commented on a change in pull request #382: Add support for unix domain sockets.

2020-12-11 Thread GitBox
martin-g commented on a change in pull request #382: URL: https://github.com/apache/tomcat/pull/382#discussion_r540897626 ## File path: webapps/docs/config/http.xml ## @@ -208,6 +208,24 @@ The default is POST + Review comment: I've just tested it. It

Re: [tomcat-jakartaee-migration] branch master updated: Make migrate.sh usable from any directory

2020-12-11 Thread Martin Grigorov
On Fri, Dec 11, 2020 at 1:20 PM Rainer Jung wrote: > Am 11.12.2020 um 09:49 schrieb Martin Grigorov: > > On Fri, Dec 11, 2020 at 10:41 AM Martin Grigorov > > wrote: > > > >> Hi Rainer, > >> > >> On Fri, Dec 11, 2020 at 10:37 AM Rainer Jung > >> wrote: > >> > >>> Am 11.12.2020 um 08:25 schrieb

[tomcat-jakartaee-migration] branch master updated: Re-work how the bin folder path is calculated

2020-12-11 Thread mgrigorov
This is an automated email from the ASF dual-hosted git repository. mgrigorov pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git The following commit(s) were added to refs/heads/master by this push: new e8e3318 Re-work how the

[GitHub] [tomcat] michael-o commented on a change in pull request #382: Add support for unix domain sockets.

2020-12-11 Thread GitBox
michael-o commented on a change in pull request #382: URL: https://github.com/apache/tomcat/pull/382#discussion_r540877133 ## File path: webapps/docs/config/http.xml ## @@ -208,6 +208,24 @@ The default is POST + Review comment: Having both enabled

[GitHub] [tomcat] michael-o commented on a change in pull request #382: Add support for unix domain sockets.

2020-12-11 Thread GitBox
michael-o commented on a change in pull request #382: URL: https://github.com/apache/tomcat/pull/382#discussion_r540877133 ## File path: webapps/docs/config/http.xml ## @@ -208,6 +208,24 @@ The default is POST + Review comment: Having both enabled

Re: [tomcat-jakartaee-migration] branch master updated: Make migrate.sh usable from any directory

2020-12-11 Thread Rainer Jung
Am 11.12.2020 um 09:49 schrieb Martin Grigorov: On Fri, Dec 11, 2020 at 10:41 AM Martin Grigorov wrote: Hi Rainer, On Fri, Dec 11, 2020 at 10:37 AM Rainer Jung wrote: Am 11.12.2020 um 08:25 schrieb mgrigo...@apache.org: This is an automated email from the ASF dual-hosted git repository.

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE

2020-12-11 Thread Romain Manni-Bucau
Le ven. 11 déc. 2020 à 10:59, Rémy Maucherat a écrit : > On Thu, Dec 10, 2020 at 5:14 PM Mark Thomas wrote: > > > On 10/12/2020 14:52, Romain Manni-Bucau wrote: > > > Le jeu. 10 déc. 2020 à 15:49, Rémy Maucherat a > écrit : > > >> On Thu, Dec 10, 2020 at 3:13 PM Mark Thomas wrote: > > >>> On

Re: [VOTE] Apache Tomcat migration tool for Jakarta EE

2020-12-11 Thread Rémy Maucherat
On Thu, Dec 10, 2020 at 5:14 PM Mark Thomas wrote: > On 10/12/2020 14:52, Romain Manni-Bucau wrote: > > Le jeu. 10 déc. 2020 à 15:49, Rémy Maucherat a écrit : > >> On Thu, Dec 10, 2020 at 3:13 PM Mark Thomas wrote: > >>> On 10/12/2020 13:58, Christopher Schultz wrote: > > > > Since this

Re: [tomcat-jakartaee-migration] branch master updated: Make migrate.sh usable from any directory

2020-12-11 Thread Martin Grigorov
On Fri, Dec 11, 2020 at 10:53 AM Mark Thomas wrote: > On 11/12/2020 08:49, Martin Grigorov wrote: > > On Fri, Dec 11, 2020 at 10:41 AM Martin Grigorov > > wrote: > >> On Fri, Dec 11, 2020 at 10:37 AM Rainer Jung > > > > >>> Maybe one could > >>> > >>>cd `dirname $0` > >>> > >> > > Two

Re: [tomcat-jakartaee-migration] branch master updated: Make migrate.sh usable from any directory

2020-12-11 Thread Mark Thomas
On 11/12/2020 08:49, Martin Grigorov wrote: > On Fri, Dec 11, 2020 at 10:41 AM Martin Grigorov > wrote: >> On Fri, Dec 11, 2020 at 10:37 AM Rainer Jung >>> Maybe one could >>> >>>cd `dirname $0` >>> >> > Two issues with this: > > 1) the script usage is: ./bin/migrate.sh input.war

Re: [tomcat-jakartaee-migration] branch master updated: Make migrate.sh usable from any directory

2020-12-11 Thread Martin Grigorov
On Fri, Dec 11, 2020 at 10:41 AM Martin Grigorov wrote: > Hi Rainer, > > On Fri, Dec 11, 2020 at 10:37 AM Rainer Jung > wrote: > >> Am 11.12.2020 um 08:25 schrieb mgrigo...@apache.org: >> > This is an automated email from the ASF dual-hosted git repository. >> > >> > mgrigorov pushed a commit

Re: [tomcat-jakartaee-migration] branch master updated: Make migrate.sh usable from any directory

2020-12-11 Thread Martin Grigorov
Hi Rainer, On Fri, Dec 11, 2020 at 10:37 AM Rainer Jung wrote: > Am 11.12.2020 um 08:25 schrieb mgrigo...@apache.org: > > This is an automated email from the ASF dual-hosted git repository. > > > > mgrigorov pushed a commit to branch master > > in repository >

Re: [tomcat-jakartaee-migration] branch master updated: Make migrate.sh usable from any directory

2020-12-11 Thread Rainer Jung
Am 11.12.2020 um 08:25 schrieb mgrigo...@apache.org: This is an automated email from the ASF dual-hosted git repository. mgrigorov pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git The following commit(s) were added to

Re: [VOTE] Release Apache Tomcat Native 1.2.26

2020-12-11 Thread Mark Thomas
On 10/12/2020 21:10, Mark Thomas wrote: > Version 1.2.26 includes the following changes compared to 1.2.25 > > - Windows binaries built using 1.1.1i > > - BZ 64942 - expose support for unix domain sockets > > Various other fixes and improvements. See the changelog for details. > > The proposed