Re: Replacement for Windows service wrapper (procrun)

2020-12-18 Thread calder
On Fri, Dec 18, 2020, 17:16 Christopher Schultz < ch...@christopherschultz.net> wrote: > Mladen, > > > I'd love to get some feedback from folks > > that are using Apache Tomcat on Windows platform. > > I don't generally use Windows, so I don't have a horse in this race, but > I'm curious as to

[Bug 65007] Misleading instructions on import an SSL certificate

2020-12-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65007 --- Comment #4 from Yuval Levin --- I don't know, it was the first time ever for me. I got from GoDaddy one CA (bundle) and our trusted cert (alias=tomcat). the only way I could do it was to add the -trustcacerts to the import of our trusted

Re: Replacement for Windows service wrapper (procrun)

2020-12-18 Thread Christopher Schultz
Mladen, On 12/18/20 15:10, Mladen Turk wrote: We use Procrun from Apache Commons Daemon project as a service wrapper for Apache Tomcat for quite some time. There are many problems with that package. I have created a project named SvcBatch https://github.com/mturk/svcbatch It can be used for

[Bug 65007] Misleading instructions on import an SSL certificate

2020-12-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65007 --- Comment #3 from Christopher Schultz --- (In reply to Yuval Levin from comment #2) > Maybe I had to specify, but this is in the part that explains how to import > a CA Authority cert. Good point. Note that -trustcacerts should only be

[Bug 65007] Misleading instructions on import an SSL certificate

2020-12-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65007 --- Comment #2 from Yuval Levin --- Maybe I had to specify, but this is in the part that explains how to import a CA Authority cert. BTW the documentation of 8.0 has the same explanation. -- You are receiving this mail because: You are the

[Bug 65007] Misleading instructions on import an SSL certificate

2020-12-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65007 --- Comment #1 from Christopher Schultz --- Perhaps the HOWTO could explain the difference between using -trustcacerts and not using -trustcacerts, but it's not true that the existing instructions "do not work" and that adding -trustcacerts

[GitHub] [tomcat] ChristopherSchultz edited a comment on pull request #395: Replace C-style array declaring with Java-style array declaring

2020-12-18 Thread GitBox
ChristopherSchultz edited a comment on pull request #395: URL: https://github.com/apache/tomcat/pull/395#issuecomment-748337399 Yes, please use Java-style array declaration syntax in new code. If you edit existing code which includes C-style array syntax (e.g. `char foo[]`), please update

[GitHub] [tomcat] ChristopherSchultz commented on pull request #395: Replace C-style array declaring with Java-style array declaring

2020-12-18 Thread GitBox
ChristopherSchultz commented on pull request #395: URL: https://github.com/apache/tomcat/pull/395#issuecomment-748337399 Yes, please use Java-style array declaration syntax in new code. This is an automated message from the

[Bug 65007] Misleading instructions on import an SSL certificate

2020-12-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65007 Yuval Levin changed: What|Removed |Added URL||http://tomcat.apache.org/to

[Bug 65007] New: Misleading instructions on import an SSL certificate

2020-12-18 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65007 Bug ID: 65007 Summary: Misleading instructions on import an SSL certificate Product: Tomcat 8 Version: 8.5.x-trunk Hardware: PC OS: Linux Status: NEW

Replacement for Windows service wrapper (procrun)

2020-12-18 Thread Mladen Turk
Hi We use Procrun from Apache Commons Daemon project as a service wrapper for Apache Tomcat for quite some time. There are many problems with that package. I have created a project named SvcBatch https://github.com/mturk/svcbatch It can be used for various deployments. Apache Tomcat can use

[GitHub] [tomcat] zzk0 commented on pull request #395: Replace C-style array declaring with Java-style array declaring

2020-12-18 Thread GitBox
zzk0 commented on pull request #395: URL: https://github.com/apache/tomcat/pull/395#issuecomment-748166928 > There are many of those. A quick search shows around 400 occurrences of the C-style. > I am not sure this is worth it. It will make backporting very hard. What if we write

Re: Compat versions

2020-12-18 Thread Rémy Maucherat
On Fri, Dec 18, 2020 at 2:56 PM Romain Manni-Bucau wrote: > Hmm, a few thoughts on this topic: > > 1. there is no reason to use reflection in jrecompat (all the java > build > time version) impl can be generated in ant build using asm or bcel > 2. all JreCompat are kind of hardcoded SPI, if this

Re: Compat versions

2020-12-18 Thread Romain Manni-Bucau
Hmm, a few thoughts on this topic: 1. there is no reason to use reflection in jrecompat (all the java > build time version) impl can be generated in ant build using asm or bcel 2. all JreCompat are kind of hardcoded SPI, if this API gets a "ordinal" - priority - and a "matches(int javaMajor)"

Re: Compat versions

2020-12-18 Thread Christopher Schultz
Rémy, On 12/18/20 08:20, Rémy Maucherat wrote: On Fri, Dec 18, 2020 at 12:19 PM Martin Grigorov wrote: On Fri, Dec 18, 2020 at 11:12 AM Rémy Maucherat wrote: Hi, I'd like to refactor the compat classes to align with the LTS versions: - Move Jre9Compat to Jre11Compat - I'll probably

Re: Compat versions

2020-12-18 Thread Rémy Maucherat
On Fri, Dec 18, 2020 at 12:19 PM Martin Grigorov wrote: > On Fri, Dec 18, 2020 at 11:12 AM Rémy Maucherat wrote: > > > Hi, > > > > I'd like to refactor the compat classes to align with the LTS versions: > > - Move Jre9Compat to Jre11Compat > > - I'll probably refactor out GraalCompat > > - For

Re: Compat versions

2020-12-18 Thread Martin Grigorov
On Fri, Dec 18, 2020 at 11:12 AM Rémy Maucherat wrote: > Hi, > > I'd like to refactor the compat classes to align with the LTS versions: > - Move Jre9Compat to Jre11Compat > - I'll probably refactor out GraalCompat > - For the upcoming Java 12+ features, they will all go to a new Jre17Compat >

Compat versions

2020-12-18 Thread Rémy Maucherat
Hi, I'd like to refactor the compat classes to align with the LTS versions: - Move Jre9Compat to Jre11Compat - I'll probably refactor out GraalCompat - For the upcoming Java 12+ features, they will all go to a new Jre17Compat class, which will actually be useable in the meantime by the latest