buildbot success in on tomcat-trunk

2020-12-30 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-trunk/builds/5611 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchScheduler

[GitHub] [tomcat] arjantijms commented on pull request #399: Add getRequest method to RequestFacade, to get the wrapped Request

2020-12-30 Thread GitBox
arjantijms commented on pull request #399: URL: https://github.com/apache/tomcat/pull/399#issuecomment-752685025 Yet another example, Weld is using similar tricks to integrate with Tomcat: https://github.com/weld/core/blob/master/environments/servlet/core/src/main/java/org/jboss/weld

[tomcat] branch 9.0.x updated: Fix javadoc after changes

2020-12-30 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 8c54d97 Fix javadoc after changes 8c54d97 is descri

[tomcat] branch master updated: Fix javadoc after changes

2020-12-30 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 0974ffc Fix javadoc after changes 0974ffc is desc

[GitHub] [tomcat] arjantijms commented on pull request #399: Add getRequest method to RequestFacade, to get the wrapped Request

2020-12-30 Thread GitBox
arjantijms commented on pull request #399: URL: https://github.com/apache/tomcat/pull/399#issuecomment-752499693 > I would be against exposing container internals via the Servlet API as it undermines portability. Well, actually it could be used by integration libraries to improve po

[GitHub] [tomcat] rmaucher commented on pull request #399: Add getRequest method to RequestFacade, to get the wrapped Request

2020-12-30 Thread GitBox
rmaucher commented on pull request #399: URL: https://github.com/apache/tomcat/pull/399#issuecomment-752472614 @markt-asf If you really want to encourage this, there is the privileged flag on the Context that allows using container servlets. public Request getRequest() { i

[GitHub] [tomcat] rmannibucau commented on pull request #399: Add getRequest method to RequestFacade, to get the wrapped Request

2020-12-30 Thread GitBox
rmannibucau commented on pull request #399: URL: https://github.com/apache/tomcat/pull/399#issuecomment-752446136 @markt-asf requests notes. How adding RequestFacade implements HttpServletRequest, Unwrappable is less secure than current impl? if it helps I guess you can use the security ma

[GitHub] [tomcat] markt-asf commented on pull request #399: Add getRequest method to RequestFacade, to get the wrapped Request

2020-12-30 Thread GitBox
markt-asf commented on pull request #399: URL: https://github.com/apache/tomcat/pull/399#issuecomment-752437120 I would be against exposing container internals via the Servlet API as it undermines portability. What information, specifically, do you need to access and how (read, write

[tomcat-jakartaee-migration] 01/02: Convert the javax.security.enterprise package with the EE profile (Java EE Security API)

2020-12-30 Thread ebourg
This is an automated email from the ASF dual-hosted git repository. ebourg pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git commit 77967f9db1a2490441c514177715126f1b7c4aa3 Author: Emmanuel Bourg AuthorDate: Wed Dec 30 11:21:57 2020

[tomcat-jakartaee-migration] 02/02: Mention the Debian/Ubuntu package

2020-12-30 Thread ebourg
This is an automated email from the ASF dual-hosted git repository. ebourg pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git commit d35a3853ae1af3282c4c19ba3050edfd94c70889 Author: Emmanuel Bourg AuthorDate: Wed Dec 30 11:15:26 2020

[tomcat-jakartaee-migration] branch master updated (c7884a4 -> d35a385)

2020-12-30 Thread ebourg
This is an automated email from the ASF dual-hosted git repository. ebourg pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git. from c7884a4 Convert the javax.xml.registry package with the EE profile (Java API for XML Registrie

[tomcat-jakartaee-migration] 06/06: Convert the javax.xml.registry package with the EE profile (Java API for XML Registries)

2020-12-30 Thread ebourg
This is an automated email from the ASF dual-hosted git repository. ebourg pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git commit c7884a42cbf31ec986e4e2261822580aa465be0a Author: Emmanuel Bourg AuthorDate: Wed Dec 30 10:52:26 2020

[tomcat-jakartaee-migration] 03/06: Convert the javax.batch package with the EE profile (Java EE Batch Processing API)

2020-12-30 Thread ebourg
This is an automated email from the ASF dual-hosted git repository. ebourg pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git commit 8a0a171135e6b4c193d495e3d4332c0477baebcd Author: Emmanuel Bourg AuthorDate: Wed Dec 30 10:30:37 2020

[tomcat-jakartaee-migration] 01/06: Convert the javax.resource package with the EE profile (Java EE Connector API)

2020-12-30 Thread ebourg
This is an automated email from the ASF dual-hosted git repository. ebourg pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git commit be600249852b4f38f01dad91e11edb7f5e0e6467 Author: Emmanuel Bourg AuthorDate: Wed Dec 30 10:16:53 2020

[tomcat-jakartaee-migration] 05/06: Convert the javax.security.jacc package with the EE profile (Java Authorization Contract for Containers API)

2020-12-30 Thread ebourg
This is an automated email from the ASF dual-hosted git repository. ebourg pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git commit e4460ba8d9240bb6de57921e25f80a9cf96cee83 Author: Emmanuel Bourg AuthorDate: Wed Dec 30 10:46:11 2020

[tomcat-jakartaee-migration] 04/06: Convert the javax.faces package with the EE profile (Java Server Faces)

2020-12-30 Thread ebourg
This is an automated email from the ASF dual-hosted git repository. ebourg pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git commit 3fbd31178f8654511495a5d53032ffe9d83bd928 Author: Emmanuel Bourg AuthorDate: Wed Dec 30 10:37:31 2020

[tomcat-jakartaee-migration] 02/06: Convert the javax.jws package with the EE profile (Java EE Web Services Metadata API)

2020-12-30 Thread ebourg
This is an automated email from the ASF dual-hosted git repository. ebourg pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git commit fc3009fe73ae79cc6099693489152786c5e80ccd Author: Emmanuel Bourg AuthorDate: Wed Dec 30 10:21:48 2020

[tomcat-jakartaee-migration] branch master updated (78287b2 -> c7884a4)

2020-12-30 Thread ebourg
This is an automated email from the ASF dual-hosted git repository. ebourg pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git. from 78287b2 Merge pull request #7 from alitokmen/master new be60024 Convert the javax.resourc

[GitHub] [tomcat-jakartaee-migration] ebourg commented on pull request #7: Convert the javax.jms package with the EE profile (Fixes #6). The previous fix c094325 targeted javax.jmx - Which is NOT touc

2020-12-30 Thread GitBox
ebourg commented on pull request #7: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/7#issuecomment-752381653 Good catch, thank you. I need more sleep. This is an automated message from the Apache Git Service.

[GitHub] [tomcat] rmannibucau commented on pull request #399: Add getRequest method to RequestFacade, to get the wrapped Request

2020-12-30 Thread GitBox
rmannibucau commented on pull request #399: URL: https://github.com/apache/tomcat/pull/399#issuecomment-752367689 @rmaucher it is not about letting a webapp use internal and by default I agree it should stick to the spec API, but it is common to need to go further, in particular when combi