[GitHub] [tomcat-taglibs-standard] olka opened a new pull request #1: Reduce excessive memory allocations in parseNumber and formatNumber tags
olka opened a new pull request #1: URL: https://github.com/apache/tomcat-taglibs-standard/pull/1 During profiling it appeared that _formatNumber_ tag causes huge memory pressure which overwhelms GC resulting in overall application slowness.  |.| Before | After | |---| --- |--- | | RPS | 578.0/s | 707.7/s | | Avg Latency | 692 ms | 561 ms | This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.63
On 31/01/2021 05:51, Igal Sapir wrote: > I ran the unit tests twice on Ubuntu 20.04 with Java 11.0.9.1 and got > failures on both runs in the following tests > >[concat] Testsuites with failed tests: >[concat] > TEST-org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.*.txt >[concat] > TEST-org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.*.txt >[concat] > TEST-org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.*.txt >[concat] > TEST-org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.*.txt > > Are they related to recent changes? I don't think so. I don't think the tribes code has changed much (or at all) in the last couple of releases. A number of the tribes tests have been unreliable historically. I spent some time trying to improve things a little while back. I made some progress but I do still see some failures from time to time. Taking another look is on the TODO list. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.63
On 31/01/2021 05:51, Igal Sapir wrote: > I ran the unit tests twice on Ubuntu 20.04 with Java 11.0.9.1 and got > failures on both runs in the following tests > >[concat] Testsuites with failed tests: >[concat] > TEST-org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.*.txt >[concat] > TEST-org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.*.txt >[concat] > TEST-org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.*.txt >[concat] > TEST-org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.*.txt > > Are they related to recent changes? I don't think so. I don't think the tribes code has changed much (or at all) in the last couple of releases. A number of the tribes tests have been unreliable historically. I spent some time trying to improve things a little while back. I made some progress but I do still see some failures from time to time. Taking another look is on the TODO list. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
