[GitHub] [tomcat] efge commented on pull request #406: Improve the SSLValve so it is able to handle the ssl_client_escaped_cert header from Nginx

2021-03-22 Thread GitBox
efge commented on pull request #406: URL: https://github.com/apache/tomcat/pull/406#issuecomment-804437149 (force-pushed to rebase) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [tomcat] branch master updated: Avoid reflection use for classloader configuration

2021-03-22 Thread Mark Thomas
On 22/03/2021 11:53, r...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new

[tomcat] branch 8.5.x updated: Remove unused code/strings

2021-03-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new f604e26 Remove unused code/strings f604e26 is

[tomcat] branch 9.0.x updated: Remove unused strings

2021-03-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 014b101 Remove unused strings 014b101 is

[tomcat] branch master updated: Remove unused strings

2021-03-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 22a4b3d Remove unused strings 22a4b3d is

[tomcat] 05/05: Fix checkstyle nag

2021-03-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit d2f09175449fa1c6b5e8eca5447fccc476de3fc2 Author: Mark Thomas AuthorDate: Mon Mar 22 22:05:02 2021 + Fix

[tomcat] 02/05: Refactor setReadListener() in preparation for fix for BZ 64771

2021-03-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 1ec5a88aaa49b0cd13ac0ab10cc303e36d8a0369 Author: Mark Thomas AuthorDate: Mon Mar 22 21:45:21 2021 + Refactor

[tomcat] 01/05: Refactor isReady() in preparation for fix of BZ 64771

2021-03-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 110a6a86b3890e58501bbc74f994b20300309c1b Author: Mark Thomas AuthorDate: Mon Mar 22 21:43:27 2021 + Refactor

[tomcat] 04/05: Fix BZ 64771. Support calls to SocketInputStream.isReady()

2021-03-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit ea8ffba3fc4740201eb93321eb42bb684959cf34 Author: Mark Thomas AuthorDate: Mon Mar 22 21:56:44 2021 + Fix BZ

[tomcat] 03/05: Refactor onDataAvailable() in preparation for fixing BZ 64771

2021-03-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 89e16ba72a5b7c56ac5120b6a46da783fe7947cd Author: Mark Thomas AuthorDate: Mon Mar 22 21:51:24 2021 + Refactor

[tomcat] branch 8.5.x updated (aabee09 -> d2f0917)

2021-03-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from aabee09 Better variable name. These are request headers, not response headers. new 110a6a8 Refactor isReady()

[tomcat] branch 9.0.x updated (57396e9 -> 5f85526)

2021-03-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 57396e9 Better variable name. These are request headers, not response headers. new da10a04 Refactor isReady()

[tomcat] 04/04: Fix BZ 64771. Support calls to SocketInputStream.isReady()

2021-03-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 5f85526a093190881b939486320b7e5b1d6849ab Author: Mark Thomas AuthorDate: Mon Mar 22 21:56:44 2021 + Fix BZ

[tomcat] 03/04: Refactor onDataAvailable() in preparation for fixing BZ 64771

2021-03-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 16a2315ea0a25a45bbc816f70a8c0f6e9a8bc675 Author: Mark Thomas AuthorDate: Mon Mar 22 21:51:24 2021 + Refactor

[tomcat] 02/04: Refactor setReadListener() in preparation for fix for BZ 64771

2021-03-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit ea9a386aa3c3c1ce59afa4341099b960c7f74bf2 Author: Mark Thomas AuthorDate: Mon Mar 22 21:45:21 2021 + Refactor

[tomcat] 01/04: Refactor isReady() in preparation for fix of BZ 64771

2021-03-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit da10a0478c7affd397834797d29316ca112cc220 Author: Mark Thomas AuthorDate: Mon Mar 22 21:43:27 2021 + Refactor

[tomcat] branch master updated: Fix BZ 64771. Support calls to SocketInputStream.isReady()

2021-03-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new a9160a6 Fix BZ 64771. Support calls to

[tomcat] 02/02: Refactor onDataAvailable() in preparation for fixing BZ 64771

2021-03-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit e7019f6bbfdce78b88b82f1ed01add25290b3538 Author: Mark Thomas AuthorDate: Mon Mar 22 21:51:24 2021 + Refactor

[tomcat] 01/02: Fix checkstyle nag

2021-03-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 1a695b38dada9563e60d06cd32086d465bcaa2a5 Author: Mark Thomas AuthorDate: Mon Mar 22 21:49:01 2021 + Fix

[tomcat] branch master updated (c34b60e -> e7019f6)

2021-03-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git. from c34b60e Refactor setReadListener() in preparation for fix for BZ 64771 new 1a695b3 Fix checkstyle nag new

[tomcat] 01/02: Refactor isReady() in preparation for fix of BZ 64771

2021-03-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit b66b1f23f27ca1ac9da25e1d34f55d1bf8bb0b96 Author: Mark Thomas AuthorDate: Mon Mar 22 21:43:27 2021 + Refactor

[tomcat] 02/02: Refactor setReadListener() in preparation for fix for BZ 64771

2021-03-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit c34b60e9432a34242c0ba8c1498efa0a171fba62 Author: Mark Thomas AuthorDate: Mon Mar 22 21:45:21 2021 + Refactor

[tomcat] branch master updated (174fa56 -> c34b60e)

2021-03-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 174fa56 Better variable name. These are request headers, not response headers. new b66b1f2 Refactor isReady()

[tomcat] branch 8.5.x updated (21df62a -> aabee09)

2021-03-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 21df62a Avoid reflection use for classloader configuration new 717707b Cosmetic clean-up. Better comments.

[tomcat] 02/02: Better variable name. These are request headers, not response headers.

2021-03-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit aabee092ded7d043a61bdbee5e39209872b4ecd1 Author: Mark Thomas AuthorDate: Mon Mar 22 16:16:44 2021 + Better

[tomcat] 01/02: Cosmetic clean-up. Better comments.

2021-03-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 717707b2e27603d9d3a27a24c0e67be727b4f0d4 Author: Mark Thomas AuthorDate: Mon Mar 22 16:16:03 2021 + Cosmetic

[tomcat] 02/02: Better variable name. These are request headers, not response headers.

2021-03-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 57396e91e6b24ac1f61d226ba997fba9f3d76c6e Author: Mark Thomas AuthorDate: Mon Mar 22 16:16:44 2021 + Better

[tomcat] 01/02: Cosmetic clean-up. Better comments.

2021-03-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 460f51ef3557ce842340181e9c3fa426bd6f075e Author: Mark Thomas AuthorDate: Mon Mar 22 16:16:03 2021 + Cosmetic

[tomcat] branch 9.0.x updated (f5d45ff -> 57396e9)

2021-03-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from f5d45ff Avoid reflection use for classloader configuration new 460f51e Cosmetic clean-up. Better comments.

[tomcat] branch master updated (5803d56 -> 174fa56)

2021-03-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 5803d56 Avoid reflection use for classloader configuration new b87bb5f Cosmetic clean-up. Better comments.

[tomcat] 01/02: Cosmetic clean-up. Better comments.

2021-03-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit b87bb5f4b96dc70e2421881413a9335069e416b4 Author: Mark Thomas AuthorDate: Mon Mar 22 16:16:03 2021 + Cosmetic

[tomcat] 02/02: Better variable name. These are request headers, not response headers.

2021-03-22 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 174fa5679b401bfbff11392dac01a6f662ddf700 Author: Mark Thomas AuthorDate: Mon Mar 22 16:16:44 2021 + Better

Re: Reproducible builds

2021-03-22 Thread Konstantin Kolinko
пн, 22 мар. 2021 г. в 17:32, Mark Thomas : > > On 22/03/2021 13:16, Konstantin Kolinko wrote: > > сб, 20 мар. 2021 г. в 18:24, Emmanuel Bourg : > > >> I got a quick look, I guess you replaced the tasks with to > >> make the timestamp of the zip entries reproducible? I'm not sure this is > >>

Re: Reproducible builds

2021-03-22 Thread Mark Thomas
On 22/03/2021 13:16, Konstantin Kolinko wrote: сб, 20 мар. 2021 г. в 18:24, Emmanuel Bourg : 2. The current Windows exe signing process isn't repeatable. There are a few suggestions workarounds at https://reproducible-builds.org/ and I need to discuss these with the provider of the code

Re: Reproducible builds

2021-03-22 Thread Konstantin Kolinko
сб, 20 мар. 2021 г. в 18:24, Emmanuel Bourg : > > 2. The current Windows exe signing process isn't repeatable. There are a > > few suggestions workarounds at https://reproducible-builds.org/ and I > > need to discuss these with the provider of the code signing service the > > ASF uses (DigiCert).

[GitHub] [tomcat] rmaucher commented on pull request #414: don't log undesired warnings for webapp classloader configuration

2021-03-22 Thread GitBox
rmaucher commented on pull request #414: URL: https://github.com/apache/tomcat/pull/414#issuecomment-804012002 I added the simple reflection free version, so the properties now need WebappCLBase and we'll see what happens. I didn't merge the test since it's quite obvious when there's no

[GitHub] [tomcat] rmaucher closed pull request #414: don't log undesired warnings for webapp classloader configuration

2021-03-22 Thread GitBox
rmaucher closed pull request #414: URL: https://github.com/apache/tomcat/pull/414 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[tomcat] branch 8.5.x updated: Avoid reflection use for classloader configuration

2021-03-22 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 21df62a Avoid reflection use for classloader

Re: [tomcat] branch master updated: Avoid reflection use for classloader configuration

2021-03-22 Thread Rémy Maucherat
On Mon, Mar 22, 2021 at 12:53 PM wrote: > - > setClassLoaderProperty("clearReferencesObjectStreamClassCaches", > -getClearReferencesObjectStreamClassCaches()); > - > setClassLoaderProperty("clearReferencesObjectStreamClassCaches", > -

[tomcat] branch 9.0.x updated: Avoid reflection use for classloader configuration

2021-03-22 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new f5d45ff Avoid reflection use for classloader

[tomcat] branch master updated: Avoid reflection use for classloader configuration

2021-03-22 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 5803d56 Avoid reflection use for classloader

Re: Reproducible builds

2021-03-22 Thread Mark Thomas
On 20/03/2021 15:24, Emmanuel Bourg wrote: Le 19/03/2021 à 16:39, Mark Thomas a écrit : Over the last few days I have been looking at making the Tomcat builds (more) reproducible. I have currently reached the stage where sequential builds on my local machine produce identical output. That's