[GitHub] [tomcat] tianshuang opened a new pull request #419: part.getString will cause OOM without checking maxPostSize, checking maxPostSize first will avoid OOM caused by huge string

2021-05-19 Thread GitBox
tianshuang opened a new pull request #419: URL: https://github.com/apache/tomcat/pull/419 In our online server, when the client sends a huge string (hundreds of megabytes) to the server via multipart/form-data, OOM occurs, and the maxPostSize check logic is not executed -- This is an au

[Bug 65124] Inefficient generated JSP code

2021-05-19 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65124 --- Comment #15 from John Engebretson --- Sorry, I'm a little confused - are you planning to generate plugins for every tag? I view this more as an optimization to the global JSP compiler. -- You are receiving this mail because: You are the

[tomcat] branch 8.5.x updated: Remove unnecessary code - align with 9.0.x/10.0.x

2021-05-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new c099d68 Remove unnecessary code - align with 9.0.x

[GitHub] [tomcat] markt-asf commented on pull request #401: Add support for unix domain sockets (APR Protocol)

2021-05-19 Thread GitBox
markt-asf commented on pull request #401: URL: https://github.com/apache/tomcat/pull/401#issuecomment-844365000 As far as I can tell, this PR was applied in a616bf38 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [tomcat] markt-asf closed pull request #401: Add support for unix domain sockets (APR Protocol)

2021-05-19 Thread GitBox
markt-asf closed pull request #401: URL: https://github.com/apache/tomcat/pull/401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[tomcat] branch 8.5.x updated: Improve the SSLValve so it is able to handle the ssl_client_escaped_cert header from Nginx

2021-05-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 02f012b Improve the SSLValve so it is able to hand

[tomcat] branch master updated: Improve the SSLValve so it is able to handle the ssl_client_escaped_cert header from Nginx

2021-05-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new b3ff835 Improve the SSLValve so it is able to ha

[tomcat] branch 9.0.x updated: Improve the SSLValve so it is able to handle the ssl_client_escaped_cert header from Nginx

2021-05-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new be0408d Improve the SSLValve so it is able to hand

[GitHub] [tomcat] markt-asf merged pull request #406: Improve the SSLValve so it is able to handle the ssl_client_escaped_cert header from Nginx

2021-05-19 Thread GitBox
markt-asf merged pull request #406: URL: https://github.com/apache/tomcat/pull/406 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[Bug 65317] PerMessageDeflate getMoreData doesn't return correct TransformationResult if the payload is inflated to exact 8192 bytes

2021-05-19 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65317 Saksham Verma changed: What|Removed |Added OS||All CC|

[Bug 65317] New: PerMessageDeflate getMoreData doesn't return correct TransformationResult if the payload is inflated to exact 8192 bytes

2021-05-19 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65317 Bug ID: 65317 Summary: PerMessageDeflate getMoreData doesn't return correct TransformationResult if the payload is inflated to exact 8192 bytes Product: Tomcat 9

buildbot success in on tomcat-85-trunk

2021-05-19 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-85-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-85-trunk/builds/2726 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchSch

[tomcat] branch 8.5.x updated: Fix Javadoc error

2021-05-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 05633b3 Fix Javadoc error 05633b3 is described bel

[tomcat-jakartaee-migration] branch master updated: Remove deprecated -verbose option

2021-05-19 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git The following commit(s) were added to refs/heads/master by this push: new 528f05e Remove deprecated -ve

[tomcat-jakartaee-migration] branch master updated: Add issue link

2021-05-19 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git The following commit(s) were added to refs/heads/master by this push: new 0bf8836 Add issue link 0bf883

[tomcat-jakartaee-migration] branch master updated: Use commons-compression for the default code path

2021-05-19 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git The following commit(s) were added to refs/heads/master by this push: new 105e5b9 Use commons-compressi

Re: Time to create Tomcat 10.1.x and master->main migration

2021-05-19 Thread Martin Grigorov
On Tue, May 18, 2021 at 3:16 PM Romain Manni-Bucau wrote: > +1 to move forward even if jakarta is not yet adopted (there is a single > time direction - at least at our scale ;)) > -0 to break all clones and related toolings/automotion for hypothetical > reasons, didn't pay in all projects which d

buildbot failure in on tomcat-85-trunk

2021-05-19 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-85-trunk while building tomcat. Full details are available at: https://ci.apache.org/builders/tomcat-85-trunk/builds/2725 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: asf946_ubuntu Build Reason: The AnyBranchSchedu

[tomcat] branch master updated: Attempt to get GitHub to store the test logs to help debug failures

2021-05-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new e9d0584 Attempt to get GitHub to store the test

[tomcat] branch 8.5.x updated: Fix #412. Add commented out users for the Manager app

2021-05-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 7e5c30d Fix #412. Add commented out users for the

[GitHub] [tomcat] markt-asf closed pull request #412: Adding default manager roles in tomcat users config.

2021-05-19 Thread GitBox
markt-asf closed pull request #412: URL: https://github.com/apache/tomcat/pull/412 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[tomcat] branch 9.0.x updated: Fix #412. Add commented out users for the Manager app

2021-05-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 3a06704 Fix #412. Add commented out users for the

[tomcat] branch master updated: Fix #412. Add commented out users for the Manager app

2021-05-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new 94c352d Fix #412. Add commented out users for th

[tomcat] branch 8.5.x updated: Fix #418 - add "pass-through" as an option for useBomIfPresent

2021-05-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new aae6bb9 Fix #418 - add "pass-through" as an option

[tomcat] branch 9.0.x updated: Fix #418 - add "pass-through" as an option for useBomIfPresent

2021-05-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 61a27bd Fix #418 - add "pass-through" as an option

[GitHub] [tomcat] markt-asf closed pull request #418: DefaultServlet - Strip BOM improvements.

2021-05-19 Thread GitBox
markt-asf closed pull request #418: URL: https://github.com/apache/tomcat/pull/418 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[tomcat] branch master updated: Fix #418 - add "pass-through" as an option for useBomIfPresent

2021-05-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new ea00bb5 Fix #418 - add "pass-through" as an opti

[GitHub] [tomcat] markt-asf commented on pull request #418: DefaultServlet - Strip BOM improvements.

2021-05-19 Thread GitBox
markt-asf commented on pull request #418: URL: https://github.com/apache/tomcat/pull/418#issuecomment-843968274 I have this applied locally along with an update to the documentation and the change log. I also refactored it to use an Enum for the configuration option. I'll commit it shor

[tomcat] branch 8.5.x updated: Format. No functional change.

2021-05-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 2ea2421 Format. No functional change. 2ea2421 is d

[tomcat] branch 9.0.x updated: Format. No functional change.

2021-05-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 6801339 Format. No functional change. 6801339 is d

[tomcat] branch master updated: Format. No functional change.

2021-05-19 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new c7f904b Format. No functional change. c7f904b is