Re: Javadoc beyond 17
On Thu, Nov 10, 2022 at 4:37 PM Mark Thomas wrote: > > Rémy, > > Which Java vendor and version was this with? I've just tested with > Temurin 19.0.1+10 and the latest OpenJDK 20 EA release and both generate > the Javadoc for 11.0.x without errors (lots of warnings as expected). I tried with Java 18 from https://adoptium.net/temurin/releases/?version=18 and it's the bunch of new warnings (but no errors) with "ant javadoc". I noticed this first with the Jakarta tool, since the github actions treat the javadoc warnings as problems. Previously all the javadoc warnings were fixed in Tomcat, but I'm not sure this is worth doing again. I found the details for the most annoying new feature (having to have empty constructors just to document them ...) here: https://stackoverflow.com/questions/72393731/how-can-i-disable-a-specific-type-of-missing-comment-warning-in-javadoc Rémy > > Mark > > > On 02/11/2022 20:08, Mark Thomas wrote: > > On 02/11/2022 15:52, Rémy Maucherat wrote: > >> Hi, > >> > >> It seems javadoc has become a lot stricter moving forward (starting > >> with Java 18 it seems), where basically everything now needs a > >> javadoc. So will we be keeping a zero warning policy, or are we going > >> to decide to relax it ? > >> If not, this will keep up busy for some time ;) > >> > >> I noticed the problem while looking at the github actions failures > >> with Java 18+ and seeing the javadoc output after fixing. > > > > It depends what the minimum Java version for Jakarta EE 11 is ;) > > > > More seriously, I have been slowly working through these over time with > > the plan / hope to have fixed them by the time we absolutely have to. It > > does seem to be a bit of a moving target depending on JVM vendor and > > Java version. > > > > We should parameterise failonerror and failonwarning so users can > > compile more easily on later versions. And we can change default if we > > reach a point we need to. > > > > Mark > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > > For additional commands, e-mail: dev-h...@tomcat.apache.org > > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 9.0.69
> 2022年11月10日 03:48，Rémy Maucherat 写道： > > The proposed Apache Tomcat 9.0.69 release is now available for voting. > > The notable changes compared to 9.0.68 are: > > - Fix concurrency issue in evaluation of expression language containing > lambda expressions. > > - Update the packaged version of the Apache Tomcat Native Library to > 2.0.2 to pick up the Windows binaries built with with OpenSSL 3.0.7. > > - Correct the date format used with the expires attribute of HTTP > cookies. A single space rather than a single dash should be used to > separate the day, month and year components to be compliant with RFC > 6265. > > Along with lots of other bug fixes and improvements. > > For full details, see the changelog: > https://nightlies.apache.org/tomcat/tomcat-9.0.x/docs/changelog.html > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.69/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1406 > The tag is: > https://github.com/apache/tomcat/tree/9.0.69 > cd5fd93c5df3699868ec39731f5a347450112299 > > The proposed 9.0.69 release is: > [ ] Broken - do not release > [X ] Stable - go ahead and release as 9.0.69 Tests pass with OpenSSL 3.0.7 and tc-native-1.2.35 on macOS 12.3.1. Han > > Rémy > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 9.0.69
Le 09/11/2022 à 20:48, Rémy Maucherat a écrit : The proposed 9.0.69 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 9.0.69 Looks good in Debian with OpenJDK 17 Emmanuel Bourg - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 9.0.x updated: OpenSSL master is now 3.2.x - update so Gump tests pass
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 080a54a5a2 OpenSSL master is now 3.2.x - update so Gump tests pass
080a54a5a2 is described below
commit 080a54a5a2599ff101bf47027552491d3fa987ce
Author: Mark Thomas
AuthorDate: Thu Nov 10 16:49:29 2022 +
OpenSSL master is now 3.2.x - update so Gump tests pass
---
test/org/apache/tomcat/util/net/openssl/ciphers/TesterOpenSSL.java | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/test/org/apache/tomcat/util/net/openssl/ciphers/TesterOpenSSL.java
b/test/org/apache/tomcat/util/net/openssl/ciphers/TesterOpenSSL.java
index 946302a9e1..4a9735f653 100644
--- a/test/org/apache/tomcat/util/net/openssl/ciphers/TesterOpenSSL.java
+++ b/test/org/apache/tomcat/util/net/openssl/ciphers/TesterOpenSSL.java
@@ -49,8 +49,10 @@ public class TesterOpenSSL {
} catch (IOException e) {
versionString = "";
}
-if (versionString.startsWith("OpenSSL 3.1.")) {
-// Note: Gump currently tests 10.x with OpenSSL 3.1.x
+if (versionString.startsWith("OpenSSL 3.2.")) {
+// Note: Gump currently tests 11.x with OpenSSL 3.2.x
+VERSION = 30200;
+} else if (versionString.startsWith("OpenSSL 3.1.")) {
VERSION = 30100;
} else if (versionString.startsWith("OpenSSL 3.0.")) {
VERSION = 3;
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 8.5.x updated: OpenSSL master is now 3.2.x - update so Gump tests pass
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new 8f9e04c87c OpenSSL master is now 3.2.x - update so Gump tests pass
8f9e04c87c is described below
commit 8f9e04c87cb7aeff2cf17c649acbe1a569662e7e
Author: Mark Thomas
AuthorDate: Thu Nov 10 16:49:29 2022 +
OpenSSL master is now 3.2.x - update so Gump tests pass
---
test/org/apache/tomcat/util/net/openssl/ciphers/TesterOpenSSL.java | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/test/org/apache/tomcat/util/net/openssl/ciphers/TesterOpenSSL.java
b/test/org/apache/tomcat/util/net/openssl/ciphers/TesterOpenSSL.java
index 946302a9e1..4a9735f653 100644
--- a/test/org/apache/tomcat/util/net/openssl/ciphers/TesterOpenSSL.java
+++ b/test/org/apache/tomcat/util/net/openssl/ciphers/TesterOpenSSL.java
@@ -49,8 +49,10 @@ public class TesterOpenSSL {
} catch (IOException e) {
versionString = "";
}
-if (versionString.startsWith("OpenSSL 3.1.")) {
-// Note: Gump currently tests 10.x with OpenSSL 3.1.x
+if (versionString.startsWith("OpenSSL 3.2.")) {
+// Note: Gump currently tests 11.x with OpenSSL 3.2.x
+VERSION = 30200;
+} else if (versionString.startsWith("OpenSSL 3.1.")) {
VERSION = 30100;
} else if (versionString.startsWith("OpenSSL 3.0.")) {
VERSION = 3;
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 10.1.x updated: OpenSSL master is now 3.2.x - update so Gump tests pass
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new 794779f8ef OpenSSL master is now 3.2.x - update so Gump tests pass
794779f8ef is described below
commit 794779f8ef0b5c9a697f4ca7cae9899d4f29915c
Author: Mark Thomas
AuthorDate: Thu Nov 10 16:49:29 2022 +
OpenSSL master is now 3.2.x - update so Gump tests pass
---
test/org/apache/tomcat/util/net/openssl/ciphers/TesterOpenSSL.java | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/test/org/apache/tomcat/util/net/openssl/ciphers/TesterOpenSSL.java
b/test/org/apache/tomcat/util/net/openssl/ciphers/TesterOpenSSL.java
index 946302a9e1..4a9735f653 100644
--- a/test/org/apache/tomcat/util/net/openssl/ciphers/TesterOpenSSL.java
+++ b/test/org/apache/tomcat/util/net/openssl/ciphers/TesterOpenSSL.java
@@ -49,8 +49,10 @@ public class TesterOpenSSL {
} catch (IOException e) {
versionString = "";
}
-if (versionString.startsWith("OpenSSL 3.1.")) {
-// Note: Gump currently tests 10.x with OpenSSL 3.1.x
+if (versionString.startsWith("OpenSSL 3.2.")) {
+// Note: Gump currently tests 11.x with OpenSSL 3.2.x
+VERSION = 30200;
+} else if (versionString.startsWith("OpenSSL 3.1.")) {
VERSION = 30100;
} else if (versionString.startsWith("OpenSSL 3.0.")) {
VERSION = 3;
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch main updated: OpenSSL master is now 3.2.x - update so Gump tests pass
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new e095d2036c OpenSSL master is now 3.2.x - update so Gump tests pass
e095d2036c is described below
commit e095d2036c6cb41601223165be912211d23da8e5
Author: Mark Thomas
AuthorDate: Thu Nov 10 16:49:29 2022 +
OpenSSL master is now 3.2.x - update so Gump tests pass
---
test/org/apache/tomcat/util/net/openssl/ciphers/TesterOpenSSL.java | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/test/org/apache/tomcat/util/net/openssl/ciphers/TesterOpenSSL.java
b/test/org/apache/tomcat/util/net/openssl/ciphers/TesterOpenSSL.java
index 946302a9e1..4a9735f653 100644
--- a/test/org/apache/tomcat/util/net/openssl/ciphers/TesterOpenSSL.java
+++ b/test/org/apache/tomcat/util/net/openssl/ciphers/TesterOpenSSL.java
@@ -49,8 +49,10 @@ public class TesterOpenSSL {
} catch (IOException e) {
versionString = "";
}
-if (versionString.startsWith("OpenSSL 3.1.")) {
-// Note: Gump currently tests 10.x with OpenSSL 3.1.x
+if (versionString.startsWith("OpenSSL 3.2.")) {
+// Note: Gump currently tests 11.x with OpenSSL 3.2.x
+VERSION = 30200;
+} else if (versionString.startsWith("OpenSSL 3.1.")) {
VERSION = 30100;
} else if (versionString.startsWith("OpenSSL 3.0.")) {
VERSION = 3;
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Javadoc beyond 17
Rémy, Which Java vendor and version was this with? I've just tested with Temurin 19.0.1+10 and the latest OpenJDK 20 EA release and both generate the Javadoc for 11.0.x without errors (lots of warnings as expected). Mark On 02/11/2022 20:08, Mark Thomas wrote: On 02/11/2022 15:52, Rémy Maucherat wrote: Hi, It seems javadoc has become a lot stricter moving forward (starting with Java 18 it seems), where basically everything now needs a javadoc. So will we be keeping a zero warning policy, or are we going to decide to relax it ? If not, this will keep up busy for some time ;) I noticed the problem while looking at the github actions failures with Java 18+ and seeing the javadoc output after fixing. It depends what the minimum Java version for Jakarta EE 11 is ;) More seriously, I have been slowly working through these over time with the plan / hope to have fixed them by the time we absolutely have to. It does seem to be a bit of a moving target depending on JVM vendor and Java version. We should parameterise failonerror and failonwarning so users can compile more easily on later versions. And we can change default if we reach a point we need to. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 8.5.x updated: Need to include new package in output JAR
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 22ab4644a5 Need to include new package in output JAR 22ab4644a5 is described below commit 22ab4644a57dfd3aeff21e4aabbd6681d3cf7860 Author: Mark Thomas AuthorDate: Thu Nov 10 11:39:35 2022 + Need to include new package in output JAR --- build.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/build.xml b/build.xml index 4756a78d8b..f5c74b75ad 100644 --- a/build.xml +++ b/build.xml @@ -419,6 +419,7 @@ + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 9.0.69
On Thu, Nov 10, 2022 at 9:04 AM Han Li wrote: > > > > > 2022年11月10日 03:48，Rémy Maucherat 写道： > > > > The proposed Apache Tomcat 9.0.69 release is now available for voting. > > > > The notable changes compared to 9.0.68 are: > > > > - Fix concurrency issue in evaluation of expression language containing > > lambda expressions. > > > > - Update the packaged version of the Apache Tomcat Native Library to > > 2.0.2 to pick up the Windows binaries built with with OpenSSL 3.0.7. > Hmm. No this change in 9.0.x. You're right it's not the default supported one, too much cut and paste here. Still supporting the APR connector ... Rémy > Han > > > > - Correct the date format used with the expires attribute of HTTP > > cookies. A single space rather than a single dash should be used to > > separate the day, month and year components to be compliant with RFC > > 6265. > > > > Along with lots of other bug fixes and improvements. > > > > For full details, see the changelog: > > https://nightlies.apache.org/tomcat/tomcat-9.0.x/docs/changelog.html > > > > It can be obtained from: > > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.69/ > > The Maven staging repo is: > > https://repository.apache.org/content/repositories/orgapachetomcat-1406 > > The tag is: > > https://github.com/apache/tomcat/tree/9.0.69 > > cd5fd93c5df3699868ec39731f5a347450112299 > > > > The proposed 9.0.69 release is: > > [ ] Broken - do not release > > [ ] Stable - go ahead and release as 9.0.69 > > > > Rémy > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > > For additional commands, e-mail: dev-h...@tomcat.apache.org > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 10.1.2
On Wed, Nov 9, 2022 at 6:32 PM Mark Thomas wrote: > > The proposed Apache Tomcat 10.1.2 release is now available for > voting. > > Applications that run on Tomcat 9 and earlier will not run on Tomcat 10 > without changes. Java EE applications designed for Tomcat 9 and earlier > may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat > will automatically convert them to Jakarta EE and copy them to the > webapps directory. > > The notable changes compared to 10.1.1 are: > > - Fix concurrency issue in evaluation of expression language containing >lambda expressions. > > - Update the packaged version of the Apache Tomcat Native Library to >2.0.2 to pick up the Windows binaries built with with OpenSSL 3.0.7. > > - Correct the date format used with the expires attribute of HTTP >cookies. A single space rather than a single dash should be used to >separate the day, month and year components to be compliant with RFC >6265. > > > For full details, see the change log: > https://nightlies.apache.org/tomcat/tomcat-10.1.x/docs/changelog.html > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.2/ > > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1405 > > The tag is: > https://github.com/apache/tomcat/tree/10.1.2 > 153506ba8aaabbafbf75b9084f5869e02f35facc > > > The proposed 10.1.2 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 10.1.2 Rémy - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 9.0.69
> 2022年11月10日 03:48，Rémy Maucherat 写道： > > The proposed Apache Tomcat 9.0.69 release is now available for voting. > > The notable changes compared to 9.0.68 are: > > - Fix concurrency issue in evaluation of expression language containing > lambda expressions. > > - Update the packaged version of the Apache Tomcat Native Library to > 2.0.2 to pick up the Windows binaries built with with OpenSSL 3.0.7. Hmm. No this change in 9.0.x. Han > > - Correct the date format used with the expires attribute of HTTP > cookies. A single space rather than a single dash should be used to > separate the day, month and year components to be compliant with RFC > 6265. > > Along with lots of other bug fixes and improvements. > > For full details, see the changelog: > https://nightlies.apache.org/tomcat/tomcat-9.0.x/docs/changelog.html > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.69/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1406 > The tag is: > https://github.com/apache/tomcat/tree/9.0.69 > cd5fd93c5df3699868ec39731f5a347450112299 > > The proposed 9.0.69 release is: > [ ] Broken - do not release > [ ] Stable - go ahead and release as 9.0.69 > > Rémy > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
