[Bug 66385] New: NIO2 with HTTP/2 wrong Timeout behaviour
https://bz.apache.org/bugzilla/show_bug.cgi?id=66385 Bug ID: 66385 Summary: NIO2 with HTTP/2 wrong Timeout behaviour Product: Tomcat 10 Version: 10.1.4 Hardware: PC OS: Linux Status: NEW Severity: normal Priority: P2 Component: Connectors Assignee: dev@tomcat.apache.org Reporter: rainer.j...@kippdata.de Target Milestone: -- I observe the following behavior for 10.1.4, but it might neither be a regression nor version specific at all. I am calling a JSP which writes a few bytes, then does "Thread.sleep(2);" and then writes the remaining things. When calling it with HTTP/1.1 it works for all connector types. When calling it with HTTP/2 it works for NIO, but not for NIO2. After a shorter time than the 20 seconds, I get an "empty reply from server" in curl and the browser. The request processing actually continues, but of course the stream is closed so the trying to write the result after 20 seconds fails. It happens for JSSE and tcnative. The behavior seems to be related to the NIO2 readTimeout setting. The empty reply error happens exactly after the amount of time set there and when increasing it slightly above the sleep time in the JSP, I get the correct result. Another possibility is, that it is the writeTimeout but that it erroneously uses the value for the readTimeout. Using trace logging and looking at the http2 log lines, all of those are the same for NIO and for NIO2. Here are the full logs for one failing request. The problem happens at the SocketTimeout at 12:50:40. 12:51:30,382 [exec-0] util.threads.LimitLatch (LimitLatch.java:115) - Counting up[exec-0] latch=1 12:51:30,407 [exec-0] util.net.SecureNio2Channel (SecureNio2Channel.java:432) - The SNI host name extracted for connection [sun.nio.ch.UnixAsynchronousSocketChannelImpl[connected local=/0.2.3.4:8244 remote=/1.2.3.1:58186]] was [myserver] 12:51:30,471 [exec-1] http11.Http11Nio2Protocol (AbstractProtocol.java:761) - Processing socket [org.apache.tomcat.util.net.SecureNio2Channel@39a7a1e8:sun.nio.ch.UnixAsynchronousSocketChannelImpl[connected local=/1.2.3.4:8244 remote=/1.2.3.1:58186]] with status [OPEN_READ] 12:51:30,472 [exec-1] http11.Http11Nio2Protocol (AbstractProtocol.java:777) - Found processor [null] for socket [org.apache.tomcat.util.net.SecureNio2Channel@39a7a1e8:sun.nio.ch.UnixAsynchronousSocketChannelImpl[connected local=/1.2.3.4:8244 remote=/1.2.3.1:58186]] 12:51:30,473 [exec-1] http2.ConnectionSettingsBase (ConnectionSettingsBase.java:66) - Connection [1], Endpoint [Local(client->server)], Parameter type [3] set to [100] 12:51:30,473 [exec-1] http2.ConnectionSettingsBase (ConnectionSettingsBase.java:66) - Connection [1], Endpoint [Local(client->server)], Parameter type [4] set to [65535] 12:51:30,473 [exec-1] http11.Http11Nio2Protocol (AbstractProtocol.java:812) - Created new processor [org.apache.coyote.http11.upgrade.UpgradeProcessorInternal@376048ac] 12:51:30,473 [exec-1] http2.Http2UpgradeHandler (Http2UpgradeHandler.java:331) - Entry, Connection [1], SocketStatus [OPEN_READ] 12:51:30,473 [exec-1] http2.Http2UpgradeHandler (Http2UpgradeHandler.java:202) - Connection [1], State [NEW] 12:51:30,480 [exec-1] http2.Http2Parser (Http2Parser.java:669) - Connection [1], Stream [0], Frame type [SETTINGS], Flags [0], Payload size [18] 12:51:30,480 [exec-1] http2.Http2UpgradeHandler (Http2UpgradeHandler.java:1520) - Connection [1], Stream [0], Frame type [SETTINGS] resulted in new overhead count of [-90] 12:51:30,480 [exec-1] http2.ConnectionSettingsBase (ConnectionSettingsBase.java:66) - Connection [1], Endpoint [Remote(server->client)], Parameter type [3] set to [100] 12:51:30,481 [exec-1] http2.Http2UpgradeHandler (Http2UpgradeHandler.java:1520) - Connection [1], Stream [0], Frame type [SETTINGS] resulted in new overhead count of [-80] 12:51:30,481 [exec-1] http2.ConnectionSettingsBase (ConnectionSettingsBase.java:66) - Connection [1], Endpoint [Remote(server->client)], Parameter type [4] set to [1073741824] 12:51:30,481 [exec-1] http2.Http2UpgradeHandler (Http2UpgradeHandler.java:1520) - Connection [1], Stream [0], Frame type [SETTINGS] resulted in new overhead count of [-70] 12:51:30,481 [exec-1] http2.ConnectionSettingsBase (ConnectionSettingsBase.java:66) - Connection [1], Endpoint [Remote(server->client)], Parameter type [2] set to [0] 12:51:30,482 [exec-1] http2.Http2UpgradeHandler (Http2UpgradeHandler.java:331) - Entry, Connection [1], SocketStatus [OPEN_READ] 12:51:30,482 [exec-1] http2.Http2UpgradeHandler (Http2UpgradeHandler.java:202) - Connection [1], State [CONNECTED] 12:51:30,483 [exec-1] http2.Http2Parser (Http2Parser.java:669) - Connection [1], Stream [0], Frame type [WINDOW_UPDATE], Flags [0], Payload size [4] 12:51:30,483 [exec-1] http2.Http2Parser (Http2Parser.java:430) - Connection [1], Stream [0], Window size increment [1073676289] 12:51:30,483 [exec-1] http2.Abstrac
Re: NIO2 with HTTP/2 wrong Timeout behaviour?
On 09/12/2022 15:15, Rainer Jung wrote: I observe the following behavior for 10.1.4, but it might neither be a regression nor version specific at all. I am calling a JSP which writes a few bytes, then does "Thread.sleep(2);" and then writes the remaining things. When calling it with HTTP/1.1 it works for all connector types. When calling it with HTTP/2 it works for NIO, but not for NIO2. After a shorter time than the 20 seconds, I get an "empty reply from server" in curl and the browser. The request processing actually continues, but of course the stream is closed so the trying to write the result after 20 seconds fails. It happens for JSSE and tcnative. The behavior seems to be related to the NIO2 readTimeout setting. The empty repky error happens exactly after the amount of time set there and when increasing it slightly above the sleep time in the JSP, I get the correct result. Using trace logging and looking at the http2 log lines, all of those are the same for NIO and for NIO2. Should I open an Issue (BZ or GH)? BZ please. This looks valid to me. Thanks for reporting. Mark At the end of the mail you can find the full log for one failing request. The problem happens at the SocketTimeout at 12:50:40. Best regards, Rainer 12:51:30,382 [exec-0] util.threads.LimitLatch (LimitLatch.java:115) - Counting up[exec-0] latch=1 12:51:30,407 [exec-0] util.net.SecureNio2Channel (SecureNio2Channel.java:432) - The SNI host name extracted for connection [sun.nio.ch.UnixAsynchronousSocketChannelImpl[connected local=/0.2.3.4:8244 remote=/1.2.3.1:58186]] was [myserver] 12:51:30,471 [exec-1] http11.Http11Nio2Protocol (AbstractProtocol.java:761) - Processing socket [org.apache.tomcat.util.net.SecureNio2Channel@39a7a1e8:sun.nio.ch.UnixAsynchronousSocketChannelImpl[connected local=/1.2.3.4:8244 remote=/1.2.3.1:58186]] with status [OPEN_READ] 12:51:30,472 [exec-1] http11.Http11Nio2Protocol (AbstractProtocol.java:777) - Found processor [null] for socket [org.apache.tomcat.util.net.SecureNio2Channel@39a7a1e8:sun.nio.ch.UnixAsynchronousSocketChannelImpl[connected local=/1.2.3.4:8244 remote=/1.2.3.1:58186]] 12:51:30,473 [exec-1] http2.ConnectionSettingsBase (ConnectionSettingsBase.java:66) - Connection [1], Endpoint [Local(client->server)], Parameter type [3] set to [100] 12:51:30,473 [exec-1] http2.ConnectionSettingsBase (ConnectionSettingsBase.java:66) - Connection [1], Endpoint [Local(client->server)], Parameter type [4] set to [65535] 12:51:30,473 [exec-1] http11.Http11Nio2Protocol (AbstractProtocol.java:812) - Created new processor [org.apache.coyote.http11.upgrade.UpgradeProcessorInternal@376048ac] 12:51:30,473 [exec-1] http2.Http2UpgradeHandler (Http2UpgradeHandler.java:331) - Entry, Connection [1], SocketStatus [OPEN_READ] 12:51:30,473 [exec-1] http2.Http2UpgradeHandler (Http2UpgradeHandler.java:202) - Connection [1], State [NEW] 12:51:30,480 [exec-1] http2.Http2Parser (Http2Parser.java:669) - Connection [1], Stream [0], Frame type [SETTINGS], Flags [0], Payload size [18] 12:51:30,480 [exec-1] http2.Http2UpgradeHandler (Http2UpgradeHandler.java:1520) - Connection [1], Stream [0], Frame type [SETTINGS] resulted in new overhead count of [-90] 12:51:30,480 [exec-1] http2.ConnectionSettingsBase (ConnectionSettingsBase.java:66) - Connection [1], Endpoint [Remote(server->client)], Parameter type [3] set to [100] 12:51:30,481 [exec-1] http2.Http2UpgradeHandler (Http2UpgradeHandler.java:1520) - Connection [1], Stream [0], Frame type [SETTINGS] resulted in new overhead count of [-80] 12:51:30,481 [exec-1] http2.ConnectionSettingsBase (ConnectionSettingsBase.java:66) - Connection [1], Endpoint [Remote(server->client)], Parameter type [4] set to [1073741824] 12:51:30,481 [exec-1] http2.Http2UpgradeHandler (Http2UpgradeHandler.java:1520) - Connection [1], Stream [0], Frame type [SETTINGS] resulted in new overhead count of [-70] 12:51:30,481 [exec-1] http2.ConnectionSettingsBase (ConnectionSettingsBase.java:66) - Connection [1], Endpoint [Remote(server->client)], Parameter type [2] set to [0] 12:51:30,482 [exec-1] http2.Http2UpgradeHandler (Http2UpgradeHandler.java:331) - Entry, Connection [1], SocketStatus [OPEN_READ] 12:51:30,482 [exec-1] http2.Http2UpgradeHandler (Http2UpgradeHandler.java:202) - Connection [1], State [CONNECTED] 12:51:30,483 [exec-1] http2.Http2Parser (Http2Parser.java:669) - Connection [1], Stream [0], Frame type [WINDOW_UPDATE], Flags [0], Payload size [4] 12:51:30,483 [exec-1] http2.Http2Parser (Http2Parser.java:430) - Connection [1], Stream [0], Window size increment [1073676289] 12:51:30,483 [exec-1] http2.AbstractStream (AbstractStream.java:130) - Connection [1], Stream [0], increase flow control window by [1073676289] to [1073741824] 12:51:30,483 [exec-1] http2.Http2Parser (Http2Parser.java:669) - Connection [1], Stream [1], Frame type [HEADERS], Flags [5], Payload size [52] 12:51:30,484 [exec-1] http2.StreamStateMachine (StreamSt
NIO2 with HTTP/2 wrong Timeout behaviour?
I observe the following behavior for 10.1.4, but it might neither be a regression nor version specific at all. I am calling a JSP which writes a few bytes, then does "Thread.sleep(2);" and then writes the remaining things. When calling it with HTTP/1.1 it works for all connector types. When calling it with HTTP/2 it works for NIO, but not for NIO2. After a shorter time than the 20 seconds, I get an "empty reply from server" in curl and the browser. The request processing actually continues, but of course the stream is closed so the trying to write the result after 20 seconds fails. It happens for JSSE and tcnative. The behavior seems to be related to the NIO2 readTimeout setting. The empty repky error happens exactly after the amount of time set there and when increasing it slightly above the sleep time in the JSP, I get the correct result. Using trace logging and looking at the http2 log lines, all of those are the same for NIO and for NIO2. Should I open an Issue (BZ or GH)? At the end of the mail you can find the full log for one failing request. The problem happens at the SocketTimeout at 12:50:40. Best regards, Rainer 12:51:30,382 [exec-0] util.threads.LimitLatch (LimitLatch.java:115) - Counting up[exec-0] latch=1 12:51:30,407 [exec-0] util.net.SecureNio2Channel (SecureNio2Channel.java:432) - The SNI host name extracted for connection [sun.nio.ch.UnixAsynchronousSocketChannelImpl[connected local=/0.2.3.4:8244 remote=/1.2.3.1:58186]] was [myserver] 12:51:30,471 [exec-1] http11.Http11Nio2Protocol (AbstractProtocol.java:761) - Processing socket [org.apache.tomcat.util.net.SecureNio2Channel@39a7a1e8:sun.nio.ch.UnixAsynchronousSocketChannelImpl[connected local=/1.2.3.4:8244 remote=/1.2.3.1:58186]] with status [OPEN_READ] 12:51:30,472 [exec-1] http11.Http11Nio2Protocol (AbstractProtocol.java:777) - Found processor [null] for socket [org.apache.tomcat.util.net.SecureNio2Channel@39a7a1e8:sun.nio.ch.UnixAsynchronousSocketChannelImpl[connected local=/1.2.3.4:8244 remote=/1.2.3.1:58186]] 12:51:30,473 [exec-1] http2.ConnectionSettingsBase (ConnectionSettingsBase.java:66) - Connection [1], Endpoint [Local(client->server)], Parameter type [3] set to [100] 12:51:30,473 [exec-1] http2.ConnectionSettingsBase (ConnectionSettingsBase.java:66) - Connection [1], Endpoint [Local(client->server)], Parameter type [4] set to [65535] 12:51:30,473 [exec-1] http11.Http11Nio2Protocol (AbstractProtocol.java:812) - Created new processor [org.apache.coyote.http11.upgrade.UpgradeProcessorInternal@376048ac] 12:51:30,473 [exec-1] http2.Http2UpgradeHandler (Http2UpgradeHandler.java:331) - Entry, Connection [1], SocketStatus [OPEN_READ] 12:51:30,473 [exec-1] http2.Http2UpgradeHandler (Http2UpgradeHandler.java:202) - Connection [1], State [NEW] 12:51:30,480 [exec-1] http2.Http2Parser (Http2Parser.java:669) - Connection [1], Stream [0], Frame type [SETTINGS], Flags [0], Payload size [18] 12:51:30,480 [exec-1] http2.Http2UpgradeHandler (Http2UpgradeHandler.java:1520) - Connection [1], Stream [0], Frame type [SETTINGS] resulted in new overhead count of [-90] 12:51:30,480 [exec-1] http2.ConnectionSettingsBase (ConnectionSettingsBase.java:66) - Connection [1], Endpoint [Remote(server->client)], Parameter type [3] set to [100] 12:51:30,481 [exec-1] http2.Http2UpgradeHandler (Http2UpgradeHandler.java:1520) - Connection [1], Stream [0], Frame type [SETTINGS] resulted in new overhead count of [-80] 12:51:30,481 [exec-1] http2.ConnectionSettingsBase (ConnectionSettingsBase.java:66) - Connection [1], Endpoint [Remote(server->client)], Parameter type [4] set to [1073741824] 12:51:30,481 [exec-1] http2.Http2UpgradeHandler (Http2UpgradeHandler.java:1520) - Connection [1], Stream [0], Frame type [SETTINGS] resulted in new overhead count of [-70] 12:51:30,481 [exec-1] http2.ConnectionSettingsBase (ConnectionSettingsBase.java:66) - Connection [1], Endpoint [Remote(server->client)], Parameter type [2] set to [0] 12:51:30,482 [exec-1] http2.Http2UpgradeHandler (Http2UpgradeHandler.java:331) - Entry, Connection [1], SocketStatus [OPEN_READ] 12:51:30,482 [exec-1] http2.Http2UpgradeHandler (Http2UpgradeHandler.java:202) - Connection [1], State [CONNECTED] 12:51:30,483 [exec-1] http2.Http2Parser (Http2Parser.java:669) - Connection [1], Stream [0], Frame type [WINDOW_UPDATE], Flags [0], Payload size [4] 12:51:30,483 [exec-1] http2.Http2Parser (Http2Parser.java:430) - Connection [1], Stream [0], Window size increment [1073676289] 12:51:30,483 [exec-1] http2.AbstractStream (AbstractStream.java:130) - Connection [1], Stream [0], increase flow control window by [1073676289] to [1073741824] 12:51:30,483 [exec-1] http2.Http2Parser (Http2Parser.java:669) - Connection [1], Stream [1], Frame type [HEADERS], Flags [5], Payload size [52] 12:51:30,484 [exec-1] http2.StreamStateMachine (StreamStateMachine.java:115) - Connection [1], Stream [1], State changed from [null] to [IDLE] 12:51:30,484 [exec-
[ANN] Apache Tomcat 10.1.4 available
The Apache Tomcat team announces the immediate availability of Apache Tomcat 10.1.4. Apache Tomcat 10 is an open source software implementation of the Jakarta Servlet, Jakarta Server Pages, Jakarta Expression Language, Jakarta WebSocket, Jakarta Authentication and Jakarta Annotations specifications. Applications that run on Tomcat 9 and earlier will not run on Tomcat 10 without changes. Java EE applications designed for Tomcat 9 and earlier may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat will automatically convert them to Jakarta EE and copy them to the webapps directory. This conversion is performed using the Apache Tomcat migration tool for Jakarta EE tool which is also available as a separate download for off-line use. The notable changes compared to 10.1.2 include: - Refactor WebappLoader so it only has a runtime dependency on the migration tool for Jakarta EE if configured to use the converter as classes are loaded. - When an HTTP/2 stream was reset, the current active stream count was not reduced. If enough resets occurred on a connection, the current active stream count limit was reached and no new streams could be created on that connection. - Update to Commons Daemon 1.3.3 Please refer to the change log for the complete list of changes: http://tomcat.apache.org/tomcat-10.1-doc/changelog.html Downloads: http://tomcat.apache.org/download-10.cgi Migration guides from Apache Tomcat 8.5.x and 9.0.x: http://tomcat.apache.org/migration.html Enjoy! - The Apache Tomcat team - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1905887 - in /tomcat/site/trunk: docs/ xdocs/
Author: markt Date: Fri Dec 9 14:26:43 2022 New Revision: 1905887 URL: http://svn.apache.org/viewvc?rev=1905887&view=rev Log: Update site for 10.1.4 release Modified: tomcat/site/trunk/docs/doap_Tomcat.rdf tomcat/site/trunk/docs/download-10.html tomcat/site/trunk/docs/index.html tomcat/site/trunk/docs/migration-10.1.html tomcat/site/trunk/docs/oldnews.html tomcat/site/trunk/docs/whichversion.html tomcat/site/trunk/xdocs/doap_Tomcat.rdf tomcat/site/trunk/xdocs/download-10.xml tomcat/site/trunk/xdocs/index.xml tomcat/site/trunk/xdocs/migration-10.1.xml tomcat/site/trunk/xdocs/oldnews.xml tomcat/site/trunk/xdocs/whichversion.xml Modified: tomcat/site/trunk/docs/doap_Tomcat.rdf URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/doap_Tomcat.rdf?rev=1905887&r1=1905886&r2=1905887&view=diff == --- tomcat/site/trunk/docs/doap_Tomcat.rdf (original) +++ tomcat/site/trunk/docs/doap_Tomcat.rdf Fri Dec 9 14:26:43 2022 @@ -60,8 +60,8 @@ Latest Stable 10.1.x Release -2022-11-14 -10.1.2 +2022-12-09 +10.1.4 Modified: tomcat/site/trunk/docs/download-10.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/download-10.html?rev=1905887&r1=1905886&r2=1905887&view=diff == --- tomcat/site/trunk/docs/download-10.html (original) +++ tomcat/site/trunk/docs/download-10.html Fri Dec 9 14:26:43 2022 @@ -20,7 +20,7 @@ Quick Navigation [define v]10.0.27[end] -[define w]10.1.2[end] +[define w]10.1.4[end] https://downloads.apache.org/tomcat/tomcat-10/KEYS";>KEYS | [v] | [w] | Modified: tomcat/site/trunk/docs/index.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/index.html?rev=1905887&r1=1905886&r2=1905887&view=diff == --- tomcat/site/trunk/docs/index.html (original) +++ tomcat/site/trunk/docs/index.html Fri Dec 9 14:26:43 2022 @@ -34,6 +34,39 @@ wiki page. Apache Tomcat, Tomcat, Apache, the Apache feather, and the Apache Tomcat project logo are trademarks of the Apache Software Foundation. +2022-12-09 Tomcat 10.1.4 Released + +The Apache Tomcat Project is proud to announce the release of version 10.1.4 +of Apache Tomcat. This release implements specifications that are part of the +Jakarta EE 10 platform. +Applications that run on Tomcat 9 and earlier will not run on Tomcat 10 +without changes. Java EE based applications designed for Tomcat 9 and earlier +may be placed in the $CATALINA_BASE/webapps-javaee directory and +Tomcat will automatically convert them to Jakarta EE and copy them to the +webapps directory. This conversion is performed using the +https://github.com/apache/tomcat-jakartaee-migration";>Apache Tomcat +migration tool for Jakarta EE tool which is also available as a separate +https://tomcat.apache.org/download-migration.cgi";>download for off-line use. +The notable changes in this release are: + +Refactor WebappLoader so it only has a runtime dependency on the migration +tool for Jakarta EE if configured to use the converter as classes are +loaded. +When an HTTP/2 stream was reset, the current active stream count was not +reduced. If enough resets occurred on a connection, the current active +stream count limit was reached and no new streams could be created on that +connection. +Update to Commons Daemon 1.3.3. + + +Full details of these changes, and all the other changes, are available in the +Tomcat 10.1 +changelog. + + + +https://tomcat.apache.org/download-10.cgi";>Download + 2022-12-05 Tomcat 9.0.70 Released The Apache Tomcat Project is proud to announce the release of version 9.0.70 @@ -113,38 +146,6 @@ changelog. https://tomcat.apache.org/download-80.cgi";>Download -2022-11-14 Tomcat 10.1.2 Released - -The Apache Tomcat Project is proud to announce the release of version 10.1.2 -of Apache Tomcat. This release implements specifications that are part of the -Jakarta EE 10 platform. -Applications that run on Tomcat 9 and earlier will not run on Tomcat 10 -without changes. Java EE based applications designed for Tomcat 9 and earlier -may be placed in the $CATALINA_BASE/webapps-javaee directory and -Tomcat will automatically convert them to Jakarta EE and copy them to the -webapps directory. This conversion is performed using the -https://github.com/apache/tomcat-jakartaee-migration";>Apache Tomcat -migration tool for Jakarta EE tool which is also available as a separate -https://tomcat.apache.org/download-migration.cgi";>download for off-line use. -The notable changes in this release are: - -Fix concurrency issue in evaluation of expression language containing lambda -expressions. -Update the packaged version of the Apache Tomcat Native Library to 2.0.2 to -pick
svn commit: r1905886 - in /tomcat/site/trunk: ./ docs/tomcat-10.1-doc/ docs/tomcat-10.1-doc/annotationapi/ docs/tomcat-10.1-doc/annotationapi/jakarta/annotation/ docs/tomcat-10.1-doc/annotationapi/jak
Author: markt Date: Fri Dec 9 14:22:03 2022 New Revision: 1905886 URL: http://svn.apache.org/viewvc?rev=1905886&view=rev Log: Update docs for 10.1.4 release [This commit notification would consist of 69 parts, which exceeds the limit of 50 ones, so it was shortened to the summary.] - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] 02/02: Add release date
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 8c05775b41b7258b45ed7d0bc64b1b9c13a9abfb Author: Mark Thomas AuthorDate: Fri Dec 9 14:14:21 2022 + Add release date --- webapps/docs/changelog.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml index b29ba9f8d3..b4f9a3afd6 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/changelog.xml @@ -106,7 +106,7 @@ --> - + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] 01/02: Increment version for next development cycle
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit cd2beb99d2b5b154fe0a753f430638a19caa60c9 Author: Mark Thomas AuthorDate: Fri Dec 9 14:13:59 2022 + Increment version for next development cycle --- build.properties.default | 2 +- res/maven/mvn.properties.default | 2 +- webapps/docs/changelog.xml | 4 +++- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/build.properties.default b/build.properties.default index 2fb0510313..fbfa7966f6 100644 --- a/build.properties.default +++ b/build.properties.default @@ -31,7 +31,7 @@ # - Version Control Flags - version.major=10 version.minor=1 -version.build=4 +version.build=5 version.patch=0 version.suffix= version.dev=-dev diff --git a/res/maven/mvn.properties.default b/res/maven/mvn.properties.default index 1a6f720028..cc4f8ea7be 100644 --- a/res/maven/mvn.properties.default +++ b/res/maven/mvn.properties.default @@ -39,7 +39,7 @@ maven.asf.release.repo.url=https://repository.apache.org/service/local/staging/d maven.asf.release.repo.repositoryId=apache.releases.https # Release version info -maven.asf.release.deploy.version=10.1.4 +maven.asf.release.deploy.version=10.1.5 #Where do we load the libraries from tomcat.lib.path=../../output/build/lib diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml index dd283faba4..b29ba9f8d3 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/changelog.xml @@ -104,7 +104,9 @@ They eventually become mixed with the numbered issues (i.e., numbered issues do not "pop up" wrt. others). --> - + + + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 10.1.x updated (017c426962 -> 8c05775b41)
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git from 017c426962 Update build.xml - remove not available path. new cd2beb99d2 Increment version for next development cycle new 8c05775b41 Add release date The 2 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: build.properties.default | 2 +- res/maven/mvn.properties.default | 2 +- webapps/docs/changelog.xml | 4 +++- 3 files changed, 5 insertions(+), 3 deletions(-) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r58606 - /dev/tomcat/tomcat-10/v10.1.4/ /release/tomcat/tomcat-10/v10.1.4/
Author: markt Date: Fri Dec 9 14:09:51 2022 New Revision: 58606 Log: Release Apache Tomcat 10.1.4 Added: release/tomcat/tomcat-10/v10.1.4/ - copied from r58605, dev/tomcat/tomcat-10/v10.1.4/ Removed: dev/tomcat/tomcat-10/v10.1.4/ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch main updated: Update comment
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 3124e9798a Update comment
3124e9798a is described below
commit 3124e9798a272db2aff7cef33e50a639ebea5f3d
Author: remm
AuthorDate: Fri Dec 9 15:08:40 2022 +0100
Update comment
---
.../java/org/apache/tomcat/util/net/openssl/panama/OpenSSLContext.java | 2 +-
.../java/org/apache/tomcat/util/net/openssl/panama/OpenSSLEngine.java | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
a/modules/openssl-foreign/src/main/java/org/apache/tomcat/util/net/openssl/panama/OpenSSLContext.java
b/modules/openssl-foreign/src/main/java/org/apache/tomcat/util/net/openssl/panama/OpenSSLContext.java
index 255c3765e1..1b73870194 100644
---
a/modules/openssl-foreign/src/main/java/org/apache/tomcat/util/net/openssl/panama/OpenSSLContext.java
+++
b/modules/openssl-foreign/src/main/java/org/apache/tomcat/util/net/openssl/panama/OpenSSLContext.java
@@ -1382,7 +1382,7 @@ public class OpenSSLContext implements
org.apache.tomcat.util.net.SSLContext {
private ContextState(MemorySegment sslCtx, MemorySegment confCtx,
List negotiableProtocols) {
states.put(Long.valueOf(sslCtx.address()), this);
this.negotiableProtocols = negotiableProtocols;
-// Allocate another session to avoid keeping a reference through
segments
+// Use another arena to avoid keeping a reference through segments
// This also allows making further accesses to the main pointers
safer
this.sslCtx = MemorySegment.ofAddress(sslCtx.address(),
ValueLayout.ADDRESS.byteSize(), stateArena.scope());
if (!MemorySegment.NULL.equals(confCtx)) {
diff --git
a/modules/openssl-foreign/src/main/java/org/apache/tomcat/util/net/openssl/panama/OpenSSLEngine.java
b/modules/openssl-foreign/src/main/java/org/apache/tomcat/util/net/openssl/panama/OpenSSLEngine.java
index 7ce5d6bd12..88ecc5822b 100644
---
a/modules/openssl-foreign/src/main/java/org/apache/tomcat/util/net/openssl/panama/OpenSSLEngine.java
+++
b/modules/openssl-foreign/src/main/java/org/apache/tomcat/util/net/openssl/panama/OpenSSLEngine.java
@@ -1813,7 +1813,7 @@ public final class OpenSSLEngine extends SSLEngine
implements SSLUtil.ProtocolIn
states.put(Long.valueOf(ssl.address()), this);
this.certificateVerificationDepth = certificateVerificationDepth;
this.noOcspCheck = noOcspCheck;
-// Allocate another session to avoid keeping a reference through
segments
+// Use another arena to avoid keeping a reference through segments
// This also allows making further accesses to the main pointers
safer
this.ssl = MemorySegment.ofAddress(ssl.address(),
ValueLayout.ADDRESS.byteSize(), stateArena.scope());
this.networkBIO = MemorySegment.ofAddress(networkBIO.address(),
ValueLayout.ADDRESS.byteSize(), stateArena.scope());
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[VOTE][RESULT] Release Apache Tomcat 10.1.4
The following votes were cast: binding: +1: markt, remm, jfclere non-binding: +1: lihan The vote therefore passes. Thanks to everyone who contributed to this release. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 66378] Failed stop jpf application in shell mode
https://bz.apache.org/bugzilla/show_bug.cgi?id=66378 Mark Thomas changed: What|Removed |Added Resolution|--- |INVALID OS||All Status|NEW |RESOLVED --- Comment #1 from Mark Thomas --- The Server object has not been shut down correctly. The users list is the place to seek further help if required. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 10.1.4
On 12/8/22 20:35, Mark Thomas wrote: Ping. Just a reminder we need one more PMC vote for this release. > [X] Stable - go ahead and release as 10.1.4 Tested of fedora36 Jean-Frederic Thanks, Mark On 05/12/2022 17:42, Mark Thomas wrote: The proposed Apache Tomcat 10.1.4 release is now available for voting. The notable changes compared to 10.1.2 are: - Refactor WebappLoader so it only has a runtime dependency on the migration tool for Jakarta EE if configured to use the converter as classes are loaded. - When an HTTP/2 stream was reset, the current active stream count was not reduced. If enough resets occurred on a connection, the current active stream count limit was reached and no new streams could be created on that connection. - Update to Commons Daemon 1.3.3 For full details, see the change log: https://nightlies.apache.org/tomcat/tomcat-10.1.x/docs/changelog.html Applications that run on Tomcat 9 and earlier will not run on Tomcat 10 without changes. Java EE applications designed for Tomcat 9 and earlier may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat will automatically convert them to Jakarta EE and copy them to the webapps directory. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.4/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1412 The tag is: https://github.com/apache/tomcat/tree/10.1.4 a8e13f8d7e621be9f58af45f5a67e7bf847a8321 The proposed 10.1.4 release is: [ ] Broken - do not release [ ] Stable - go ahead and release as 10.1.4 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org -- Cheers Jean-Frederic - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 66370] AccessControlException and default behavior change with org.apache.el.GET_CLASSLOADER_USE_PRIVILEGED
https://bz.apache.org/bugzilla/show_bug.cgi?id=66370 --- Comment #6 from Mark Thomas --- Looking at comment 0, this line appears in the stack trace: org.apache.jasper.runtime.JspFactoryImpl.getJspApplicationContext(JspFactoryImpl.java:265) I can't match that to any current or historical Tomcat version. It also appears to be missing a privileged block (which Tomcat versions all have) which would avoid the problem. Are you using a modified JspFactoryImpl? If so, this is an issue that needs to be addressed in that modified JspFactoryImpl. Looking at comment 4, I'd like to see the full stack trace to see what is calling jakarta.el.Util since that is a package private class. Looking at the history here: Bug 62080 Some non-Tomcat users of the EL API Jar provided by Tomcat stated a need for additional privileged blocks. While they are known not to be required by Tomcat, they were added. Bug 66294 Tomcat users report that the additional privilege blocks causes performance issues. The solution was to make the use of the additional privilege blocks optional. This was controlled by a system property. The complication is that this also must be called from within a privileged block. Again, this is not an issue for Tomcat. This bug At least one non-Tomcat user of the EL API JAR doesn't use privileged blocks where Tomcat does. Things are not helped by the limited information provided in bug 62080 that started all of this. At this point I see three possible ways forward: 1. Users of the Tomcat provided EL (Open Liberty and others) use privilege blocks for the same calls Tomcat uses them for. 2. The changes for bug 66294 and bug 62080 are reverted. 3. Users stop using the SecurityManager as it is going to go away eventually and this is an opportunity to find an alternative solution to whatever problem using a security manager is currently solving for them. Option 3 seems highly unlikely. Some variation of option 1 might well turn out to the fix for the problem described in bug 62080 but given the lack of information in that bug it is hard to tell. I'm currently leaning towards 2 and if bug 62080 is re-opened, we can dig into exactly why it is happening. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 66382] org.apache.jk has been deleted by Mark Thomas in 2009/4/9, but the file build.xml still have at line 757
https://bz.apache.org/bugzilla/show_bug.cgi?id=66382 Han Li changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Han Li --- Thank you for the PR, it has been merged. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] aooohan closed pull request #573: fix 66382 for build.xml have includ unfound path
aooohan closed pull request #573: fix 66382 for build.xml have includ unfound path URL: https://github.com/apache/tomcat/pull/573 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] aooohan commented on pull request #573: fix 66382 for build.xml have includ unfound path
aooohan commented on PR #573: URL: https://github.com/apache/tomcat/pull/573#issuecomment-1344002368 Merged manually. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 8.5.x updated: Update build.xml - remove not available path.
This is an automated email from the ASF dual-hosted git repository. lihan pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 524011a5e6 Update build.xml - remove not available path. 524011a5e6 is described below commit 524011a5e60a736237cf5b666934ac4856f82e41 Author: lihan AuthorDate: Fri Dec 9 16:27:14 2022 +0800 Update build.xml - remove not available path. Submitted by yong hu. --- build.xml | 1 - 1 file changed, 1 deletion(-) diff --git a/build.xml b/build.xml index f5c74b75ad..b6271ff8e5 100644 --- a/build.xml +++ b/build.xml @@ -505,7 +505,6 @@ --> - - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 9.0.x updated: Update build.xml - remove not available path.
This is an automated email from the ASF dual-hosted git repository. lihan pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new a91c539a23 Update build.xml - remove not available path. a91c539a23 is described below commit a91c539a239343fc208c9b9a82a4ab74f9014074 Author: lihan AuthorDate: Fri Dec 9 16:27:14 2022 +0800 Update build.xml - remove not available path. Submitted by yong hu. --- build.xml | 1 - 1 file changed, 1 deletion(-) diff --git a/build.xml b/build.xml index fde8898f1b..7460c756d3 100644 --- a/build.xml +++ b/build.xml @@ -750,7 +750,6 @@ --> - - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 10.1.x updated: Update build.xml - remove not available path.
This is an automated email from the ASF dual-hosted git repository. lihan pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 017c426962 Update build.xml - remove not available path. 017c426962 is described below commit 017c426962403e5c2acf424633d95b8979626ea4 Author: lihan AuthorDate: Fri Dec 9 16:27:14 2022 +0800 Update build.xml - remove not available path. Submitted by yong hu. --- build.xml | 1 - 1 file changed, 1 deletion(-) diff --git a/build.xml b/build.xml index b76fbcd3bf..c40ee2f16a 100644 --- a/build.xml +++ b/build.xml @@ -754,7 +754,6 @@ --> - - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch main updated: Update build.xml - remove not available path.
This is an automated email from the ASF dual-hosted git repository. lihan pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new c60a558566 Update build.xml - remove not available path. c60a558566 is described below commit c60a55856677c33bb34558ce60273712833fdc67 Author: lihan AuthorDate: Fri Dec 9 16:27:14 2022 +0800 Update build.xml - remove not available path. Submitted by yong hu. --- build.xml | 1 - 1 file changed, 1 deletion(-) diff --git a/build.xml b/build.xml index 92dc34cab8..a3fce38255 100644 --- a/build.xml +++ b/build.xml @@ -754,7 +754,6 @@ --> - - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
