[GitHub] [tomcat] markt-asf commented on pull request #593: Update CONTRIBUTING.md

2023-02-20 Thread via GitHub


markt-asf commented on PR #593:
URL: https://github.com/apache/tomcat/pull/593#issuecomment-1437964475

   That spelling is correct for US English.
   Given the range of contributors to Tomcat, there is a mix of UK and US 
English used in the Tomcat docs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] markt-asf closed pull request #593: Update CONTRIBUTING.md

2023-02-20 Thread via GitHub


markt-asf closed pull request #593: Update CONTRIBUTING.md
URL: https://github.com/apache/tomcat/pull/593


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] zengwei2000 opened a new pull request, #593: Update CONTRIBUTING.md

2023-02-20 Thread via GitHub


zengwei2000 opened a new pull request, #593:
URL: https://github.com/apache/tomcat/pull/593

   fix typo


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 66482] Nio2 websocket timeout cause the response is no longer possible, always pending

2023-02-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66482

--- Comment #5 from zhougang  ---
(In reply to Remy Maucherat from comment #4)
> Ok, so that makes sense. I checked the code and both read and write can
> throw this undocumented exception (there are other exceptions but they don't
> occur, unlike this one apparently).
> The easiest is probably going to be to do a try/catch for the whole
> Nio2OperationState.run and call the completion failure with the exception.

Yes, I did try/finally for the entire Nio2OperationState.run and then the
problem did not occur in the test.  But are there any side effects to this
modification?  Because we've seen elsewhere that there are isInline methods
that do something based on this variable value.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 10.1.6

2023-02-20 Thread Igal Sapir
On Sun, Feb 19, 2023 at 6:11 AM Christopher Schultz <
ch...@christopherschultz.net> wrote:

> The proposed Apache Tomcat 10.1.6 release is now available for
> voting.
>
> The notable changes compared to 10.1.5 are:
>
> - Switch to using the ServiceLoader mechanism to load the custom URL
>protocol handlers that Tomcat uses.
>
> - Update the packaged version of the Apache Tomcat Native Library to
>2.0.3 to pick up the Windows binaries built with with OpenSSL 3.0.8.
>
> - Add the shared address space specified by RFC 6598 (100.64.0.0/10)
>to the list of trusted proxies for RemoteIPValve/Filter.
>
> - Limit access to examples web application to localhost by default
>
>
> For full details, see the change log:
> https://nightlies.apache.org/tomcat/tomcat-10.1.x/docs/changelog.html
>
> Applications that run on Tomcat 9 and earlier will not run on Tomcat 10
> without changes. Java EE applications designed for Tomcat 9 and earlier
> may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat
> will automatically convert them to Jakarta EE and copy them to the
> webapps directory.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.6/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1421
>
> The tag is:
> https://github.com/apache/tomcat/tree/10.1.6
> 9829c929059f96605a3fb870700b5887970d7203
>
> The proposed 10.1.6 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 10.1.6
>

+1

Igal



>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 10.1.6

2023-02-20 Thread Igal Sapir
Mark,

On Mon, Feb 20, 2023 at 1:22 AM Mark Thomas  wrote:

> On 19/02/2023 18:15, Igal Sapir wrote:
> > I get a failure on TestImportHandlerStandardPackages on both Java 11 and
> > Java 17.  Any thoughts?  Output below:
> >
> > Testsuite: jakarta.el.TestImportHandlerStandardPackages
> > Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.319 sec
>
> That suggests an issue with the test environment. The SingleThreadModel
> class was removed in 10.1.x. Maybe you need an "ant clean"?
>

That did it.  In the past I used to always run `ant clean test` and for
some reason I felt like "clean" was redundant but evidently it is not.

Thank you,

Igal



>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


[SECURITY] CVE-2023-24998 Apache Tomcat - FileUpload DoS with excessive parts

2023-02-20 Thread Mark Thomas

Re-sending with corrected credit

CVE-2023-24998 Apache Tomcat - FileUpload DoS with excessive parts

Severity: Important

Vendor: The Apache Software Foundation

Versions Affected:
Apache Tomcat 11.0.0-M1
Apache Tomcat 10.1.0-M1 to 10.1.4
Apache Tomcat 9.0.0-M1 to 9.0.70
Apache Tomcat 8.5.0 to 8.5.84

Description:
Apache Tomcat uses a packaged renamed copy of Apache Commons FileUpload 
to provide the file upload functionality defined in the Jakarta Servlet 
specification. Apache Tomcat was, therefore, also vulnerable to the 
Apache Commons FileUpload vulnerability CVE-2023-24998 as there was no 
limit to the number of request parts processed. This resulted in the 
possibility of an attacker triggering a DoS with a malicious upload or 
series of uploads.


Mitigation:
Users of the affected versions should apply one of the following
mitigations:
- Upgrade to Apache Tomcat 11.0.0-M3 or later when released
- Upgrade to Apache Tomcat 10.1.5 or later
- Upgrade to Apache Tomcat 9.0.71 or later
- Upgrade to Apache Tomcat 8.5.85 or later
- Note 11.0.0-M2 was not released

Credit:
This issue was identified by Jakob Ackermann

History:
2023-01-03 Original advisory
2023-01-03 Corrected credit

References:
[1] https://tomcat.apache.org/security-10.html
[2] https://tomcat.apache.org/security-9.html
[3] https://tomcat.apache.org/security-8.html


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[SECURITY] CVE-2023-24998 Apache Tomcat - FileUpload DoS with excessive parts

2023-02-20 Thread Mark Thomas

CVE-2023-24998 Apache Tomcat - FileUpload DoS with excessive parts

Severity: Important

Vendor: The Apache Software Foundation

Versions Affected:
Apache Tomcat 11.0.0-M1
Apache Tomcat 10.1.0-M1 to 10.1.4
Apache Tomcat 9.0.0-M1 to 9.0.70
Apache Tomcat 8.5.0 to 8.5.84

Description:
Apache Tomcat uses a packaged renamed copy of Apache Commons FileUpload 
to provide the file upload functionality defined in the Jakarta Servlet 
specification. Apache Tomcat was, therefore, also vulnerable to the 
Apache Commons FileUpload vulnerability CVE-2023-24998 as there was no 
limit to the number of request parts processed. This resulted in the 
possibility of an attacker triggering a DoS with a malicious upload or 
series of uploads.


Mitigation:
Users of the affected versions should apply one of the following
mitigations:
- Upgrade to Apache Tomcat 11.0.0-M3 or later when released
- Upgrade to Apache Tomcat 10.1.5 or later
- Upgrade to Apache Tomcat 9.0.71 or later
- Upgrade to Apache Tomcat 8.5.85 or later
- Note 11.0.0-M2 was not released

Credit:
This issue was identified by the Apache Tomcat security team.

History:
2023-01-03 Original advisory

References:
[1] https://tomcat.apache.org/security-10.html
[2] https://tomcat.apache.org/security-9.html
[3] https://tomcat.apache.org/security-8.html


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1907777 - in /tomcat/site/trunk: docs/security-10.html docs/security-11.html docs/security-8.html docs/security-9.html xdocs/security-10.xml xdocs/security-11.xml xdocs/security-8.xml xdo

2023-02-20 Thread markt
Author: markt
Date: Mon Feb 20 16:36:44 2023
New Revision: 190

URL: http://svn.apache.org/viewvc?rev=190=rev
Log:
Update site for CVE-2023-24998

Modified:
tomcat/site/trunk/docs/security-10.html
tomcat/site/trunk/docs/security-11.html
tomcat/site/trunk/docs/security-8.html
tomcat/site/trunk/docs/security-9.html
tomcat/site/trunk/xdocs/security-10.xml
tomcat/site/trunk/xdocs/security-11.xml
tomcat/site/trunk/xdocs/security-8.xml
tomcat/site/trunk/xdocs/security-9.xml

Modified: tomcat/site/trunk/docs/security-10.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/security-10.html?rev=190=1907776=190=diff
==
--- tomcat/site/trunk/docs/security-10.html (original)
+++ tomcat/site/trunk/docs/security-10.html Mon Feb 20 16:36:44 2023
@@ -42,26 +42,27 @@
 
 
   Table of Contents
-Fixed in Apache Tomcat 
10.0.27Fixed in Apache 
Tomcat 10.1.2Fixed in 
Apache Tomcat 10.1.1Fixed in Apache Tomcat 
10.0.23Fixed in 
Apache Tomcat 10.1.0-M17Fixed in Apache Tomcat 
10.0.21Fixed in 
Apache Tomcat 10.1.0-M15Fixed in Apache Tomcat 
10.0.20Fixed in 
Apache Tomcat 10.1.0-M14Fixed in Apache Tomcat 
10.0.16Fixed in 
Apache Tomcat 10.1.0-M10Fixed in Apache Tomcat 10.0.12Fixed in Apache Tomcat 
10.1.0-M6Fixed in Apache 
Tomcat 10.0.7Fixed in 
Apache Tomcat 10.0.6Fixed 
in Apache Tomcat 10.0.5Fixed in Apache Tomcat 
10.0.4Fixed in Apache 
Tomcat 10.0.2Fixed in 
Apache Tomcat 10.0.0-M10Fixed in Apache Tomcat 
10.0.0-M8Fixed in 
Apache Tomcat 10.0.0-M7Fixed in Apache Tomcat 
10.0.0-M6Fixed in 
Apache Tomcat 10.0.0-M5
 Not a vulnerability in 
Tomcat
-  2022-10-10 Fixed in Apache Tomcat 10.0.27
+Fixed in Apache Tomcat 
10.1.5Fixed in Apache 
Tomcat 10.1.2Fixed in 
Apache Tomcat 10.1.1Fixed in Apache Tomcat 
10.0.27Fixed in Apache 
Tomcat 10.0.23Fixed 
in Apache Tomcat 10.1.0-M17Fixed in Apache Tomcat 
10.0.21Fixed in 
Apache Tomcat 10.1.0-M15Fixed in Apache Tomcat 
10.0.20Fixed in 
Apache Tomcat 10.1.0-M14Fixed in Apache Tomcat 
10.0.16Fixed in Apache Tomcat 10.1.0-M10Fixed in Apache Tomcat 
10.0.12Fixed in Apache 
Tomcat 10.1.0-M6Fixed in 
Apache Tomcat 10.0.7Fixed 
in Apache Tomcat 10.0.6Fixed in Apache Tomcat 
10.0.5Fixed in Apache 
Tomcat 10.0.4Fixed in 
Apache Tomcat 10.0.2Fixed in Apache Tomcat 
10.0.0-M10Fixed in 
Apache Tomcat 10.0.0-M8Fixed in Apache Tomcat 
10.0.0-M7Fixed in 
Apache Tomcat 10.0.0-M6<
 li>Fixed in Apache Tomcat 
10.0.0-M5Not a 
vulnerability in Tomcat
+  2023-01-13 Fixed in Apache Tomcat 10.1.5
   
-Low: Apache Tomcat request smuggling
-   http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-42252; 
rel="nofollow">CVE-2022-42252
+Important: Apache Tomcat denial of service
+   http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-24998; 
rel="nofollow">CVE-2023-24998
 
-If Tomcat was configured to ignore invalid HTTP headers via setting
-   rejectIllegalHeader to false (not the 
default),
-   Tomcat did not reject a request containing an invalid
-   Content-Length header making a request smuggling attack
-   possible if Tomcat was located behind a reverse proxy that also failed 
to
-   reject the request with the invalid header.
+Apache Tomcat uses a packaged renamed copy of Apache Commons FileUpload
+   to provide the file upload functionality defined in the Jakarta Servlet
+   specification. Apache Tomcat was, therefore, also vulnerable to the
+   Apache Commons FileUpload vulnerability http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-24998; 
rel="nofollow">CVE-2023-24998 as
+   there was no limit to the number of request parts processed. This
+   resulted in the possibility of an attacker triggering a DoS with a
+   malicious upload or series of uploads.

 This was fixed with commit
-   https://github.com/apache/tomcat/commit/0d089a15047faf9cb3c82f80f4d28febd4798920;>0d089a15.
+   https://github.com/apache/tomcat/commit/8a2285f13affa961cc65595aad999db5efae45ce;>8a2285f1.
 
-This issue was reported to the Apache Tomcat Security team on 29
-   September 2022. The issue was made public on 31 October 2022.
+This issue was reported to the Apache Tomcat Security team on 11
+   December 2022. The issue was made public on 20 February 2023.
 
-Affects: 10.0.0-M1 to 10.0.26
+Affects: 10.1.0-M1 to 10.1.4
 
   2022-11-14 Fixed in Apache Tomcat 10.1.2
   
@@ -102,6 +103,26 @@
 
 Affects: 10.1.0-M1 to 10.1.0
 
+  2022-10-10 Fixed in Apache Tomcat 10.0.27
+  
+Low: Apache Tomcat request smuggling
+   http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-42252; 
rel="nofollow">CVE-2022-42252
+
+If Tomcat was configured to ignore invalid HTTP headers via setting
+   rejectIllegalHeader to false (not the 
default),
+   Tomcat did not reject a request containing an invalid
+   Content-Length header making a request smuggling attack

[Bug 66482] Nio2 websocket timeout cause the response is no longer possible, always pending

2023-02-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66482

--- Comment #4 from Remy Maucherat  ---
Ok, so that makes sense. I checked the code and both read and write can throw
this undocumented exception (there are other exceptions but they don't occur,
unlike this one apparently).
The easiest is probably going to be to do a try/catch for the whole
Nio2OperationState.run and call the completion failure with the exception.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.5.86

2023-02-20 Thread Rémy Maucherat
On Sat, Feb 18, 2023 at 2:57 PM Christopher Schultz
 wrote:
>
> The proposed Apache Tomcat 8.5.86 release is now available for voting.
>
> The notable changes compared to 8.5.85 are:
>
> - Add an error report valve that allows redirecting to or proxying from
>an external web server.
>
> - Add the shared address space specified by RFC 6598 (100.64.0.0/10)
>to the list of trusted proxies for RemoteIPValve/Filter.
>
> - Log basic information for each configured TLS certificate when
>Tomcat starts.
>
> - Limit access to examples web application to localhost by default
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://nightlies.apache.org/tomcat/tomcat-8.5.x/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.86/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1419
>
> The tag is:
> https://github.com/apache/tomcat/tree/8.5.86/
> 0bf2722f4652674e321a0e22e72dca75d2ea8275
>
> The proposed 8.5.86 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.5.86 (stable)

Rémy

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 9.0.72

2023-02-20 Thread Rémy Maucherat
On Sat, Feb 18, 2023 at 10:44 AM Rémy Maucherat  wrote:
>
> The proposed Apache Tomcat 9.0.72 release is now available for voting.
>
> The notable changes compared to 9.0.71 are:
>
> -  Add an error report valve that allows redirecting to or proxying from an
>external web server.
>
> - Log basic information for each configured TLS certificate when
>Tomcat starts.
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://nightlies.apache.org/tomcat/tomcat-9.0.x/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.72/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1418
> The tag is:
> https://github.com/apache/tomcat/tree/9.0.72
> 7754d319b2a8866b5bcdf1ea0f35e68470320295
>
> The proposed 9.0.72 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 9.0.72

Rémy

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.5.86

2023-02-20 Thread Mark Thomas

On 18/02/2023 13:56, Christopher Schultz wrote:

The proposed 8.5.86 release is:
[ ] Broken - do not release
[X] Stable - go ahead and release as 8.5.86 (stable)


The binary distributions are reproducible.

The source distributions are not reproducible because the tag is missing 
the res/maven/mvn.properties.release file. I don't think this requires a 
new tag or release vote.


Tests pass on Linux, Windows and MacOS (Intel and M1).

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 11.0.0-M3

2023-02-20 Thread Rémy Maucherat
On Fri, Feb 17, 2023 at 7:18 PM Mark Thomas  wrote:
>
> The proposed Apache Tomcat 11.0.0-M3 release is now available for
> voting.
>
> Apache Tomcat 11.0.0-M3 is a milestone release of the 11.0.x branch and
> has been made to provide users with early access to the new features in
> Apache Tomcat 11.0.x so that they may provide feedback. The notable
> changes compared to the previous milestone include:
>
> For full details, see the change log:
> https://nightlies.apache.org/tomcat/tomcat-11.0.x/docs/changelog.html
>
> Applications that run on Tomcat 9 and earlier will not run on Tomcat 11
> without changes. Java EE applications designed for Tomcat 9 and earlier
> may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat
> will automatically convert them to Jakarta EE and copy them to the
> webapps directory. Applications using deprecated APIs may require
> further changes.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-11/v11.0.0-M3/
> 8afe2647d7801172cc304f4a47d8aad9646d2985
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1417
>
> The tag is:
> https://github.com/apache/tomcat/tree/11.0.0-M3
>
>
> The proposed 11.0.0-M3 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 11.0.0-M3

Alpha

Rémy

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 10.1.6

2023-02-20 Thread Christopher Schultz

Mark,

On 2/20/23 08:27, Mark Thomas wrote:
You'll probably need to change the default ephemeral (dynamic in MS 
speak) port range to avoid issues with port exhaustion.


I'm using:

netsh int ipv4 set dynamicport tcp start=1025 num=64511

I suspect running out of ports is causing odd errors.


I have waved my magic wand and spoken the incantation. We'll see if it 
runs to completion :)


Thanks,
-chris


On 20/02/2023 13:16, Christopher Schultz wrote:

All,

I'm getting a failure on 
jakarta.servlet.http.TestHttpServletDoHeadValidWrite0.NIO on Windows


Looks like 11 failures all of the form:

   Failed to delete at least one file

I'm assuming that this is a spurious error, but the test keeps failing 
at that point and stopping, despite having test.haltonfailure=false in 
my build.properties file.


When running ant test-status, I get only 4 tests shown under "test 
suites with failed tests" and nothing showing elsewhere. A very small 
number of other TEST-*.txt files exist in the logs/ directory.


Any suggestions?

-chris

On 2/19/23 09:11, Christopher Schultz wrote:

The proposed Apache Tomcat 10.1.6 release is now available for
voting.

The notable changes compared to 10.1.5 are:

- Switch to using the ServiceLoader mechanism to load the custom URL
   protocol handlers that Tomcat uses.

- Update the packaged version of the Apache Tomcat Native Library to
   2.0.3 to pick up the Windows binaries built with with OpenSSL 3.0.8.

- Add the shared address space specified by RFC 6598 (100.64.0.0/10)
   to the list of trusted proxies for RemoteIPValve/Filter.

- Limit access to examples web application to localhost by default


For full details, see the change log:
https://nightlies.apache.org/tomcat/tomcat-10.1.x/docs/changelog.html

Applications that run on Tomcat 9 and earlier will not run on Tomcat 
10 without changes. Java EE applications designed for Tomcat 9 and 
earlier may be placed in the $CATALINA_BASE/webapps-javaee directory 
and Tomcat will automatically convert them to Jakarta EE and copy 
them to the webapps directory.


It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.6/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1421

The tag is:
https://github.com/apache/tomcat/tree/10.1.6
9829c929059f96605a3fb870700b5887970d7203

The proposed 10.1.6 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 10.1.6


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 10.1.6

2023-02-20 Thread Christopher Schultz

Konstantin,

On 2/20/23 08:43, Konstantin Kolinko wrote:

пн, 20 февр. 2023 г. в 16:16, Christopher Schultz
:


All,

I'm getting a failure on
jakarta.servlet.http.TestHttpServletDoHeadValidWrite0.NIO on Windows

Looks like 11 failures all of the form:

Failed to delete at least one file

I'm assuming that this is a spurious error, but the test keeps failing
at that point and stopping, despite having test.haltonfailure=false in
my build.properties file.

When running ant test-status, I get only 4 tests shown under "test
suites with failed tests" and nothing showing elsewhere. A very small
number of other TEST-*.txt files exist in the logs/ directory.

Any suggestions?


Is it a virtual machine?


Yes, this is Windows 11 running within VirtualBox on MacOS Ventura, all 
on x86-64 hardware.



Are other tests mentioned in the console output of Ant?


No.


Can it be that "hard drive" is full, so no more logs could be written?


It looks like I have 16GiB free, so I don't think this is a cause. 
Thanks for the sanity check, though. I would never think to check the 
disk space on a VM ;)



JVM crashed?


No evidence of that. Ant just says "BUILD FAILED" and tells me which 
test failed.



Version of java, version of Ant =?


Java 11.0.18, ant 1.10.12.

Thanks,
-chris

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 10.1.6

2023-02-20 Thread Konstantin Kolinko
пн, 20 февр. 2023 г. в 16:16, Christopher Schultz
:
>
> All,
>
> I'm getting a failure on
> jakarta.servlet.http.TestHttpServletDoHeadValidWrite0.NIO on Windows
>
> Looks like 11 failures all of the form:
>
>Failed to delete at least one file
>
> I'm assuming that this is a spurious error, but the test keeps failing
> at that point and stopping, despite having test.haltonfailure=false in
> my build.properties file.
>
> When running ant test-status, I get only 4 tests shown under "test
> suites with failed tests" and nothing showing elsewhere. A very small
> number of other TEST-*.txt files exist in the logs/ directory.
>
> Any suggestions?

Is it a virtual machine?
Are other tests mentioned in the console output of Ant?
Can it be that "hard drive" is full, so no more logs could be written?

JVM crashed?

Version of java, version of Ant =?

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 10.1.6

2023-02-20 Thread Mark Thomas
You'll probably need to change the default ephemeral (dynamic in MS 
speak) port range to avoid issues with port exhaustion.


I'm using:

netsh int ipv4 set dynamicport tcp start=1025 num=64511

I suspect running out of ports is causing odd errors.

Mark



On 20/02/2023 13:16, Christopher Schultz wrote:

All,

I'm getting a failure on 
jakarta.servlet.http.TestHttpServletDoHeadValidWrite0.NIO on Windows


Looks like 11 failures all of the form:

   Failed to delete at least one file

I'm assuming that this is a spurious error, but the test keeps failing 
at that point and stopping, despite having test.haltonfailure=false in 
my build.properties file.


When running ant test-status, I get only 4 tests shown under "test 
suites with failed tests" and nothing showing elsewhere. A very small 
number of other TEST-*.txt files exist in the logs/ directory.


Any suggestions?

-chris

On 2/19/23 09:11, Christopher Schultz wrote:

The proposed Apache Tomcat 10.1.6 release is now available for
voting.

The notable changes compared to 10.1.5 are:

- Switch to using the ServiceLoader mechanism to load the custom URL
   protocol handlers that Tomcat uses.

- Update the packaged version of the Apache Tomcat Native Library to
   2.0.3 to pick up the Windows binaries built with with OpenSSL 3.0.8.

- Add the shared address space specified by RFC 6598 (100.64.0.0/10)
   to the list of trusted proxies for RemoteIPValve/Filter.

- Limit access to examples web application to localhost by default


For full details, see the change log:
https://nightlies.apache.org/tomcat/tomcat-10.1.x/docs/changelog.html

Applications that run on Tomcat 9 and earlier will not run on Tomcat 
10 without changes. Java EE applications designed for Tomcat 9 and 
earlier may be placed in the $CATALINA_BASE/webapps-javaee directory 
and Tomcat will automatically convert them to Jakarta EE and copy them 
to the webapps directory.


It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.6/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1421

The tag is:
https://github.com/apache/tomcat/tree/10.1.6
9829c929059f96605a3fb870700b5887970d7203

The proposed 10.1.6 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 10.1.6


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 10.1.6

2023-02-20 Thread Christopher Schultz

All,

I'm getting a failure on 
jakarta.servlet.http.TestHttpServletDoHeadValidWrite0.NIO on Windows


Looks like 11 failures all of the form:

  Failed to delete at least one file

I'm assuming that this is a spurious error, but the test keeps failing 
at that point and stopping, despite having test.haltonfailure=false in 
my build.properties file.


When running ant test-status, I get only 4 tests shown under "test 
suites with failed tests" and nothing showing elsewhere. A very small 
number of other TEST-*.txt files exist in the logs/ directory.


Any suggestions?

-chris

On 2/19/23 09:11, Christopher Schultz wrote:

The proposed Apache Tomcat 10.1.6 release is now available for
voting.

The notable changes compared to 10.1.5 are:

- Switch to using the ServiceLoader mechanism to load the custom URL
   protocol handlers that Tomcat uses.

- Update the packaged version of the Apache Tomcat Native Library to
   2.0.3 to pick up the Windows binaries built with with OpenSSL 3.0.8.

- Add the shared address space specified by RFC 6598 (100.64.0.0/10)
   to the list of trusted proxies for RemoteIPValve/Filter.

- Limit access to examples web application to localhost by default


For full details, see the change log:
https://nightlies.apache.org/tomcat/tomcat-10.1.x/docs/changelog.html

Applications that run on Tomcat 9 and earlier will not run on Tomcat 10 
without changes. Java EE applications designed for Tomcat 9 and earlier 
may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat 
will automatically convert them to Jakarta EE and copy them to the 
webapps directory.


It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.6/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1421

The tag is:
https://github.com/apache/tomcat/tree/10.1.6
9829c929059f96605a3fb870700b5887970d7203

The proposed 10.1.6 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 10.1.6


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 9.0.72

2023-02-20 Thread Mark Thomas

On 18/02/2023 09:44, Rémy Maucherat wrote:

The proposed 9.0.72 release is:
[ ] Broken - do not release
[X] Stable - go ahead and release as 9.0.72


Build is reproducible.

Tests pass on Linux, Windows and MacOS (Intel and M1).

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 11.0.0-M3

2023-02-20 Thread Felix Schumacher


Am 17.02.23 um 19:18 schrieb Mark Thomas:

The proposed Apache Tomcat 11.0.0-M3 release is now available for
voting.

Apache Tomcat 11.0.0-M3 is a milestone release of the 11.0.x branch 
and has been made to provide users with early access to the new 
features in Apache Tomcat 11.0.x so that they may provide feedback. 
The notable changes compared to the previous milestone include:


For full details, see the change log:
https://nightlies.apache.org/tomcat/tomcat-11.0.x/docs/changelog.html

Applications that run on Tomcat 9 and earlier will not run on Tomcat 
11 without changes. Java EE applications designed for Tomcat 9 and 
earlier may be placed in the $CATALINA_BASE/webapps-javaee directory 
and Tomcat will automatically convert them to Jakarta EE and copy them 
to the webapps directory. Applications using deprecated APIs may 
require further changes.


It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-11/v11.0.0-M3/
8afe2647d7801172cc304f4a47d8aad9646d2985

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1417

The tag is:
https://github.com/apache/tomcat/tree/11.0.0-M3


The proposed 11.0.0-M3 release is:
[ ] Broken - do not release
[x] Stable - go ahead and release as 11.0.0-M3


* Builds and tests run under Linux

* gpg and sha512 checks are valid

Felix



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



OpenPGP_0xEA6C3728EA91C4AF.asc
Description: OpenPGP public key


OpenPGP_signature
Description: OpenPGP digital signature


Re: [VOTE] Release Apache Tomcat 10.1.6

2023-02-20 Thread Felix Schumacher


Am 20.02.23 um 12:41 schrieb Mark Thomas:

On 20/02/2023 11:30, Felix Schumacher wrote:

The source tar seem to be missing two files, that might be important:
  res/META-INF/catalina.jar/services/java.net.spi.URLStreamHandlerProvider 

  res/META-INF/tomcat-embed-core.jar/services/java.net.spi.URLStreamHandlerProvider 



I see those files in both the src.zip and src.tar.gz files.


Yes, sorry, I just looked at the rsync diff and assumed they were 
missing. They are NOT, but the line endings seem to be different, which 
should be no real problem.


Thanks for checking and sorry for the confusion.

Felix



Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



OpenPGP_0xEA6C3728EA91C4AF.asc
Description: OpenPGP public key


OpenPGP_signature
Description: OpenPGP digital signature


Re: [VOTE] Release Apache Tomcat 10.1.6

2023-02-20 Thread Mark Thomas

On 20/02/2023 11:30, Felix Schumacher wrote:

The source tar seem to be missing two files, that might be important:
  res/META-INF/catalina.jar/services/java.net.spi.URLStreamHandlerProvider
  
res/META-INF/tomcat-embed-core.jar/services/java.net.spi.URLStreamHandlerProvider


I see those files in both the src.zip and src.tar.gz files.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 9.0.72

2023-02-20 Thread Felix Schumacher


Am 18.02.23 um 10:44 schrieb Rémy Maucherat:

The proposed Apache Tomcat 9.0.72 release is now available for voting.

The notable changes compared to 9.0.71 are:

-  Add an error report valve that allows redirecting to or proxying from an
external web server.

- Log basic information for each configured TLS certificate when
Tomcat starts.

Along with lots of other bug fixes and improvements.

For full details, see the changelog:
https://nightlies.apache.org/tomcat/tomcat-9.0.x/docs/changelog.html

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.72/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1418
The tag is:
https://github.com/apache/tomcat/tree/9.0.72
7754d319b2a8866b5bcdf1ea0f35e68470320295

The proposed 9.0.72 release is:
[ ] Broken - do not release
[x] Stable - go ahead and release as 9.0.72


* Builds and tests are OK under linux

* gpg and sha512 checks are valid

Might be nice to mention the IP filter in the webapps, though :)

Felix



Rémy

-
To unsubscribe, e-mail:dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail:dev-h...@tomcat.apache.org



OpenPGP_0xEA6C3728EA91C4AF.asc
Description: OpenPGP public key


OpenPGP_signature
Description: OpenPGP digital signature


Re: [VOTE] Release Apache Tomcat 8.5.86

2023-02-20 Thread Felix Schumacher


Am 18.02.23 um 14:56 schrieb Christopher Schultz:

The proposed Apache Tomcat 8.5.86 release is now available for voting.

The notable changes compared to 8.5.85 are:

- Add an error report valve that allows redirecting to or proxying from
  an external web server.

- Add the shared address space specified by RFC 6598 (100.64.0.0/10)
  to the list of trusted proxies for RemoteIPValve/Filter.

- Log basic information for each configured TLS certificate when
  Tomcat starts.

- Limit access to examples web application to localhost by default

Along with lots of other bug fixes and improvements.

For full details, see the changelog:
https://nightlies.apache.org/tomcat/tomcat-8.5.x/docs/changelog.html

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.86/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1419

The tag is:
https://github.com/apache/tomcat/tree/8.5.86/
0bf2722f4652674e321a0e22e72dca75d2ea8275

The proposed 8.5.86 release is:
[ ] Broken - do not release
[x] Stable - go ahead and release as 8.5.86 (stable)


* Builds and tests run under linux

* gpg and sha512 checks are valid

Felix



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



OpenPGP_0xEA6C3728EA91C4AF.asc
Description: OpenPGP public key


OpenPGP_signature
Description: OpenPGP digital signature


Re: [VOTE] Release Apache Tomcat 10.1.6

2023-02-20 Thread Felix Schumacher


Am 19.02.23 um 15:11 schrieb Christopher Schultz:

The proposed Apache Tomcat 10.1.6 release is now available for
voting.

The notable changes compared to 10.1.5 are:

- Switch to using the ServiceLoader mechanism to load the custom URL
  protocol handlers that Tomcat uses.

- Update the packaged version of the Apache Tomcat Native Library to
  2.0.3 to pick up the Windows binaries built with with OpenSSL 3.0.8.

- Add the shared address space specified by RFC 6598 (100.64.0.0/10)
  to the list of trusted proxies for RemoteIPValve/Filter.

- Limit access to examples web application to localhost by default


For full details, see the change log:
https://nightlies.apache.org/tomcat/tomcat-10.1.x/docs/changelog.html

Applications that run on Tomcat 9 and earlier will not run on Tomcat 
10 without changes. Java EE applications designed for Tomcat 9 and 
earlier may be placed in the $CATALINA_BASE/webapps-javaee directory 
and Tomcat will automatically convert them to Jakarta EE and copy them 
to the webapps directory.


It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.6/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1421

The tag is:
https://github.com/apache/tomcat/tree/10.1.6
9829c929059f96605a3fb870700b5887970d7203

The proposed 10.1.6 release is:
[ ] Broken - do not release
[x] Stable - go ahead and release as 10.1.6


* Builds and tests run under Linux

* gpg and sha512 sums are valid

The source tar seem to be missing two files, that might be important:
 res/META-INF/catalina.jar/services/java.net.spi.URLStreamHandlerProvider
 
res/META-INF/tomcat-embed-core.jar/services/java.net.spi.URLStreamHandlerProvider

(I accidentally tested the new IP filter for examples, that works :))

Felix



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



OpenPGP_0xEA6C3728EA91C4AF.asc
Description: OpenPGP public key


OpenPGP_signature
Description: OpenPGP digital signature


Re: [VOTE] Release Apache Tomcat 10.1.6

2023-02-20 Thread Mark Thomas

On 19/02/2023 14:11, Christopher Schultz wrote:

The proposed 10.1.6 release is:
[ ] Broken - do not release
[X] Stable - go ahead and release as 10.1.6


Build is reproducible.

Tests pass on Linux, Windows and MacOS (Intel and M1).

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [tomcat] branch main updated: Many improvements.

2023-02-20 Thread Mark Thomas

On 18/02/2023 05:43, Han Li wrote:




On Feb 17, 2023, at 17:17, Rémy Maucherat  wrote:

On Fri, Feb 17, 2023 at 4:32 AM  wrote:

-ciphers.removeAll(movedCiphers);
+movedCiphers.forEach(ciphers::remove);


Ok for some of them maybe, but I don't understand why one this is better.


See:https://www.baeldung.com/java-hashset-removeall-performance 

It’s just possible to avoid some potential performance issues. So i replaced 
old writing style with this. :)


Those performance issues are when the collection the items are being 
removed from is an ArrayList. These all look to be LinkedHashSet.


There may be a very small gain from these changes as it skips some logic 
in removeAll() that isn't necessary in these instances.


Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 66482] Nio2 websocket timeout cause the response is no longer possible, always pending

2023-02-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66482

--- Comment #3 from Mark Thomas  ---
It might be because 01f2cf25b270a84d0daeefc4f215aa2f56e1df99 also changed the
WebSocket implementation to use AsyncIO.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[tomcat] branch 9.0.x updated: Next is 9.0.73

2023-02-20 Thread remm
This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/9.0.x by this push:
 new 694a93a6d5 Next is 9.0.73
694a93a6d5 is described below

commit 694a93a6d504eeacabcb50a5c71d22df3b05b238
Author: remm 
AuthorDate: Mon Feb 20 10:29:26 2023 +0100

Next is 9.0.73
---
 build.properties.default | 2 +-
 res/maven/mvn.properties.default | 2 +-
 webapps/docs/changelog.xml   | 4 +++-
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/build.properties.default b/build.properties.default
index b8b995ad04..ca3470567b 100644
--- a/build.properties.default
+++ b/build.properties.default
@@ -31,7 +31,7 @@
 # - Version Control Flags -
 version.major=9
 version.minor=0
-version.build=72
+version.build=73
 version.patch=0
 version.suffix=
 version.dev=-dev
diff --git a/res/maven/mvn.properties.default b/res/maven/mvn.properties.default
index d0ab01a60b..be6d694eb4 100644
--- a/res/maven/mvn.properties.default
+++ b/res/maven/mvn.properties.default
@@ -39,7 +39,7 @@ 
maven.asf.release.repo.url=https://repository.apache.org/service/local/staging/d
 maven.asf.release.repo.repositoryId=apache.releases.https
 
 # Release version info
-maven.asf.release.deploy.version=9.0.72
+maven.asf.release.deploy.version=9.0.73
 
 #Where do we load the libraries from
 tomcat.lib.path=../../output/build/lib
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 18b99c9353..3dd14ddc59 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -104,7 +104,9 @@
   They eventually become mixed with the numbered issues (i.e., numbered
   issues do not "pop up" wrt. others).
 -->
-
+
+
+
   
 
   


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[tomcat] branch main updated: Increment version for next dev cycle

2023-02-20 Thread markt
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/main by this push:
 new d97bf3be48 Increment version for next dev cycle
d97bf3be48 is described below

commit d97bf3be48c81e184a023bcdaf7fab89cd5cc539
Author: Mark Thomas 
AuthorDate: Mon Feb 20 09:25:10 2023 +

Increment version for next dev cycle
---
 build.properties.default | 2 +-
 res/maven/mvn.properties.default | 2 +-
 webapps/docs/changelog.xml   | 4 +++-
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/build.properties.default b/build.properties.default
index 39619919c1..a8b61c5398 100644
--- a/build.properties.default
+++ b/build.properties.default
@@ -33,7 +33,7 @@ version.major=11
 version.minor=0
 version.build=0
 version.patch=0
-version.suffix=-M3
+version.suffix=-M4
 version.dev=-dev
 
 # - Build tools -
diff --git a/res/maven/mvn.properties.default b/res/maven/mvn.properties.default
index 83bae4e2e9..f51a4fab54 100644
--- a/res/maven/mvn.properties.default
+++ b/res/maven/mvn.properties.default
@@ -39,7 +39,7 @@ 
maven.asf.release.repo.url=https://repository.apache.org/service/local/staging/d
 maven.asf.release.repo.repositoryId=apache.releases.https
 
 # Release version info
-maven.asf.release.deploy.version=11.0.0-M3
+maven.asf.release.deploy.version=11.0.0-M4
 
 #Where do we load the libraries from
 tomcat.lib.path=../../output/build/lib
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 08cbc1fc49..60968d8d04 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -104,7 +104,9 @@
   They eventually become mixed with the numbered issues (i.e., numbered
   issues do not "pop up" wrt. others).
 -->
-
+
+
+
   
 
   


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 10.1.6

2023-02-20 Thread Mark Thomas

On 19/02/2023 18:15, Igal Sapir wrote:

I get a failure on TestImportHandlerStandardPackages on both Java 11 and
Java 17.  Any thoughts?  Output below:

Testsuite: jakarta.el.TestImportHandlerStandardPackages
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.319 sec


That suggests an issue with the test environment. The SingleThreadModel 
class was removed in 10.1.x. Maybe you need an "ant clean"?


Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 11.0.0-M3

2023-02-20 Thread Mark Thomas

On 17/02/2023 18:18, Mark Thomas wrote:

The proposed 11.0.0-M3 release is:
[ ] Broken - do not release
[X] Stable - go ahead and release as 11.0.0-M3


Still haven't remembered to update that to Alpha

Test pass on Linux, Windows and MacOS (Intel & M1).

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 66482] Nio2 websocket timeout cause the response is no longer possible, always pending

2023-02-20 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66482

Remy Maucherat  changed:

   What|Removed |Added

 OS||All

--- Comment #2 from Remy Maucherat  ---
Ok, so an exception was not really supposed to happen here, so there was no
try/finally in Nio2OperationState.start. Probably not a great idea.

However, I don't understand why the socket close backport would be related to
this. The Nio2OperationState.start and the rest were the same before that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org