[GitHub] [tomcat] markt-asf commented on pull request #594: Update CoyoteAdapter.java

2023-03-02 Thread via GitHub
markt-asf commented on PR #594: URL: https://github.com/apache/tomcat/pull/594#issuecomment-1453068854 Thanks for the PR. I understand the problem but this isn't the right fix. It will break apps when there are two session cookies and the second one is the only valid one. -- This is an

[GitHub] [tomcat] pangxianhai commented on pull request #594: Update CoyoteAdapter.java

2023-03-02 Thread via GitHub
pangxianhai commented on PR #594: URL: https://github.com/apache/tomcat/pull/594#issuecomment-1452803563 we have a problem at function parseSessionCookiesId. If the request has two JSESSIONID on the Cookie. The session will init twice. So request.isRequestedSessionIdValid() will be

[GitHub] [tomcat] pangxianhai opened a new pull request, #594: Update CoyoteAdapter.java

2023-03-02 Thread via GitHub
pangxianhai opened a new pull request, #594: URL: https://github.com/apache/tomcat/pull/594 we have a problem at function parseSessionCookiesId. If the request has two JSESSIONID on the Cookie. The session will init twice. So request.isRequestedSessionIdValid() will be invoked. But at

Buildbot success in on tomcat-11.0.x

2023-03-02 Thread buildbot
Build status: Build succeeded! Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/112/builds/234 Blamelist: Mark Thomas Build Text: build successful Status Detected: restored build Build Source Stamp: [branch main] 7322521761fd04d72348903d7177b6e6132ff289 Steps:

[tomcat] branch main updated: Remove unnecessary setting of java.protocol.handler.pkgs

2023-03-02 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 7322521761 Remove unnecessary setting of

Re: [VOTE] Release Apache Tomcat 10.1.7

2023-03-02 Thread Christopher Schultz
Mark, On 2/28/23 08:37, Mark Thomas wrote: On 27/02/2023 20:56, Christopher Schultz wrote: The proposed 10.1.7 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 10.1.7 The binary releases are reproducible. The source releases are not reproducible without manual

Buildbot failure in on tomcat-9.0.x

2023-03-02 Thread buildbot
Build status: BUILD FAILED: failed update (failure) Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/37/builds/480 Blamelist: Mark Thomas , remm Build Text: failed update (failure) Status Detected: new failure Build Source Stamp: [branch 9.0.x]

Buildbot failure in on tomcat-10.1.x

2023-03-02 Thread buildbot
Build status: BUILD FAILED: update (failure) Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/44/builds/697 Blamelist: Mark Thomas , remm Build Text: update (failure) Status Detected: new failure Build Source Stamp: [branch 10.1.x] e6fccf9e903371a156c317f2f0640833678e4cda

Buildbot failure in on tomcat-11.0.x

2023-03-02 Thread buildbot
Build status: BUILD FAILED: failed update (failure) Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/112/builds/233 Blamelist: Mark Thomas Build Text: failed update (failure) Status Detected: new failure Build Source Stamp: [branch main]

[tomcat] branch 8.5.x updated: Fix false positives

2023-03-02 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 576550f242 Fix false positives 576550f242 is

[tomcat] branch 9.0.x updated: Fix false positives

2023-03-02 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 5aa666143d Fix false positives 5aa666143d is

[tomcat] branch 10.1.x updated: Fix false positives

2023-03-02 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new e6fccf9e90 Fix false positives e6fccf9e90 is

[tomcat] branch main updated: Fix SpotBugs warnings

2023-03-02 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new a73234bf82 Fix SpotBugs warnings a73234bf82 is

[Bug 66507] New: Catalina version command not honoring JAVA_OPTS variable

2023-03-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66507 Bug ID: 66507 Summary: Catalina version command not honoring JAVA_OPTS variable Product: Tomcat 9 Version: 9.0.x Hardware: All OS: All

Buildbot success in on tomcat-10.1.x

2023-03-02 Thread buildbot
Build status: Build succeeded! Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/44/builds/696 Blamelist: Mark Thomas , remm Build Text: build successful Status Detected: restored build Build Source Stamp: [branch 10.1.x] f189c95f516872c61479ddbe7ddd7d062d13b03c Steps:

[Bug 66506] Information about Max Busy

2023-03-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66506 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 66506] New: Information about Max Busy

2023-03-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66506 Bug ID: 66506 Summary: Information about Max Busy Product: Tomcat Connectors Version: 1.2.48 Hardware: PC Status: NEW Severity: normal Priority: P2

Re: [tomcat] branch main updated: Improve JSON filter

2023-03-02 Thread Mark Thomas
On 02/03/2023 14:35, Rémy Maucherat wrote: On Thu, Mar 2, 2023 at 2:52 PM Mark Thomas wrote: On 02/03/2023 13:38, r...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. -private JSONFilter() { -// Utility class. Hide the default

[tomcat] branch 9.0.x updated: Cleanup

2023-03-02 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new af9d1afb2c Cleanup af9d1afb2c is described below

[tomcat] branch 8.5.x updated: Cleanup

2023-03-02 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 4d293d12c5 Cleanup 4d293d12c5 is described below

[tomcat] branch 10.1.x updated: Cleanup

2023-03-02 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 545f5be62a Cleanup 545f5be62a is described below

[tomcat] branch main updated: Cleanup

2023-03-02 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new bb7f13d6a5 Cleanup bb7f13d6a5 is described below

Re: [tomcat] branch main updated: Improve JSON filter

2023-03-02 Thread Rémy Maucherat
On Thu, Mar 2, 2023 at 2:52 PM Mark Thomas wrote: > > On 02/03/2023 13:38, r...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > > > remm pushed a commit to branch main > > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > > > > The

Re: [tomcat] branch main updated: Improve JSON filter

2023-03-02 Thread Mark Thomas
On 02/03/2023 13:38, r...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new

[tomcat] branch 8.5.x updated: Improve JSON filter

2023-03-02 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 002c502555 Improve JSON filter 002c502555 is

[tomcat] branch 9.0.x updated (1cf2da6665 -> 719550778f)

2023-03-02 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a change to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git from 1cf2da6665 Backport translation updates add 719550778f Improve JSON filter No new revisions were added by this

[tomcat] branch 10.1.x updated: Improve JSON filter

2023-03-02 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new f189c95f51 Improve JSON filter f189c95f51 is

[tomcat] branch main updated: Improve JSON filter

2023-03-02 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 50a9edfdb2 Improve JSON filter 50a9edfdb2 is

Re: [tomcat] branch 9.0.x updated: Fix BZ 65995 - Use text/javascript rather than application/javascript

2023-03-02 Thread Christopher Schultz
Mark, On 3/2/23 04:12, ma...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new

Buildbot failure in on tomcat-10.1.x

2023-03-02 Thread buildbot
Build status: BUILD FAILED: failed compile (failure) Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/44/builds/695 Blamelist: Mark Thomas Build Text: failed compile (failure) Status Detected: new failure Build Source Stamp: [branch 10.1.x]

[tomcat] 01/02: Alphabetical order

2023-03-02 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit a63e64836b6278b909929209a143d1072af5262c Author: Mark Thomas AuthorDate: Thu Mar 2 10:45:46 2023 + Alphabetical

[tomcat] 02/02: Backport translation updates

2023-03-02 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 11721b02bb93eb1ab9b7d718e9f95d0c668540d6 Author: Mark Thomas AuthorDate: Thu Mar 2 10:46:32 2023 + Backport

[tomcat] branch 8.5.x updated (3e5b45b342 -> 11721b02bb)

2023-03-02 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git from 3e5b45b342 Fix formatting imported values that have multiple lines starting with \t new a63e64836b Alphabetical

[tomcat] 01/02: Alphabetical order

2023-03-02 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit bbeb3e9ed889b07eefd1a99a35ef740aa0d0a186 Author: Mark Thomas AuthorDate: Thu Mar 2 10:43:46 2023 + Alphabetical

[tomcat] branch 9.0.x updated (767476afc3 -> 1cf2da6665)

2023-03-02 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git from 767476afc3 Fix formatting imported values that have multiple lines starting with \t new bbeb3e9ed8 Alphabetical

[tomcat] 02/02: Backport translation updates

2023-03-02 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 1cf2da6665c67c5680560dec6f94d8591fdf588a Author: Mark Thomas AuthorDate: Thu Mar 2 10:44:28 2023 + Backport

[tomcat] 03/03: Improvements to Chinese translations. Contributed by totoo.

2023-03-02 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 22a05a719f213d37e40853856ad4dc3b30213e95 Author: Mark Thomas AuthorDate: Thu Mar 2 10:41:57 2023 + Improvements

[tomcat] 01/03: Improvements to French translations. (remm)

2023-03-02 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 875d86388f5cc9bf63ec3092a3780a42c43115f4 Author: Mark Thomas AuthorDate: Thu Mar 2 10:39:21 2023 + Improvements

[tomcat] 02/03: Improvements to Japanese translations. Contributed by Shirayuking.

2023-03-02 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit b014bf9029540f196fd93f86d7c07853271c58de Author: Mark Thomas AuthorDate: Thu Mar 2 10:41:04 2023 + Improvements

[tomcat] branch 10.1.x updated (8b1fd0605e -> 22a05a719f)

2023-03-02 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git from 8b1fd0605e Fix formatting imported values that have multiple lines starting with \t new 875d86388f Improvements

[tomcat] branch 10.1.x updated: Fix formatting imported values that have multiple lines starting with \t

2023-03-02 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 8b1fd0605e Fix formatting imported values that

[tomcat] branch 8.5.x updated: Fix formatting imported values that have multiple lines starting with \t

2023-03-02 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 3e5b45b342 Fix formatting imported values that

[tomcat] branch 9.0.x updated: Fix formatting imported values that have multiple lines starting with \t

2023-03-02 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 767476afc3 Fix formatting imported values that

[Bug 65995] Change JavaScript MIME type from application/javascript to text/javascript

2023-03-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65995 --- Comment #5 from Alexander Veit --- This change is also in accordance with RFC 9239: 'IANA has added the note "OBSOLETED in favor of text/javascript" to all registrations except "text/javascript"; that is, this note has been added to the

[Bug 66502] tomcat-jdbc ConnectionPool.returnConnection() accept closed connections

2023-03-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66502 Mark Thomas changed: What|Removed |Added Target Milestone|-- |--- Version|10.1.6

[Bug 65995] Change JavaScript MIME type from application/javascript to text/javascript

2023-03-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65995 Mark Thomas changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|---

[tomcat] branch 8.5.x updated: Fix BZ 65995 - Use text/javascript rather than application/javascript

2023-03-02 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new a94459d811 Fix BZ 65995 - Use text/javascript

[tomcat] branch 9.0.x updated: Fix BZ 65995 - Use text/javascript rather than application/javascript

2023-03-02 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 2506a9826f Fix BZ 65995 - Use text/javascript

[tomcat] branch 10.1.x updated: Fix BZ 65995 - Use text/javascript rather than application/javascript

2023-03-02 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 8435963696 Fix BZ 65995 - Use text/javascript

[tomcat] branch main updated: Fix BZ 65995 - Use text/javascript rather than application/javascript

2023-03-02 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new eb3d4bf875 Fix BZ 65995 - Use text/javascript rather

[Bug 66505] Calling [asyncPostProcess()] is not valid for a request with Async state [ERROR]

2023-03-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66505 Mark Thomas changed: What|Removed |Added Severity|critical|normal --- Comment #2 from Mark Thomas

[Bug 66505] Calling [asyncPostProcess()] is not valid for a request with Async state [ERROR]

2023-03-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66505 Mark Thomas changed: What|Removed |Added OS||All Status|NEW

[tomcat] branch 9.0.x updated: Add missing line from change log entry

2023-03-02 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 135f49bdf9 Add missing line from change log entry