Re: svn commit: r1348762 - in /tomcat/trunk: java/org/apache/catalina/valves/ErrorReportValve.java test/org/apache/catalina/valves/TestErrorReportValve.java

2012-06-11 Thread Christopher Schultz
Mark, On 6/11/12 5:24 AM, ma...@apache.org wrote: Author: markt Date: Mon Jun 11 09:24:53 2012 New Revision: 1348762 URL: http://svn.apache.org/viewvc?rev=1348762view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=53071 Stepping through the code, light dawns as to what

[OT] Subversion and recording bugzilla bug ids

2012-06-14 Thread Christopher Schultz
All, Since I know we've got some infra folks on this list but I'm not on the infra mailing list, I hope nobody minds if I ask here: When I do an svn commit to the ASF repository, one of the options (in Eclipse) is to provide a Bugzilla bug id. Can anyone tell me what svn plug-in (or whatever) is

Re: [Proposal] Preparatory refactoring for Resource handling refactoring

2012-06-18 Thread Christopher Schultz
Mark, On 6/15/12 1:00 PM, Mark Thomas wrote: Since this is fairly major work, any objections before I start? I like the unification of all these things. Would this be a good time to consider making Tomcat 7 RTC with such a significant change to the core of the trunk? -chris signature.asc

[OT] Moving entire directory structures in svn

2012-06-25 Thread Christopher Schultz
All, I apologize for another OT post to the dev list, but I know there are svn experts here and it's somewhat relevant. I have a project, recently migrated from CVS to SVN, and one of the things I'd like to be able to do that I couldn't do in CVS is to re-name files and do it all in one Big

Re: [OT] Moving entire directory structures in svn

2012-06-25 Thread Christopher Schultz
Mark, On 6/25/12 12:45 PM, Mark Thomas wrote: On 25/06/2012 17:42, Christopher Schultz wrote: $ mkdir src/newpackage $ svn add src/newpackage Skip the above 2 lines I'm actually introducing a new directory into the mix -- not just renaming but also putting the newly-moved files

Get-and-set with JMXProxyServlet

2012-07-03 Thread Christopher Schultz
All, I have a slight interest in implementing either a get-and-set or get-and-invoke (or both) in JMXProxyServlet. While it is easy to script get-then-set (or get-then-invoke), I'd like to be able to, with a single URL, get one value and (for example) reset the value to zero (or call something

Missing classes in stock 5.5.35 JARs?

2012-07-11 Thread Christopher Schultz
All, http://stackoverflow.com/questions/11427522/ssl-configuration-getting-classpuretlsimplementation-jsse15factory-not-foun The SO poster is using 5.5.30 but the problem appears to still exist in 5.5.35 (latest). I downloaded the core Tomcat 5.5.35 tarball and none of the .jar files in there

Re: svn commit: r1371678 - in /tomcat/tc6.0.x/trunk: 53531.diff java/org/apache/catalina/startup/LocalStrings.properties src/

2012-08-10 Thread Christopher Schultz
Konstantin, On 8/10/12 8:07 AM, kkoli...@apache.org wrote: Author: kkolinko Date: Fri Aug 10 12:07:37 2012 New Revision: 1371678 URL: http://svn.apache.org/viewvc?rev=1371678view=rev Log: https://issues.apache.org/bugzilla/show_bug.cgi?id=53531 Followup to r1371355. Add missing message,

Re: svn commit: r1372002 - /tomcat/tc5.5.x/trunk/STATUS.txt

2012-08-12 Thread Christopher Schultz
Konstantin, On 8/11/12 3:26 PM, kkoli...@apache.org wrote: Author: kkolinko Date: Sat Aug 11 19:26:30 2012 New Revision: 1372002 URL: http://svn.apache.org/viewvc?rev=1372002view=rev Log: Update Christopher Schultz' proposal with an actual patch. I am keeping Christopher's vote

Back-porting versus brand-new patch

2012-08-13 Thread Christopher Schultz
All, Recently, I have made a proposal or to to back-port changes into Tomcat 6. In one case, Konstantin has (helpfully!) provided a new patch based upon several changes to trunk/TC7. In this case, is it more appropriate to apply the single patch to TC6 and ignore those patches made to trunk, or

Re: svn commit: r1372415 - /tomcat/tc6.0.x/trunk/STATUS.txt

2012-08-13 Thread Christopher Schultz
Konstantin, On 8/13/12 9:06 AM, kkoli...@apache.org wrote: Author: kkolinko @@ -178,12 +161,14 @@ PATCHES PROPOSED TO BACKPORT: Patch from 7.0.x should apply relatively cleanly, as it is very small: http://svn.apache.org/viewvc?view=revisionrevision=1041892 +1: schultz - -1:

Re: Back-porting versus brand-new patch

2012-08-13 Thread Christopher Schultz
Konstantin, On 8/13/12 3:26 PM, Konstantin Kolinko wrote: Regarding size of a patch: It is up to you. You do it in your own name. The lesser the patch the lesser are chances to screw it. But if you feel that something needs to be included as well, feel free to include it.

Re: error while shutting down tomcat

2012-08-14 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Ijlal, On 8/14/12 6:18 PM, Ijlal EL HAZITI wrote: I installed a wab application (sakai precisely) on a distant server remotely, but it doesn't start, and when I shutdown tomcat, I get that error: This is a question better targeted at the Tomcat

Re-factoring TLD parsing

2012-08-16 Thread Christopher Schultz
All, The first item in the TOMCAT-NEXT.txt is this: 1. Refactor the TLD parsing. TLDs are currently parsed twice. Once by Catalina looking for listeners and once by Jasper. I had a conversation in Vancouver with David Blevins about the scourge of JAR-scanning in general (in that case, we

Re: Re-factoring TLD parsing

2012-08-16 Thread Christopher Schultz
Sebb, On 8/16/12 7:11 PM, sebb wrote: On 16 August 2012 23:44, Christopher Schultz ch...@christopherschultz.net wrote: I had a conversation in Vancouver with David Blevins about the scourge of JAR-scanning in general (in that case, we were discussing annotation-processing) and I suggested

Re: Tomcat + j_security_check (JDBCRealm) + salt / jBCrypt

2012-08-27 Thread Christopher Schultz
Salek, On 8/20/12 3:31 PM, Salek Talangi wrote: Hi all, I just started using Tomcat+j_security_check (JDBCRealm) for Form-based Webapp-Login. I read [1] that only a few standard (MD5, SHA-1, MD2?) java.security.MessageDigest methods are supported, which isn't enough in times of (still)

Re: pooledconnection tccl?

2012-08-27 Thread Christopher Schultz
Filip, On 8/22/12 9:12 AM, Filip Hanik (mailing lists) wrote: I've thought about this, you see if it is using TCCL it will cause a memory leak on app reload as the app wont be unloaded due to the pool holding it. But I think we should make it an option It's always been my position that

Re: [Bug 53531] ExpandWar.expand does not check the return value of File.mkdir and File.mkdirs

2012-08-27 Thread Christopher Schultz
Mark, On 8/27/12 5:36 PM, bugzi...@apache.org wrote: https://issues.apache.org/bugzilla/show_bug.cgi?id=53531 Mark Thomas ma...@apache.org changed: What|Removed |Added

Re: [Bug 53531] ExpandWar.expand does not check the return value of File.mkdir and File.mkdirs

2012-08-28 Thread Christopher Schultz
Mark, On 8/27/12 7:57 PM, Mark Thomas wrote: On 28/08/2012 00:53, Christopher Schultz wrote: Mark, On 8/27/12 5:36 PM, bugzi...@apache.org wrote: https://issues.apache.org/bugzilla/show_bug.cgi?id=53531 Mark Thomas ma...@apache.org changed: What|Removed |Added

Re: Tomcat 5.5.36

2012-09-20 Thread Christopher Schultz
Jim, On 7/25/12 7:25 AM, Jim Jagielski wrote: On Jul 24, 2012, at 12:17 PM, Mark Thomas wrote: On 24/07/2012 14:40, Jim Jagielski wrote: Any interest in seeing a 5.5.36 release in the near future? We should to tie up the remaining loose ends before 5.5.x is EOL. No great rush at the

Re: to improve the performance of form-based upload for Tomcat 7

2012-09-25 Thread Christopher Schultz
Link, On 9/25/12 10:14 AM, Fastupload wrote: What's the right org that I can apply a commuter account of apache open source project? Committers are invited by the current group of active participants. The best way to be invited is to become active in the community (i.e. this mailing list

Re: WebClassLoader using SystemClassLoader to load ServletDef?

2012-09-25 Thread Christopher Schultz
Elgs, On 9/25/12 1:15 PM, Elgs Chen wrote: Hi Mark, I finally get my homework done. Thank you so much for pointing me to the right direction. That really helped me to gain huge insight into the inner world of the tomcat. I used JPDA to attach my eclipse to tomcat. Then I was able to

Re: svn commit: r1381633 - in /tomcat/trunk: java/org/apache/catalina/manager/JMXProxyServlet.java webapps/docs/manager-howto.xml

2012-10-02 Thread Christopher Schultz
Mark, On 10/2/12 5:16 AM, Mark Thomas wrote: On 15/09/2012 23:02, Mark Thomas wrote: On 06/09/2012 16:02, schu...@apache.org wrote: Author: schultz Date: Thu Sep 6 15:02:42 2012 New Revision: 1381633 URL: http://svn.apache.org/viewvc?rev=1381633view=rev Log: Added multi-op modes to

Re: svn commit: r1381633 - in /tomcat/trunk: java/org/apache/catalina/manager/JMXProxyServlet.java webapps/docs/manager-howto.xml

2012-10-02 Thread Christopher Schultz
Mark, On 10/2/12 12:16 PM, Christopher Schultz wrote: Mark, On 10/2/12 5:16 AM, Mark Thomas wrote: On 15/09/2012 23:02, Mark Thomas wrote: On 06/09/2012 16:02, schu...@apache.org wrote: Author: schultz Date: Thu Sep 6 15:02:42 2012 New Revision: 1381633 URL: http://svn.apache.org

Re: svn commit: r1381635 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/manager/JMXProxyServlet.java webapps/docs/changelog.xml webapps/docs/manager-howto.xml

2012-10-02 Thread Christopher Schultz
Mark, On 10/2/12 5:22 AM, Mark Thomas wrote: On 08/09/2012 14:37, Mark Thomas wrote: On 08/09/2012 11:52, Konstantin Kolinko wrote: 2012/9/6 schu...@apache.org: Author: schultz Date: Thu Sep 6 15:08:58 2012 New Revision: 1381635 URL: http://svn.apache.org/viewvc?rev=1381635view=rev

Re: trunk: An buffer exception in AccessLogValve.log(..)

2012-10-02 Thread Christopher Schultz
Konstantin, On 10/2/12 2:32 PM, Konstantin Kolinko wrote: Running current trunk + Nio connector + JDK 7u7, I see a lot of the following exceptions. It looks like there is some bug in AccessLogValve optimization when StringBuilder was replaced with a CharBuffer. A CharBuffer cannot grow

Re: trunk: An buffer exception in AccessLogValve.log(..)

2012-10-02 Thread Christopher Schultz
Konstantin, On 10/2/12 3:58 PM, Konstantin Kolinko wrote: 2012/10/2 Christopher Schultz ch...@christopherschultz.net: Konstantin, On 10/2/12 2:32 PM, Konstantin Kolinko wrote: Running current trunk + Nio connector + JDK 7u7, I see a lot of the following exceptions. It looks like

Surprising implementation of SSL.hasOp

2012-10-03 Thread Christopher Schultz
All, I was preparing a 6.0 patch for https://issues.apache.org/bugzilla/show_bug.cgi?id=53481 (Add support for OpenSSL SSLHonorCipherOrder) and I found a missing method SSL.hasOp that is used in trunk and 7.0. The javadoc for SSL.hasOp says: /** * Return true if SSL_OP_ if defined.

Re: Surprising implementation of SSL.hasOp

2012-10-03 Thread Christopher Schultz
Rainer, On 10/3/12 1:30 PM, Rainer Jung wrote: On 03.10.2012 18:02, Christopher Schultz wrote: Looking at the OpenSSL API (wow, I really miss javadoc), it doesn't appear that there's any function that can sniff the capabilities of the engine and check to see whether a particular option

Re: [VOTE] Release Apache Tomcat 7.0.32

2012-10-03 Thread Christopher Schultz
Mark, On 10/3/12 5:24 AM, Mark Thomas wrote: The proposed Apache Tomcat 7.0.32 release is now available for voting. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.32/ The Maven staging repo is:

Re: [VOTE] Release Apache Tomcat 7.0.32

2012-10-03 Thread Christopher Schultz
All, On 10/3/12 3:01 PM, Christopher Schultz wrote: I did however get a unit test failure: details below. I'll check to see if it is repeatable. Testsuite: org.apache.catalina.loader.TestWebappClassLoaderExecutorMemoryLeak A second run of this test (BIO, NIO, APR) shows that they all pass

Re: Surprising implementation of SSL.hasOp

2012-10-04 Thread Christopher Schultz
Rainer, On 10/3/12 2:49 PM, Christopher Schultz wrote: I like the idea of using a macro to compact the code a bit, but in spite of tcnative's use of macros that don't contain arguments for all data that will be operated on, I prefer to be explicit about mentioning all data that will be used

Re: Surprising implementation of SSL.hasOp

2012-10-04 Thread Christopher Schultz
Rainer, On 10/4/12 5:27 PM, Rainer Jung wrote: On 04.10.2012 23:14, Christopher Schultz wrote: For instance, we could use a technique similar to the above to set a static bitset: static int supported_ssl_opts = 0; initialize() { ... #ifdef SSL_OP_MICROSOFT_SESS_ID_BUG

Re: svn commit: r1394452 - in /tomcat/native/branches/1.1.x: java/org/apache/tomcat/jni/SSL.java java/overview.html xdocs/miscellaneous/changelog.xml

2012-10-05 Thread Christopher Schultz
Konstantin, On 10/5/12 7:33 AM, kkoli...@apache.org wrote: Author: kkolinko Date: Fri Oct 5 11:33:22 2012 New Revision: 1394452 URL: http://svn.apache.org/viewvc?rev=1394452view=rev Log: Followup to r1394343: Update javadoc for hasOp method. It seems that is the only place where this

Re: svn commit: r1394104 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/catalina/connector/ webapps/docs/ webapps/docs/config/

2012-10-05 Thread Christopher Schultz
Konstantin, On 10/5/12 8:45 AM, Konstantin Kolinko wrote: 2012/10/4 ma...@apache.org: Author: markt Date: Thu Oct 4 14:55:59 2012 New Revision: 1394104 URL: http://svn.apache.org/viewvc?rev=1394104view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48692 Provide option

Re: [Bug 53986] Comment end tag preceded directly by a dash causes JSP fail compilation

2012-10-09 Thread Christopher Schultz
All, On 10/9/12 6:07 PM, bugzi...@apache.org wrote: https://issues.apache.org/bugzilla/show_bug.cgi?id=53986 --- Comment #4 from Christopher Schultz ch...@christopherschultz.net --- (In reply to comment #3) Possible cause: r1381417 Reverting that patch resolves the issue in 7.0.x/trunk

Re: Time for 6.0.36?

2012-10-10 Thread Christopher Schultz
Mark, On 10/10/12 11:04 AM, Mark Thomas wrote: It has been just over 10 months since the last 6.0.x release. The change log is looking pretty lengthy. I think we need a release. If it's likely that there will be a long interval before the following release, I think I'd like to complete my work

Re: Time for 6.0.36?

2012-10-11 Thread Christopher Schultz
Konstantin, On 10/11/12 6:47 AM, Konstantin Kolinko wrote: 2012/10/10 Mark Thomas ma...@apache.org: It has been just over 10 months since the last 6.0.x release. The change log is looking pretty lengthy. I think we need a release. +1 2012/10/10 Christopher Schultz ch

Re: svn commit: r1408739 - in /tomcat/trunk: java/org/apache/catalina/startup/RealmRuleSet.java webapps/docs/config/systemprops.xml

2012-11-17 Thread Christopher Schultz
Mark, Apologies for the late reply. Please see comments inline. On 11/13/12 9:17 AM, ma...@apache.org wrote: Author: markt Date: Tue Nov 13 14:17:42 2012 New Revision: 1408739 URL: http://svn.apache.org/viewvc?rev=1408739view=rev Log: Fix

Re: Delete catalina.out

2012-11-17 Thread Christopher Schultz
Josh, On 11/15/12 2:45 PM, Josh Gooding wrote: That is the tomcat default log file. Nothing server wise will happen if you delete if that is your concern. It just removes that particular log file. I believe that you have to either be root and/or have the server stopped to remove the file

Re: svn commit: r1408739 - in /tomcat/trunk: java/org/apache/catalina/startup/RealmRuleSet.java webapps/docs/config/systemprops.xml

2012-11-17 Thread Christopher Schultz
Mark, On 11/17/12 8:04 PM, Christopher Schultz wrote: Apologies for the late reply. Please see comments inline. On 11/13/12 9:17 AM, ma...@apache.org wrote: Author: markt Date: Tue Nov 13 14:17:42 2012 New Revision: 1408739 URL: http://svn.apache.org/viewvc?rev=1408739view=rev Log: Fix

Re: [VOTE] Release Apache Tomcat 7.0.33

2012-11-21 Thread Christopher Schultz
Mark, On 11/18/12 6:34 PM, Mark Thomas wrote: The proposed Apache Tomcat 7.0.33 release is now available for voting. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.33/ The Maven staging repo is:

Re: Test failures with trunk/head

2012-11-21 Thread Christopher Schultz
Rainer, On 11/21/12 8:33 AM, Rainer Jung wrote: On 21.11.2012 13:34, Toby Hobson wrote: I'm trying to build the latest source code which I've checked out from http://svn.apache.org/repos/asf/tomcat/tc7.0.x/trunk. I created a build.properties file and I'm able to successfully build Tomcat

Re: Bug # 52529 on Tomcat 7.0.30 still rearing it's ugly head?

2012-11-30 Thread Christopher Schultz
Josh, On 11/30/12 3:47 PM, Josh Gooding wrote: Hey, I can do that: java.lang.NullPointerException at org.intermedix.emr.ui.AbstractComboBoxInfo.populateSortedMap(AbstractComboBoxInfo.java:48) at org.intermedix.emr.ui.AbstractComboBoxInfo.init(AbstractComboBoxInfo.java:21) at

Re: svn commit: r1417194 - in /tomcat/trunk/java/org/apache/tomcat/util/buf: ByteChunk.java CharChunk.java

2012-12-07 Thread Christopher Schultz
Mark, On 12/4/12 4:21 PM, ma...@apache.org wrote: +private int hashCode=0; +// did we compute the hashcode ? +private boolean hasHashCode = false; Should hashCode and hasHashCode be volatile? // Hash code +@Override +

Re: svn commit: r1417282 - in /tomcat/trunk/webapps/docs/config: ajp.xml executor.xml http.xml

2012-12-07 Thread Christopher Schultz
Konstantin, On 12/5/12 3:06 AM, Konstantin Kolinko wrote: 2012/12/5 Caldarale, Charles R chuck.caldar...@unisys.com: From: kkoli...@apache.org [mailto:kkoli...@apache.org] Subject: svn commit: r1417282 - in /tomcat/trunk/webapps/docs/config: ajp.xml executor.xml http.xml Author: kkolinko

Re: svn commit: r1420586 [1/48] - in /tomcat/site/trunk/docs/tomcat-7.0-doc: ./ api/ api/org/apache/catalina/ api/org/apache/catalina/ant/ api/org/apache/catalina/ant/jmx/ api/org/apache/catalina/auth

2012-12-12 Thread Christopher Schultz
Mark, On 12/12/12 4:42 AM, ma...@apache.org wrote: Author: markt Date: Wed Dec 12 09:32:51 2012 New Revision: 1420586 URL: http://svn.apache.org/viewvc?rev=1420586view=rev Log: Update website t.0.x docs to 7.0.34 Did we ever decide that the API Javadoc for javax.servlet was copywritten

Re: svn commit: r1420586 [1/48] - in /tomcat/site/trunk/docs/tomcat-7.0-doc: ./ api/ api/org/apache/catalina/ api/org/apache/catalina/ant/ api/org/apache/catalina/ant/jmx/ api/org/apache/catalina/auth

2012-12-12 Thread Christopher Schultz
Mark, On 12/12/12 3:13 PM, Mark Thomas wrote: On 12/12/2012 19:59, Christopher Schultz wrote: Mark, On 12/12/12 4:42 AM, ma...@apache.org wrote: Author: markt Date: Wed Dec 12 09:32:51 2012 New Revision: 1420586 URL: http://svn.apache.org/viewvc?rev=1420586view=rev Log: Update website

Re: Heads up: comments coming to live TC 7 docs

2012-12-20 Thread Christopher Schultz
Rainer, On 12/15/12 6:04 AM, Rainer Jung wrote: André, Chris, Chuck and Pid have moderator status. Every ASF committer is also a moderator if she logs in using her LDAP credentials. D'oh. I wish I had known that -- I wouldn't have created a separate set of credentials. Care to remove my

SSL compression / bug 54324

2012-12-21 Thread Christopher Schultz
All, https://issues.apache.org/bugzilla/show_bug.cgi?id=54324 The enhancement request (marked MAJOR) is to allow the APR connector to configure SSL_OP_NO_COMPRESSION in OpenSSL, disabling SSL compression even when it is supported by the client. This prevents CRIME attacks. My question is

Re: SSL compression / bug 54324

2012-12-21 Thread Christopher Schultz
All, On 12/21/12 10:37 AM, Christopher Schultz wrote: Since this is security-related, my preference is to disable SSL compression /by default/ and allow users to specifically enable it if necessary. But, this represents a change in default so I figured I'd ask. One more note which reverses my

Time for tcnative 1.1.25?

2012-12-21 Thread Christopher Schultz
All, There is a particular fix in tcnative-trunk ant the 1.1.x branch to the ssl.c::hasOp function that I'd like to get out there in the wild: there are now two Tomcat enhancements (one committed, one not yet committed) that rely upon it: https://issues.apache.org/bugzilla/show_bug.cgi?id=53481

Re: Heads up: comments coming to live TC 7 docs

2012-12-25 Thread Christopher Schultz
Rainer, On 12/24/12 7:02 AM, Rainer Jung wrote: On 23.12.2012 15:41, Konstantin Kolinko wrote: 2012/12/23 Caldarale, Charles R chuck.caldar...@unisys.com: From: Rainer Jung [mailto:rainer.j...@kippdata.de] Subject: Heads up: comments coming to live TC 7 docs I plan to add the comments

Re: PreDestroy annotation handling

2013-01-05 Thread Christopher Schultz
Konstantin, On 1/5/13 12:52 PM, Konstantin Kolinko wrote: 2) Calling PreDestroy methods if init() method fails. The specs say that - if @PostConstruct methods fail then nothing is called afterwards, and - if init() fails then destroy() is not called. I wonder whether failure of init()

Re: PreDestroy annotation handling

2013-01-05 Thread Christopher Schultz
Konstantin, On 1/5/13 6:31 PM, Konstantin Kolinko wrote: 2013/1/6 Christopher Schultz ch...@christopherschultz.net: On 1/5/13 12:52 PM, Konstantin Kolinko wrote: 2) Calling PreDestroy methods if init() method fails. The specs say that - if @PostConstruct methods fail then nothing is called

Re: svn commit: r1430577 - /tomcat/tc6.0.x/trunk/STATUS.txt

2013-01-08 Thread Christopher Schultz
Konstantin, On 1/8/13 5:25 PM, kkoli...@apache.org wrote: Author: kkolinko Date: Tue Jan 8 22:25:27 2013 New Revision: 1430577 URL: http://svn.apache.org/viewvc?rev=1430577view=rev Log: Move proposal into the correct section and vote Thanks for moving that; the stalled section has

Re: Rewrite functionality for 8

2013-01-09 Thread Christopher Schultz
Remy, On 1/9/13 10:04 AM, Remy Maucherat wrote: Hi, I ported a valve providing mod_rewrite functionality (most of it) for Tomcat 8, and committed it in the sandbox. This could be easily placed in the main repository, where it would provide an additional item in the new features department

Re: Time for tcnative 1.1.25?

2013-01-09 Thread Christopher Schultz
All, Bump: any interest? I'd roll it myself, but I've never done something like that and I'd need a large amount of hand-holding. Thanks, -chris On 12/21/12 3:54 PM, Christopher Schultz wrote: All, There is a particular fix in tcnative-trunk ant the 1.1.x branch to the ssl.c::hasOp

Re: [Bug 54406] NIO and BIO connectors handle unsupported SSL ciphers and sslEnabledProtocols differently

2013-01-14 Thread Christopher Schultz
Tim, On 1/13/13 5:13 PM, Tim Whittington wrote: On Mon, Jan 14, 2013 at 11:10 AM, bugzi...@apache.org wrote: https://issues.apache.org/bugzilla/show_bug.cgi?id=54406 --- Comment #2 from Tim Whittington t...@apache.org --- Fixed in trunk and in 7.0.x and will be included in 7.0.36 onwards.

Re: svn commit: r1432753 - in /tomcat/tc7.0.x/trunk: java/org/apache/tomcat/util/net/ java/org/apache/tomcat/util/net/jsse/ java/org/apache/tomcat/util/net/jsse/res/ webapps/docs/ webapps/docs/config/

2013-01-14 Thread Christopher Schultz
Tim, Repeating my comment on your BZ comment: On 1/13/13 5:08 PM, t...@apache.org wrote: Modified: tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/SSLUtil.java URL:

Re: svn commit: r1432753 - in /tomcat/tc7.0.x/trunk: java/org/apache/tomcat/util/net/ java/org/apache/tomcat/util/net/jsse/ java/org/apache/tomcat/util/net/jsse/res/ webapps/docs/ webapps/docs/config/

2013-01-15 Thread Christopher Schultz
Mark, On 1/15/13 4:11 AM, Mark Thomas wrote: On 15/01/2013 00:53, Christopher Schultz wrote: Tim, Repeating my comment on your BZ comment: On 1/13/13 5:08 PM, t...@apache.org wrote: Modified: tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/SSLUtil.java URL: http://svn.apache.org

Disable TLS compression in JSSE

2013-01-15 Thread Christopher Schultz
All, I'm working on a fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=54324 which is requesting the ability to disable TLS compression in the APR connector. If possible, I'd like to write a patch that will work for both kinds of connectors: those based upon JSSE And those based upon

Missing tc6.0.x mergeinfo

2013-01-17 Thread Christopher Schultz
All, Due to my own negligence with merging in the past, tc6.0.x/trunk is missing some specific mergeinfo. While preparing a back-port today, I noticed that there was some old, uncommitted mergeinfo: Merged /tomcat/trunk:r1041892,1043983,1049264 Those commits were from a while back. Shall I

Re: svn commit: r1434905 - /tomcat/trunk/java/org/apache/tomcat/jni/SSL.java

2013-01-17 Thread Christopher Schultz
Mark, On 1/17/13 3:41 PM, ma...@apache.org wrote: Author: markt Date: Thu Jan 17 20:41:19 2013 New Revision: 1434905 URL: http://svn.apache.org/viewvc?rev=1434905view=rev Log: Trailing whitespace police Do you have any idea how to get Eclipse to stop adding that crap? It's obviously

Re: svn commit: r1434905 - /tomcat/trunk/java/org/apache/tomcat/jni/SSL.java

2013-01-17 Thread Christopher Schultz
Mark, On 1/17/13 4:28 PM, Mark Thomas wrote: On 17/01/2013 21:07, Christopher Schultz wrote: Mark, On 1/17/13 3:41 PM, ma...@apache.org wrote: Author: markt Date: Thu Jan 17 20:41:19 2013 New Revision: 1434905 URL: http://svn.apache.org/viewvc?rev=1434905view=rev Log: Trailing

Re: SSL compression / bug 54324

2013-01-22 Thread Christopher Schultz
Konstantin, On 1/21/13 4:25 AM, Konstantin Kolinko wrote: 2012/12/22 Rainer Jung rainer.j...@kippdata.de: On 21.12.2012 16:37, Christopher Schultz wrote: All, https://issues.apache.org/bugzilla/show_bug.cgi?id=54324 The enhancement request (marked MAJOR) is to allow the APR connector

Re: [VOTE] Release Apache Tomcat Native 1.1.25

2013-01-23 Thread Christopher Schultz
Jean-Frederic, On 1/23/13 12:34 PM, jean-frederic clere wrote: Version 1.1.25 is bug fixing release. The proposed release artefacts can be found at [1], and the build was done using tag [2]. The VOTE will remain open for at least 48 hours. The Apache Tomcat Native 1.1.25 is [ ] Stable,

Re: Disable TLS compression in JSSE

2013-01-23 Thread Christopher Schultz
Tim, On 1/22/13 8:13 PM, Tim Whittington wrote: As far as I know, JSSE doesn't support compression. [1] claims this, but doesn't have a reference, and I can't find anything else useful on the internet, although i recall an analysis of the CRIME attack that claimed the same thing. Thanks --

Improvements to RealmBase

2013-01-23 Thread Christopher Schultz
All, I've been using securityfilter for a number of years. With the introduction of Servlet 3.0, the major reason for sf's existence has finally been made available to devs within a servlet container: drive-by logins. As I'm finally running on Tomcat 7 ;) I've been considering switching from

Re: [VOTE] Release Apache Tomcat Native 1.1.25

2013-01-23 Thread Christopher Schultz
Konstantin, On 1/23/13 7:50 PM, Konstantin Kolinko wrote: 2013/1/23 jean-frederic clere jfcl...@gmail.com: Version 1.1.25 is bug fixing release. The proposed release artefacts can be found at [1], and the build was done using tag [2]. The VOTE will remain open for at least 48 hours. The

Re: Confusion around tcnative

2013-01-28 Thread Christopher Schultz
Rainer, On 1/28/13 6:20 AM, Rainer Jung wrote: I'm a bit confused about tcnative and the various trunks and branches: 1) tcnative trunk vs. branch 1.1.x. It seems most updates are directly done to the branch. So trunk is outdated. On the other hand originally there were some updates to

Re: [ANN] New Tomcat committer: Violeta Georgieva (violetagg)

2013-01-31 Thread Christopher Schultz
Violeta, On 1/31/13 11:22 AM, Mark Thomas wrote: On behalf of the Tomcat committers I am pleased to announce that Violeta Georgieva (violetagg) has been voted in as a new Tomcat committer. Please join me in welcoming her. Welcome! Great work on your recent patches. I would have voted for

Re: [ANN] Apache Tomcat Native 1.1.27 released

2013-02-13 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 All, On 2/13/13 1:01 AM, Mladen Turk wrote: The Apache Tomcat team announces the immediate availability of Apache Tomcat Native 1.1.27 stable. It's worth mentioning that tcnative-1.1.27 is required in order to configure Tomcat for the following

Re: [ANN] Apache Tomcat Native 1.1.27 released

2013-02-14 Thread Christopher Schultz
Henri, On 2/14/13 4:14 AM, Henri Gomez wrote: I build Tomcat Native on various machine, CentOS 5/6, openSUSE/SLES and notice this error on CentOS 5.9 : /bin/sh /usr/lib/apr-1/build/libtool --silent --mode=compile gcc -pthread -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions

Re: [ANN] Apache Tomcat Native 1.1.27 released

2013-02-14 Thread Christopher Schultz
Henri, On 2/14/13 4:14 AM, Henri Gomez wrote: I build Tomcat Native on various machine, CentOS 5/6, openSUSE/SLES and notice this error on CentOS 5.9 : I was able to build using Debian Squeeze with APR 1.4.2 and OpenSSL 0.9.8o. $ ./configure --with-apr=/usr/bin --with-ssl=yes

Re: [ANN] Apache Tomcat Native 1.1.27 released

2013-02-20 Thread Christopher Schultz
Henri, On 2/14/13 4:14 AM, Henri Gomez wrote: I build Tomcat Native on various machine, CentOS 5/6, openSUSE/SLES and notice this error on CentOS 5.9 : On CentOS 6.2: First, some prerequisites: $ sudo yum install gcc make \ apr apr-devel \

Re: JarScanning

2013-02-26 Thread Christopher Schultz
Mark, On 2/21/13 8:34 AM, Mark Thomas wrote: JRE JARs. I think scanning of these should be made optional and disabled by default. This will reduce the list of JARs we have to maintain in jarsToSkip. I intend to implement this unless there are any objections. +1 Will you be checking the

Re: OT: No web-jsptaglibrary_2_2.xsd?

2013-03-02 Thread Christopher Schultz
Nick, On 3/1/13 9:29 PM, Nick Williams wrote: Perusing the Tomcat sources I noticed that there are JSP tag library XSD files web-jsptaglibrary_1_1.xsd, web-jsptaglibrary_1_2.xsd, web-jsptaglibrary_2_0.xsd and web-jsptaglibrary_2_1.xsd. However, the JSP version that Tomcat currently supports

Re: svn commit: r1458187 - in /tomcat/trunk/java/org/apache/tomcat/util/http/fileupload: ./ util/mime/Base64Decoder.java util/mime/MimeUtility.java

2013-03-21 Thread Christopher Schultz
Konstantin, On 3/19/13 6:09 AM, Konstantin Kolinko wrote: } else if (data[end - 1] == PADDING) { -b1 = DECODING_TABLE[data[end - 4]]; -b2 = DECODING_TABLE[data[end - 3]]; -b3 = DECODING_TABLE[data[end - 2]]; +b1 =

Re: [Bug 54721] New: RemoteEndpoint blocks indefinitely if sendObject called with BinaryStream of TextStream encoders

2013-03-21 Thread Christopher Schultz
Nick, On 3/18/13 6:03 PM, Nick Williams wrote: I've been busy fleshing out all kinds of problems. :-) Careful: you might inadvertently become the babysitter of Tomcat's Websocket implementation. -chris signature.asc Description: OpenPGP digital signature

Re: [Tomcat Wiki] Update of LocalBadContent by ChuckCaldarale

2013-03-21 Thread Christopher Schultz
Mark, +1 on locking-down the wiki, at least for a short period of time. On 3/19/13 7:04 PM, Mark Thomas wrote: On 19/03/2013 23:02, sebb wrote: On 18 March 2013 21:54, Mark Thomas ma...@apache.org wrote: I'll note that while the spammers entries to the wiki get removed pretty quickly

Re: Wiki (was: Update of LocalBadContent)

2013-03-21 Thread Christopher Schultz
Konstantin, On 3/20/13 8:36 AM, Konstantin Kolinko wrote: Previous discussions: [2] (Jun 2011) http://tomcat.markmail.org/thread/nndyb3elaee6nduv [3] (Dec 2011) http://tomcat.markmail.org/thread/llawwzb4jxgwbt6z +0. It is a bit of a pity, but I would not oppose the change. I'd say that

Re: Adding Connectors

2013-03-21 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Steffen, I think this should be discussed on the users' list. I'm cross-posting this message one time for that purpose. See below. On 3/21/13 9:59 AM, Steffen Heil (Mailinglisten) wrote: I have a servlet that creates a new Connector and adds it

Re: OT: Will web containers be required to implement WebSockets

2013-03-21 Thread Christopher Schultz
Nick, On 3/21/13 10:17 AM, Nicholas Williams wrote: I know that WebSockets will be a part of the Java EE 7 specification for full application servers. But will web containers also be required to implement this? Or will it be optional, and Tomcat is just being nice? :-) Do you mean will the

Re: svn commit: r1458187 - in /tomcat/trunk/java/org/apache/tomcat/util/http/fileupload: ./ util/mime/Base64Decoder.java util/mime/MimeUtility.java

2013-03-21 Thread Christopher Schultz
Konstantin, On 3/21/13 10:18 AM, Konstantin Kolinko wrote: 2013/3/21 Christopher Schultz ch...@christopherschultz.net: Konstantin, On 3/19/13 6:09 AM, Konstantin Kolinko wrote: } else if (data[end - 1] == PADDING) { -b1 = DECODING_TABLE[data[end - 4]]; -b2

Re: Getting my head around NIO 'simulated' blocking (trying to)

2013-03-27 Thread Christopher Schultz
Igaz, On 3/24/13 11:46 PM, igaz wrote: You need to read the Javadoc more carefully. I suggest you take a look at java.io.ByteArrayInputStream (both source and javadoc). Perfectly good InputStream (never heard anyone claim otherwise) Never blocks. Yes, but it doesn't really follow the NIO

Re: [VOTE] Release Apache Tomcat 7.0.40

2013-05-07 Thread Christopher Schultz
Mark, On 5/5/13 6:44 AM, Mark Thomas wrote: The proposed Apache Tomcat 7.0.40 release is now available for voting. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.40/ The Maven staging repo is:

Re: [VOTE] Release Apache Tomcat 7.0.40

2013-05-07 Thread Christopher Schultz
Mark, On 5/7/13 3:43 PM, Christopher Schultz wrote: - Validate target shows no warnings (though checkstyle is not run for some reason -- I'll investigate) Okay, checkstyle runs, now nary a warning. -chris signature.asc Description: OpenPGP digital signature

Re: Automatic deployment changes

2013-05-07 Thread Christopher Schultz
Mark, On 5/7/13 8:54 AM, Mark Thomas wrote: In an attempt to improve the situation, I have tried to document a proposed expected behaviour [4]. Cool. Two question: 1. What is the difference between Y/N and - in a column? Y/N seems to mean does not matter. Does - mean does not apply? If both

Re: svn commit: r1479953 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/http/parser/HttpParser.java test/org/apache/tomcat/util/http/parser/TestMediaType.java webapps/docs/changelog.xml

2013-05-08 Thread Christopher Schultz
Mark, On 5/7/13 11:54 AM, ma...@apache.org wrote: Author: markt Date: Tue May 7 15:54:36 2013 New Revision: 1479953 URL: http://svn.apache.org/r1479953 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54703 Be tolerant of applications that pass CR or LF in setHeader() values.

Re: svn commit: r1479953 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/http/parser/HttpParser.java test/org/apache/tomcat/util/http/parser/TestMediaType.java webapps/docs/changelog.xml

2013-05-08 Thread Christopher Schultz
Mark, On 5/8/13 10:08 AM, Mark Thomas wrote: On 08/05/2013 14:22, Christopher Schultz wrote: Mark, On 5/7/13 11:54 AM, ma...@apache.org wrote: Author: markt Date: Tue May 7 15:54:36 2013 New Revision: 1479953 URL: http://svn.apache.org/r1479953 Log: Fix https://issues.apache.org

Re: Automatic deployment changes

2013-05-08 Thread Christopher Schultz
Mark, On 5/7/13 5:05 PM, Mark Thomas wrote: On 07/05/2013 21:13, Christopher Schultz wrote: Mark, On 5/7/13 8:54 AM, Mark Thomas wrote: In an attempt to improve the situation, I have tried to document a proposed expected behaviour [4]. Cool. Two question: 1. What is the difference

Re: Automatic deployment changes

2013-05-14 Thread Christopher Schultz
Mark, On 5/13/13 3:35 AM, Mark Thomas wrote: On 08/05/2013 15:18, Christopher Schultz wrote: Perhaps I should clarify my question with an example: what happens when a WAR file is found and a DIR also exists with the same context name, but expandWars is false? Does the directory get updated

Re: OT: How do I subscribe to the Tomcat Dev/User lists with my @apache.org address?

2013-05-14 Thread Christopher Schultz
Nick, On 5/14/13 6:35 PM, Nick Williams wrote: I recently became a committer on the Logging project and thus I now have an @apache.org address. Since it's a forwarding address, I'm having it forward to my Google Apps email address (the address I'm sending from now). I'd like to subscribe

Re: Automatic deployment changes

2013-05-22 Thread Christopher Schultz
Mark, On 5/17/13 3:04 PM, Mark Thomas wrote: On 16/05/2013 21:50, Mark Thomas wrote: The final (for now) changes are: 1. unpackWARs now applies to external WARs as well as WARs located in the Host's appBase. 2. If a WAR is modified (located in the Host's appBase or externally) and

Re: Automatic deployment changes

2013-05-22 Thread Christopher Schultz
Mark, On 5/17/13 3:25 PM, Mark Thomas wrote: On 17/05/2013 20:22, Caldarale, Charles R wrote: From: Mark Thomas [mailto:ma...@apache.org] Subject: Re: Automatic deployment changes 3. A warning is generate if a DIR in the appBase is ignored because there is a matching WAR and

Re: [PATCH] jdbc-pool | FairBlockingQueue

2013-05-24 Thread Christopher Schultz
Björn, On 5/24/13 4:08 PM, Björn Raupach wrote: out of pure curiosity I was browsing the source of jdbc-pool and ended up looking through FairBlockingQueue. FairBlockingQueue utilises a global ReentrantLock for mutual exclusion. Common practice is to always follow a call to lock with a

Re: APR/native errors with non-blocking I/O

2013-05-31 Thread Christopher Schultz
Rainer, On 5/31/13 4:35 PM, Rainer Jung wrote: On 31.05.2013 21:34, Mark Thomas wrote: Caldarale, Charles R chuck.caldar...@unisys.com wrote: From: Mark Thomas [mailto:ma...@apache.org] Subject: APR/native errors with non-blocking I/O Assuming these are negative errno values: On OSX the

Re: APR/native errors with non-blocking I/O

2013-05-31 Thread Christopher Schultz
Chuck, On 5/31/13 4:42 PM, Caldarale, Charles R wrote: From: Rainer Jung [mailto:rainer.j...@kippdata.de] Subject: Re: APR/native errors with non-blocking I/O Compile and have fun. Or we could talk about Mark's familiarity with C :-) IMHO we don't have that in the code to output text

Re: APR/native errors with non-blocking I/O

2013-06-03 Thread Christopher Schultz
Chuck, On 5/31/13 5:46 PM, Caldarale, Charles R wrote: From: Christopher Schultz [mailto:ch...@christopherschultz.net] Subject: Re: APR/native errors with non-blocking I/O I'm pretty sure that sterror is thread safe: it should just return a static char*. Would that it were that simple

<    1   2   3   4   5   6   7   8   9   10   >