zhanhb edited a comment on issue #172: Process request range as specified in
RFC 7233
URL: https://github.com/apache/tomcat/pull/172#issuecomment-504711376
RFC 7233 `If-Range should be compared with strong validator.` This can't be
applied. I test on chrome 75 and find Header `If-Range`
zhanhb edited a comment on issue #172: Process request range as specified in
RFC 7233
URL: https://github.com/apache/tomcat/pull/172#issuecomment-504711376
RFC 7233 says `If-Range should be compared with strong validator.` This
can't be applied. I test on chrome 75 and find Header
zhanhb edited a comment on issue #172: Process request range as specified in
RFC 7233
URL: https://github.com/apache/tomcat/pull/172#issuecomment-504718438
Before I write unit tests, maybe I need to explain what I my PR do.
-
zhanhb edited a comment on issue #172: Process request range as specified in
RFC 7233
URL: https://github.com/apache/tomcat/pull/172#issuecomment-504718438
Before I write unit tests, maybe I need to explain what I my PR do.
-
zhanhb edited a comment on issue #172: Process request range as specified in
RFC 7233
URL: https://github.com/apache/tomcat/pull/172#issuecomment-504718438
Before I write unit tests, maybe I need to explain what I my PR do.
-
zhanhb edited a comment on issue #172: Process request range as specified in
RFC 7233
URL: https://github.com/apache/tomcat/pull/172#issuecomment-504718438
Before I write unit tests, maybe I need to explain what I my PR do.
[Line
zhanhb commented on issue #172: Process request range as specified in RFC 7233
URL: https://github.com/apache/tomcat/pull/172#issuecomment-504726789
I search the source in
zhanhb edited a comment on issue #172: Process request range as specified in
RFC 7233
URL: https://github.com/apache/tomcat/pull/172#issuecomment-504726789
I search the source in
zhanhb edited a comment on issue #172: Process request range as specified in
RFC 7233
URL: https://github.com/apache/tomcat/pull/172#issuecomment-504711376
RFC 7233 `If-Range should be compared with strong validator.` This can't be
applied. I test on chrome 75 and find Header `If-Range`
zhanhb edited a comment on issue #172: Process request range as specified in
RFC 7233
URL: https://github.com/apache/tomcat/pull/172#issuecomment-504718438
Before I write unit tests, maybe I need to explain what I my PR do.
- [Line
zhanhb edited a comment on issue #172: Process request range as specified in
RFC 7233
URL: https://github.com/apache/tomcat/pull/172#issuecomment-504718438
Before I write unit tests, maybe I need to explain what I my PR do.
- [Line
zhanhb edited a comment on issue #172: Process request range as specified in
RFC 7233
URL: https://github.com/apache/tomcat/pull/172#issuecomment-504718438
Before I write unit tests, maybe I need to explain what I my PR do.
-
zhanhb edited a comment on issue #172: Process request range as specified in
RFC 7233
URL: https://github.com/apache/tomcat/pull/172#issuecomment-504718438
Before I write unit tests, maybe I need to explain what I my PR do.
-
zhanhb edited a comment on issue #172: Process request range as specified in
RFC 7233
URL: https://github.com/apache/tomcat/pull/172#issuecomment-504718438
Before I write unit tests, maybe I need to explain what I my PR do.
-
zhanhb edited a comment on issue #172: Process request range as specified in
RFC 7233
URL: https://github.com/apache/tomcat/pull/172#issuecomment-504718438
Before I write unit tests, maybe I need to explain what I my PR do.
-
zhanhb edited a comment on issue #172: Process request range as specified in
RFC 7233
URL: https://github.com/apache/tomcat/pull/172#issuecomment-504718438
Before I write unit tests, maybe I need to explain what I my PR do.
-
zhanhb edited a comment on issue #172: Process request range as specified in
RFC 7233
URL: https://github.com/apache/tomcat/pull/172#issuecomment-504718438
Before I write unit tests, maybe I need to explain what I my PR do.
-
zhanhb commented on issue #172: Process request range as specified in RFC 7233
URL: https://github.com/apache/tomcat/pull/172#issuecomment-504711376
RFC 7233 `If-Range should be compared with strong validator.` This can't be
applied. I test on chrome 75 and find Head If-Range is sent.
zhanhb opened a new pull request #175: Apply the suggestion in rfc7233
URL: https://github.com/apache/tomcat/pull/175
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
zhanhb opened a new pull request #174: Clean method parseRange
URL: https://github.com/apache/tomcat/pull/174
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
zhanhb edited a comment on issue #172: Process request range as specified in
RFC 7233
URL: https://github.com/apache/tomcat/pull/172#issuecomment-504718438
Before I write unit tests, maybe I need to explain what I my PR do.
-
markt-asf closed pull request #5: Add support for TLS key logging
URL: https://github.com/apache/tomcat-native/pull/5
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
markt-asf closed pull request #2: Port Netty-tc-native code to tomcat-native
URL: https://github.com/apache/tomcat-native/pull/2
This is an automated message from the Apache Git Service.
To respond to the message, please log
markt-asf closed pull request #4: Fixing Client Certificate Based
Authentication for Certificates without OCSP OID id-ad-ocsp
URL: https://github.com/apache/tomcat-native/pull/4
This is an automated message from the Apache
markt-asf closed pull request #1: Fixed a bug with File.infoGet() and
File.getInfo() methods that sometime...
URL: https://github.com/apache/tomcat-native/pull/1
This is an automated message from the Apache Git Service.
To
markt-asf closed pull request #3: scripts, maven pom.xml and class to help to
load libraries from a jar
URL: https://github.com/apache/tomcat-native/pull/3
This is an automated message from the Apache Git Service.
To
markt-asf commented on issue #5: Add support for TLS key logging
URL: https://github.com/apache/tomcat-native/pull/5#issuecomment-503127024
Re-opening after auto-close due to repo changes made during migration from
svn to git.
If you are able to rebase this PR against master rather than
johnkdev opened a new pull request #5: Add support for TLS key logging
URL: https://github.com/apache/tomcat-native/pull/5
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
rmaucher opened a new pull request #163: Remove multiple pollers from NIO
URL: https://github.com/apache/tomcat/pull/163
NIO2 manages without it, so it should work fine overall. This allows
removing a lot of complexity and disconnect between channel <-> wrapper
<-> poller, as both now
farnulfo opened a new pull request #164: Create .travis.yml
URL: https://github.com/apache/tomcat/pull/164
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
farnulfo closed pull request #164: Create .travis.yml
URL: https://github.com/apache/tomcat/pull/164
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
rmaucher commented on issue #163: Remove multiple pollers from NIO
URL: https://github.com/apache/tomcat/pull/163#issuecomment-491806081
Commited as e813ae0d9329ebf4b95c02043c39c676edb47d3c since nobody complained
about it.
rmaucher closed pull request #163: Remove multiple pollers from NIO
URL: https://github.com/apache/tomcat/pull/163
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
farnulfo commented on issue #165: Implementation of SameSite cookie attribute
URL: https://github.com/apache/tomcat/pull/165#issuecomment-491922297
I'm really sorry I didn't see the PR
https://github.com/apache/tomcat/pull/162 .
I closed mine.
farnulfo closed pull request #165: Implementation of SameSite cookie attribute
URL: https://github.com/apache/tomcat/pull/165
This is an automated message from the Apache Git Service.
To respond to the message, please log
farnulfo opened a new pull request #165: Implementation of SameSite cookie
attribute
URL: https://github.com/apache/tomcat/pull/165
# Introduction
Hi folks, this pull request is an attemp to implement the SameSite cookie
attribute according to
ChristopherSchultz commented on issue #162: Add support for same-site cookie
attribute
URL: https://github.com/apache/tomcat/pull/162#issuecomment-491889201
Thank you for the proposed patch.
Understanding that changing the definition of a class in the `javax.servlet`
namespace
markt-asf commented on issue #162: Add support for same-site cookie attribute
URL: https://github.com/apache/tomcat/pull/162#issuecomment-491875787
Sorry, any new configuration option needs to be added to the docs as well.
markt-asf commented on issue #162: Add support for same-site cookie attribute
URL: https://github.com/apache/tomcat/pull/162#issuecomment-491890888
We have no latitude to change any part of a spec API. Being able to set a
default for this is better than not being able to set anything at
markt-asf commented on issue #162: Add support for same-site cookie attribute
URL: https://github.com/apache/tomcat/pull/162#issuecomment-491869493
The configuration should be on the CookieProcessor, not the Context. We also
need to look at https://scotthelme.co.uk/tough-cookies/ but that
johnkdev commented on issue #162: Add support for same-site cookie attribute
URL: https://github.com/apache/tomcat/pull/162#issuecomment-492171504
I've moved the configuration to CookieProcessor and updated the docs.
This is
markt-asf merged pull request #162: Add support for same-site cookie attribute
URL: https://github.com/apache/tomcat/pull/162
This is an automated message from the Apache Git Service.
To respond to the message, please log on
markt-asf commented on issue #162: Add support for same-site cookie attribute
URL: https://github.com/apache/tomcat/pull/162#issuecomment-493880726
Thanks for the PR. It has been applied to master. I'll close this PR once I
have completed back-porting it.
markt-asf commented on issue #162: Add support for same-site cookie attribute
URL: https://github.com/apache/tomcat/pull/162#issuecomment-493889783
Back-ported to 8.5.x
This is an automated message from the Apache Git
markt-asf commented on issue #166: Corrected typo "Bescrheibung" to
"Beschreibung"
URL: https://github.com/apache/tomcat/pull/166#issuecomment-494323962
Thanks for the report and the fix.
We manage translations via https://poeditor.com/projects/view?id=221603 (and
some custom
markt-asf closed pull request #166: Corrected typo "Bescrheibung" to
"Beschreibung"
URL: https://github.com/apache/tomcat/pull/166
This is an automated message from the Apache Git Service.
To respond to the message, please
dusiema opened a new pull request #166: Corrected typo "Bescrheibung" to
"Beschreibung"
URL: https://github.com/apache/tomcat/pull/166
This is an automated message from the Apache Git Service.
To respond to the message,
dusiema commented on issue #166: Corrected typo "Bescrheibung" to "Beschreibung"
URL: https://github.com/apache/tomcat/pull/166#issuecomment-494354942
Thanks for the link. I created an account and will try to contribute some...
rjozwik opened a new pull request #167: Use test -t command to check if STDOUT
is opened on a terminal
URL: https://github.com/apache/tomcat/pull/167
Current check for TTY availability in catalina.sh doesn't work if
non-English locales are installed and activated. This fix uses `test`
johnkdev commented on issue #162: Add support for same-site cookie attribute
URL: https://github.com/apache/tomcat/pull/162#issuecomment-493176748
I've updated the code and added an entry to the changelog.
This is an
markt-asf commented on issue #162: Add support for same-site cookie attribute
URL: https://github.com/apache/tomcat/pull/162#issuecomment-492644191
Thanks for the updates. I have a few comments on the updated PR:
- You can reduce the code duplication by using CookieProcessorBase
-
markt-asf commented on issue #156: Don't place CrawlerSessionManagerValve into
session, place data-holder only. For 7.0.x
URL: https://github.com/apache/tomcat/pull/156#issuecomment-488256240
Thanks for the PR. I cherry-picked the 8.5.x fix fixed the conflict in the
changelog and then
markt-asf closed pull request #156: Don't place CrawlerSessionManagerValve into
session, place data-holder only. For 7.0.x
URL: https://github.com/apache/tomcat/pull/156
This is an automated message from the Apache Git
markt-asf commented on issue #155: Don't place CrawlerSessionManagerValve into
session, place data-holder only. For 8.5.x
URL: https://github.com/apache/tomcat/pull/155#issuecomment-488255406
Thanks for the PR. I cherry-picked the 9.0.x fix (with the minor
adjustments) and then made the
markt-asf closed pull request #155: Don't place CrawlerSessionManagerValve into
session, place data-holder only. For 8.5.x
URL: https://github.com/apache/tomcat/pull/155
This is an automated message from the Apache Git
markt-asf commented on issue #154: Don't place CrawlerSessionManagerValve into
session, place data-holder only
URL: https://github.com/apache/tomcat/pull/154#issuecomment-488254573
Patch applied manually with a few changes to keep Checkstyle etc happy. I
also added a changelog entry.
markt-asf closed pull request #154: Don't place CrawlerSessionManagerValve into
session, place data-holder only
URL: https://github.com/apache/tomcat/pull/154
This is an automated message from the Apache Git Service.
To
markt-asf commented on issue #157:
https://bz.apache.org/bugzilla/show_bug.cgi?id=6
URL: https://github.com/apache/tomcat/pull/157#issuecomment-487770720
Just a note to say this next on my list to look at - hopefully tomorrow.
markt-asf commented on issue #157:
https://bz.apache.org/bugzilla/show_bug.cgi?id=6
URL: https://github.com/apache/tomcat/pull/157#issuecomment-487898377
I've applied this. I didn't merge the PR directly as I wanted to tweak some
of the formatting but the functional aspects remained
markt-asf closed pull request #157:
https://bz.apache.org/bugzilla/show_bug.cgi?id=6
URL: https://github.com/apache/tomcat/pull/157
This is an automated message from the Apache Git Service.
To respond to the message,
markt-asf closed pull request #161: Early check end of input condition to avoid
ArrayIndexOutOfBoundsExceptions
URL: https://github.com/apache/tomcat/pull/161
This is an automated message from the Apache Git Service.
To
markt-asf commented on issue #161: Early check end of input condition to avoid
ArrayIndexOutOfBoundsExceptions
URL: https://github.com/apache/tomcat/pull/161#issuecomment-487916490
Thanks for the PR. I applied (rather than merged it) along with a update to
the changelog that included
woonsan opened a new pull request #159: 63370 - Message files
(LocalStrings_*.properties) of the examples webapp not converted to ascii
URL: https://github.com/apache/tomcat/pull/159
This is an automated message from the
ChristopherSchultz merged pull request #160: Add javadoc to describe
IntrospectionUtils.isInstance
URL: https://github.com/apache/tomcat/pull/160
This is an automated message from the Apache Git Service.
To respond to the
johnkdev opened a new pull request #162: Add support for same-site cookie
attribute
URL: https://github.com/apache/tomcat/pull/162
This is an automated message from the Apache Git Service.
To respond to the message, please
zhanhb opened a new pull request #175: Apply the suggestion in rfc7233
URL: https://github.com/apache/tomcat/pull/175
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
govi20 edited a comment on issue #177: Code polish: replace classic for-loop
with enhanced
URL: https://github.com/apache/tomcat/pull/177#issuecomment-509019980
Yes. `for-loop's` temp variable and `ServletContextAttributeListener's` old
var name were clashing. I don't think using
govi20 opened a new pull request #177: Code polish: replace classic for-loop
with enhanced
URL: https://github.com/apache/tomcat/pull/177
ApplicationContext has classic-for loops, these for loops can be replaced
with enhanced for-loop to improve code readability.
ChristopherSchultz commented on issue #177: Code polish: replace classic
for-loop with enhanced
URL: https://github.com/apache/tomcat/pull/177#issuecomment-509018351
The patch is smaller is you don't replace `listener` with
`servletContextAttributeListener` everywhere. Any reason to
govi20 commented on issue #177: Code polish: replace classic for-loop with
enhanced
URL: https://github.com/apache/tomcat/pull/177#issuecomment-509019980
Yes. `for-loop's` temp and `ServletContextAttributeListener's` old name are
clashing. I don't think using `tempListener` in a
govi20 edited a comment on issue #177: Code polish: replace classic for-loop
with enhanced
URL: https://github.com/apache/tomcat/pull/177#issuecomment-509019980
Yes. `for-loop's` temp variable and `ServletContextAttributeListener's` old
var name were clashing. I don't think using
michael-o opened a new pull request #178: Bug 63556 - Mark request as forwarded
in RemoteIpValve/RemoteIpFilter
URL: https://github.com/apache/tomcat/pull/178
This is WIP, please review. I will squash, backport to 8.5.x and merge into
both branches.
markt-asf commented on issue #178: Bug 63556 - Mark request as forwarded in
RemoteIpValve/RemoteIpFilter
URL: https://github.com/apache/tomcat/pull/178#issuecomment-509663648
Only a couple of minor comments.
- We try and keep the changelog to a maximum width of 80 chars. We probably
michael-o commented on issue #178: Bug 63556 - Mark request as forwarded in
RemoteIpValve/RemoteIpFilter
URL: https://github.com/apache/tomcat/pull/178#issuecomment-509669901
* Will fix `changelog.xml`
* Indeed, I have blindly copied from `REMOTE_ADDR_ATTRIBUTE`. I can drop
michael-o commented on issue #178: Bug 63556 - Mark request as forwarded in
RemoteIpValve/RemoteIpFilter
URL: https://github.com/apache/tomcat/pull/178#issuecomment-509672500
@markt-asf Done. Will now run the tests again.
alpire commented on a change in pull request #176: CoyoteAdapter: fix
out-of-bounds read in checkNormalize
URL: https://github.com/apache/tomcat/pull/176#discussion_r299498714
##
File path: java/org/apache/catalina/connector/CoyoteAdapter.java
##
@@ -1271,6 +1276,11 @@
alpire commented on a change in pull request #176: CoyoteAdapter: fix
out-of-bounds read in checkNormalize
URL: https://github.com/apache/tomcat/pull/176#discussion_r299503403
##
File path: java/org/apache/catalina/connector/CoyoteAdapter.java
##
@@ -1271,6 +1276,11 @@
markt-asf commented on a change in pull request #176: CoyoteAdapter: fix
out-of-bounds read in checkNormalize
URL: https://github.com/apache/tomcat/pull/176#discussion_r299500242
##
File path: java/org/apache/catalina/connector/CoyoteAdapter.java
##
@@ -1271,6 +1276,11 @@
markt-asf commented on issue #175: Apply the suggestion in rfc7233
URL: https://github.com/apache/tomcat/pull/175#issuecomment-507209534
Thanks. I have applied 2 of the 3 changes to 9.0.x (range units and etag)
with some additional refactoring / clean-up as well as additional comments.
zhanhb commented on issue #175: Apply the suggestion in rfc7233
URL: https://github.com/apache/tomcat/pull/175#issuecomment-507295587
For a put request, usually it won't have a header 'Range', The header
specified in rfc 2616 is 'Content-Range'.
What will happen to a put request if
zhanhb edited a comment on issue #175: Apply the suggestion in rfc7233
URL: https://github.com/apache/tomcat/pull/175#issuecomment-507295587
For a put request, usually it won't have a header 'Range', The header
specified in rfc 2616 is 'Content-Range'.
What will happen to a put request
markt-asf commented on issue #175: Apply the suggestion in rfc7233
URL: https://github.com/apache/tomcat/pull/175#issuecomment-507304794
Thanks for the the review. I had mis-remembered how partial PUTs were
implemented. I'll take another pass at the patch.
govi20 commented on issue #177: Code polish: replace classic for-loop with
enhanced
URL: https://github.com/apache/tomcat/pull/177#issuecomment-509239212
Cool Thanks!
This is an automated message from the Apache Git Service.
woonsan merged pull request #159: 63370 - Message files
(LocalStrings_*.properties) of the examples webapp not converted to ascii
URL: https://github.com/apache/tomcat/pull/159
This is an automated message from the Apache
ChristopherSchultz opened a new pull request #160: Add javadoc to describe
IntrospectionUtils.isInstance
URL: https://github.com/apache/tomcat/pull/160
This is an automated message from the Apache Git Service.
To respond to
isapir commented on issue #160: Add javadoc to describe
IntrospectionUtils.isInstance
URL: https://github.com/apache/tomcat/pull/160#issuecomment-486358760
@ChristopherSchultz Should I merge it or are you just testing things out?
Not sure why you opened a PR rather than push it
kkolinko commented on issue #154: Don't place CrawlerSessionManagerValve into
session, place data-holder only
URL: https://github.com/apache/tomcat/pull/154#issuecomment-481178151
I commented in Bugzilla, starting with
https://bz.apache.org/bugzilla/show_bug.cgi?id=63324#c2
rmaucher commented on issue #153: Add async API for NIO
URL: https://github.com/apache/tomcat/pull/153#issuecomment-481834218
Since I got no objections, I merged the code.
This is an automated message from the Apache Git
rmaucher closed pull request #153: Add async API for NIO
URL: https://github.com/apache/tomcat/pull/153
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
jchobantonov opened a new pull request #157:
https://bz.apache.org/bugzilla/show_bug.cgi?id=6
URL: https://github.com/apache/tomcat/pull/157
This is an automated message from the Apache Git Service.
To respond to the
ChristopherSchultz commented on issue #157:
https://bz.apache.org/bugzilla/show_bug.cgi?id=6
URL: https://github.com/apache/tomcat/pull/157#issuecomment-481842267
No explanation?
-1
This is an automated message
ChristopherSchultz commented on issue #157:
https://bz.apache.org/bugzilla/show_bug.cgi?id=6
URL: https://github.com/apache/tomcat/pull/157#issuecomment-481847793
But an explanation should be included with all PRs. What if BZ is deleted?
(It shouldn't be, but there's no reason to make
ChristopherSchultz commented on issue #157:
https://bz.apache.org/bugzilla/show_bug.cgi?id=6
URL: https://github.com/apache/tomcat/pull/157#issuecomment-481848050
Code comments would be helpful, here, too.
This is an
jchobantonov commented on issue #157:
https://bz.apache.org/bugzilla/show_bug.cgi?id=6
URL: https://github.com/apache/tomcat/pull/157#issuecomment-481849557
Code comments are exactly the same as what tomcat source code have for
DataSourceRealm, not sure what else do you need as a
ChristopherSchultz commented on issue #157:
https://bz.apache.org/bugzilla/show_bug.cgi?id=6
URL: https://github.com/apache/tomcat/pull/157#issuecomment-481850427
The low-quality of the existing code and/or documentation is not an excuse
for maintaining that level of quality.
ChristopherSchultz commented on issue #157:
https://bz.apache.org/bugzilla/show_bug.cgi?id=6
URL: https://github.com/apache/tomcat/pull/157#issuecomment-481850875
> I think that it'd be cleaner/more readable if `invocationSuccess` is
initialized with `false` value and only set to
jchobantonov commented on issue #157:
https://bz.apache.org/bugzilla/show_bug.cgi?id=6
URL: https://github.com/apache/tomcat/pull/157#issuecomment-481852195
> The low-quality of the existing code and/or documentation is not an excuse
for maintaining that level of quality.
Ok,
jchobantonov commented on issue #157:
https://bz.apache.org/bugzilla/show_bug.cgi?id=6
URL: https://github.com/apache/tomcat/pull/157#issuecomment-481860226
> But these lines are all in the same transaction, no?
Yes they are - there is no need to use local variable as well - it
michael-o commented on issue #157:
https://bz.apache.org/bugzilla/show_bug.cgi?id=6
URL: https://github.com/apache/tomcat/pull/157#issuecomment-481843426
I agree with @ChristopherSchultz .
This is an automated message
jchobantonov commented on issue #157:
https://bz.apache.org/bugzilla/show_bug.cgi?id=6
URL: https://github.com/apache/tomcat/pull/157#issuecomment-481845121
the explanation of the reason is here
https://bz.apache.org/bugzilla/show_bug.cgi?id=6
201 - 300 of 3206 matches
Mail list logo
