[GitHub] [tomcat] isapir commented on issue #157: https://bz.apache.org/bugzilla/show_bug.cgi?id=63333

isapir commented on issue #157: https://bz.apache.org/bugzilla/show_bug.cgi?id=6 URL: https://github.com/apache/tomcat/pull/157#issuecomment-481850076 I think that it'd be cleaner/more readable if `invocationSuccess` is initialized with `false` value and only set to `true` upon

[GitHub] [tomcat] jchobantonov commented on issue #157: https://bz.apache.org/bugzilla/show_bug.cgi?id=63333

jchobantonov commented on issue #157: https://bz.apache.org/bugzilla/show_bug.cgi?id=6 URL: https://github.com/apache/tomcat/pull/157#issuecomment-481851585 > I think that it'd be cleaner/more readable if `invocationSuccess` is initialized with `false` value and only set to `true`

[GitHub] [tomcat] isapir commented on issue #157: https://bz.apache.org/bugzilla/show_bug.cgi?id=63333

isapir commented on issue #157: https://bz.apache.org/bugzilla/show_bug.cgi?id=6 URL: https://github.com/apache/tomcat/pull/157#issuecomment-481853982 > To reduce the number of changed lines and opportunities for mistakes, there could be a local flag for success which is copied to the

[GitHub] [tomcat] isapir commented on issue #157: https://bz.apache.org/bugzilla/show_bug.cgi?id=63333

isapir commented on issue #157: https://bz.apache.org/bugzilla/show_bug.cgi?id=6 URL: https://github.com/apache/tomcat/pull/157#issuecomment-481861275 > Ok, let me know what you think we should put as a comment additionally that is so greatly missed and it is not obvious enough for

[GitHub] [tomcat] markt-asf commented on issue #139: service.bat handles changed Service at installation

markt-asf commented on issue #139: service.bat handles changed Service at installation URL: https://github.com/apache/tomcat/pull/139#issuecomment-481356608 The patch needs some more work. Currently it works if you install a different service name using the installer (because

[GitHub] [tomcat] uhees opened a new pull request #161: Early check end of input condition to avoid ArrayIndexOutOfBoundsExceptions

uhees opened a new pull request #161: Early check end of input condition to avoid ArrayIndexOutOfBoundsExceptions URL: https://github.com/apache/tomcat/pull/161 Exceptions are expensive and should only be thrown in an exceptional state. End of input is no exception but should be expected.

[GitHub] [tomcat] isapir commented on issue #160: Add javadoc to describe IntrospectionUtils.isInstance

isapir commented on issue #160: Add javadoc to describe IntrospectionUtils.isInstance URL: https://github.com/apache/tomcat/pull/160#issuecomment-486764240 Is your remote configured for https:// (rather than git://)?. Run `git remote -v` to view the remote URLs. I was trying at first to

[GitHub] [tomcat] ChristopherSchultz commented on issue #160: Add javadoc to describe IntrospectionUtils.isInstance

ChristopherSchultz commented on issue #160: Add javadoc to describe IntrospectionUtils.isInstance URL: https://github.com/apache/tomcat/pull/160#issuecomment-486762240 Just exercising everything to make sure it works how I expect it to work. For example, Eclipse crapped its pants

[GitHub] [tomcat] markt-asf commented on issue #175: Apply the suggestion in rfc7233

markt-asf commented on issue #175: Apply the suggestion in rfc7233 URL: https://github.com/apache/tomcat/pull/175#issuecomment-507409540 I think everything is complete now. Feel free to re-open if you spot something I missed.

[GitHub] [tomcat] markt-asf closed pull request #175: Apply the suggestion in rfc7233

markt-asf closed pull request #175: Apply the suggestion in rfc7233 URL: https://github.com/apache/tomcat/pull/175 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [tomcat] zhanhb commented on issue #175: Apply the suggestion in rfc7233

zhanhb commented on issue #175: Apply the suggestion in rfc7233 URL: https://github.com/apache/tomcat/pull/175#issuecomment-507436005 Good job, there is no issue with the range request now. This is an automated message from

[GitHub] [tomcat] zhanhb closed pull request #174: Clean method parseRange

zhanhb closed pull request #174: Clean method parseRange URL: https://github.com/apache/tomcat/pull/174 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [tomcat] zhanhb closed pull request #175: Apply the suggestion in rfc7233

zhanhb closed pull request #175: Apply the suggestion in rfc7233 URL: https://github.com/apache/tomcat/pull/175 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [tomcat] alpire commented on a change in pull request #176: CoyoteAdapter: fix out-of-bounds read in checkNormalize

alpire commented on a change in pull request #176: CoyoteAdapter: fix out-of-bounds read in checkNormalize URL: https://github.com/apache/tomcat/pull/176#discussion_r299276651 ## File path: java/org/apache/catalina/connector/CoyoteAdapter.java ## @@ -1271,6 +1276,11 @@

[GitHub] [tomcat] alpire commented on a change in pull request #176: CoyoteAdapter: fix out-of-bounds read in checkNormalize

alpire commented on a change in pull request #176: CoyoteAdapter: fix out-of-bounds read in checkNormalize URL: https://github.com/apache/tomcat/pull/176#discussion_r299276368 ## File path: java/org/apache/catalina/connector/CoyoteAdapter.java ## @@ -1252,6 +1252,11 @@

[GitHub] [tomcat] alpire commented on a change in pull request #176: CoyoteAdapter: fix out-of-bounds read in checkNormalize

alpire commented on a change in pull request #176: CoyoteAdapter: fix out-of-bounds read in checkNormalize URL: https://github.com/apache/tomcat/pull/176#discussion_r299284882 ## File path: test/org/apache/catalina/connector/TestCoyoteAdapter.java ## @@ -344,6 +345,29 @@

[GitHub] [tomcat] alpire opened a new pull request #176: CoyoteAdapter: fix out-of-bounds read in checkNormalize

alpire opened a new pull request #176: CoyoteAdapter: fix out-of-bounds read in checkNormalize URL: https://github.com/apache/tomcat/pull/176 On malformed requests, checkNormalize would throw an ArrayIndexOutOfBoundsException leading to a 500 response. This change fixes checkNormalize to

[GitHub] [tomcat] markt-asf commented on a change in pull request #176: CoyoteAdapter: fix out-of-bounds read in checkNormalize

markt-asf commented on a change in pull request #176: CoyoteAdapter: fix out-of-bounds read in checkNormalize URL: https://github.com/apache/tomcat/pull/176#discussion_r299493101 ## File path: java/org/apache/catalina/connector/CoyoteAdapter.java ## @@ -1271,6 +1276,11 @@

[GitHub] [tomcat] markt-asf commented on a change in pull request #176: CoyoteAdapter: fix out-of-bounds read in checkNormalize

markt-asf commented on a change in pull request #176: CoyoteAdapter: fix out-of-bounds read in checkNormalize URL: https://github.com/apache/tomcat/pull/176#discussion_r299572216 ## File path: java/org/apache/catalina/connector/CoyoteAdapter.java ## @@ -1271,6 +1276,11 @@

[GitHub] [tomcat] markt-asf commented on issue #176: CoyoteAdapter: fix out-of-bounds read in checkNormalize

markt-asf commented on issue #176: CoyoteAdapter: fix out-of-bounds read in checkNormalize URL: https://github.com/apache/tomcat/pull/176#issuecomment-507753421 Many thanks for raising this issue. I think we have tracked down the root cause and fixed it. Note that 7.0.x was not affected.

[GitHub] [tomcat] markt-asf closed pull request #176: CoyoteAdapter: fix out-of-bounds read in checkNormalize

markt-asf closed pull request #176: CoyoteAdapter: fix out-of-bounds read in checkNormalize URL: https://github.com/apache/tomcat/pull/176 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [tomcat] markt-asf commented on a change in pull request #176: CoyoteAdapter: fix out-of-bounds read in checkNormalize

markt-asf commented on a change in pull request #176: CoyoteAdapter: fix out-of-bounds read in checkNormalize URL: https://github.com/apache/tomcat/pull/176#discussion_r298806623 ## File path: test/org/apache/catalina/connector/TestCoyoteAdapter.java ## @@ -344,6 +345,29

[GitHub] [tomcat] markt-asf commented on a change in pull request #176: CoyoteAdapter: fix out-of-bounds read in checkNormalize

markt-asf commented on a change in pull request #176: CoyoteAdapter: fix out-of-bounds read in checkNormalize URL: https://github.com/apache/tomcat/pull/176#discussion_r298806528 ## File path: java/org/apache/catalina/connector/CoyoteAdapter.java ## @@ -1271,6 +1276,11 @@

[GitHub] [tomcat] markt-asf commented on a change in pull request #176: CoyoteAdapter: fix out-of-bounds read in checkNormalize

markt-asf commented on a change in pull request #176: CoyoteAdapter: fix out-of-bounds read in checkNormalize URL: https://github.com/apache/tomcat/pull/176#discussion_r298806534 ## File path: test/org/apache/catalina/connector/TestCoyoteAdapter.java ## @@ -326,6 +326,7

[GitHub] [tomcat] markt-asf commented on a change in pull request #176: CoyoteAdapter: fix out-of-bounds read in checkNormalize

markt-asf commented on a change in pull request #176: CoyoteAdapter: fix out-of-bounds read in checkNormalize URL: https://github.com/apache/tomcat/pull/176#discussion_r298806436 ## File path: java/org/apache/catalina/connector/CoyoteAdapter.java ## @@ -1252,6 +1252,11 @@

[GitHub] [tomcat] michael-o commented on issue #186: BZ 63636: Context#findRoleMapping() never called in RealmBase#hasRole()

michael-o commented on issue #186: BZ 63636: Context#findRoleMapping() never called in RealmBase#hasRole() URL: https://github.com/apache/tomcat/pull/186#issuecomment-520436938 @markt-asf I have now added proper tests. Please have a look. If they are as expected, I'll rebase, squash,

[GitHub] [tomcat] maxime-beck opened a new pull request #188: Introduce Tomcat Source-to-Image (S2I)

maxime-beck opened a new pull request #188: Introduce Tomcat Source-to-Image (S2I) URL: https://github.com/apache/tomcat/pull/188 # Tomcat - Source-to-Image (S2I) This resource provides a CentOS-based Docker image that enables

[GitHub] [tomcat] markt-asf commented on issue #186: BZ 63636: Context#findRoleMapping() never called in RealmBase#hasRole()

markt-asf commented on issue #186: BZ 63636: Context#findRoleMapping() never called in RealmBase#hasRole() URL: https://github.com/apache/tomcat/pull/186#issuecomment-520490637 Test LGTM. This is an automated message from

[GitHub] [tomcat] michael-o commented on issue #186: BZ 63636: Context#findRoleMapping() never called in RealmBase#hasRole()

michael-o commented on issue #186: BZ 63636: Context#findRoleMapping() never called in RealmBase#hasRole() URL: https://github.com/apache/tomcat/pull/186#issuecomment-520472525 All tests pass on Tomcat 9.0.x. This is an

[GitHub] [tomcat] michael-o commented on issue #188: Introduce Tomcat Source-to-Image (S2I)

michael-o commented on issue #188: Introduce Tomcat Source-to-Image (S2I) URL: https://github.com/apache/tomcat/pull/188#issuecomment-520475521 I am against pulling this one for several reasons: * This is CentOS-specific and OpenShift * Someone has to maintain it, likely none of

[GitHub] [tomcat] leeyazhou opened a new pull request #189: Additional translations of Chinese

leeyazhou opened a new pull request #189: Additional translations of Chinese URL: https://github.com/apache/tomcat/pull/189 Additional translations of Chinese for tomcat manager This is an automated message from the

[GitHub] [tomcat] markt-asf commented on issue #189: Additional translations of Chinese

markt-asf commented on issue #189: Additional translations of Chinese URL: https://github.com/apache/tomcat/pull/189#issuecomment-521162534 I'm all in favour of expanding the i18n support in Tomcat and I agree adding Chinese translations to 8.5.x is a good next step. If you aren't

[GitHub] [tomcat] KangZhiDong opened a new pull request #192: Fix typo

KangZhiDong opened a new pull request #192: Fix typo URL: https://github.com/apache/tomcat/pull/192 Fix typo This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [tomcat] KangZhiDong opened a new pull request #191: Fix typo for prefect

KangZhiDong opened a new pull request #191: Fix typo for prefect URL: https://github.com/apache/tomcat/pull/191 fix typo for prefect This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [tomcat] leeyazhou edited a comment on issue #189: Additional translations of Chinese

leeyazhou edited a comment on issue #189: Additional translations of Chinese URL: https://github.com/apache/tomcat/pull/189#issuecomment-521515402 > I'm all in favour of expanding the i18n support in Tomcat and I agree adding Chinese translations to 8.5.x is a good next step. > > If

[GitHub] [tomcat] leeyazhou closed pull request #189: Additional translations of Chinese

leeyazhou closed pull request #189: Additional translations of Chinese URL: https://github.com/apache/tomcat/pull/189 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [tomcat] markt-asf commented on issue #189: Additional translations of Chinese

markt-asf commented on issue #189: Additional translations of Chinese URL: https://github.com/apache/tomcat/pull/189#issuecomment-521657310 Just to let you know, I've written some utilities to back-port the translations and have run them for 9.0.x -> 8.5.x. I've also picked up the

[GitHub] [tomcat] leeyazhou commented on issue #189: Additional translations of Chinese

leeyazhou commented on issue #189: Additional translations of Chinese URL: https://github.com/apache/tomcat/pull/189#issuecomment-521515402 > I'm all in favour of expanding the i18n support in Tomcat and I agree adding Chinese translations to 8.5.x is a good next step. > > If you

[GitHub] [tomcat] markt-asf merged pull request #190: Fix typo for prefect

markt-asf merged pull request #190: Fix typo for prefect URL: https://github.com/apache/tomcat/pull/190 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [tomcat] markt-asf commented on issue #189: Additional translations of Chinese

markt-asf commented on issue #189: Additional translations of Chinese URL: https://github.com/apache/tomcat/pull/189#issuecomment-521241008 I've completed the first two bullets for 9.0.x->8.5.x. There was only one change required to fix a key that had been added out of order.

[GitHub] [tomcat] KangZhiDong opened a new pull request #190: Fix typo for prefect

KangZhiDong opened a new pull request #190: Fix typo for prefect URL: https://github.com/apache/tomcat/pull/190 Fix typo for prefect This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [tomcat] asfgit merged pull request #186: BZ 63636: Context#findRoleMapping() never called in RealmBase#hasRole()

asfgit merged pull request #186: BZ 63636: Context#findRoleMapping() never called in RealmBase#hasRole() URL: https://github.com/apache/tomcat/pull/186 This is an automated message from the Apache Git Service. To respond to

[GitHub] [tomcat] gmshake commented on a change in pull request #192: Fix typo

gmshake commented on a change in pull request #192: Fix typo URL: https://github.com/apache/tomcat/pull/192#discussion_r315478754 ## File path: java/org/apache/catalina/core/StandardWrapper.java ## @@ -1253,7 +1253,7 @@ public synchronized void unload() throws

[GitHub] [tomcat] KangZhiDong closed pull request #192: Fix typo

KangZhiDong closed pull request #192: Fix typo URL: https://github.com/apache/tomcat/pull/192 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [tomcat] qixiaobo commented on a change in pull request #192: Fix typo

qixiaobo commented on a change in pull request #192: Fix typo URL: https://github.com/apache/tomcat/pull/192#discussion_r315514055 ## File path: java/org/apache/catalina/core/StandardWrapper.java ## @@ -1253,7 +1253,7 @@ public synchronized void unload() throws

[GitHub] [tomcat] markt-asf commented on issue #192: Fix typo

markt-asf commented on issue #192: Fix typo URL: https://github.com/apache/tomcat/pull/192#issuecomment-522885985 It does. The use of loaf is meant to indicate that the thread waits for a while, idle, not doing anything.

[GitHub] [tomcat] qixiaobo commented on issue #192: Fix typo

qixiaobo commented on issue #192: Fix typo URL: https://github.com/apache/tomcat/pull/192#issuecomment-522887312 maybe spin~ This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [tomcat] maxime-beck opened a new pull request #193: Fix '/opt already exists' build error

maxime-beck opened a new pull request #193: Fix '/opt already exists' build error URL: https://github.com/apache/tomcat/pull/193 The base image (openjdk:8-jre-alpine) already provides that folder. This is an automated

[GitHub] [tomcat] jfclere merged pull request #193: Fix '/opt already exists' build error

jfclere merged pull request #193: Fix '/opt already exists' build error URL: https://github.com/apache/tomcat/pull/193 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [tomcat] maxime-beck commented on issue #188: Introduce Tomcat Source-to-Image (S2I)

maxime-beck commented on issue #188: Introduce Tomcat Source-to-Image (S2I) URL: https://github.com/apache/tomcat/pull/188#issuecomment-522977107 Yes, switching to Alpine is definitely possible. I can update the PR if needed.

[GitHub] [tomcat] jfclere commented on issue #188: Introduce Tomcat Source-to-Image (S2I)

jfclere commented on issue #188: Introduce Tomcat Source-to-Image (S2I) URL: https://github.com/apache/tomcat/pull/188#issuecomment-520809089 Actually using Alpine like in res/tomcat-maven/Dockerfile might be a good idea. The tool to build the image is independent of Openshift and the

[GitHub] [tomcat] markt-asf commented on issue #191: Fix typo for prefect

markt-asf commented on issue #191: Fix typo for prefect URL: https://github.com/apache/tomcat/pull/191#issuecomment-522260230 Thanks for the PR. I have applied the change (with a modified comment) to 9.0.x and 8.5.x. Note that it isn't clear to me what you mean by "...for prefect" in

[GitHub] [tomcat] markt-asf closed pull request #191: Fix typo for prefect

markt-asf closed pull request #191: Fix typo for prefect URL: https://github.com/apache/tomcat/pull/191 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [tomcat] qixiaobo commented on issue #192: Fix typo

qixiaobo commented on issue #192: Fix typo URL: https://github.com/apache/tomcat/pull/192#issuecomment-523262936 > I love the definition "to spend time doing nothing, usually when you should be working": macmillandictionary.com intelligent

[GitHub] [tomcat] michael-o opened a new pull request #195: BZ 63684: Wrapper never passed to RealmBase#hasRole() for given secur…

michael-o opened a new pull request #195: BZ 63684: Wrapper never passed to RealmBase#hasRole() for given secur… URL: https://github.com/apache/tomcat/pull/195 …ity constraints It turned out that BZ 63636 was not complete. The realm needs the wrapper to do its magic. All

[GitHub] [tomcat] jfclere commented on issue #192: Fix typo

jfclere commented on issue #192: Fix typo URL: https://github.com/apache/tomcat/pull/192#issuecomment-522999745 I love the definition "to spend time doing nothing, usually when you should be working": macmillandictionary.com

[GitHub] [tomcat] michael-o commented on issue #195: BZ 63684: Wrapper never passed to RealmBase#hasRole() for given secur…

michael-o commented on issue #195: BZ 63684: Wrapper never passed to RealmBase#hasRole() for given secur… URL: https://github.com/apache/tomcat/pull/195#issuecomment-524982814 @markt-asf, any opinion? I'd like to merge by tomorrow.

[GitHub] [tomcat] asfgit closed pull request #196: fix JSSE_OPTS quoting

asfgit closed pull request #196: fix JSSE_OPTS quoting URL: https://github.com/apache/tomcat/pull/196 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [tomcat] KangZhiDong opened a new pull request #197: Remove unuse catch exception

KangZhiDong opened a new pull request #197: Remove unuse catch exception URL: https://github.com/apache/tomcat/pull/197 Remove unuse catch exception This is an automated message from the Apache Git Service. To respond to the

[GitHub] [tomcat] asfgit merged pull request #195: BZ 63684: Wrapper never passed to RealmBase#hasRole() for given secur…

asfgit merged pull request #195: BZ 63684: Wrapper never passed to RealmBase#hasRole() for given secur… URL: https://github.com/apache/tomcat/pull/195 This is an automated message from the Apache Git Service. To respond to

[GitHub] [tomcat] sk8k closed pull request #198: commit desi.test

sk8k closed pull request #198: commit desi.test URL: https://github.com/apache/tomcat/pull/198 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [tomcat] sk8k opened a new pull request #198: commit desi.test

sk8k opened a new pull request #198: commit desi.test URL: https://github.com/apache/tomcat/pull/198 adding desi test. This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [tomcat] sk8k commented on issue #199: commit desi.test

sk8k commented on issue #199: commit desi.test URL: https://github.com/apache/tomcat/pull/199#issuecomment-526319367 ccc This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [tomcat] sk8k opened a new pull request #199: commit desi.test

sk8k opened a new pull request #199: commit desi.test URL: https://github.com/apache/tomcat/pull/199 c This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [tomcat] sk8k closed pull request #199: commit desi.test

sk8k closed pull request #199: commit desi.test URL: https://github.com/apache/tomcat/pull/199 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [tomcat] KangZhiDong opened a new pull request #194: fix typo

KangZhiDong opened a new pull request #194: fix typo URL: https://github.com/apache/tomcat/pull/194 Fix typo , ["An MBean is a managed Java object, similar to a JavaBeans component, that follows the design patterns set forth in the JMX specification. An MBean can represent a device, an

[GitHub] [tomcat] KangZhiDong commented on issue #194: fix typo

KangZhiDong commented on issue #194: fix typo URL: https://github.com/apache/tomcat/pull/194#issuecomment-524649497 @markt-asf fix some typos at the weekend (●´∀｀●)ﾉ This is an automated message from the Apache Git

[GitHub] [tomcat] peteruhnak opened a new pull request #196: fix JSSE_OPTS quoting

peteruhnak opened a new pull request #196: fix JSSE_OPTS quoting URL: https://github.com/apache/tomcat/pull/196 Otherwise if JSSE_OPTS is set with the same value, the quotation will cancel itself in the if condition. ``` if not ""-Djdk.tls.ephemeralDHKeySize=2048"" ```

[GitHub] [tomcat] KangZhiDong closed pull request #194: fix typo

KangZhiDong closed pull request #194: fix typo URL: https://github.com/apache/tomcat/pull/194 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [tomcat] KangZhiDong opened a new pull request #194: fix typo

KangZhiDong opened a new pull request #194: fix typo URL: https://github.com/apache/tomcat/pull/194 Fix typo , ["An MBean is a managed Java object, similar to a JavaBeans component, that follows the design patterns set forth in the JMX specification. An MBean can represent a device, an

[GitHub] [tomcat] markt-asf closed pull request #201: Avoid NPE in NamingContextListener.getGlobalNamingContext with Embedded containers

markt-asf closed pull request #201: Avoid NPE in NamingContextListener.getGlobalNamingContext with Embedded containers URL: https://github.com/apache/tomcat/pull/201 This is an automated message from the Apache Git Service.

[GitHub] [tomcat] markt-asf commented on issue #201: Avoid NPE in NamingContextListener.getGlobalNamingContext with Embedded containers

markt-asf commented on issue #201: Avoid NPE in NamingContextListener.getGlobalNamingContext with Embedded containers URL: https://github.com/apache/tomcat/pull/201#issuecomment-530479424 Thanks for the PR. It has been applied (along with a changelog entry) to master, 8.5.x and 7.0.x

[GitHub] [tomcat] markt-asf merged pull request #203: spelling and formatting corrections for cluster-howto

markt-asf merged pull request #203: spelling and formatting corrections for cluster-howto URL: https://github.com/apache/tomcat/pull/203 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [tomcat] carterkozak opened a new pull request #204: Fix typo in StringManager class javadoc

carterkozak opened a new pull request #204: Fix typo in StringManager class javadoc URL: https://github.com/apache/tomcat/pull/204 s/formating/formatting This is an automated message from the Apache Git Service. To respond

[GitHub] [tomcat] markt-asf merged pull request #202: Polish. Add spaces

markt-asf merged pull request #202: Polish. Add spaces URL: https://github.com/apache/tomcat/pull/202 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [tomcat] markt-asf commented on issue #202: Polish. Add spaces

markt-asf commented on issue #202: Polish. Add spaces URL: https://github.com/apache/tomcat/pull/202#issuecomment-530480113 Tx. Applying now... This is an automated message from the Apache Git Service. To respond to the

[GitHub] [tomcat] carterkozak opened a new pull request #205: ByteBufferUtils.cleanDirectBuffer invocation failures are logged

carterkozak opened a new pull request #205: ByteBufferUtils.cleanDirectBuffer invocation failures are logged URL: https://github.com/apache/tomcat/pull/205 Previously cleanMethod failures were ignored entirely, and invokeCleanerMethod failures were logged to stderr using

[GitHub] [tomcat] markt-asf merged pull request #205: ByteBufferUtils.cleanDirectBuffer invocation failures are logged

markt-asf merged pull request #205: ByteBufferUtils.cleanDirectBuffer invocation failures are logged URL: https://github.com/apache/tomcat/pull/205 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [tomcat] markt-asf commented on issue #179: PropertySource: Add an environment variable based source

markt-asf commented on issue #179: PropertySource: Add an environment variable based source URL: https://github.com/apache/tomcat/pull/179#issuecomment-530938832 Thanks for the updates. Unfortunately this won't work. You can't create an instance of an object that depends on an instance of

[GitHub] [tomcat] markt-asf merged pull request #204: Fix typo in StringManager class javadoc

markt-asf merged pull request #204: Fix typo in StringManager class javadoc URL: https://github.com/apache/tomcat/pull/204 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [tomcat] KangZhiDong opened a new pull request #206: Fix typo

KangZhiDong opened a new pull request #206: Fix typo URL: https://github.com/apache/tomcat/pull/206 remove redundant javadoc for clean This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [tomcat] KangZhiDong closed pull request #206: Fix typo

KangZhiDong closed pull request #206: Fix typo URL: https://github.com/apache/tomcat/pull/206 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [tomcat] markt-asf commented on issue #179: PropertySource: Add an environment variable based source

markt-asf commented on issue #179: PropertySource: Add an environment variable based source URL: https://github.com/apache/tomcat/pull/179#issuecomment-530997490 I've pushed my modified solution to master. I'm going to wait for feedback before back-porting.

[GitHub] [tomcat] markt-asf commented on issue #194: fix typo

markt-asf commented on issue #194: fix typo URL: https://github.com/apache/tomcat/pull/194#issuecomment-530252907 Wow. There are a lot of changes here. Thank you. It is too much to review in one go. I took a quick look at the first few changes files and things look good. My current

[GitHub] [tomcat] vocatan opened a new pull request #203: spelling and formatting corrections for cluster-howto

vocatan opened a new pull request #203: spelling and formatting corrections for cluster-howto URL: https://github.com/apache/tomcat/pull/203 Was reading the documentation about session clustering and found some minor typographical issues. Felt that they were small enough that rather than

[GitHub] [tomcat] xiantang commented on issue #194: fix typo

xiantang commented on issue #194: fix typo URL: https://github.com/apache/tomcat/pull/194#issuecomment-529468320 @KangZhiDong too much commits This is an automated message from the Apache Git Service. To respond to the

[GitHub] [tomcat] markt-asf commented on a change in pull request #194: fix typo

markt-asf commented on a change in pull request #194: fix typo URL: https://github.com/apache/tomcat/pull/194#discussion_r323170474 ## File path: webapps/docs/windows-auth-howto.xml ## @@ -101,7 +101,7 @@ policy had to be relaxed. This is not recommended for production

[GitHub] [tomcat] markt-asf commented on issue #194: fix typo

markt-asf commented on issue #194: fix typo URL: https://github.com/apache/tomcat/pull/194#issuecomment-530322410 I'm about 2/3 of the way through the commits. With the benefit of experience, 1 PR vs multiple PRs doesn't make that much of a difference. What would have helped was re-basing

[GitHub] [tomcat] KangZhiDong commented on issue #194: fix typo

KangZhiDong commented on issue #194: fix typo URL: https://github.com/apache/tomcat/pull/194#issuecomment-530367386 It seems to have been merged This is an automated message from the Apache Git Service. To respond to the

[GitHub] [tomcat] KangZhiDong closed pull request #194: fix typo

KangZhiDong closed pull request #194: fix typo URL: https://github.com/apache/tomcat/pull/194 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [tomcat] KangZhiDong closed pull request #197: Remove unuse catch exception

KangZhiDong closed pull request #197: Remove unuse catch exception URL: https://github.com/apache/tomcat/pull/197 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [tomcat] KangZhiDong commented on issue #197: Remove unuse catch exception

KangZhiDong commented on issue #197: Remove unuse catch exception URL: https://github.com/apache/tomcat/pull/197#issuecomment-530369535 duplicate exception handling @markt-asf This is an automated message from the Apache Git

[GitHub] [tomcat] xiantang commented on a change in pull request #194: fix typo

xiantang commented on a change in pull request #194: fix typo URL: https://github.com/apache/tomcat/pull/194#discussion_r323195835 ## File path: webapps/docs/windows-auth-howto.xml ## @@ -101,7 +101,7 @@ policy had to be relaxed. This is not recommended for production

[GitHub] [tomcat] xiantang opened a new pull request #202: Polish. Add spaces

xiantang opened a new pull request #202: Polish. Add spaces URL: https://github.com/apache/tomcat/pull/202 when i read `LimitLatch.java` I saw that obvious format error This is an automated message from the Apache Git

[GitHub] [tomcat] KangZhiDong opened a new pull request #207: Fix typos

KangZhiDong opened a new pull request #207: Fix typos URL: https://github.com/apache/tomcat/pull/207 remove redundant or reformat javadoc for clean(some can be ingored). fix typos, such as: a non-zero, a long, a utf-8, an array ,an html, an xa connection, an XAResource, an X-Powered-By,

[GitHub] [tomcat] markt-asf closed pull request #179: PropertySource: Add an environment variable based source

markt-asf closed pull request #179: PropertySource: Add an environment variable based source URL: https://github.com/apache/tomcat/pull/179 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [tomcat] markt-asf commented on issue #179: PropertySource: Add an environment variable based source

markt-asf commented on issue #179: PropertySource: Add an environment variable based source URL: https://github.com/apache/tomcat/pull/179#issuecomment-531697078 Fixed in: - master for 9.0.25 onwards - 8.5.x for 8.5.46 onwards - 7.0.x for 7.0.97 onwards

[GitHub] [tomcat] markt-asf commented on a change in pull request #207: Fix typos

markt-asf commented on a change in pull request #207: Fix typos URL: https://github.com/apache/tomcat/pull/207#discussion_r324573610 ## File path: java/javax/servlet/http/Part.java ## @@ -48,9 +48,6 @@ public String getContentType(); /** - * Obtain the name

[GitHub] [tomcat] KangZhiDong closed pull request #207: Fix typos

KangZhiDong closed pull request #207: Fix typos URL: https://github.com/apache/tomcat/pull/207 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [tomcat] KangZhiDong commented on issue #207: Fix typos

KangZhiDong commented on issue #207: Fix typos URL: https://github.com/apache/tomcat/pull/207#issuecomment-531760193 i will make other changes in spare time @markt-asf This is an automated message from the Apache Git

<    1   2   3   4   5   6   7   8   9   10   >