Re: svn commit: r1086611 - /tomcat/trunk/webapps/docs/windows-auth-howto.xml

2011-03-29 Thread Konstantin Kolinko
=Wep application Typo above. +  pTBD/p +  /subsection The rest of the text looks OK. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h

trunk: TestDefaultServlet fails

2011-03-30 Thread Konstantin Kolinko
] at org.apache.catalina.servlets.TestDefaultServlet.testCustomErrorPage(TestDefaultServlet.java:218) I have not investigated what the cause is yet. (I'll be busy several next hours). The output folder was cleaned before running the build, so this must be a clean one. Best regards, Konstantin Kolinko

Re: svn commit: r1087655 - in /tomcat/trunk: java/org/apache/catalina/authenticator/ java/org/apache/catalina/realm/ test/org/apache/catalina/authenticator/ webapps/docs/ webapps/docs/config/

2011-04-01 Thread Konstantin Kolinko
2011/4/1 ma...@apache.org: Author: markt Date: Fri Apr  1 11:36:54 2011 New Revision: 1087655 URL: http://svn.apache.org/viewvc?rev=1087655view=rev Log: Add additional configuration options to the DIGEST authenticator Added:    

Re: [GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2011-04-01 Thread Konstantin Kolinko
days ago I once saw hanging in the org.apache.tomcat.jni.Library.terminate(Native Method) call during shutdown. That is with APR connector, native 1.1.20 / win32. That happened only once and was not reproducible ever since. Best regards, Konstantin Kolinko

Re: [GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2011-04-01 Thread Konstantin Kolinko
2011/4/1 Mark Thomas ma...@apache.org: On 01/04/2011 14:37, Konstantin Kolinko wrote: 2011/4/1 Mark Thomas ma...@apache.org:  Tomcat hangs during shutdown. I did not observe any issues with DedicatedThreadExecutor. All runs OK for me. (three connectors, Win32, JDK 6u24). I'm seeing random

Re: [GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2011-04-01 Thread Konstantin Kolinko
2011/4/1 Konstantin Kolinko knst.koli...@gmail.com: 2011/4/1 Mark Thomas ma...@apache.org: On 01/04/2011 10:54, Bill Barker wrote: Full details are available at:     http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/index.html I'm seeing a slightly different issue when I

Re: svn commit: r1087467 - in /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool: PoolProperties.java TrapException.java

2011-04-02 Thread Konstantin Kolinko
)) return true; +} +return false; +} Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2011-04-06 Thread Konstantin Kolinko
2011/4/4 Rainer Jung rainer.j...@kippdata.de: On 04.04.2011 11:34, Stefan Bodewig wrote: On 2011-04-03, Rainer Jung wrote: On 02.04.2011 01:20, Konstantin Kolinko wrote: 2011/4/1 Konstantin Kolinkoknst.koli...@gmail.com: In the recent run:      [junit] Apr 1, 2011 9:53:27 PM

Re: anyone using git-svn for tomcat ?

2011-04-07 Thread Konstantin Kolinko
be omitted from src distributions I googled whether other projects have it, gitignore site:svn.apache.org here is some random example: https://svn.apache.org/repos/asf/hadoop/mapreduce/branches/MR-279/.gitignore What content will be in your version of the file? Best regards, Konstantin Kolinko

Re: anyone using git-svn for tomcat ?

2011-04-07 Thread Konstantin Kolinko
2011/4/8 Sylvain Laurent sylvain.laur...@m4x.org: On 7 avr. 2011, at 23:54, Konstantin Kolinko wrote: What content will be in your version of the file? mostly what we ave already ignored with svn props : eclipse-sepcific files, the logs, work, temp directories... Otherwise, one can also

Re: svn commit: r1090072 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-04-07 Thread Konstantin Kolinko
://svn.apache.org/viewvc?view=revisionrevision=1073393 Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1086706 - in /tomcat/trunk/java/org/apache/catalina: Realm.java authenticator/SpnegoAuthenticator.java realm/CombinedRealm.java realm/LocalStrings.properties realm/LockOutRealm.java r

2011-04-07 Thread Konstantin Kolinko
and changing the interface, or we can do what most other systems do public Principal authenticate(Object auth); Good idea. Just Object, or some marker interface? Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr

Re: svn commit: r1090072 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-04-08 Thread Konstantin Kolinko
2011/4/8 Christopher Schultz ch...@christopherschultz.net: Konatantin, On 4/7/2011 9:08 PM, Konstantin Kolinko wrote: 2011/4/8  schu...@apache.org: Author: schultz Date: Fri Apr  8 00:41:29 2011 New Revision: 1090072 URL: http://svn.apache.org/viewvc?rev=1090072view=rev Log: Updated

Re: svn commit: r1090441 - /tomcat/trunk/webapps/docs/changelog.xml

2011-04-08 Thread Konstantin Kolinko
=Coyote Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1090763 - in /tomcat/trunk: java/org/apache/jasper/compiler/DefaultErrorHandler.java webapps/docs/changelog.xml

2011-04-10 Thread Konstantin Kolinko
2011/4/10 ma...@apache.org: Author: markt Date: Sun Apr 10 10:33:30 2011 New Revision: 1090763 URL: http://svn.apache.org/viewvc?rev=1090763view=rev Log: Improve error reporting by labeling line/column numbers This contradicts with i18n of errMsg. If you are making this more

Re: New connector sandbox

2011-04-11 Thread Konstantin Kolinko
some nested connectors sandbox inside sandbox. Maybe sandbox/jk_iis7 ? Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1095367 - in /tomcat/trunk: java/org/apache/catalina/startup/ java/org/apache/jasper/compiler/ java/org/apache/tomcat/util/scan/ webapps/docs/

2011-04-20 Thread Konstantin Kolinko
they file ones? A zip file has central directory i.e. master index at the end of the file. IIRC when you are using random-access methods of Zip file, that index is loaded into memory once. Scanning the file sequentially does not use the index and I think it will be slower. Best regards, Konstantin

Re: svn commit: r1095367 - in /tomcat/trunk: java/org/apache/catalina/startup/ java/org/apache/jasper/compiler/ java/org/apache/tomcat/util/scan/ webapps/docs/

2011-04-20 Thread Konstantin Kolinko
the bit we want. On a reasonably complex app with quite a few JARs the start-up time went from ~30s to ~12s with these changes with most of the 12s now being app init code. Copying the file was killing performance. Best regards, Konstantin Kolinko

Re: svn commit: r1095686 - in /tomcat/trunk/java/org/apache/jasper: compiler/DefaultErrorHandler.java resources/LocalStrings.properties

2011-04-22 Thread Konstantin Kolinko
, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: External Docroot support for Tomcat

2011-04-28 Thread Konstantin Kolinko
#Patches_and_enhancement_requests Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1099394 - in /tomcat/trunk: res/tomcat.nsi webapps/docs/changelog.xml

2011-05-04 Thread Konstantin Kolinko
} (...) Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: BIO performance issues

2011-05-04 Thread Konstantin Kolinko
the NIO connector as the default one in Tomcat 7. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: BIO performance issues

2011-05-04 Thread Konstantin Kolinko
2011/5/4 Mark Thomas ma...@apache.org: On 04/05/2011 12:04, Konstantin Kolinko wrote: I do not quite get what happens in 6s. My first understanding from reading the scenario was that the threads at 2s are busy because we need them to process keep-alive connections. Then I see that at 6s keep

Re: Why AstValue (part of EL) coerces set value to the target type

2011-05-08 Thread Konstantin Kolinko
#getType() in trunk performs a bit differently. BTW, a workaround in your case might be to do assignment in two steps: first assign null, and then assign the actual value. Best regards, Konstantin Kolinko - To unsubscribe, e-mail

Re: svn commit: r1095686 - in /tomcat/trunk/java/org/apache/jasper: compiler/DefaultErrorHandler.java resources/LocalStrings.properties

2011-05-08 Thread Konstantin Kolinko
2011/4/22 Konstantin Kolinko knst.koli...@gmail.com: 2011/4/21  ma...@apache.org: Author: markt Date: Thu Apr 21 12:50:40 2011 New Revision: 1095686 URL: http://svn.apache.org/viewvc?rev=1095686view=rev Log: i18n for r1090763 Modified:    tomcat/trunk/java/org/apache/jasper/compiler

Re: svn commit: r1100940 - in /tomcat/trunk: java/org/apache/catalina/valves/LocalStrings.properties java/org/apache/catalina/valves/RemoteIpValve.java webapps/docs/changelog.xml webapps/docs/config/v

2011-05-09 Thread Konstantin Kolinko
, the +default of codenull/code is used./p Maybe treat an empty string as if it were he null. Is all this intended for HTTP/1.0 or 0.9 requests? (HTTP/1.1 ones should have Host: header) Best regards, Konstantin Kolinko

Re: svn commit: r1100992 - in /tomcat/trunk: java/org/apache/catalina/core/ApplicationSessionCookieConfig.java webapps/docs/changelog.xml

2011-05-09 Thread Konstantin Kolinko
I have seen applications where /webappname is not redirected to /webappname/ but is served as is. IIRC, that happens when there is no welcome file. If I understand correctly, this change will break them. Maybe make it conditional? For reference, discussion on users@ [1]

Re: [PROPOSAL] Move to svnpubsub for /dist/tomcat

2011-05-18 Thread Konstantin Kolinko
thought whether you proposal will facilitate such migration, or impede it? Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [PROPOSAL] Move to svnpubsub for /dist/tomcat

2011-05-18 Thread Konstantin Kolinko
, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1124644 - in /tomcat/trunk/webapps/docs: changelog.xml config/listeners.xml

2011-05-19 Thread Konstantin Kolinko
2011/5/19 ma...@apache.org: Author: markt Date: Thu May 19 09:43:59 2011 New Revision: 1124644 URL: http://svn.apache.org/viewvc?rev=1124644view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51182 Better organisation of listeners doc Add JAAS/JMX listener info Patch

Re: Fixing bug 33453

2011-05-23 Thread Konstantin Kolinko
like a separate (un)related issue. 3) Typo in generated comment in Generator.java, s/to assit/to assist/ Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail

Re: [PROPOSAL] Move to svnpubsub for /dist/tomcat

2011-05-24 Thread Konstantin Kolinko
area). Anyway, the current scope is dist at www.apache.org, which does not interfere with the area on tomcat.apache.org. Assuming no objections, I'll progress this with infra in the next week or so. Good. Best regards, Konstantin Kolinko

Re: svn commit: r1132362 - in /tomcat/trunk/java/org/apache/coyote/http11: AbstractHttp11Processor.java Http11AprProcessor.java Http11NioProcessor.java Http11Processor.java

2011-06-05 Thread Konstantin Kolinko
, but general notion is that exception creation is expensive. Maybe we can use a cached copy of NumberFormatException, like o.a.naming.resources.ImmutableNameNotFoundException By the way, there are two HexUtils classes in trunk. Do we need both? Best regards, Konstantin Kolinko

Re: [PROPOSAL] Enable session replication by default.

2011-06-07 Thread Konstantin Kolinko
. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [PROPOSAL] Enable session replication by default.

2011-06-07 Thread Konstantin Kolinko
() never returns null. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2011-06-15 Thread Konstantin Kolinko
at org.apache.catalina.core.TestAsyncContextImpl.validateAccessLog(TestAsyncContextImpl.java:1052) at org.apache.catalina.core.TestAsyncContextImpl.testListeners(TestAsyncContextImpl.java:628) Best regards, Konstantin Kolinko 2011/6/15 Bill Barker billbar...@apache.org: To whom it may engage... This is an automated request

Re: Embedding Tomcat 7 in Apache OFBiz

2011-06-16 Thread Konstantin Kolinko
!=null check there. Though I do not know whether it will fail further down the road. The same may be said about similar code in removeMapping() method. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr

Re: [VOTE] Release Apache Tomcat 7.0.16

2011-06-16 Thread Konstantin Kolinko
not observe the issue. All other tests in the testsuite did run successfully: BIO, NIO, APR, with Oracle JDK 6u25 32-bit on Windows XP Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

Diagram for AsyncStateMachine.java

2011-06-18 Thread Konstantin Kolinko
it yet. Feel free to enjoy and comment. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Wiki spam prevention measure

2011-06-19 Thread Konstantin Kolinko
) There is PoweredBy page that has hundred of different authors. I am not ready to manage those people. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h

Re: Diagram for AsyncStateMachine.java

2011-06-19 Thread Konstantin Kolinko
2011/6/19 Mark Thomas ma...@apache.org: On 19/06/2011 01:15, Konstantin Kolinko wrote: I have redrawn the state diagram for trunk's org/apache/coyote/AsyncStateMachine.java. Why? I was trying to understand the logic behind the states and similarities between them, without looking too much

Re: svn commit: r1137607 - /tomcat/trunk/bin/catalina.sh

2011-06-20 Thread Konstantin Kolinko
$CATALINA_OPTS to the version command, so we get consistent JVM behavior. -d32/-d64 flag should go into JAVA_OPTS, so that stop command were using it as well. Maybe let version command to print out the content of JAVA_OPTS and CATALINA_OPTS variables? Best regards, Konstantin Kolinko

Re: OneLineFormatter by default?

2011-06-20 Thread Konstantin Kolinko
. Regarding grep: Some grep implementations (e.g. the GNU one) have --context, --before-context, --after-context options to print several lines of context for each match (section 2.1.5 in [1]). [1]: http://www.gnu.org/software/grep/manual/ Best regards, Konstantin Kolinko

Re: svn commit: r1137803 - /tomcat/trunk/webapps/docs/changelog.xml

2011-06-21 Thread Konstantin Kolinko
, chronologically. They eventually become mixed with the numbered issues. (I.e., numbered issues to not pop up wrt. others). Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e

Re: Overhauling setclasspath.(bat|sh)?

2011-06-21 Thread Konstantin Kolinko
%\endorsed but given that it always is equal to CATALINA_HOME I think it is OK to replace it with CATALINA_HOME. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e

Re: svn commit: r1137638 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11AprProcessor.java Http11AprProtocol.java

2011-06-21 Thread Konstantin Kolinko
); +                        state = processor.asyncDispatch(status);                     } else if (processor.comet) {                         state = processor.event(status);                     } else { Best regards, Konstantin Kolinko

Re: svn commit: r1137638 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11AprProcessor.java Http11AprProtocol.java

2011-06-21 Thread Konstantin Kolinko
2011/6/21 Mark Thomas ma...@apache.org: On 21/06/2011 13:00, Konstantin Kolinko wrote: Why setting socket reference in InputBuffer and OutputBuffer is unnecessary here in async processing, but is still present for the non-async case. Because during the processing of a request, asyncDispatch

Re: svn commit: r1138573 - in /tomcat/trunk: java/org/apache/catalina/startup/Tomcat.java webapps/docs/changelog.xml

2011-06-22 Thread Konstantin Kolinko
#getWebXmlSource(defaultWebXml, baseDir) to return null An alternative to 2)+3) is to put the constant into DefaultWebXmlListener, but I like 2)+3) better. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr

Re: Supporting more general globs in loader definition?

2011-06-23 Thread Konstantin Kolinko
. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Multiple instances of the same Tomcat version (was: svn commit: r1139381)

2011-06-24 Thread Konstantin Kolinko
of Tomcat and later uses the port specified there to stopping launched Tomcat. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h

Re: Multiple instances of the same Tomcat version (was: svn commit: r1139381)

2011-06-25 Thread Konstantin Kolinko
2011/6/25 Konstantin Kolinko knst.koli...@gmail.com: Though I suspect that for running as a service that value can be -1, thought Sorry, I did not notice that shutdown port has already been changed. (I looked in the file, but did not notice that my svn update command had failed). 2

Re: svn commit: r1139576 - in /tomcat/trunk/webapps/docs: changelog.xml project.xml upgrading.xml

2011-06-27 Thread Konstantin Kolinko
/index.html Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1140204 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java

2011-06-27 Thread Konstantin Kolinko
: charset.aliases()) { +                encodingToCharsetCache.put(alias, charset); Should be: s/alias/alias.toLowerCase(Locale.US)/ +            }         }     } I was wondering how slow is Charset.availableCharsets(). In my test it is about 100ms. Nothing to worry about. Best regards, Konstantin

Re: JK 1.2.32 release kick

2011-06-27 Thread Konstantin Kolinko
2011/6/27 Mladen Turk mt...@apache.org: Hi, I have a time slot available so I volunteer as a 1.2.32 RM. Think we are good for a new release. Comments, objections? Sounds good. +1. Best regards, Konstantin Kolinko

Re: svn commit: r1140467 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-06-28 Thread Konstantin Kolinko
your vote in place as the changes are essentially addressing your review comments but the comments did prompt a couple of related changes so you may want to look at this again. OK with me. The new patch is good one. Best regards, Konstantin Kolinko

Re: svn commit: r1140383 - in /tomcat: tc5.5.x/trunk/STATUS.txt tc6.0.x/trunk/STATUS.txt

2011-06-28 Thread Konstantin Kolinko
%=attributeName% or ${attributeName} as a shortcut although I don't currently see anything to support that usage in the JSP specification. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

Re: svn commit: r1140383 - in /tomcat: tc5.5.x/trunk/STATUS.txt tc6.0.x/trunk/STATUS.txt

2011-06-28 Thread Konstantin Kolinko
a periodToUnderscore parameter to makeJavaIdentifier() and essnetially have both approaches. The current one for file names, the new one for variable names. Or better just add a separate method. Best regards, Konstantin Kolinko

Re: response.encodeURL(http://localhost:8080) produces an invalid URL?

2011-06-29 Thread Konstantin Kolinko
if it is an absolute URL, scheme is http or https and the path is empty. (I guess that there is a check for the scheme name already?). So that it becomes http://localhost:8080/;jsessionid=... Best regards, Konstantin Kolinko - To unsubscribe, e

Re: response.encodeURL(http://localhost:8080) produces an invalid URL?

2011-06-29 Thread Konstantin Kolinko
2011/6/29 Erik Bertelsen bertelsen.e...@gmail.com: 2011/6/29 Konstantin Kolinko knst.koli...@gmail.com: From HTTP standpoint it should be http://localhost:8080/ and in my experience browsers add the trailing slash automatically. I have not looked whether the actual HTTP spec is more strict

Re: svn commit: r1141388 - /tomcat/native/trunk/native/src/sslcontext.c

2011-06-30 Thread Konstantin Kolinko
/src/sslcontext.c -        cb_data-password[0] = '\0'; The above line inside the loop in the old code - I guess it was retrying without a password. With your change that retry is gone. Is that OK? (Just guessing, I do not know much of that code). Best regards, Konstantin Kolinko

Re: Tagging 7.0.17

2011-07-01 Thread Konstantin Kolinko
. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Multiple instances of the same Tomcat version (was: svn commit: r1139381)

2011-07-01 Thread Konstantin Kolinko
2011/6/25 Konstantin Kolinko knst.koli...@gmail.com: 2011/6/25 Konstantin Kolinko knst.koli...@gmail.com: Though I suspect that for running as a service that value can be -1, thought Sorry, I did not notice that shutdown port has already been changed. (I looked in the file, but did

Re: svn commit: r981842 - /tomcat/trunk/webapps/docs/changelog.xml

2010-08-03 Thread Konstantin Kolinko
2010/8/3 ma...@apache.org: +      update +        Update to Commons Daemon from 1.0.2 to 1.0.3.(markt) +      /update One to should be enough. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr

Re: SharingWebappClassLoader proposal

2010-08-03 Thread Konstantin Kolinko
for trouble. A web application and be unloaded (stopped, reloaded) at any time. Since that moment any classes loaded by its classloader should not be accesses any more. Thus, no other web applications should keep references to them. Best regards, Konstantin Kolinko

Re: svn commit: r960864 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-08-03 Thread Konstantin Kolinko
2010/8/3 Mark Thomas ma...@apache.org: On 07/07/2010 12:16, Mark Thomas wrote: On 07/07/2010 11:36, Konstantin Kolinko wrote: It is not mentioned there that Java language keywords are also reserved. Yes it is. Section 1.19 in the EL 2.2 spec. 3) I agree, that it is possible to read

Re: Sharing Native Library from parent classloader?

2010-08-09 Thread Konstantin Kolinko
in ${catalina.base}\lib and at the same time _remove_ it from your webapp. The result will be that it will be loaded by the Common classloader. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2010-08-11 Thread Konstantin Kolinko
/compile/logs/stdio says: BUILD FAILED /home/buildslave3/slave3/tomcat-trunk/build/build.xml:440: Unable to find a javac compiler; com.sun.tools.javac.Main is not on the classpath. Best regards, Konstantin Kolinko - To unsubscribe, e

Re: [g...@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2010-08-24 Thread Konstantin Kolinko
) at org.apache.catalina.authenticator.TestFormAuthenticator.doTest(TestFormAuthenticator.java:59) at org.apache.catalina.authenticator.TestFormAuthenticator.testGet(TestFormAuthenticator.java:30) Best regards, Konstantin Kolinko - To unsubscribe, e

Re: Links to Sun/Oracle on welcome page

2010-08-25 Thread Konstantin Kolinko
to tomcat.apache.org, or to local /docs/ ? Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Links to Sun/Oracle on welcome page

2010-08-27 Thread Konstantin Kolinko
mind, that not only those two specs might be important, but also some others, like the ones mentioned here: http://markmail.org/message/olpuftjrqhcfk3vb Maybe create a Wiki page to list the relevant specification links? (I don't have time now, but maybe later). Best regards, Konstantin Kolinko

Re: Finding the context of a Request at the point of parsing session

2010-08-29 Thread Konstantin Kolinko
. If I am reading the code correctly, parseSessionId() call modifies the req.requestURI() bytechunk if a semicolon was there. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional

Using JDK compiler with Tomcat (was: Re: svn commit: r999941)

2010-09-22 Thread Konstantin Kolinko
that that phrase can be removed. Am I missing anything else? Reading Using Jikes part there, http://tomcat.apache.org/tomcat-5.5-doc/jasper-howto.html#Using_Jikes maybe it means, that one has to edit conf/web.xml and set the compiler parameter of JspServlet to the value of javac? Best regards, Konstantin

Re: svn commit: r1000003 - /tomcat/trunk/webapps/docs/logging.xml

2010-09-22 Thread Konstantin Kolinko
that are caught by Tomcat are printed to catalina.date.log, not only to the console. Maybe that phrase can be removed as a whole. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional

Re: NamingContext Possible Bug

2010-09-23 Thread Konstantin Kolinko
and a ResourceLink in your context.xml. [2] It would be undesirable to break that. [1] https://issues.apache.org/bugzilla/show_bug.cgi?id=47512 [2] http://tomcat.apache.org/tomcat-6.0-doc/jndi-resources-howto.html#context.xml_configuration Best regards, Konstantin Kolinko

Re: svn commit: r1001216 - /tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml

2010-09-26 Thread Konstantin Kolinko
2010/9/26 sebb seb...@gmail.com: On 26 September 2010 10:00, Tim Whittington t...@apache.org wrote: Bah. Trying to convince Eclipse not to use tabs is proving tricky - will be more vigilent.. Hit me too amny times. The tabs setting for the XML editor is in a different place: Preferences /

Re: [OT] Difficulty creating working patch - renamed file.

2010-09-28 Thread Konstantin Kolinko
regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1002277 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-09-28 Thread Konstantin Kolinko
2010/9/28 Mladen Turk mt...@apache.org: On 09/28/2010 08:16 PM, Konstantin Kolinko wrote: 2010/9/28 Mladen Turkmt...@apache.org: On 09/28/2010 07:24 PM, ma...@apache.org wrote: Author: markt +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49665 +  Better handling for missing TLD

Re: svn commit: r964780 - in /tomcat/trunk: java/org/apache/catalina/servlets/WebdavServlet.java webapps/docs/changelog.xml

2010-10-03 Thread Konstantin Kolinko
, XMLWriter.OPENING); generatedXML.writeElement(D, null, href, XMLWriter.OPENING); and so on. Best regards, Konstantin Kolinko

Re: Site redesign

2010-10-04 Thread Konstantin Kolinko
design has all pages and subsections listed in well defined manner. The proposed one has information scattered all over the place. For the ROOT webapp that was OK because that app is effectively a single page. Best regards, Konstantin Kolinko

Re: svn commit: r1004393 - /tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java

2010-10-05 Thread Konstantin Kolinko
, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [taglibs] Pick common format for test class names

2010-10-10 Thread Konstantin Kolinko
of the latter 2 to avoid conflicts with inner classes (e.g. TestTransformSupport$1) I do not know surefire, but the above file masks end with *.java, and your inner classes do not have .java suffix in them. Is there really a problem?? Best regards, Konstantin Kolinko

Re: svn commit: r1005192 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-10-13 Thread Konstantin Kolinko
into account the path segment where it was applied. The proposed patch strips information on the parameters from the path. How the application is supposed to have access to them? Best regards, Konstantin Kolinko - To unsubscribe, e-mail

Re: svn commit: r1005192 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-10-13 Thread Konstantin Kolinko
, I can imagine a scenario that this issue may be seen a) start Tomcat and make a bookmark that includes jsessionid in its path b) reconfigure Tomcat to use a different name for jsessionid parameter c) the bookmark no longer works. Best regards, Konstantin Kolinko

Re: svn commit: r1022117 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/catalina/core/ApplicationContext.java java/org/apache/catalina/core/StandardContext.java webapps/docs/changelog.xml

2010-10-13 Thread Konstantin Kolinko
? There are a lot of non-final fields in ApplicationContext and I think in related classes as well. I do not think making this specific one as final is essential. (Anyway, +1 if anybody wants to do that). Best regards, Konstantin Kolinko

Recycling processors in Http11NioProtocol

2010-10-13 Thread Konstantin Kolinko
. log.error(sm.getString(http11protocol.proto.error), e); } +connections.remove(socket); +processor.recycle(); recycledProcessors.offer(processor); return SocketState.CLOSED; } ]]] Best regards, Konstantin Kolinko Index: java/org/apache

Re: svn commit: r1022117 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/catalina/core/ApplicationContext.java java/org/apache/catalina/core/StandardContext.java webapps/docs/changelog.xml

2010-10-14 Thread Konstantin Kolinko
2010/10/14 sebb seb...@gmail.com: On 14 October 2010 00:05, Konstantin Kolinko knst.koli...@gmail.com wrote: Re: sebb: 2010/10/13 sebb seb...@gmail.com: -    private Map parameters = null; +    private MapString,String parameters = +        new ConcurrentHashMapString,String(); This should

Re: svn commit: r1005192 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-10-14 Thread Konstantin Kolinko
2010/10/13 Mark Thomas ma...@apache.org: On 13/10/2010 16:57, Konstantin Kolinko wrote: 2010/10/6  ma...@apache.org: Author: markt Date: Wed Oct  6 18:03:03 2010 New Revision: 1005192 URL: http://svn.apache.org/viewvc?rev=1005192view=rev Log: Proposal Modified:    tomcat/tc6.0.x/trunk

Re: Recycling processors in Http11NioProtocol

2010-10-14 Thread Konstantin Kolinko
2010/10/14 Mark Thomas ma...@apache.org: On 14/10/2010 01:01, Konstantin Kolinko wrote: Hi! Looking at the Http11NioProtocol.Http11ConnectionHandler.release(NioChannel socket) method in Http11NioProtocol.java,  it looks for me that like that method does in all other places before any call

Re: JmxRemoteLifecycleListener and com.sun.security.auth.module.LdapLoginModule JMX authentification

2010-10-14 Thread Konstantin Kolinko
may change it. Should I open a BZ for this one ? I do not see a problem here, but if you are to propose some patch/enhancement then you are welcome, as always. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev

Re: svn commit: r1005192 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-10-15 Thread Konstantin Kolinko
2010/10/14 Mark Thomas ma...@apache.org: On 14/10/2010 09:02, Konstantin Kolinko wrote: OK. Looks that the patch is working.  The snoop.jsp displays the full original path as Request URI (aka request.getRequestURI()). Other things there 1) Add http://svn.apache.org/viewvc?rev=1022389view=rev

Re: svn commit: r1022606 - in /tomcat/trunk/java: javax/el/BeanELResolver.java org/apache/el/lang/ExpressionBuilder.java org/apache/el/util/ConcurrentCache.java

2010-10-15 Thread Konstantin Kolinko
will be more suitable here, because there will be a thousand of reads for a single write. this.eden.clear(); Shouldn't the above line be inside the lock as well? Best regards, Konstantin Kolinko - To unsubscribe

Re: svn commit: r1022606 - in /tomcat/trunk/java: javax/el/BeanELResolver.java org/apache/el/lang/ExpressionBuilder.java org/apache/el/util/ConcurrentCache.java

2010-10-16 Thread Konstantin Kolinko
matter -  there's a race on the overflow logic anyway, so it'll still be called twice (and the underlying map is concurrent). Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

Re: bugzilla question : bugs fixed in trunk but not yet in tc6

2010-10-22 Thread Konstantin Kolinko
that the bug is assigned to: we move it to the one where it is still present: to TC6, then to TC5. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h

Re: svn commit: r1022606 - in /tomcat/trunk/java: javax/el/BeanELResolver.java org/apache/el/lang/ExpressionBuilder.java org/apache/el/util/ConcurrentCache.java

2010-10-22 Thread Konstantin Kolinko
2010/10/16 Konstantin Kolinko knst.koli...@gmail.com: 2010/10/16 Tim Whittington t...@apache.org: Modified:    tomcat/trunk/java/javax/el/BeanELResolver.java    tomcat/trunk/java/org/apache/el/lang/ExpressionBuilder.java    tomcat/trunk/java/org/apache/el/util/ConcurrentCache.java Modified

Re: bugzilla question : bugs fixed in trunk but not yet in tc6

2010-10-23 Thread Konstantin Kolinko
tell us that it was fixed in 7.0.3 ?? http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml (as mentioned on http://tomcat.apache.org/bugreport.html#Recently_fixed_issues ) Best regards, Konstantin Kolinko

Re: svn commit: r1026723 - in /tomcat/taglibs/standard/trunk: compat/ compat/src/main/java/org/apache/taglibs/standard/tag/compat/core/ impl/src/main/java/org/apache/taglibs/standard/tag/common/core/

2010-10-24 Thread Konstantin Kolinko
leak from retained references Added:     tomcat/taglibs/standard/trunk/compat/src/main/java/org/apache/taglibs/standard/tag/compat/core/OutTag.java svn:eol-style (and svn:keywords) are not set on this OutTag.java and on a number of other files that were added recently Best regards, Konstantin

Re: Is it possible to handle exception on ant build?

2010-10-28 Thread Konstantin Kolinko
and support options there. Offtopic: I think that there are a lot of options to solve your problem. E.g.: 1) check return value (aka exit code) of Ant, 2) use failonerror=false and errorProperty attributes on the javac task Best regards, Konstantin Kolinko

Re: Is it possible to handle exception on ant build?

2010-10-28 Thread Konstantin Kolinko
2010/10/28 pannar nsveera2...@yahoo.co.in: I am new to this forum. Please move redirect me to ant users forum with this thread. It is not a forum. It is a mailing list. - To unsubscribe, e-mail:

Re: svn commit: r1029423 - in /tomcat: tc5.5.x/trunk/STATUS.txt tc6.0.x/trunk/STATUS.txt

2010-11-01 Thread Konstantin Kolinko
-if-native-dll-is-compiled-as-x64-or-x86 4. We can write a Java class and execute it with javaw.exe System.getProperty(os.arch); [4] http://stackoverflow.com/questions/807263/how-do-i-detect-which-kind-of-jre-is-installed-32bit-vs-64bit Best regards, Konstantin Kolinko

Re: configtest

2010-11-03 Thread Konstantin Kolinko
); +} +System.exit(0); where load(args) processes command line arguments, parses server.xml and also calls getServer().init(); I like it. My +1 Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr

<    2   3   4   5   6   7   8   9   10   11   >