"Embedded" improvements

2018-10-24 Thread Rémy Maucherat
Hi, I'm starting to review embedded. Maybe I won't make many changes in the end and won't need a separate API. However, I have another post 9.0.13 refactoring with a redoing of ConfigFileLoader and various places which try to load the configuration from seemingly random locations (the winner is

Re: "Embedded" improvements

2018-10-29 Thread Rémy Maucherat
On Wed, Oct 24, 2018 at 11:54 AM Rémy Maucherat wrote: > Hi, > > I'm starting to review embedded. Maybe I won't make many changes in the > end and won't need a separate API. > > However, I have another post 9.0.13 refactoring with a redoing of > ConfigFileLoader and var

Re: Mime types

2018-11-01 Thread Rémy Maucherat
On Thu, Nov 1, 2018 at 2:34 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > Why bother even doing that? File-extension mapping is a poor way to > perform file-type detection (in fact, it is NOT file type detection), > but the spec mandates it, so we are stuck. > > But why bother

Mime types

2018-10-31 Thread Rémy Maucherat
Hi, There are two main contraptions in Tomcat that do (badly ...) extension to mime type mapping: the shared web.xml and some hardcoded stuff in startup.Tomcat. While we should obviously have support for user configured mime types in web.xml, as it's the spec, there should be a possibility to

Re: Mime types

2018-10-31 Thread Rémy Maucherat
On Wed, Oct 31, 2018 at 8:16 PM Konstantin Kolinko wrote: > ср, 31 окт. 2018 г. в 19:38, Rémy Maucherat : > > > > Hi, > > > > There are two main contraptions in Tomcat that do (badly ...) extension > to > > mime type mapping: the shared web.xml and some h

Re: Mime types

2018-10-31 Thread Rémy Maucherat
On Wed, Oct 31, 2018 at 10:30 PM Igal Sapir wrote: > >> Unless DefaultServlet behaviour is fixed, enabling probeContentType is > >> likely to break my configurations. > > How about allowing to remove a Mime type by mapping it to an empty > string? That way you would only need to override that

Re: JDK 12 Early Access build 15 is available

2018-10-30 Thread Rémy Maucherat
On Tue, Oct 30, 2018 at 6:42 PM Mark Thomas wrote: > FYI, > > org.apache.tomcat.util.net.TestSsl.testRenegotiateWorks() is failing > consistently when running with the NIO2 connector. > > It works with: > - Oracle JDK 1.8.0 update 192 > - Oracle JDK 9.0.4 > - Oracle JDK 10.0.2 > > It fails with:

Re: svn commit: r1845203 - /tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/EncryptInterceptor.java

2018-10-30 Thread Rémy Maucherat
On Tue, Oct 30, 2018 at 10:02 AM Mark Thomas wrote: > On 30/10/18 09:00, ma...@apache.org wrote: > > Author: markt > > Date: Tue Oct 30 09:00:33 2018 > > New Revision: 1845203 > > > > URL: http://svn.apache.org/viewvc?rev=1845203=rev > > Log: > > Copy code to avoid unwanted dependency. > > The

Re: JDK 12 Early Access build 15 is available

2018-10-31 Thread Rémy Maucherat
On Tue, Oct 30, 2018 at 7:12 PM Mark Thomas wrote: > Ah. More likely a JDK regression then. > > After enabling it for NIO, it also fails. Works with an "older" 11-ea18 I had, fails with 12-ea17. Basically it makes the 10 requests, but the listener set with socket.addHandshakeCompletedListener is

Re: For review: EncryptInterceptor for Cluster/Tribes

2018-10-25 Thread Rémy Maucherat
On Thu, Oct 25, 2018 at 5:15 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > All, > > Bump. > > I have a full patch at this point (still without documentation), but > this one includes resolution of the IV issue and also a set

Re: svn commit: r1845800 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/servlets/DefaultServlet.java webapps/docs/changelog.xml

2018-11-05 Thread Rémy Maucherat
On Mon, Nov 5, 2018 at 3:17 PM wrote: > Author: remm > Date: Mon Nov 5 14:17:56 2018 > New Revision: 1845800 > > URL: http://svn.apache.org/viewvc?rev=1845800=rev > Log: > Default servlet will no longer override content-type > And I won't backport it to 7.0 since the behavior might well be

Re: svn commit: r1845136 - in /tomcat/trunk: java/org/apache/catalina/connector/Connector.java java/org/apache/tomcat/util/net/AbstractEndpoint.java webapps/docs/changelog.xml

2018-10-29 Thread Rémy Maucherat
On Mon, Oct 29, 2018 at 4:17 PM wrote: > Author: markt > Date: Mon Oct 29 15:17:01 2018 > New Revision: 1845136 > > URL: http://svn.apache.org/viewvc?rev=1845136=rev > Log: > Refactor the Connector so that the port is obtained from the Endpoint > rather than a local field that could end up out

Re: svn commit: r1845136 - in /tomcat/trunk: java/org/apache/catalina/connector/Connector.java java/org/apache/tomcat/util/net/AbstractEndpoint.java webapps/docs/changelog.xml

2018-10-29 Thread Rémy Maucherat
On Mon, Oct 29, 2018 at 6:13 PM Mark Thomas wrote: > On 29/10/2018 16:56, Mark Thomas wrote: > > On 29/10/2018 16:41, Rémy Maucherat wrote: > >> On Mon, Oct 29, 2018 at 4:17 PM wrote: > >> > >>> Author: markt > >>> Date: Mon Oct 29 15:17:01 201

Re: "Embedded" improvements

2018-10-29 Thread Rémy Maucherat
On Mon, Oct 29, 2018 at 6:46 PM Mark Thomas wrote: > On 29/10/2018 10:52, Rémy Maucherat wrote: > > On Wed, Oct 24, 2018 at 11:54 AM Rémy Maucherat wrote: > > > >> Hi, > >> > >> I'm starting to review embedded. Maybe I won't make many changes in

Re: [VOTE] Release Apache Tomcat 8.5.35

2018-11-05 Thread Rémy Maucherat
On Sat, Nov 3, 2018 at 6:55 PM Mark Thomas wrote: > The proposed Apache Tomcat 8.5.35 release is now available for voting. > > The major changes compared to the 8.5.34 release are: > > - support for TLSv1.3 when used with a JRE or OpenSSl version that > supports it > > - multiple improvements

Re: [VOTE] Release Apache Tomcat 9.0.13

2018-11-05 Thread Rémy Maucherat
On Mon, Nov 5, 2018 at 8:43 AM Romain Manni-Bucau wrote: > +1 (non-binding), tested on meecrowave and some work projects > Well, I guess "ads" are useful sometimes. I looked at the code of meecrowave just right now, and it looks like my embedded improvements are relevant and could avoid a

Re: buildbot failure in on tomcat-trunk

2018-11-08 Thread Rémy Maucherat
On Thu, Nov 8, 2018 at 11:57 AM wrote: > The Buildbot has detected a new failure on builder tomcat-trunk while > building . Full details are available at: > https://ci.apache.org/builders/tomcat-trunk/builds/3719 > > Buildbot URL: https://ci.apache.org/ > > Buildslave for this Build:

Re: L10n / I18n

2018-11-08 Thread Rémy Maucherat
On Thu, Nov 8, 2018 at 3:47 PM Mark Thomas wrote: > On 08/11/2018 00:16, Emmanuel Bourg wrote: > > Le 07/11/2018 à 23:36, Mark Thomas a écrit : > > > >> WDYT? > > > > What about simplifying the issue by dropping the translations of the > > internal messages and retaining only the user facing

Re: L10n / I18n

2018-11-08 Thread Rémy Maucherat
On Thu, Nov 8, 2018 at 11:00 PM Marek Czernek wrote: > On 11/8/18 1:16 AM, Emmanuel Bourg wrote: > > Le 07/11/2018 à 23:36, Mark Thomas a écrit : > > > >> WDYT? > > What about simplifying the issue by dropping the translations of the > > internal messages and retaining only the user facing

Re: svn commit: r1846691 - /tomcat/trunk/TOMCAT-NEXT.txt

2018-11-15 Thread Rémy Maucherat
On Fri, Nov 16, 2018 at 12:35 AM wrote: > 2. Remove org.apache.tomcat.jni and replace with the minimum necessary to > interface with OpenSSL and clones. > +We might want to park this one until we see what is available direct > from > +the JRE with project Panama. > Ok, I guess

Re: Threads

2018-11-06 Thread Rémy Maucherat
On Tue, Nov 6, 2018 at 6:39 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > > Otherwise, at the moment, the behavior is the same as before: if > > an exception remains uncaught like your OOM or ThreadDeath or > > whatever, it will cancel the scheduling (and I haven't added the > >

Re: Threads

2018-11-07 Thread Rémy Maucherat
On Wed, Nov 7, 2018 at 12:17 AM Rémy Maucherat wrote: > On Tue, Nov 6, 2018 at 6:39 PM Christopher Schultz < > ch...@christopherschultz.net> wrote: > >> > , and the javadoc says: If any execution of the task encounters an >> > exception, subsequent executions

Re: [VOTE] Release Apache Tomcat 7.0.92

2018-11-14 Thread Rémy Maucherat
On Fri, Nov 9, 2018 at 12:34 PM Violeta Georgieva wrote: > The proposed Apache Tomcat 7.0.92 release is now available for voting. > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.92/ > The Maven staging repo is: >

Re: Threads

2018-11-06 Thread Rémy Maucherat
On Tue, Nov 6, 2018 at 4:18 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > This reply is quite late, I'm sorry for that. > > I'm not sure if this has changed since a while back, but it used to be > that an application could inadvertently kill the background thread. > One way to

Re: [VOTE] Release Apache Tomcat 9.0.13

2018-11-02 Thread Rémy Maucherat
On Fri, Nov 2, 2018 at 5:11 PM Mark Thomas wrote: > The proposed Apache Tomcat 9.0.13 release is now available for voting. > > The major changes compared to the 9.0.13 release are: > > - support for TLSv1.3 when used with a JRE or OPenSSl version that > supports it > > - added support for

Re: Cloud clustering support using Kubernetes

2018-10-04 Thread Rémy Maucherat
On Thu, Oct 4, 2018 at 7:23 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Rémy, > > On 10/4/18 05:26, Rémy Maucherat wrote: > > On Wed, Oct 3, 2018 at 10:27 PM Christopher Schultz < > &

Cloud clustering support using Kubernetes

2018-10-03 Thread Rémy Maucherat
Hi, As I talked about during the latest TomcatCon (and the previous one in London actually ...), there's a cloud aware cluster members provider that can be contributed to Tomcat. The current code is here: https://github.com/rmaucher/tomcat-in-the-cloud It uses Kubernetes to retrieve the members

Re: Cloud clustering support using Kubernetes

2018-10-03 Thread Rémy Maucherat
On Wed, Oct 3, 2018 at 4:35 PM Mark Thomas wrote: > On 03/10/18 14:48, Rémy Maucherat wrote: > > Hi, > > > > As I talked about during the latest TomcatCon (and the previous one in > > London actually ...), there's a cloud aware cluster members provider that >

Re: svn commit: r1842849 - in /tomcat/trunk: java/org/apache/tomcat/jni/Library.java test/org/apache/tomcat/util/net/TesterSupport.java test/org/apache/tomcat/util/net/openssl/TestOpenSSLConf.java

2018-10-05 Thread Rémy Maucherat
On Fri, Oct 5, 2018 at 11:40 AM Mark Thomas wrote: > On 04/10/18 22:07, isa...@apache.org wrote: > > Author: isapir > > Date: Thu Oct 4 21:07:54 2018 > > New Revision: 1842849 > > > > URL: http://svn.apache.org/viewvc?rev=1842849=rev > > Log: > > System.load() expects absolute path. > >

Re: [GUMP@vmgump-vm3]: Project tomcat-trunk (in module tomcat-trunk) failed

2018-10-09 Thread Rémy Maucherat
On Tue, Oct 9, 2018 at 4:45 AM Bill Barker wrote: > The following work was performed: > > http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk/gump_work/build_tomcat-trunk_tomcat-trunk.html > Work Name: build_tomcat-trunk_tomcat-trunk (Type: Build) > Work ended in a state of : Failed >

Re: svn commit: r1843285 - in /tomcat/trunk: TOMCAT-NEXT.txt build.properties.default build.xml java/org/apache/catalina/tribes/membership/cloud/KubernetesMembershipProvider.java res/checkstyle/org-im

2018-10-09 Thread Rémy Maucherat
On Tue, Oct 9, 2018 at 3:56 PM wrote: > Author: remm > Date: Tue Oct 9 13:56:25 2018 > New Revision: 1843285 > > URL: http://svn.apache.org/viewvc?rev=1843285=rev > Log: > Switch from OpenJSON to Noggit. > > Modified: > tomcat/trunk/TOMCAT-NEXT.txt >

Re: Cloud clustering support using Kubernetes

2018-10-04 Thread Rémy Maucherat
On Wed, Oct 3, 2018 at 10:27 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Rémy, > > On 10/3/18 09:48, Rémy Maucherat wrote: > > Hi, > > > > As I talked about during the latest Tom

Re: Cloud clustering support using Kubernetes

2018-10-04 Thread Rémy Maucherat
On Thu, Oct 4, 2018 at 12:58 PM Mark Thomas wrote: > On 04/10/18 11:48, Martin Grigorov wrote: > > Hi, > > > > I cannot find the original mail now (I think it was sent by Bertrand > > Delacretaz two years ago) but json.org's licence is not ASL2 compatible. > > For that reason several Apache

Re: svn commit: r1843328 - /tomcat/trunk/java/org/apache/catalina/tribes/membership/cloud/CertificateStreamProvider.java

2018-10-09 Thread Rémy Maucherat
On Tue, Oct 9, 2018 at 8:56 PM Mark Thomas wrote: > On 09/10/18 19:55, ma...@apache.org wrote: > > Author: markt > > Date: Tue Oct 9 18:55:17 2018 > > New Revision: 1843328 > > > > URL: http://svn.apache.org/viewvc?rev=1843328=rev > > Log: > > Fix unused code warning > > My IDE popped up a

Re: svn commit: r1843328 - /tomcat/trunk/java/org/apache/catalina/tribes/membership/cloud/CertificateStreamProvider.java

2018-10-09 Thread Rémy Maucherat
On Tue, Oct 9, 2018 at 9:05 PM Mark Thomas wrote: > On 09/10/18 19:58, Rémy Maucherat wrote: > > On Tue, Oct 9, 2018 at 8:56 PM Mark Thomas wrote: > > > >> On 09/10/18 19:55, ma...@apache.org wrote: > >>> Author: markt > >>> Date: Tue

Re: Tagging 9.0.x

2018-09-03 Thread Rémy Maucherat
On Mon, Sep 3, 2018 at 12:19 PM Mark Thomas wrote: > Hi all, > > As the start of September is here I'm planning to tag 9.0.x (and 8.5.x) > shortly and roll the next monthly release. > > I've a couple of things I want to look at first so I'll probably be > tagging in the next day or two. > > What

Re: Tagging 9.0.x

2018-09-03 Thread Rémy Maucherat
On Mon, Sep 3, 2018 at 12:53 PM Mark Thomas wrote: > On 03/09/18 11:40, Rémy Maucherat wrote: > > On Mon, Sep 3, 2018 at 12:19 PM Mark Thomas wrote: > > > >> Hi all, > >> > >> As the start of September is here I'm planning to tag 9.0.x (and 8.5.x) >

Re: [VOTE] Release Apache Tomcat 7.0.91

2018-09-19 Thread Rémy Maucherat
n Thu, Sep 13, 2018 at 10:28 PM Violeta Georgieva wrote: > The proposed Apache Tomcat 7.0.91 release is now available for voting. > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.91/ > The Maven staging repo is: >

Re: Extras

2019-01-14 Thread Rémy Maucherat
On Mon, Jan 14, 2019 at 12:27 PM Konstantin Kolinko wrote: > ср, 9 янв. 2019 г. в 20:10, Rémy Maucherat : > > > > Hi, > > > > So I'm looking at random small items as possible cleanups and ... The > > extras came up. > > > > At some point (15

Re: [VOTE] Release Apache Tomcat Native 1.2.20

2019-01-21 Thread Rémy Maucherat
On Mon, Jan 21, 2019 at 3:49 PM Mark Thomas wrote: > Version 1.2.20 includes the following changes compared to 1.2.19: > > - Fixed memory leak associated with the use of OpenSSL BIO (used when > OpenSSL provides the TLS functionality for the NIO and NIO2 > connectors) > > Various other fixes

Re: svn commit: r1848804 - /tomcat/trunk/java/org/apache/tomcat/util/buf/CharChunk.java

2018-12-12 Thread Rémy Maucherat
On Wed, Dec 12, 2018 at 11:17 PM wrote: > Author: markt > Date: Wed Dec 12 22:17:46 2018 > New Revision: 1848804 > > URL: http://svn.apache.org/viewvc?rev=1848804=rev > Log: > Fix an IDE nag > (only fix one to trigger a CI build) > My IDE still does not nag me, so I never do it ... Rémy

Re: svn commit: r1848806 - in /tomcat/trunk/java: javax/el/ javax/servlet/ javax/servlet/http/ org/apache/jasper/ org/apache/jasper/compiler/ org/apache/jasper/resources/ org/apache/jasper/runtime/ or

2018-12-12 Thread Rémy Maucherat
On Wed, Dec 12, 2018 at 11:29 PM wrote: > Author: remm > Date: Wed Dec 12 22:29:52 2018 > New Revision: 1848806 > > URL: http://svn.apache.org/viewvc?rev=1848806=rev > Log: > Add i18n for jasper and el packages > As far as I am concerned I am "done" for now. Maybe I'll do the bootstrap and JNI

Re: Specifying a URL for the docBase

2018-12-13 Thread Rémy Maucherat
On Thu, Dec 13, 2018 at 3:31 AM Woonsan Ko wrote: > On Mon, Dec 10, 2018 at 11:49 PM Rémy Maucherat wrote: > > > I have nothing against adding the feature (as long as I'm not doing it), > > but for the "microservice" cloud design, I would expect "s

Re: svn commit: r1848806 - in /tomcat/trunk/java: javax/el/ javax/servlet/ javax/servlet/http/ org/apache/jasper/ org/apache/jasper/compiler/ org/apache/jasper/resources/ org/apache/jasper/runtime/ or

2018-12-13 Thread Rémy Maucherat
On Thu, Dec 13, 2018 at 1:55 AM Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Rémy, > > On 12/12/18 17:42, Rémy Maucherat wrote: > > On Wed, Dec 12, 2018 at 11:29 PM wrote: > > > >>

Re: svn commit: r1848739 - in /tomcat/trunk/java/org/apache: el/ el/lang/ el/parser/ naming/factory/ naming/factory/webservices/ tomcat/util/json/ tomcat/websocket/

2018-12-12 Thread Rémy Maucherat
On Wed, Dec 12, 2018 at 11:27 AM wrote: > Author: remm > Date: Wed Dec 12 10:27:30 2018 > New Revision: 1848739 > > URL: http://svn.apache.org/viewvc?rev=1848739=rev > Log: > Add i18n for other packages > > WIP remains for javax and Jasper, I'll do that next. Then potentially the no-i18n

Re: [Bug 63009] Content-Length header is dropped when HTTP2 is used

2018-12-15 Thread Rémy Maucherat
On Sat, Dec 15, 2018 at 9:13 PM Mark Thomas wrote: > > So ... I wanted to add I have nothing against the add even if it is > > optional (like reason phrase :) ), since hpack should make that > > addition as efficient as possible. > > Fair point. > > I did consider rejecting the bug but a

Re: [Bug 63009] Content-Length header is dropped when HTTP2 is used

2018-12-14 Thread Rémy Maucherat
On Fri, Dec 14, 2018 at 11:05 PM Caldarale, Charles R < chuck.caldar...@unisys.com> wrote: > > From: Christopher Schultz [mailto:ch...@christopherschultz.net] > > Subject: Re: [Bug 63009] Content-Length header is dropped when HTTP2 is > used > > > Is this bad enough to pull and re-roll the latest

Re: svn commit: r1849311 - in /tomcat/trunk: java/org/apache/catalina/startup/LocalStrings.properties java/org/apache/catalina/startup/Tomcat.java test/org/apache/catalina/startup/TestTomcat.java weba

2018-12-19 Thread Rémy Maucherat
On Wed, Dec 19, 2018 at 5:13 PM wrote: > Author: markt > Date: Wed Dec 19 16:13:46 2018 > New Revision: 1849311 > > URL: http://svn.apache.org/viewvc?rev=1849311=rev > Log: > Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=54741 > Add a new method, Tomcat.addWebapp(String,URL), that allows a

Re: svn commit: r1847747 - in /tomcat/trunk/java/org/apache: catalina/core/LocalStrings.properties catalina/core/StandardEngine.java catalina/startup/Catalina.java catalina/startup/LocalStrings.proper

2018-11-29 Thread Rémy Maucherat
On Thu, Nov 29, 2018 at 9:02 PM Mark Thomas wrote: > On 29/11/2018 19:46, r...@apache.org wrote: > > Author: remm > > Date: Thu Nov 29 19:46:04 2018 > > New Revision: 1847747 > > > > URL: http://svn.apache.org/viewvc?rev=1847747=rev > > Log: > > i18n and cleanup > > I've added these new terms to

Re: svn commit: r1847747 - in /tomcat/trunk/java/org/apache: catalina/core/LocalStrings.properties catalina/core/StandardEngine.java catalina/startup/Catalina.java catalina/startup/LocalStrings.proper

2018-11-29 Thread Rémy Maucherat
On Thu, Nov 29, 2018 at 9:08 PM Mark Thomas wrote: > Indeed. There is some low hanging fruit for a new contributor there. It > shouldn't be too hard to write a regular expression to look for > (non-debug) logging calls that don't use a StringManager. > > I see you've added the French

Re: svn commit: r1847646 - /tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

2018-11-30 Thread Rémy Maucherat
On Wed, Nov 28, 2018 at 4:52 PM Mark Thomas wrote: > Indeed. I saw that and started to mentally draft a "Ignore my last" > email while I scrolled to the end to see which test had failed. > > Looks really fixed to me now. Outstanding ! Rémy

Re: [VOTE] Release Apache Tomcat Native 1.2.19

2018-12-04 Thread Rémy Maucherat
On Fri, Nov 30, 2018 at 9:00 PM Mark Thomas wrote: > Version 1.2.19 includes the following changes compared to 1.2.18: > > - Windows binaries built with OpenSSL 1.0.2q and APR 1.6.5 > - Windows binaries built with OpenSSL 1.1.1a and APR 1.6.5 > - Fixed memory leak associated with OCSP > - Fix an

Re: svn commit: r1848225 - in /tomcat/trunk/java/org/apache/catalina/loader: LocalStrings.properties WebappClassLoaderBase.java WebappLoader.java

2018-12-05 Thread Rémy Maucherat
On Wed, Dec 5, 2018 at 5:37 PM wrote: > Author: remm > Date: Wed Dec 5 16:37:42 2018 > New Revision: 1848225 > > URL: http://svn.apache.org/viewvc?rev=1848225=rev > Log: > Add i18n for the loader package. > > I have at least 350 more strings to add. I don't know what to do with: - the

Re: svn commit: r1848225 - in /tomcat/trunk/java/org/apache/catalina/loader: LocalStrings.properties WebappClassLoaderBase.java WebappLoader.java

2018-12-05 Thread Rémy Maucherat
On Wed, Dec 5, 2018 at 9:17 PM Mark Thomas wrote: > On 05/12/2018 20:03, Rémy Maucherat wrote: > > On Wed, Dec 5, 2018 at 5:37 PM wrote: > > > >> Author: remm > >> Date: Wed Dec 5 16:37:42 2018 > >> New Revision: 1848225 > >> > >>

Re: [VOTE] Release Apache Tomcat 9.0.14

2018-12-07 Thread Rémy Maucherat
On Thu, Dec 6, 2018 at 10:37 PM Mark Thomas wrote: > The proposed Apache Tomcat 9.0.14 release is now available for voting. > > The major changes compared to the 9.0.13 release are: > > - Significant expansion of localisation support with the addition of > Brazilian Portuguese, Korean and

Re: svn commit: r1848225 - in /tomcat/trunk/java/org/apache/catalina/loader: LocalStrings.properties WebappClassLoaderBase.java WebappLoader.java

2018-12-07 Thread Rémy Maucherat
On Fri, Dec 7, 2018 at 6:53 PM Mark Thomas wrote: > On 06/12/2018 14:08, Rémy Maucherat wrote: > > On Thu, Dec 6, 2018 at 2:42 PM Mark Thomas wrote: > > > >>> Ok, why not. > >> > >> Apart from the fact it would mean touching almost every class in

Re: Specifying a URL for the docBase

2018-12-08 Thread Rémy Maucherat
On Sat, Dec 8, 2018 at 2:37 AM Woonsan Ko wrote: > On Sat, Dec 8, 2018 at 3:35 AM Mark Thomas wrote: > > > > On 04/12/2018 22:22, Woonsan Ko wrote: > > > > > > > > > More specifically, I can remove my custom logic in > > > AppsDeployingTomcatEmbeddedServletContainerFactory.java [2,3] by > > >

Re: open visibility of JavaClassCacheEntry

2018-12-06 Thread Rémy Maucherat
On Thu, Dec 6, 2018 at 11:51 AM Romain Manni-Bucau wrote: > Hi guys, > > can you make ContextConfig.JavaClassCacheEntry public please? Idea is to be > able to override ContextConfig and potentially customize processAnnotations > methods. Currently it is a pain and it is preventing to upgrade

Re: svn commit: r1848225 - in /tomcat/trunk/java/org/apache/catalina/loader: LocalStrings.properties WebappClassLoaderBase.java WebappLoader.java

2018-12-06 Thread Rémy Maucherat
On Thu, Dec 6, 2018 at 2:42 PM Mark Thomas wrote: > > Ok, why not. > > Apart from the fact it would mean touching almost every class in Tomcat? > > Seriously, the more I think about it the more I like it. Move the res > package from o.a.tomcat.util.res o.a.juli.res and deprecate the old one >

Re: svn commit: r1848566 - in /tomcat/trunk/java/org/apache/catalina/webresources: JarWarResourceSet.java LocalStrings.properties

2018-12-10 Thread Rémy Maucherat
On Mon, Dec 10, 2018 at 1:41 PM wrote: > Author: markt > Date: Mon Dec 10 12:41:43 2018 > New Revision: 1848566 > > URL: http://svn.apache.org/viewvc?rev=1848566=rev > Log: > Don't use an initial capital in the key name > Sorry for all the mistakes, I had tried to be creaful. About this one, I

Re: Specifying a URL for the docBase

2018-12-10 Thread Rémy Maucherat
On Sun, Dec 9, 2018 at 3:45 AM Woonsan Ko wrote: > On Sat, Dec 8, 2018 at 10:48 PM Rémy Maucherat wrote: > > > > On Sat, Dec 8, 2018 at 2:37 AM Woonsan Ko wrote: > > > > > On Sat, Dec 8, 2018 at 3:35 AM Mark Thomas wrote: > > > > >

Re: Current problems with TLS 1.0 and NIO(2)+native+openssl 1.1.1

2018-11-29 Thread Rémy Maucherat
On Sun, Nov 25, 2018 at 10:42 AM Rainer Jung wrote: > In our Java code, what happens is a call to unwrap() in OpenSSLEngine. > This call writes I think 146 bytes, then checks > pendingReadableBytesInSSL(). That call in turn calls SSL.readFromSSL() > and gets back "0" (from SSL_read()). Up in

Re: Container packaging

2018-11-23 Thread Rémy Maucherat
On Fri, Nov 23, 2018 at 1:22 PM Mark Thomas wrote: > On 22/11/2018 15:45, Rémy Maucherat wrote: > > Hi, > > > > After a bit of experimenting, the docker image works well, and is nicer > > (IMO) to configure and customize with the embedded updates from 9.0.14. I > &

Re: Tagging Tomcat Native 1.2.19

2018-11-23 Thread Rémy Maucherat
On Fri, Nov 23, 2018 at 2:54 PM Mark Thomas wrote: > Hi all, > > Given bugs 62662 and 62944, I plan to tag 1.2.19 early next week with a > view to including 1.2.19 in the next round of Tomcat releases. > +1 Rémy

Re: svn commit: r1846116 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/core/ java/org/apache/tomcat/util/threads/ test/org/apache/catalina/mbeans/ webapps/docs/ webapps/docs/c

2018-11-23 Thread Rémy Maucherat
On Fri, Nov 23, 2018 at 1:05 PM Mark Thomas wrote: > On 08/11/2018 10:17, r...@apache.org wrote: > > Author: remm > > Date: Thu Nov 8 10:17:43 2018 > > New Revision: 1846116 > > > > URL: http://svn.apache.org/viewvc?rev=1846116=rev > > Log: > > Add a scheduled executor service to the Service,

Re: svn commit: r1847046 [1/2] - in /tomcat/trunk/java: javax/el/ javax/servlet/http/ org/apache/catalina/authenticator/ org/apache/catalina/authenticator/jaspic/ org/apache/catalina/connector/ org/ap

2018-11-20 Thread Rémy Maucherat
authenticator.jaspicCleanSubjectFail=Échec du nettoyage du sujet de JASPIC +authenticator.jaspicSecureResponseFail=Echec de la sécurisation de la réponse lors du traitement de JASPIC French evolves over time, and technically the 'É' (vs 'E') is the correct one here, but I hate that new rule so

Container packaging

2018-11-22 Thread Rémy Maucherat
Hi, After a bit of experimenting, the docker image works well, and is nicer (IMO) to configure and customize with the embedded updates from 9.0.14. I have verified that Kubernetes based discovery works without being too difficult to configure. Custom code and components can be plugged in easily

Re: svn commit: r1846661 - in /tomcat/trunk/java/org/apache/catalina/startup: LocalStrings.properties Tomcat.java

2018-11-17 Thread Rémy Maucherat
On Thu, Nov 15, 2018 at 4:03 PM wrote: > Author: remm > Date: Thu Nov 15 15:03:45 2018 > New Revision: 1846661 > > URL: http://svn.apache.org/viewvc?rev=1846661=rev > Log: > Add a simple main method to use from a Maven packager pom. > https://github.com/rmaucher/tomcat-maven Is that useful ?

Re: Container packaging

2018-11-26 Thread Rémy Maucherat
On Sat, Nov 24, 2018 at 12:19 AM Mark Thomas wrote: > On 23/11/2018 12:57, Rémy Maucherat wrote: > > On Fri, Nov 23, 2018 at 1:22 PM Mark Thomas wrote: > > > > >> This is a docker image, right? > >> > > > > A bit. There are standard Tomcat im

Re: svn commit: r1847646 - /tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Endpoint.java

2018-11-28 Thread Rémy Maucherat
On Wed, Nov 28, 2018 at 4:20 PM Mark Thomas wrote: > On 28/11/2018 15:00, ma...@apache.org wrote: > > Author: markt > > Date: Wed Nov 28 15:00:06 2018 > > New Revision: 1847646 > > > > URL: http://svn.apache.org/viewvc?rev=1847646=rev > > Log: > > Fix possible cause of intermittent

Re: svn commit: r1847636 - /tomcat/trunk/java/org/apache/catalina/core/StandardServer.java

2018-11-28 Thread Rémy Maucherat
On Wed, Nov 28, 2018 at 7:07 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > > /** - * The event period. + * The lifecycle event period. > > */ protected int eventPeriod = 10; > > Can you give the units, here? I suspect the units are "number of > events" rather than e.g.

Re: Extras

2019-01-10 Thread Rémy Maucherat
On Thu, Jan 10, 2019 at 2:53 PM Rainer Jung wrote: > Am 10.01.2019 um 13:16 schrieb Rémy Maucherat: > > On Thu, Jan 10, 2019 at 1:09 PM Mark Thomas wrote: > > > >> There is the possibility that an alternative logging JAR could return. > >> https://mark

Re: Extras

2019-01-10 Thread Rémy Maucherat
On Thu, Jan 10, 2019 at 1:09 PM Mark Thomas wrote: > There is the possibility that an alternative logging JAR could return. > https://markmail.org/message/gdmffcyporhcmqge > > Whether that needs an optional / alternative JAR or whether it could be > handled via configuration is TBD. > Ok, so

Re: svn commit: r1850769 - in /tomcat/trunk: java/org/apache/catalina/startup/Catalina.java webapps/docs/changelog.xml

2019-01-08 Thread Rémy Maucherat
On Tue, Jan 8, 2019 at 5:26 PM wrote: > Author: markt > Date: Tue Jan 8 16:26:18 2019 > New Revision: 1850769 > > URL: http://svn.apache.org/viewvc?rev=1850769=rev > Log: > Correct a bug exposed in 9.0.14 and ensure that the Tomcat terminates in a > timely manner when running as a service. >

Re: New design for the Tomcat website

2019-01-04 Thread Rémy Maucherat
On Fri, Jan 4, 2019 at 10:24 AM Mark Thomas wrote: > On 03/01/2019 23:47, Igal Sapir wrote: > > On 1/3/2019 12:09 PM, Mark Thomas wrote: > >> On 03/01/2019 17:38, Igal Sapir wrote: > >> > >> > >> > >>> Looking at other ASF sites like Kafka, Pulsar, and Spark I don't see > the > >>> ASF logo at

Re: New design for the Tomcat website

2019-01-03 Thread Rémy Maucherat
On Thu, Jan 3, 2019 at 2:59 AM Igal Sapir wrote: > Hi Tomcat team, > > I am working on a new design for the Tomcat website and wanted some > preliminary feedback. > > You can see the first mockup at > http://people.apache.org/~isapir/mockups/tomcat-site-1/ > > Please let me know your thoughts. >

Extras

2019-01-09 Thread Rémy Maucherat
Hi, So I'm looking at random small items as possible cleanups and ... The extras came up. At some point (15 years ago) the idea was to have a smaller JAR and avoid bloat, but right now I don't see the point of keeping them out of the regular catalina.jar (and thus reduce the complexity of the

Re: svn commit: r1840901 - /tomcat/trunk/java/org/apache/catalina/users/MemoryUserDatabase.java

2018-09-14 Thread Rémy Maucherat
On Fri, Sep 14, 2018 at 10:41 AM wrote: > Author: markt > Date: Fri Sep 14 08:41:02 2018 > New Revision: 1840901 > > URL: http://svn.apache.org/viewvc?rev=1840901=rev > Log: > Review thread-safety > Document locking strategy > Fix a few issues: > - Iterators could throw

Re: Release Announcement: General Availability of Java 12 / JDK 12

2019-03-26 Thread Rémy Maucherat
Hi Rory, On Wed, Mar 20, 2019 at 10:07 AM Rory O'Donnell wrote: >Hi Mark, > > *1) Release Announcement: General Availability of Java 12 / JDK 12 [1] * > > * JDK 12, the reference implementation of Java 12, is now Generally > Available. > * GPL-licensed OpenJDK builds from Oracle are

Re: buildbot failure in on tomcat-trunk

2019-03-27 Thread Rémy Maucherat
On Wed, Mar 27, 2019 at 11:42 AM wrote: > The Buildbot has detected a new failure on builder tomcat-trunk while > building tomcat. Full details are available at: > https://ci.apache.org/builders/tomcat-trunk/builds/4165 > > Buildbot URL: https://ci.apache.org/ > > Buildslave for this Build:

Re: Becoming graalvm friendly?

2019-03-28 Thread Rémy Maucherat
On Wed, Mar 20, 2019 at 4:45 PM Romain Manni-Bucau wrote: > Most of the time monitoring is done through a custom exporter in practise > based on other impl - sigar, library integration like > hibernate/eclipselinks ones, metrics, microprofile etc... - and JMX is not > then used - not judging it

Re: Becoming graalvm friendly?

2019-03-28 Thread Rémy Maucherat
On Thu, Mar 28, 2019 at 3:43 PM Romain Manni-Bucau wrote: > In my case - I tried on meecrowave - i just switched using Log SPI the impl > to something else - custom log4j2 IIRC - and it passed that state until it > fails on JMX. Then i @Subtitute some code in the Registry and base classes > but

Re: [tomcat] 01/01: Fix wrong protocol version usage

2019-04-01 Thread Rémy Maucherat
On Sun, Mar 31, 2019 at 7:38 PM Michael Osipov wrote: > Am 2019-03-31 um 14:50 schrieb Konstantin Kolinko: > > -1 (veto). > > This was discussed several years ago, and the decision was to use > "HTTP/2.0" > > https://bz.apache.org/bugzilla/show_bug.cgi?id=58605 > > I tripped over this when

Re: [tomcat] 01/01: Fix wrong protocol version usage

2019-04-01 Thread Rémy Maucherat
On Mon, Apr 1, 2019 at 9:48 AM Michael Osipov wrote: > Am 2019-04-01 um 09:36 schrieb Rémy Maucherat: > > On Sun, Mar 31, 2019 at 7:38 PM Michael Osipov > wrote: > > > >> Am 2019-03-31 um 14:50 schrieb Konstantin Kolinko: > >>> -1 (veto). >

Re: [tomcat] branch master updated: Fix the HTTP/2 equivalent of swallowInput

2019-04-08 Thread Rémy Maucherat
On Sun, Apr 7, 2019 at 10:42 PM wrote: > This is an automated email from the ASF dual-hosted git repository. > > markt pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > The following commit(s) were added to refs/heads/master by this push: >

Re: [tomcat] branch master updated: Fix the HTTP/2 equivalent of swallowInput

2019-04-08 Thread Rémy Maucherat
On Mon, Apr 8, 2019 at 11:05 AM Mark Thomas wrote: > On 08/04/2019 09:57, Rémy Maucherat wrote: > > On Sun, Apr 7, 2019 at 10:42 PM wrote: > > > >> This is an automated email from the ASF dual-hosted git repository. > >> > >> markt pushed a commit

Re: Git migration read for testing

2019-02-26 Thread Rémy Maucherat
On Tue, Feb 26, 2019 at 1:33 PM Mark Thomas wrote: > All, > > https://github.com/apache/tomcat > > is now ready for testing. > > It should contain: > branches > - master (9.0.x) > - 8.5.x > - 7.0.x > > Tags: > - one for each 7.0.x, 8.5.x and 9.0.x release > > Tags have all been renamed to follow

Re: Git migration read for testing

2019-02-27 Thread Rémy Maucherat
On Wed, Feb 27, 2019 at 11:09 AM Mark Thomas wrote: > On 27/02/2019 09:44, Rémy Maucherat wrote: > > On Tue, Feb 26, 2019 at 1:33 PM Mark Thomas wrote: > > > >> All, > >> > >> https://github.com/apache/tomcat > > > > > > Trying my tes

Re: Git migration read for testing

2019-02-27 Thread Rémy Maucherat
On Tue, Feb 26, 2019 at 1:33 PM Mark Thomas wrote: > All, > > https://github.com/apache/tomcat Trying my test commit, I can't push to the github repo. I probably missed something obvious. Rémy > > > is now ready for testing. > > It should contain: > branches > - master (9.0.x) > - 8.5.x > -

Re: New git based merging workflow?

2019-02-28 Thread Rémy Maucherat
On Thu, Feb 28, 2019 at 4:03 PM Emmanuel Bourg wrote: > Le 28/02/2019 à 15:25, Mark Thomas a écrit : > > > The main reason I don't do that is that I want to have each branch setup > > correctly (Java version, dependencies, etc.) in an IDE. Eclipse, at > > least, doesn't cope well with that. > >

Re: Git migration read for testing

2019-03-01 Thread Rémy Maucherat
On Fri, Mar 1, 2019 at 9:50 PM Mark Thomas wrote: > On 01/03/2019 19:54, Mark Thomas wrote: > > On 01/03/2019 19:00, Coty Sutherland wrote: > >> The email notifications work for when we push commits to the repository, > >> but it looks like we're missing emails when PRs are opened. > > > > ACK.

Re: [VOTE] Release Apache Tomcat 7.0.93

2019-02-20 Thread Rémy Maucherat
On Sat, Feb 16, 2019 at 6:41 PM Violeta Georgieva wrote: > The proposed Apache Tomcat 7.0.93 release is now available for voting. > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.93/ > The Maven staging repo is: >

Re: [VOTE] Migrate to git

2019-02-21 Thread Rémy Maucherat
On Thu, Feb 21, 2019 at 5:13 PM Mark Thomas wrote: > This is a VOTE to migrate the primary source code repository for Apache > Tomcat 9.0.x, 8.5.x and 7.0.x from svn to git. > > The migration will be performed as per: > https://cwiki.apache.org/confluence/display/TOMCAT/Git+migration > > with

Re: buildbot failure in on tomcat-85-trunk

2019-03-05 Thread Rémy Maucherat
On Mon, Mar 4, 2019 at 10:07 PM wrote: > The Buildbot has detected a new failure on builder tomcat-85-trunk while > building tomcat. Full details are available at: > https://ci.apache.org/builders/tomcat-85-trunk/builds/1679 > > Buildbot URL: https://ci.apache.org/ > > Buildslave for this

Re: [VOTE] Release Apache Tomcat 9.0.17

2019-03-14 Thread Rémy Maucherat
On Wed, Mar 13, 2019 at 7:23 PM Mark Thomas wrote: > The proposed Apache Tomcat 9.0.17 release is now available for voting. > > The major changes compared to the 9.0.16 release are: > > - The APR/Native connector now supports both OpenSSL and JSSE TLS > configuration syntax (NIO and NIO2

Re: ApacheCon Berlin 2019 track?

2019-03-14 Thread Rémy Maucherat
On Thu, Mar 14, 2019 at 5:28 PM Mark Thomas wrote: > On 10/03/2019 19:59, Myrle Krantz wrote: > > Hey Tomcat! > > > > ApacheCon EU this year is going to be from October 22-24 in Berlin, I'm > > looking for some great tracks for this year. Tomcat is doing a track in > > Las Vegas this year

Re: svn commit: r1854025 - in /tomcat/trunk/java/org/apache/tomcat/util/net: AbstractJsseEndpoint.java SSLUtilBase.java jsse/JSSEUtil.java openssl/OpenSSLUtil.java

2019-03-07 Thread Rémy Maucherat
On Thu, Feb 21, 2019 at 10:29 AM wrote: > Author: markt > Date: Thu Feb 21 09:29:29 2019 > New Revision: 1854025 > > URL: http://svn.apache.org/viewvc?rev=1854025=rev > Log: > Refactor creation of SSLContext to include configuration > There's probably an issue with that strategy. I have one of

Re: [tomcat] branch master updated: Avoid keystores with OpenSSL and regular certificates

2019-03-07 Thread Rémy Maucherat
On Thu, Mar 7, 2019 at 1:48 PM Mark Thomas wrote: > On 07/03/2019 12:18, r...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > > > remm pushed a commit to branch master > > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > > > > The

Re: Becoming graalvm friendly?

2019-03-20 Thread Rémy Maucherat
https://github.com/rmannibucau> | > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book > < > https://www.packtpub.com/application-development/java-ee-8-high-performance > > > > > Le mar. 19 mars 2019 à 16:38, Rémy Maucherat a écrit : > > > On Sun, Mar 10,

Re: Becoming graalvm friendly?

2019-03-19 Thread Rémy Maucherat
On Sun, Mar 10, 2019 at 6:24 PM Romain Manni-Bucau wrote: > Hi guys, > > Anyone got a look to graalvm native-image tool? > Tomcat does not work OOTB due to its JMX wide usage - all is not > implemented in graalvm native scope. That said most of this code is not > really used by Tomcat and can be

<    3   4   5   6   7   8   9   10   11   12   >