Re: 8.5.2 async state?

2016-05-17 Thread Romain Manni-Bucau
I see, that's however a regression for tomcat users. could the async listener wrapper impl this if a tomcat flag is switched on? Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibu

Re: 8.5.2 async state?

2016-05-17 Thread Romain Manni-Bucau
the real issue is adding a listener there trigger onStartAsync()*ONLY* (no onCompleted(), onTimeout(), onError() etc... cause org.apache.catalina.core.AsyncContextImpl#setStarted does listeners.clear(); ) Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog

Re: 8.5.2 async state?

2016-05-17 Thread Romain Manni-Bucau
he related issue please? Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber <http://www.tomitribe.com>

8.5.2 async state?

2016-05-17 Thread Romain Manni-Bucau
an exception since isAsyncStarted() = false. Was it intended? Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber &

Re: NPE in StandardJarScanner

2016-05-17 Thread Romain Manni-Bucau
Thanks Violeta for the fix! Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber <http://www.tomitribe.c

NPE in StandardJarScanner

2016-05-16 Thread Romain Manni-Bucau
Hi guys, org.apache.tomcat.util.scan.StandardJarScanner#processManifest does: Manifest manifest = jar.getManifest(); Attributes attributes = manifest.getMainAttributes(); Please note that manifest can be null so another NPE should be added Thanks, Romain Manni-Bucau @rmannibucau <ht

Re: Small typo in title on security-9 page

2016-05-10 Thread Romain Manni-Bucau
After having cleaned the cache yes. Thanks! Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber <http://

Small typo in title on security-9 page

2016-05-10 Thread Romain Manni-Bucau
Hi guys, If like me you use chrome the tabs are likely too small to see it but check the window title of https://tomcat.apache.org/security-9.html, it is " Apache Tomcat - Apache Tomcat 8 vulnerabilities" which looks like a copy/paste. Romain Manni-Bucau @rmannibucau <https:

Re: tomcat 7 broken on java 7 for linux distro

2016-04-27 Thread Romain Manni-Bucau
anyway. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber <http://www.tomitribe.com> | JavaEE

Re: tomcat 7 broken on java 7 for linux distro

2016-04-26 Thread Romain Manni-Bucau
Le 26 avr. 2016 22:27, "Christopher Schultz" <ch...@christopherschultz.net> a écrit : > > Romain, > > On 4/25/16 11:42 AM, Romain Manni-Bucau wrote: > > Hi guys, > > > > tomcat uses ConcurrentHashMap in few places and doesn't rely on > > Conc

Re: tomcat 7 broken on java 7 for linux distro

2016-04-26 Thread Romain Manni-Bucau
Not sure what happent, got the same it in one of my box (but was 15.10 so can't explain the feedback i got with 14.04). Maybe a package update. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <http://rmannibucau.wordpress.com> | Github <https://github.

Re: tomcat 7 broken on java 7 for linux distro

2016-04-25 Thread Romain Manni-Bucau
Just to make it clearer: 14.04 had java 7 as expected but tomcat7 package was compiled with java 8. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <htt

Re: tomcat 7 broken on java 7 for linux distro

2016-04-25 Thread Romain Manni-Bucau
Only met it on previous LTS (16.04 is still fresh so was 14 one). So sounds it was a no luck case. Maybe a page on tomcat website dealing with main integrations and things to check (/etc/defaults/tomcatX JAVA_HOME etc...) can be enough for this issue. What do you think? Romain Manni-Bucau

tomcat 7 broken on java 7 for linux distro

2016-04-25 Thread Romain Manni-Bucau
using the interface instead of the implementation as field type. Do you think it is possible or would you just move it over linux distro? If this last one: how to ensure we don't get more regression in the future due to another build process for user binaries? Thanks, Romain Manni-Bucau

Re: 8.5.1?

2016-04-14 Thread Romain Manni-Bucau
Ok thanks! Le 14 avr. 2016 21:50, "Mark Thomas" <ma...@apache.org> a écrit : > On 14/04/2016 15:39, Romain Manni-Bucau wrote: > > Hi guys, > > > > any plan to do a 8.5.1? I'd like to upgrade tomee and remove the > workaround > > we have for

8.5.1?

2016-04-14 Thread Romain Manni-Bucau
Hi guys, any plan to do a 8.5.1? I'd like to upgrade tomee and remove the workaround we have for the NPE in the webapp classloader with custom repositories. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <http://rmannibucau.wordpress.com> | Github <htt

Re: bug in 8.5.0?

2016-03-24 Thread Romain Manni-Bucau
Thanks Violeta. Romain Manni-Bucau @rmannibucau | Blog | Github | LinkedIn | Tomitriber 2016-03-24 20:29 GMT+01:00 Violeta Georgieva <miles...@gmail.com>: > Hi, > > 2016-03-24 21:01 GMT+02:00 Romain Manni-Bucau <rmannibu...@gmail.com>: >> >> H

bug in 8.5.0?

2016-03-24 Thread Romain Manni-Bucau
Hi guys, if I'm not mistaken org.apache.catalina.loader.WebappClassLoaderBase#getResourceAsStream can throw a NPE: 1090. URL url = super.findResource(name); 1091. stream = url.openStream(); // url can be null Romain Manni-Bucau @rmannibucau | Blog | Github | LinkedIn | Tomitriber

Re: Context path: any technical reason to ignore it?

2016-02-18 Thread Romain Manni-Bucau
2016-02-18 17:20 GMT+01:00 Christopher Schultz <ch...@christopherschultz.net >: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Romain, > > On 2/18/16 6:00 AM, Romain Manni-Bucau wrote: > > On a personal side i tend to agree and like to have filesystem > &g

Re: Context path: any technical reason to ignore it?

2016-02-18 Thread Romain Manni-Bucau
2016-02-18 12:02 GMT+01:00 Konstantin Kolinko <knst.koli...@gmail.com>: > 2016-02-18 13:42 GMT+03:00 Romain Manni-Bucau <rmannibu...@gmail.com>: > > Hi guys, > > > > in /META-INF/context.xml was used a lot > > for tomcat 6/7 and doesn't work anymore since

Re: Context path: any technical reason to ignore it?

2016-02-18 Thread Romain Manni-Bucau
? Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber <http://www.tomitribe.com> 2016-02-18 1

Context path: any technical reason to ignore it?

2016-02-18 Thread Romain Manni-Bucau
would be enough to keep the feature working. Do I miss anything? Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibuca

Re: regression due to https://bz.apache.org/bugzilla/show_bug.cgi?id=58867 ?

2016-02-10 Thread Romain Manni-Bucau
Thanks a lot Mark! Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber <http://www.tomitribe.com> 2

Re: regression due to https://bz.apache.org/bugzilla/show_bug.cgi?id=58867 ?

2016-02-08 Thread Romain Manni-Bucau
unpacking and several tools around tomcat as well. I guess - can check if needed - a plain tomcat installation can get it setting an absolute docBase on . Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <http://rmannibucau.wordpress.com> | Github <https

regression due to https://bz.apache.org/bugzilla/show_bug.cgi?id=58867 ?

2016-02-08 Thread Romain Manni-Bucau
to this path then all was working smoothly ie the manually exploded folder was deployed. Now (8.0.32) the war is re-expanded in webapps (by default). Of course a work around is to set unpackWARs to false but it is a regression in term of behavior which is quite nasty IMO. Was it really intended or is i

Re: InstanceListener, InstanceEvent: Unused?

2016-01-04 Thread Romain Manni-Bucau
Hi TomEE uses it but nothing justifying to keep the api - we can do it in another manner if needed. Le 4 janv. 2016 17:14, "Mark Thomas" a écrit : > Given that the Tomcat code doesn't contain any classes that implement > InstanceListener is looks to be unused internally. I'm

access log valve not using logger?

2015-11-20 Thread Romain Manni-Bucau
. Romain Manni-Bucau @rmannibucau | Blog | Github | LinkedIn | Tomitriber - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: access log valve not using logger?

2015-11-20 Thread Romain Manni-Bucau
+1, that is more or less what I just hacked for tomcat 7/8. Romain Manni-Bucau @rmannibucau | Blog | Github | LinkedIn | Tomitriber 2015-11-20 12:01 GMT-08:00 Christopher Schultz <ch...@christopherschultz.net>: > Romain, > > On 11/20/15 2:44 PM, Romain Manni-Bucau wrote

Re: websocket tomcat listener API?

2015-11-04 Thread Romain Manni-Bucau
Yes, and would avoid a custom configurator :). Le 4 nov. 2015 06:09, "Rémy Maucherat" <r...@apache.org> a écrit : > 2015-11-04 14:55 GMT+01:00 Romain Manni-Bucau <rmannibu...@gmail.com>: > > > Here is the use case: we make these endpoints go through the javee

Re: websocket tomcat listener API?

2015-11-04 Thread Romain Manni-Bucau
That is what I thought but extending WsSession in t8 is hard. Le 4 nov. 2015 06:45, "Rémy Maucherat" <r...@apache.org> a écrit : > 2015-11-04 15:16 GMT+01:00 Romain Manni-Bucau <rmannibu...@gmail.com>: > > > Yes, and would avoid a custom configurator

Re: websocket tomcat listener API?

2015-11-04 Thread Romain Manni-Bucau
+01:00 Mark Thomas <ma...@apache.org>: > > > On 04/11/2015 06:28, Romain Manni-Bucau wrote: > > > Hi guys, > > > > So you only want the views of the male committers? > > > > > Would it be possible to add to tomcat codebase a way to register custom &g

Re: websocket tomcat listener API?

2015-11-04 Thread Romain Manni-Bucau
I see, will it be "fixed" or should it be worked-around with a BackgroundProcess - that is what we use ATM in TomEE SNAPSHOT code? Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <http://rmannibucau.wordpress.com> | Github <https://github.co

websocket tomcat listener API?

2015-11-03 Thread Romain Manni-Bucau
Hi guys, Would it be possible to add to tomcat codebase a way to register custom websocket lifecycle listeners for technical integration. For instance in TomEE we would need a clean way to listen for close() or timeout() without modifying the user code side if possible. wdyt? Romain Manni-Bucau

Re: access log valve with custom format

2015-07-02 Thread Romain Manni-Bucau
Thanks! Yes now there is AbstractAccessLogValve but was not in v7. Romain Manni-Bucau @rmannibucau https://twitter.com/rmannibucau | Blog http://rmannibucau.wordpress.com | Github https://github.com/rmannibucau | LinkedIn https://www.linkedin.com/in/rmannibucau | Tomitriber http

access log valve with custom format

2015-07-02 Thread Romain Manni-Bucau
Manni-Bucau @rmannibucau https://twitter.com/rmannibucau | Blog http://rmannibucau.wordpress.com | Github https://github.com/rmannibucau | LinkedIn https://www.linkedin.com/in/rmannibucau | Tomitriber http://www.tomitribe.com

Re: access log valve with custom format

2015-07-02 Thread Romain Manni-Bucau
the javadoc: https://tomcat.apache.org/tomcat-7.0-doc/api/org/apache/catalina/valves/AccessLogValve.html Romain Manni-Bucau @rmannibucau https://twitter.com/rmannibucau | Blog http://rmannibucau.wordpress.com | Github https://github.com/rmannibucau | LinkedIn https://www.linkedin.com

Re: connector redirect

2015-06-18 Thread Romain Manni-Bucau
Hmm, link between connectors is tomcat specific so I guess we could have a flag to support all http methods and not rely on default sendRedirect Romain Manni-Bucau @rmannibucau https://twitter.com/rmannibucau | Blog http://rmannibucau.wordpress.com | Github https://github.com/rmannibucau

connector redirect

2015-06-18 Thread Romain Manni-Bucau
Hi guys, when redirecting ports between connectors tomcat uses a 302 ATM, any reason to not use a 307 (ie support POST redirect as well)? Romain Manni-Bucau @rmannibucau https://twitter.com/rmannibucau | Blog http://rmannibucau.wordpress.com | Github https://github.com/rmannibucau | LinkedIn

encoder/decoder and newInstance()

2015-02-23 Thread Romain Manni-Bucau
Hi guys, any reason org.apache.tomcat.websocket.WsRemoteEndpointImplBase#setEncoders doesn't use InstanceManager? Would be super nice to be able to use injections in encoders and decoders to avoid to be able to keep cache through injections wdyt? Romain Manni-Bucau @rmannibucau http

async and complete on 7.0.59

2015-02-19 Thread Romain Manni-Bucau
but MUST_COMPLETE and method returns false instead of true so complete doesn't do what is expected. Was working in previous versions (7.0.57 IIRC) Is the bug identified? Will it be fixed? Thanks! Romain Manni-Bucau @rmannibucau http://www.tomitribe.com http://rmannibucau.wordpress.com https

Re: async and complete on 7.0.59

2015-02-19 Thread Romain Manni-Bucau
And current one doesnt pass TCKs cause of it too Romain Manni-Bucau @rmannibucau http://www.tomitribe.com http://rmannibucau.wordpress.com https://github.com/rmannibucau 2015-02-19 15:15 GMT+01:00 Rémy Maucherat r...@apache.org: 2015-02-19 14:52 GMT+01:00 Romain Manni-Bucau rmannibu

Re: async and complete on 7.0.59

2015-02-19 Thread Romain Manni-Bucau
@Rémy: is there a typo on the version? 7.0.57 was all green, I used 7.0.59 to get the failing tests Romain Manni-Bucau @rmannibucau http://www.tomitribe.com http://rmannibucau.wordpress.com https://github.com/rmannibucau 2015-02-19 16:06 GMT+01:00 Rémy Maucherat r...@apache.org: 2015-02-19 15

Re: async and complete on 7.0.59

2015-02-19 Thread Romain Manni-Bucau
Just to terminate this thread and with the help of Rémy (thanks again) we identified my test was no more valid after an update of the spec. Sorry for the noise Romain Manni-Bucau @rmannibucau http://www.tomitribe.com http://rmannibucau.wordpress.com https://github.com/rmannibucau 2015-02-19

Re: async and thread constraint

2015-02-11 Thread Romain Manni-Bucau
all green with the trunk. That you very much. Romain Manni-Bucau @rmannibucau http://www.tomitribe.com http://rmannibucau.wordpress.com https://github.com/rmannibucau 2015-02-11 15:31 GMT+01:00 Mark Thomas ma...@apache.org: On 11/02/2015 13:54, Romain Manni-Bucau wrote: that's it I think

Re: async and thread constraint

2015-02-11 Thread Romain Manni-Bucau
); } and org.apache.coyote.AsyncStateMachine#asyncDispatch checks ContainerThreadMarker.isContainerThread() which is obviously true since request 2 is a normal request so dispatch is skipped and response is never sent (well not as expected and we get a timeout). Romain Manni-Bucau @rmannibucau http

Re: async and thread constraint

2015-02-11 Thread Romain Manni-Bucau
is startAsync works but you reuse container pool (so previous issue sounds really like a bug). startAsync works cause the context (this marker flag) is generally different (not set) when you call it. Romain Manni-Bucau @rmannibucau http://www.tomitribe.com http://rmannibucau.wordpress.com https

Re: async and thread constraint

2015-02-11 Thread Romain Manni-Bucau
it should work. is it clearer? if not I can dump some stacks to make the calls more concrete Romain Manni-Bucau @rmannibucau http://www.tomitribe.com http://rmannibucau.wordpress.com https://github.com/rmannibucau 2015-02-11 10:30 GMT+01:00 Mark Thomas ma...@apache.org: On 11/02/2015 09:21

Re: async and thread constraint

2015-02-11 Thread Romain Manni-Bucau
ContainerThreadMarker should check current thread id and not just a boolean cause request 2 is in a container thread but this is not request 1 thread so you can do request 1 async operations in it. wdyt? hope it is clearer Romain Manni-Bucau @rmannibucau http://www.tomitribe.com http

async and thread constraint

2015-02-10 Thread Romain Manni-Bucau
container threads? PS: there is no log saying dispatching is skipped so it makes it very hard to understand without opening an IDE and tomcat sources, could it be enhanced please? Romain Manni-Bucau @rmannibucau http://www.tomitribe.com http://rmannibucau.wordpress.com https://github.com/rmannibucau

Re: regression in 8.0.18?

2015-01-27 Thread Romain Manni-Bucau
Ok I think I identified the issue but it is weird as well: seems I had (thanks maven for it) tomcat 8.0.18 + tomcat-el-api in version 8.0.12. So the bug was in the 8.0.12 actually. What is weird is it appeared only when upgrading to 8.0.18 other artifacts. Romain Manni-Bucau @rmannibucau http

Re: regression in 8.0.18?

2015-01-26 Thread Romain Manni-Bucau
From 8.0.15, sorry forgot to mention it Romain Manni-Bucau @rmannibucau http://www.tomitribe.com http://rmannibucau.wordpress.com https://github.com/rmannibucau 2015-01-26 20:46 GMT+01:00 Mark Thomas ma...@apache.org: On 26/01/2015 18:17, Romain Manni-Bucau wrote: Hi guys, since I upgraded

regression in 8.0.18?

2015-01-26 Thread Romain Manni-Bucau
but this is not the cause, any pointer? will a flag be introduced for existing apps? Romain Manni-Bucau @rmannibucau http://www.tomitribe.com http://rmannibucau.wordpress.com https://github.com/rmannibucau - To unsubscribe, e-mail: dev-unsubscr

Re: FW: JSR 236 with tomcat 8

2014-11-25 Thread Romain Manni-Bucau
Hi Tomcat doesn't prevent you to use threads so you can use whatever you want like ExecutorServices etc... Romain Manni-Bucau @rmannibucau http://www.tomitribe.com http://rmannibucau.wordpress.com https://github.com/rmannibucau 2014-11-25 11:57 GMT+01:00 Jean-Louis MONTEIRO jeano...@gmail.com

Re: adding an internal filter

2014-09-18 Thread Romain Manni-Bucau
(context, filterConfigs)).put(filterDef.getFilterName(), config); } catch (final Exception e) { throw new IllegalStateException(e); } } works fine even if not sexy Thanks Konstantin for the feedback Romain Manni-Bucau Twitter: @rmannibucau Blog: http

Re: adding an internal filter

2014-09-16 Thread Romain Manni-Bucau
2014-09-16 15:16 GMT+02:00 Konstantin Kolinko knst.koli...@gmail.com: 2014-09-15 23:01 GMT+04:00 Romain Manni-Bucau rmannibu...@gmail.com: Hi guys, in TomEE I'd like to add a filter but after context filter are started (means filterStart() from StandardContext is called). Why? What

adding an internal filter

2014-09-15 Thread Romain Manni-Bucau
); def.set(context, oldConfig); } } catch (final Exception e) { throw new IllegalStateException(e); } but it is really hacky just to get a ApplicationFilterConfig. Is there an easier way I miss or is it possible to make it a bit more easy? Romain Manni-Bucau

Re: shared/server classloaders in Tomcat 8

2014-09-14 Thread Romain Manni-Bucau
Hi I looked it as well few weeks ago. It is still supported in the code. Not sure how widely used it is but it doesn't cost anything on tomcat side (2 lines) so I guess the doc should be updated. Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http

mirgation guide tomcat 6 - tomcat 7

2014-09-11 Thread Romain Manni-Bucau
have a look please? Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau - To unsubscribe, e-mail: dev-unsubscr

Re: mirgation guide tomcat 6 - tomcat 7

2014-09-11 Thread Romain Manni-Bucau
ok, thank you, will paste the link on the jira for memories Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau 2014-09-11 20:34 GMT+02:00 Mark Thomas ma...@apache.org: On 11/09

Re: request.getUserPrincipal() returns null in a ServletRequestListener#requestInitialized in tc-7.0.54

2014-08-05 Thread Romain Manni-Bucau
Actually it is broken Mark since the principal can be created later (you login in a servlet for instance). That's why in tomee we wrap the realm to ensure we get the information whatever happen. Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http

Re: request.getUserPrincipal() returns null in a ServletRequestListener#requestInitialized in tc-7.0.54

2014-08-04 Thread Romain Manni-Bucau
Returns a java.security.Principal object containing the name of the current authenticated user. If the user has not been authenticated, the method returns null. Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github

Re: request.getUserPrincipal() returns null in a ServletRequestListener#requestInitialized in tc-7.0.54

2014-08-04 Thread Romain Manni-Bucau
Hmm did you debug in org.apache.catalina.connector.Request#recycle? Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau 2014-08-04 22:37 GMT+02:00 Mark Struberg strub

sleep?

2014-07-30 Thread Romain Manni-Bucau
Hi guys, running bean validation TCKs on TomEE I wondered why undeployment was slow (well that's ok excepted when you pass 700 tests ;)). Finally realized: org.apache.tomcat.util.threads.ThreadPoolExecutor#contextStopping was doing sleep(200). Can't we get something better here? Romain Manni

Re: new log format?

2014-07-30 Thread Romain Manni-Bucau
a écrit : Romain, On 7/28/14, 3:59 AM, Romain Manni-Bucau wrote: 2014-07-28 9:38 GMT+02:00 Rainer Jung rainer.j...@kippdata.de: Am 27.07.2014 um 19:19 schrieb Romain Manni-Bucau: Here is the one we use: http://svn.apache.org/repos/asf/tomee/tomee/trunk/container/openejb-core/src

Re: new log format?

2014-07-30 Thread Romain Manni-Bucau
Well it is easy (actually not since you need to hack classpath so a default log/*.jar in it would help) but the point is making it nice by default. Le 30 juil. 2014 21:59, Christopher Schultz ch...@christopherschultz.net a écrit : Romain, On 7/30/14, 3:52 PM, Romain Manni-Bucau wrote

Re: new log format?

2014-07-28 Thread Romain Manni-Bucau
2014-07-28 9:38 GMT+02:00 Rainer Jung rainer.j...@kippdata.de: Am 27.07.2014 um 19:19 schrieb Romain Manni-Bucau: Here is the one we use: http://svn.apache.org/repos/asf/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/log/SingleLineFormatter.java Can you compare

Re: little feedback from 8 changes

2014-07-28 Thread Romain Manni-Bucau
Le 28 juil. 2014 23:24, Mark Thomas ma...@apache.org a écrit : On 25/07/2014 23:31, Romain Manni-Bucau wrote: Hi I have 2 main issues/requests regarding big refactorings done in 8.x (mainly integrating it with tomee): 1) is it possible to get an easy way to switch scanning of @WebXXX

Re: new log format?

2014-07-27 Thread Romain Manni-Bucau
it is the one used in dev. Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau 2014-07-27 19:14 GMT+02:00 Konstantin Kolinko knst.koli...@gmail.com: 2014-07-24 21:15 GMT+04:00 Romain

little feedback from 8 changes

2014-07-25 Thread Romain Manni-Bucau
or something to add? Otherwise classloading refactoring allowed us to kill several code so a big thank you :) Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau

new log format?

2014-07-24 Thread Romain Manni-Bucau
] [ class.method on 20chars max] message) Main point is to get everything aligned and not too wide wdyt? Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau

async error message if not supported

2014-06-10 Thread Romain Manni-Bucau
response) { 1657 if (!isAsyncSupported()) { 1658 throw new IllegalStateException(Not supported.); 1659 } I propose to change it to: throw new IllegalStateException(A filter or servlet of the current chain doesn't support asynchronism.); Romain Manni-Bucau Twitter

Re: async error message if not supported

2014-06-10 Thread Romain Manni-Bucau
Thanks! Le 11 juin 2014 02:58, Violeta Georgieva miles...@gmail.com a écrit : Hi, 2014-06-10 21:28 GMT+03:00 Romain Manni-Bucau rmannibu...@gmail.com: Hi in /org/apache/catalina/connector/Request.java it would be nice if error message if there is a filter/servlet not supporting async

7.0.54 status

2014-05-19 Thread Romain Manni-Bucau
://issues.apache.org/bugzilla/show_bug.cgi?id=56425 Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau

Re: 7.0.54 status

2014-05-19 Thread Romain Manni-Bucau
Ok, thank you, please keep up updated Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau 2014-05-19 12:43 GMT+02:00 Mark Thomas ma...@apache.org: On 19/05/2014 11:25, Violeta

Re: apis @asf

2014-05-17 Thread Romain Manni-Bucau
+1 we already talked a bit about it and thought geronimo/specs was the place but another project could work too. My goal is mainly to get something consistent. Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau

apis @asf

2014-05-16 Thread Romain Manni-Bucau
consistent accross ASF. wdyt? Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau - To unsubscribe, e-mail: dev

Re: apis @asf

2014-05-16 Thread Romain Manni-Bucau
is not done in resolver where before invoke was passing correct types. Didnt check the spec about it. Not sure the work needed to go this way, any idea how we can go further? Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com

Re: 7.0.54?

2014-04-18 Thread Romain Manni-Bucau
Hi Awesome, thanks for the note! Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau 2014-04-18 21:15 GMT+02:00 Christopher Schultz ch...@christopherschultz.net: Romain, On 4

7.0.54?

2014-04-16 Thread Romain Manni-Bucau
Hi guys, any 7.0.54 release planned with tc-native upgrade? wonder if we fix it on tomee side or if we can wait for a tomcat release Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com

Re: 7.0.54?

2014-04-16 Thread Romain Manni-Bucau
...@christopherschultz.net a écrit : Romain, On 4/16/14, 3:20 AM, Romain Manni-Bucau wrote: any 7.0.54 release planned with tc-native upgrade? wonder if we fix it on tomee side or if we can wait for a tomcat release I'm not sure about a 7.0.54 release, but tcnative 1.1.30 has been released. Note

Re: ErrorValve enhancement

2014-04-09 Thread Romain Manni-Bucau
Hi for this kind of reason we included in tomee http://svn.apache.org/repos/asf/tomee/tomee/trunk/tomee/tomee-catalina/src/main/java/org/apache/tomee/catalina/valve/MinimumErrorReportValve.java would be great to get it in tomcat OOTB. Romain Manni-Bucau Twitter: @rmannibucau Blog: http

@Deprecated setParentClassLoader(ClassLoader pcl)

2014-04-03 Thread Romain Manni-Bucau
handles it recreating the loader? Will tomcat 7.0.53 be fixed for this usage (wtp uses it for instance)? Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau

Re: @Deprecated setParentClassLoader(ClassLoader pcl)

2014-04-03 Thread Romain Manni-Bucau
well actually can be a link with cxf. Just trying to see it ATM and just saw the behavior you describe. Will come back if I find something wrong due to tomcat otherwise just assume it was a wrong cxf setup and sorry me to have sent this mail a bit too early. Romain Manni-Bucau Twitter

Fwd: svn commit: r1569398 - in /tomcat/trunk/java/org/apache/catalina/loader: LocalStrings.properties WebappClassLoader.java

2014-03-23 Thread Romain Manni-Bucau
Hi any planned date for a tomcat 7.0.53 with this fix? Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau -- Forwarded message -- From: ma...@apache.org Date

[jira] [Commented] (MTOMCAT-174) tomcatConfigurationFilesDirectory is not implemented

2014-03-19 Thread Romain Manni-Bucau (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13940688#comment-13940688 ] Romain Manni-Bucau commented on MTOMCAT-174: Side note: in cli

[jira] [Commented] (MTOMCAT-174) tomcatConfigurationFilesDirectory is not implemented

2014-03-07 Thread Romain Manni-Bucau (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13924165#comment-13924165 ] Romain Manni-Bucau commented on MTOMCAT-174: This still doesn't work on trunk

Re: async-supportedfalse/async-supported in filter?

2014-02-19 Thread Romain Manni-Bucau
Le 19 févr. 2014 19:01, Mark Thomas ma...@apache.org a écrit : On 19/02/2014 14:15, Konstantin Kolinko wrote: 2014-02-19 17:21 GMT+04:00 Mark Thomas ma...@apache.org: There are two issues here. One is the issue cited above although it is much wider than just async-supported. I'm

Re: async-supportedfalse/async-supported in filter?

2014-02-19 Thread Romain Manni-Bucau
2014-02-19 21:12 GMT+01:00 Mark Thomas ma...@apache.org: On 19/02/2014 18:16, Romain Manni-Bucau wrote: Le 19 févr. 2014 19:01, Mark Thomas ma...@apache.org a écrit : I think I am done for 8.0.x. It is a little verbose but it isn't too bad considering. Will you backport it on v7? Yes

new classloader parent?

2014-02-18 Thread Romain Manni-Bucau
. Is it intended? Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau - To unsubscribe, e-mail: dev-unsubscr

Re: new classloader parent?

2014-02-18 Thread Romain Manni-Bucau
PS: BTW system varaible is no more used in new code Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com/rmannibucau 2014-02-18 10:21 GMT+01:00 Romain Manni-Bucau rmannibu...@gmail.com: Hello

Re: new classloader parent?

2014-02-18 Thread Romain Manni-Bucau
We did it but it doesn't cover the embedded case at all since you want to use system classloader. I know this is a case tomcat doesn't handle but it breaks applications using it before (new Tomcat() too). Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn

Re: new classloader parent?

2014-02-18 Thread Romain Manni-Bucau
2014-02-18 11:04 GMT+01:00 Mark Thomas ma...@apache.org: Please don't top post. On 18/02/2014 09:59, Romain Manni-Bucau wrote: We did it but Did what? used filter() it doesn't cover the embedded case at all What doesn't? Why? In embedded case you deploy an app with your classes

async-supportedfalse/async-supported in filter?

2014-02-18 Thread Romain Manni-Bucau
Hi async-supportedfalse/async-supported is no more supported by default int tomcat for filter? it is used in tcks and seems broken now Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http://fr.linkedin.com/in/rmannibucau Github: https://github.com

Re: new classloader parent?

2014-02-18 Thread Romain Manni-Bucau
FooImpl will use Foo from the webapp. It was working fine before and it was convenient. By default you don't add jars in tomcat system loader so the behavior of tomcat was fine + in unit test of embedded mode it was convenient so I dont get the point changing it. Romain Manni-Bucau Twitter: @rmannibucau

Re: async-supportedfalse/async-supported in filter?

2014-02-18 Thread Romain Manni-Bucau
edit: org.apache.jasper.compiler.JspConfig#processWebDotXml validates the xml immediately and doesn't read the version from WebXml - from ContextConfig with getMajorVersion, getMinorVersion methods Romain Manni-Bucau Twitter: @rmannibucau Blog: http://rmannibucau.wordpress.com/ LinkedIn: http

Re: new classloader parent?

2014-02-18 Thread Romain Manni-Bucau
2014-02-18 11:44 GMT+01:00 Mark Thomas ma...@apache.org: Again, please stop top posting. On 18/02/2014 10:14, Romain Manni-Bucau wrote: let say we have an interface Foo. I deploy a war with Foo and FooImpl. In the since I'm in embedded mode I can get FooImpl casting it to Foo. Foo has been

Re: async-supportedfalse/async-supported in filter?

2014-02-18 Thread Romain Manni-Bucau
2014-02-18 11:54 GMT+01:00 Mark Thomas ma...@apache.org: Yet again, please don't top post. On 18/02/2014 10:21, Romain Manni-Bucau wrote: edit: org.apache.jasper.compiler.JspConfig#processWebDotXml validates the xml immediately and doesn't read the version from WebXml - from ContextConfig

Re: async-supportedfalse/async-supported in filter?

2014-02-18 Thread Romain Manni-Bucau
2014-02-18 12:15 GMT+01:00 Mark Thomas ma...@apache.org: On 18/02/2014 11:06, Romain Manni-Bucau wrote: 2014-02-18 11:54 GMT+01:00 Mark Thomas ma...@apache.org: Yet again, please don't top post. On 18/02/2014 10:21, Romain Manni-Bucau wrote: edit: org.apache.jasper.compiler.JspConfig

Re: new classloader parent?

2014-02-18 Thread Romain Manni-Bucau
2014-02-18 12:09 GMT+01:00 Mark Thomas ma...@apache.org: On 18/02/2014 10:50, Romain Manni-Bucau wrote: 2014-02-18 11:44 GMT+01:00 Mark Thomas ma...@apache.org: On 18/02/2014 10:14, Romain Manni-Bucau wrote: snip/ It was working fine before and it was convenient. By default you don't add

Re: async-supportedfalse/async-supported in filter?

2014-02-18 Thread Romain Manni-Bucau
2014-02-18 13:10 GMT+01:00 Mark Thomas ma...@apache.org: On 18/02/2014 12:01, Romain Manni-Bucau wrote: 2014-02-18 12:15 GMT+01:00 Mark Thomas ma...@apache.org: On 18/02/2014 11:06, Romain Manni-Bucau wrote: snip/ I got it from JspConfig: Got what from JspConfig? the previous stack

<    1   2   3   4   5   >