Problems with managing sizing of processor pools in web server, JK and Tomcat

2006-11-19 Thread Tim Whittington
A recent discussion on a patch for the IIS ISAPI Redirector (http://issues.apache.org/bugzilla/show_bug.cgi?id=40967) raised some issues with the current way JK handles the sizing of the connection pool and it's relationship to the threads in the web server process. Historically (prior to 1.2.16

AJP message chunking behaviour

2006-11-23 Thread Tim Whittington
I'm observing sub-optimal AJP messages being sent from Tomcat (5.0.something in this case) to JK running under IIS. I see a consistent pattern (for large response) of message sizes of 8188 and then 12. This looks like 8184 + AJP header and 8 + AJP header = 8192 + 2 * AJP Headers= 8 * 1024

Re: svn commit: r493480 - /tomcat/connectors/trunk/jk/java/org/apache/jk/common/ChannelSocket.java

2007-01-07 Thread Tim Whittington
This is one of the major problems with the current JK implementation If web server threads, JK worker connection_pool_size and AJP maxThreads don't all match, then you can get (silently) dropped connections. If you configure it so you don't, then you've got very large numbers of connections (and

Re: svn commit: r511227 - in /tomcat/connectors/trunk/jk: native/apache-1.3/mod_jk.c native/apache-2

2007-02-25 Thread Tim Whittington
Mladen Why was this changed to use malloc over _alloca here? Regardless of that, it looks like there are two (potential) bugs introduced in this patch: - There's no sizeof(char) in the mallo for status_str and headers_str - status_str isn't initialised, so the check to free it will probably

Re: svn commit: r511227 - in /tomcat/connectors/trunk/jk: native/apache-1.3/mod_jk.c native/apache-2

2007-02-25 Thread Tim Whittington
Never mind the second issue - one should read the docs more carefully. Apologies for the noise. The missing sizeof makes me nervous still. tim On 26/02/2007 at 2:33 p.m., in message [EMAIL PROTECTED], Tim Whittington [EMAIL PROTECTED] wrote: Mladen Why was this changed to use malloc over

Re: Debugging Apache/mod_jk (worker) fault on AIX

2007-03-06 Thread Tim Whittington
We've seen broken mod_jk builds with xlc_r in our environments. cc_r builds seems to work fine though. I haven't dug into what the issue is though. tim On 6/03/2007 at 8:35 a.m., in message [EMAIL PROTECTED], Eric Wertman [EMAIL PROTECTED] wrote: Actually I started with xlc_r and it wouldn't

RE: Tomcat connector for iis

2007-11-28 Thread Tim Whittington
This would probably be best sent to the users list. It's all in the way the ISAPI redirector works. It's a combination of an ISAPI filter - this intercepts requests and magically redirects the ones that should go to Tomcat to a different URL, which is the same DLL mounted in a virtual directory

[Announce] Enhanced ISAPI Redirector + Tomcat Connector Binaries

2007-12-20 Thread Tim Whittington
Hi all We've been using Tomcat and Tomcat Connectors in our company products for almost 10 years now, and it's a very important part of our technology stack. Over those years we've contributed some enhancements and fixes to the IIS connector/ISAPI Redirector, and most of these have been

RE: [ANN] Apache Tomcat JK 1.2.26 Web Server Connector released

2008-01-02 Thread Tim Whittington
Binary builds of 1.2.26 for various platforms are available now from http://sourceforge.net/projects/timsjk/ These include builds of a patched IIS 5/6 ISAPI Redirector that support HTTP 1.1 chunked encoding (and thus keep-alives on dynamic content). cheers tim -Original Message- From:

RE: [ANN] Apache Tomcat JK 1.2.26 Web Server Connector released

2008-02-17 Thread Tim Whittington
to veto that part of the patch. cheers tim _ From: Mladen Turk [mailto:[EMAIL PROTECTED] Sent: Friday, 4 January 2008 1:03 a.m. To: Tomcat Developers List Subject: Re: [ANN] Apache Tomcat JK 1.2.26 Web Server Connector released Tim Whittington wrote: Binary builds of 1.2.26

AJP connector free port scanning

2009-06-16 Thread Tim Whittington
Hi all I¹ve noticed an unexpected and undocumented behaviour in the AJP connector in Tomcat 5.5.27. I¹ve configured the AJP connector to run on port 8009, which is occupied by another process, but instead of failing the connector continues to scan until it hits a free port and uses that.

Re: [VOTE] Release Apache Tomcat Connectors 1.2.32

2011-07-07 Thread Tim Whittington
The proposed 1.2.32 release is: [ x] Stable - go ahead and release as 1.2.32 Stable [ ] Broken - do not release Builds fine on OS X, Solaris, aix-ppc64, HPUX-IA64, HPUX-PARISC, Linux x86, Linux x64, Windows x86 and Windows x64. Testing on a mix of HTML + heavy AJAX apps shows no problems so

Re: svn commit: r1158991 - in /tomcat/jk/trunk: native/iis/jk_isapi_plugin.c xdocs/miscellaneous/changelog.xml

2011-08-18 Thread Tim Whittington
Yeah - not sure what I was smoking on that one. Have reverted for another think. The basic problem we have is that the shared memory code assumes a single worker configuration, and when you have multiple ISAPI Redirectors on a single IIS with different configs that goes a bit wonky. For a start,

/ on end of context paths breaking existing apps

2011-08-21 Thread Tim Whittington
The change in [1] has broken existing behaviour in some applications. Consider the following situation: - An application is context path /application - The application has a servlet mapped to /* - An authentication valve intercepts requests to /application and returns (via a

Re: svn commit: r697462 - /tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c

2008-09-22 Thread Tim Whittington
This fails to build in VC.Net 2005 (actually the change in r697451 is the culprit). The definition of now/mstarted needs to precede the JK_TRACE_ENTER. cheers tim From: [EMAIL PROTECTED] Reply-To: Tomcat Developers List dev@tomcat.apache.org Date: Sun, 21 Sep 2008 09:46:00 - To:

Re: svn commit: r697779 - in /tomcat/connectors/trunk/jk: native/common/jk_lb_worker.c native/common/jk_lb_worker.h native/common/jk_shm.h native/common/jk_util.c native/common/jk_util.h xdocs/miscell

2008-09-22 Thread Tim Whittington
This is failing to build in VC++ 2005 In jk_lb_worker.c: +strcppy(p-s-session_cookie, p-session_cookie); +strcppy(p-s-session_path, p-session_path); I can¹t find a strcppy implementation in VC++ 2005, nor can I find references to it on Google ­ where is this function defined? cheers

Re: svn commit: r697779 - in /tomcat/connectors/trunk/jk: native/common/jk_lb_worker.c native/common/jk_lb_worker.h native/common/jk_shm.h native/common/jk_util.c native/common/jk_util.h xdocs/miscel

2008-09-23 Thread Tim Whittington
Also fixed. Thanks again. Tim Whittington schrieb: This is failing to build in VC++ 2005 In jk_lb_worker.c: +strcppy(p-s-session_cookie, p-session_cookie); +strcppy(p-s-session_path, p-session_path); I can¹t find a strcppy implementation in VC++ 2005, nor can I find references

Re: svn commit: r698229 - in /tomcat/connectors/trunk/jk: native/apache-2.0/mod_jk.c native/common/jk_ajp_common.c native/common/jk_service.h native/common/jk_util.c xdocs/miscellaneous/changelog.xml

2008-09-24 Thread Tim Whittington
This has broken the build on Windows also. The addition of the log statement pushed the declaration of char* buff below it out of the beginning of the block, and VC is being pedantic about the C declaration rules. tim From: [EMAIL PROTECTED] Reply-To: Tomcat Developers List

Re: DO NOT REPLY [Bug 46416] New: Include order in jk_global.h breaks mod_jk build on Windows + Visual Studio 2005

2009-01-28 Thread Tim Whittington
Any chance of anyone fixing this? I¹d submit a patch myself, but it¹s trivial, and some more tidying than a quick fix might be in order. cheers tim From: bugzi...@apache.org Reply-To: Tomcat Developers List dev@tomcat.apache.org Date: Thu, 18 Dec 2008 14:04:22 -0800 (PST) To:

Re: Going for jk 1.2.28

2009-02-22 Thread Tim Whittington
I¹d appreciate a fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=46416 so I can build on Windows without local patches. cheers tim From: Mladen Turk mt...@apache.org Reply-To: Tomcat Developers List dev@tomcat.apache.org Date: Thu, 19 Feb 2009 16:39:50 +0100 To: Tomcat Developers

Re: [VOTE] Release Tomcat Connectors 1.2.30

2010-03-01 Thread Tim Whittington
Apache Tomcat Connectors 1.2.30 is: [x] Stable - no major issues, no regressions [ ] Beta - at least one significant issue -- tell us what it is [ ] Alpha - multiple significant issues -- tell us what they are Tested with some RIA apps that utilise POST heavily, replicated the 1.2.29

Re: [VOTE] Release Tomcat Connectors 1.2.30

2010-03-01 Thread Tim Whittington
I've noticed an issue with the IIS shutdown being blocked, but I'm pretty sure it's not a regression. https://issues.apache.org/bugzilla/show_bug.cgi?id=48830 cheers tim On Mon, Mar 1, 2010 at 9:03 PM, Tim Whittington t...@apache.org wrote: Apache Tomcat Connectors 1.2.30 is: [x

Re: [VOTE] Release Tomcat Connectors 1.2.30

2010-03-01 Thread Tim Whittington
1) Logging Performance on ISAPI/Windows The logging changes for Windows seem to dramatically slow down log performance. I'm not seeing this on Windows XP - I get many logs per clock slice. (I tried it with my builds, and Mladen's 1.2.27/28/30 builds).

Re: Enable RAW headers by default in IIS Tomcat connector

2010-03-07 Thread Tim Whittington
I've committed this change now. I replaced USE_RAW_HEADERS with USE_CGI_HEADERS, and inverted all the conditionals. cheers tim On Mon, Feb 8, 2010 at 9:13 PM, Tim Whittington t...@apache.org wrote: OK, the most conservative change will be to enable USE_RAW_HEADERS in the makefiles/projects

Re: svn commit: r920199 - /tomcat/jk/trunk/native/apache-2.0/Makefile.vc

2010-03-07 Thread Tim Whittington
Thanks - I was wondering whether to do this, but forgot on the commit. On Mon, Mar 8, 2010 at 7:01 PM, mt...@apache.org wrote: Author: mturk Date: Mon Mar 8 06:01:27 2010 New Revision: 920199 URL: http://svn.apache.org/viewvc?rev=920199view=rev Log: Embed manifest inside dll Modified:

Re: svn commit: r920086 - in /tomcat/jk/trunk/native/apache-2.0: Makefile.vc mod_jk.rc

2010-03-07 Thread Tim Whittington
Great - I hadn't considered that. On Mon, Mar 8, 2010 at 10:55 AM, Mladen Turk mt...@apache.org wrote: On 03/07/2010 09:17 PM, t...@apache.org wrote: Author: timw --- tomcat/jk/trunk/native/apache-2.0/mod_jk.rc (added) +++ tomcat/jk/trunk/native/apache-2.0/mod_jk.rc Sun Mar 7 20:17:04

Re: svn commit: r920093 - in /tomcat/jk/trunk: native/iis/jk_isapi_plugin.c xdocs/reference/iis.xml

2010-03-07 Thread Tim Whittington
Thanks I'm trying to track down a VC6 install so I can test the .dsp build before I commit. Maybe a move to VC2003 as a minimum might be in order some day. cheers tim On Mon, Mar 8, 2010 at 7:43 PM, Mladen Turk mt...@apache.org wrote: On 03/07/2010 09:31 PM, t...@apache.org wrote: Author:

Re: svn commit: r920281 - /tomcat/jk/trunk/native/iis/jk_isapi_plugin.c

2010-03-09 Thread Tim Whittington
On Tue, Mar 9, 2010 at 12:45 AM, mt...@apache.org wrote: Author: mturk Date: Mon Mar 8 11:45:37 2010 New Revision: 920281 URL: http://svn.apache.org/viewvc?rev=920281view=rev Log: Use StringCbPrintf instead sprintf_s and use existing logger for logging new rotation file name Modified:

Re: svn commit: r920093 - in /tomcat/jk/trunk: native/iis/jk_isapi_plugin.c xdocs/reference/iis.xml

2010-03-09 Thread Tim Whittington
doing cmdline builds. cheers tim On Mon, Mar 8, 2010 at 9:37 PM, Mladen Turk mt...@apache.org wrote: On 03/08/2010 08:57 AM, Tim Whittington wrote: Thanks I'm trying to track down a VC6 install so I can test the .dsp build before I commit. Maybe a move to VC2003 as a minimum might

Re: svn commit: r920093 - in /tomcat/jk/trunk: native/iis/jk_isapi_plugin.c xdocs/reference/iis.xml

2010-03-09 Thread Tim Whittington
When building x86 binaries, make sure PSDK dirs are included before MSVC6. Why does this make a difference? One thing I noticed is that VS6 can't read the .dsp and .dsw files currently in SVN, so I'm currently only doing cmdline builds. Check line endings. They must be CRLF

[PROPOSAL] Log rotation in Tomcat Connector

2009-12-17 Thread Tim Whittington
Hi all We're experiencing issues with the Tomcat Connector log in some IIS production sites where the log file grows to a very large size (8GB on one site). This is almost entirely due to connection errors between the front end and back end produced when the back-end Tomcat is restarted after

Re: Problem loading classes with Class.forName() in StandardContext.createWrapper()

2009-12-26 Thread Tim Whittington
We've experienced similar issues integrating lots of third party libraries (Tomcat being one of them) into our OSGi runtime. Essentially this boils down to OSGi liking extension functionality to be provided by instantiation in the providing bundles, and publication using OSGi services. (i.e.

Re: [PROPOSAL] Log rotation in Tomcat Connector

2010-01-05 Thread Tim Whittington
1:01:53 AM GMT +12:00 New Zealand Subject: Re: [PROPOSAL] Log rotation in Tomcat Connector Hi Tim, On 18.12.2009 03:26, Tim Whittington wrote: Hi all We're experiencing issues with the Tomcat Connector log in some IIS production sites where the log file grows to a very large size (8GB

Re: [PROPOSAL] Log rotation in Tomcat Connector

2010-01-07 Thread Tim Whittington
...@apache.org To: Tomcat Developers List dev@tomcat.apache.org Sent: Thursday, 7 January, 2010 12:53:06 AM GMT +12:00 New Zealand Subject: Re: [PROPOSAL] Log rotation in Tomcat Connector On 01/06/2010 03:28 AM, Tim Whittington wrote: The downside of the rotatelogs approach is that it's not easy

Re: [PROPOSAL] Log rotation in Tomcat Connector

2010-01-07 Thread Tim Whittington
at all. cheers tim - Original Message - From: Tim Whittington t...@orionhealth.com To: Tomcat Developers List dev@tomcat.apache.org Sent: Wednesday, 6 January, 2010 3:28:47 PM GMT +12:00 New Zealand Subject: Re: [PROPOSAL] Log rotation in Tomcat Connector For consistency (with Apache

Re: svn commit: r893452 - /tomcat/jk/trunk/native/common/jk_connect.c

2010-01-07 Thread Tim Whittington
This appears to have broken my build on Windows (VC 2005). SHUT_RD is SD_RECEIVE on Windows? cheers tim - Original Message - From: mt...@apache.org To: dev@tomcat.apache.org Sent: Wednesday, 23 December, 2009 11:01:47 PM GMT +12:00 New Zealand Subject: svn commit: r893452 -

Re: [PROPOSAL] Log rotation in Tomcat Connector

2010-01-07 Thread Tim Whittington
09:56 AM, Tim Whittington wrote: I've attached the initial implementation, along with a docs patch, to an issue in Bugzilla. https://issues.apache.org/bugzilla/show_bug.cgi?id=48501 I managed to track down the crashing - I was referencing a jk_file_logger_t that got deallocated when

Re: svn commit: r893452 - /tomcat/jk/trunk/native/common/jk_connect.c

2010-01-07 Thread Tim Whittington
SD_RECEIVE +#else +#define SHUT_RD 0x00 +#endif +#endif /** Drain and close the socket * @param sd socket to close - Original Message - From: Tim Whittington t...@orionhealth.com To: Tomcat Developers List dev@tomcat.apache.org Sent: Thursday, 7 January, 2010 10:41:02 PM GMT +12:00

Re: [PROPOSAL] Log rotation in Tomcat Connector

2010-01-07 Thread Tim Whittington
Not sure why are you using ftell_nolock We already have a problem with ISS logging because multiple processes (IIS 6+) can write to a single log file. Yeah, my bad. Was hoping it would be cheaper than a file size check, but not thinking about multi-process IIS. On the configuration I

Use of raw HTTP headers by default in ISAPI Redirector

2010-01-07 Thread Tim Whittington
There's a long standing issue in the ISAPI redirector, that by default the HTTP headers are obtained using the CGI style ALL_HTTP variable. The net result of this is that the case of headers is lost, and all underscores in the original header names are converted to dashes. There's code in the

Re: [ANN] New committer: Tim Whittington

2010-01-12 Thread Tim Whittington
Thanks Rainer, and thanks everyone for the welcome (and the work you've put into Tomcat over the years). cheers tim - Rainer Jung rainer.j...@kippdata.de wrote: On behalf of the Tomcat committers I am pleased to announce that Tim Whittington has been voted in as a new Tomcat committer

Re: JK 1.2.29 Plan

2010-02-07 Thread Tim Whittington
I guess we need to re-plan this since we missed the dates? I'll hold off on the IIS log rotation changes until 1.2.29 is tagged. cheers tim From: Mladen Turk mt...@apache.org To: dev@tomcat.apache.org Sent: Thursday, 7 January, 2010 12:42:07 AM GMT +12:00 New Zealand Subject: Re: JK 1.2.29

Enable RAW headers by default in IIS Tomcat connector

2010-02-07 Thread Tim Whittington
Hi all Bug 38895 (Http headers with an underscore _ change into hypen -) points out that the IIS Tomcat Connector uses (by default) the CGI style headers from IIS, and thus mangles underscores in header names. There's a USE_RAW_HEADERS define that will force the use of the raw HTTP headers and

Re: Enable RAW headers by default in IIS Tomcat connector

2010-02-08 Thread Tim Whittington
: On 02/08/2010 08:38 AM, Tim Whittington wrote: There's a USE_RAW_HEADERS define that will force the use of the raw HTTP headers and avoid this problem, so I'd propose that we make that behaviour the default. I agree with having it default, but is it possible to have additional configure

Re: [VOTE] Release build 6.0.30

2011-01-11 Thread Tim Whittington
On Tue, Jan 11, 2011 at 6:18 AM, jean-frederic clere jfcl...@gmail.com wrote: The candidates binaries are available here: http://people.apache.org/~jfclere/tomcat-6/v6.0.30/ According to the release process, the 6.0.30 build corresponding to the tag TOMCAT_6_0_30 is: [ ] Broken [ ] Alpha [

Re: [VOTE] Release Tomcat 5.5.33 Build

2011-02-08 Thread Tim Whittington
The builds for Tomcat 5.5.33 are ready for testing and approval. The candidates binaries are available here: http://people.apache.org/~jim/tomcat-5.5/ According to the release process, the 5.5.33 build corresponding to the tag TOMCAT_5_5_33 [1] is: [ ] Broken [ ] Alpha [ ] Beta [x ]

Re: [VOTE] Release Apache Tomcat 7.0.12

2011-04-03 Thread Tim Whittington
The proposed 7.0.12 release is: [ ] Broken - do not release [ ] Alpha  - go ahead and release as 7.0.12 Alpha [ ] Beta   - go ahead and release as 7.0.12 Beta [x ] Stable - go ahead and release as 7.0.12 Stable https://issues.apache.org/bugzilla/show_bug.cgi?id=50957 is still a bit of a

bindOnInit and maxConnections for AJP connectors

2011-04-05 Thread Tim Whittington
In the AJP standard implementation docs, the following are not mentioned, although they're properties of AbstractEndpoint and probably should work: - bindOnInit - maxConnections Am I right in assuming these should be possible in the AJP connector (my reading of the code indicates they are - just

Re: bindOnInit and maxConnections for AJP connectors

2011-04-05 Thread Tim Whittington
by 200 threads with a 60 second keepalive timeout, which could lead to some large backlogs of connected sockets that take 50 minutes to get serviced) cheers tim On Tue, Apr 5, 2011 at 8:51 PM, Tim Whittington t...@apache.org wrote: In the AJP standard implementation docs, the following

Re: bindOnInit and maxConnections for AJP connectors

2011-04-06 Thread Tim Whittington
On Wed, Apr 6, 2011 at 11:16 PM, Mark Thomas ma...@apache.org wrote: On 05/04/2011 10:50, Tim Whittington wrote: Is what's actually going on more like: APR: use maxConnections == pollerSize (smallest will limit, but if pollerSize maxConnections then the socket backlog effectively won't

7.0.13 release for HTTP pipelining fix

2011-04-06 Thread Tim Whittington
Given the severity of https://issues.apache.org/bugzilla/show_bug.cgi?id=50957, would it be a good idea to get a 7.0.13 release out soon? 7.0.12 mitigated the issue to a degree, but I'd feel better with a complete fix. cheers tim

Re: bindOnInit and maxConnections for AJP connectors

2011-04-08 Thread Tim Whittington
On Fri, Apr 8, 2011 at 2:40 AM, Christopher Schultz ch...@christopherschultz.net wrote: Mark, I understand that a fix has already been applied, but... On 4/6/2011 7:16 AM, Mark Thomas wrote: I thought of two options for issue 3: a) Assign a processor (+ inputbuffer, output buffer etc.) to a

processorCache for APR connector is unlimited

2011-04-08 Thread Tim Whittington
The Http11Protocol and Http11NioProtocol connectors set processorCache to 200 by default, which matches the docs ([2]). The Http11AprProtocol sets it to -1 (unlimited) - is this intentional/desired or accidental? This appears to have been introduced in [1] during some refactoring by Mladen. [1]

Re: bindOnInit and maxConnections for AJP connectors

2011-04-08 Thread Tim Whittington
Are those buffers ever discarded? I guess it comes down to whether the 8k buffer belongs to the connection or to the request. It looks like the bug arises from the buffer being treated like it belongs to the request when it really belongs to the connection. I agree, switching to a

Re: New connector sandbox

2011-04-11 Thread Tim Whittington
On Mon, Apr 11, 2011 at 6:17 PM, Mladen Turk mt...@apache.org wrote: Hi, I plan to create a sandbox/connectors/native/iis7 for a native IIS7 C++ connector (since Microsoft deprecated ISAPI) Any objections? We're only just getting the ISAPI one working properly ;) +1 from me - let me know

Re: [VOTE] Release Apache Tomcat 7.0.14

2011-05-10 Thread Tim Whittington
On Tue, May 10, 2011 at 11:31 AM, Mark Thomas ma...@apache.org wrote: The proposed Apache Tomcat 7.0.14 release is now available for voting. It can be obtained from: http://people.apache.org/~markt/dev/tomcat-7/v7.0.14/ The svn tag is:

Re: [PROPOSAL] Move to svnpubsub for /dist/tomcat

2011-05-21 Thread Tim Whittington
+1 On Thu, May 19, 2011 at 1:38 AM, Mark Thomas ma...@apache.org wrote: All, We have the option to move to svnpubsub for managing our releases. Rather than copying artefacts to people.a.o and then waiting for rsync (every around 2 hours) we would commit the artefacts to svn and a commit

Re: mod_jk 1.2.32 [was: Re: svn commit: r1127315 - /tomcat/jk/trunk/xdocs/reference/apache.xml]

2011-05-28 Thread Tim Whittington
There are enough changes for a 1.2.32 anyhows, so I would propose we start a new release cycle in about 2 weeks. OK? +1 I could give RM a go if that works for ya'll - I've done a dry run already to find where everything goes. cheers tim

Re: JK 1.2.32 release kick

2011-06-27 Thread Tim Whittington
+1 from me. On Tue, Jun 28, 2011 at 7:17 AM, Konstantin Kolinko knst.koli...@gmail.com wrote: 2011/6/27 Mladen Turk mt...@apache.org: Hi, I have a time slot available so I volunteer as a 1.2.32 RM. Think we are good for a new release. Comments, objections? Sounds good. +1. Best

Re: Proposed .dsp and source change to jk for apache 2.0

2010-09-11 Thread Tim Whittington
+1 from me. I've been maintaining my own VS 2003 (and now 2005) solution for a while now with Apache 2.0/2.2 projects. cheers tim On Thu, Sep 9, 2010 at 4:51 AM, William A. Rowe Jr. wr...@rowe-clan.netwrote: It seems I've been lax in committing anything in recent memory, and had my commit

Re: [ANN] Apache Tomcat Connectors 1.2.30 released

2010-09-13 Thread Tim Whittington
I agree with this approach. I'd like to get a 1.2.31 release out sometime to release the ISAPI Redirector log rotation though, before we start on 1.3. cheers tim On Tue, Sep 14, 2010 at 9:38 AM, Rainer Jung rainer.j...@kippdata.dewrote: On 13.09.2010 23:17, William A. Rowe Jr. wrote: On

Re: [ANN] Apache Tomcat Connectors 1.2.30 released

2010-09-21 Thread Tim Whittington
: On 14.09.2010 01:14, William A. Rowe Jr. wrote: On 9/13/2010 6:11 PM, Tim Whittington wrote: I agree with this approach. I'd like to get a 1.2.31 release out sometime to release the ISAPI Redirector log rotation though, before we start on 1.3. Just to make sure there is no confusion, I'm speaking

Re: [ANN] Apache Tomcat Connectors 1.2.30 released

2010-09-21 Thread Tim Whittington
I just committed a proposed fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=49511 - if can simulate the required conditions that could bear some testing as well. cheers tim On Tue, Sep 21, 2010 at 10:49 PM, Mladen Turk mt...@apache.org wrote: On 09/21/2010 12:05 PM, Tim Whittington

Re: svn commit: r1000392 - in /tomcat/trunk: Start Tomcat.launch Stop Tomcat.launch webapps/docs/building.xml webapps/docs/changelog.xml

2010-09-26 Thread Tim Whittington
OK, will do. I've just had a motherboard failure, so will be a couple of days before I can get this patched up. Any objections to the suggestion of an 'eclipse' or 'ide-eclipse' target to pull the Eclipse files into the root directory? cheers tim On Fri, Sep 24, 2010 at 6:47 AM, Rainer Jung

Re: svn commit: r1000392 - in /tomcat/trunk: Start Tomcat.launch Stop Tomcat.launch webapps/docs/building.xml webapps/docs/changelog.xml

2010-09-26 Thread Tim Whittington
On Fri, Sep 24, 2010 at 6:49 AM, Wesley Acheson wesley.ache...@gmail.com wrote: On Thu, Sep 23, 2010 at 12:15 PM,  t...@apache.org wrote: Author: timw Date: Thu Sep 23 10:15:16 2010 New Revision: 1000392 URL: http://svn.apache.org/viewvc?rev=1000392view=rev Log:

Re: svn commit: r1001216 - /tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml

2010-09-26 Thread Tim Whittington
Bah. Trying to convince Eclipse not to use tabs is proving tricky - will be more vigilent.. cheers tim On Sun, Sep 26, 2010 at 3:28 AM, rj...@apache.org wrote: Author: rjung Date: Sat Sep 25 14:28:36 2010 New Revision: 1001216 URL: http://svn.apache.org/viewvc?rev=1001216view=rev Log:

Re: DO NOT REPLY [Bug 50001] Eclipse source files don't belong in project root.

2010-09-26 Thread Tim Whittington
OK Oh how I've missed working with Bugzilla... tim On Mon, Sep 27, 2010 at 6:29 AM, Mark Thomas ma...@apache.org wrote: On 26/09/2010 09:59, Rainer Jung wrote: On 26.09.2010 10:23, bugzi...@apache.org wrote: https://issues.apache.org/bugzilla/show_bug.cgi?id=50001 Tim

Re: Atomicity violation in setAttribute

2010-09-26 Thread Tim Whittington
This is technically a race condition, but given the vague information provided in ServletContextAttributeEvent (e.g. the inability to differentiate adds vs replaces) I can't see it causing a real problem. i.e. there's no atomicity in the interaction of an attribute listener with the context, so a

Re: svn commit: r1002073 - in /tomcat/trunk: ./ res/ide-support/ res/ide-support/eclipse/ webapps/docs/

2010-09-28 Thread Tim Whittington
Yeah saw that, but the patch was broken and this appears to work fine. I left the launch targets in place (Eclipse finds them anyway). cheers tim On Tue, Sep 28, 2010 at 10:41 PM, Wesley Acheson wesley.ache...@gmail.com wrote: On Tue, Sep 28, 2010 at 11:36 AM,  t...@apache.org wrote: Author:

Re: DO NOT REPLY [Bug 48870] New: avoid parallel arrays of base types

2010-09-29 Thread Tim Whittington
I propose to replace the parallel arrays with a ClassLoaderFactory.Repository(type, location) class and a ClassLoaderFactory.RepositoryType enum. (I know this is small fry, but just trying to get my feet under the desk so to speak...) Is the lack of such conventions now just a hangover from pre

Re: svn commit: r1004393 - /tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java

2010-10-06 Thread Tim Whittington
1. In DefaultServlet#getRelativePath(..) there is  if (request.getAttribute(Globals.INCLUDE_REQUEST_URI_ATTR) != null) branch several lines above that.  I suspect that it needs the same changes. (As it does the same things with the paths, though takes them from attributes). Fixed. Thanks for

Documentation for file serving and WebdavServlet

2010-10-06 Thread Tim Whittington
Hi all Working through https://issues.apache.org/bugzilla/show_bug.cgi?id=50026 there appears to be a lack of broader community understanding/documentation of how to configure file/resource serving in Tomcat. In particular the fact that DefaultServlet is a Servlet (and not a magic engine

Re: Missing AL headers in tomcat-trunk

2010-10-06 Thread Tim Whittington
res/ide-support/eclipse/start.launch res/ide-support/eclipse/stop.launch These 2 files have licenses in them, the same as the eclipse.* files in the same directory. Detection fail? test/org/apache/coyote/http11/TestAbstractHttp11Processor.java

Re: Missing SVN EOL-style on 2 test files

2010-10-06 Thread Tim Whittington
Fixed On Thu, Oct 7, 2010 at 12:38 PM, sebb seb...@gmail.com wrote: Current tomcat-trunk: URL: http://svn.apache.org/repos/asf/tomcat/trunk Revision: 1005289 svn ps svn:eol-style native test/org/apache/catalina/servlets/TestDefaultServlet.java svn ps svn:eol-style native

Re: Documentation for file serving and WebdavServlet

2010-10-06 Thread Tim Whittington
Hi all Working through https://issues.apache.org/bugzilla/show_bug.cgi?id=50026 there appears to be a lack of broader community understanding/documentation of how to configure file/resource serving in Tomcat. In particular the fact that DefaultServlet is a Servlet (and not a magic engine

Re: DO NOT REPLY [Bug 50078] Concurrent access to WeakHashMap in ConcurrentCache causes infinite loop, 100% CPU usage

2010-10-14 Thread Tim Whittington
I can have a look at this. Is there a preferred way of making this configurable? Given the caches are static, it's either going to be system property, or changing to using an instance cache retained somewhere appropriate (at the moment the builders appear to be instantiated in a lot of places).

Re: DO NOT REPLY [Bug 50078] Concurrent access to WeakHashMap in ConcurrentCache causes infinite loop, 100% CPU usage

2010-10-14 Thread Tim Whittington
at 6:36 AM, Mark Thomas ma...@apache.org wrote: On 14/10/2010 16:08, Mark Thomas wrote: On 14/10/2010 09:44, Tim Whittington wrote: I can have a look at this. Tim, Any progress on this? I'd like to get something into Tomcat 7 before I tag 7.0.4 later today. I'm happy to look

Re: svn commit: r1022606 - in /tomcat/trunk/java: javax/el/BeanELResolver.java org/apache/el/lang/ExpressionBuilder.java org/apache/el/util/ConcurrentCache.java

2010-10-15 Thread Tim Whittington
Modified:    tomcat/trunk/java/javax/el/BeanELResolver.java    tomcat/trunk/java/org/apache/el/lang/ExpressionBuilder.java    tomcat/trunk/java/org/apache/el/util/ConcurrentCache.java Modified: tomcat/trunk/java/javax/el/BeanELResolver.java URL:

Re: svn commit: r1022606 - in /tomcat/trunk/java: javax/el/BeanELResolver.java org/apache/el/lang/ExpressionBuilder.java org/apache/el/util/ConcurrentCache.java

2010-10-15 Thread Tim Whittington
This won't be straight forward since the data structure is being modified in the get - you can't upgrade a ReentrantReadWriteLock from a read lock to a write lock, so it doesn't handle this situation. Correction: the same lock is required to protect get and put operations on the WeakHashMap

Re: [VOTE] Release Apache Tomcat 7.0.4

2010-10-19 Thread Tim Whittington
+1 Beta The proposed 7.0.4 release is: [ ] Broken - do not release [ ] Alpha  - go ahead and release as 7.0.4 Alpha [x ] Beta   - go ahead and release as 7.0.4 Beta [ ] Stable - go ahead and release as 7.0.4 Stable - To

Re: Tagging JK 1.2.31

2010-10-21 Thread Tim Whittington
+1 I just committed a minor fix for the Apache 2.0 build with VS 2005 - not a blocker. cheers tim On Thu, Oct 21, 2010 at 8:02 PM, Mladen Turk mt...@apache.org wrote: Hi, Seems we are fine for 1.2.31 now that httpd 2.3 compiles without problems. I plan to tag 1.2.31_RC1 and make release

Re: [VOTE] Release Tomcat Connectors 1.2.31

2010-10-27 Thread Tim Whittington
Sorry, long holiday weekend in NZ. So, Tomcat Connectors 1.2.31 is: [x ] +1 release it [ ] -1 nope, it's broken tim - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail:

Re: Tomcat native ia64 binaries wrong?

2010-10-27 Thread Tim Whittington
On Tue, Oct 26, 2010 at 11:42 PM, Mladen Turk mt...@apache.org wrote: On 10/26/2010 11:28 AM, Mark Thomas wrote: Hi, I don't have the hardware to test if this is an issue on ia64 this but the following files have the same MD5 hash:

Re: [VOTE] Release Apache Tomcat 7.0.5

2010-11-29 Thread Tim Whittington
I've only been able to do limited testing, but let's keep the 7 releases ticking over. tim On Thu, Nov 25, 2010 at 7:52 AM, Mark Thomas ma...@apache.org wrote: The proposed Apache Tomcat 7.0.5 release is now available for voting. It can be obtained from:

Re: svn commit: r549328 - in /tomcat/connectors/trunk/jk/java/org/apache: coyote/ajp/AjpAprProcessor.java jk/common/JkInputStream.java

2007-06-21 Thread Tim Whittington
This would limit dynamic (servlet) responses (and for practical purposes requests) to 32bit, but Tomcat could still serve static content with a 64bit content length. tim Tim WhittingtonDevelopment Unit Manager - Concerto Portal[EMAIL PROTECTED]P: +64 9 638 0600

RE: Rebuilding isapi_redirect.dll

2007-10-27 Thread Tim Whittington
The errors sound like what you get when you build with VC2005 with the DLL C runtime, but don't install the VC8 runtime on the IIS server. Changing your runtime settings (to Multithread) should fix that. I've attached the project I use to build the ISAPI DLL - it might help. tim -Original

RE: Rebuilding isapi_redirect.dll

2007-10-28 Thread Tim Whittington
was hoping I might be able to get some more info about what's going wrong through the log, but my built version of the DLL doesn't log anything regardless of the configuration. Thanks again for any help, -Dan -Original Message- From: Tim Whittington [mailto:[EMAIL PROTECTED] Sent: Saturday

Re: [VOTE] Release Apache Tomcat Connectors 1.2.33

2012-03-13 Thread Tim Whittington
A spot belated, but: [+1] Stable, release Tested on OS X Snow Leopard and Windows 2003 Server. No problems encountered. Will be building on AIX/PPC64, HPUX/PARISC, HPUX/IA64, Solaris 10/Sparc, Solaris 10/x64 and a bunch of CentOS/RHEL versions soon. cheers tim On Sat, Mar 10, 2012 at 1:00 AM,

Re: [RESULT] Was: [VOTE] Release Apache Tomcat Connectors 1.2.33

2012-03-13 Thread Tim Whittington
Thanks Mladen The source distribution for 1.2.32 ended up in the root of the jk archive [1] (which I've only just found now ;), but all the other releases have gone into the source subdirectory [2]. I assume this was unintentional? [1] http://archive.apache.org/dist/tomcat/tomcat-connectors/jk/

Re: [RESULT] Was: [VOTE] Release Apache Tomcat Connectors 1.2.33

2012-03-14 Thread Tim Whittington
I see 1.2.33 ended up in the root of the /jk directory... On Wed, Mar 14, 2012 at 10:07 AM, Tim Whittington t...@apache.org wrote: Thanks Mladen The source distribution for 1.2.32 ended up in the root of the jk archive  [1] (which I've only just found now ;), but all the other releases have

Re: [VOTE] Release Apache Tomcat Connectors 1.2.34

2012-03-21 Thread Tim Whittington
The Apache Tomcat Connectors 1.2.34 is [X] Stable, go ahead and release [ ] Broken because of ... Looks fine on a quick test on OS X Snow Leopard, Windows 2003 Server. I'm off on holiday, so won't be able to test multi-platform for a while. cheers tim On Tue, Mar 20, 2012 at 9:49 PM, Mladen

Re: [Bug 54406] NIO and BIO connectors handle unsupported SSL ciphers and sslEnabledProtocols differently

2013-01-13 Thread Tim Whittington
On Mon, Jan 14, 2013 at 11:10 AM, bugzi...@apache.org wrote: https://issues.apache.org/bugzilla/show_bug.cgi?id=54406 --- Comment #2 from Tim Whittington t...@apache.org --- Fixed in trunk and in 7.0.x and will be included in 7.0.36 onwards. The change involved a modification

Re: [Bug 54406] NIO and BIO connectors handle unsupported SSL ciphers and sslEnabledProtocols differently

2013-01-14 Thread Tim Whittington
On Tue, Jan 15, 2013 at 1:49 PM, Christopher Schultz ch...@christopherschultz.net wrote: Tim, On 1/13/13 5:13 PM, Tim Whittington wrote: On Mon, Jan 14, 2013 at 11:10 AM, bugzi...@apache.org wrote: https://issues.apache.org/bugzilla/show_bug.cgi?id=54406 --- Comment #2 from Tim Whittington

Re: Disable TLS compression in JSSE

2013-01-22 Thread Tim Whittington
As far as I know, JSSE doesn't support compression. [1] claims this, but doesn't have a reference, and I can't find anything else useful on the internet, although i recall an analysis of the CRIME attack that claimed the same thing. At this point I'd probably opt for an OpenJDK code dive. tim

Re: [VOTE] Release Apache Tomcat Connectors 1.2.39

2014-03-12 Thread Tim Whittington
On Fri, Feb 28, 2014 at 10:35 PM, Mladen Turk mt...@apache.org wrote: Hi, Apache Tomcat Connectors 1.2.39 release candidate is ready for vote at [1]. The build was done using tag [2]. This version fixes few bugs found in released version 1.2.37 and adds some new features like IPV6 support.

Re: [VOTE] Release Apache Tomcat 8.0.5

2014-03-27 Thread Tim Whittington
The proposed 8.0.5 release is: [ ] Broken - do not release [ ] Alpha - go ahead and release as 8.0.5 (alpha) [x] Beta - go ahead and release as 8.0.5 (beta) [ ] Stable - go ahead and release as 8.0.5 (stable) cheers tim

Re: Tagging JK 1.2.40

2014-04-09 Thread Tim Whittington
On 8/04/2014, at 11:56 pm, Konstantin Kolinko knst.koli...@gmail.com wrote: 2014-04-08 11:56 GMT+04:00 Mladen Turk mt...@apache.org: Hi, I plan to tag JK 1.2.40 pretty soon (probably end of this week) We have few bugs in the latest release which requires a new version. +1 There is

Re: [Bug 55915] Add ECDHE support to tcnative-1.dll

2014-04-09 Thread Tim Whittington
Does this need a SSL_CTX_set_options(c-ctx, SSL_OP_SINGLE_ECDH_USE) as well? The API docs are pretty sparse, but it looks like mod_ssl does this (as well as nginx etc.) The description in ssl.h is “If set, always create a new key when using tmp_ecdh parameters” Reading the docs for the

Re: [VOTE] Release Apache Tomcat Native 1.1.30

2014-04-11 Thread Tim Whittington
On 10/04/2014, at 11:50 pm, Mladen Turk mt...@apache.org wrote: Version 1.1.30 is bug fixing release with added ECDH if supported by OpenSSL library. The proposed release artefacts can be found at [1], and the build was done using tag [2]. The VOTE will remain open for at least 48 hours.

Re: VOTE] Release Apache Tomcat Connectors 1.2.40

2014-04-13 Thread Tim Whittington
On 12/04/2014, at 1:17 am, Mladen Turk mt...@apache.org wrote: Hi, Apache Tomcat Connectors 1.2.40 release candidate is ready for vote at [1]. The build was done using tag [2]. This version is bugfix release, fixing some issues found in version 1.2.39. The VOTE will remain open for

  1   2   >