pbodnar commented on PR #22:
URL: https://github.com/apache/tomcat/pull/22#issuecomment-1546657736
For anyone searching for this feature, this was implemented by #354 in the
end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
pbodnar commented on PR #354:
URL: https://github.com/apache/tomcat/pull/354#issuecomment-1546656729
> Will this be backported to version 9 ?
Actually, it seems like this was merged right into the version 9 branch -
see 101476c3536ac09a105d0b603b2c51dd0f3770e9. So it is available
isapir merged PR #607:
URL: https://github.com/apache/tomcat/pull/607
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
neillee95 opened a new pull request, #616:
URL: https://github.com/apache/tomcat/pull/616
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
markt-asf commented on PR #616:
URL: https://github.com/apache/tomcat/pull/616#issuecomment-1545491107
No explanation was provided for this PR. It is tempting to close it with a
similar lack of explanation. However...
The purpose of the PR is not obvious from the context (the
markt-asf closed pull request #616: Fix backport
URL: https://github.com/apache/tomcat/pull/616
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Chaohua95 opened a new pull request, #618:
URL: https://github.com/apache/tomcat/pull/618
test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Chaohua95 closed pull request #618: Update MERGE.txt
URL: https://github.com/apache/tomcat/pull/618
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
neo-ytx opened a new pull request, #617:
URL: https://github.com/apache/tomcat/pull/617
1. I think toString method should not change the object's status. Because
this method is used for return a String. Most people think they can get
object's stringValue from this method, and will not
imario42 commented on PR #683:
URL: https://github.com/apache/tomcat/pull/683#issuecomment-1899854047
Thanks a lot @markt-asf for tackling and fixing it and @lbliangbin for the
analysis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
ConiKost opened a new pull request, #8:
URL: https://github.com/apache/tomcat-connectors/pull/8
On musl, sys/socketvar.h does not exist, so we need to make sure, not to use
it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
markt-asf closed pull request #686: Add a fallback when people use Parameters
class concurrently, to avoid lost params
URL: https://github.com/apache/tomcat/pull/686
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
markt-asf commented on PR #686:
URL: https://github.com/apache/tomcat/pull/686#issuecomment-1931626326
WONTFIX - As per section 2.3.3.4 applications are responsible for accessing
the request in a thread safe manner.
--
This is an automated message from the Apache Git Service.
To respond
markt-asf commented on PR #673:
URL: https://github.com/apache/tomcat/pull/673#issuecomment-1931686883
I was tempted to merge this but having reviewed the Tomcat code I think this
is going to create problems - the main one being that Tomcat clears the
SSLContext on Connector.stop() when
markt-asf closed pull request #673: Added option to use custom SSLContext
URL: https://github.com/apache/tomcat/pull/673
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
markt-asf commented on PR #673:
URL: https://github.com/apache/tomcat/pull/673#issuecomment-1931990842
I have some ideas on how to address this. I might have a fix for this soon
that takes account of the lifecycle issues.
--
This is an automated message from the Apache Git Service.
To
Hakky54 commented on PR #673:
URL: https://github.com/apache/tomcat/pull/673#issuecomment-1931967568
Ah that is pity, I was looking forward to it. You have a better overview of
the issues which it can cause to other functionalities. I was not aware of the
lifecycle management and only
Hakky54 commented on PR #673:
URL: https://github.com/apache/tomcat/pull/673#issuecomment-1929460593
Hi team, is there any progress on this topic. Is there something what I can
do on my side? Like backporting to other branches or anything else maybe?
--
This is an automated message from
Jaelinny commented on PR #693:
URL: https://github.com/apache/tomcat/pull/693#issuecomment-1945201345
"Sorry if my pull request caused any trouble. If there's any unintended
confusion, I deeply apologize. Please let me know if there's any way I can
resolve it with a fix."
--
This is an
dhkdtld37 commented on PR #688:
URL: https://github.com/apache/tomcat/pull/688#issuecomment-1945202137
I hope this message finds you well. I am writing to extend my sincere
apologies for any confusion caused by the branch I created for learning
purposes.
I understand that the
hyunsungJoo commented on PR #692:
URL: https://github.com/apache/tomcat/pull/692#issuecomment-1945201710
sorry. It was created due to an error while learning. I'm enjoying the
repository. thank you
--
This is an automated message from the Apache Git Service.
To respond to the message,
hyunsungJoo closed pull request #692: super tomcat
URL: https://github.com/apache/tomcat/pull/692
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Jaelinny closed pull request #693: super tomcat
URL: https://github.com/apache/tomcat/pull/693
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
temp12312yeap closed pull request #696: 20.0.0/super tomcat
URL: https://github.com/apache/tomcat/pull/696
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
temp12312yeap commented on PR #696:
URL: https://github.com/apache/tomcat/pull/696#issuecomment-1945203347
Hello there Apache! As you note, this merge was accidental as I've been
practicing merging branches using git command. Sorry for any convenience that I
could possibly made. Closing
jsmin6330 commented on PR #694:
URL: https://github.com/apache/tomcat/pull/694#issuecomment-1945202862
Dear Tomcat,
I hope this message finds you well. I am writing to express my sincere
apologies for the mistake made in the recent Pull Request (PR) submission.
I made a
Afresh2 closed pull request #697: super tomcat
URL: https://github.com/apache/tomcat/pull/697
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
papercrane55123 commented on PR #689:
URL: https://github.com/apache/tomcat/pull/689#issuecomment-1945201957
Sorry, I made a PR for learning. Thank you for always making the best
server. I delete the PR I made. Have a great day.
--
This is an automated message from the Apache Git
Afresh2 commented on PR #697:
URL: https://github.com/apache/tomcat/pull/697#issuecomment-1945202870
Hello,
I am sorry to make this PR here. I didnt mean to.
I am using apache tomcat often, and feel thankful for that.
Thank you.
--
This is an automated message from the Apache Git
jsmin6330 closed pull request #694: super tomcat
URL: https://github.com/apache/tomcat/pull/694
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dhkdtld37 opened a new pull request, #688:
URL: https://github.com/apache/tomcat/pull/688
fix README.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
papercrane55123 closed pull request #689: Super-Tomcat
URL: https://github.com/apache/tomcat/pull/689
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
pySatellite commented on PR #691:
URL: https://github.com/apache/tomcat/pull/691#issuecomment-1945200861
Sorry, I sent you the wrong PR to the branch created for learning. I'm
always using TOMCAT well as a Java developer. Thank you, I'll end that PR.
--
This is an automated message from
papercrane55123 closed pull request #689: Super-Tomcat
URL: https://github.com/apache/tomcat/pull/689
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Seull1 closed pull request #695: 20.0.0/super tomcat
URL: https://github.com/apache/tomcat/pull/695
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Seull1 commented on PR #695:
URL: https://github.com/apache/tomcat/pull/695#issuecomment-1945201326
I'm sorry. I'd appreciate it if you could let me know so that I don't make
this mistake in the future.
--
This is an automated message from the Apache Git Service.
To respond to the
pySatellite closed pull request #691: super super
URL: https://github.com/apache/tomcat/pull/691
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ae-chae opened a new pull request, #698:
URL: https://github.com/apache/tomcat/pull/698
tomcat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ae-chae closed pull request #698: 20.1.0/super tomcat
URL: https://github.com/apache/tomcat/pull/698
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
parc02 opened a new pull request, #690:
URL: https://github.com/apache/tomcat/pull/690
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
hyunsungJoo opened a new pull request, #692:
URL: https://github.com/apache/tomcat/pull/692
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
Jaelinny opened a new pull request, #693:
URL: https://github.com/apache/tomcat/pull/693
first~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
temp12312yeap opened a new pull request, #696:
URL: https://github.com/apache/tomcat/pull/696
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
dhkdtld37 closed pull request #688: fix README.md
URL: https://github.com/apache/tomcat/pull/688
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
parc02 commented on PR #694:
URL: https://github.com/apache/tomcat/pull/694#issuecomment-1945197670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
parc02 commented on PR #690:
URL: https://github.com/apache/tomcat/pull/690#issuecomment-1945205246
I offer my sincere apologies to make a PR that was meant for my learning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
parc02 closed pull request #690: Super tomcat
URL: https://github.com/apache/tomcat/pull/690
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
parc02 commented on PR #693:
URL: https://github.com/apache/tomcat/pull/693#issuecomment-1945198656
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Hakky54 commented on PR #673:
URL: https://github.com/apache/tomcat/pull/673#issuecomment-1953299389
Hi @markt-asf I just wanted to thank you. I noticed the latest version
10.1.19 is available since today. I tried it out and it works, amazing work!
--
This is an automated message from
markt-asf commented on PR #673:
URL: https://github.com/apache/tomcat/pull/673#issuecomment-1953742188
You're welcome. I didn't do much here. I just tweaked the original PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
dependabot[bot] opened a new pull request, #53:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/53
Bumps org.apache.commons:commons-compress from 1.25.0 to 1.26.0.
[
adds nonce-check skipping to the URLs that won't get nonces added to
markt-asf commented on PR #524:
URL: https://github.com/apache/tomcat/pull/524#issuecomment-1857955904
A variation of this has been applied to 11.0.x as Servlet 6.1 has added
additional methods to allow the status code to be specified in a sendRedirect()
call.
--
This is an automated
michael-o commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1428761992
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends
CsrfPreventionFilterBase {
KoteswararaoGundapaneni commented on PR #630:
URL: https://github.com/apache/tomcat/pull/630#issuecomment-1858736665
Am ready to take part in this based on the work allocated as per the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
ChristopherSchultz opened a new pull request, #681:
URL: https://github.com/apache/tomcat/pull/681
Please see https://lists.apache.org/thread/47syblyghh3tromyf6bkvl8q14w70f3x
for the initial conversation.
I see some potential improvements for the CSRF prevention filter that will
be
ChristopherSchultz commented on PR #681:
URL: https://github.com/apache/tomcat/pull/681#issuecomment-1858296301
My initial testing indicates that caching is working as expected with these
changes.
--
This is an automated message from the Apache Git Service.
To respond to the message,
ChristopherSchultz commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1437898048
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -87,11 +104,170 @@ public void setNonceRequestParameterName(String
parameterName) {
ChristopherSchultz commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1437898144
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -87,11 +104,170 @@ public void setNonceRequestParameterName(String
parameterName) {
ChristopherSchultz commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1437901624
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -87,11 +104,170 @@ public void setNonceRequestParameterName(String
parameterName) {
isapir commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1437903976
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -87,11 +104,170 @@ public void setNonceRequestParameterName(String
parameterName) {
ChristopherSchultz commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1437897171
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -87,11 +104,170 @@ public void setNonceRequestParameterName(String
parameterName) {
ChristopherSchultz commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1437896682
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -110,45 +285,70 @@ public void doFilter(ServletRequest request,
ServletResponse response,
ChristopherSchultz commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1437899157
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -87,11 +104,170 @@ public void setNonceRequestParameterName(String
parameterName) {
ChristopherSchultz commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1437900565
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -87,11 +104,170 @@ public void setNonceRequestParameterName(String
parameterName) {
isapir commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1437905241
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -110,45 +285,70 @@ public void doFilter(ServletRequest request,
ServletResponse response, FilterCha
isapir commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1437906912
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends
CsrfPreventionFilterBase {
private
markt-asf commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1431736198
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends
CsrfPreventionFilterBase {
ChristopherSchultz commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1431639832
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends
CsrfPreventionFilterBase {
ChristopherSchultz commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1432880460
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends
CsrfPreventionFilterBase {
michael-o commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1432909931
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends
CsrfPreventionFilterBase {
ChristopherSchultz commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1432853641
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends
CsrfPreventionFilterBase {
ChristopherSchultz commented on code in PR #681:
URL: https://github.com/apache/tomcat/pull/681#discussion_r1432856054
##
java/org/apache/catalina/filters/CsrfPreventionFilter.java:
##
@@ -53,6 +58,25 @@ public class CsrfPreventionFilter extends
CsrfPreventionFilterBase {
kkolinko commented on PR #681:
URL: https://github.com/apache/tomcat/pull/681#issuecomment-1864873921
Re 4: I think that if one is wise enough to write a RegExp, they could use
"|" to combine several patterns, and do not really need splitting by comma. Or
do you envision a use case, where
kkolinko commented on PR #681:
URL: https://github.com/apache/tomcat/pull/681#issuecomment-1864889547
Re 8: Whatever is easier.
(Maybe it will be easier to extract some logic into an utility class and
test that utility class. My concern is just that the logic is not trivial, is
801 - 900 of 1150 matches
Mail list logo
