[GitHub] [tomcat] be-hase commented on pull request #493: Do not use legacy character encoding(Shift_JIS) as default

2022-05-11 Thread GitBox


be-hase commented on PR #493:
URL: https://github.com/apache/tomcat/pull/493#issuecomment-1124475153

   Thanks your handling :)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] maxfortun commented on pull request #506: Adding Redirect and Proxy Error Reporting Valves

2022-05-11 Thread GitBox


maxfortun commented on PR #506:
URL: https://github.com/apache/tomcat/pull/506#issuecomment-1124294882

   @markt-asf I guess you are right and the JSP can do the same proxying as the 
valve to the external url. Still this does not scale well for our needs. We 
would need to rebuild a few hundred servlets with this approach, where many 
webapps are legacy ones where build processes no longer work. This is very 
time-costly and produces the same result as a quick tomcat config change. Just 
not worth the time for us. Thank you for your ideas.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] markt-asf commented on pull request #506: Adding Redirect and Proxy Error Reporting Valves

2022-05-11 Thread GitBox


markt-asf commented on PR #506:
URL: https://github.com/apache/tomcat/pull/506#issuecomment-1124287597

   This would be per web application but if you put the following in web.xml
   ```
   
 /WEB-INF/default-error-handler.jsp
   
   ```
   you should get close to what you need. That page can forward elsewhere if 
necessary.
   
   (The error page is placed under `WEB-INF` so it isn't directly accessible)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] maxfortun commented on pull request #506: Adding Redirect and Proxy Error Reporting Valves

2022-05-11 Thread GitBox


maxfortun commented on PR #506:
URL: https://github.com/apache/tomcat/pull/506#issuecomment-1124218158

   > This feels more like a custom ErrorReportValve rather than something that 
would ship with Tomcat. I do agree with Chris that a lot (all?) of this 
functionality could be achieved with the existing error handling mechanism and 
a suitable Servlet / JSP as the target for the error reports.
   
   @markt-asf You are right. This is a Custom error reporting valve. We are 
deploying this as a standalone artifact within our tomcat distribution. It is a 
small and a rather generic use-case that others may benefit from. This is the 
only reason I am contributing this. 

   As far as leveraging an existing error mechanism to achieve the same.. I 
spent a few hours searching github, stack overflow, and google for examples of 
delegating error reporting to something outside of an application. I was hoping 
to find something that would intercept an unhandled error and forward it to 
/ROOT/error.jsp, or some thing like that. I couldn't find anything meaningful. 
Could you please suggest an example of how I may achieve this  "with the 
existing error handling mechanism"? 
   
   Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] maxfortun commented on pull request #506: Adding Redirect and Proxy Error Reporting Valves

2022-05-11 Thread GitBox


maxfortun commented on PR #506:
URL: https://github.com/apache/tomcat/pull/506#issuecomment-1124214014

   > Thank you for your contribution. I have a few comments:
   >
   > 1. The javadoc was copy/pasted and inaccurate: both classes claim to serve 
JSPs for errors, and neither of them do this.
   
   Changed the wording.
   
   > 2. Each valve is configured using an external properties file instead of 
within `server.xml` like valves are typically configured.
   
   The idea here is to be able to provide different resource bundles based on 
the locale of the requests. French errors may looks somewhat different from 
English ones. Do you believe It is a requirement to configure valves only using 
their attributes?
   
   > 3. The documentation (XML) disagrees with the implementation, including 
documenting  attributes that don't have any effect and confusing them with 
entries in the file-based configuration and failing to document `nnn=` vs 
`http.nnn=` in any way.
   
   The documented attributes are not for the valve, but for the resource 
bundle. I believe that what the text states. How do you suggest I reword this 
to avoid confusion?
   
   > 4. Trace log statement(s) is/are not guarded by e.g. `log.isTraceEnabled`
   
   Added
   
   > 5. The URL parameters are not consistently sanitized using 
`URLEncoder.encode`
   
   Added
   
   > 6. There doesn't seem to be a reason to prohibit URL parameters from the 
"base URL" for each valve
   
   Added support for arbitrary url params.
   
   > For the "Proxy" error report valve:
   >
   > 1. No attempt is made to set the response's Content-Length or other 
appropriate headers coming from the proxied connection (I do see the 
Content-Type in there, which is good
   
   Added content-length
   > 2. This valve will fail if the request has already been using a Writer
   > 3. This valve will fail if `url.openStream` returns `null`
   Upon any failure valves return handling to ErrorReportValve.
   
   > 4. Performance: Please use `StringBuilder` instead of string-concatenation 
when possible
   Changed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] markt-asf commented on pull request #506: Adding Redirect and Proxy Error Reporting Valves

2022-05-11 Thread GitBox


markt-asf commented on PR #506:
URL: https://github.com/apache/tomcat/pull/506#issuecomment-1124090754

   This feels more like a custom ErrorReportValve rather than something that 
would ship with Tomcat. I do agree with Chris that a lot (all?) of this 
functionality could be achieved with the existing error handling mechanism and 
a suitable Servlet / JSP as the target for the error reports.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] maxfortun commented on pull request #506: Adding Redirect and Proxy Error Reporting Valves

2022-05-11 Thread GitBox


maxfortun commented on PR #506:
URL: https://github.com/apache/tomcat/pull/506#issuecomment-1124079689

   @ChristopherSchultz thank you for your meticulous review, I'll make the 
adjustments. As far as the "why". We are deploying hundreds of containerized 
apps that need the same tomcat behavior and do not want to configure this on 
app level. It is more straightforward to delegate error formatting to external 
error formatter and make updates to formatter ONLY, without having to redeploy 
a multitude of apps.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] zisding opened a new pull request, #514: Registry gives inaccurate log message saying "Creating MBeanServer ... " after already created the MBeanServer

2022-05-11 Thread GitBox


zisding opened a new pull request, #514:
URL: https://github.com/apache/tomcat/pull/514

   Hello,
   
   While viewing the https://issues.apache.org/jira/browse/MAPREDUCE-4262, I 
found that the logging statements might give inaccurate messages. 
   
   I also found that the in the line 
[465](https://github.com/apache/tomcat/blob/529117d53fba06ef1b45699e8dda16398f88acde/java/org/apache/tomcat/util/modeler/Registry.java#L465)
 of the file Registry.java, the log messages says "Creating MBeanServer". 
However, the MBean server creation should already completed in previous code 
(line 463).
   
   Would it be better if we change the verb "Creating" to "Created" to indicate 
the action is completed? Or can we move the logging statement to the line 
before 463? Since when there was an exception in line 465, the logging message 
would not be printed, which may be not good for debugging.
   
   The detailed url is:
   
https://github.com/apache/tomcat/blob/529117d53fba06ef1b45699e8dda16398f88acde/java/org/apache/tomcat/util/modeler/Registry.java#L465
   
   There is another same issue: in the line 
[378](https://github.com/apache/tomcat/blob/529117d53fba06ef1b45699e8dda16398f88acde/java/org/apache/coyote/AbstractProtocol.java#L378)
 of the file AbstractProtocol.java, the log messages says "Added processor 
...". However, the exact adding action (source code) is placed after the 
logging statement, which means that the add is still not completed.
   
   Would it be better if we change the verb "added" to "adding" to indicate the 
action is in progress? Or can we move the logging statement to the end of the 
method? 
   
   The url of file: 
   
https://github.com/apache/tomcat/blob/529117d53fba06ef1b45699e8dda16398f88acde/java/org/apache/coyote/AbstractProtocol.java#L378


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] markt-asf merged pull request #512: Adding a ServiceBindingPropertySource

2022-05-10 Thread GitBox


markt-asf merged PR #512:
URL: https://github.com/apache/tomcat/pull/512


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] markt-asf commented on pull request #512: Adding a ServiceBindingPropertySource

2022-05-10 Thread GitBox


markt-asf commented on PR #512:
URL: https://github.com/apache/tomcat/pull/512#issuecomment-1122616275

   Agreed. I was going to merge this, tidy things up a bit and then back-port.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] ChristopherSchultz commented on pull request #512: Adding a ServiceBindingPropertySource

2022-05-10 Thread GitBox


ChristopherSchultz commented on PR #512:
URL: https://github.com/apache/tomcat/pull/512#issuecomment-1122565867

   This looks interesting to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] markt-asf merged pull request #513: Typo on changelog.xml, changed from jsp:pluing to jsp:plugin.

2022-05-10 Thread GitBox


markt-asf merged PR #513:
URL: https://github.com/apache/tomcat/pull/513


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] ChristopherSchultz commented on pull request #511: Allow to decrypt PEM keys.

2022-05-10 Thread GitBox


ChristopherSchultz commented on PR #511:
URL: https://github.com/apache/tomcat/pull/511#issuecomment-1122525000

   > Mostly done but I'm looking at trying to make the support for encrypted 
PKCS1 files more generic rather than just supporting the one cipher.
   
   I had the same problem:
   
https://github.com/ChristopherSchultz/pem-utils/blob/main/src/main/java/net/christopherschultz/pemutils/PEMFile.java#L404


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] markt-asf merged pull request #510: Remove the prestartminSpareThreads field from StandardThreadExecutor

2022-05-10 Thread GitBox


markt-asf merged PR #510:
URL: https://github.com/apache/tomcat/pull/510


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] druizdeazua opened a new pull request, #513: Typo on changelog.xml, changed from jsp:pluing to jsp:plugin.

2022-05-10 Thread GitBox


druizdeazua opened a new pull request, #513:
URL: https://github.com/apache/tomcat/pull/513

   While going through changelog.xml file found small typo, just providing 
small correction.
   
   from jsp:pluing to jsp:plugin, below impacted section:
   
   
   To align with the JSP 3.1 specification, make the
   jsp:pluing action a NO-OP. No HTML will be generated as 
a
   result the jsp:pluing action being included in a JSP. 
This
   is be because the associated HTML elements are no longer supported by
   any major browser. (markt)
 
   
   
https://github.com/apache/tomcat/compare/main...druizdeazua:main#diff-57d2f0a72170743f6c3687a48997b2aa37d8d209efe200f00a0b9dc51fc7e572
   
   Please reject pull request if required, I just wanted the team to be aware.
   
   Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] garethjevans opened a new pull request, #512: Adding a ServiceBindingPropertySource

2022-05-10 Thread GitBox


garethjevans opened a new pull request, #512:
URL: https://github.com/apache/tomcat/pull/512

   The property source allows values in Tomcat's configuration
   files to be injected directly from a servicebinding.io's
   Service Binding without having to be converted to an
   environment variable first.
   
   Co-authored-by: Sumit Kulhadia 
   Co-authored-by: Gareth Evans 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] markt-asf closed pull request #511: Allow to decrypt PEM keys.

2022-05-10 Thread GitBox


markt-asf closed pull request #511: Allow to decrypt PEM keys.
URL: https://github.com/apache/tomcat/pull/511


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] markt-asf commented on pull request #511: Allow to decrypt PEM keys.

2022-05-10 Thread GitBox


markt-asf commented on PR #511:
URL: https://github.com/apache/tomcat/pull/511#issuecomment-1122302040

   Done. Not quite as generic as I would like but I couldn't figure out how to 
get from DEK-Info to JSSE standard names without a manual lookup.
   Thanks for doing all the hard work on this. I just did a little refactoring


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] jfclere commented on pull request #511: Allow to decrypt PEM keys.

2022-05-10 Thread GitBox


jfclere commented on PR #511:
URL: https://github.com/apache/tomcat/pull/511#issuecomment-1122256216

   @markt-asf OK Please close this PR when yours is ready (or when you have 
committed).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] markt-asf commented on pull request #511: Allow to decrypt PEM keys.

2022-05-10 Thread GitBox


markt-asf commented on PR #511:
URL: https://github.com/apache/tomcat/pull/511#issuecomment-1122127955

   Mostly done but I'm looking at trying to make the support for encrypted 
PKCS1 files more generic rather than just supporting the one cipher.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] markt-asf commented on pull request #511: Allow to decrypt PEM keys.

2022-05-10 Thread GitBox


markt-asf commented on PR #511:
URL: https://github.com/apache/tomcat/pull/511#issuecomment-1122094182

   +1 to broadening the support of our PEM file conversion.
   
   I think the algorithm and the digest should be saved with the part for 
consistency with the rest of the code. I'm happy to do the refactoring to do 
that.
   
   Refactoring made me think about tests to make sure i didn't break anything. 
I noticed we don't have any tests for `PEMFile` so I'm going to add some at the 
same time. I should have something to commit shortly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] jfclere commented on pull request #511: Allow to decrypt PEM keys.

2022-05-10 Thread GitBox


jfclere commented on PR #511:
URL: https://github.com/apache/tomcat/pull/511#issuecomment-1122047815

   Note openssl can used to convert the key like:
   -BEGIN RSA PRIVATE KEY-
   Proc-Type: 4,ENCRYPTED
   DEK-Info: AES-256-CBC,A337ABA05A83C84E225C79ACD675C6D2
   to the PKCS#8 format something like:
   openssl pkcs8 -topk8 -in server.key -out server.pkcs8.key
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] jfclere opened a new pull request, #511: Allow to decrypt PEM keys.

2022-05-09 Thread GitBox


jfclere opened a new pull request, #511:
URL: https://github.com/apache/tomcat/pull/511

   Allow to decrypt PEM keys starting like:
Proc-Type: 4,ENCRYPTED
   DEK-Info: DES-EDE3-CBC,3EEF0D821F09467F
   
   CRuSQwLsLRukfxzyTvl15rP4q+DGV3zTdD+vpZgpR/OiJvN2FAb/hLlMjo4RBE7m
   ...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] markt-asf closed pull request #509: 可以使定义在环境变量中的_RUNJAVA 和 _RUNJDB 支持含空格的路径

2022-05-08 Thread GitBox


markt-asf closed pull request #509: 可以使定义在环境变量中的_RUNJAVA 和 _RUNJDB 支持含空格的路径
URL: https://github.com/apache/tomcat/pull/509


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] markt-asf commented on pull request #509: 可以使定义在环境变量中的_RUNJAVA 和 _RUNJDB 支持含空格的路径

2022-05-08 Thread GitBox


markt-asf commented on PR #509:
URL: https://github.com/apache/tomcat/pull/509#issuecomment-1120468048

   Closing as spam


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] aooohan opened a new pull request, #510: Remove the prestartminSpareThreads field from StandardThreadExecutor

2022-05-08 Thread GitBox


aooohan opened a new pull request, #510:
URL: https://github.com/apache/tomcat/pull/510

   I found that in the constructor of the ThreadPoolExecutor, all core threads 
are started by default, so in the StandardThreadExecutor, 
prestartminSpareThreads becomes meaningless.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] ChristopherSchultz commented on pull request #509: 可以使定义在环境变量中的_RUNJAVA 和 _RUNJDB 支持含空格的路径

2022-05-07 Thread GitBox


ChristopherSchultz commented on PR #509:
URL: https://github.com/apache/tomcat/pull/509#issuecomment-1120279354

   This is a joke/mistake, right?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] xh02 opened a new pull request, #509: 可以使定义在环境变量中的_RUNJAVA 和 _RUNJDB 支持含空格的路径

2022-05-07 Thread GitBox


xh02 opened a new pull request, #509:
URL: https://github.com/apache/tomcat/pull/509

   可以使定义在环境变量中的_RUNJAVA 和 _RUNJDB 支持含空格的路径


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] markt-asf commented on pull request #488: Donating EL Translations

2022-05-07 Thread GitBox


markt-asf commented on PR #488:
URL: https://github.com/apache/tomcat/pull/488#issuecomment-1120183016

   There are a couple of historical exceptions but we generally only pull in a 
new language once ~10% of the terms are translated.
   The Chinese translations are in the `LocalStrings_sh_CN.properties` file.
   We could potentially pull in the translations so they are in the source but 
not build a JAR for that language. Would that help?
   We could also think about shipping some/all i18n JARs separately so users 
would download the core Tomcat distribution and then add any additional 
language(s) they wanted. That would be a discussion for the dev list.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] markt-asf closed pull request #508: Cloudevents

2022-05-07 Thread GitBox


markt-asf closed pull request #508: Cloudevents
URL: https://github.com/apache/tomcat/pull/508


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] markt-asf commented on pull request #508: Cloudevents

2022-05-07 Thread GitBox


markt-asf commented on PR #508:
URL: https://github.com/apache/tomcat/pull/508#issuecomment-1120182132

   The Jakarta APIs are defined by the Jakarta specification projects. It is 
not permitted to change them in any way.
   
   This PR has reverted multiple recent changes. That is not acceptable.
   
   This PR contains a large number of unnecessary cosmetic changes that make it 
harder to review the significant changes.
   
   This PR adds three additional JARS to the Tomcat distribution.
   
   This PR will not be merged. If there are changes you would like to see that 
would make it easier to integrate the CouldEvents API these will be considered 
but the CouldEvents API isn't going to be shipped with Tomcat at this time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] jgutie2r opened a new pull request, #508: Cloudevents

2022-05-06 Thread GitBox


jgutie2r opened a new pull request, #508:
URL: https://github.com/apache/tomcat/pull/508

   I have made some changes to ease de development of event-driven serverless 
functions using embed Tomcat. I have used the API provided by CloudEvents.
   With these changes you can develop a serverless function extending the class 
CloudEventListener and implementing the method consumeEvent(CloudEvent ev, 
HttpServletRequest, HttpServletResponse). An instance of this class can be 
registered in a Tomcat instance (as is done with a HttpServlet subclass).
   
   A new method has been added to HttpServletResponse to send a CloudEvent as 
response to the request.
   
   These changes do not break the API (provide backward compatibility), if I'm 
not wrong.
   
   Besides I have added three filters (HealthFilter, MetricsFilter, 
TokenAuthFilter) and a class to register these filters. This do not affect the 
other changes (can be removed).
   
   A script is included to install the jar in the local repository for maven.
   
   I hope these changes are not out of scope of the project.
   ---
   The code in this project has been used to develop functions that have been 
deployed on Knative.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] volosied commented on pull request #488: Donating EL Translations

2022-05-06 Thread GitBox


volosied commented on PR #488:
URL: https://github.com/apache/tomcat/pull/488#issuecomment-1119935517

   @markt-asf  Quick question -- I see some translations are missing or am I 
not looking at this right? 
   For example, I see an Italian translation is in the POEditor: 
   https://user-images.githubusercontent.com/5934310/167201467-5fb13812-e8fc-46a1-8f55-17491d970b4a.png;>
   
   But I don't see the Italian `LocalStrings_it.properties` file here: 
https://github.com/apache/tomcat/tree/main/java/jakarta/el
   
   
   Basically, I don't see the following EL files in Tomcat: 
   LocalStrings_ro.properties (Romanian)
   LocalStrings_pl.properties (Polish)
   LocalStrings_hu.properties (Hungarian)
   LocalStrings_it.properties (Italian)
   LocalStrings_zh_TW.properties (Traditional Chinese )
   LocalStrings_zh.properties (Chinese)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] ChristopherSchultz commented on pull request #506: Adding Redirect and Proxy Error Reporting Valves

2022-05-06 Thread GitBox


ChristopherSchultz commented on PR #506:
URL: https://github.com/apache/tomcat/pull/506#issuecomment-1119878843

   > Writing an HTTP proxy is non-trivial. I am going to need a LOT of 
convincing that the proxy Valve is both safe and compliant with the relevant 
RFCs.
   
   I'd like to point out that, despite it's name, this is *not* a proxy. It's 
just fetching its error response from another server, so IMHO doesn't have any 
expectation of being compliant with any particular RFC(s).
   
   That said, I'm curious as to why any of this is necessary.
   
   You can set up whatever you want in `` elements in 
`WEB-INF/web.xml` and handle errors any way you want including redirects, 
forwards, external-fetches, etc. There is no particular reason to create any 
new `Valve`s for these purposes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] markt-asf commented on pull request #506: Adding Redirect and Proxy Error Reporting Valves

2022-05-06 Thread GitBox


markt-asf commented on PR #506:
URL: https://github.com/apache/tomcat/pull/506#issuecomment-1119738823

   Writing an HTTP proxy is non-trivial. I am going to need a LOT of convincing 
that the proxy Valve is both safe and compliant with the relevant RFCs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] p-m-q opened a new pull request, #507: 9.0.x

2022-05-04 Thread GitBox


p-m-q opened a new pull request, #507:
URL: https://github.com/apache/tomcat/pull/507

   pull 9.0.x


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] ChristopherSchultz commented on pull request #506: Adding Redirect and Proxy Error Reporting Valves

2022-05-03 Thread GitBox


ChristopherSchultz commented on PR #506:
URL: https://github.com/apache/tomcat/pull/506#issuecomment-1116329419

   Thank you for your contribution. I have a few comments:
   
   1. The javadoc was copy/pasted and inaccurate: both classes claim to serve 
JSPs for errors, and neither of them do this.
   2. Each valve is configured using an external properties file instead of 
within `server.xml` like valves are typically configured.
   3. The documentation (XML) disagrees with the implementation, including 
documenting  attributes that don't have any effect and confusing them 
with entries in the file-based configuration and failing to document `nnn=` vs 
`http.nnn=` in any way
   4. Trace log statement(s) is/are not guarded by e.g. `log.isTraceEnabled`
   5. The URL parameters are not consistently sanitized using 
`URLEncoder.encode`
   6. There doesn't seem to be a reason to prohibit URL parameters from the 
"base URL" for each valve
   
   For the "Proxy" error report valve:
   1. No attempt is made to set the response's Content-Length or other 
appropriate headers coming from the proxied connection (I do see the 
Content-Type in there, which is good
   2. This valve will fail if the request has already been using a Writer
   3. This valve will fail if `url.openStream` returns `null`
   4. Performance: Please use `StringBuilder` instead of string-concatenation 
when possible
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat-native] markt-asf commented on pull request #12: Fix script to run from different directories

2022-05-03 Thread GitBox


markt-asf commented on PR #12:
URL: https://github.com/apache/tomcat-native/pull/12#issuecomment-1116300500

   Thanks for the PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat-native] markt-asf merged pull request #12: Fix script to run from different directories

2022-05-03 Thread GitBox


markt-asf merged PR #12:
URL: https://github.com/apache/tomcat-native/pull/12


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat-native] markt-asf closed pull request #11: Update BUILDING

2022-05-03 Thread GitBox


markt-asf closed pull request #11: Update BUILDING
URL: https://github.com/apache/tomcat-native/pull/11


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat-native] markt-asf commented on pull request #11: Update BUILDING

2022-05-03 Thread GitBox


markt-asf commented on PR #11:
URL: https://github.com/apache/tomcat-native/pull/11#issuecomment-1116298625

   For Linux etc it is `./Configure...` not `./configure`. I've updated 
`BUILDING`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] maxfortun opened a new pull request, #506: Adding Redirect and Proxy Error Reporting Valves

2022-05-03 Thread GitBox


maxfortun opened a new pull request, #506:
URL: https://github.com/apache/tomcat/pull/506

   These 2 error reporting valves allow to delegate error report for dynamic 
generation to an external source either via issuing a redirect or proxying the 
request. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] markt-asf closed pull request #493: Do not use legacy character encoding(Shift_JIS) as default

2022-04-28 Thread GitBox


markt-asf closed pull request #493: Do not use legacy character 
encoding(Shift_JIS) as default
URL: https://github.com/apache/tomcat/pull/493


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] markt-asf commented on pull request #493: Do not use legacy character encoding(Shift_JIS) as default

2022-04-28 Thread GitBox


markt-asf commented on PR #493:
URL: https://github.com/apache/tomcat/pull/493#issuecomment-1112523717

   I am going to revert this change but simply reverting the commit also 
reverts the changelog which I don't want. I'll do a manual revert. The TCK 
issue can be addressed via configuration in the global web.xml. I'm closing 
this PR as I need to do a manual revert.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat-training] dependabot[bot] opened a new pull request, #5: Bump async from 1.5.2 to 2.6.4

2022-04-28 Thread GitBox


dependabot[bot] opened a new pull request, #5:
URL: https://github.com/apache/tomcat-training/pull/5

   Bumps [async](https://github.com/caolan/async) from 1.5.2 to 2.6.4.
   
   Release notes
   Sourced from https://github.com/caolan/async/releases;>async's releases.
   
   v2.3.0
   
   Added support for ES2017 async functions.  Wherever you can 
pass a Node-style/CPS function that uses a callback, you can also pass an 
async function.  Previously, you had to wrap async 
functions with asyncify.  The caveat is that it will only work if 
async functions are supported natively in your environment, 
transpiled implementations can't be detected.  (https://github-redirect.dependabot.com/caolan/async/issues/1386;>#1386,
 https://github-redirect.dependabot.com/caolan/async/issues/1390;>#1390)
   
   v2.2.0
   
   Added groupBy, and the 
Series/Limit equivalents, analogous to http://lodash.com/docs#groupBy;>_.groupBy (https://github-redirect.dependabot.com/caolan/async/issues/1364;>#1364)
   Fixed transform bug when callback was not 
passed (https://github-redirect.dependabot.com/caolan/async/issues/1381;>#1381)
   
   v2.1.5
   
   Fix auto bug when function names collided with 
Array.prototype (https://github-redirect.dependabot.com/caolan/async/issues/1358;>#1358)
   Improve some error messages (https://github-redirect.dependabot.com/caolan/async/issues/1349;>#1349)
   Avoid stack overflow case in queue
   Fixed an issue in some, every and 
find where processing would continue after the result was 
determined.
   Cleanup implementations of some, every and 
find
   
   v2.1.3
   
   Make bundle size smaller
   Create optimized hotpath for filter in array case.
   
   v2.1.2
   
   Fixed a stackoverflow bug with detect, some, 
every on large inputs (https://github-redirect.dependabot.com/caolan/async/issues/1293;>#1293).
   
   v2.1.0
   
   retry and retryable now support an optional 
errorFilter function that determines if the task 
should retry on the error (https://github-redirect.dependabot.com/caolan/async/issues/1256;>#1256,
 https://github-redirect.dependabot.com/caolan/async/issues/1261;>#1261)
   Optimized array iteration in race, cargo, 
queue, and priorityQueue (https://github-redirect.dependabot.com/caolan/async/issues/1253;>#1253)
   
   v2.0.0
   Lots of changes here!
   First and foremost, we have a slick new https://caolan.github.io/async/;>site for docs. Special thanks to https://github.com/hargasinski;>@​hargasinski
 for his work converting our old docs to jsdoc format and 
implementing the new website. Also huge ups to https://github.com/ivanseidel;>@​ivanseidel
 for designing our new logo. It was a long process for both of these tasks, but 
I think these changes turned out extraordinary well.
   The biggest feature is modularization. You can now 
require(async/series) to only require the 
series function. Every Async library function is available this 
way. You still can require(async) to require the 
entire library, like you could do before.
   We also provide Async as a collection of ES2015 modules. You can now 
import {each} from 'async-es' or import waterfall from 
'async-es/waterfall'. If you are using only a few Async functions, and 
are using a ES bundler such as Rollup, this can significantly lower your build 
size.
   Major thanks to https://github.com/caolan/async/blob/HEAD/github.com/Kikobeats;>@​Kikobeats,
 https://github.com/caolan/async/blob/HEAD/github.com/aearly;>@​aearly
 and https://github.com/caolan/async/blob/HEAD/github.com/megawac;>@​megawac
 for doing the majority of the modularization work, as well as https://github.com/caolan/async/blob/HEAD/github.com/jdalton;>@​jdalton
 and https://github.com/caolan/async/blob/HEAD/github.com/Rich-Harris;>@​Rich-Harris
 for advisory work on the general modularization strategy.
   Another one of the general themes of the 2.0 release is standardization 
of what an async function is. We are now more strictly following 
the node-style continuation passing style. That is, an async function is a 
function that:
   
   Takes a variable number of arguments
   The last argument is always a callback
   The callback can accept any number of arguments
   The first argument passed to the callback will be treated as an error 
result, if the argument is truthy
   Any number of result arguments can be passed after the error 
argument
   The callback is called once and exactly once, either on the same tick or 
later tick of the JavaScript event loop.
   
   There were several cases where Async accepted some functions that did not 
strictly have these properties, most notably auto, 
every, some, and filter.
   Another theme is performance. We have eliminated internal deferrals in 
all cases where they make sense. For example, in waterfall and 
auto, there was a setImmediate between each task -- 
these deferrals have been removed. A setImmediate call can add up 
to 1ms of delay. This might not seem like a lot, but it can add up if you are 
using 

[GitHub] [tomcat] markt-asf closed pull request #496: Fix Tomcat Versions wiki url

2022-04-28 Thread GitBox


markt-asf closed pull request #496: Fix Tomcat Versions wiki url
URL: https://github.com/apache/tomcat/pull/496


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] markt-asf commented on pull request #496: Fix Tomcat Versions wiki url

2022-04-28 Thread GitBox


markt-asf commented on PR #496:
URL: https://github.com/apache/tomcat/pull/496#issuecomment-1112086527

   Thanks for spotting this. I did a more global update of wiki URLs to use the 
new wiki location.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] markt-asf commented on pull request #496: Fix Tomcat Versions wiki url

2022-04-28 Thread GitBox


markt-asf commented on PR #496:
URL: https://github.com/apache/tomcat/pull/496#issuecomment-1112060150

   FYI, no need for one PR per branch unless the patch doesn't apply cleanly 
for some reason. Generally, we merge PRs ot main and then cherry-pick them to 
the earlier branches.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] markt-asf closed pull request #500: Minor typo on javadoc of setHostHeader method

2022-04-28 Thread GitBox


markt-asf closed pull request #500: Minor typo on javadoc of setHostHeader 
method
URL: https://github.com/apache/tomcat/pull/500


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] markt-asf commented on pull request #500: Minor typo on javadoc of setHostHeader method

2022-04-28 Thread GitBox


markt-asf commented on PR #500:
URL: https://github.com/apache/tomcat/pull/500#issuecomment-1112059246

   Fixed via cherry pick of 9.0.x fix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] markt-asf commented on pull request #499: Minor typo on javadoc of setHostHeader method

2022-04-28 Thread GitBox


markt-asf commented on PR #499:
URL: https://github.com/apache/tomcat/pull/499#issuecomment-1112059069

   Fixed via cherry pick of 10.0.x fix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] markt-asf closed pull request #499: Minor typo on javadoc of setHostHeader method

2022-04-28 Thread GitBox


markt-asf closed pull request #499: Minor typo on javadoc of setHostHeader 
method
URL: https://github.com/apache/tomcat/pull/499


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] markt-asf commented on pull request #498: Minor typo on javadoc of setHostHeader method

2022-04-28 Thread GitBox


markt-asf commented on PR #498:
URL: https://github.com/apache/tomcat/pull/498#issuecomment-1112058668

   Fixed via cherry pick of 10.1.x fix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] markt-asf closed pull request #498: Minor typo on javadoc of setHostHeader method

2022-04-28 Thread GitBox


markt-asf closed pull request #498: Minor typo on javadoc of setHostHeader 
method
URL: https://github.com/apache/tomcat/pull/498


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat-training] dependabot[bot] opened a new pull request, #4: Bump grunt from 1.0.2 to 1.5.2

2022-04-27 Thread GitBox


dependabot[bot] opened a new pull request, #4:
URL: https://github.com/apache/tomcat-training/pull/4

   Bumps [grunt](https://github.com/gruntjs/grunt) from 1.0.2 to 1.5.2.
   
   Release notes
   Sourced from https://github.com/gruntjs/grunt/releases;>grunt's releases.
   
   v1.5.2
   
   Update Changelog  7f15fd5
   Merge pull request https://github-redirect.dependabot.com/gruntjs/grunt/issues/1743;>#1743
 from gruntjs/cleanup-link  b0ec6e1
   Clean up link handling  433f91b
   
   https://github.com/gruntjs/grunt/compare/v1.5.1...v1.5.2;>https://github.com/gruntjs/grunt/compare/v1.5.1...v1.5.2
   v1.5.1
   
   Merge pull request https://github-redirect.dependabot.com/gruntjs/grunt/issues/1742;>#1742
 from gruntjs/update-symlink-test  ad22608
   Fix symlink test  0652305
   
   https://github.com/gruntjs/grunt/compare/v1.5.0...v1.5.1;>https://github.com/gruntjs/grunt/compare/v1.5.0...v1.5.1
   v1.5.0
   
   Updated changelog  b2b2c2b
   Merge pull request https://github-redirect.dependabot.com/gruntjs/grunt/issues/1740;>#1740
 from gruntjs/update-deps-22-10  3eda6ae
   Update testing matrix  47d32de
   More updates  2e9161c
   Remove console log  04b960e
   Update dependencies, tests...  aad3d45
   Merge pull request https://github-redirect.dependabot.com/gruntjs/grunt/issues/1736;>#1736
 from justlep/main  fdc7056
   support .cjs extension  e35fe54
   
   https://github.com/gruntjs/grunt/compare/v1.4.1...v1.5.0;>https://github.com/gruntjs/grunt/compare/v1.4.1...v1.5.0
   v1.4.1
   
   Update Changelog  e7625e5
   Merge pull request https://github-redirect.dependabot.com/gruntjs/grunt/issues/1731;>#1731
 from gruntjs/update-options  5d67e34
   Fix ci install  d13bf88
   Switch to Actions  08896ae
   Update grunt-known-options  eee0673
   Add note about a breaking change  1b6e288
   
   https://github.com/gruntjs/grunt/compare/v1.4.0...v1.4.1;>https://github.com/gruntjs/grunt/compare/v1.4.0...v1.4.1
   v1.4.0
   
   Merge pull request https://github-redirect.dependabot.com/gruntjs/grunt/issues/1728;>#1728
 from gruntjs/update-deps-changelog  63b2e89
   Update changelog and util dep  106ed17
   Merge pull request https://github-redirect.dependabot.com/gruntjs/grunt/issues/1727;>#1727
 from gruntjs/update-deps-apr  49de70b
   Update CLI and nodeunit  47cf8b6
   Merge pull request https://github-redirect.dependabot.com/gruntjs/grunt/issues/1722;>#1722
 from gruntjs/update-through  e86db1c
   Update deps  4952368
   
   https://github.com/gruntjs/grunt/compare/v1.3.0...v1.4.0;>https://github.com/gruntjs/grunt/compare/v1.3.0...v1.4.0
   v1.3.0
   
   Merge pull request https://github-redirect.dependabot.com/gruntjs/grunt/issues/1720;>#1720
 from gruntjs/update-changelog-deps  faab6be
   Update Changelog and legacy-util dependency  520fedb
   Merge pull request https://github-redirect.dependabot.com/gruntjs/grunt/issues/1719;>#1719
 from gruntjs/yaml-refactor  7e669ac
   Switch to use safeLoad for loading YML files via 
file.readYAML.  e350cea
   
   
   
   ... (truncated)
   
   
   Changelog
   Sourced from https://github.com/gruntjs/grunt/blob/main/CHANGELOG;>grunt's 
changelog.
   
   v1.5.2
   date: 2022-04-12
   changes:
   - Unlink symlinks when copy destination is a symlink.
   v1.5.1
   date: 2022-04-11
   changes:
   - Fixed symlink destination handling.
   v1.5.0
   date: 2022-04-10
   changes:
   - Updated dependencies.
   - Add symlink handling for copying files.
   v1.4.1
   date: 2021-05-24
   changes:
   - Fix --preload option to be a known option
   - Switch to GitHub Actions
   v1.4.0
   date: 2021-04-21
   changes:
   - Security fixes in production and dev dependencies
   - Liftup/Liftoff upgrade breaking change. Update your scripts to use 
--preload instead of --require. Ref: https://github.com/js-cli/js-liftoff/commit/e7a969d6706e730d90abb4e24d3cb4d3bce06ddb;>https://github.com/js-cli/js-liftoff/commit/e7a969d6706e730d90abb4e24d3cb4d3bce06ddb.
   v1.3.0
   date: 2020-08-18
   changes:
   - Switch to use safeLoad for loading YML files via 
file.readYAML.
   - Upgrade legacy-log to ~3.0.0.
   - Upgrade legacy-util to ~2.0.0.
   v1.2.1
   date: 2020-07-07
   changes:
   - Remove path-is-absolute dependency.
   (PR: https://github-redirect.dependabot.com/gruntjs/grunt/pull/1715;>gruntjs/grunt#1715)
   v1.2.0
   date: 2020-07-03
   changes:
   - Allow usage of grunt plugins that are located in any location that
   is visible to Node.js and NPM, instead of node_modules directly
   inside package that have a dev dependency to these plugins.
   (PR: https://github-redirect.dependabot.com/gruntjs/grunt/pull/1677;>gruntjs/grunt#1677)
   - Removed coffeescript from dependencies. To ease transition, if
   coffeescript is still around, Grunt will attempt to load it.
   If it is not, and the user loads a CoffeeScript file,
   Grunt will print a useful error indicating that the
   coffeescript package should be installed as a dev dependency.
   This is considerably more user-friendly than dropping 

[GitHub] [tomcat] jeanouii commented on pull request #505: JasperInitializer not correctly initialized when a Default JspFactory is already defined

2022-04-25 Thread GitBox


jeanouii commented on PR #505:
URL: https://github.com/apache/tomcat/pull/505#issuecomment-1108775222

   I first had the same though. Why not just using the API and call 
getDefaultFactory. Thanks Remy


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] rmaucher commented on pull request #505: JasperInitializer not correctly initialized when a Default JspFactory is already defined

2022-04-25 Thread GitBox


rmaucher commented on PR #505:
URL: https://github.com/apache/tomcat/pull/505#issuecomment-1108763955

   Adding this field was a bad idea. I'm removing it now instead.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] rmaucher closed pull request #505: JasperInitializer not correctly initialized when a Default JspFactory is already defined

2022-04-25 Thread GitBox


rmaucher closed pull request #505: JasperInitializer not correctly initialized 
when a Default JspFactory is already defined
URL: https://github.com/apache/tomcat/pull/505


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] jeanouii opened a new pull request, #505: JasperInitializer not correctly initialized when a Default JspFactory is already defined

2022-04-25 Thread GitBox


jeanouii opened a new pull request, #505:
URL: https://github.com/apache/tomcat/pull/505

   An issue as been introduced in JasperInitializer with commit 
https://github.com/apache/tomcat/commit/5e8eb5533f551c3dbc3003e4c2f4f0d2958a8eb3
   
   When a default JspFactory is already defined the static field 
`defaultFactory` in JasperInitializer isn't initialized. It produces a 
NullPointerException line 108 when setting the poolSize.
   
   This fix enforces a proper initialization even when the default JspFactory 
is already set.
   Adding a small test checking the PoolSize can be set using the 
ServletContext and therefor the bug as been fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] markt-asf commented on pull request #496: Fix Tomcat Versions wiki url

2022-04-24 Thread GitBox


markt-asf commented on PR #496:
URL: https://github.com/apache/tomcat/pull/496#issuecomment-1107806007

   This should be changed to the canonical URL which is:
   https://cwiki.apache.org/confluence/display/TOMCAT/Tomcat+Versions
   
   In the meantime, I have added a redirect so users don't see a 404.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] markt-asf closed pull request #504: disable jsp and jspx by default

2022-04-13 Thread GitBox


markt-asf closed pull request #504: disable jsp and jspx by default
URL: https://github.com/apache/tomcat/pull/504


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] markt-asf commented on pull request #504: disable jsp and jspx by default

2022-04-13 Thread GitBox


markt-asf commented on PR #504:
URL: https://github.com/apache/tomcat/pull/504#issuecomment-1098727906

   This is a bad idea for so many different reasons. To name a few:
   
   - "Spring4Shell" allows arbitrary file uploads. All an attacker has to do to 
bypass this change is to upload a web.xml file that re-enables the mapping
   - It does nothing to help users that want/need to use JSPs.
   - Users that had followed the documented security recommendations and set OS 
file permissions appropriately would have been protected not only against 
"Spring4Shell"but against any similar vulnerability as well


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] k4n5ha0 opened a new pull request, #504: disable jsp and jspx by default

2022-04-13 Thread GitBox


k4n5ha0 opened a new pull request, #504:
URL: https://github.com/apache/tomcat/pull/504

   jsp and jspx is dangerous. likes spring4shell and others hacker,they use 
uplaod jsp or write a webshell to disk.
   If project need jsp or jspx, they pack web.xml in war with jsp mappings by 
themself.
   secure by default.
   thx!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] CrazyHZM closed pull request #502: Support max http request header size and max http header size configuration separation

2022-04-11 Thread GitBox


CrazyHZM closed pull request #502: Support max http request header size and max 
http header size configuration separation
URL: https://github.com/apache/tomcat/pull/502


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] CrazyHZM closed pull request #503: Support max http request header size and max http header size configuration separation

2022-04-11 Thread GitBox


CrazyHZM closed pull request #503: Support max http request header size and max 
http header size configuration separation
URL: https://github.com/apache/tomcat/pull/503


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] CrazyHZM opened a new pull request, #503: Support max http request header size and max http header size configuration separation

2022-04-11 Thread GitBox


CrazyHZM opened a new pull request, #503:
URL: https://github.com/apache/tomcat/pull/503

   Mail link:https://bz.apache.org/bugzilla/show_bug.cgi?id=65866


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] CrazyHZM commented on pull request #501: Support max http request header size and max http header size configuration separation

2022-04-11 Thread GitBox


CrazyHZM commented on PR #501:
URL: https://github.com/apache/tomcat/pull/501#issuecomment-1094939842

   @rmaucher 
   Do i need to resubmit a clean pr?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] rmaucher commented on pull request #501: Support max http request header size and max http header size configuration separation

2022-04-11 Thread GitBox


rmaucher commented on PR #501:
URL: https://github.com/apache/tomcat/pull/501#issuecomment-1094929661

   Merged with changed. I didn't understand the changes to TestHttp2Limits, 
HTTP/2 should use the new request header size and that should be it. Also 
updated docs and changelog.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] rmaucher closed pull request #501: Support max http request header size and max http header size configuration separation

2022-04-11 Thread GitBox


rmaucher closed pull request #501: Support max http request header size and max 
http header size configuration separation
URL: https://github.com/apache/tomcat/pull/501


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] CrazyHZM commented on pull request #501: Support max http request header size and max http header size configuration separation

2022-04-11 Thread GitBox


CrazyHZM commented on PR #501:
URL: https://github.com/apache/tomcat/pull/501#issuecomment-1094916955

   @rmaucher 
   I can patch several other branches, right?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] rmaucher commented on pull request #501: Support max http request header size and max http header size configuration separation

2022-04-11 Thread GitBox


rmaucher commented on PR #501:
URL: https://github.com/apache/tomcat/pull/501#issuecomment-1094815675

   The proposed patch is still simpler and should work well, so I will merge 
that one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] gmshake commented on pull request #501: Support max http request header size and max http header size configuration separation

2022-04-11 Thread GitBox


gmshake commented on PR #501:
URL: https://github.com/apache/tomcat/pull/501#issuecomment-1094800382

   > Overall, I prefer the PR as it is right now, it's simpler. If the new 
setters are used, then the behavior could be slightly different, but since this 
is new API this should be fine.
   
   It is not complicated. I forked and edit online to demonstrate the part of 
change: 
https://github.com/gmshake/tomcat/commit/75289cf9e7a3920cc6d3ea0463db53a6ab0d090c?diff=split


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] rmaucher commented on pull request #501: Support max http request header size and max http header size configuration separation

2022-04-11 Thread GitBox


rmaucher commented on PR #501:
URL: https://github.com/apache/tomcat/pull/501#issuecomment-1094743565

   Overall, I prefer the PR as it is right now, it's simpler. If the new 
setters are used, then the behavior could be slightly different, but since this 
is new API this should be fine.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] rmannibucau commented on a diff in pull request #501: Support max http request header size and max http header size configuration separation

2022-04-11 Thread GitBox


rmannibucau commented on code in PR #501:
URL: https://github.com/apache/tomcat/pull/501#discussion_r847064940


##
java/org/apache/coyote/http11/AbstractHttp11Protocol.java:
##
@@ -244,6 +244,34 @@ public void setMaxSavePostSize(int maxSavePostSize) {
 public void setMaxHttpHeaderSize(int valueI) { maxHttpHeaderSize = valueI; 
}
 
 
+/**
+ * Maximum size of the HTTP request message header.
+ */
+private int maxHttpRequestHeaderSize = -1;

Review Comment:
   Setter should stay IMHO and set both values to the exact same one *if not 
already set*.
   Getter should get the max value since the consumer wants the max size and it 
is exactly the semantic of this method (= what is the max for request and 
response, only change is that before it was a single value, now it is really a 
max but a min is wrong IMHO).
   
   So IMHO it makes perfect sense as method for frameworks and integrators to 
still have this, in particular when it is linked to pooling where max is more 
intended than min or any value under the max.
   
   > I still insist that semantic level compatibility is more important than 
API level compatibility
   
   Well there are two points:
   
   1. API compat: IMHO it is not an option to break before next 10.2 or 
something like that
   2. semantic level is preserved and it makes sense to have this shortcut IMHO 
so we can solve both at once



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] gmshake commented on a diff in pull request #501: Support max http request header size and max http header size configuration separation

2022-04-11 Thread GitBox


gmshake commented on code in PR #501:
URL: https://github.com/apache/tomcat/pull/501#discussion_r847041315


##
java/org/apache/coyote/http11/AbstractHttp11Protocol.java:
##
@@ -244,6 +244,34 @@ public void setMaxSavePostSize(int maxSavePostSize) {
 public void setMaxHttpHeaderSize(int valueI) { maxHttpHeaderSize = valueI; 
}
 
 
+/**
+ * Maximum size of the HTTP request message header.
+ */
+private int maxHttpRequestHeaderSize = -1;

Review Comment:
   Keep `getMaxHttpHeaderSize()` only preserves API level compatibility, the 
semantic of `getMaxHttpHeaderSize()` has change once we introduce dedicated 
header settings for request and response.
   
   To illustrate the semantic change:
   ```java
   setMaxHttpHeaderSize(4096);
   setMaxHttpRequestHeaderSize(8192);
   setMaxHttpResponseHeaderSize(16384);
   ```
   Then `getMaxHttpHeaderSize()` make no sense except the only meaning "default 
maxHttpHeaderSize"
   
   Maybe it is more reasonable to deprecate `getMaxHttpHeaderSize()` and return 
a size that is not too bad:
   ```java
   @Deprecated
   public int getMaxHttpHeaderSize() {
   return Math.min(maxHttpRequestHeaderSize, maxHttpResponseHeaderSize)
   }
   ```
   
   I still insist that semantic level compatibility is more important than API 
level compatibility. For `setMaxHttpHeaderSize()` it originally means set 
maximum size of the HTTP message header for both request and response.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] gmshake commented on a diff in pull request #501: Support max http request header size and max http header size configuration separation

2022-04-11 Thread GitBox


gmshake commented on code in PR #501:
URL: https://github.com/apache/tomcat/pull/501#discussion_r847041315


##
java/org/apache/coyote/http11/AbstractHttp11Protocol.java:
##
@@ -244,6 +244,34 @@ public void setMaxSavePostSize(int maxSavePostSize) {
 public void setMaxHttpHeaderSize(int valueI) { maxHttpHeaderSize = valueI; 
}
 
 
+/**
+ * Maximum size of the HTTP request message header.
+ */
+private int maxHttpRequestHeaderSize = -1;

Review Comment:
   Keep `getMaxHttpHeaderSize()` only preserves API level compatibility, the 
semantic of `getMaxHttpHeaderSize()` has change once we introduce dedicated 
header settings for request and response.
   
   To illustrate the semantic change:
   ```java
   setMaxHttpHeaderSize(4096);
   setMaxHttpRequestHeaderSize(8192);
   setMaxHttpResponseHeaderSize(16384);
   ```
   Then `getMaxHttpHeaderSize()` make no sense except the only meaning "default 
maxHttpHeaderSize"
   
   Maybe it is more reasonable to deprecate `getMaxHttpHeaderSize()` and return 
a size that is not too bad:
   ```java
   public int getMaxHttpHeaderSize() {
   return Math.min(maxHttpRequestHeaderSize, maxHttpResponseHeaderSize)
   }
   ```
   
   I still insist that semantic level compatibility is more important than API 
level compatibility. For `setMaxHttpHeaderSize()` it originally means set 
maximum size of the HTTP message header for both request and response.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] gmshake commented on a diff in pull request #501: Support max http request header size and max http header size configuration separation

2022-04-11 Thread GitBox


gmshake commented on code in PR #501:
URL: https://github.com/apache/tomcat/pull/501#discussion_r847041315


##
java/org/apache/coyote/http11/AbstractHttp11Protocol.java:
##
@@ -244,6 +244,34 @@ public void setMaxSavePostSize(int maxSavePostSize) {
 public void setMaxHttpHeaderSize(int valueI) { maxHttpHeaderSize = valueI; 
}
 
 
+/**
+ * Maximum size of the HTTP request message header.
+ */
+private int maxHttpRequestHeaderSize = -1;

Review Comment:
   Keep `getMaxHttpHeaderSize()` only preserves API level compatibility, the 
semantic of `getMaxHttpHeaderSize()` has change once we introduce dedicated 
header settings for request and response.
   
   To illustrate the semantic change:
   ```java
   setMaxHttpHeaderSize(4096);
   setMaxHttpRequestHeaderSize(8192);
   setMaxHttpResponseHeaderSize(16384);
   ```
   Then `getMaxHttpHeaderSize()` make no sense except the only meaning "default 
maxHttpHeaderSize"
   
   Maybe it is  deprecate `getMaxHttpHeaderSize()` and return a size that is 
not too bad:
   ```java
   public int getMaxHttpHeaderSize() {
   return Math.min(maxHttpRequestHeaderSize, maxHttpResponseHeaderSize)
   }
   ```
   
   I still insist that semantic level compatibility is more important than API 
level compatibility. For `setMaxHttpHeaderSize()` it originally means set 
maximum size of the HTTP message header for both request and response.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] rmannibucau commented on pull request #501: Support max http request header size and max http header size configuration separation

2022-04-11 Thread GitBox


rmannibucau commented on PR #501:
URL: https://github.com/apache/tomcat/pull/501#issuecomment-1094636457

   +1 I see two advantages:
   
   1. enables cases where "front" tomcat has big incoming headers but "normal" 
forwarded headers
   2. enables better web server abstractions which often have this configuration
   
   Open question: shouldn't `setMaxHttpHeaderSize` set both request and 
response ones and `maxHttpHeaderSize` field be dropped for backward compat?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] CrazyHZM commented on pull request #501: Support max http request header size and max http header size configuration separation

2022-04-11 Thread GitBox


CrazyHZM commented on PR #501:
URL: https://github.com/apache/tomcat/pull/501#issuecomment-1094629380

   > That seems pretty straightforward. I'm slightly skeptical about the real 
practical use since trying to optimize the sizes too much is risky, but no 
problem, this is the user's responsibility.
   
   @rmaucher 
   I saw some discussion about this, you can refer to it: 
   https://github.com/spring-projects/spring-boot/issues/29382


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] CrazyHZM commented on a diff in pull request #501: Support max http request header size and max http header size configuration separation

2022-04-11 Thread GitBox


CrazyHZM commented on code in PR #501:
URL: https://github.com/apache/tomcat/pull/501#discussion_r847005884


##
java/org/apache/coyote/http11/AbstractHttp11Protocol.java:
##
@@ -244,6 +244,34 @@ public void setMaxSavePostSize(int maxSavePostSize) {
 public void setMaxHttpHeaderSize(int valueI) { maxHttpHeaderSize = valueI; 
}
 
 
+/**
+ * Maximum size of the HTTP request message header.
+ */
+private int maxHttpRequestHeaderSize = -1;

Review Comment:
   I'm worried about the compatibility risk of removing getMaxHttpHeaderSize(), 
because this is a public API after all, I wonder if this change can be done in 
10.1.x. of which I agree with the annotation Deprecated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] rmaucher commented on pull request #501: Support max http request header size and max http header size configuration separation

2022-04-11 Thread GitBox


rmaucher commented on PR #501:
URL: https://github.com/apache/tomcat/pull/501#issuecomment-1094622549

   That seems pretty straightforward. I'm slightly skeptical about the real 
practical use since trying to optimize the sizes too much is risky, but no 
problem, this is the user's responsibility.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] gmshake commented on a diff in pull request #501: Support max http request header size and max http header size configuration separation

2022-04-11 Thread GitBox


gmshake commented on code in PR #501:
URL: https://github.com/apache/tomcat/pull/501#discussion_r846991658


##
java/org/apache/coyote/http11/AbstractHttp11Protocol.java:
##
@@ -244,6 +244,34 @@ public void setMaxSavePostSize(int maxSavePostSize) {
 public void setMaxHttpHeaderSize(int valueI) { maxHttpHeaderSize = valueI; 
}
 
 
+/**
+ * Maximum size of the HTTP request message header.
+ */
+private int maxHttpRequestHeaderSize = -1;

Review Comment:
   After the change, `maxHttpHeaderSize` becomes default maximum size of the 
HTTP message header for both request and response.
   
   If we no longer have consumer of `getMaxHttpHeaderSize()`, then I'd suggest 
to remove `maxHttpHeaderSize`, and change `setMaxHttpHeaderSize()` like this 
   
   ```java
   @Deprecated
   public void setMaxHttpHeaderSize(int valueI) {
   maxHttpRequestHeaderSize = valueI;
   maxHttpResponseHeaderSize = valueI;
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] CrazyHZM opened a new pull request, #502: Support max http request header size and max http header size configuration separation

2022-04-11 Thread GitBox


CrazyHZM opened a new pull request, #502:
URL: https://github.com/apache/tomcat/pull/502

   Mail link:https://bz.apache.org/bugzilla/show_bug.cgi?id=65866


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] CrazyHZM commented on pull request #501: Support max http request header size and max http header size configuration separation

2022-04-11 Thread GitBox


CrazyHZM commented on PR #501:
URL: https://github.com/apache/tomcat/pull/501#issuecomment-1094598895

   Please review the code first, if there is no problem, I will support this on 
other branches as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] CrazyHZM opened a new pull request, #501: Support max http request header size and max http header size configuration separation

2022-04-11 Thread GitBox


CrazyHZM opened a new pull request, #501:
URL: https://github.com/apache/tomcat/pull/501

   Mail link:https://bz.apache.org/bugzilla/show_bug.cgi?id=65866
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat-training] dependabot[bot] opened a new pull request, #3: Bump minimist from 0.0.8 to 1.2.6

2022-04-09 Thread GitBox


dependabot[bot] opened a new pull request, #3:
URL: https://github.com/apache/tomcat-training/pull/3

   Bumps [minimist](https://github.com/substack/minimist) from 0.0.8 to 1.2.6.
   
   Commits
   
   https://github.com/substack/minimist/commit/7efb22a518b53b06f5b02a1038a88bd6290c2846;>7efb22a
 1.2.6
   https://github.com/substack/minimist/commit/ef88b9325f77b5ee643ccfc97e2ebda577e4c4e2;>ef88b93
 security notice for additional prototype pollution issue
   https://github.com/substack/minimist/commit/c2b981977fa834b223b408cfb860f933c9811e4d;>c2b9819
 isConstructorOrProto adapted from PR
   https://github.com/substack/minimist/commit/bc8ecee43875261f4f17eb20b1243d3ed15e70eb;>bc8ecee
 test from prototype pollution PR
   https://github.com/substack/minimist/commit/aeb3e27dae0412de5c0494e9563a5f10c82cc7a9;>aeb3e27
 1.2.5
   https://github.com/substack/minimist/commit/278677b171d956b46613a158c6c486c3ef979b20;>278677b
 1.2.4
   https://github.com/substack/minimist/commit/4cf1354839cb972e38496d35e12f806eea92c11f;>4cf1354
 security notice
   https://github.com/substack/minimist/commit/1043d212c3caaf871966e710f52cfdf02f9eea4b;>1043d21
 additional test for constructor prototype pollution
   https://github.com/substack/minimist/commit/6457d7440a47f329c12c4a5abfbce211c4235b93;>6457d74
 1.2.3
   https://github.com/substack/minimist/commit/38a4d1caead72ef99e824bb420a2528eec03d9ab;>38a4d1c
 even more aggressive checks for protocol pollution
   Additional commits viewable in https://github.com/substack/minimist/compare/0.0.8...1.2.6;>compare 
view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=minimist=npm_and_yarn=0.0.8=1.2.6)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   - `@dependabot use these labels` will set the current labels as the default 
for future PRs for this repo and language
   - `@dependabot use these reviewers` will set the current reviewers as the 
default for future PRs for this repo and language
   - `@dependabot use these assignees` will set the current assignees as the 
default for future PRs for this repo and language
   - `@dependabot use this milestone` will set the current milestone as the 
default for future PRs for this repo and language
   
   You can disable automated security fix PRs for this repo from the [Security 
Alerts page](https://github.com/apache/tomcat-training/network/alerts).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] leggiero commented on pull request #495: Minor typo on javadoc of setHostHeader method

2022-04-08 Thread GitBox


leggiero commented on PR #495:
URL: https://github.com/apache/tomcat/pull/495#issuecomment-1093126687

   @isapir Just opened them :+1: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] leggiero closed pull request #497: Minor typo on javadoc of setHostHeader method

2022-04-08 Thread GitBox


leggiero closed pull request #497: Minor typo on javadoc of setHostHeader method
URL: https://github.com/apache/tomcat/pull/497


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] leggiero opened a new pull request, #497: Minor typo on javadoc of setHostHeader method

2022-04-08 Thread GitBox


leggiero opened a new pull request, #497:
URL: https://github.com/apache/tomcat/pull/497

   - This file should only be in the main branch
   - Version updates
   - Remove testing support for old OpenSSL versions
   - Code clean-up: Add braces for clarity
   - Code clean-up: Add braces for clarity
   - Code cleanup: Add races for clarity.
   - Code clean-up. Add braces for clarity.
   - Code clean-up. Add braces for clarity.
   - Update schema used in web-fragments
   - Some more Java EE 8 to Jakarta EE 9 updates
   - Export no longer needed. Only used in main branch.
   - Update JspC to use Servlet 5.0 schemas
   - AprLifecycleListener does not show dev version suffix for libtcnative and 
libapr
   - Update import/export to handle POEditor behaviours
   - Back-port translation updates
   - Simplify AprEndpoint socket bind for all platforms
   - Renaming to make code clearer
   - Increase data written to ensure required (for the test) IOE is triggered
   - Code clean-up. Add braces for clarity.
   - Clean-up. Remove unused import.
   - Code clean-up. Add braces for clarity
   - Remove TODOs
   - Code clean-up. Add braces for clarity.
   - Code clean-up. Add braces to improve clarity
   - Code clean-up. Add braces to improve readability.
   - Code clean-up. Add braces for clarity. Enable check now all are fixed.
   - Code clean-up. Fix remaining braces.
   - Add ALv2 header (reported by RAT)
   - Add 2 missed output files from Jakarta EE 9
   - Code clean-up. Remove unnecessary code.
   - Need unique name for log files else they overwrite each other
   - Remove useless strings
   - Remove unused translations (also removed from poeditor.com)
   - Clean up
   - LocalString_xx.properties are UTF-8 when filtered
   - Fix BZ 65342. Correct regression in fix for BZ 65262.
   - Fix some indentation issues
   - Remove blank lines between license header and package declaration
   - Refactor principal handling for UserDatabaseRealm
   - 65340: Fix NegativeArraySizeException exception in hpack decoder
   - Fix missing code from the original hasRole
   - Clean-up. Fix indents.
   - No need for these internal classes to be package visible.
   - Fix long content-length handling for doHead()
   - Avoid synchronization on roles verification
   - Refactor HEAD testing so other Servlets can be tested
   - Fix HEAD response for reset() and resetBuffer()
   - Fix getPrincipal logic
   - Fix HEAD for the non-blocking case.
   - Update Korean translations
   - Update French translations
   - Packaging on main only
   - Fix BZ 65358 - Improve EL matching of varargs methods.
   - Fix 65362. Add JPMS entries to embedded JARs removed in previous release
   - Add debug logging for HPACK decoding
   - Restore a (commented out) HTTP/2 example
   - Update to Tomcat Native 1.2.30
   - Fix 65332 - javac permissions with Java 9 onwards for JSPs
   - Treat empty token at end the same way as empty token at start/middle
   - Remove support for the identity T-E header value
   - Process T-E header from both HTTP 1.0 and HTTP 1.1. clients
   - Ensure chunked, if present, is the last encoding in the list
   - Update timestamp for reproducible builds
   - Fix typos
   - Fix typo
   - Fix typo
   - Increment version for next development cycle
   - Integrate JSign for cross-platform builds with signed Windows binaries
   - Fix BZ 65368 - better handling of closed TLS connection
   - Update version numbers
   - Expand test case to cover example from BZ 65373
   - Fix problems with file uploads and HTTP/2
   - Add missing values in message
   - Add debug logging for overhead count
   - Fix HTTP/2 tests broken by changes to small window update frames
   - Reduce overhead count by 2 rather than 1 for non-overhead frames
   - Add release date for 10.0.7
   - Remove docs for removed attribute
   - Update comments after change to DEFAULT_OVERHEAD_REDUCTION_FACTOR
   - Change the starting overhead count from -10 to -10*overheadCountFactor
   - Multiple increment and decrement by 10 to provide more control
   - Continue if the build/test step fails so the logs are uploaded
   - Use the standard utility method for List to comma separated string
   - Remove deprecated and unused code
   - Act on rather old TODO comment
   - Revert "Remove deprecated and unused code"
   - Relax parsing of 1#token to align with RFC 7230 section 7
   - Extend the time allowed for tests to complete
   - Add expanded unit tests for HEAD and fix bugs identified in buffering
   - Fix test broken by response buffer fixes
   - Remove trailing space
   - Fix BZ 6539. Closes #422. Add Java 16+ options to service.bat
   - Fix BZ 65385 - correct link to Maven Central repo
   - Fix potential hang with concurrent reads or concurrent writes
   - Fix BZ 65384 - Make test Locale independent
   - Fix BZ 65387 - fix regression in generated code clean-up
   - Fix BZ 65390 - revert code removal made in error
   - Fix typos
   - Make fields accessible to sub-classes of JNDIRealm
   - Update the 

[GitHub] [tomcat] leggiero opened a new pull request, #496: Fix Tomcat Versions wiki url

2022-04-08 Thread GitBox


leggiero opened a new pull request, #496:
URL: https://github.com/apache/tomcat/pull/496

   - Minor typo on javadoc of setHostHeader method
   - Fix URL to Tomcat Versions page redirection
   - Fix URL to Tomcat Versions page redirection
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat-native] dsoumis opened a new pull request, #12: Fix script to run from different directories

2022-04-08 Thread GitBox


dsoumis opened a new pull request, #12:
URL: https://github.com/apache/tomcat-native/pull/12

   By adding cd $(dirname $0) , user can run script from external directory and 
not having issues with the actual location of deps directory.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] isapir commented on pull request #495: Minor typo on javadoc of setHostHeader method

2022-04-07 Thread GitBox


isapir commented on PR #495:
URL: https://github.com/apache/tomcat/pull/495#issuecomment-1092290696

   @leggiero Can you do the same for the other active branches?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] isapir merged pull request #495: Minor typo on javadoc of setHostHeader method

2022-04-07 Thread GitBox


isapir merged PR #495:
URL: https://github.com/apache/tomcat/pull/495


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] rmaucher closed pull request #494: Update BUILDING.txt

2022-04-07 Thread GitBox


rmaucher closed pull request #494: Update BUILDING.txt
URL: https://github.com/apache/tomcat/pull/494


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] rmaucher commented on pull request #494: Update BUILDING.txt

2022-04-07 Thread GitBox


rmaucher commented on PR #494:
URL: https://github.com/apache/tomcat/pull/494#issuecomment-1091648175

   Ok, this is now integrated, after fixing another item.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] dsoumis opened a new pull request, #494: Update BUILDING.txt

2022-04-07 Thread GitBox


dsoumis opened a new pull request, #494:
URL: https://github.com/apache/tomcat/pull/494

   Regarding build.xml , there is not "native" directory in default path.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat-jakartaee-migration] suhail-1997 opened a new issue, #25: java.lang.IllegalArgumentException: Unknown Entity bean class with eclipselink in tomcat 10

2022-04-07 Thread GitBox


suhail-1997 opened a new issue, #25:
URL: https://github.com/apache/tomcat-jakartaee-migration/issues/25

   Im trying to upgrade spring web app to tomcat 10 for the upgrade im using 
apache jakarta migration tool. the application got successfully migrated using 
this tool but when i run the application in tomcat 10 im facing following issue
   
   java.lang.IllegalArgumentException: Unknown Entity bean class please verify 
that this class has been marked with the @Entity annotation.
   
   and tables are not being created in the database.
   
   when i run same application in tomcat 9 the tables are being created and i 
dont face any exception there.
   
   i cant able to figure what is the problem in tomcat 10 even after using 
migration tool.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] be-hase commented on pull request #493: Do not use legacy character encoding(Shift_JIS) as default

2022-04-06 Thread GitBox


be-hase commented on PR #493:
URL: https://github.com/apache/tomcat/pull/493#issuecomment-1091012924

   [off topic]
   For 
[Spring4Shell](https://spring.io/blog/2022/03/31/spring-framework-rce-early-announcement),
 I did a version up of Spring Boot. Then I met this `Shift_JIS` problem.  
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] Oliverwqcwrw closed pull request #492: Remove redundant 'of'

2022-04-06 Thread GitBox


Oliverwqcwrw closed pull request #492: Remove redundant 'of'
URL: https://github.com/apache/tomcat/pull/492


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] be-hase commented on pull request #493: Do not use legacy character encoding(Shift_JIS) as default

2022-04-06 Thread GitBox


be-hase commented on PR #493:
URL: https://github.com/apache/tomcat/pull/493#issuecomment-1090173899

   Sorry, I'm not familiar with full history. I would be grateful if you could 
consider this issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



  1   2   3   4   5   6   7   8   9   10   >