Re: [VOTE] Release Apache Tomcat 9.0.63

2022-05-12 Thread Igal Sapir
On Wed, May 11, 2022 at 1:27 AM Rémy Maucherat  wrote:

> The proposed Apache Tomcat 9.0.63 release is now available for voting.
>
> The notable changes compared to 9.0.62 are:
>
> - Provide a property source that sources values from Kubernetes service
>bindings. Provided by Sumit Kulhadia and Gareth Evans.
>
> - The root cause of the Linux kernel duplicate accept bug has been
>identified along with the version of the kernel that includes the fix.
>The error message displayed when this bug occurs has been updated to
>reflect this new information and to advise users to update to a
>version of the OS that uses kernel 5.10 or later. Thanks to
>Christopher Gual for the research into this issue.
>
> - Update the packaged version of the Tomcat Native Library to 1.2.33 to
>pick up Windows binaries built with OpenSSL 1.1.1o.
>
> - Add support for encrypted PKCS#1 formatted private keys when configuring
>the internal, in memory key store.
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://nightlies.apache.org/tomcat/tomcat-9.0.x/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.63/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1374
> The tag is:
> https://github.com/apache/tomcat/tree/9.0.63
> 538ed3896852b3608561ba6f3d0bc8890ae15de1
>
> The proposed 9.0.63 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 9.0.63 (stable)
>

Unit tests passed on Ubuntu 20.04 with Java 11

Igal



>
> Rémy
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 10.0.21

2022-05-11 Thread Igal Sapir
On Tue, May 10, 2022 at 3:39 PM Mark Thomas  wrote:

> The proposed Apache Tomcat 10.0.21 release is now available for
> voting.
>
> Apache Tomcat 10.0.x implements Jakarta EE 9 and, as such, the primary
> package for all the specification APIs has changed from javax.* to
> jakarta.*
>
> Applications that run on Tomcat 9 will not run on Tomcat 10 without
> changes. Java EE applications designed for Tomcat 9 and earlier may be
> placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat will
> automatically convert them to Jakarta EE and copy them to the webapps
> directory
>
> The notable changes compared to 10.0.20 are:
>
> - Provide a property source that sources values from Kubernetes service
>bindings. Provided by Sumit Kulhadia and Gareth Evans.
>
> - The root cause of the Linux kernel duplicate accept bug has been
>identified along with the version of the kernel that includes the fix.
>The error message displayed when this bug occurs has been updated to
>reflect this new information and to advise users to update to a
>version of the OS that uses kernel 5.10 or later. Thanks to
>Christopher Gual for the research into this issue.
>
> - Update the packaged version of the Tomcat Native Library to 1.2.33 to
>pick up Windows binaries built with OpenSSL 1.1.1o.
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://nightlies.apache.org/tomcat/tomcat-10.0.x/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.0.21/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1373
>
> The tag is:
> https://github.com/apache/tomcat/tree/10.0.21
> feb577944dee2ac7cc9839638e9388d90067f1cb
>
> The proposed 10.0.21 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 10.0.21 (stable)
>

Unit tests passed on Ubuntu 20.04 with Java 11

Igal



>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 10.1.0-M15

2022-05-11 Thread Igal Sapir
On Tue, May 10, 2022 at 1:25 PM Mark Thomas  wrote:

> The proposed Apache Tomcat 10.1.0-M15 release is now available for
> voting.
>
> Applications that run on Tomcat 9 and earlier will not run on Tomcat 10
> without changes. Java EE applications designed for Tomcat 9 and earlier
> may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat
> will automatically convert them to Jakarta EE and copy them to the
> webapps directory.
>
> The notable changes compared to 10.1.0-M14 are:
>
> - Provide a property source that sources values from Kubernetes service
>bindings. Provided by Sumit Kulhadia and Gareth Evans.
>
> - The root cause of the Linux kernel duplicate accept bug has been
>identified along with the version of the kernel that includes the fix.
>The error message displayed when this bug occurs has been updated to
>reflect this new information and to advise users to update to a
>version of the OS that uses kernel 5.10 or later. Thanks to
>Christopher Gual for the research into this issue.
>
> - Update the packaged version of the Tomcat Native Library to 1.2.33 to
>pick up Windows binaries built with OpenSSL 1.1.1o.
>
> For full details, see the change log:
> https://nightlies.apache.org/tomcat/tomcat-10.1.x/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.0-M15/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1371
>
> The tag is:
> https://github.com/apache/tomcat/tree/10.1.0-M15
> dcf3e81b2e709574971c7a9592614d70c1b55bf7
>
>
> The proposed 10.1.0-M15 release is:
> [ ] Broken - do not release
> [X] Alpha - go ahead and release as 10.1.0-M15 (alpha)
>

Tested from git tag so Maven issue should not have affected me.

Unit tests passed on Ubuntu 20.04 with Java 11.

Igal



>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat Native 1.2.33

2022-05-03 Thread Igal Sapir
On Tue, May 3, 2022 at 1:45 PM Mark Thomas  wrote:

> Version 1.2.33 includes the following changes compared to 1.2.32
>
> - Updated recommended minimum OpenSSL to 1.1.1o and build windows
>binaries using that version
>
> - Fix BZ 66035, a crash when attempting to read the TSL session ID after
>a failed handshake
>
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
>
> The Apache Tomcat Native 1.2.33 release is
>   [X] Stable, go ahead and release
>   [ ] Broken because of ...
>

Built from source and passed APR unit tests on Ubuntu with Java 11

Igal



>
> Thanks,
>
> Mark
>
>
> [1]
>
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/1.2.33
> [2]
>
> https://gitbox.apache.org/repos/asf?p=tomcat-native.git;a=commit;h=5806305d98ef24f60ea1a4d8c99ef29e6faab434
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat Native 1.2.32

2022-03-17 Thread Igal Sapir
On Thu, Mar 17, 2022 at 1:48 AM Mark Thomas  wrote:

> Version 1.2.32 includes the following changes compared to 1.2.31
>
> - Updated recommended minimum OpenSSL to 1.1.1n and build windows
>binaries using that version
>
> - Fix release script so it works with the current git layout
>
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
>
> The Apache Tomcat Native 1.2.32 release is
>   [X] Stable, go ahead and release
>   [ ] Broken because of ...
>

Built from source and passed APR unit tests on Ubuntu 20.04 with Java 11

Igal



>
> Thanks,
>
> Mark
>
>
> [1]
>
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/1.2.32
> [2]
>
> https://gitbox.apache.org/repos/asf?p=tomcat-native.git;a=commit;h=ee11afcb5bc3426b85525985461484222f609406
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 10.1.0-M12

2022-03-13 Thread Igal Sapir
On Wed, Mar 9, 2022 at 6:00 AM Mark Thomas  wrote:

> The proposed Apache Tomcat 10.1.0-M12 release is now available for
> voting.
>
> Applications that run on Tomcat 9 and earlier will not run on Tomcat 10
> without changes. Java EE applications designed for Tomcat 9 and earlier
> may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat
> will automatically convert them to Jakarta EE and copy them to the
> webapps directory.
>
> The notable changes compared to 10.1.0-M11 are:
>
> - Fix a potential thread-safety issue that could cause HTTP/1.1 request
>processing to pause, and potentially timeout, waiting for additional
>data when the full request has been received.
>
> - Fix a regression introduced with 65757 bugfix which better identified
>non request threads but which introduced a similar problem when user
>code was doing sequential operations in a single thread.
>
> - When resolving methods in EL expressions that use beans and/or static
>fields, ensure that any custom type conversion is considered when
>identifying the method to call.
>
> For full details, see the changelog:
> https://nightlies.apache.org/tomcat/tomcat-10.1.x/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.0-M12/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1360
>
> The tag is:
> https://github.com/apache/tomcat/tree/10.1.0-M12
> d08498a3cefa7206bad791acf019455794f865ea
>
>
> The proposed 10.1.0-M12 release is:
> [ ] Broken - do not release
> [X] Alpha - go ahead and release as 10.1.0-M12 (alpha)
>

Unit tests passed on Ubuntu 20.04 with Java 11.0.14 after patching BZ-65951
[1] which is a minor bug and IMHO should not affect the release.

Igal

[1] https://bz.apache.org/bugzilla/show_bug.cgi?id=65951


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 10.0.18

2022-03-13 Thread Igal Sapir
On Wed, Mar 9, 2022 at 6:52 AM Mark Thomas  wrote:

> The proposed Apache Tomcat 10.0.18 release is now available for
> voting.
>
> Apache Tomcat 10.0.x implements Jakarta EE 9 and, as such, the primary
> package for all the specification APIs has changed from javax.* to
> jakarta.*
>
> Applications that run on Tomcat 9 will not run on Tomcat 10 without
> changes. Java EE applications designed for Tomcat 9 and earlier may be
> placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat will
> automatically convert them to Jakarta EE and copy them to the webapps
> directory
>
> The notable changes compared to 10.0.17 are:
>
> - Fix a potential thread-safety issue that could cause HTTP/1.1 request
>processing to pause, and potentially timeout, waiting for additional
>data when the full request has been received.
>
> - Fix a regression introduced with 65757 bugfix which better identified
>non request threads but which introduced a similar problem when user
>code was doing sequential operations in a single thread.
>
> - When resolving methods in EL expressions that use beans and/or static
>fields, ensure that any custom type conversion is considered when
>identifying the method to call.
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://nightlies.apache.org/tomcat/tomcat-10.0.x/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.0.18/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1361
>
> The tag is:
> https://github.com/apache/tomcat/tree/10.0.18
> 70f59e8328621e58b9493c119f05a2e57f597a1c
>
> The proposed 10.0.18 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 10.0.18 (stable)
>

After a system reboot the unit tests passed on Ubuntu 20.04 with Java
11.0.14.

Igal



>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 8.5.77

2022-03-13 Thread Igal Sapir
On Sun, Mar 13, 2022 at 12:41 PM Christopher Schultz <
ch...@christopherschultz.net> wrote:

> The proposed Apache Tomcat 8.5.77 release is now available for voting.
>
> The notable changes compared to 8.5.76 are:
>
> - Fix a potential thread-safety issue that could cause HTTP/1.1 request
> processing to pause, and potentially timeout, waiting for additional
> data when the full request has been received.
>
> - Fix a regression introduced with 65757 bugfix which better identified
> non request threads but which introduced a similar problem when user
> code was doing sequential operations in a single thread.
>
> - When resolving methods in EL expressions that use beans and/or static
> fields, ensure that any custom type conversion is considered when
> identifying the method to call.
>
> Along with lots of other bug fixes and improvements.
>
> This is the second release of Tomcat 8.5 that has been built with Java
> 11 (in Java 7 mode) instead of Java 7. Please report any strangeness you
> may observe especially if you are running Tomcat 8.5 in an environment
> using Java < 11. We don't expect any issues, but understand that we
> cannot test all possible environmental configurations.
>
> For full details, see the changelog:
> https://nightlies.apache.org/tomcat/tomcat-8.5.x/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.77/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1363
> The tag is:
> https://github.com/apache/tomcat/tree/8.5.77
> 3931695e564dd4dd1dbf029026e900b74992408c
>
> The proposed 8.5.77 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.5.76 (stable)
>

Unit tests passed with Java 11.0.14 on Ubuntu 20.04

Igal



>
> -chris
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 10.1.0-M12

2022-03-13 Thread Igal Sapir
Mark,

On Sun, Mar 13, 2022 at 10:00 AM Mark Thomas  wrote:

> Works for me. CI systems (Gump, BuidlBot) also look OK.
>
> Maybe something related to the build environment?
>

Thanks!  I see the problem, and it also affects other versions, e.g. 9.0.x.

For each major version I have a git tree, and in that directory I have a
setting for the output directory, e.g. for 9.0.x I have
  tomcat.output=/workspace/build/tomcat/9.0.x

The manifest files are created in the correct directory:
  build-manifests:
  [mkdir] Created dir: /workspace/build/tomcat/9.0.x/manifests
   [copy] Copying 21 files to /workspace/build/tomcat/9.0.x/manifests

But are then "read" from the wrong place and fail because there is no such
directory:
  [bnd] 2 ERRORS
  [bnd]  Input file does not exist:
../../output/manifests/default.license
  [bnd]  Input file does not exist:
../../output/manifests/default.notice
  [bnd]
/workspace/src/tomcat/9.0.x/res/bnd/annotations-api.jar.tmp.bnd: bnd failed

I will try to find where that happens and patch it.

Igal



>
> Mark
>
>
> On 12/03/2022 19:45, Igal Sapir wrote:
> > On Wed, Mar 9, 2022 at 6:00 AM Mark Thomas  wrote:
> >
> >> The proposed Apache Tomcat 10.1.0-M12 release is now available for
> >> voting.
> >>
> >> Applications that run on Tomcat 9 and earlier will not run on Tomcat 10
> >> without changes. Java EE applications designed for Tomcat 9 and earlier
> >> may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat
> >> will automatically convert them to Jakarta EE and copy them to the
> >> webapps directory.
> >>
> >> The notable changes compared to 10.1.0-M11 are:
> >>
> >> - Fix a potential thread-safety issue that could cause HTTP/1.1 request
> >> processing to pause, and potentially timeout, waiting for additional
> >> data when the full request has been received.
> >>
> >> - Fix a regression introduced with 65757 bugfix which better identified
> >> non request threads but which introduced a similar problem when user
> >> code was doing sequential operations in a single thread.
> >>
> >> - When resolving methods in EL expressions that use beans and/or static
> >> fields, ensure that any custom type conversion is considered when
> >> identifying the method to call.
> >>
> >> For full details, see the changelog:
> >> https://nightlies.apache.org/tomcat/tomcat-10.1.x/docs/changelog.html
> >>
> >> It can be obtained from:
> >> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.0-M12/
> >>
> >> The Maven staging repo is:
> >> https://repository.apache.org/content/repositories/orgapachetomcat-1360
> >>
> >> The tag is:
> >> https://github.com/apache/tomcat/tree/10.1.0-M12
> >> d08498a3cefa7206bad791acf019455794f865ea
> >>
> >>
> >> The proposed 10.1.0-M12 release is:
> >> [ ] Broken - do not release
> >> [ ] Alpha - go ahead and release as 10.1.0-M12 (alpha)
> >>
> >
> > Was there a change in dependencies?  I get an error while trying to run
> > `ant clean test` using Java 11.0.14 on Ubuntu 20.04:
> >
> > package:
> >[jar] Building jar:
> > /workspace/build/tomcat/main/build/lib/annotations-api.jar
> >
> > add-osgi:
> >   [echo] add-osgi
> > /workspace/build/tomcat/main/build/lib/annotations-api.jar true
> >[bnd] [main] WARN aQute.bnd.plugin.jpms.JPMSModuleInfoPlugin -
> Using
> > module name 'jakarta.annotation' for: Jar:annotations-api
> >[bnd] 2 ERRORS
> >[bnd]  Input file does not exist:
> > ../../output/manifests/default.license
> >[bnd]  Input file does not exist:
> > ../../output/manifests/default.notice
> >[bnd]
> /workspace/src/tomcat/main/res/bnd/annotations-api.jar.tmp.bnd:
> > bnd failed
> >[bnd] at
> > aQute.bnd.ant.BndTask.executeBackwardCompatible(BndTask.java:231)
> >[bnd] at aQute.bnd.ant.BndTask.execute(BndTask.java:117)
> >[bnd] at
> > org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
> >[bnd] at
> jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown
> > Source)
> >[bnd] at
> >
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> >[bnd] at
> java.base/java.lang.reflect.Method.invoke(Method.java:566)
> >[bnd] at
> >
> org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99)

Re: [VOTE] Release Apache Tomcat 10.1.0-M12

2022-03-12 Thread Igal Sapir
On Wed, Mar 9, 2022 at 6:00 AM Mark Thomas  wrote:

> The proposed Apache Tomcat 10.1.0-M12 release is now available for
> voting.
>
> Applications that run on Tomcat 9 and earlier will not run on Tomcat 10
> without changes. Java EE applications designed for Tomcat 9 and earlier
> may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat
> will automatically convert them to Jakarta EE and copy them to the
> webapps directory.
>
> The notable changes compared to 10.1.0-M11 are:
>
> - Fix a potential thread-safety issue that could cause HTTP/1.1 request
>processing to pause, and potentially timeout, waiting for additional
>data when the full request has been received.
>
> - Fix a regression introduced with 65757 bugfix which better identified
>non request threads but which introduced a similar problem when user
>code was doing sequential operations in a single thread.
>
> - When resolving methods in EL expressions that use beans and/or static
>fields, ensure that any custom type conversion is considered when
>identifying the method to call.
>
> For full details, see the changelog:
> https://nightlies.apache.org/tomcat/tomcat-10.1.x/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.0-M12/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1360
>
> The tag is:
> https://github.com/apache/tomcat/tree/10.1.0-M12
> d08498a3cefa7206bad791acf019455794f865ea
>
>
> The proposed 10.1.0-M12 release is:
> [ ] Broken - do not release
> [ ] Alpha - go ahead and release as 10.1.0-M12 (alpha)
>

Was there a change in dependencies?  I get an error while trying to run
`ant clean test` using Java 11.0.14 on Ubuntu 20.04:

package:
  [jar] Building jar:
/workspace/build/tomcat/main/build/lib/annotations-api.jar

add-osgi:
 [echo] add-osgi
/workspace/build/tomcat/main/build/lib/annotations-api.jar true
  [bnd] [main] WARN aQute.bnd.plugin.jpms.JPMSModuleInfoPlugin - Using
module name 'jakarta.annotation' for: Jar:annotations-api
  [bnd] 2 ERRORS
  [bnd]  Input file does not exist:
../../output/manifests/default.license
  [bnd]  Input file does not exist:
../../output/manifests/default.notice
  [bnd] /workspace/src/tomcat/main/res/bnd/annotations-api.jar.tmp.bnd:
bnd failed
  [bnd] at
aQute.bnd.ant.BndTask.executeBackwardCompatible(BndTask.java:231)
  [bnd] at aQute.bnd.ant.BndTask.execute(BndTask.java:117)
  [bnd] at
org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:292)
  [bnd] at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown
Source)
  [bnd] at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
  [bnd] at java.base/java.lang.reflect.Method.invoke(Method.java:566)
  [bnd] at
org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:99)
  [bnd] at org.apache.tools.ant.Task.perform(Task.java:350)
  ...
BUILD FAILED
/workspace/src/tomcat/main/build.xml:1036: The following error occurred
while executing this line:
/workspace/src/tomcat/main/build.xml:3798: The following error occurred
while executing this line:
/workspace/src/tomcat/main/build.xml:3820: Failed to build jar file:


Igal




>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 10.0.18

2022-03-12 Thread Igal Sapir
On Wed, Mar 9, 2022 at 6:52 AM Mark Thomas  wrote:

> The proposed Apache Tomcat 10.0.18 release is now available for
> voting.
>
> Apache Tomcat 10.0.x implements Jakarta EE 9 and, as such, the primary
> package for all the specification APIs has changed from javax.* to
> jakarta.*
>
> Applications that run on Tomcat 9 will not run on Tomcat 10 without
> changes. Java EE applications designed for Tomcat 9 and earlier may be
> placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat will
> automatically convert them to Jakarta EE and copy them to the webapps
> directory
>
> The notable changes compared to 10.0.17 are:
>
> - Fix a potential thread-safety issue that could cause HTTP/1.1 request
>processing to pause, and potentially timeout, waiting for additional
>data when the full request has been received.
>
> - Fix a regression introduced with 65757 bugfix which better identified
>non request threads but which introduced a similar problem when user
>code was doing sequential operations in a single thread.
>
> - When resolving methods in EL expressions that use beans and/or static
>fields, ensure that any custom type conversion is considered when
>identifying the method to call.
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://nightlies.apache.org/tomcat/tomcat-10.0.x/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.0.18/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1361
>
> The tag is:
> https://github.com/apache/tomcat/tree/10.0.18
> 70f59e8328621e58b9493c119f05a2e57f597a1c
>
> The proposed 10.0.18 release is:
> [ ] Broken - do not release
> [ ] Stable - go ahead and release as 10.0.18 (stable)
>

The unit
test TEST-org.apache.tomcat.jni.TestSocketServerAnyLocalAddress.NIO2.txt
which used to work properly in my environment is failing with an error [1].

Any ideas why?

Igal

[1] Testsuite: org.apache.tomcat.jni.TestSocketServerAnyLocalAddress
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 130.291 sec
- Standard Output ---
Server is listening at [/0:0:0:0:0:0:0:0:35999]
Client attempting to connect to [/2600:1700:4000:8120:0:0:0:40%wlp2s0:35999]
-  ---
- Standard Error -
java.net.ConnectException: Connection timed out (Connection timed out)
at java.base/java.net.PlainSocketImpl.socketConnect(Native Method)
at
java.base/java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:412)
at
java.base/java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:255)
at
java.base/java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:237)
at
java.base/java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392)
at java.base/java.net.Socket.connect(Socket.java:615)
at
org.apache.tomcat.jni.TestSocketServerAnyLocalAddress$Client.run(TestSocketServerAnyLocalAddress.java:139)
-  ---

Testcase: testWithClient took 130.268 sec
Caused an ERROR
22: Invalid argument
org.apache.tomcat.jni.Error: 22: Invalid argument
at org.apache.tomcat.jni.Socket.accept(Native Method)
at
org.apache.tomcat.jni.TestSocketServerAnyLocalAddress.testWithClient(TestSocketServerAnyLocalAddress.java:94)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)



>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [PROPOSAL] Change default TLS protocol from "all" to "TLSv1.2,TLSv1.3" in Tomcat 10.1

2022-02-28 Thread Igal Sapir
On Mon, Feb 28, 2022 at 8:12 AM Christopher Schultz <
ch...@christopherschultz.net> wrote:

> All,
>
> As the subject says.
>
> Or, perhaps, redefine "all" to be "TLSv1.2,TLSv1.3" similarly to what we
> did in the past when removing SSLv3 from the definition of "all".
>
> I think this should be done with Tomcat 10.1 (relatively new) to set a
> precedent moving forward, but not 8.5 or 9.0 to avoid disrupting
> production deployments.
>

+1

Igal



>
> -chris
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 8.5.75 (clarified version numbers, again)

2022-01-19 Thread Igal Sapir
On Tue, Jan 18, 2022 at 2:26 PM Christopher Schultz <
ch...@christopherschultz.net> wrote:

> The proposed Apache Tomcat 8.5.75 release is now available for voting.
>
> The proposed 8.5.75 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.5.75 (stable)
>

+1

Igal



>
> -chris
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 8.5.75

2022-01-17 Thread Igal Sapir
On Mon, Jan 17, 2022 at 2:43 PM Christopher Schultz <
ch...@christopherschultz.net> wrote:

> The proposed 8.5.75 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.5.75 (stable)
>

Unit tests passed on Ubuntu with Java 11

Igal


>
> -chris
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 8.5.75

2022-01-17 Thread Igal Sapir
Chris,

On Mon, Jan 17, 2022 at 2:43 PM Christopher Schultz <
ch...@christopherschultz.net> wrote:

> The proposed Apache Tomcat 8.5.74 release is now available for voting.
>
> The one notable change compared to 8.5.74 (which was not released due to
> this bug) is:
>

The old version 8.5.74 is in various places of the body of the email.  Not
a big deal as we know we're voting for 8.5.75 but you might consider
to send a different email to avoid confusion?  Just a thought.

Igal



>
> - Correct a regression in the fix for BZ 65785 that broke HTTP/2
>  server push.
>
> The notable changes compared to 8.5.73 are:
>
> - Provide protection against a known OS bug that causes the acceptor to
> report an incoming connection more than once.
>
> - Fix several potential JVM crashes when using the APR connector.
>
> - Implement a workaround for a JVM bug that can trigger a file
> descriptor leak when using multi-part upload and the application does
> not explicitly close an input stream for an uploaded file that was
> cached on disk.
>
> - Fix exceptions when the security manager is enabled and the first
> request received after starting is an HTTP request to a TLS enabled
> NIO2 connector.
>
> - Implement support for HTTP/1.1 upgrade when the request includes a
> body. The maximum permitted size of the body is controlled by
> maxSavePostSize.
>
> - Improve handling of various cases where one request/response
> processing thread attempts to manage the asynchronous IO for a
> different request/response.
>
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat-8.5.x/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.75/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1355
> The tag is:
> https://github.com/apache/tomcat/tree/8.5.75/
> Commit b5c9c3a25a17f777989408973013f5312acdb8e2
>
> The proposed 8.5.74 release is:
> [ ] Broken - do not release
> [ ] Stable - go ahead and release as 8.5.75 (stable)
>
> -chris
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 9.0.58

2022-01-16 Thread Igal Sapir
On Sat, Jan 15, 2022 at 6:51 AM Rémy Maucherat  wrote:

>
> The proposed 9.0.58 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 9.0.58 (stable)
>

Unit tests passed on Ubuntu with Java 11

Igal



>
> Rémy
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 10.0.16

2022-01-16 Thread Igal Sapir
On Sat, Jan 15, 2022 at 6:12 AM Mark Thomas  wrote:

> The proposed 10.0.16 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 10.0.16 (stable)
>

Unit tests passed on Ubuntu with Java 11

Igal



>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 10.1.0-M10

2022-01-16 Thread Igal Sapir
On Sat, Jan 15, 2022 at 4:49 AM Mark Thomas  wrote:

> The proposed Apache Tomcat 10.1.0-M10 release is now available for
> voting.
>
> The proposed 10.1.0-M10 release is:
> [ ] Broken - do not release
> [X] Alpha - go ahead and release as 10.1.0-M10 (alpha)
>

Unit tests passed on Ubuntu with Java 11

Igal



>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 8.5.73

2021-11-11 Thread Igal Sapir
On Thu, Nov 11, 2021 at 7:35 AM Christopher Schultz <
ch...@christopherschultz.net> wrote:

> 
>
> The proposed 8.5.73 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.5.73 (stable)
>

Unit tests passed on Ubuntu 20.04 with Java 17

Igal



>
> -chris
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 9.0.55

2021-11-11 Thread Igal Sapir
On Wed, Nov 10, 2021 at 12:55 AM Rémy Maucherat  wrote:

> 
>
> The proposed 9.0.55 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 9.0.55 (stable)
>

Unit tests passed on Ubuntu with Java 17

Igal



>
> Rémy
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 10.0.13

2021-11-11 Thread Igal Sapir
On Tue, Nov 9, 2021 at 2:51 PM Mark Thomas  wrote:

> 
>
> The proposed 10.0.13 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 10.0.13 (stable)
>

Unit tests passed on Ubuntu with Java 17

Igal



>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 10.1.0-M7

2021-11-11 Thread Igal Sapir
On Mon, Nov 8, 2021 at 1:59 PM Mark Thomas  wrote:

> 
>
> The proposed 10.1.0-M7 release is:
> [ ] Broken - do not release
> [X] Alpha - go ahead and release as 10.1.0-M7 (alpha)
>

Unit tests passed on Ubuntu with Java 17

Igal



>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 8.5.72

2021-10-01 Thread Igal Sapir
On Fri, Oct 1, 2021 at 8:47 AM Christopher Schultz <
ch...@christopherschultz.net> wrote:

> The proposed Apache Tomcat 8.5.72 release is now available for voting.
>
> The notable changes compared to 8.5.71 are:
>
> - Further robustness improvements to HTTP/2 flow control window
> management
>
> - Fix an issue that caused some Servlet non-blocking API reads of the
> HTTP request body to incorrectly use blocking IO.
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat-8.5.x/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.72/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1337
> The tag is:
> https://github.com/apache/tomcat/tree/8.5.72
> 53c394049af76032bc7acab9de023013ad4fdc43
>
> The proposed 8.5.72 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.5.72 (stable)
>

+1

Unit tests passed on Ubuntu 20.04 with Java 11

Igal



>
> -chris
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 10.0.12

2021-09-28 Thread Igal Sapir
On Tue, Sep 28, 2021 at 6:59 AM Mark Thomas  wrote:

> The proposed Apache Tomcat 10.0.12 release is now available for
> voting.
>
> Apache Tomcat 10.x implements Jakarta EE 9 and, as such, the primary
> package for all the specification APIs has changed from javax.* to
> jakarta.*
>
> Applications that run on Tomcat 9 will not run on Tomcat 10 without
> changes. Java EE applications designed for Tomcat 9 and earlier may be
> placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat will
> automatically convert them to Jakarta EE and copy them to the webapps
> directory
>
> The notable changes compared to 10.0.11 are:
>
> - Further robustness improvements to HTTP/2 flow control window
>management
>
> - Improvements to the DataSourceUserDatabase
>
> - Fix an issue that caused some Servlet non-blocking API reads of the
>HTTP request body to incorrectly use blocking IO.
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat-10.0.x/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.0.12/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1335
>
> The tag is:
> https://github.com/apache/tomcat/tree/10.0.12
> 84e18583f461778707f7fd2e25b1f0677e44e899
>
> The proposed 10.0.12 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 10.0.12 (stable)
>

+1 Unit tests passed on Ubuntu 20.04 with Java 11

Igal



>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 9.0.54

2021-09-28 Thread Igal Sapir
On Tue, Sep 28, 2021 at 7:25 AM Rémy Maucherat  wrote:

> The proposed Apache Tomcat 9.0.54 release is now available for voting.
>
> The notable changes compared to 9.0.54 are:
>
> - Further robustness improvements to HTTP/2 flow control window
>management
>
> - Improvements to the DataSourceUserDatabase
>
> - Fix an issue that caused some Servlet non-blocking API reads of the
>HTTP request body to incorrectly use blocking IO.
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat-9.0.x/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.54/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1336
> The tag is:
> https://github.com/apache/tomcat/tree/9.0.54
> 454f804f3336ec980e84eb84bb6a051e349c6d3a
>
> The proposed 9.0.54 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 9.0.54 (stable)
>

+1 Unit tests passed on Ubuntu 20.04 with Java 11

Igal



>
> Rémy
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 10.1.0-M6

2021-09-28 Thread Igal Sapir
On Tue, Sep 28, 2021 at 5:31 AM Mark Thomas  wrote:

> The proposed Apache Tomcat 10.1.0-M6 release is now available for
> voting.
>
> Applications that run on Tomcat 9 and earlier will not run on Tomcat 10
> without changes. Java EE applications designed for Tomcat 9 and earlier
> may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat
> will automatically convert them to Jakarta EE and copy them to the
> webapps directory.
>
> The notable changes compared to 10.1.0-M5 are:
>
> - Servlet API updates for Servlet 6 including removal of all deprecated
>code, updated schemas and a new API for connection and request IDs.
>
> - EL API updates for EL 5.0 including deprecation of the use of
>FeatureDescriptor, improvements to BeanELResolver and the addition of
>MethodReference
>
> - Further robustness improvements to HTTP/2 flow control window
>management
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat-10.1.x/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.0-M6/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1334
>
> The tag is:
> https://github.com/apache/tomcat/tree/10.1.0-M6
> 51d1031c36c0f2b3ee1e0d14b56228a559144153
>
>
> The proposed 10.1.0-M6 release is:
> [ ] Broken - do not release
> [X] Alpha - go ahead and release as 10.1.0-M6 (alpha)
>

Unit tests passed on Ubuntu 20.04 with Java 11

Igal




>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 8.5.71

2021-09-10 Thread Igal Sapir
On Thu, Sep 9, 2021 at 12:30 PM Christopher Schultz 
wrote:

> The proposed Apache Tomcat 8.5.71 release is now available for voting.
>
> The notable changes compared to 8.5.70 are:
>
> - Add a UserDatabase implementation as a superset of the DataSourceRealm
> functionality.
>
> - Update the internal fork of Apache Commons DBCP to 2.9.0, Apache
> Commons Pool to 2.9.1, Apache Commons FileUpload to 2.0, and
> Apache Commons Codec to 1.16.
>
> - Update the packaged version of the Tomcat Native Library to 1.2.31 to
> pick up Windows binaries built with OpenSSL 1.1.1l.
>
> - Correct parsing of Content-Range headers
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat-8.0.x/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.71/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1333
> The tag is:
>
>
> https://github.com/apache/tomcat/commit/9e60ee33816f3f28af81535c108e6bd23f2ef970
>
> https://github.com/apache/tomcat/tree/8.5.71
> 9e60ee33816f3f28af81535c108e6bd23f2ef970
>
> The proposed 8.5.71 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.5.71 (stable)
>

+1.  Tested on Ubuntu 20.04 with Java 11.

Igal


>
> Remy
>

Who are you? ;)


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 9.0.53

2021-09-09 Thread Igal Sapir
On Mon, Sep 6, 2021 at 12:22 PM Rémy Maucherat  wrote:

> The proposed Apache Tomcat 9.0.53 release is now available for voting.
>
> The notable changes compared to 9.0.53 are:
>
> - Add a UserDatabase implementation as a superset of the DataSourceRealm
>functionality.
>
> - Update the internal fork of Apache Commons DBCP to 2.9.0 and Apache
>Commons Pool to 2.11.1
>
> - Update the packaged version of the Tomcat Native Library to 1.2.31 to
>pick up Windows binaries built with OpenSSL 1.1.1l.
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat-9.0.x/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.53/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1332
> The tag is:
> https://github.com/apache/tomcat/tree/9.0.53
> 966ec5401970b9d4b41b53f5fff9f65966d887dd
>
> The proposed 9.0.53 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 9.0.53 (stable)
>

+1 tested on Ubuntu 20.04 with Zulu 11 JVM

Igal



>
> Remy
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 10.0.11

2021-09-08 Thread Igal Sapir
On Mon, Sep 6, 2021 at 11:30 AM Mark Thomas  wrote:

> The proposed Apache Tomcat 10.0.11 release is now available for
> voting.
>
> Apache Tomcat 10.x implements Jakarta EE 9 and, as such, the primary
> package for all the specification APIs has changed from javax.* to
> jakarta.*
>
> Applications that run on Tomcat 9 will not run on Tomcat 10 without
> changes. Java EE applications designed for Tomcat 9 and earlier may be
> placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat will
> automatically convert them to Jakarta EE and copy them to the webapps
> directory
>
> The notable changes compared to 10.0.10 are:
>
> - Add a UserDatabase implementation as a superset of the DataSourceRealm
>functionality.
>
> - Update the internal fork of Apache Commons DBCP to 2.9.0 and Apache
>Commons Pool to 2.11.1
>
> - Update the packaged version of the Tomcat Native Library to 1.2.31 to
>pick up Windows binaries built with OpenSSL 1.1.1l.
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat-10.0.x/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.0.11/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1331
>
> The tag is:
> https://github.com/apache/tomcat/tree/10.0.11
> c191bad5a0cd7f1606f573dd960d0b396aeb288d
>
> The proposed 10.0.11 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 10.0.11 (stable)
>

+1

Igal


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 10.1.0-M5

2021-09-08 Thread Igal Sapir
On Mon, Sep 6, 2021 at 7:43 AM Mark Thomas  wrote:

> The proposed Apache Tomcat 10.1.0-M5 release is now available for
> voting.
>
> Applications that run on Tomcat 9 and earlier will not run on Tomcat 10
> without changes. Java EE applications designed for Tomcat 9 and earlier
> may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat
> will automatically convert them to Jakarta EE and copy them to the
> webapps directory.
>
> The notable changes compared to 10.1.0-M4 are:
>
> - Remove the deprecated APR/Native connector which includes the HTTP APR
>and the AJP APR connector. Also remove the Java interfaces to the
>APR/Native library that are not used by the OpenSSL integration for
>the NIO and NIO2 connectors.
>
> - Add a UserDatabase implementation as a superset of the DataSourceRealm
>functionality.
>
> - Update the internal fork of Apache Commons DBCP to 2.9.0 and Apache
>Commons Pool to 2.11.1
>
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat-10.1.x/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.0-M4/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1330
>
> The tag is:
> https://github.com/apache/tomcat/tree/10.1.0-M5
> 2a10c8d9110d7b1c7f526f3352648c6b19ba2c52
>
>
> The proposed 10.1.0-M5 release is:
> [ ] Broken - do not release
> [X] Alpha - go ahead and release as 10.1.0-M5 (alpha)
>

 +1

Igal



> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat Native 1.2.31

2021-08-31 Thread Igal Sapir
On Thu, Aug 26, 2021 at 9:04 AM Mark Thomas  wrote:

> Version 1.2.31 includes the following changes compared to 1.2.30
>
> - Build an issue when building with OpenSSL 3.0.0
>
> - Clean up remaining reference to pkg-config
>
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
>
> The Apache Tomcat Native 1.2.31 release is
>   [X] Stable, go ahead and release
>   [ ] Broken because of ...
>

+1

Igal



> Thanks,
>
> Mark
>
>
> [1]
>
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/1.2.31
> [2]
>
> https://gitbox.apache.org/repos/asf?p=tomcat-native.git;a=commit;h=7e16cd817767bfc1be9fd854728d97641928702f
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 8.5.70

2021-08-09 Thread Igal Sapir
On Mon, Aug 9, 2021 at 1:06 PM Mark Thomas  wrote:

> The proposed Apache Tomcat 8.5.70 release is now available for voting.
>
> 
>
> The tag is:
> https://github.com/apache/tomcat/tree/8.5.70
> 3d2e8b1964d4dff3c0656618edc0b09d0d5634b8
>
> The proposed 8.5.70 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.5.70
>

+1

Tested on Ubuntu 20.04 with Java 11

Igal



>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 10.1.0-M3

2021-08-02 Thread Igal Sapir
On Mon, Aug 2, 2021 at 3:34 PM Mark Thomas  wrote:

> Hi Rainer,
>
> I see the same thing.
>
> My Java 11 cleanup is the obvious likely candidate for the root cause. I
> can dig into this some more tomorrow. Looks like we'll need an M4 release.
>

Confirmed.  WebSocket echo example works in 10.0.10 but fails in 10.1.0-M3.

Great catch Rainer!

Igal


>
> Mark
>
>
> On 03/08/2021 00:12, Rainer Jung wrote:
> > Hi there,
> >
> > is anyone able to run he websockets examples? For instance the "echo"
> > example? I immediately get "Info: WebSocket connection closed, Code:
> > 1006" and a 404 response. This happened on a self-compiled installation
> > on Linux but also on an extracted binary Windows 64 Bits download from
> > the voting site.
> >
> > Could it be, that the registration of the endpoints is somehow broken?
> >
> > The example works in 10.0.10 using the same Java 11 installation that I
> > used to test 10.1.0.
> >
> > Thanks and regards,
> >
> > Rainer
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > For additional commands, e-mail: dev-h...@tomcat.apache.org
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 10.0.10

2021-07-30 Thread Igal Sapir
On Fri, Jul 30, 2021 at 3:18 AM Mark Thomas  wrote:

>
> The proposed 10.0.10 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 10.0.10 (stable)
>

+1.  Tested on Ubuntu with Java 11.

Igal


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 10.1.0-M3

2021-07-30 Thread Igal Sapir
On Thu, Jul 29, 2021 at 7:37 AM Mark Thomas  wrote:

>
> The proposed 10.1.0-M3 release is:
> [ ] Broken - do not release
> [X] Alpha - go ahead and release as 10.1.0-M3 (alpha)
>

+1.  Tested on Ubuntu with Java 11.

Igal


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 10.0.9

2021-07-29 Thread Igal Sapir
On Thu, Jul 29, 2021 at 12:07 PM Mark Thomas  wrote:

> The proposed Apache Tomcat 10.0.9 release is now available for
> voting.
>
> Apache Tomcat 10.x implements Jakarta EE 9 and, as such, the primary
> package for all the specification APIs has changed from javax.* to
> jakarta.*
>
> 
>
> The tag is:
> https://github.com/apache/tomcat/tree/10.0.9
> 5a10f281b5f09e1f73572f753f34ce7a1248763d
>
> The proposed 10.0.9 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 10.0.9 (stable)
>

+1

Unit tests passed on Ubuntu 20.04 with Java 11

Igal


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 8.5.69

2021-07-05 Thread Igal Sapir
Chris,

On Mon, Jul 5, 2021 at 8:16 AM Christopher Schultz <
ch...@christopherschultz.net> wrote:

> All,
>
> On 6/29/21 17:03, Christopher Schultz wrote:
> > The proposed Apache Tomcat 8.5.69 release is now available for voting.
> >
> > The notable changes compared to the 8.5.68 release are:
> >
> > - Re-work the HTTP/2 overhead protection to reduce the likelihood of
> >false positives. Note that the default overheadCountFactor has changed
> >from 1 to 10 and that the useful range is now 0 to ~20.
> >
> > - Fix regressions in JSP compilation in the previous release.
> >
> > - Improve HTTP header parsing to ignore empty elements in 1#token
> >values, as per RFC 7230 section 7.
> >
> > Along with lots of other bug fixes and improvements.
> >
> > For full details, see the changelog:
> > https://ci.apache.org/projects/tomcat/tomcat-8.5.x/docs/changelog.html
> >
> > It can be obtained from:
> > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.69/
> >
> > The Maven staging repo is:
> > https://repository.apache.org/content/repositories/orgapachetomcat-1322/
> >
> > The tag is:
> > https://github.com/apache/tomcat/tree/8.5.69
> > a17eaf7de9aa166dea03a5bc3bb4f1915176a3c8
> >
> > The proposed 8.5.69 release is:
> > [ ] Broken - do not release
> > [ ] Stable - go ahead and release as 8.5.69
>
> +0 for release
>
> Works with a vanilla servlet-style application in development environment.
>
> I'm a little concerned about these two tests which failed:
>
> * org.apache.catalina.filters.TestExpiresFilter.NIO.txt
> * org.apache.coyote.http2.TestStreamProcessor.NIO.txt
>
> However, none of the other voters reported any unit-test errors, so I
> will vote +0 due to the importance of getting the h2 and JSP fixes out.
>

Right, all of the unit tests passed for me and my exclusion list does not
cover those but I have "Relax Timing" on which may or may not play a role
with those tests (I didn't check).  These are the settings I have for unit
tests:

test.exclude=org/apache/catalina/tribes/group/Test*,org/apache/catalina/tribes/group/interceptors/Test*
test.relaxTiming=true

HTH,

Igal



>
> Details:
>
> * Environment
> *  Java (build): openjdk version "1.8.0_292" OpenJDK Runtime
> Environment (build 1.8.0_292-8u292-b10-0+deb9u1-b10) OpenJDK 64-Bit
> Server VM (build 25.292-b10, mixed mode)
> *  Java (test): openjdk version "1.8.0_292" OpenJDK Runtime
> Environment (build 1.8.0_292-8u292-b10-0+deb9u1-b10) OpenJDK 64-Bit
> Server VM (build 25.292-b10, mixed mode)
> *  OS:   Linux 4.19.0-16-amd64 x86_64
> *  cc:   cc (Debian 8.3.0-6) 8.3.0
> *  make: GNU Make 4.2.1
> *  OpenSSL:  OpenSSL 1.1.1 11 Sep 2018
> *  APR:  1.6.5
> *
> * Valid SHA-512 signature for apache-tomcat-8.5.69.zip
> * Valid GPG signature for apache-tomcat-8.5.69.zip
> * Valid SHA-512 signature for apache-tomcat-8.5.69.tar.gz
> * Valid GPG signature for apache-tomcat-8.5.69.tar.gz
> * Valid SHA-512 signature for apache-tomcat-8.5.69.exe
> * Valid GPG signature for apache-tomcat-8.5.69.exe
> * Valid Windows Digital Signature for apache-tomcat-8.5.69.exe
> * Valid SHA512 signature for apache-tomcat-8.5.69-src.zip
> * Valid GPG signature for apache-tomcat-8.5.69-src.zip
> * Valid SHA512 signature for apache-tomcat-8.5.69-src.tar.gz
> * Valid GPG signature for apache-tomcat-8.5.69-src.tar.gz
> *
> * Binary Zip and tarball: Same
> * Source Zip and tarball: Same
> *
> * Building dependencies returned: 0
> * tcnative builds cleanly
> * Tomcat builds cleanly
> * Junit Tests: FAILED
> *
> * Tests that failed:
> * org.apache.catalina.filters.TestExpiresFilter.APR.txt
> * org.apache.catalina.filters.TestExpiresFilter.NIO.txt
> * org.apache.catalina.filters.TestExpiresFilter.NIO2.txt
> * org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.APR.txt
> * org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.NIO.txt
> * org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.NIO2.txt
> *
> org.apache.catalina.tribes.group.TestGroupChannelSenderConnections.APR.txt
> *
> org.apache.catalina.tribes.group.TestGroupChannelSenderConnections.NIO.txt
> *
> org.apache.catalina.tribes.group.TestGroupChannelSenderConnections.NIO2.txt
> * org.apache.catalina.tribes.group.TestGroupChannelStartStop.APR.txt
> * org.apache.catalina.tribes.group.TestGroupChannelStartStop.NIO.txt
> * org.apache.catalina.tribes.group.TestGroupChannelStartStop.NIO2.txt
> *
>
> org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.APR.txt
> *
>
> org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.NIO.txt
> *
>
> org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.NIO2.txt
> *
> org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.APR.txt
> *
> org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.NIO.txt
> *
> org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.NIO2.txt
> *
>
> 

Re: [VOTE] Release Apache Tomcat 9.0.50

2021-06-30 Thread Igal Sapir
On Mon, Jun 28, 2021 at 1:57 AM Rémy Maucherat  wrote:

> The proposed Apache Tomcat 9.0.50 release is now available for voting.
>
> 
>
> The proposed 9.0.50 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 9.0.50 (stable)
>

Unit tests passed on Ubuntu 20.04 with Java 11

Igal



>
> Remy
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 8.5.69

2021-06-30 Thread Igal Sapir
On Tue, Jun 29, 2021 at 2:03 PM Christopher Schultz <
ch...@christopherschultz.net> wrote:

> The proposed Apache Tomcat 8.5.69 release is now available for voting.
>
> 
>
> The proposed 8.5.69 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.5.69
>

Unit tests passed on Ubuntu 20.04 with Java 11

Igal


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 10.0.8

2021-06-26 Thread Igal Sapir
On Fri, Jun 25, 2021 at 4:27 PM Mark Thomas  wrote:

> The proposed Apache Tomcat 10.0.8 release is now available for
> voting.
>
> 
>
> The tag is:
> https://github.com/apache/tomcat/tree/10.0.8
> 64520a63e23437b4e92db42bfc70a20d1f9e79c4
>
> The proposed 10.0.8 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 10.0.8 (stable)
>

Unit tests passed on Ubuntu 20.04 with Java 11

Igal



>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 10.1.0-M2

2021-06-26 Thread Igal Sapir
On Fri, Jun 25, 2021 at 3:06 PM Mark Thomas  wrote:

> The proposed Apache Tomcat 10.1.0-M2 release is now available for
> voting.
> 
> The tag is:
> https://github.com/apache/tomcat/tree/10.1.0-M2
> 0e59fedb28df646930c5aff945159b64d7a52260
>
> The proposed 10.1.0-M2 release is:
> [ ] Broken - do not release
> [X] Alpha - go ahead and release as 10.1.0-M2 (alpha)
>

Unit tests passed on Ubuntu 20.04 with Java 11

Igal


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 8.5.68

2021-06-14 Thread Igal Sapir
Chris,

On Mon, Jun 14, 2021 at 7:32 AM Christopher Schultz <
ch...@christopherschultz.net> wrote:

> 
> Tests on Windows 10 passed except for a timing issue which wasn't
> reproducible on a second run.
>
> 
> * Junit Tests: FAILED
> *
> * Tests that failed:
> * org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.APR.txt
> * org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.NIO.txt
> * org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.NIO2.txt
> *
> org.apache.catalina.tribes.group.TestGroupChannelSenderConnections.APR.txt
> *
> org.apache.catalina.tribes.group.TestGroupChannelSenderConnections.NIO.txt
> *
> org.apache.catalina.tribes.group.TestGroupChannelSenderConnections.NIO2.txt
> * org.apache.catalina.tribes.group.TestGroupChannelStartStop.APR.txt
> * org.apache.catalina.tribes.group.TestGroupChannelStartStop.NIO.txt
> * org.apache.catalina.tribes.group.TestGroupChannelStartStop.NIO2.txt
> *
>
> org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.APR.txt
> *
>
> org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.NIO.txt
> *
>
> org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.NIO2.txt
> *
> org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.APR.txt
> *
> org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.NIO.txt
> *
> org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.NIO2.txt
> *
>
> org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.APR.txt
> *
>
> org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.NIO.txt
> *
>
> org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.NIO2.txt
> * org.apache.tomcat.util.net.openssl.ciphers.TestCipher.APR.txt
> * org.apache.tomcat.util.net.openssl.ciphers.TestCipher.NIO.txt
> * org.apache.tomcat.util.net.openssl.ciphers.TestCipher.NIO2.txt
> *
> org.apache.tomcat.util.net
> .openssl.ciphers.TestOpenSSLCipherConfigurationParser.APR.txt
> *
> org.apache.tomcat.util.net
> .openssl.ciphers.TestOpenSSLCipherConfigurationParser.NIO.txt
> *
> org.apache.tomcat.util.net
> .openssl.ciphers.TestOpenSSLCipherConfigurationParser.NIO2.txt
>

I've been having failed tests for a while now with the timing of the
tribes.** packages on Ubuntu laptop (not a VM).  At first I was concerned
but I believe that it's a non-issue.  Recently I added the following to
build.properties to skip those tests:

test.exclude=org/apache/catalina/tribes/group/Test*,org/apache/catalina/tribes/group/interceptors/Test*

Best,

Igal



>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 8.5.68

2021-06-11 Thread Igal Sapir
On Fri, Jun 11, 2021 at 7:01 AM Christopher Schultz <
ch...@christopherschultz.net> wrote:

> The proposed Apache Tomcat 8.5.68 release is now available for voting.
>
> 
>
> The proposed 8.5.68 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.5.68
>

Igal



>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 9.0.48

2021-06-10 Thread Igal Sapir
On Thu, Jun 10, 2021 at 3:20 AM Rémy Maucherat  wrote:

> The proposed Apache Tomcat 9.0.48 release is now available for voting.
>
> 
>
> The proposed 9.0.48 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 9.0.48 (stable)
>

+1

Tested on Ubuntu 20.04 and Java 11

Igal



>
> Rémy
>


Re: [VOTE] Release Apache Tomcat 8.5.67

2021-06-10 Thread Igal Sapir
On Thu, Jun 10, 2021 at 3:36 PM Christopher Schultz <
ch...@christopherschultz.net> wrote:

> The proposed Apache Tomcat 8.5.67 release is now available for voting.
>
> 
>
> The proposed 8.5.67 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.5.67
>

+1

Tested on Ubuntu 20.04 with Java 11

Igal



> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat Native 1.2.30

2021-06-01 Thread Igal Sapir
On Tue, Jun 1, 2021 at 2:53 AM Mark Thomas  wrote:

> Resending with correct subject line...
>
> Version 1.2.30 includes the following changes compared to 1.2.28
>
> - Fix an issue where some Windows systems in some configurations would
>only listen on IPv6 addresses on dual stack systems even though
>configured to listen on both IPv6 and IPv4 addresses.
>
> - Complete the fix for BZ 65181
>
> - Correct constants used for Windows versions. Expand versions
>supported.
>
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
>
> The Apache Tomcat Native 1.2.30 release is
>   [X] Stable, go ahead and release
>   [ ] Broken because of ...
>

+1

Igal



>
> Thanks,
>
> Mark
>
>
> [1]
>
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/1.2.30
> [2]
>
> https://gitbox.apache.org/repos/asf?p=tomcat-native.git;a=commit;h=8b1baaa1af07c07a9f44f9adb31b7dbdabd6ff39
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat Native 1.2.29

2021-05-29 Thread Igal Sapir
Mark,

On Sat, May 29, 2021 at 4:30 AM Mark Thomas  wrote:

> On 28/05/2021 23:16, Igal Sapir wrote:
> > On Fri, May 28, 2021 at 6:40 AM Mark Thomas  wrote:
> >
> >> 
> >>
> >> The Apache Tomcat Native 1.2.29 release is
> >>[X] Stable, go ahead and release
> >>[ ] Broken because of ...
> >>
> >
> > +1
>
> Thanks for voting but unfortunately I think that BZ 65181 means I am
> going to have to cancel this release, (re)fix BZ  65181 and the re-tag.
>

Good catch!  FWIW building from source and running Tomcat unit tests with
APR passed so if possible it'd be great to have a unit test for BZ 65181.

Best,

Igal



>
> Sorry for the inconvenience.
>
> Mark
>
>
> >
> > Igal
> >
> >
> >>
> >> Thanks,
> >>
> >> Mark
> >>
> >>
> >> [1]
> >>
> >>
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/1.2.29
> >> [2]
> >>
> >>
> https://gitbox.apache.org/repos/asf?p=tomcat-native.git;a=commit;h=c7166f321fe275676dcc2990fe9232c1fcc67f5f
> >>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> >> For additional commands, e-mail: dev-h...@tomcat.apache.org
> >>
> >>
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat Native 1.2.29

2021-05-28 Thread Igal Sapir
On Fri, May 28, 2021 at 6:40 AM Mark Thomas  wrote:

> 
>
> The Apache Tomcat Native 1.2.29 release is
>   [X] Stable, go ahead and release
>   [ ] Broken because of ...
>

+1

Igal


>
> Thanks,
>
> Mark
>
>
> [1]
>
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/1.2.29
> [2]
>
> https://gitbox.apache.org/repos/asf?p=tomcat-native.git;a=commit;h=c7166f321fe275676dcc2990fe9232c1fcc67f5f
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: Disabling Some Test Cases by Pattern

2021-05-12 Thread Igal Sapir
Martin,

On Tue, May 11, 2021 at 12:18 AM Martin Grigorov 
wrote:

> Hi Igal,
>
> On Mon, May 10, 2021 at 4:28 AM Igal Sapir  wrote:
>
> > I am trying to disable some test cases that constantly fail on my
> machine.
> > I have added the following to build.properties:
> >
> >
> >
> test.exclude=org.apache.catalina.tribes.group.Test**,org.apache.catalina.tribes.group.interceptors.Test**
> >
> > But I still get the following failures:
> >
> >[concat] Testsuites with failed tests:
> >[concat]
> >
> >
> TEST-org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.NIO2.txt
> >[concat]
> >
> >
> TEST-org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.NIO2.txt
> >[concat]
> >
> >
> TEST-org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.NIO2.txt
> >[concat]
> >
> >
> TEST-org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.NIO2.txt
> >
> > I expect the pattern
> [org.apache.catalina.tribes.group.interceptors.Test**]
> > to exclude the last 3 for example, but that doesn't happen.
> >
> > What am I doing wrong?
> >
>
> Looking at
>
> https://github.com/apache/tomcat/blob/9747a3a6334369deb9b5bef1b17b1fe0ce774cdf/build.xml#L2024-L2039
> I think you should use '/' instead of '.',
> i.e.
>
> test.exclude=org/apache/catalina/tribes/group/Test*,org/apache/catalina/tribes/group/interceptors/Test*
>

Brilliant!  That worked.

Thank you,

Igal



>
>
> >
> > Thanks,
> >
> > Igal
> >
>


Re: [VOTE] Release Apache Tomcat 8.5.66

2021-05-09 Thread Igal Sapir
On Sat, May 8, 2021 at 4:12 PM Mark Thomas  wrote:

> The proposed Apache Tomcat 8.5.66 release is now available for voting.
>
> 
>
> The proposed 8.5.66 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.5.66
>

+1

Igal



>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 9.0.46

2021-05-09 Thread Igal Sapir
On Sat, May 8, 2021 at 11:15 AM Mark Thomas  wrote:

> The proposed Apache Tomcat 9.0.46 release is now available for voting.
>
> 
>
> The proposed 9.0.46 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 9.0.46
>

+1

Igal



>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 10.0.6

2021-05-09 Thread Igal Sapir
On Sat, May 8, 2021 at 9:18 AM Mark Thomas  wrote:

> The proposed Apache Tomcat 10.0.6 release is now available for
> voting.
>
> 
>
> The proposed 10.0.6 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 10.0.6 (stable)
>

+1

Igal



>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Disabling Some Test Cases by Pattern

2021-05-09 Thread Igal Sapir
I am trying to disable some test cases that constantly fail on my machine.
I have added the following to build.properties:

test.exclude=org.apache.catalina.tribes.group.Test**,org.apache.catalina.tribes.group.interceptors.Test**

But I still get the following failures:

   [concat] Testsuites with failed tests:
   [concat]
TEST-org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.NIO2.txt
   [concat]
TEST-org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.NIO2.txt
   [concat]
TEST-org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.NIO2.txt
   [concat]
TEST-org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.NIO2.txt

I expect the pattern [org.apache.catalina.tribes.group.interceptors.Test**]
to exclude the last 3 for example, but that doesn't happen.

What am I doing wrong?

Thanks,

Igal


Re: [VOTE] Release Apache Tomcat 7.0.109

2021-04-23 Thread Igal Sapir
On Thu, Apr 22, 2021 at 12:13 PM Violeta Georgieva 
wrote:

> The proposed Apache Tomcat 7.0.109 release is now available for voting.
> Please note that this is the last Tomcat 7 release.
>
> 
>
> The proposed 7.0.109 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 7.0.109 Stable
>

+1

Igal


>
> Regards,
> Violeta
>


Re: [VOTE] Release Apache Tomcat Native 1.2.28

2021-04-01 Thread Igal Sapir
On Thu, Apr 1, 2021 at 6:57 AM Mark Thomas  wrote:

> Version 1.2.28 includes the following changes compared to 1.2.27
>
> The Apache Tomcat Native 1.2.28 release is
>   [X] Stable, go ahead and release
>   [ ] Broken because of ...
>

+1

Built and ran unit tests with Tomcat 9 and APR

Igal


>
> Thanks,
>
> Mark
>
>
> [1]
>
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/1.2.28
> [2]
>
> https://gitbox.apache.org/repos/asf?p=tomcat-native.git;a=commit;h=5566385ab63361d8d707613508d803964a15a1f8
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 10.0.5

2021-03-30 Thread Igal Sapir
On Tue, Mar 30, 2021 at 1:46 AM Mark Thomas  wrote:

> The proposed Apache Tomcat 10.0.5 release is now available for
> voting.
>
> 
>
> The proposed 10.0.5 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 10.0.5 (stable)
>

+1

Igal


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 9.0.45

2021-03-30 Thread Igal Sapir
On Tue, Mar 30, 2021 at 3:52 AM Mark Thomas  wrote:

> The proposed Apache Tomcat 9.0.45 release is now available for voting.
>
> 
>
> The proposed 9.0.45 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 9.0.45
>

+1

Igal


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 8.5.65

2021-03-30 Thread Igal Sapir
On Tue, Mar 30, 2021 at 6:13 AM Mark Thomas  wrote:

> The proposed Apache Tomcat 8.5.65 release is now available for voting.
>
> 
>
> The proposed 8.5.65 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.5.65
>

+1

Igal



>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat Native 1.2.27

2021-03-27 Thread Igal Sapir
On Fri, Mar 26, 2021 at 4:10 AM Mark Thomas  wrote:

> Version 1.2.27 includes the following changes compared to 1.2.26
>
> - Windows binaries built using 1.1.1k
>
> - BZ 65181 - Improved support for OpenSSL engines with proprietary key
>formats
>
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
>
> The Apache Tomcat Native 1.2.27 release is
>   [X] Stable, go ahead and release
>   [ ] Broken because of ...
>

+1

Igal


>
> Thanks,
>
> Mark
>
>
> [1]
>
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/1.2.27
> [2]
>
> https://gitbox.apache.org/repos/asf?p=tomcat-native.git;a=commit;h=c7c22b9c7f96869aa8f04e6692518aa5323a467b
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 8.5.63

2021-01-30 Thread Igal Sapir
On Fri, Jan 29, 2021 at 3:44 AM Mark Thomas  wrote:

> The proposed Apache Tomcat 8.5.63 release is now available for voting.
>
> The notable changes compared to the 8.5.61 release are:
>
> - Add a new StringInterpreter interface that allows applications to
>   provide customised string attribute value to type conversion within
>   JSPs. This allows applications to provide a conversion
>   implementation that is optimised for the application.
>
> - Add peerAddress to coyote request, which contains the IP address of
>   the direct connection peer. If a reverse proxy sits in front of
>   Tomcat and the protocol used is AJP or HTTP in combination with the
>   RemoteIp(Valve|Filter), the peer address might differ from the
>   remoteAddress. The latter then contains the address of the client in
>   front of the reverse proxy, not the address of the proxy itself.
>

I ran the unit tests twice on Ubuntu 20.04 with Java 11.0.9.1 and got
failures on both runs in the following tests

   [concat] Testsuites with failed tests:
   [concat]
TEST-org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.*.txt
   [concat]
TEST-org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.*.txt
   [concat]
TEST-org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.*.txt
   [concat]
TEST-org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.*.txt

Are they related to recent changes?


>
> - Escape elements in the access log that need to be escaped for the
>   access log to be parsed unambiguously.
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat85/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.63/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1298/
>
> The tag is:
> https://github.com/apache/tomcat/tree/8.5.63
> eb8d36c30857866536e8c931731c9f86980b00a6
>
> The proposed 8.5.63 release is:
> [ ] Broken - do not release
> [ ] Stable - go ahead and release as 8.5.63
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Apache Tomcat migration tool for Jakarta EE

2020-12-12 Thread Igal Sapir
On Thu, Dec 10, 2020 at 11:45 PM Mark Thomas  wrote:

> On 11/12/2020 06:58, Martin Grigorov wrote:
> > On Thu, Dec 10, 2020 at 11:50 PM Igal Sapir  wrote:
> >
> >> On Thu, Dec 10, 2020 at 5:58 AM Christopher Schultz <
> >> ch...@christopherschultz.net> wrote:
> >>
> >>> Mark,
> >>>
> >>> On 12/10/20 06:39, Mark Thomas wrote:
> >>>> The proposed Apache Tomcat migration tool for Jakarta EE 0.1.0 is now
> >>>> available for voting.
> >>>>
> >>>> This is (potentially) the first release.
> >>>>
> >>>> It can be obtained from:
> >>>>
> >>>
> >>
> https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v0.1.0/
> >>>>
> >>>> The Maven staging repo is:
> >>>>
> >>
> https://repository.apache.org/content/repositories/orgapachetomcat-1291/
> >>>>
> >>>> The tag is:
> >>>> https://github.com/apache/tomcat-jakartaee-migration/tree/0.1.0
> >>>> cbada3204bf9c43ca0cf481cd88c7521690b30a0
> >>>>
> >>>> The proposed 0.1.0 release is:
> >>>>
> >>>> [ ] -1: Broken. Do not release because...
> >>>> [ ] +1: Acceptable. Go ahead and release.
> >>>
> >>> Do we even need (a) a release and (b) a VOTE?
> >>>
> >>> I once heard Ross say that there was an ASP project (Subversion?) that
> >>> never had votes; they only had releases. That seemed to cut-down on the
> >>> red-tape required to get things out into the world. I can't find a
> >>> reference for that, now.
> >>>
> >>> Since this is a developer tool and not a runtime library or anything
> >>> like that, maybe we can just say "YMMV, this is available any time you
> >>> want it"?
> >>>
> >>> That said, I have no objections whatsoever with holding a vote. I am an
> >>> unsigned "0" on the vote itself; I have not even downloaded the source
> >>> let alone attempted to migrate a project using it.
> >>>
> >>
> >> I'm a +0 on this one.  Like Chris, I also did not even download nor
> tested
> >> that tool.
> >>
> >> Did we use that tool to migrate the Tomcat examples?  Were they all
> >> migrated successfully?
> >>
> >
> > No. The examples were migrated manually, i.e. their source code was
> > migrated.
> > The tool migrates binary files (.war,.jar, .class). It is useful when
> your
> > application depends on third party libraries which still use javax.**
>
> Martin is correct, the examples were migrated using a package rename in
> the IDE.
>
> The JSTL JARs (used by the examples webapp) were migrated with this tool.
>

Thank you both for clarifying.  My question just shows why at this point I
should remain a +0 on this one.

Igal



>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat Native 1.2.26

2020-12-10 Thread Igal Sapir
On Thu, Dec 10, 2020 at 1:10 PM Mark Thomas  wrote:

> Version 1.2.26 includes the following changes compared to 1.2.25
>
> - Windows binaries built using 1.1.1i
>
> - BZ 64942 - expose support for unix domain sockets
>
> Various other fixes and improvements. See the changelog for details.
>
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
>
> The Apache Tomcat Native 1.2.26 release is
>  [X] Stable, go ahead and release
>

Tested with Tomcat 9.0.41 and Java 13.0.4 on Ubuntu 20.04

Best,

Igal



>  [ ] Broken because of ...
>
> Thanks,
>
> Mark
>
>
> [1]
>
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/1.2.26
> [2]
>
> https://gitbox.apache.org/repos/asf?p=tomcat-native.git;a=commit;h=64fafd13032afb34690e3c3343b6f614f04b2660
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Apache Tomcat migration tool for Jakarta EE

2020-12-10 Thread Igal Sapir
On Thu, Dec 10, 2020 at 5:58 AM Christopher Schultz <
ch...@christopherschultz.net> wrote:

> Mark,
>
> On 12/10/20 06:39, Mark Thomas wrote:
> > The proposed Apache Tomcat migration tool for Jakarta EE 0.1.0 is now
> > available for voting.
> >
> > This is (potentially) the first release.
> >
> > It can be obtained from:
> >
> https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v0.1.0/
> >
> > The Maven staging repo is:
> > https://repository.apache.org/content/repositories/orgapachetomcat-1291/
> >
> > The tag is:
> > https://github.com/apache/tomcat-jakartaee-migration/tree/0.1.0
> > cbada3204bf9c43ca0cf481cd88c7521690b30a0
> >
> > The proposed 0.1.0 release is:
> >
> > [ ] -1: Broken. Do not release because...
> > [ ] +1: Acceptable. Go ahead and release.
>
> Do we even need (a) a release and (b) a VOTE?
>
> I once heard Ross say that there was an ASP project (Subversion?) that
> never had votes; they only had releases. That seemed to cut-down on the
> red-tape required to get things out into the world. I can't find a
> reference for that, now.
>
> Since this is a developer tool and not a runtime library or anything
> like that, maybe we can just say "YMMV, this is available any time you
> want it"?
>
> That said, I have no objections whatsoever with holding a vote. I am an
> unsigned "0" on the vote itself; I have not even downloaded the source
> let alone attempted to migrate a project using it.
>

I'm a +0 on this one.  Like Chris, I also did not even download nor tested
that tool.

Did we use that tool to migrate the Tomcat examples?  Were they all
migrated successfully?

Igal



>
> -chris
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [tomcat] 01/02: Replace Collections.sort() with List.sort()

2020-12-03 Thread Igal Sapir
On Thu, Dec 3, 2020 at 2:48 PM Martin Grigorov  wrote:

> Hi,
>
> Shall we backport these commits to 9.x and 8.5?
> It will make it easier to backport future changes in these classes.
>

+1

No need to diverge the branches unnecessarily.

Igal



>
> Martin
>
> On Fri, Dec 4, 2020, 00:06 Emmanuel Bourg  wrote:
>
> > Hi Christopher,
> >
> > Le 03/12/2020 à 21:49, Christopher Schultz a écrit :
> >
> > > I'm curious as to why this change is warranted. I'm not suggesting it's
> > > not... just wondering what the benefit is? Avoiding a pass-through
> > > method call?
> >
> > It's the shorter idiom to sort lists with Java 8+, it just improves the
> > readability. I don't think the method call avoided has any impact, the
> > actual sorting dominates the time spent anyway.
> >
> > Emmanuel Bourg
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > For additional commands, e-mail: dev-h...@tomcat.apache.org
> >
> >
>


Re: [VOTE] Release Apache Tomcat 8.5.61

2020-12-03 Thread Igal Sapir
On Thu, Dec 3, 2020 at 6:49 AM Mark Thomas  wrote:

> The proposed Apache Tomcat 8.5.61 release is now available for voting.
>
> The notable changes compared to the 8.5.60 release are:
>
> - Align the behaviour of ServletContext.getRealPath(String path) with
>   the recent clarification from the Servlet specification project. If
>   the path parameter does not start with / then Tomcat processes the
>   call as if / is appended to the beginning of the provided path.
>
> - Fix a potential file descriptor leak when WebSocket connections are
>   attempted and fail. Patch provided by Maurizio Adami.
>
> - Ensure that the LoadBalancerDrainingValve uses the correct setting
>   for the secure attribute for any session cookies it creates. Based on
>   a pull request by Andreas Kurth.
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat85/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.61/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1290/
>
> The tag is:
> https://github.com/apache/tomcat/tree/8.5.61
> 77d330abea52e4aeb039ca7eb8a766e0e1c56a71
>
> The proposed 8.5.61 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.5.61
>

Tested on Ubuntu 20.04 with Java 13.0.4 and TC-Native 1.2.25

Best,

Igal



>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 9.0.41

2020-12-03 Thread Igal Sapir
On Thu, Dec 3, 2020 at 5:12 AM Mark Thomas  wrote:

> The proposed Apache Tomcat 9.0.41 release is now available for voting.
>
> The notable changes compared to the 9.0.40 release are:
>
> - Align the behaviour of ServletContext.getRealPath(String path) with
>   the recent clarification from the Servlet specification project. If
>   the path parameter does not start with / then Tomcat processes the
>   call as if / is appended to the beginning of the provided path.
>
> - Fix a potential file descriptor leak when WebSocket connections are
>   attempted and fail. Patch provided by Maurizio Adami.
>
> -  Ensure that the LoadBalancerDrainingValve uses the correct setting
>for the secure attribute for any session cookies it creates. Based on
>a pull request by Andreas Kurth.
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat9/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.41/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1289/
> The tag is:
> https://github.com/apache/tomcat/tree/9.0.41
> 75d7a2069bf4360bcd8b885c6b7387d70c9cb052
>
> The proposed 9.0.41 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 9.0.41
>

Tested with Ubuntu 20.04, Java 13.0.4, and TC-Native 1.2.25

Best,

Igal



>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 10.0.0

2020-12-03 Thread Igal Sapir
On Thu, Dec 3, 2020 at 2:50 AM Mark Thomas  wrote:

> The proposed Apache Tomcat 10.0.0 release is now available for
> voting.
>
> Apache Tomcat 10.x implements Jakarta EE 9 and, as such, the primary
> package for all the specification APIs has changed from javax.* to
> jakarta.*
> Applications that run on Tomcat 9 will not run on Tomcat 10 without
> changes.
>
> The notable changes compared to 10.0.0-M10 are:
>
> - Specs are now final. Tomcat passes the TCKs apart from a number of
>   expected failures that don't impact spec compliance.
>
> - The APR/Native AJP and HTTP connectors have been deprecated.
>   Tomcat Native will continue to be used to support OpenSSL use with NIO
>   and NIO2.
>
> - Align the behaviour of ServletContext.getRealPath(String path) with
>   the recent clarification from the Servlet specification project. If
>   the path parameter does not start with / then Tomcat processes the
>   call as if / is appended to the beginning of the provided path.
>
> Along with lots of other bug fixes and improvements.
>
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat10/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.0.0/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1287/
> The tag is:
> https://github.com/apache/tomcat/tree/10.0.0
> 4c8b650437e2464c1c31c6598a263b3805b7a81f
>
> The proposed 10.0.0 release is:
> [ ] Broken - do not release
> [X] Beta   - go ahead and release as 10.0.0 (beta)
> [ ] Stable - go ahead and release as 10.0.0 (stable)
>

Tested on Ubuntu 20.04 with Java 13.0.4 and TC-Native 1.2.25

Best,

Igal



>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: Tomcat Native Build Instructions

2020-12-03 Thread Igal Sapir
On Thu, Dec 3, 2020 at 2:31 PM Emmanuel Bourg  wrote:

> Le 03/12/2020 à 23:00, Igal Sapir a écrit :
>
> > It seems that the package is named "libapr1-dev" and I'm not sure if that
> > was a recent change or not.
> >
> > I want to update the docs but not sure if that would break non-Ubuntu
> > Debian-based builds.
> >
> > Any thoughts?
>
> libapr1.0-dev was in Debian Sid between 2004 and 2006, it has only been
> part of Debian 3.1 Sarge until its EOL in 2008. (the Ubuntu release at
> this time was 6.06 Dapper Drake, EOL in 2011)
>
> libapr1-dev has been used to build tomcat-native in Debian (and Ubuntu)
> since its first upload in 2008 [1].
>

Thanks Emmanuel!  I'm surprised that no one has complained about the docs
being misaligned so far.

Best,

Igal



>
> Emmanuel Bourg
>
> [1] https://salsa.debian.org/java-team/tomcat-native/-/commit/201da1d9
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Tomcat Native Build Instructions

2020-12-03 Thread Igal Sapir
The docs for building Tomcat Native [1] states "libapr1.0-dev" as a
prerequisite for Debian based systems, but on Ubuntu 20.04 that throws an
error:

> Package libapr1.0-dev is not available, but is referred to by another
package.
> This may mean that the package is missing, has been obsoleted, or
> is only available from another source

It seems that the package is named "libapr1-dev" and I'm not sure if that
was a recent change or not.

I want to update the docs but not sure if that would break non-Ubuntu
Debian-based builds.

Any thoughts?

Thank you,

Igal




[1] http://tomcat.apache.org/native-doc/#Requirements


Re: [VOTE] Release Apache Tomcat 8.5.60

2020-11-15 Thread Igal Sapir
On Thu, Nov 12, 2020 at 9:54 AM Mark Thomas  wrote:

> The proposed Apache Tomcat 8.5.60 release is now available for voting.
> 
>
> The proposed 8.5.60 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.5.60
>

+1

Unit tests passed on Ubuntu with Java 11 and Tomcat Native 1.2.23

Igal



>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 9.0.40

2020-11-15 Thread Igal Sapir
On Thu, Nov 12, 2020 at 7:58 AM Mark Thomas  wrote:

> The proposed Apache Tomcat 9.0.40 release is now available for voting.
> 
>
> The proposed 9.0.40 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 9.0.40
>

+1

Unit tests passed on Ubuntu with Java 11 and Tomcat Native 1.2.23

Igal



>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 10.0.0-M10

2020-11-15 Thread Igal Sapir
On Thu, Nov 12, 2020 at 4:32 AM Mark Thomas  wrote:

> The proposed Apache Tomcat 10.0.0-M10 release is now available for
> voting.
> 
>
> The proposed 10.0.0-M10 release is:
> [ ] Broken - do not release
> [X] Alpha  - go ahead and release as 10.0.0-M10
>

+1

Tested on Ubuntu with Java 11 and Tomcat Native 1.2.23

Best,

Igal



>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: JPMS module names

2020-10-31 Thread Igal Sapir
Mark,

On Thu, Oct 29, 2020 at 12:43 PM Mark Thomas  wrote:

> Hi all,
>
> Just a reminder that this is on the radar. I'll likely be looking to
> make these changes early next week as part of the prep for the next
> release round (I need to sort this to be able to fix BZ 64849 sensibly).
>
> Mark
>
>
> On 27/10/2020 20:04, Mark Thomas wrote:
> > Hi all,
> >
> > We are starting to get JPMS related bug reports. Resolving the issues is
> > technically simple but depends on us deciding on the names to use for
> > the various modules.
> >
> > The names we choose for our own modules are easy. Generally we are using
> > the same or derivation from the OSGi module name.
> >
> > The names we use for the spec API modules are a little more tricky. We
> > need to (try and) remain aligned with the RI spec JARs.
> >
> > It looks like Jakarta EE 9 onwards is going to have consistent naming
> > (at least it does for the modules we use). Java EE 8 / Jakarta EE 8 is a
> > bit more inconsistent.
> >
> > I have put together a wiki page that documents the current position and
> > the naming I propose we use in Tomcat.
> >
> > https://cwiki.apache.org/confluence/display/TOMCAT/JPMS+names
> >
> > Comments (in this thread ideally) welcome.
>

+1.  Your proposal looks good.

Best,

Igal



> >
> > Once we (appear to) have consensus I'll update the builds to use the new
> > names and start fixing the associated bugs.
> >
> > Mark
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > For additional commands, e-mail: dev-h...@tomcat.apache.org
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: svn/git for website

2020-10-29 Thread Igal Sapir
Dave,

On Wed, Oct 28, 2020 at 9:36 PM Dave Fisher  wrote:

> Hi -
>
> I may have helpful ideas. Tell me where the Tomcst site repository and
> build are located.
>

The SVN repo for the Tomcat site is at
http://svn.apache.org/repos/asf/tomcat/site/

I'm not sure where the build scripts are stored or executed from.

Thanks,

Igal



>
> Regards,
> Dave
>
> Sent from my iPhone
>
> > On Oct 27, 2020, at 12:18 PM, Christopher Schultz <
> ch...@christopherschultz.net> wrote:
> >
> > Konstantin,
> >
> >> On 10/26/20 20:47, Konstantin Kolinko wrote:
> >> пт, 2 окт. 2020 г. в 00:09, Mark Thomas :
> >>>
> >>> Hi all,
> >>>
> >>> The topic came up at the BoF session at the end of the Tomcat track of
> >>> migrating the website from svn to git. There were strong opinions both
> >>> for migrating and for sticking with svn.
> >>>
> >>> As a middle ground I'd like to propose we ask Infra to create a git
> >>> mirror of the svn repo.
> >>>
> >>> For those who favour git:
> >>> The git mirror would be read-only but it would be possible to:
> >>> - clone the git mirror
> >>> - make changes in git
> >>> - use git-svn to commit those changes back to svn
> >>> - then the mirror automatically replicates them back to git
> >>>
> >>> For those who favour svn there would be no change.
> >>>
> >>> If there is agreement on this approach, I volunteer to contact infra to
> >>> get it set up.
> >> My proposal at BoF was for a partial mirror.
> >> The issue is that
> >> 1. I think that this mirror is intended as a tool to collect feedback
> >> / patches from random people, and to lower barriers for contribution.
> >> 2. The full Tomcat site is large. It includes documentation for all
> >> versions of Tomcat, including javadocs. Those pages are changed rarely
> >> and are not needed for people who contribute small changes for the
> >> site. The source code for those pages is elsewhere.
> >
> > The question I have to ask, here is: why do we bother putting all those
> files in revision-control? The users guide for 4 different versions of
> Tomcat is not a problem, but the javadocs are just stupid to store.
> >
> > Is there some policy we are following by having all those files in
> there? Or is it just to make sure that website "publication" is as simple
> as "svn checkout"?
> >
> >> 3. Subversion has easy commands to cope with such large source trees.
> >> This feature is called "sparse checkouts".
> >> For our site the necessary commands are documented in README.txt.
> >> Essentially, it is done with --depth and --set-depth arguments to "svn
> >> checkout" and "svn update" commands
> >> Speaking about Git, there are huge repositories [1] out there, but I
> >> think that the majority of people are not accustomed to them.
> >> [1] https://en.wikipedia.org/wiki/Monorepo
> >> I see that Git developers recently did some work to make dealing with
> >> such repositories simpler, with addition of "git sparse-checkout"
> >> command in Git 2.25.0 [2], released in January 2020.
> >> [2]
> https://github.com/git/git/blob/v2.25.0/Documentation/RelNotes/2.25.0.txt
> >> Though I think that support in tools is still lacking. E.g. missing in
> >> TortoiseGit. [3]
> >> [3] https://gitlab.com/tortoisegit/tortoisegit/issues/1599
> >> If we go with a full Git mirror or with migration to Git, then I think
> >> that somebody has to prepare an update to README.txt.
> >> If we go with a partial Git mirror, I think it could be named
> >> "tomcat-site-dev", reserving the name "tomcat-site" for a full mirror
> >> if we ever make one.
> >> Ignored paths for git-svn are configured with "--ignore-paths"
> >> argument or with "svn-remote..ignore-paths" configuration
> >> option. [4]
> >> [4] https://git-scm.com/docs/git-svn
> >> Other notes:
> >> 4. Release managers use Subversion to publish the binaries.
> >> Thus I expect that they are able to update the published documentation
> >> with Subversion as well.
> >> 5. Publishing the javadocs generates small changes over a large number
> >> of files. The script that generates the commit email notes that the
> >> diff is huge and trims it all to a small summary.
> >> If we ever migrate to Git, I wonder whether a similar script in Git is
> >> able to cope with it.
> >
> > We might also want to consider complicating the website-building process
> in order to simplify the repository. Yes, "disk space is cheap" but it's
> kind of ridiculous that we have all that derivative content in RCS,
> separate from its canonical source.
> >
> > -chris
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > For additional commands, e-mail: dev-h...@tomcat.apache.org
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: svn/git for website

2020-10-28 Thread Igal Sapir
On Tue, Oct 27, 2020 at 12:17 PM Christopher Schultz <
ch...@christopherschultz.net> wrote:

> Konstantin,
>
> On 10/26/20 20:47, Konstantin Kolinko wrote:
> > пт, 2 окт. 2020 г. в 00:09, Mark Thomas :
> >>
> >> Hi all,
> >>
> >> The topic came up at the BoF session at the end of the Tomcat track of
> >> migrating the website from svn to git. There were strong opinions both
> >> for migrating and for sticking with svn.
> >>
> >> As a middle ground I'd like to propose we ask Infra to create a git
> >> mirror of the svn repo.
> >>
> >> For those who favour git:
> >> The git mirror would be read-only but it would be possible to:
> >> - clone the git mirror
> >> - make changes in git
> >> - use git-svn to commit those changes back to svn
> >> - then the mirror automatically replicates them back to git
> >>
> >> For those who favour svn there would be no change.
> >>
> >> If there is agreement on this approach, I volunteer to contact infra to
> >> get it set up.
> >
> > My proposal at BoF was for a partial mirror.
> >
> > The issue is that
> >
> > 1. I think that this mirror is intended as a tool to collect feedback
> > / patches from random people, and to lower barriers for contribution.
> >
> > 2. The full Tomcat site is large. It includes documentation for all
> > versions of Tomcat, including javadocs. Those pages are changed rarely
> > and are not needed for people who contribute small changes for the
> > site. The source code for those pages is elsewhere.
>
> The question I have to ask, here is: why do we bother putting all those
> files in revision-control? The users guide for 4 different versions of
> Tomcat is not a problem, but the javadocs are just stupid to store.
>
> Is there some policy we are following by having all those files in
> there? Or is it just to make sure that website "publication" is as
> simple as "svn checkout"?
>
> > 3. Subversion has easy commands to cope with such large source trees.
> > This feature is called "sparse checkouts".
> >
> > For our site the necessary commands are documented in README.txt.
> > Essentially, it is done with --depth and --set-depth arguments to "svn
> > checkout" and "svn update" commands
> >
> > Speaking about Git, there are huge repositories [1] out there, but I
> > think that the majority of people are not accustomed to them.
> >
> > [1] https://en.wikipedia.org/wiki/Monorepo
> >
> > I see that Git developers recently did some work to make dealing with
> > such repositories simpler, with addition of "git sparse-checkout"
> > command in Git 2.25.0 [2], released in January 2020.
> >
> > [2]
> https://github.com/git/git/blob/v2.25.0/Documentation/RelNotes/2.25.0.txt
> >
> > Though I think that support in tools is still lacking. E.g. missing in
> > TortoiseGit. [3]
> >
> > [3] https://gitlab.com/tortoisegit/tortoisegit/issues/1599
> >
> >
> > If we go with a full Git mirror or with migration to Git, then I think
> > that somebody has to prepare an update to README.txt.
> >
> > If we go with a partial Git mirror, I think it could be named
> > "tomcat-site-dev", reserving the name "tomcat-site" for a full mirror
> > if we ever make one.
> >
> >
> > Ignored paths for git-svn are configured with "--ignore-paths"
> > argument or with "svn-remote..ignore-paths" configuration
> > option. [4]
> >
> > [4] https://git-scm.com/docs/git-svn
> >
> >
> > Other notes:
> >
> > 4. Release managers use Subversion to publish the binaries.
> >
> > Thus I expect that they are able to update the published documentation
> > with Subversion as well.
> >
> > 5. Publishing the javadocs generates small changes over a large number
> > of files. The script that generates the commit email notes that the
> > diff is huge and trims it all to a small summary.
> >
> > If we ever migrate to Git, I wonder whether a similar script in Git is
> > able to cope with it.
>
> We might also want to consider complicating the website-building process
> in order to simplify the repository. Yes, "disk space is cheap" but it's
> kind of ridiculous that we have all that derivative content in RCS,
> separate from its canonical source.
>

That makes a lot of sense to me.  I'm sure that the whole process can be
scripted, including the script that Konstantin mentioned in his item [5].

I also wonder if Git LFS (Large File Storage) [1][2] would solve the issue
of repo size here.

>From [1]: "Git Large File Storage (LFS) replaces large files such as audio
samples, videos, datasets, and graphics with text pointers inside Git,
while storing the file contents on a remote server".  It allows to set file
patterns, e.g. "*.jpg", or "/javadoc/*" for files that should not be
tracked by Git and do not need to be downloaded from the server unless
requested.

Igal

[1] https://git-lfs.github.com/
[2] https://www.atlassian.com/git/tutorials/git-lfs



>
> -chris
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, 

Re: [VOTE] Release Apache Tomcat 8.5.59

2020-10-07 Thread Igal Sapir
On Tue, Oct 6, 2020 at 10:34 AM Mark Thomas  wrote:

> The proposed Apache Tomcat 8.5.59 release is now available for voting.
>
> 
>
> The proposed 8.5.59 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.5.59
>

Unit tests passed on Ubuntu 20.04 with Java 11 and TCNative 1.2.23

Igal


Re: [VOTE] Release Apache Tomcat 9.0.39

2020-10-07 Thread Igal Sapir
On Tue, Oct 6, 2020 at 7:49 AM Mark Thomas  wrote:

> The proposed Apache Tomcat 9.0.39 release is now available for voting.
>
> 
>
> The proposed 9.0.39 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 9.0.39
>

Unit tests passed on Ubuntu 20.04 with Java 11 and TCNative 1.2.23

Igal


Re: [VOTE] Release Apache Tomcat 9.0.39

2020-10-07 Thread Igal Sapir
I got an error [1] running unit tests.  Will run it again in case it's just
a fluke or a fragile test case.

Igal

[1] Testcase: testExceedMaxActiveStreams02[0] took 0.282 sec
Caused an ERROR
End of input stream
java.io.IOException: End of input stream
at
org.apache.coyote.http2.Http2TestBase$TestInput.fill(Http2TestBase.java:979)
at
org.apache.coyote.http2.Http2Parser$Input.fill(Http2Parser.java:707)
at
org.apache.coyote.http2.Http2Parser.readFrame(Http2Parser.java:78)
at
org.apache.coyote.http2.Http2Parser.readFrame(Http2Parser.java:71)
at
org.apache.coyote.http2.TestHttp2Section_5_1.testExceedMaxActiveStreams02(TestHttp2Section_5_1.java:303)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

07-Oct-2020 14:19:13.286 FINE [http-nio-127.0.0.1-auto-6-exec-4]
org.apache.coyote.http2.Http2UpgradeHandler.upgradeDispatch Connection error
org.apache.coyote.http2.ConnectionException: There was an error
during the HPACK decoding of HTTP headers
at
org.apache.coyote.http2.Http2Parser.readHeaderPayload(Http2Parser.java:488)
at
org.apache.coyote.http2.Http2Parser.readHeadersFrame(Http2Parser.java:269)
at
org.apache.coyote.http2.Http2AsyncParser$FrameCompletionHandler.completed(Http2AsyncParser.java:249)
at
org.apache.coyote.http2.Http2AsyncParser$FrameCompletionHandler.completed(Http2AsyncParser.java:164)
at
org.apache.tomcat.util.net.SocketWrapperBase$VectoredIOCompletionHandler.completed(SocketWrapperBase.java:1087)
at
org.apache.tomcat.util.net.NioEndpoint$NioSocketWrapper$NioOperationState.run(NioEndpoint.java:1511)
at
org.apache.tomcat.util.net.SocketWrapperBase$OperationState.start(SocketWrapperBase.java:1039)
at
org.apache.tomcat.util.net.SocketWrapperBase.vectoredOperation(SocketWrapperBase.java:1450)
at
org.apache.tomcat.util.net.SocketWrapperBase.read(SocketWrapperBase.java:1293)
at
org.apache.tomcat.util.net.SocketWrapperBase.read(SocketWrapperBase.java:1265)
at
org.apache.coyote.http2.Http2AsyncParser.readFrame(Http2AsyncParser.java:138)
at
org.apache.coyote.http2.Http2Parser.readFrame(Http2Parser.java:71)
at
org.apache.coyote.http2.Http2UpgradeHandler.upgradeDispatch(Http2UpgradeHandler.java:339)
at
org.apache.coyote.http2.Http2AsyncUpgradeHandler.upgradeDispatch(Http2AsyncUpgradeHandler.java:40)
at
org.apache.coyote.http11.upgrade.UpgradeProcessorInternal.dispatch(UpgradeProcessorInternal.java:54)
at
org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:59)
at
org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:868)
at
org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1590)
at
org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
at
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at
org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
at java.base/java.lang.Thread.run(Thread.java:834)
Caused by: org.apache.coyote.http2.HpackException: Connection [5],
Stream [5], received multiple [:method] headers
at
org.apache.coyote.http2.Stream.emitHeader(Stream.java:329)
at
org.apache.coyote.http2.HpackDecoder.emitHeader(HpackDecoder.java:431)
at
org.apache.coyote.http2.HpackDecoder.addStaticTableEntry(HpackDecoder.java:300)
at
org.apache.coyote.http2.HpackDecoder.handleIndex(HpackDecoder.java:267)
at
org.apache.coyote.http2.HpackDecoder.decode(HpackDecoder.java:111)
at
org.apache.coyote.http2.Http2Parser.readHeaderPayload(Http2Parser.java:485)
... 22 more


On Wed, Oct 7, 2020 at 2:15 PM Raymond Auge
 wrote:

> On Tue, Oct 6, 2020 at 10:49 AM Mark Thomas  wrote:
>
> > The proposed Apache Tomcat 9.0.39 release is now available for voting.
> >
> > The notable changes compared to the 9.0.38 release are:
> >
> > - Refactor the handling of closed HTTP/2 streams to reduce the heap
> >   usage associated with used streams and to retain information for more
> >   streams in the priority tree.
> >
> > - Allow using the utility executor for annotation scanning. Patch
> >   provided by Jatin Kamnani.
> >
> > - Add a bloom filter to speed up archive lookup and 

Re: [VOTE] Release Apache Tomcat 10.0.0-M9

2020-10-07 Thread Igal Sapir
On Tue, Oct 6, 2020 at 6:38 AM Mark Thomas  wrote:

> The proposed Apache Tomcat 10.0.0-M9 release is now available for
> voting.
>
> 
>
> The proposed 10.0.0-M9 release is:
> [ ] Broken - do not release
> [X] Alpha  - go ahead and release as 10.0.0-M9
>

Unit tests passed on Ubuntu 20.04 with Java 8 and TCNative 1.2.23

Igal


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: Use of "constants" in Manager to generate HTML/CSS content

2020-08-16 Thread Igal Sapir
Konstantin,

On Sun, Aug 16, 2020 at 1:00 PM Konstantin Kolinko 
wrote:

> вс, 16 авг. 2020 г. в 21:32, Igal Sapir :
> >
> > I don't see any scripts either.  Why not add a CSP and set script to
> 'none'?  I can add that if no one objects.
> >
>
> sessionsList.jsp has onclick attributes. Maybe it can be modified to
> work without them, I do not know.
>

Definitely something to consider.  I naively searched for "script" and
missed that.

Thank you,

Igal



>
> K.Kolinko
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [tomcat] branch master updated: Extracted CSS styles to external file for better code mainenance

2020-08-16 Thread Igal Sapir
Michael,

On Sun, Aug 16, 2020 at 11:37 AM Michael Osipov  wrote:

> Am 2020-08-16 um 20:05 schrieb isa...@apache.org:
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > isapir pushed a commit to branch master
> > in repository https://gitbox.apache.org/repos/asf/tomcat.git
> >
> >
> > The following commit(s) were added to refs/heads/master by this push:
> >   new 9c5d2e3  Extracted CSS styles to external file for better code
> mainenance
> > 9c5d2e3 is described below
> >
> > commit 9c5d2e3b633fdb651bc9f11db4aac97ad3ad4df2
> > Author: Igal Sapir 
> > AuthorDate: Sun Aug 16 11:05:05 2020 -0700
> >
> >  Extracted CSS styles to external file for better code mainenance
> >
> >  Also replaced gif logo with svg
> > ---
> >   java/org/apache/catalina/manager/Constants.java|  79 +-
>
> There is a slight problem to that: TOMCAT_CSS is shared throughout the
> codebase. Do you want to break that up in CSS modules or duplicate code?
>

The new file "manager.css" includes the code from TOMCAT_CSS, which is
really just a few lines of CSS [1].

We can certainly add another file with just that but IMO it would be an
overkill and would result in an additional unnecessary http request.

Igal

[1]
https://github.com/apache/tomcat/blob/69602cb1ef0dc3aa2188a1b3be9fa3a1440cd1b1/java/org/apache/catalina/util/TomcatCSS.java#L25



>
> M
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: Use of "constants" in Manager to generate HTML/CSS content

2020-08-16 Thread Igal Sapir
On Wed, Aug 12, 2020 at 8:47 AM Christopher Schultz <
ch...@christopherschultz.net> wrote:

> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA256
>
> Konstantin,
>
> On 8/12/20 10:02, Konstantin Kolinko wrote:
> > вт, 28 июл. 2020 г. в 16:55, Christopher Schultz
> > :
> >>
> >> All,
> >>
> >> I was looking at this PR[1] and wondering why we have huge swaths
> >> of CSS and HTML in a Java source file, instead of using e.g. JSP
> >> or some other content-generation framework.
> >
> > I remember that I once read some praise for being able to use the
> > Manager web application when there is no Jasper and no JSP
> > compiler available. It was more than 5 years ago and I do not
> > remember the details - maybe it was some small system with limited
> > hardware.
>
> Agreed.
>
> > The Manager app does use JSPs nowadays, not for some unimportant
> > pages: listing of sessions and listing attributes of a session.
>
> Okay. Are you suggesting then that JSP can/should be required for
> Manager usage? Or maybe just for certain functions?
>
> >> I know, I hate JSP, too, but having large blocks of HTML and CSS
> >> in Java strings is just ... awful.
> >>
> >> Also, is there a particular reason we are using embedded CSS in
> >> the pages instead of an external CSS file?
> >
> > Originally it was rather small. It grows with time.
>
> Okay. I think it's time to separate.
>
> > A separate file needs a license header, so the size will grow.
>
> I'm okay with that.
>
> >> Ultimately, it would be a good idea to move all CSS and even
> >> styles into a separate CSS file so we can tighten-up the Content
> >> Security Policy on the manager app. This can help prevent attacks
> >> if there happens to be some kind of XSS vulnerability hiding in
> >> there somewhere.
> >
> > I do not get how having a separate file [matters] with Content
> > Security Policy.
>
> Having separate CSS allows a site to allow external styles but
> prohibit in-page styles. The allow-token for CSP for inline styles is
> "unsafe-inline".
>
> The reason this is a security issue is for XSS attacks. If an XSS
> attack is in progress, the script may attempt to modify the page's
> styles to manipulate the user. For example, hiding some important data
> or warning message. XSS would have more difficulty spoofing an
> externally-loaded CSS file.
>
> I don't think we have any js in the Manager, but external js is better
> as well, as the page is therefore prohibited from running any js code
> appearing in the page: all scripts must be external.
>

I don't see any scripts either.  Why not add a CSP and set script to
'none'?  I can add that if no one objects.


>
> Speaking of which, we should look at defining a CSP for the Manager
> application.
>
> >> Any objections to evicting the CSS to begin with?
> >
> > No objection, if you want it.
>

I have extracted the CSS from the Java code on master [2].  I plan to port
that to 9.0.x and 8.5.x.  Feedback welcomed.

I also replaced the old GIF logo with an SVG image from the main page as it
looks more modern and crisp, especially on high resolution screens.

I personally don't think that a few KBs make a difference with the code
size, but if it is a concern then we can remove the multiple copies of the
logos (Tomcat and ASF) for example from the different web applications, and
copy them over at build time.  So we will have a slightly smaller codebase
at the expense of a bit more complicated build process.

Best,

Igal

[2]
https://github.com/apache/tomcat/commit/9c5d2e3b633fdb651bc9f11db4aac97ad3ad4df2



> >
> > We already have image files. Thus, why not?
>
> Sine you mentioned it, how to we "license" image files?
>
> >> [1] https://github.com/apache/tomcat/pull/327
> >
> > An odd PR. I see that it makes some visual changes, but there is
> > no description nor discussion what the actual changes are.
>
> I care less about this specific PR and more about cleaning everything up
> .
>
> - -chris
> -BEGIN PGP SIGNATURE-
> Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/
>
> iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAl80Dx8ACgkQHPApP6U8
> pFhSSg/9EQQpZ6WLOeMA7o41UJ3o/X49Xu5h7mliFhIQ6xNkoqW6sWkOHy0LURqU
> 4S+WaPQzNsXqU8gREcKcU1OPNFnh2i3hGaD6mc/Tr5PMg82qBDwozxM9L6pcKo/N
> d30RiJ5MeenrLZ/chbC8Kq4pqBbNtChQWmVH4Dp469DIAwhE3A6T7pwiB1bB72Tz
> DxW/1PTAZENvkchkhll/UyEd+pJV9rq1CrrR8LRpqkEkZqu50vKFhE7XWIn4AkZf
> OXhtI+SLh/1cxeVMfVjq7JyoslMHiZ7d+55wybvdRWZLns+OMeOTjxW6nzAaB8nN
> SYEs/x/+HOV2x91btCpurttGFNzjdU3VqnM/Xk0mThVoxP0CktOSePGlUKd8gqi1
> Jed/RxeaKSUSjrghhCJLnvsNhqUfXMy35eATWdJ+YPhIyxM1aotBPZN9zZRKh2zp
> IPM/VvpFWJsIiIzbzhLfQfRNK9UpLaTL96s+V/5opoIHpPVpW+T8uSVrFpysfErE
> fZVC027SgEDzDjtBvPhRN4E8kK4rUKiAOyJJX/M3q7iJKZj1zy5NOo3RQZ7WAqIv
> Qx8mAwIi+/cNaQotbCuTkTpObzSHetR6OF9RQDZG/zAMI+W5/9eVTrZucto4yCB8
> 9fMGf2YTrqnF4qF5JMAKzRH+kucGyZx4q8aX9SY+RTl5GuGcGKI=
> =xI8S
> -END PGP SIGNATURE-
>
> -
> To unsubscribe, e-mail: 

Re: Use of "constants" in Manager to generate HTML/CSS content

2020-08-11 Thread Igal Sapir
Chris,

On Mon, Aug 10, 2020 at 12:20 PM Martin Grigorov 
wrote:

>
> On Tue, Jul 28, 2020, 16:48 Christopher Schultz <
> ch...@christopherschultz.net> wrote:
>
>> -BEGIN PGP SIGNED MESSAGE-
>> Hash: SHA256
>>
>> All,
>>
>> I was looking at this PR[1] and wondering why we have huge swaths of
>> CSS and HTML in a Java source file, instead of using e.g. JSP or some
>> other content-generation framework.
>>
>> I know, I hate JSP, too, but having large blocks of HTML and CSS in
>> Java strings is just ... awful.
>>
>> Also, is there a particular reason we are using embedded CSS in the
>> pages instead of an external CSS file?
>>
>> Ultimately, it would be a good idea to move all CSS and even styles
>> into a separate CSS file so we can tighten-up the Content Security
>> Policy on the manager app. This can help prevent attacks if there
>> happens to be some kind of XSS vulnerability hiding in there somewhere.
>>
>> Any objections to evicting the CSS to begin with?
>>
>
It's funny, I was thinking the same thing a couple of weeks ago but didn't
want to cause a merge conflict for the PR so waited to see what's going on
with that, though as I commented on it I don't like that it changes the
theme colors, etc.

If you are already working on that then great.  If you haven't started, and
you have better things to do, I'd be happy to clean that up so please LMK.

Best,

Igal



>
> +1
>
>
>> Thanks,
>> - -chris
>>
>> [1] https://github.com/apache/tomcat/pull/327
>> -BEGIN PGP SIGNATURE-
>> Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/
>>
>> iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAl8gLJsACgkQHPApP6U8
>> pFgKCw//WY8p/EBS7sxDYgnV6W4pjeuAuhXv6ierajPH28NfdokIRlU4IfFIUVIE
>> Ck98rK9uH98o6QFkWC70MVYV+NbEi4CwrjPhuFV/rEplyqfA+Ijs5g069a1g15On
>> fw5V44CK2JBj0AjT4ZtMVWOSxDElHZc3SjZmyaie0pk2zDVxYwSwhoRPtqzms5rH
>> zTlu48R14t1O9PLsWGthwdVStAn9WlE7hBLI3yLag/QKUqlOR/a8Fy75mbMma5a9
>> cmG8Lh5Jo8a6YzD0q37sdOmKN5d9lZxZkz3x21Cy3v2qcKcaGUcAttAEe9hFKEzh
>> I0hOMKYc/2n2aNpMTjIkG86fXzAYB1IIsfiGxlwP/nY6HzJ9XRolD9+kT7LZ/tP3
>> 7SKL8rVoKi5SWiH+g3jGifVkxfiHlMhvZikAbC75ngP7mNXZFHPdnF3rvai/cbum
>> FWUpLDoW/oTs87v9l071hs+hf2PffvqL/v5AeoMbGf/VDpf/zcuNy0wlB2w6Nxo9
>> K8sBVHQGJzIlaR9fqLyYJkJ8kmSb37t7BxPXLuGSCr98uUD8bSy2IwC2IxessXQc
>> E+oIyJ0mlPdKU1dh5yFtMzCp4S9olUg4diqOxpToGm2hnmdnkRY3OarC1OU839NC
>> Yd5uYA9XoYxBro2oNfB1gCNB5Ve4aLVOV0Q3iKcW83b8jLiNgzY=
>> =Z+cI
>> -END PGP SIGNATURE-
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>
>>


Re: How to run individual Test

2020-08-10 Thread Igal Sapir
Saksham,

On Mon, Aug 10, 2020 at 9:46 AM Saksham Verma 
wrote:

> Hi Dev Team,
>
> Need help with below questions:
>
> 1. The Pull request Tests are failing on Travis CI. But Is there any way I
> can get the logs for the test job?
>
> 2. How can I run any individual test.
>

See section 7 of the BUILDING.txt [1] file.

Igal

[1] https://github.com/apache/tomcat/blob/master/BUILDING.txt#L308




> Whenever I am trying to run a single test I get below error:
> java.lang.VerifyError: Inconsistent stackmap frames at branch target 392
> Exception Details:
>   Location:
>
> org/apache/juli/ClassLoaderLogManager.readConfiguration(Ljava/lang/ClassLoader;)V
> @392: ldc_w
>   Reason:
> Type uninitialized 370 (current frame, stack[2]) is not assignable to
> uninitialized 366 (stack map, stack[2])
>   Current Frame:
> bci: @383
> flags: { }
> locals: { 'org/apache/juli/ClassLoaderLogManager',
> 'java/lang/ClassLoader', 'java/io/InputStream', 'java/lang/String' }
> stack: { uninitialized 366, uninitialized 366, uninitialized 370,
> uninitialized 370, 'java/lang/String', integer }
>   Stackmap Frame:
> bci: @392
> flags: { }
> locals: { 'org/apache/juli/ClassLoaderLogManager',
> 'java/lang/ClassLoader', 'java/io/InputStream', 'java/lang/String' }
> stack: { uninitialized 366, uninitialized 366, uninitialized 366,
> uninitialized 366, 'java/lang/String' }
>   Bytecode:
>
> Thanks,
> Saksham
>


Re: Publishing EOL dates on whichversion?

2020-08-07 Thread Igal Sapir
Chris,

On Thu, Aug 6, 2020 at 8:29 AM Christopher Schultz <
ch...@christopherschultz.net> wrote:

> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA256
>
> All,
>
> I'm wondering if we shouldn't add EOL dates to the "which version" page.
>
> The table on that page is very busy, but I think it would help to know:
>
> 1. When a currently-supported version will be EOL'd (e.g. 7.0.x)
> 2. When a superseded version has been EOL'd (e.g. 6.0.x)
>

+1.  Very useful and important information IMO.


> We might be able to shrink the table horizontally a little by
> shrinkking / abbreviating some of the column headers. For example
> replace "Authentication (JASPIC) Spec" with "JASPIC". Maybe drop
> "Spec" from all headers. Maybe shorten "Latest Released Version" to
> "Latest" and "Supported Java Versions" to "Java". We could use a
> stylesheet to add those longer headers for printing, and we could use
> "title"s to expand the headers if you float a mouse/tap a finger on
> the headings to get more information. We could also put a key below
> the table.
>
> WDYT?
>

There are many opportunities for improving the layout, and I'd be happy to
get back on that.  It is a bit challenging for me to work with SVN though
as I'm much more familiar with Git and I don't have much time ATM to work
on improving my SVN skills (which would probably become obsolete soon
anyway).

It'd be great if we could move the website to Git.  Many apache projects
use the `-site` or `-website` suffix, so it can be something like
`tomcat-site`.

Best,

Igal



>
> - -chris
> -BEGIN PGP SIGNATURE-
> Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/
>
> iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAl8sIa8ACgkQHPApP6U8
> pFhjkA/8DLMqIHgF130aGL2YXWuG5OKl/WHh1NFUHhcWHg1zu4zosaMeqExcxFdM
> 20kE44WjbcD0kvAEeAvR6ejOLm1S7lfXzCs41ZnJI6v4wyhEfp+n9gfYESF3kZqU
> 5v4IhD0XBspp60iom2BVggF61qu2ZIE9BCD+zv5ikELni4+psg1T7WkTomtIj8Id
> W0A+QGMnsYyAGZpqxPRM3agn/T2A+pbsQKFTfqX8KEot+m00PrEy5HRjeYCRpm4Y
> OtlHrPLhrOutS7M3K8b191BPf7I55pGEfsq7rSHnpD0H+KM4ur9v6tHtWNutwVTY
> 3Y2Fs357Cckr+jU0YpBEDn/2jmHioiShMYNmchalkvbXCiCESzgzhr5oazU7tp9j
> et7zFy3XlJ1e0fJ3vq/LQnu6HqCwPRPaF27h8hyVrLSzatrPb9Cb2/AGr3SaHonK
> 9YmpziI1MR4i358y3cxeVIaTMal6MDAjRn8fIfQxxm3k5PZiHb+aMNd4Mion11xH
> SqVAep9FyV9V0AbikoazTzUApPBosiD0onioq3o6ApSVfdaa+shh2jmI2JFzRGkf
> Unpb3xGRye3EZZVjwXCDw0QJ2UVx65gM7k5W0xvUr0IOmSjJVLBpi1Z1Zv7ijNN0
> nj8x3UUTNrABK8PniUIZ+xafoRFlPv4RDGcf6laCdks5R5y31+8=
> =8Ax9
> -END PGP SIGNATURE-
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Jasper throws an NPE when running in IntelliJ IDEA

2019-12-24 Thread Igal Sapir
I have set up Tomcat in IntelliJ using the ant task, `ant ide-intellij`.  I
added the PATH variables for ANT_HOME and TOMCAT_BUILD_LIBS, and marked the
directory webapps/examples/WEB-INF/classes as a Source Folder.

If I call the URI for /tomcat.gif, for example, it works as expected and I
get the image, but if I try to run /index.jsp I get the NPE below [1].

Further, when I check the IDE for implementations of the abstract class
org.apache.jasper.runtime.HttpJspBase I can't find any, which is very
puzzling to me.

What am I doing wrong?

Thanks,

Igal

[1]
org.apache.jasper.JasperException: java.lang.NullPointerException

org.apache.jasper.servlet.JspServletWrapper.handleJspException(JspServletWrapper.java:639)

org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:515)
org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:385)
org.apache.jasper.servlet.JspServlet.service(JspServlet.java:329)
javax.servlet.http.HttpServlet.service(HttpServlet.java:741)

*Root Cause*

java.lang.NullPointerException
org.apache.jsp.index_jsp._jspService(index_jsp.java:431)
org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
javax.servlet.http.HttpServlet.service(HttpServlet.java:741)

org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:477)
org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:385)
org.apache.jasper.servlet.JspServlet.service(JspServlet.java:329)
javax.servlet.http.HttpServlet.service(HttpServlet.java:741)


Re: Broken links on the website

2019-12-17 Thread Igal Sapir
Scratch that.

I don't know why Google is indexing the wrong page.  The actual Download
page [2] was a bit slow but renders properly.  Sorry about that.

Perhaps we can remove the wrong page or add a meta tag with a canonical tag
[3], e.g.
  https://tomcat.apache.org/download-90.cgi; />

Igal

[2] https://tomcat.apache.org/download-90.cgi
[3] https://support.google.com/webmasters/answer/139066?hl=en


On Tue, Dec 17, 2019 at 6:18 PM Igal Sapir  wrote:

> Something went wrong on the website.  Specifically, the Download page for
> 9.0 [1] shows attributes that should be evaluated, e.g. [define
> v]9.0.30[end].  That also breaks the download links which do not evaluate
> the version number properly.
>
> I can look into it tomorrow, but if someone more familiar with recent
> changes can fix it that would be great.
>
> Also, migrating the source to Git would be very helpful since if it were
> in Git I could have looked into it now.  SVN is a bit more challenging for
> me ATM.
>
> Thank you,
>
> Igal
>
> [1] https://tomcat.apache.org/download-90
>
>


Broken links on the website

2019-12-17 Thread Igal Sapir
Something went wrong on the website.  Specifically, the Download page for
9.0 [1] shows attributes that should be evaluated, e.g. [define
v]9.0.30[end].  That also breaks the download links which do not evaluate
the version number properly.

I can look into it tomorrow, but if someone more familiar with recent
changes can fix it that would be great.

Also, migrating the source to Git would be very helpful since if it were in
Git I could have looked into it now.  SVN is a bit more challenging for me
ATM.

Thank you,

Igal

[1] https://tomcat.apache.org/download-90


Re: Initial set of patches for Jakarta EE 9

2019-12-02 Thread Igal Sapir

On 12/1/2019 1:28 PM, Mark Thomas wrote:

On 30/11/2019 21:11, Igal Sapir wrote:



First issue I noticed when trying to build on Windows:

compile:
     [javac] Compiling 1727 source files to
E:\Workspace\test\tomcat-jakarta\output\classes
     [javac]
E:\Workspace\test\tomcat-jakarta\java\org\apache\tomcat\util\http\RequestUtil.java:21:
error: package javax.servlet.http does not exist
     [javac] import javax.servlet.http.HttpServletRequest;
     [javac]  ^
     [javac]
E:\Workspace\test\tomcat-jakarta\java\org\apache\tomcat\util\http\RequestUtil.java:122:
error: cannot find symbol
     [javac] public static boolean isSameOrigin(HttpServletRequest
request, String origin) {
     [javac]    ^
     [javac]   symbol:   class HttpServletRequest
     [javac]   location: class RequestUtil
     [javac] Note: Some input files use or override a deprecated API.
     [javac] Note: Recompile with -Xlint:deprecation for details.
     [javac] 2 errors

BUILD FAILED
E:\Workspace\test\tomcat-jakarta\build.xml:706: Compile failed; see the
compiler error output for details.

Sorry. My error. When I rebased the branch I forgot to check if any
additional changes were required. I've fixed this now. Note I used a
force push to try and keep to the one commit per package I used originally.

Should be OK now.


This one built fine but got some failing test cases on a busy Windows 
machine, so possibly false positives:


   [concat] Testsuites with failed tests:
   [concat] 
TEST-org.apache.catalina.authenticator.TestFormAuthenticator.APR.txt

   [concat] TEST-org.apache.catalina.core.TestAsyncContextImpl.NIO2.txt
   [concat] TEST-org.apache.coyote.http2.TestStreamProcessor.APR.txt
   [concat] TEST-org.apache.coyote.http2.TestStreamProcessor.NIO.txt
   [concat] TEST-org.apache.coyote.http2.TestStreamProcessor.NIO2.txt
   [concat] TEST-org.apache.jasper.runtime.TestJspRuntimeLibrary.APR.txt
   [concat] TEST-org.apache.jasper.runtime.TestJspRuntimeLibrary.NIO.txt
   [concat] TEST-org.apache.jasper.runtime.TestJspRuntimeLibrary.NIO2.txt
   [concat] 
TEST-org.apache.tomcat.websocket.TestWebSocketFrameClientSSL.APR.txt


Igal




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Initial set of patches for Jakarta EE 9

2019-11-30 Thread Igal Sapir

Mark,

On 11/28/2019 11:46 AM, Mark Thomas wrote:

Hi all,

I have pushed an initial set of patches for Jakarta EE 9 here:
https://github.com/markt-asf/tomcat/tree/jakarta

The current status is:
- All the packages changing in Jakarta EE 9 have been renamed
- Any associated constants, service loader files etc. have also been
   renamed
- It builds
- The unit tests pass (excluding those that depend on JSTL - more on
   that below)
- A basic smoke test passes

Please try and build it, take it for a spin and report back on this
thread if you find any issues.


First issue I noticed when trying to build on Windows:

compile:
    [javac] Compiling 1727 source files to 
E:\Workspace\test\tomcat-jakarta\output\classes
    [javac] 
E:\Workspace\test\tomcat-jakarta\java\org\apache\tomcat\util\http\RequestUtil.java:21: 
error: package javax.servlet.http does not exist

    [javac] import javax.servlet.http.HttpServletRequest;
    [javac]  ^
    [javac] 
E:\Workspace\test\tomcat-jakarta\java\org\apache\tomcat\util\http\RequestUtil.java:122: 
error: cannot find symbol
    [javac] public static boolean isSameOrigin(HttpServletRequest 
request, String origin) {

    [javac]    ^
    [javac]   symbol:   class HttpServletRequest
    [javac]   location: class RequestUtil
    [javac] Note: Some input files use or override a deprecated API.
    [javac] Note: Recompile with -Xlint:deprecation for details.
    [javac] 2 errors

BUILD FAILED
E:\Workspace\test\tomcat-jakarta\build.xml:706: Compile failed; see the 
compiler error output for details.


Igal



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.5.49

2019-11-18 Thread Igal Sapir

On 11/18/2019 1:22 PM, Mark Thomas wrote:

On 17/11/2019 19:01, Mark Thomas wrote:

We have a regression affecting 8.5.x (and 7.0.x).

The fix [1] for an issue raised on the users list [2] was incorrect and
creating a different issue [3].

There are two questions to address.

a) Do we cancel the 8.5.49 release for this and roll a 8.5.50 release?

b) Do we fix this by a) correcting [1] or back-porting the change to a
single poll set?

I'm leaning towards 8.5.50 and back-port the single poll set change.

Thoughts?


+1 for 8.5.50

Igal




Mark

[1]
https://github.com/apache/tomcat/commit/fffb08790e642e03f00c5f96a3a61ee09a2c8342
[2] https://markmail.org/thread/lh7pst3bwptpcyco
[3] https://tomcat.markmail.org/thread/btjionfhp2olyjne



The proposed Apache Tomcat 8.5.49 release is now available for voting.

The major changes compared to the 8.5.47 release are:

- Improvements to Async error handling

- Stricter processing of HTTP headers when looking for specific token
   values

- Fix various issues that could lead to modification to a JSP not being
   reflected in the served page

Along with lots of other bug fixes and improvements.

For full details, see the changelog:
https://ci.apache.org/projects/tomcat/tomcat85/docs/changelog.html

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.49/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1238/

The tag is:
https://github.com/apache/tomcat/tree/8.5.49

The proposed 8.5.49 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 8.5.49

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 9.0.29

2019-11-18 Thread Igal Sapir

On 11/16/2019 10:56 AM, Mark Thomas wrote:

The proposed Apache Tomcat 9.0.29 release is now available for voting.

The proposed 9.0.29 release is:
[ ] Broken - do not release
[X] Stable - go ahead and release as 9.0.29


Unit tests passed on Windows 10 and Ubuntu 18.04

Igal



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.5.49

2019-11-18 Thread Igal Sapir

On 11/17/2019 11:01 AM, Mark Thomas wrote:

The proposed Apache Tomcat 8.5.49 release is now available for voting.

The proposed 8.5.49 release is:
[ ] Broken - do not release
[X] Stable - go ahead and release as 8.5.49


Unit tests passed on Windows 10 and Ubuntu 18.04

Igal



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.5.47

2019-10-08 Thread Igal Sapir

On 10/7/2019 6:58 AM, Mark Thomas wrote:

The proposed Apache Tomcat 8.5.47 release is now available for voting.

The major changes compared to the 8.5.46 release are:


I'm getting similar test failures as I did for 9.0.27 on that same 
Windows machine:


> grep -A 5 FAILED output/build/logs/*.txt
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt: 
FAILED
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt-Uri: 
/stage1, Status: 500, Time: 2248 duration is not < 1600
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt-junit.framework.AssertionFailedError: 
Uri: /stage1, Status: 500, Time: 2248 duration is not < 1600
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt- 
at 
org.apache.catalina.valves.TesterAccessLogValve.validateAccessLog(TesterAccessLogValve.java:92)
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt- 
at 
org.apache.catalina.core.TestAsyncContextImpl.doTestDispatchError(TestAsyncContextImpl.java:1015)
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt- 
at 
org.apache.catalina.core.TestAsyncContextImpl.testDispatchErrorWithThreadMultiple(TestAsyncContextImpl.java:921)

--
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt: 
FAILED
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt-Uri: 
/stage1, Status: 500, Time: 4018 duration is not < 1600
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt-junit.framework.AssertionFailedError: 
Uri: /stage1, Status: 500, Time: 4018 duration is not < 1600
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt- 
at 
org.apache.catalina.valves.TesterAccessLogValve.validateAccessLog(TesterAccessLogValve.java:92)
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt- 
at 
org.apache.catalina.core.TestAsyncContextImpl.doTestDispatchError(TestAsyncContextImpl.java:1015)
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt- 
at 
org.apache.catalina.core.TestAsyncContextImpl.testDispatchErrorMultiple(TestAsyncContextImpl.java:906)

--
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt: 
FAILED
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt-Uri: 
/stage1, Status: 500, Time: 2182 duration is not < 1600
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt-junit.framework.AssertionFailedError: 
Uri: /stage1, Status: 500, Time: 2182 duration is not < 1600
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt- 
at 
org.apache.catalina.valves.TesterAccessLogValve.validateAccessLog(TesterAccessLogValve.java:92)
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt- 
at 
org.apache.catalina.core.TestAsyncContextImpl.doTestDispatchError(TestAsyncContextImpl.java:1015)
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt- 
at 
org.apache.catalina.core.TestAsyncContextImpl.testDispatchErrorDoubleThenComplete(TestAsyncContextImpl.java:931)

--
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt: 
FAILED
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt-Uri: 
/stage1, Status: 500, Time: 2512 duration is not < 1600
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt-junit.framework.AssertionFailedError: 
Uri: /stage1, Status: 500, Time: 2512 duration is not < 1600
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt- 
at 
org.apache.catalina.valves.TesterAccessLogValve.validateAccessLog(TesterAccessLogValve.java:92)
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt- 
at 
org.apache.catalina.core.TestAsyncContextImpl.doTestDispatchError(TestAsyncContextImpl.java:1015)
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt- 
at 
org.apache.catalina.core.TestAsyncContextImpl.testDispatchErrorSingle(TestAsyncContextImpl.java:896)

--
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt: 
FAILED
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt-Uri: 
/stage1, Status: 500, Time: 1843 duration is not < 1600
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt-junit.framework.AssertionFailedError: 
Uri: /stage1, Status: 500, Time: 1843 duration is not < 1600
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt- 
at 
org.apache.catalina.valves.TesterAccessLogValve.validateAccessLog(TesterAccessLogValve.java:92)
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt- 
at 
org.apache.catalina.core.TestAsyncContextImpl.doTestDispatchError(TestAsyncContextImpl.java:1015)
output/build/logs/TEST-org.apache.catalina.core.TestAsyncContextImpl.APR.txt- 
at 

Re: [VOTE] Release Apache Tomcat 9.0.27

2019-10-07 Thread Igal Sapir

Mark,

On 10/7/2019 4:51 AM, Mark Thomas wrote:

The proposed Apache Tomcat 9.0.27 release is now available for voting.


I'm getting the failures below [1] for unit tests on Windows 10 with 
Java 1.8u181.  False positives?


Igal

[1] output\build\logs> grep -A 5 FAILED * */*
TEST-org.apache.coyote.http2.TestStreamProcessor.APR.txt: FAILED
TEST-org.apache.coyote.http2.TestStreamProcessor.APR.txt-expected:<...3-Header-[:status]-[[304]
TEST-org.apache.coyote.http2.TestStreamProcessor.APR.txt-3-Header-[etag]-[W/"957-1447269522000"]]
TEST-org.apache.coyote.http2.TestStreamProcessor.APR.txt-3-Header-[date]-[W...> 
but was:<...3-Header-[:status]-[[200]

TEST-org.apache.coyote.http2.TestStreamProcessor.APR.txt-3-Header-[accept-ranges]-[bytes]
TEST-org.apache.coyote.http2.TestStreamProcessor.APR.txt-3-Header-[etag]-[W/"957-1447269522000"]
--
TEST-org.apache.coyote.http2.TestStreamProcessor.NIO.txt: FAILED
TEST-org.apache.coyote.http2.TestStreamProcessor.NIO.txt-expected:<...3-Header-[:status]-[[304]
TEST-org.apache.coyote.http2.TestStreamProcessor.NIO.txt-3-Header-[etag]-[W/"957-1447269522000"]]
TEST-org.apache.coyote.http2.TestStreamProcessor.NIO.txt-3-Header-[date]-[W...> 
but was:<...3-Header-[:status]-[[200]

TEST-org.apache.coyote.http2.TestStreamProcessor.NIO.txt-3-Header-[accept-ranges]-[bytes]
TEST-org.apache.coyote.http2.TestStreamProcessor.NIO.txt-3-Header-[etag]-[W/"957-1447269522000"]
--
TEST-org.apache.coyote.http2.TestStreamProcessor.NIO2.txt: FAILED
TEST-org.apache.coyote.http2.TestStreamProcessor.NIO2.txt-expected:<...3-Header-[:status]-[[304]
TEST-org.apache.coyote.http2.TestStreamProcessor.NIO2.txt-3-Header-[etag]-[W/"957-1447269522000"]]
TEST-org.apache.coyote.http2.TestStreamProcessor.NIO2.txt-3-Header-[date]-[W...> 
but was:<...3-Header-[:status]-[[200]

TEST-org.apache.coyote.http2.TestStreamProcessor.NIO2.txt-3-Header-[accept-ranges]-[bytes]
TEST-org.apache.coyote.http2.TestStreamProcessor.NIO2.txt-3-Header-[etag]-[W/"957-1447269522000"]
--
TEST-org.apache.tomcat.jni.TestSocketServer.NIO2.txt:   FAILED
TEST-org.apache.tomcat.jni.TestSocketServer.NIO2.txt-Socket.timeoutSet 
failed (<1s) [999760800] +-[400]
TEST-org.apache.tomcat.jni.TestSocketServer.NIO2.txt-junit.framework.AssertionFailedError: 
Socket.timeoutSet failed (<1s) [999760800] +-[400]
TEST-org.apache.tomcat.jni.TestSocketServer.NIO2.txt-   at 
org.apache.tomcat.jni.TestSocketServer.testBlockingReadFromClientWithTimeout(TestSocketServer.java:111)

TEST-org.apache.tomcat.jni.TestSocketServer.NIO2.txt-
TEST-org.apache.tomcat.jni.TestSocketServer.NIO2.txt-Testcase: testPort 
took 0.001 sec





-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [PROPOSAL] Tomcat 10: Remove CGI Servlet

2019-10-07 Thread Igal Sapir

On 10/7/2019 8:14 AM, Christopher Schultz wrote:

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Mark,

On 10/7/19 11:10, Mark Thomas wrote:

All,

I recently gave a presentation on locking-down Apache Tomcat[1]
and I briefly discussed the "sharp edges" present in Tomcat. Some
of them are unnecessarily sharp and may be actually unnecessary.
I'm going to make a few proposals to remove functions from
Tomcat.

Proposal: Remove CGI Servlet

-1. Not a veto, just a -1.

Fair enough. I didn't think I'd get 100% agreement. If anyone feels
like this is is something worth keeping around, I'm happy to let the
proposal drop.


Is it possible to extract these removals (including the other proposals 
in this question) to an external repo in case someone wants to add them 
manually to his/her own deployment?


That way if anyone depends on any of the removed items they can still 
add them.


Igal



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [PROPOSAL] Tomcat 10: Remove Server-Side Includes (SSI)

2019-10-07 Thread Igal Sapir

On 10/7/2019 7:46 AM, Christopher Schultz wrote:

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

All,

I recently gave a presentation on locking-down Apache Tomcat[1] and I
briefly discussed the "sharp edges" present in Tomcat. Some of them
are unnecessarily sharp and may be actually unnecessary. I'm going to
make a few proposals to remove functions from Tomcat.

Proposal: Remove Server-Side Includes


+1

Igal



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.5.46

2019-09-17 Thread Igal Sapir

On 9/16/2019 11:46 AM, Mark Thomas wrote:

The proposed Apache Tomcat 8.5.46 release is now available for voting.

The proposed 8.5.46 release is:
[ ] Broken - do not release
[X] Stable - go ahead and release as 8.5.46


Igal




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 9.0.26

2019-09-17 Thread Igal Sapir

Mark,

On 9/17/2019 1:56 PM, Mark Thomas wrote:

On 17/09/2019 19:46, Igal Sapir wrote:

On 9/16/2019 9:15 AM, Mark Thomas wrote:

The proposed Apache Tomcat 9.0.26 release is now available for voting.



[1] Testsuite: org.apache.catalina.core.TestAsyncContextImpl
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0 sec

Testcase: testBug50753 took 0.004 sec
Caused an ERROR
Forked Java VM exited abnormally. Please note the time in the report does not 
reflect the time until the VM exit.
junit.framework.AssertionFailedError: Forked Java VM exited abnormally. Please 
note the time in the report does not reflect the time until the VM exit.
at java.lang.Thread.run(Thread.java:748)

That usually indicates an APR/native crash during Windows shutdown. It
means we have a (possibly timing related) bug in the APR/native code we
still haven't tracked down. That they aren't easy to reproduce makes
fixing bugs like this tricky.


In my user's home directory I have a build.properties file pointing to 
an older native lib:


test.apr.loc=E:/Downloads/tomcat-native-1.2.21-openssl-1.1.1a-win32-bin/bin/x64

I will try to test again with the current version (1.2.23) in the coming 
days.


Thanks,

Igal




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 9.0.26

2019-09-17 Thread Igal Sapir

On 9/16/2019 9:15 AM, Mark Thomas wrote:

The proposed Apache Tomcat 9.0.26 release is now available for voting.

The major changes compared to the 9.0.24 release are:

- Update to Commons Daemon 1.2.1 to pick up fixes for regressions in
   Commons Daemon 1.2.0, most notably a failure to start when using
   a 32-bit JVM on Windows.

- Avoid an NPE when accessing an https port using http.

- Correct the invalid automatic module names for the embedded JARs.

- Fix a potential hang when using HTTP/2 with the asynchronous Servlet
   API.



The proposed 9.0.26 release is:
[ ] Broken - do not release
[X] Stable - go ahead and release as 9.0.26


Tested with Ubuntu and Windows.

On Windows I received an error on 
org.apache.catalina.core.TestAsyncContextImpl which tests bug 50753.  I 
think it is a fluke in the test case though.  Details below [1].


Igal

[1] Testsuite: org.apache.catalina.core.TestAsyncContextImpl
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0 sec

Testcase: testBug50753 took 0.004 sec
Caused an ERROR
Forked Java VM exited abnormally. Please note the time in the report does not 
reflect the time until the VM exit.
junit.framework.AssertionFailedError: Forked Java VM exited abnormally. Please 
note the time in the report does not reflect the time until the VM exit.
at java.lang.Thread.run(Thread.java:748)






  1   2   3   >