Re: TestRewriteValve Fails When Specifying Custom Output Directory

2023-03-20 Thread Mark Thomas
On 18/03/2023 20:53, Igal Sapir wrote: Mark, On Thu, Mar 16, 2023 at 2:12 AM Mark Thomas wrote: On 15/03/2023 21:16, Igal Sapir wrote: It is mostly solved, and that might be sufficient. So while `ant clean test` now completes without failures, the part that still doesn't work is when I

Re: TestRewriteValve Fails When Specifying Custom Output Directory

2023-03-16 Thread Mark Thomas
On 15/03/2023 21:16, Igal Sapir wrote: It is mostly solved, and that might be sufficient. So while `ant clean test` now completes without failures, the part that still doesn't work is when I specify a custom "Working Directory" in the IDE in order to make JSP files resolved. In my setup

Re: Reduce default for maxParameterCount

2023-03-15 Thread Mark Thomas
On 15/03/2023 11:22, Konstantin Kolinko wrote: ср, 15 мар. 2023 г. в 13:29, Konstantin Kolinko : ср, 15 мар. 2023 г. в 13:15, Konstantin Kolinko : ср, 15 мар. 2023 г. в 12:07, Mark Thomas : On 14/03/2023 21:13, Christopher Schultz wrote: On 3/14/23 13:57, Mark Thomas wrote: On 09/03/2023 14

Re: [tomcat] branch main updated: Support RFC 7616. Add support for multiple algorithms.

2023-03-15 Thread Mark Thomas
On 15/03/2023 02:35, Han Li wrote: On Mar 15, 2023, at 01:45, ma...@apache.org wrote: +boolean session = false; +if (algorithm.endsWith("-sess")) { +algorithm = algorithm.substring(0, algorithm.length() - 5); +} I guess here maybe a bug that ‘session’

Re: TestRewriteValve Fails When Specifying Custom Output Directory

2023-03-15 Thread Mark Thomas
On 15/03/2023 01:52, Igal Sapir wrote: Hello, test/org/apache/catalina/valves/rewrite/TestRewriteValve.java fails with file not found when a custom tomcat.output directory is specified in build.properties. I have the Tomcat source code (main branch) at /workspace/src/tomcat/main (let's call it

Re: Reduce default for maxParameterCount

2023-03-15 Thread Mark Thomas
On 14/03/2023 21:13, Christopher Schultz wrote: Mark, On 3/14/23 13:57, Mark Thomas wrote: On 09/03/2023 14:23, Christopher Schultz wrote: Mark, On 3/9/23 05:56, Mark Thomas wrote: Hi all, In the context of CVE-2023-24998 (performance issues for large numbers of uploaded parts), I have

Re: Reduce default for maxParameterCount

2023-03-14 Thread Mark Thomas
On 09/03/2023 14:23, Christopher Schultz wrote: Mark, On 3/9/23 05:56, Mark Thomas wrote: Hi all, In the context of CVE-2023-24998 (performance issues for large numbers of uploaded parts), I have been wondering about reducing the default value for maxParameterCount. The current default

Re: [tomcat] branch main updated: Support RFC 7616. Add support for multiple algorithms.

2023-03-14 Thread Mark Thomas
55ad7dbe19 Support RFC 7616. Add support for multiple algorithms. 55ad7dbe19 is described below commit 55ad7dbe196ba35dd16952701890d318e7926c02 Author: Mark Thomas AuthorDate: Fri Mar 3 17:58:05 2023 + Support RFC 7616. Add support for multiple algorithms. Thoughts on back-porting

Re: Buildbot failure in on tomcat-11.0.x

2023-03-14 Thread Mark Thomas
: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/112/builds/255 Blamelist: Mark Thomas Build Text: failed compile (failure) Status Detected: new failure Build Source Stamp: [branch main] 6c841c949b8b6a36a4318a3cbe21c2d345007a66 Steps: worker_preparation: 0 git: 0 shell: 0

Reduce default for maxParameterCount

2023-03-09 Thread Mark Thomas
Hi all, In the context of CVE-2023-24998 (performance issues for large numbers of uploaded parts), I have been wondering about reducing the default value for maxParameterCount. The current default for maxParameterCount is 10,000. It was set based on it being low enough to mitigate

Re: Connector Comparison in documentation - still needed?

2023-03-07 Thread Mark Thomas
On 07/03/2023 13:55, Christopher Schultz wrote: All, The "Connector Comparison" used to be an important read when choosing a connector: For the 8.5 and 9.0 releases: https://tomcat.apache.org/tomcat-8.5-doc/config/http.html#Connector_Comparison

Re: [tomcat] branch main updated: Align with spec

2023-03-07 Thread Mark Thomas
On 07/03/2023 08:24, Han Li wrote: Hi Mark,Remy and Konstatntin, Thank you for such detailed answers, I read all your reply in full. I read, and the reason for this commit is because of user feedback about a bug, see below: https://github.com/apache/tomcat/pull/595

Re: tomcat-native v2.0+ breaks unix domain socket support on java16-

2023-03-07 Thread Mark Thomas
On 07/03/2023 07:45, Rémy Maucherat wrote: On Tue, Mar 7, 2023 at 12:01 AM Graham Leggett wrote: Hi all, A while back I added unix domain socket support to tomcat-native, and patched tomcat to use it until java16 is available. Unfortunately unix domain socket support was removed from

Re: [tomcat] branch main updated: Fix BZ 66507 - Catalina version command not honoring JAVA_OPTS variable

2023-03-07 Thread Mark Thomas
On 07/03/2023 03:39, li...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. lihan pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new

Re: [tomcat] branch main updated: Align with spec

2023-03-07 Thread Mark Thomas
On 07/03/2023 07:14, Han Li wrote: On Mar 7, 2023, at 14:39, Konstantin Kolinko wrote: вт, 7 мар. 2023 г. в 09:17, mailto:li...@apache.org>>: This is an automated email from the ASF dual-hosted git repository. lihan pushed a commit to branch main in repository

Re: Native Windows installer builds

2023-03-06 Thread Mark Thomas
On 06/03/2023 17:01, Christopher Schultz wrote: All, I'm curious... how married are we to the idea of distributing installers for Windows operating systems? There are definitely users that use it so I think we need to provide something that installs Tomcat as a service. My understanding

[ANN] Apache Tomcat 11.0.0-M4 (alpha) available

2023-03-06 Thread Mark Thomas
The Apache Tomcat team announces the immediate availability of Apache Tomcat 11.0.0-M4 (alpha). Apache Tomcat 11 is an open source software implementation of the Jakarta Servlet, Jakarta Server Pages, Jakarta Expression Language, Jakarta WebSocket, Jakarta Authentication and Jakarta Annotations

[VOTE][RESULT] Release Apache Tomcat 11.0.0-M4

2023-03-06 Thread Mark Thomas
The following votes were cast: Binding: +1: lihan, markt, remm Non-binding: +1: Dimitris Soumis The vote therefore passes. Thanks to everyone who contributed to this release. Mark On 27/02/2023 20:32, Mark Thomas wrote: The proposed Apache Tomcat 11.0.0-M4 release is now available

Re: [tomcat] branch main updated: Improve JSON filter

2023-03-02 Thread Mark Thomas
On 02/03/2023 14:35, Rémy Maucherat wrote: On Thu, Mar 2, 2023 at 2:52 PM Mark Thomas wrote: On 02/03/2023 13:38, r...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. -private JSONFilter() { -// Utility class. Hide the default constructor

Re: [tomcat] branch main updated: Improve JSON filter

2023-03-02 Thread Mark Thomas
On 02/03/2023 13:38, r...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new

Re: [VOTE] Release Apache Tomcat 9.0.73

2023-03-01 Thread Mark Thomas
On 28/02/2023 20:03, Rémy Maucherat wrote: On Tue, Feb 28, 2023 at 6:35 PM Mark Thomas wrote: On 27/02/2023 15:52, Rémy Maucherat wrote: The proposed 9.0.73 release is: [ ] Broken - do not release [ ] Stable - go ahead and release as 9.0.73 Build is reproducible. Tests pass on Linux

Re: [VOTE] Release Apache Tomcat 8.5.87

2023-02-28 Thread Mark Thomas
On 27/02/2023 20:11, Christopher Schultz wrote: The proposed 8.5.87 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 8.5.87 (stable) Build is reproducible. Tests pass on Linux, Windows and MacOS (Intel and M1). Mark

Re: [VOTE] Release Apache Tomcat 9.0.73

2023-02-28 Thread Mark Thomas
On 27/02/2023 15:52, Rémy Maucherat wrote: The proposed 9.0.73 release is: [ ] Broken - do not release [ ] Stable - go ahead and release as 9.0.73 Build is reproducible. Tests pass on Linux, Windows and MacOs (Intel and M1). Mark

Re: [VOTE] Release Apache Tomcat 10.1.7

2023-02-28 Thread Mark Thomas
On 27/02/2023 20:56, Christopher Schultz wrote: The proposed 10.1.7 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 10.1.7 The binary releases are reproducible. The source releases are not reproducible without manual intervention. The tag includes an empty file

Re: [VOTE] Release Apache Tomcat 11.0.0-M4

2023-02-28 Thread Mark Thomas
On 27/02/2023 20:32, Mark Thomas wrote: The proposed 11.0.0-M4 release is: [ ] Broken - do not release [X] Alpha  - go ahead and release as 11.0.0-M4 Unit tests pass on Linux, Windows and MacOSX (Intel and M1) Mark

Re: [tomcat] branch 10.1.x updated: Have 'pre-release' indicate the the release is in progress.

2023-02-28 Thread Mark Thomas
On 28/02/2023 07:22, Rémy Maucherat wrote: wrote: On 2/27/23 16:09, Rémy Maucherat wrote: On Mon, Feb 27, 2023 at 9:41 PM Mark Thomas wrote: On 27/02/2023 20:36, schu...@apache.org wrote: Have 'pre-release' indicate the the release is in progress. This saves one more

Re: [tomcat] branch 10.1.x updated: Have 'pre-release' indicate the the release is in progress.

2023-02-27 Thread Mark Thomas
On 27/02/2023 20:36, schu...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. schultz pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push:

[VOTE] Release Apache Tomcat 11.0.0-M4

2023-02-27 Thread Mark Thomas
The proposed Apache Tomcat 11.0.0-M4 release is now available for voting. Apache Tomcat 11.0.0-M4 is a milestone release of the 11.0.x branch and has been made to provide users with early access to the new features in Apache Tomcat 11.0.x so that they may provide feedback. The notable changes

Re: Loom research

2023-02-27 Thread Mark Thomas
On 27/02/2023 18:02, Romain Manni-Bucau wrote:> Le lun. 27 févr. 2023 à 18:38, Mark Thomas a écrit : On 27/02/2023 17:09, Romain Manni-Bucau wrote: Hi, AFAIK loom or a standard thread pool are exactly the same except when you use loom you need to ensure you pass the contextual execu

Re: Loom research

2023-02-27 Thread Mark Thomas
<https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book <https://www.packtpub.com/application-development/java-ee-8-high-performance> Le lun

Loom research

2023-02-27 Thread Mark Thomas
FYI https://spring.io/blog/2023/02/27/web-applications-and-project-loom Written for $dayjob but the data is based purely on Tomcat and a trivial web application. I think this could prove useful when we need discuss what to do with the Loom module code. Mark

Re: [tomcat] branch main updated: Refactcor custom URL handler to use ServiceLoader

2023-02-27 Thread Mark Thomas
0782f0b919 Refactcor custom URL handler to use ServiceLoader 0782f0b919 is described below commit 0782f0b919b5131a9423c91333f7c557954336a3 Author: Mark Thomas AuthorDate: Mon Jan 23 14:56:29 2023 + Refactcor custom URL handler to use ServiceLoader Heads up. I am going to have to revert

Re: [tomcat] branch main updated: Replace with JDK 1.8 Integer::compareUnsigned(int, int).

2023-02-26 Thread Mark Thomas
On 26/02/2023 07:46, li...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. lihan pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new

Re: [tomcat] branch 10.1.x updated: Refactor to reduce native calls

2023-02-25 Thread Mark Thomas
ed to refs/heads/10.1.x by this push:   new 0064bc6933 Refactor to reduce native calls 0064bc6933 is described below commit 0064bc69334bb40e5fae381b5b1b3506b73bb044 Author: Mark Thomas AuthorDate: Fri Feb 24 14:59:43 2023 + Refactor to reduce native calls Thread.currentThread() i

[ANN] Apache Tomcat 11.0.0-M3 (alpha) available

2023-02-23 Thread Mark Thomas
The Apache Tomcat team announces the immediate availability of Apache Tomcat 11.0.0-M3 (alpha). Apache Tomcat 11 is an open source software implementation of the Jakarta Servlet, Jakarta Server Pages, Jakarta Expression Language, Jakarta WebSocket, Jakarta Authentication and Jakarta Annotations

[VOTE][RESULT] Release Apache Tomcat 11.0.0-M3

2023-02-23 Thread Mark Thomas
The following votes were cast: Binding: +1: isapir, markt, fschumacher, remm Non-binding: +1: lihan, Dimitris Soumis No other votes were cast. The release vote therefore passes. Mark - To unsubscribe, e-mail:

Re: [tomcat] 03/06: A sub-set of JavaBeans support that does not depend on java.beans

2023-02-22 Thread Mark Thomas
On 22/02/2023 19:26, ma...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 0d4b396392db0362a8f1bc6a80c4f60005114f09 Author: Mark Thomas AuthorDate

[SECURITY] CVE-2023-24998 Apache Tomcat - FileUpload DoS with excessive parts

2023-02-20 Thread Mark Thomas
Re-sending with corrected credit CVE-2023-24998 Apache Tomcat - FileUpload DoS with excessive parts Severity: Important Vendor: The Apache Software Foundation Versions Affected: Apache Tomcat 11.0.0-M1 Apache Tomcat 10.1.0-M1 to 10.1.4 Apache Tomcat 9.0.0-M1 to 9.0.70 Apache Tomcat 8.5.0 to

[SECURITY] CVE-2023-24998 Apache Tomcat - FileUpload DoS with excessive parts

2023-02-20 Thread Mark Thomas
CVE-2023-24998 Apache Tomcat - FileUpload DoS with excessive parts Severity: Important Vendor: The Apache Software Foundation Versions Affected: Apache Tomcat 11.0.0-M1 Apache Tomcat 10.1.0-M1 to 10.1.4 Apache Tomcat 9.0.0-M1 to 9.0.70 Apache Tomcat 8.5.0 to 8.5.84 Description: Apache Tomcat

Re: [VOTE] Release Apache Tomcat 8.5.86

2023-02-20 Thread Mark Thomas
On 18/02/2023 13:56, Christopher Schultz wrote: The proposed 8.5.86 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 8.5.86 (stable) The binary distributions are reproducible. The source distributions are not reproducible because the tag is missing the

Re: [VOTE] Release Apache Tomcat 10.1.6

2023-02-20 Thread Mark Thomas
You'll probably need to change the default ephemeral (dynamic in MS speak) port range to avoid issues with port exhaustion. I'm using: netsh int ipv4 set dynamicport tcp start=1025 num=64511 I suspect running out of ports is causing odd errors. Mark On 20/02/2023 13:16, Christopher

Re: [VOTE] Release Apache Tomcat 9.0.72

2023-02-20 Thread Mark Thomas
On 18/02/2023 09:44, Rémy Maucherat wrote: The proposed 9.0.72 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 9.0.72 Build is reproducible. Tests pass on Linux, Windows and MacOS (Intel and M1). Mark

Re: [VOTE] Release Apache Tomcat 10.1.6

2023-02-20 Thread Mark Thomas
On 20/02/2023 11:30, Felix Schumacher wrote: The source tar seem to be missing two files, that might be important:  res/META-INF/catalina.jar/services/java.net.spi.URLStreamHandlerProvider   res/META-INF/tomcat-embed-core.jar/services/java.net.spi.URLStreamHandlerProvider I see those files

Re: [VOTE] Release Apache Tomcat 10.1.6

2023-02-20 Thread Mark Thomas
On 19/02/2023 14:11, Christopher Schultz wrote: The proposed 10.1.6 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 10.1.6 Build is reproducible. Tests pass on Linux, Windows and MacOS (Intel and M1). Mark

Re: [tomcat] branch main updated: Many improvements.

2023-02-20 Thread Mark Thomas
On 18/02/2023 05:43, Han Li wrote: On Feb 17, 2023, at 17:17, Rémy Maucherat wrote: On Fri, Feb 17, 2023 at 4:32 AM wrote: -ciphers.removeAll(movedCiphers); +movedCiphers.forEach(ciphers::remove); Ok for some of them maybe, but I don't understand why one this is better.

Re: [VOTE] Release Apache Tomcat 10.1.6

2023-02-20 Thread Mark Thomas
On 19/02/2023 18:15, Igal Sapir wrote: I get a failure on TestImportHandlerStandardPackages on both Java 11 and Java 17. Any thoughts? Output below: Testsuite: jakarta.el.TestImportHandlerStandardPackages Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.319 sec That

Re: [VOTE] Release Apache Tomcat 11.0.0-M3

2023-02-20 Thread Mark Thomas
On 17/02/2023 18:18, Mark Thomas wrote: The proposed 11.0.0-M3 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 11.0.0-M3 Still haven't remembered to update that to Alpha Test pass on Linux, Windows and MacOS (Intel & M1).

[VOTE] Release Apache Tomcat 11.0.0-M3

2023-02-17 Thread Mark Thomas
The proposed Apache Tomcat 11.0.0-M3 release is now available for voting. Apache Tomcat 11.0.0-M3 is a milestone release of the 11.0.x branch and has been made to provide users with early access to the new features in Apache Tomcat 11.0.x so that they may provide feedback. The notable changes

Re: Test certs expired?

2023-02-17 Thread Mark Thomas
They have. I have a new set ready to commit. Just running the tests to make sure I didn't miss any. Mark On 17/02/2023 16:30, Rainer Jung wrote: I think the test certs in test/org/apache/tomcat/util/net just expired. At least I start to get failures with Caused by:

February release plans

2023-02-17 Thread Mark Thomas
Hi all, I wanted to provide an up dated on my plans for the February releases. The Tomcat Native releases are complete, the dependencies updated, open PRs and bugs reviewed and the translations updated. Tests are passing on Linux and MacOS but I am seeing (fairly) consistent failures on

Re: Query about support for OpenSSL 1.1.1

2023-02-15 Thread Mark Thomas
This is a question for the users list, not the dev list. Mark On 15/02/2023 08:24, Vivek Naruka (EXT-NSB) wrote: Hi Tomcat Support Team, There is new version of Openssl i.e. Openssl 3.0 available for which tomcat provide support in its newly released versions. We are using Openssl version

Re: Autocommit issue with JDK 1.8, Tomcat 9.0.60, ojdbc8.jar and Oracle DB 19c (19.14.0.0)

2023-02-15 Thread Mark Thomas
This question belongs on the users list, not the dev list. Mark On 15/02/2023 06:32, Promit Banik wrote: Hello everyone, Recently we have done an environment setup upgradation/migration as mentioned below for our application: JDK 1.7 ---> JDK 1.8 Tomcat 7.0.47 ---> Tomcat 9.0.60 (Also using

[ANN] Apache Tomcat Native 2.0.3 released

2023-02-13 Thread Mark Thomas
The Apache Tomcat team announces the immediate availability of Apache Tomcat Native 2.0.3 stable. The key features of this release are: - The binaries for Windows in this release have been built with OpenSSL 3.0.8 The 2.0.x branch is primarily intended for use with Tomcat 10.1.x or later

[ANN] Apache Tomcat Native 1.2.36 released

2023-02-13 Thread Mark Thomas
The Apache Tomcat team announces the immediate availability of Apache Tomcat Native 1.2.36 stable. The key features of this release are: - Update the version of OpenSSL used to create the binaries for Windows to OpenSSL 1.1.1t Please refer to the change log for the complete list of changes:

[VOTE][RESULT] Release Apache Tomcat Native 1.2.36

2023-02-13 Thread Mark Thomas
The following votes were cast: Binding: +1: schultz, remm, markt Non-binding: +1: Dimitris Soumis, Vasileios Mourikis No other votes were cast. The vote therefore passes. Thanks to everyone who contributed to this release. Mark

Re: [VOTE] Release Apache Tomcat Native 1.2.36

2023-02-13 Thread Mark Thomas
On 08/02/2023 16:43, Mark Thomas wrote: The Apache Tomcat Native 1.2.36 release is  [X] Stable, go ahead and release  [ ] Broken because of ... Builds on Linux, MacOS (M1), MacOS (Intel) and Windows. Tomcat 9.0.x tests pass on Windows with pre-built binary. Tomcat 9.0.x tests pass on Linux

[VOTE][RESULT] Release Apache Tomcat Native 2.0.3

2023-02-13 Thread Mark Thomas
The following votes were cast: Binding: +1: remm, markt, schultz Non-binding: +1: Dimitris Soumis, Vasileios Mourikis No other votes were cast. The vote therefore passes. Thanks to everyone who contributed to this release. Mark

Re: [VOTE] Release Apache Tomcat Native 2.0.3

2023-02-13 Thread Mark Thomas
On 08/02/2023 15:45, Mark Thomas wrote: The Apache Tomcat Native 2.0.3 release is  [X] Stable, go ahead and release  [ ] Broken because of ... Builds on Linux, MacOS (M1) MacOS (Intel) and Windows. Tomcat 11.0.x tests pass on Windows with pre-built binary. Tomcat 11.0.x tests pass on Linux

Re: [VOTE] Release Apache Tomcat Native 2.0.3

2023-02-10 Thread Mark Thomas
es.mk: No such file or directory make: *** No rule to make target `[redacted]/tomcat-native-2.0.3-src/native/build/rules.mk'.  Stop. The configure command appears to have succeeded but obviously something didn't work as expected. -chris On 2/8/23 10:45, Mark Thomas wrote: The key differences of

Re: [GitHub] [tomcat] Madfarm opened a new pull request, #585: Update README.md

2023-02-09 Thread Mark Thomas
9 Feb 2023 21:49:52 Madfarm (via GitHub) : Madfarm opened a new pull request, #585: URL: https://github.com/apache/tomcat/pull/585    You can deny this; I had to create a pull request for a school project -- This is an automated message from the Apache Git Service. To respond to the

[VOTE] Release Apache Tomcat Native 1.2.36

2023-02-08 Thread Mark Thomas
Version 1.2.36 includes the following changes compared to 1.2.35 - The windows binaries in this release have been built with OpenSSL 1.1.1t and APR 1.7.2 The proposed release artefacts can be found at [1], and the build was done using tag [2]. The Apache Tomcat Native 1.2.36 release is [ ]

[VOTE] Release Apache Tomcat Native 2.0.3

2023-02-08 Thread Mark Thomas
The key differences of version 2.0.3 compared to 2.0.2 are: - The windows binaries in this release have been built with OpenSSL 3.0.8 and APR 1.7.2 The 2.0.x branch is primarily intended for use with Tomcat 10.1.x but can be used with earlier versions as long as the APR/native connector is

Re: Regarding IDE configuration files

2023-02-04 Thread Mark Thomas
4 Feb 2023 04:17:29 Bailey Brownie : Hi all, Recently, when setting up Tomcat for development with the Eclipse IDE, I noticed that the configuration files that come with Tomcat had multiple hard-coded (and outdated) references to some dependencies. Sorry. That is probably me forgetting

Re: [tomcat] branch main updated: Restore ISE catching behavior

2023-02-02 Thread Mark Thomas
On 02/02/2023 09:26, r...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new

Re: [tomcat-native] branch main updated: Update recommended APR version to 1.7.1

2023-02-01 Thread Mark Thomas
On 01/02/2023 18:33, Rainer Jung wrote: APR 1.7.1 will be replaced by 1.7.2, because in 1.7.1 the tarball was rolled with a directory containing an RC verion in its name. So 1.7.2 will be the same source code as 1.7.1, but with a packaging failure fixed. The release is expected to happen

Re: [tomcat-native] branch 1.2.x updated: Update EOL info

2023-02-01 Thread Mark Thomas
On 01/02/2023 18:11, ma...@apache.org wrote: It is current anticipated that Tomcat Native releases will transition to 1.3.x at some point in the future when the minimum version will become OpenSSL 1.1.1 and APR 1.6.3. Given the various EOL dates, these minimum versions are unlikely to

Re: Issues playing around with digest.sh

2023-01-31 Thread Mark Thomas
On 31/01/2023 18:51, Christopher Schultz wrote: $ digest.sh -a 'PBKDF2' 'secret' If we get (swallowed) errors while trying to find out which CredentialHandler should performing the password mutation, then we just always use the last one we tried. That effectively changes the default

February release round

2023-01-31 Thread Mark Thomas
Hi all, As I started to think about preparing for the February release round, I received the notification from the OpenSSL project that they have a security release planned for a week today. That security release may (or may not) trigger a Tomcat Native release. I was wondering whether to

Re: [tomcat] branch 9.0.x updated: Fix BZ 66455 - avoid ClassCastException when processing window update

2023-01-30 Thread Mark Thomas
On 30/01/2023 21:03, Christopher Schultz wrote: Is the default window size really 65535 bytes (64k - 1)? That would be very unusual (is this some kind of spec-mandated window size? still seems weird). It seems more likely that it is a full 64k bytes and that the max index into that array

Re: [tomcat] 05/05: Redirect no longer required for root mapping

2023-01-28 Thread Mark Thomas
On 27/01/2023 16:19, Mark Thomas wrote: On 27/01/2023 14:11, Rémy Maucherat wrote: On Fri, Jan 27, 2023 at 2:51 PM wrote: This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git

Re: [tomcat] 05/05: Redirect no longer required for root mapping

2023-01-27 Thread Mark Thomas
ce8621750e4f74229bffa7e42e648523b91b91de Author: Mark Thomas AuthorDate: Fri Jan 27 12:57:39 2023 + Redirect no longer required for root mapping But this would break directory listing for the webapp root right ? In the case where a servlet is mapped to the context root, yes. There would be no way to pass a request

Re: JDK 20 Rampdown Phase 2 & JMX Heads-up

2023-01-25 Thread Mark Thomas
On 25/01/2023 05:21, David Delabassee wrote: ## Heads-up - JDK 21: JMX Subject Delegation & Fine-grained Security Deprecation JMX has some features that rely on Security Manager APIs which are deprecated for removal (see JEP 411 [4]). These features are "Subject Delegation" and

Re: [tomcat] 02/02: LongAdder is a better choice for statistics collection

2023-01-24 Thread Mark Thomas
F dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit a7bf4d84f753d69acb66f5e45f5bc767a1d55e49 Author: Mark Thomas AuthorDate: Tue Jan 24 12:22:01 2023 + LongAdder is a better choice for statistics col

[ANN] Apache Tomcat 10.1.5 available

2023-01-23 Thread Mark Thomas
The Apache Tomcat team announces the immediate availability of Apache Tomcat 10.1.5. Apache Tomcat 10 is an open source software implementation of the Jakarta Servlet, Jakarta Server Pages, Jakarta Expression Language, Jakarta WebSocket, Jakarta Authentication and Jakarta Annotations

Re: [VOTE][RESULT] Release Apache Tomcat 10.1.5

2023-01-23 Thread Mark Thomas
for your cooperation. -Original Message- From: Mark Thomas Sent: Friday, January 13, 2023 7:48 AM To: dev@tomcat.apache.org Subject: [VOTE][RESULT] Release Apache Tomcat 10.1.5 The following votes were cast: Binding: +1: markt, remm, jfclere +0: schultz Non-binding: +1: lihan

Java 17, MacOS and Apple silicon

2023-01-23 Thread Mark Thomas
Hi all, Having switched to Java 17 on my $work laptop (MacOS, Apple silicon), I noticed the unit tests were significantly slower. A quick test with 11.0.0-M1 with Java 11 vs Java 17 indicated the issue was related to Java 17. I haven't dug into it yet. I plan to do that once I have

Re: RFC 9218 priorities - back-port?

2023-01-23 Thread Mark Thomas
On 21/01/2023 14:33, Christopher Schultz wrote: Mark, On 1/20/23 14:11, Mark Thomas wrote: Hi all, You will have seen I've just committed the updated priorities implementation for HTTP/2. The open question is whether or not we want to back-port this and if so, how far. Thoughts

[VOTE][RESULT] Release Apache Tomcat 11.0.0-M2

2023-01-23 Thread Mark Thomas
The following votes were cast: Binding: +1: markt, remm Non-binding: +1: lihan The vote therefore does not pass. I will update the changelog accordingly. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For

RFC 9218 priorities - back-port?

2023-01-20 Thread Mark Thomas
Hi all, You will have seen I've just committed the updated priorities implementation for HTTP/2. The open question is whether or not we want to back-port this and if so, how far. Thoughts? Mark - To unsubscribe, e-mail:

Re: [tomcat] branch main updated: Update the default HEAD response to exclude payload headers

2023-01-20 Thread Mark Thomas
On 20/01/2023 09:39, Konstantin Kolinko wrote: чт, 19 янв. 2023 г. в 23:41, : changelog.xml index 7570715faa..9fd2f679a3 100644 --- a/webapps/docs/changelog.xml +++ b/webapps/docs/changelog.xml @@ -125,6 +125,10 @@ Implement the new Servlet API methods for setting character encodings

Checkstyle, Javadoc and automatic formatting

2023-01-19 Thread Mark Thomas
Hi all, Ever since the first CheckStyle rules were added, I have been looking at the options for using my IDE (Eclipse) to fix the code so it meets the rules. The results until today have been mixed. Some stuff gets fixed but other stuff gets broken. Today, however, I made progress. I think

Re: [VOTE] Release Apache Tomcat 11.0.0-M2

2023-01-19 Thread Mark Thomas
Ping. The VOTE has been open for 10 days. I'll leave it a few more days. Mark On 13/01/2023 13:48, Mark Thomas wrote: Ping. This vote is current one PMV vote short of being bale to release. Mark On 09/01/2023 18:20, Mark Thomas wrote: The proposed Apache Tomcat 11.0.0-M2 release is now

Re: Tomcat 11 - minimum Java version

2023-01-19 Thread Mark Thomas
as there is no driver to increase that at this time Mark On 11/01/2023 11:23, Mark Thomas wrote: Hi all, The Jakarta EE platform group has announced that the minimum Java version for Jakarta EE 11 will be Java 21. [1] Given that the Java SecurityManager was deprecated in Java 17 and planned

Re: [tomcat] branch main updated: Implement new methods for setting character encoding

2023-01-18 Thread Mark Thomas
b1008bf815 Implement new methods for setting character encoding b1008bf815 is described below commit b1008bf81591d856368fdf5aa9a693e01bfdad3d Author: Mark Thomas AuthorDate: Tue Jan 17 16:55:57 2023 + Implement new methods for setting character encoding FYI I am currently exploring options

Re: Categorizing javadoc errors

2023-01-17 Thread Mark Thomas
On 17/01/2023 14:48, Rémy Maucherat wrote: Hi, In the past, javadoc problems were fixed. I'm glad Mark switched validation to checkstyle since I no longer trust the javadoc developers for doing the right thing after the Java 18 changes. Also it allows easy configuration of what is important and

Re: [tomcat] branch 10.1.x updated: Disable test for Java 16 onwards since performance is comparable

2023-01-16 Thread Mark Thomas
is described below commit 1058eed2b6e94f09b8f3ecdcac3be634baa01f76 Author: Mark Thomas AuthorDate: Mon Nov 14 11:42:53 2022 + Disable test for Java 16 onwards since performance is comparable ---   test/org/apache/tomcat/util/buf/TestMessageBytes.java | 9 -   1 file changed, 8 insertions

Re: [VOTE] Release Apache Tomcat 11.0.0-M2

2023-01-13 Thread Mark Thomas
Ping. This vote is current one PMV vote short of being bale to release. Mark On 09/01/2023 18:20, Mark Thomas wrote: The proposed Apache Tomcat 11.0.0-M2 release is now available for voting. Apache Tomcat 11.0.0-M2 is a milestone release of the 11.0.x branch and has been made to provide

[VOTE][RESULT] Release Apache Tomcat 10.1.5

2023-01-13 Thread Mark Thomas
The following votes were cast: Binding: +1: markt, remm, jfclere +0: schultz Non-binding: +1: lihan The vote therefore passes. Thanks to everyone who contributed to this release. Mark - To unsubscribe, e-mail:

Re: Buildbot failure in on tomcat-11.0.x

2023-01-12 Thread Mark Thomas
On 12/01/2023 22:16, Mark Thomas wrote: On 12/01/2023 20:01, build...@apache.org wrote: Build status: BUILD FAILED: failed compile (failure) Worker used: bb2_worker2_ubuntu URL: https://ci2.apache.org/#builders/112/builds/115 Blamelist: Mark Thomas Build Text: failed compile (failure) Status

Re: Buildbot failure in on tomcat-11.0.x

2023-01-12 Thread Mark Thomas
On 12/01/2023 20:01, build...@apache.org wrote: Build status: BUILD FAILED: failed compile (failure) Worker used: bb2_worker2_ubuntu URL: https://ci2.apache.org/#builders/112/builds/115 Blamelist: Mark Thomas Build Text: failed compile (failure) Status Detected: new failure Build Source Stamp

Re: [VOTE] Release Apache Tomcat 8.5.85 (round 2)

2023-01-12 Thread Mark Thomas
On 12/01/2023 20:17, Christopher Schultz wrote: The proposed 8.5.85 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 8.5.85 (stable) Unit tests pass on Linux. Mark - To unsubscribe, e-mail:

Re: [VOTE] Release Apache Tomcat 8.5.85 (round 2)

2023-01-12 Thread Mark Thomas
On 12/01/2023 20:17, Christopher Schultz wrote: The proposed 8.5.85 release is: [ ] Broken - do not release [ ] Stable - go ahead and release as 8.5.85 (stable) Still running the unit tests but I wanted to confirm that I have repeated the build using the new 8.5.85 tag and have confirmed that

Re: [VOTE] Release Apache Tomcat 8.5.85

2023-01-12 Thread Mark Thomas
On 12/01/2023 19:01, Christopher Schultz wrote: It looks like the Release Process document should include this: --- Create the tag (Do existing tag stuff, up through but not including the "commit" step) * Run a release build (ant release) * git add res/install-win/tomcat-installer.exe.sig

Re: [VOTE] Release Apache Tomcat 8.5.85

2023-01-12 Thread Mark Thomas
Something like: git checkout 8.5.85 git add ... git commit - "Update 8.5.85 tag to include signature files" git tag -d 8.5.85 git push --delete origin 8.5.85 git tag 8.5.85 git push origin 8.5.85 ? Mark On 12/01/2023 18:51, Christopher Schultz wrote: Mark, On 1/11/23 14:45, M

Re: CI, Java 17 and Javadoc

2023-01-12 Thread Mark Thomas
On 12/01/2023 13:41, Rémy Maucherat wrote: On Thu, Jan 12, 2023 at 1:19 PM Mark Thomas wrote: I tried switching the CI over to use Java 17 last night. This exposed an unexpected Javadoc behaviour that is currently breaking the 9.0.x and 8.5.x builds. Ant is configured to run Javadoc

CI, Java 17 and Javadoc

2023-01-12 Thread Mark Thomas
I tried switching the CI over to use Java 17 last night. This exposed an unexpected Javadoc behaviour that is currently breaking the 9.0.x and 8.5.x builds. Ant is configured to run Javadoc with failonwarning="true" When running the Javadoc task with Java 17: - if source="11" (Tomcat 10.1.x

Re: SecurityManager removal

2023-01-12 Thread Mark Thomas
On 12/01/2023 09:23, Rémy Maucherat wrote: On Thu, Jan 12, 2023 at 10:12 AM Mark Thomas wrote: Hi all, As you will have seen I'm starting to work on removing references to the SecurityManager. Doing this has raised a couple of questions about related features. If there is no SecurityManager

SecurityManager removal

2023-01-12 Thread Mark Thomas
Hi all, As you will have seen I'm starting to work on removing references to the SecurityManager. Doing this has raised a couple of questions about related features. If there is no SecurityManager then everything deployed to Tomcat has to be assumed to be trusted. Or Tomcat has to be run in

Re: Tomcat 11 - minimum Java version

2023-01-12 Thread Mark Thomas
my TODO list (somewhere near the middle at the moment). Mark Rémy Le mer. 11 janv. 2023 à 21:41, Mark Thomas a écrit : On 11/01/2023 20:15, Michael Osipov wrote: Even if not, there is another problem with that: When you build with Java 17, that build cannot be reproduced on Java 11 o

Re: Tomcat 11 - minimum Java version

2023-01-11 Thread Mark Thomas
On 11/01/2023 20:15, Michael Osipov wrote: Even if not, there is another problem with that: When you build with Java 17, that build cannot be reproduced on Java 11 or 8 because class file content will be different. Experience in the Tomcat project says otherwise. We can already reproduce

  1   2   3   4   5   6   7   8   9   10   >