Re: [VOTE] Release Apache Tomcat 9.0.27

2019-10-08 Thread Martin Grigorov
Hi,

On Mon, Oct 7, 2019 at 2:51 PM Mark Thomas  wrote:

> The proposed Apache Tomcat 9.0.27 release is now available for voting.
>
> The major changes compared to the 9.0.26 release are:
>
> - Update to Commons Daemon 1.2.2 to pick up the fix for a regression in
>   Commons Daemon 1.2.0 and 1.2.1 that triggered a crash on startup when
>   running on a Windows OS that had not been fully updated.
>
> - Fix some edge cases with NIO2 and TLS that could has a request to
>   hang.
>
> - Fix a memory leak introduced by the HTTP/2 timeout refactoring in
>   9.0.23 that could occur when HTTP/2 or WebSocket was used.
>
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat9/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.27/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1233/
> The tag is:
> https://github.com/apache/tomcat/tree/9.0.27
>
>
> The proposed 9.0.27 release is:
> [ ] Broken - do not release
> [ X ] Stable - go ahead and release as 9.0.27
>

Regards,
Martin


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 8.5.45

2019-08-21 Thread Martin Grigorov
Hi,

On Thu, Aug 15, 2019 at 1:48 AM Mark Thomas  wrote:

> The proposed Apache Tomcat 8.5.45 release is now available for voting.
>
> The major changes compared to the 8.5.43 release are:
>
> - Expand the HTTP/2 excessive overhead protection to cover various forms
>   of abusive client behaviour and close the connection if any such
>   behaviour is detected.
>
> - Security improvements to the Windows installer including a change in
>   the default user from Local System to Local Service.
>
> - Improve handling of invalid requests so that 400 responses are
>   returned to the client rather than 500 responses.
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat85/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.45/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1228/
>
> The tag is:
> https://github.com/apache/tomcat/tree/8.5.45
> 46d444a14cdac3e7e1f011a02cbdac9e5a80631c
>
> The proposed 8.5.45 release is:
> [ ] Broken - do not release
> [ X ] Stable - go ahead and release as 8.5.45
>

Regards,
Martin


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 9.0.24

2019-08-15 Thread Martin Grigorov
On Thu, Aug 15, 2019 at 12:45 AM Mark Thomas  wrote:

> The proposed Apache Tomcat 9.0.24 release is now available for voting.
>
> The major changes compared to the 9.0.22 release are:
>
> - Expand Graal native image support to include JNDI, JSPs and JULI
>
> - Expand the HTTP/2 excessive overhead protection to cover various forms
>   of abusive client behaviour and close the connection if any such
>   behaviour is detected.
>
> - Security improvements to the Windows installer including a change in
>   the default user from Local System to Local Service.
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat9/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.24/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1227/
> The tag is:
> https://github.com/apache/tomcat/tree/9.0.24
>
>
> The proposed 9.0.24 release is:
> [ ] Broken - do not release
> [ X ] Stable - go ahead and release as 9.0.24
>

Regards,
Martin


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 9.0.23

2019-08-14 Thread Martin Grigorov
Hi,

On Wed, Aug 14, 2019 at 2:57 PM Mark Thomas  wrote:

> The proposed Apache Tomcat 9.0.23 release is now available for voting.
>
> The major changes compared to the 9.0.22 release are:
>
> - Various improvements to the Kubernetes cluster membership service
>
> - Expand the HTTP/2 excessive overhead protection to cover various forms
>   of abusive client behaviour and close the connection if any such
>   behaviour is detected.
>
> - Security improvements to the Windows installer including a change in
>   the default user from Local System to Local Service.
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat9/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.23/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1225/
> The tag is:
> https://github.com/apache/tomcat/tree/9.0.23
> bd48c597e3cb280d73d9c9279babcaf75b6879c0
>
> The proposed 9.0.23 release is:
> [ ] Broken - do not release
> [ X ] Stable - go ahead and release as 9.0.23
>
>
Regards,
Martin


> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 8.5.42

2019-06-06 Thread Martin Grigorov
Hi,

On Wed, Jun 5, 2019 at 12:06 AM Mark Thomas  wrote:

> The proposed Apache Tomcat 8.5.42 release is now available for voting.
>
> The major changes compared to the 8.5.41 release are:
>
> - Fix various concurrency and stability issues for HTTP/2.
>
> - Add support for same-site cookie attribute. Patch provided by John
>   Kelly.
>
> - Add an option to sort directory listings provided by the Default
>   Servlet.
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat85/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.42/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1214/
>
> The tag is:
> https://github.com/apache/tomcat/tree/8.5.42
> 00b711f6af57e043bf4d5d64dbc1617970a54d69
>
>
> The proposed 8.5.42 release is:
> [ ] Broken - do not release
> [ X ] Stable - go ahead and release as 8.5.42
>

Regards,
Martin


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 9.0.21

2019-06-06 Thread Martin Grigorov
Hi,

On Tue, Jun 4, 2019 at 11:50 PM Mark Thomas  wrote:

> The proposed Apache Tomcat 9.0.21 release is now available for voting.
>
> The major changes compared to the 9.0.20 release are:
>
> - Fix various concurrency and stability issues for HTTP/2.
>
> - Add support for same-site cookie attribute. Patch provided by John
>   Kelly.
>
> - Add an option to sort directory listings provided by the Default
>   Servlet.
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat9/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.21/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1213/
> The tag is:
> https://github.com/apache/tomcat/tree/9.0.21
> 5dd82367de857318b8a384c07c4414e5d55cc975
>
> The proposed 9.0.21 release is:
> [ ] Broken - do not release
> [ X ] Stable - go ahead and release as 9.0.21
>

Regards,
Martin


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: Micro-optimizations

2019-05-08 Thread Martin Grigorov
Hi,

On Wed, May 8, 2019 at 7:16 PM Christopher Schultz <
ch...@christopherschultz.net> wrote:

> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA256
>
> All,
>
> While working on the sort-file-listing enhancement over the weekend, I
> looked in the Tomcat code to see if we already had a method to split a
> string by a single character. The closest method I found was
>

Since few years java.lang.String#split(String) is optimized to not use
Regex when the following condition passes:

if (((regex.value.length == 1 &&
 ".$|()[{^?*+\\".indexOf(ch = regex.charAt(0)) == -1) ||
 (regex.length() == 2 &&
  regex.charAt(0) == '\\' &&
  (((ch = regex.charAt(1))-'0')|('9'-ch)) < 0 &&
  ((ch-'a')|('z'-ch)) < 0 &&
  ((ch-'A')|('Z'-ch)) < 0)) &&
(ch < Character.MIN_HIGH_SURROGATE ||
 ch > Character.MAX_LOW_SURROGATE))
{

i.e. in many cases it is already fast enough.


> org.pache.jasper.compiler.JspUtil which splits on a string, so I
> rejected it as being a bit too general-purpose for my needs.
>
> But it got me looking into the implementation of the method, and it
> looks a little sketchy.
>
> First, it uses a java.util.Vector. Yep, a Vector. Remember those?
> Synchronized everything? The Vector is not used outside of the method
> at all -- it's just local and temporary. So, the obvious conclusion is
> that it should be changed to ArrayList, right?
>
> But, modern JVMs are fairly good at (a) processing contention-less
> locks more quickly and (b) identifying objects which cannot possibly
> have lock-contention and simply skipping the locking.
>
> What's the right move in these cases? Should we change Vector ->
> ArrayList and "help-out" the compiler and runtime, or should we leave
> the code alone because "it's fine"?
>
> Similar arguments can be made for using StringBuilder over
> StringBuffer, etc.
>
> WDYT?
>
> - -chris
> -BEGIN PGP SIGNATURE-
> Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/
>
> iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlzTAMcACgkQHPApP6U8
> pFjEOQ//SpbOVCErJu8SCue+RagRp0Z0PsAwbquf2z4NuMsPZVST66fcjE7QY7aI
> 9whVdUBauxNiUCwMUOkgV8g8IGBB8KoWyhyIkTWCZuh+cwan6+5aKesE5UcUdYW5
> Xg93cqB4oGUWsR1YaEWEdycBObCTcXx/oHTq26/rXZvrGDHGU7rrGGOgTqO4TETU
> 6xvME86xTaImrBYIrnSUTo2S3QyPbqsoOOzEWinyW75cvR6xFw4iNNRfgzHIlb8f
> EIUjCqHasm4qAcxQ+t0DIoeVbWvcLpX49UMNyXP5Wt2frOjeTzpx4ErFrNXsAlQd
> JYoNgo50nAYNwxAsnBbZCrqSkaFO89I+nj7Tq9WDovOTF17CyMMaYtJiBe/ocTNv
> 25JmldlsM/wFY+ol9PQz9UmfzOHCcKGWEV4DcKaro6aTBzhELGYHpRh3z+ZNNuHD
> zkbJPRZFDZ4XC9dwRSfm0DUbIsYP2peBp3z7/1hWm+lnK6NIAZQQh0TzJ/cIliKw
> 6uWvCesERD1GyQosqoL0h9MHSckGpTSfbk+iI6MZtEwQc3AH4C27fm6MpfAc8YQU
> sr0jf2EdgzrC990jazPZcRbpwT8Eifc5kF6QgkbiockkqC/Zr28awL7vY2m5Szg9
> n2scZoWUAnkGM8k0x3sFM4DZpthjUGVe78ZsBnJkKX4Q5LAnAYQ=
> =U4Jd
> -END PGP SIGNATURE-
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: Finally getting around to switching to Git

2019-04-23 Thread Martin Grigorov
On Tue, Apr 23, 2019, 17:29 Christopher Schultz <
ch...@christopherschultz.net> wrote:

> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA256
>
> Rémy,
>
> On 4/23/19 10:07, Rémy Maucherat wrote:
> > On Tue, Apr 23, 2019 at 3:54 PM Christopher Schultz <
> > ch...@christopherschultz.net> wrote:
> >
> > All,
> >
> > I haven't updated my local working copies of Tomcat source since
> > the move to Git. I'm going to do that, now, and I'm looking for
> > advice.
> >
> > Specifically, which repo is "better" -- gitbox or GitHub? I'm
> > guessing the its all go to the same place eventually. Should
> > committers use gitbox for direct-commits? If I use GitHub, will my
> > commits require some other review? Do I have to link my GitHub
> > account with my ASF LDAP id? Is one of them reliably faster?
> >
> >
> >> I use github personally. No commit review is required (but for
> >> example I used a PR for larger NIO changes, although in the end I
> >> didn't really get any feedback).
> >
> >> Setting up the account is needed. I failed to do it, and Mark
> >> told me I needed three green ticks there:
> >> https://gitbox.apache.org/setup/
> Thanks. Looks like I'm not a part of the ASF-org on GitHub.
>
> Anyone with the Karma to do so, can I be added to ASF-org on GitHub?
> My GitHub username is ChristopherSchultz.
>

Go to https://id.apache.org and enter your Github ID there.


> - -chris
> -BEGIN PGP SIGNATURE-
> Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/
>
> iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAly/ISUACgkQHPApP6U8
> pFgFrQ/8DeucBQTlxJ4TVKVZIBbR5yqq7KoOqaEH3UWsZ4hFdudmWsGZoV+2zkbL
> NVaSJPaAGSu7uA2xH8dCeg/151V4PKBlbvV/Q00xiMF6cC58skneNurOdysJIyuX
> UdaUgLVu9juzRrXk4MnedenXFEJGGq7hVo+7APVKfmWju38Zut3iCpAzU8YNAaa1
> alKE0ZXopLWiBh07oTHIea7+fMdlxucgwPbcg3a4QmSR1sy8mH/qIwbSiWk+irWT
> EiFJKst7E13qAb1Zi3KuOtYny06jZWyTW3Jo8EzWRAHkMUUKEpG1WkXcl2gLw1qz
> IQAVXjIUT2rfCQK3bcdmwvhriM7tWAfaK4NETlxu77QgoSRuA0+DbZgvHIP73FRg
> MK/EORN15d+pQiB7ez//qwlHSm11+nJALynkWRhYb6q9LvNaq2kN6ympyiAch3PO
> bm4bj8gbXSgquSHNMvxcw3dLNjL9yySh9vJ17WBbkunLTW9dRjuuMYIXwTtPRB34
> lSfeZZP1iorBivbZeidS3WBUDXNXy0U9d/bFrJWfK25YR+2LqolIkokKXMx9H/MC
> KjaqFqn/uGBjLxjbLNEfAh/KksTR7zc2XfQTIXCJMyQnJvamuhw64BAinrOraUjS
> MdVCXfYWcfkZoHzpLl9svgVUX3GtptxoCxUCgMpih9akyuVLNOU=
> =VMk3
> -END PGP SIGNATURE-
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: Git migration read for testing

2019-02-26 Thread Martin Grigorov
Hi,

On Tue, Feb 26, 2019 at 2:33 PM Mark Thomas  wrote:

> All,
>
> https://github.com/apache/tomcat
>
> is now ready for testing.
>
> It should contain:
> branches
> - master (9.0.x)
> - 8.5.x
> - 7.0.x
>
> Tags:
> - one for each 7.0.x, 8.5.x and 9.0.x release
>
> Tags have all been renamed to follow a a.b.c-MODIFIERn format for
> version number where modifier is RC or M.
>
> The repository is probably read/write for all committers now but please
> refrain from making any changes until we confirm that all is well.
>
> If you have some time available now, please test this new repository and
> report and questions or concerns to this thread.
>

I've just created a new branch, committed an empty change and removed the
branch.
All seems to work.
I haven't received any email notifications though.

Martin


>
> Assuming no issues are discovered, I'd like to formally move over to git
> later today.
>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Migrate to git

2019-02-21 Thread Martin Grigorov
On Thu, Feb 21, 2019, 18:13 Mark Thomas  wrote:

> This is a VOTE to migrate the primary source code repository for Apache
> Tomcat 9.0.x, 8.5.x and 7.0.x from svn to git.
>
> The migration will be performed as per:
> https://cwiki.apache.org/confluence/display/TOMCAT/Git+migration
>
> with the following changes:
> - 8.0.x will not be migrated
> - the tag name format will be changed from "TOMCAT_9_0_5" to "9.0.5"
> - the branches will be named master, 8.5.x and 7.0.x
>
> The proposed date (subject to Infra agreement) for the migration is 26
> Feb 2018.
>
> The migration process will be:
> - Make svn read only for trunk, 8.5.x and 7.0.x
> - Turn off the svn->git replication for trunk, 8.5.x and 7.0.x
> - Make git://git.apache.org/tomcat.git read/write for me only
> - Perform the migration as set out in the wiki with the modifications
>   described above
> - Check the migration
> - Make git://git.apache.org/tomcat.git read/write for all committers
>   (Note: This automatically makes https://github.com/apache/tomcat
>read/write as well)
>
> The critical work is done at this point. The following tasks are more
> clean-up and may end up being spread over several days.
>
> - Confirm there are no open PRs for https://github.com/apache/tomcat85
>   and then delete it and git://git.apache.org/tomcat85.git
> - Confirm there are no open PRs for https://github.com/apache/tomcat70
>   and then delete it and git://git.apache.org/tomcat70.git
> - Update the CI systems to pull the source from git
> - Create /source.html and replace /svn.html with a redirect to
>   /source.html
> - Update migration guide to pull diffs from gitweb
> - Update Tomcat Native to pull in source from git hash
> - Fix anything else we have forgotten about.
>
> If anything goes wrong and we can't fix is easily, the fallback is to
> make svn read-write and go back to using svn while we clean up the git
> side of things, figure out what went wrong and come up with a better
> migration plan.
>
> [ X ] +1 Go ahead with the migration
> [ ] -1 Postpone the migration because...
>

Regards,
Martin


> The vote will be open for at least 72 hours.
>
> Mark
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: System properties: JVM launch versus catalina.properties

2018-12-29 Thread Martin Grigorov
Hi Igal,

I am not sure this is a good idea.
Usually .properties.default files are used as sample files. And one has to
rename them to .properties to make use of them.
IMO your suggestion will be confusing for people used to this approach.

Regards,
Martin

On Sat, Dec 29, 2018 at 2:11 AM Igal Sapir  wrote:

> Chris,
>
> On 12/28/2018 7:07 AM, Christopher Schultz wrote:
>
> > -BEGIN PGP SIGNED MESSAGE-
> > Hash: SHA256
> >
> > All,
> >
> > Someone asked this question on SO recently:
> > https://stackoverflow.com/questions/53921375/tomcat-overriding-catalina-
> > properties-from-commandline/53952396#53952396
> >
> > TLDR: this person wants to set system properties in
> > catalina.properties but be able to "override" those from the command-lin
> > e.
> >
> > The fix would be trivial: just don't clobber the value of any existing
> > system property in CatalinaProperties when copying the properties from
> > the file to the live system properties.
> >
> > I'm wondering if anyone can think of any security issues with doing
> > that. Presumably, if a user can launch Tomcat, they can set system
> > properties. However, it's possible that a user might have the right to
> > *launch* Tomcat, but not reconfigure it (e.g. read-only
> > catalina.properties).
> >
> > That could easily be solved by using a catalina.properties-only
> > setting like "catalina.properties.noclobber.system.properties=true" or
> > something like that.
>
> How about adding an optional file named "catalina.properties.default",
> which will be read before "catalina.properties", and whose values will
> be set only if no corresponding keys are set in System properties?  e.g.
>
> # file catalina.properties.default
> tomcat.port=8080
>
> Can be overridden with `-Dtomcat.properties=`, but
>
> # file catalina.properties
> tomcat.host=localhost
>
> Can not be overridden, as it is now.
>
> Users will know that if they place a value in the default file, it could
> be overridden with a System property.
>
> This should be fairly simple and I can implement it if it sounds like a
> good idea.
>
> Igal
>
>
>
>
>
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: Cloud clustering support using Kubernetes

2018-10-04 Thread Martin Grigorov
Hi,

I cannot find the original mail now (I think it was sent by Bertrand
Delacretaz two years ago) but json.org's licence is not ASL2 compatible.
For that reason several Apache projects (Apache Wicket one of them) had to
migrate to something else.
Wicket choose https://github.com/tdunning/open-json and then improved it to
https://github.com/openjson/openjson. The APIs are almost identical to make
the transition easier.

On Thu, Oct 4, 2018 at 12:27 PM Rémy Maucherat  wrote:

> On Wed, Oct 3, 2018 at 10:27 PM Christopher Schultz <
> ch...@christopherschultz.net> wrote:
>
> > -BEGIN PGP SIGNED MESSAGE-
> > Hash: SHA256
> >
> > Rémy,
> >
> > On 10/3/18 09:48, Rémy Maucherat wrote:
> > > Hi,
> > >
> > > As I talked about during the latest TomcatCon (and the previous one
> > > in London actually ...), there's a cloud aware cluster members
> > > provider that can be contributed to Tomcat.
> > >
> > > The current code is here:
> > > https://github.com/rmaucher/tomcat-in-the-cloud It uses Kubernetes
> > > to retrieve the members of a cluster, rather than multicast (which
> > > isn't available) or static (which is well ... static) member
> > > providers.
> > >
> > > Credits: Maxime Beck and JGroups did the initial code Keiichi
> > > Fujino explained how to refactor it to fit in the Catalina cluster
> > > API and I refactored it as he told me to
> > >
> > > Problems: Only does Kubernetes for now (which is likely ok since
> > > it's now widely available) JSON parser dependency (org.json) that
> > > is likely not ok to have as is in the lib folder (solutions:
> > > package renaming using a script or include json code in Tomcat)
> >
> > Solr uses this JSON parser which is quite fast, although the API is a
> > little little awkward because of it:
> >
> > https://github.com/yonik/noggit
> >
> > AL2 license
> >
> > I'm not sure it's necessary to have a "streaming JSON" parser as
> > opposed to a more "traditional" one where the whole JSON object is
> > converted into objects before the client code can do anything with them.
> >
>
> The json from Kube is simple.
>
> The org.json parser is very dom like, this event based one looks good I
> guess. Is it worth changing my code ? Given the parser size, event based
> nature and the presence of a "writer", this noggit could be worth package
> renaming (IMO for this one that's the only viable strategy as I'm not sure
> there's much maintenance or use going on - maybe it's bug free ;) ). After
> all, we might need/use more json handling in Tomcat in the future (right
> ?).
>
> Rémy
>


Re: Message files encoding

2018-08-01 Thread Martin Grigorov
On Wed, Aug 1, 2018 at 2:56 PM Emmanuel Bourg  wrote:

> Le 01/08/2018 à 13:16, Martin Grigorov a écrit :
>
> > What about using the XML version of Java Properties ?
> >
> https://docs.oracle.com/javase/7/docs/api/java/util/Properties.html#loadFromXML(java.io.InputStream)
> > This way the encoding could be specified in the XML file itself and there
> > is no need to use native2ascii at all.
>
> I'm not really fond of XML properties files, the plain text format is
> more compact and easier to browse in my opinion. XML files are
> interesting when structured with different levels, but properties files
> even in XML format have a flat layout.
>

I hope the following changes your mind:

1) Bulgarian translations in XML format:
https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/Application_bg.properties.xml
2) Czech translation in ascii format:
https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/Application_cs.properties

I can easily read 1) (bulgarian, is my native lang).
I know some Czech but the \u0xyz makes it really hard / imposible to read
it as is.


>
> Emmanuel Bourg
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: Message files encoding

2018-08-01 Thread Martin Grigorov
Hi,

On Wed, Aug 1, 2018 at 2:08 PM Mark Thomas  wrote:

> On 01/08/18 12:03, Emmanuel Bourg wrote:
> > Hi all,
> >
> > The LocalString*.properties files are ASCII encoded which renders the
> > modification of the non-english messages rather inconvenient.
> > Contributors either need a specialized resource editor or go through a
> > native2ascii roundtrip.
> >
> > How do feel about converting the message files to UTF-8 to facilitate
> > the modifications and transform them with native2ascii at build time?
>
> I like the idea but that will make building with later versions of Java
> problematic - or at least more complex - since native2ascii has been
> removed in Java 9 onwards.
>

What about using the XML version of Java Properties ?
https://docs.oracle.com/javase/7/docs/api/java/util/Properties.html#loadFromXML(java.io.InputStream)
This way the encoding could be specified in the XML file itself and there
is no need to use native2ascii at all.

Martin


>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: How do I start contributing?

2018-03-09 Thread Martin Grigorov
Hi Rohan,

http://tomcat.apache.org/getinvolved.html explains the first steps.
You can contribute by providing patches / Pull Requests, or by helping
others in the us...@tomcat.apache.org mailing list or at StackOverflow.
If you have questions about how some Tomcat internals work this mailing
list is the right place!

Have fun!


Martin Grigorov
Wicket Training and Consulting
Looking for a remote position with Wicket ? Contact me!
https://twitter.com/mtgrigorov


On Fri, Mar 9, 2018 at 1:34 PM, Rohan Chhabra <rohan23chha...@gmail.com>
wrote:

> Hey Mark and the Tomcat team,
>
> How do I start contributing? I am a software engineering enthusiast,
> interested in open source. I want to contribute to Tomcat. I occasionally
> read your mails but I don't get a feel for it. How do I start?
>


Re: [Git migration] Merge strategy

2018-01-22 Thread Martin Grigorov
On Mon, Jan 22, 2018 at 10:45 PM, Mark Thomas <ma...@apache.org> wrote:

> On 22/01/18 21:37, Martin Grigorov wrote:
> > Hi Mark,
> >
> > On Mon, Jan 22, 2018 at 10:16 PM, Mark Thomas <ma...@apache.org> wrote:
> >
> >> The plan when we migrate to git is to migrate to single git repo with
> >> the following branches:
> >>
> >> master - 9.0.x development
> >> tc8.5  - 8.5.x development
> >> tc8.0  - 8.0.x development
> >> tc7.0  - 7.0.x development
> >>
> >> We need to decide how we are going to handle a fix that applies to
> >> multiple versions.
> >>
> >> I can see two options:
> >>
> >> 1. Make the change in master and cherry-pick as required to earlier
> >>versions. This is, essentially, what we do now in svn.
> >>
> >
> > I think this will not work.
> > "git merge" needs to know the common parent of the two HEADs to be able
> to
> > decide what to merge.
> > I am not sure how smart svn-to-git is these days but I doubt it will be
> > that smart.
>
> If by "this" in "this will not work" you mean forward merging, we can
>

Yes, I meant 1).


> make this work if we want to based on my limited testing. It requires a
> few extra commits to get the meta-data to the point where git thinks all
> previous changes have been merged. From that point it should work (with
> the odd merge conflict, as now).
>
> The tricky part for me is new features. These naturally get implemented
> against master and then we decide how far back to port them. That
> requires a new way of thinking if we do forward merging.
>
> > Wicket was also converted several years ago from SVN to Git and there we
> > use cherry-picking.
>
> That seems the obvious choice but I'm wary of taking the "that is how we
> have always done it in svn" approach if there is a better way in git -
> especially if I don't know about it.
>
> > For smaller projects which were started with Git I use git merge!
> > For feature branches (at work) I even use "git rebase" insteaf of merge.
> > But this also means you have to use "git push --force" to the remote of
> the
> > feature branch. But for feature branches this usually is OK.
>
> Feature branches is almost a whole other question but probably one that
> needs to be discussed on this thread.
>
> Mark
>
> >
> >
> >>
> >> 2. Make the change in the earliest applicable version and them merge
> >>forward. This appears to be the more natural git way of doing things.
> >>
> >> These options are based on my fairly limited understanding of git.
> >> Suggestions for other approaches welcome.
> >>
> >> Thoughts? Comments?
> >>
> >> Mark
> >>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> >> For additional commands, e-mail: dev-h...@tomcat.apache.org
> >>
> >>
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [Git migration] Merge strategy

2018-01-22 Thread Martin Grigorov
Hi Mark,

On Mon, Jan 22, 2018 at 10:16 PM, Mark Thomas  wrote:

> The plan when we migrate to git is to migrate to single git repo with
> the following branches:
>
> master - 9.0.x development
> tc8.5  - 8.5.x development
> tc8.0  - 8.0.x development
> tc7.0  - 7.0.x development
>
> We need to decide how we are going to handle a fix that applies to
> multiple versions.
>
> I can see two options:
>
> 1. Make the change in master and cherry-pick as required to earlier
>versions. This is, essentially, what we do now in svn.
>

I think this will not work.
"git merge" needs to know the common parent of the two HEADs to be able to
decide what to merge.
I am not sure how smart svn-to-git is these days but I doubt it will be
that smart.
Wicket was also converted several years ago from SVN to Git and there we
use cherry-picking.
For smaller projects which were started with Git I use git merge!
For feature branches (at work) I even use "git rebase" insteaf of merge.
But this also means you have to use "git push --force" to the remote of the
feature branch. But for feature branches this usually is OK.


>
> 2. Make the change in the earliest applicable version and them merge
>forward. This appears to be the more natural git way of doing things.
>
> These options are based on my fairly limited understanding of git.
> Suggestions for other approaches welcome.
>
> Thoughts? Comments?
>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [Git migration] trunk or master

2018-01-08 Thread Martin Grigorov
Hi,

On Jan 8, 2018 15:33, "Mark Thomas"  wrote:

This is the third of the per issue e-mails to discuss the issues
associated with migrating from svn to git.

The standard name for the main branch where development takes place in
svn is 'trunk'. In git the standard name is 'master'.

We can use either of these going forwards. Or something completely
different.

We need to pick a name.

Thoughts?


Here is another suggestion:
each branch is named after the version of Tomcat it is for.
For example : 7.x, 8.x, 8.5.x, 9.x, etc.
Tomcat supports several versions and this approach makes it very clear
which branch for which version is.
Also this way all branch names are consistent.

If it just between trunk and master then I vote for master.

Regards,
Martin


Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org


Re: svn commit: r1816544 - /tomcat/trunk/test/org/apache/tomcat/websocket/TestWebSocketFrameClient.java

2017-11-28 Thread Martin Grigorov
On Tue, Nov 28, 2017 at 3:52 PM,  wrote:

> Author: huxing
> Date: Tue Nov 28 13:52:58 2017
> New Revision: 1816544
>
> URL: http://svn.apache.org/viewvc?rev=1816544=rev
> Log:
> Change file encoding to UTF-8
>
> Modified:
> tomcat/trunk/test/org/apache/tomcat/websocket/
> TestWebSocketFrameClient.java
>
> Modified: tomcat/trunk/test/org/apache/tomcat/websocket/
> TestWebSocketFrameClient.java
> URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/
> tomcat/websocket/TestWebSocketFrameClient.java?rev=1816544=1816543=
> 1816544=diff
> 
> ==
> --- 
> tomcat/trunk/test/org/apache/tomcat/websocket/TestWebSocketFrameClient.java
> (original)
> +++ 
> tomcat/trunk/test/org/apache/tomcat/websocket/TestWebSocketFrameClient.java
> Tue Nov 28 13:52:58 2017
> @@ -145,7 +145,7 @@ public class TestWebSocketFrameClient ex
>  SecurityCollection collection = new SecurityCollection();
>  collection.addPatternDecoded("/");
>  String utf8User = "test";
> -String utf8Pass = "123£";
> +String utf8Pass = "123£";
>

The old value looked better.


>
>  tomcat.addUser(utf8User, utf8Pass);
>  tomcat.addRole(utf8User, ROLE);
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: Java 9, modularisation and build systems

2017-10-06 Thread Martin Grigorov
Hi,


On Fri, Oct 6, 2017 at 11:45 AM, Romain Manni-Bucau 
wrote:

> Hi Mark,
>
> few comments inline
>
> 2017-10-06 10:18 GMT+02:00 Mark Thomas :
>
> > Hi all,
> >
> > As you have probably seen, I've been working on improving Java 9
> > support. The current TODO list is:
> >
> > - module path scanning
> > - handling multi-release JARs in the JarScanner
> >
> > I've been looking at the module path scanning and while there are
> > various approaches, they all make fairly heavy use of Java 9 APIs.
> > Implementing them via the existing JreCompat approach is going to
> > require a lot of reflection. That got me thinking about the obvious
> > alternative: multi-release JARs.
> >
> > Handling multi-release JARs is going to require some changes / additions
> > to the build process and source layout. That reminded me of a comment
> > that Rémy made at TomcatCon in London regarding modularisation and build
> > tools and whether we wanted to do things differently. If we want to make
> > changes in that area it probably makes sense to make them now - hence
> > this e-mail.
> >
> > Modularisation and build tools are inter-related so I think it makes
> > sense to discuss them together. Hence this thread.
> >
> > I'm going to start with what I think is the easy one: Modularisation.
> >
> > Tomcat is already modular. You can remove some features (JSP, WebSocket,
> > clustering?, store-config?) simply by removing the JARs. Do we want to
> > take this further? Nothing immediately springs to mind hence the fairly
> > open question: what changes could we implement to make Tomcat more
> > modular and how would those changes benefit our users?
> >
> > The build tools aspect has, historically, been the area where fairly
> > strong opinions have been expressed.
> >
> > The argument against Ant is that it isn't as well known amongst
> > prospective new contributors as other tools and hence creates a barrier
> > to contributing that harms the community. The argument for Ant is that
> > it works, it isn't causing any pain points and it has the flexibility to
> > handle all aspects of our build.
> >
> > The usual candidate for an alternative build system is Maven. The
> > argument for Maven is that it is more widely known and hence easier to
> > get started with. The argument against is broadly that Maven is very
> > opinionated and they way Tomcat currently does things is not consistent
> > with what Maven expects and some things (e.g. the Windows installer) are
> > well outside the typical Maven build. Therefore switching to Maven would
> > require a fair amount of effort.
> >
> > I'd like to suggest a third alternative: Gradle. The argument for Gradle
> > is that it can boot-strap itself so, unlike Ant, a new user doesn't need
> > to download the build tool. Gradle can also import Ant build files so we
> > could start with a simple Gradle script that simply imported the current
> > Ant script and then migrate slowly over time. The argument against is
> > that it isn't as widely known as Maven.
> >
>
> Maven also has this wrapper stuff (
> https://github.com/takari/takari-maven-plugin) and an ant plugin so this
> doesn't help much to decide between gradle and maven IMHO.
>

Right!

Maven also has 'mvnw' script (Maven Wrapper) that allows to bootstrap it
with a predefined version.
For example this project uses it
https://github.com/sidnan/loopback-rest-connector-example/tree/master/DemoBCH

And quite robust https://maven.apache.org/plugins/maven-antrun-plugin/

But also take into account the IDE support.
In Intellij IDEA at least the Maven support is much better than the one for
Gradle!

I personally prefer Maven because it is more consistent.
With free-style build tools like Ant, Gradle, sbt one has to invest some
time to understand the build and be able to make changes.

My 2c.

Regards,
Martin


>
> >
> >
> > My own views are neutral at this point on modularisation. I don't have
> > any immediate suggestions for changes but I'd like to hear what ideas
> > others have. On build systems, I'm not convinced that the benefits of
> > switching to Maven justify the costs. Gradle looks promising and I do
> > like the boot-strapping feature. If there was consensus to move to
> > Gradle, I'd be willing to help that process.
> >
> >
>
> I'm concerned of all consumers of tomcat embedded - none of them are java 9
> friendly today AFAIK - including spring boot - so this could create a
> moment where tomcat can't be used on java 9 even if it supports it by
> itself ("alone"). Maybe it is the kind of work which can be done in a
> branch in quick and dirty mode to evaluate the current state before
> speaking of a build tool which is mainly an implementation detail not
> impacting much users _immediately_? Rephrased: I would like tomcat to avoid
> to go live and prevent people to upgrade to get security fixes (or bug
> fixes) due to java 9 work - it has been the case for surefire where a few
> release 

Re: [PROPOSAL] Deprecate and eventually remove the o.a.c.servlet4preview package in 8.5.x

2017-09-28 Thread Martin Grigorov
On Thu, Sep 28, 2017 at 12:00 PM, Mark Thomas <ma...@apache.org> wrote:

> On 28/09/17 06:56, Martin Grigorov wrote:
> > Hi,
> >
> > On Thu, Sep 28, 2017 at 8:45 AM, Huxing Zhang <
> huxing@alibaba-inc.com>
> > wrote:
> >
> >> +1 to remove the preview packages.
> >>
> >> --
> >> Mark Thomas <ma...@apache.org>
> >> 2017 Sep 28 (Thu) 03:08
> >> Tomcat Developers List <dev@tomcat.apache.org>
> >> [PROPOSAL] Deprecate and eventually remove the o.a.c.servlet4preview
> >> package in 8.5.x
> >>
> >>
> >> All,
> >>
> >> I'd like to propose removing this for the following reasons:
> >>
> >> 1. Now the Servlet 4.0 spec is final, users can use Tomcat 9 for Servlet
> >> 4.0 features.
> >>
> >> 2. The preview is not complete and may be out of date in places.
> >>
> >> 3. I'm not aware of any user feedback so usage seems to be very low.
> >>
> >> My proposal is to deprecate it now with the intention to remove it after
> >> a year.
> >>
> >> As an alternative is deprecate it now with the intention to remove it 1
> >> year after the first stable 9.0.x release.
> >>
> >> Thoughts? Comments? Questions?
> >>
> >
> > We use the preview in Apache Wicket:
> > https://github.com/apache/wicket/blob/77d8bf32d2063ac0174fc383da81ac
> 2d6bcc482b/wicket-experimental/wicket-http2/wicket-http2-tomcat/src/main/
> java/org/apache/wicket/http2/markup/head/Tomcat85PushBuilder.java#L40
> >
> > But we can rework it!
>
> Great to know that someone is using it.
>
> It looks like reworking that could be as simple as switching to the
> concrete implementation (ApplicationPushBuilder) rather than the preview
> interface.
>

Wicket 8.0.0-M8 will use the ApplicationPushBuilder directly!

https://git1-us-west.apache.org/repos/asf?p=wicket.git;a=commitdiff;h=35a7d6d5;hp=77d8bf32d2063ac0174fc383da81ac2d6bcc482b

Regards,
Martin


>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [PROPOSAL] Deprecate and eventually remove the o.a.c.servlet4preview package in 8.5.x

2017-09-27 Thread Martin Grigorov
Hi,

On Thu, Sep 28, 2017 at 8:45 AM, Huxing Zhang 
wrote:

> +1 to remove the preview packages.
>
> --
> Mark Thomas 
> 2017 Sep 28 (Thu) 03:08
> Tomcat Developers List 
> [PROPOSAL] Deprecate and eventually remove the o.a.c.servlet4preview
> package in 8.5.x
>
>
> All,
>
> I'd like to propose removing this for the following reasons:
>
> 1. Now the Servlet 4.0 spec is final, users can use Tomcat 9 for Servlet
> 4.0 features.
>
> 2. The preview is not complete and may be out of date in places.
>
> 3. I'm not aware of any user feedback so usage seems to be very low.
>
> My proposal is to deprecate it now with the intention to remove it after
> a year.
>
> As an alternative is deprecate it now with the intention to remove it 1
> year after the first stable 9.0.x release.
>
> Thoughts? Comments? Questions?
>

We use the preview in Apache Wicket:
https://github.com/apache/wicket/blob/77d8bf32d2063ac0174fc383da81ac2d6bcc482b/wicket-experimental/wicket-http2/wicket-http2-tomcat/src/main/java/org/apache/wicket/http2/markup/head/Tomcat85PushBuilder.java#L40

But we can rework it!


>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 8.5.21

2017-09-18 Thread Martin Grigorov
On Thu, Sep 14, 2017 at 12:02 AM, Mark Thomas  wrote:

> The proposed Apache Tomcat 8.5.21 release is now available for voting.
>
> The major changes compared to the 8.5.20 release are:
>
> - Additional capabilities for the CGI Servlet. Based on patches provided
>   by jm009.
>
> - Added support for the OpenSSL SSL_CONF API. To support this the
>   minimum required Tomcat Native version is 1.2.14.
>
> Along with lots of other bug fixes and improvements.
>
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.21/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1153/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_21/
>
> The proposed 8.5.21 release is:
> [ ] Broken - do not release
> [ X ] Stable - go ahead and release as 8.5.21
>
>
Regards,
Martin


> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 9.0.0.M27

2017-09-18 Thread Martin Grigorov
On Wed, Sep 13, 2017 at 9:49 PM, Mark Thomas  wrote:

> The proposed Apache Tomcat 9.0.0.M27 release is now available for voting.
>
> This is a milestone release for the 9.0.x branch. It should be
> noted that, as a milestone release:
> - Servlet 4.0 is not finalised
> - It is not known if there will be a minor maintenance release for
>   JSP 2.4, EL 3.1 or WebSocket 1.2
>
> The major changes compared to the 9.0.0.M26 release are:
>
> - Additional capabilities for the CGI Servlet. Based on patches provided
>   by jm009.
>
> - Added support for the OpenSSL SSL_CONF API. To support this the
>   minimum required Tomcat Native version is 1.2.14.
>
> Along with lots of other bug fixes and improvements.
>
>
> For full details, see the changelog:
> http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M27/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1152/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M27/
>
> The proposed 9.0.0.M27 release is:
> [ ] Broken - do not release
> [ X ] Alpha - go ahead and release as 9.0.0.M27
>

Regards,
Martin


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 7.0.81

2017-08-15 Thread Martin Grigorov
On Fri, Aug 11, 2017 at 2:14 PM, Violeta Georgieva 
wrote:

> The proposed Apache Tomcat 7.0.81 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.81/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1151/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_81/
>
> The proposed 7.0.81 release is:
> [ ] Broken - do not release
> [ X ] Stable - go ahead and release as 7.0.81 Stable
>
>
Regards,
Martin


> Regards,
> Violeta
>


Re: [VOTE] Release Apache Tomcat 8.0.46

2017-08-15 Thread Martin Grigorov
On Thu, Aug 10, 2017 at 1:55 PM, Violeta Georgieva 
wrote:

> The proposed Apache Tomcat 8.0.46 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.46/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1150/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_46/
>
> The proposed 8.0.46 release is:
> [ ] Broken - do not release
> [ X ] Stable - go ahead and release as 8.0.46
>
>
Regards,
Martin


> Regards,
> Violeta
>


Re: [VOTE] [OT] Release Apache Tomcat 8.5.19

2017-07-27 Thread Martin Grigorov
Hi,

On Thu, Jul 27, 2017 at 11:31 AM, Mark Thomas  wrote:

> On 26/07/2017 20:59, Christopher Schultz wrote:
> > Mark,
> >
> > On 7/26/17 2:34 PM, Mark Thomas wrote:
> >> On 25/07/2017 00:22, Mark Thomas wrote:
> >>> The proposed Apache Tomcat 8.5.19 release is now available for
> >>> voting.
> >>>
> >>> The major changes compared to the 8.5.16 release are:
> >>>
> >>> - Enable TLS connectors to use Java key stores that contain
> >>> multiple keys where each key has a separate password. Based on a
> >>> patch by Frank Taffelt.
> >>>
> >>> - Make asynchronous error handling more robust. In particular
> >>> ensure that onError() is called for any registered AsyncListeners
> >>> after an I/O error on a non-container thread.
> >>>
> >>> - Sync SSL session access for the APR connector to prevent errors
> >>> when accessing the session.
> >>>
> >>>
> >>> Along with lots of other bug fixes and improvements.
> >>>
> >>>
> >>> It can be obtained from:
> >>> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.19/
> >>> The Maven staging repo is:
> >>> https://repository.apache.org/content/repositories/orgapachetomcat-11
> > 46/
> >>>
> >>>
> > The svn tag is:
> >>> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_19/
> >>>
> >>>
> >>>
> > The proposed 8.5.19 release is:
> >>> [ ] Broken - do not release [X] Stable - go ahead and release as
> >>> 8.5.19
> >
> >> All unit tests passed with NIO, NIO2 and APR/native (1.2.12) on
> >> Linux Windows and macOS.
> >
> > I've noticed that there are some tests which have no bearing on the
> > type of connector, yet are run for each type of connector. For example
> > (from my test report):
> >
> > * org.apache.tomcat.util.net.openssl.ciphers.TestCipher.APR.txt
> > * org.apache.tomcat.util.net.openssl.ciphers.TestCipher.NIO.txt
> > * org.apache.tomcat.util.net.openssl.ciphers.TestCipher.NIO2.txt
> > *
> > org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfiguratio
> > nParser.APR.txt
> > *
> > org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfiguratio
> > nParser.NIO.txt
> > *
> > org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfiguratio
> > nParser.NIO2.txt
> >
> > Would it be worth it to annotate some of these tests as being "not
> > connector-specific" and then running them only a single time?
> > Depending upon the number of them, it could significantly reduce the
> > time it takes to run all of the unit tests.
>
> I don't know. The tests that take longer to run tend to be the ones that
> involve I/O.
>
> Does JUnit provide a way for us to annotate the tests in this way? If it
> does we could have one test run for all the non-IO tests and per
> connector test runs for all the other tests.
>

Here is how we do it in Wicket:

- introduce a special annotation:

https://github.com/apache/wicket/blob/d7e8fe2762700520a8856eda51f99eaa2678d002/wicket-util/src/main/java/org/apache/wicket/util/SlowTests.java
- annotate slow tests with it:
https://github.com/apache/wicket/blob/9e42a9548adb0da540e4e87d491f5824e778537e/wicket-util/src/test/java/org/apache/wicket/util/io/ConnectionsTest.java#L32
- use Maven profile that skips slow tests and javadoc and sources
generation:
https://github.com/apache/wicket/blob/573fdf5739fb8a82223b54d551c343687b3aab35/pom.xml#L1166-L1193

usage:
mvn clean install -Pfast

It is not pure JUnit, but uses maven-surefire-plugin to control it, so I
cannot tell you what exactly is the JUnit launcher configuration.


>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 8.5.19

2017-07-27 Thread Martin Grigorov
On Tue, Jul 25, 2017 at 2:22 AM, Mark Thomas  wrote:

> The proposed Apache Tomcat 8.5.19 release is now available for voting.
>
> The major changes compared to the 8.5.16 release are:
>
> - Enable TLS connectors to use Java key stores that contain multiple
>   keys where each key has a separate password. Based on a patch by Frank
>   Taffelt.
>
> - Make asynchronous error handling more robust. In particular ensure
>   that onError() is called for any registered AsyncListeners after an
>   I/O error on a non-container thread.
>
> - Sync SSL session access for the APR connector to prevent errors when
>   accessing the session.
>
>
> Along with lots of other bug fixes and improvements.
>
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.19/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1146/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_19/
>
> The proposed 8.5.19 release is:
> [ ] Broken - do not release
> [ X ] Stable - go ahead and release as 8.5.19
>
>
Regards,
Martin


> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 8.5.18

2017-07-21 Thread Martin Grigorov
On Tue, Jul 18, 2017 at 3:58 PM, Mark Thomas  wrote:

> The proposed Apache Tomcat 8.5.18 release is now available for voting.
>
> The major changes compared to the 8.5.16 release are:
>
> - Enable TLS connectors to use Java key stores that contain multiple
>   keys where each key has a separate password. Based on a patch by Frank
>   Taffelt.
>
> - Make asynchronous error handling more robust. In particular ensure
>   that onError() is called for any registered AsyncListeners after an
>   I/O error on a non-container thread.
>
> - Sync SSL session access for the APR connector to prevent errors when
>   accessing the session.
>
>
> Along with lots of other bug fixes and improvements.
>
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.18/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1144/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_18/
>
> The proposed 8.5.18 release is:
> [ ] Broken - do not release
> [ X ] Stable - go ahead and release as 8.5.18
>


Regards,
Martin


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 9.0.0.M24

2017-07-21 Thread Martin Grigorov
On Tue, Jul 18, 2017 at 1:43 PM, Mark Thomas  wrote:

> The proposed Apache Tomcat 9.0.0.M24 release is now available for voting.
>
> This is a milestone release for the 9.0.x branch. It should be
> noted that, as a milestone release:
> - Servlet 4.0 is not finalised
> - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0
>
> Note that the 9.0.0.M23 release vote was cancelled due to a regression.
>
> The major changes compared to the 9.0.0.M22 release are:
>
> - Correct a regression in 9.0.0.M22 that prevented Tomcat from shutting
>   down cleanly.
>
> - Add LoadBalancerDrainingValve, a Valve designed to reduce the amount
>   of time required for a node to drain its authenticated users.
>
> - When generating JSP runtime error messages that quote the relevant JSP
>   source code, switch from using the results of the JSP page parsing
>   process to using the JSR 045 source map data to identify the correct
>   part of the JSP source from the stack trace. This significantly
>   reduces the memory footprint of Jasper in development mode, provides a
>   small performance improvement for error page generation and enables
>   source quotes to continue to be provided after a Tomcat restart.
>
> - Add support for a Tomcat specific deployment descriptor,
>   /WEB-INF/tomcat-web.xml
>
> Along with lots of other bug fixes and improvements.
>
>
> For full details, see the changelog:
> http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M24/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1143/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M24/
>
> The proposed 9.0.0.M24 release is:
> [ ] Broken - do not release
> [ X ] Alpha - go ahead and release as 9.0.0.M24
>

Regards,
Martin


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] 8.0.x EOL - 30 June 2018

2017-06-22 Thread Martin Grigorov
On Thu, Jun 22, 2017 at 5:18 PM, Mark Thomas  wrote:

> We had a couple of threads discussing this. I think it is time for a vote.
>
> [ X ] +1 We should announce 8.0.x EOL for 30 June 2018
> [ ] -1 We should announce 8.0.x EOL for [insert date here]
> [ ] -1 We should not announce 8.0.x EOL at this time
>
> Thanks,
>
> Mark
>
>
Regards,
Martin


> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: svn commit: r1799498 - in /tomcat/trunk: java/org/apache/catalina/valves/LoadBalancerDrainingValve.java test/org/apache/catalina/valves/TestLoadBalancerDrainingValve.java webapps/docs/changelog.xm

2017-06-22 Thread Martin Grigorov
Hi Chris,


On Wed, Jun 21, 2017 at 9:05 PM,  wrote:

> Author: schultz
> Date: Wed Jun 21 19:05:38 2017
> New Revision: 1799498
>
> URL: http://svn.apache.org/viewvc?rev=1799498=rev
> Log:
> Add LoadBalancerDrainingValve.
>
> Added:
> 
> tomcat/trunk/java/org/apache/catalina/valves/LoadBalancerDrainingValve.java
>  (with props)
> tomcat/trunk/test/org/apache/catalina/valves/
> TestLoadBalancerDrainingValve.java   (with props)
> Modified:
> tomcat/trunk/webapps/docs/changelog.xml
> tomcat/trunk/webapps/docs/config/valve.xml
>
> Added: tomcat/trunk/java/org/apache/catalina/valves/
> LoadBalancerDrainingValve.java
> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/
> catalina/valves/LoadBalancerDrainingValve.java?rev=1799498=auto
> 
> ==
> --- 
> tomcat/trunk/java/org/apache/catalina/valves/LoadBalancerDrainingValve.java
> (added)
> +++ 
> tomcat/trunk/java/org/apache/catalina/valves/LoadBalancerDrainingValve.java
> Wed Jun 21 19:05:38 2017
> @@ -0,0 +1,277 @@
> +/*
> + * Licensed to the Apache Software Foundation (ASF) under one or more
> + * contributor license agreements.  See the NOTICE file distributed with
> + * this work for additional information regarding copyright ownership.
> + * The ASF licenses this file to You under the Apache License, Version 2.0
> + * (the "License"); you may not use this file except in compliance with
> + * the License.  You may obtain a copy of the License at
> + *
> + *  http://www.apache.org/licenses/LICENSE-2.0
> + *
> + * Unless required by applicable law or agreed to in writing, software
> + * distributed under the License is distributed on an "AS IS" BASIS,
> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
> implied.
> + * See the License for the specific language governing permissions and
> + * limitations under the License.
> + */
> +package org.apache.catalina.valves;
> +
> +import java.io.IOException;
> +
> +import javax.servlet.ServletException;
> +import javax.servlet.http.Cookie;
> +import javax.servlet.http.HttpServletResponse;
> +
> +import org.apache.catalina.LifecycleException;
> +import org.apache.catalina.connector.Request;
> +import org.apache.catalina.connector.Response;
> +import org.apache.catalina.util.SessionConfig;
> +import org.apache.juli.logging.Log;
> +
> +/**
> + * A Valve to detect situations where a load-balanced node receiving a
> + * request has been deactivated by the load balancer
> (JK_LB_ACTIVATION=DIS)
> + * and the incoming request has no valid session.
> + *
> + * In these cases, the user's session cookie should be removed if it
> exists,
> + * any ";jsessionid" parameter should be removed from the request URI,
> + * and the client should be redirected to the same URI. This will cause
> the
> + * load-balanced to re-balance the client to another server.
> + *
> + * A request parameter is added to the redirect URI in order to avoid
> + * repeated redirects in the event of an error or misconfiguration.
> + *
> + * All this work is required because when the activation state of a
> node is
> + * DISABLED, the load-balancer will still send requests to the node if
> they
> + * appear to have a session on that node. Since mod_jk doesn't actually
> know
> + * whether the session id is valid, it will send the request blindly to
> + * the disabled node, which makes it take much longer to drain the node
> + * than strictly necessary.
> + *
> + * For testing purposes, a special cookie can be configured and used
> + * by a client to ignore the normal behavior of this Valve and allow
> + * a client to get a new session on a DISABLED node. See
> + * {@link #setIgnoreCookieName} and {@link #setIgnoreCookieValue}
> + * to configure those values.
> + *
> + * This Valve should be installed earlier in the Valve pipeline than
> any
> + * authentication valves, as the redirection should take place before an
> + * authentication valve would save a request to a protected resource.
> + *
> + * @see http://tomcat.apache.org/connectors-doc/generic_howto/
> loadbalancers.html
> + */
> +public class LoadBalancerDrainingValve
> +extends ValveBase
> +{
> +/**
> + * The request attribute key where the load-balancer's activation
> state
> + * can be found.
> + */
> +static final String ATTRIBUTE_KEY_JK_LB_ACTIVATION =
> "JK_LB_ACTIVATION";
>

Any objection to make this constant public and visible from outside ?
I find it useful to be able to refer the constant by name than its value
when integrating.


> +
> +/**
> + * The HTTP response code that will be used to redirect the request
> + * back to the load-balancer for re-balancing. Defaults to 307
> + * (TEMPORARY_REDIRECT).
> + *
> + * HTTP status code 305 (USE_PROXY) might be an option, here. too.
> + */
> +private int _redirectStatusCode = HttpServletResponse.SC_
> TEMPORARY_REDIRECT;
> +
> +/**
> + * 

Re: svn commit: r1798509 - in /tomcat/trunk: conf/logging.properties java/org/apache/coyote/AbstractProcessor.java java/org/apache/coyote/AsyncStateMachine.java webapps/docs/changelog.xml

2017-06-12 Thread Martin Grigorov
Hi Mark,

On Mon, Jun 12, 2017 at 8:42 PM,  wrote:

> Author: markt
> Date: Mon Jun 12 18:42:32 2017
> New Revision: 1798509
>
> URL: http://svn.apache.org/viewvc?rev=1798509=rev
> Log:
> Make asynchronous error handling more robust. In particular ensure that
> onError() is called for any registered AsyncListeners after an I/O error on
> a non-container thread.
>
> Modified:
> tomcat/trunk/conf/logging.properties
> tomcat/trunk/java/org/apache/coyote/AbstractProcessor.java
> tomcat/trunk/java/org/apache/coyote/AsyncStateMachine.java
> tomcat/trunk/webapps/docs/changelog.xml
>
> Modified: tomcat/trunk/conf/logging.properties
> URL: http://svn.apache.org/viewvc/tomcat/trunk/conf/logging.prope
> rties?rev=1798509=1798508=1798509=diff
> 
> ==
> --- tomcat/trunk/conf/logging.properties (original)
> +++ tomcat/trunk/conf/logging.properties Mon Jun 12 18:42:32 2017
> @@ -65,6 +65,8 @@ org.apache.catalina.core.ContainerBase.[
>
>  # To see debug messages for HTTP/2 handling, uncomment the following line:
>  #org.apache.coyote.http2.level = FINE
> +org.apache.coyote.level = FINEST
> +org.apache.catalina.level = FINEST
>

Look like debug leftovers.


>
>  # To see debug messages for WebSocket handling, uncomment the following
> line:
>  #org.apache.tomcat.websocket.level = FINE
>
> Modified: tomcat/trunk/java/org/apache/coyote/AbstractProcessor.java
> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/co
> yote/AbstractProcessor.java?rev=1798509=1798508=1798509=diff
> 
> ==
> --- tomcat/trunk/java/org/apache/coyote/AbstractProcessor.java (original)
> +++ tomcat/trunk/java/org/apache/coyote/AbstractProcessor.java Mon Jun 12
> 18:42:32 2017
> @@ -95,6 +95,7 @@ public abstract class AbstractProcessor
>  // have been completed. Dispatch to a container thread to do
> the
>  // clean-up. Need to do it this way to ensure that all the
> necessary
>  // clean-up is performed.
> +asyncStateMachine.asyncMustError();
>  
> getLog().info(sm.getString("abstractProcessor.nonContainerThreadError"),
> t);
>  processSocketEvent(SocketEvent.ERROR, true);
>  }
>
> Modified: tomcat/trunk/java/org/apache/coyote/AsyncStateMachine.java
> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/co
> yote/AsyncStateMachine.java?rev=1798509=1798508=1798509=diff
> 
> ==
> --- tomcat/trunk/java/org/apache/coyote/AsyncStateMachine.java [UTF-8]
> (original)
> +++ tomcat/trunk/java/org/apache/coyote/AsyncStateMachine.java [UTF-8]
> Mon Jun 12 18:42:32 2017
> @@ -66,38 +66,49 @@ import org.apache.tomcat.util.security.P
>   *differences required to avoid race conditions
> during error
>   *handling.
>   * DISPATCHING  - The dispatch is being processed.
> + * MUST_ERROR   - ServletRequest.startAsync() has been called
> followed by an
> + *I/O error on a non-container thread. The main
> purpose of
> + *this state is to prevent additional async actions
> + *(complete(), dispatch() etc.) on the non-container
> thread.
> + *The container will perform the necessary error
> handling,
> + *including ensuring that the AsyncLister.onError()
> method
> + *is called.
>   * ERROR- Something went wrong.
>   *
> - * |-»--|
> - * |   \|/ /---«-
> --«--|
> - * |   |--«-E R R O R--«---«--
> -|  |
> - * |   |  complete() /|\/|\\ \-««---|
> |  |
> - * |   |  |  |  \
>|  |  |
> - * |   ||-»---|  |   \---»--|
>|  |  |
> - * |   |||  |dispatch()
>|  |  |
> - * |   ||| \|/
>   ^  |  |
> - * |   |||  |--|timeout()   |
>|  |  |
> - * |   || post() |  | \|/   | post()
>   |  |  |
> - * |   |||-- | --»DISPATCHED«-- |
> --COMPLETING«-|  |  |
> - * |   |||   |   /|\/|\ |   |
> | /|\ /|\  |  |  |
> - * |   ||||---»- | ---|  |  |startAsync()   |
>  timeout()|--|   |   |  |  |
> - * |   |^^|  |   |  |   |
>|   |  ^  |
> - * |   ||||   |-- \ -|  |   complete()  |
>|post() | 

Re: Things that we can do to increase contributor involvement?

2017-06-04 Thread Martin Grigorov
Hi,

On Thu, Jun 1, 2017 at 3:34 PM, Romain Manni-Bucau 
wrote:

> Hi guys,
>
> a quick feedback on that topic:
>
> - github seems to be the preferred way to submit code these days (what we
> saw in tomee, batchee etc), it implies almost the same amount of work for
> dev (just need to comment if applied or not on github itself for tracking)
> so it is a good way probably
> - tomcat build not being "standard" can be a stopper for newcomers, I know
> migrating to a real maven structure was rejected multiple times but I think
> it can help. It would enable to import the project smoothly in any IDE, run
> it almost directly from the command line (it is not rare now to not have
> ant), and make it easier to browse the structure/package/module
>

I totally agree with Romain here!
I have said it before as well: http://markmail.org/message/aomihwix7bvxpttd

@Konstantin: re. "PR === patch"
For me PR is much more convenient than a .patch file because I can comment
on any line! And even have a whole discussion thread on it!

Me and some other ASF committers have asked at
us...@infrastructure.apache.org why ASF Git doesn't provide more advanced
features, like PRs. Even Atlassian offered hosted BitBucket for free but it
has been rejected :-/

Now there is https://gitbox.apache.org/ but it is still in early evaluation
stage. I hope it will make it simpler for my other Apache projects (Wicket
and Isis) some day!

Martin


>
>
>
> Romain Manni-Bucau
> @rmannibucau  |  Blog
>  | Old Blog
>  | Github  rmannibucau> |
> LinkedIn  | JavaEE Factory
> 
>
> 2017-06-01 15:29 GMT+02:00 Mark Thomas :
>
> > On 1 June 2017 13:05:18 BST, Coty Sutherland 
> wrote:
> >
> > >Hm, using Git was mentioned at the TomcatCon but I can't recall if the
> > >git repository on github is bi-directional or just a clone of svn. Can
> > >anyone answer that?
> >
> > The ASF hosts a read-only git clone of svn. GitHub has a read-only mirror
> > of the ASF repo.
> >
> > I.e. only ASF svn is read/write.
> >
> > > Have we made a decision about the best way to
> > >submit patches? BZ attachment, github PR, email, other?
> >
> > BZ or PR are generally best since they are less likely to be forgotten.
> >
> > > How often do
> > >we check the github projects for contributions?
> >
> > Notifications of PRs get sent to the dev list.
> >
> > >  We also talked about
> > >going over the tomcat 6 and older version BZs to clean them up, maybe
> > >we should do the same for github PRs?
> >
> > 5.5.x and earlier was cleaned up as they went EOL. There are currently 15
> > or so 6.0.x BZ entries left to clean up.
> >
> > >> Anyway, there are PRs there from a few months ago, all the way to a
> > >couple
> > >> of years ago.  The really old ones should be closed IMO, and suggest
> > >to the
> > >> contributors to submit again if the issue(s) are still valid.
> >
> > There is generally a large difference in responsiveness between bugs and
> > enhancement requests. Most of the open PRs have been reviewed and are
> > waiting for feedback. The others are enhancement requests which typically
> > remain open until there is sufficient interest in implementing them.
> >
> > Yes it would be great to move faster on these. That needs more people
> > looking at them. Things are slowly improving - the total open issues is
> > trending downwards over time.
> >
> > Mark
> >
> >
> >  > The
> > >newer
> > >> ones should be evaluated and feedback should be given to the
> > >contributors
> > >> You already "found" new contributors -- better spend some time
> > >"cultivating"
> > >> them than look for new ones who might end up stuck in that same
> > >situation.
> > >>
> > >> The most recent PR ATM -- https://github.com/apache/tomcat/pull/56 --
> > >is
> > >> from me, and it's only been a few days, so normally I wouldn't have
> > >said
> > >> anything at this point because it hasn't been "long enough" since I
> > >> submitted it.  But then I saw this email and it made perfect sense
> > >for me to
> > >> chime in.
> > >>
> > >> It was very important for me to keep my PR as small and simple as
> > >possible,
> > >> so that it's easy to review and accept or reject.  But there is no
> > >feedback
> > >
> > >Just for future reference, when you submit a PR it's easiest to review
> > >if you squash all of the commits into one rather than multiple
> > >commits.
> > >
> > >> whatsoever.  I usually have more time to contribute on the weekends,
> > >so if
> > >> I'll get some feedback soon, I will hopefully be able to implement
> > >whatever
> > >> changes necessary on the weekend.  If not, then another week goes by.
> > >>
> > >> Anyway, I really am not complaining here.  Just providing a
> > >perspective from
> > >> "the other 

Re: [VOTE] Release Apache Tomcat 7.0.78

2017-05-15 Thread Martin Grigorov
On Wed, May 10, 2017 at 5:47 PM, Violeta Georgieva 
wrote:

> The proposed Apache Tomcat 7.0.78 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.78/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1135/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_78/
>
> The proposed 7.0.78 release is:
> [ ] Broken - do not release
> [ X ] Stable - go ahead and release as 7.0.78 Stable
>

Regards,
Martin


>
> Regards,
> Violeta
>


Re: [VOTE] Release Apache Tomcat 8.0.44

2017-05-14 Thread Martin Grigorov
On Wed, May 10, 2017 at 8:41 PM, Violeta Georgieva 
wrote:

> The proposed Apache Tomcat 8.0.44 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.44/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1136/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_44/
>
> The proposed 8.0.44 release is:
> [ ] Broken - do not release
> [ X ] Stable - go ahead and release as 8.0.44
>

Regards,
Martin


>
> Regards,
> Violeta
>


Re: [VOTE] Release Apache Tomcat 9.0.0.M21

2017-05-09 Thread Martin Grigorov
On Fri, May 5, 2017 at 11:03 AM, Mark Thomas  wrote:

> The proposed Apache Tomcat 9.0.0.M21 release is now available for voting.
>
> This is a milestone release for the 9.0.x branch. It should be
> noted that, as a milestone release:
> - Servlet 4.0 is not finalised
> - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0
>
> The major changes compared to the 9.0.0.M20 release are:
>
> - Update the default URIEncoding for a Connector to UTF-8 as required
>   by the Servlet 4.0 specification.
>
> - Various improvements to the handling of static custom error pages
>
> - Update to Eclipse JDT Compiler 4.6.3
>
> Along with lots of other bug fixes and improvements
>
> For full details, see the changelog:
> http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M21/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1133/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M21/
>
> The proposed 9.0.0.M21 release is:
> [ ] Broken - do not release
> [ X ] Alpha - go ahead and release as 9.0.0.M21
>


Regards,
Martin


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 8.5.15

2017-05-09 Thread Martin Grigorov
On Fri, May 5, 2017 at 1:38 PM, Mark Thomas  wrote:

> The proposed Apache Tomcat 8.5.15 release is now available for voting.
>
> The major changes compared to the 8.5.13 release are:
>
> - Various improvements to the handling of static custom error pages
>
> - Update to Eclipse JDT Compiler 4.6.3
>
> - Review those places where Tomcat re-encodes a URI or URI component
>   and ensure that that correct encoding is consistently applied.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.15/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1134/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_15/
>
> The proposed 8.5.15 release is:
> [ ] Broken - do not release
> [ X ] Stable - go ahead and release as 8.5.15
>

Regards,
Martin


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [ANN] New committer: Michael Osipov

2017-05-08 Thread Martin Grigorov
Welcome, Michael!

Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov

On Mon, May 8, 2017 at 10:08 AM, Mark Thomas <ma...@apache.org> wrote:

> On behalf of the Tomcat committers I am pleased to announce that
> Michael Osipov (michaelo) has been voted in as a new Tomcat committer.
>
> Please join me in welcoming him.
>
> Regards,
>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 9.0.0.M20

2017-04-14 Thread Martin Grigorov
On Wed, Apr 12, 2017 at 10:11 PM, Mark Thomas  wrote:

> The proposed Apache Tomcat 9.0.0.M20 release is now available for voting.
>
> This is a milestone release for the 9.0.x branch. It should be
> noted that, as a milestone release:
> - Servlet 4.0 is not finalised
> - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0
>
> The major changes compared to the 9.0.0.M19 release are:
>
> - Correct a regression that broke JMX operations (including the Manager
>   web application) if the operation took parameters
>
> - Add JMX support for Tribes components
>
> - Calls to isReady() no longer throw exceptions after timeouts for async
>   servlets
>
>
> Along with lots of other bug fixes and improvements
>
> For full details, see the changelog:
> http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M20/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1131/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M20/
>
> The proposed 9.0.0.M20 release is:
> [ ] Broken - do not release
> [ X ] Alpha - go ahead and release as 9.0.0.M20
>

Regards,
Martin


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 8.5.14

2017-04-14 Thread Martin Grigorov
On Thu, Apr 13, 2017 at 3:12 PM, Mark Thomas  wrote:

> The proposed Apache Tomcat 8.5.14 release is now available for voting.
>
> The major changes compared to the 8.5.13 release are:
>
> - Correct a regression that broke JMX operations (including the Manager
>   web application) if the operation took parameters
>
> - Add JMX support for Tribes components
>
> - Calls to isReady() no longer throw exceptions after timeouts for async
>   servlets
>
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.14/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1132/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_14/
>
> The proposed 8.5.14 release is:
> [ ] Broken - do not release
> [ X ] Stable - go ahead and release as 8.5.14
>

Regards,
Martin


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 7.0.77

2017-03-30 Thread Martin Grigorov
On Tue, Mar 28, 2017 at 6:45 PM, Violeta Georgieva 
wrote:

> The proposed Apache Tomcat 7.0.77 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.77/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1128/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_77/
>
> The proposed 7.0.77 release is:
> [ ] Broken - do not release
> [ X ] Stable - go ahead and release as 7.0.77 Stable
>

Regards,
Martin


>
> Regards,
> Violeta
>


Re: [VOTE] Release Apache Tomcat 8.0.43

2017-03-29 Thread Martin Grigorov
On Tue, Mar 28, 2017 at 5:28 PM, Violeta Georgieva 
wrote:

> The proposed Apache Tomcat 8.0.43 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.43/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1127/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_43/
>
> The proposed 8.0.43 release is:
> [ ] Broken - do not release
> [ X ] Stable - go ahead and release as 8.0.43
>

Regards,
Martin


>
> Regards,
> Violeta
>


Re: [VOTE] Release Apache Tomcat 9.0.0.M19

2017-03-29 Thread Martin Grigorov
On Mon, Mar 27, 2017 at 2:56 PM, Mark Thomas  wrote:

> The proposed Apache Tomcat 9.0.0.M19 release is now available for voting.
>
> This is a milestone release for the 9.0.x branch. It should be
> noted that, as a milestone release:
> - Servlet 4.0 is not finalised
> - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0
>
> The major changes compared to the 9.0.0.M18 release are:
>
> - Various HTTP/2 improvements
>
> - Fixes for sendfile related issues that could cause subsequent requests
>   to experience IllegalStateExceptions
>
> - Servlet 4.0 updates
>
>
> Along with lots of other bug fixes and improvements
>
> For full details, see the changelog:
> http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M19/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1125/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M19/
>
> The proposed 9.0.0.M19 release is:
> [ ] Broken - do not release
> [ X ] Alpha - go ahead and release as 9.0.0.M19
>

Regards,
Martin


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 8.5.13

2017-03-29 Thread Martin Grigorov
On Mon, Mar 27, 2017 at 5:13 PM, Mark Thomas  wrote:

> The proposed Apache Tomcat 8.5.13 release is now available for voting.
>
> The major changes compared to the 8.5.12 release are:
>
> - Various HTTP/2 improvements
>
> - Fixes for sendfile related issues that could cause subsequent requests
>   to experience IllegalStateExceptions
>
> - Servlet 4.0 updates
>
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.13/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1126/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_13/
>
> The proposed 8.5.13 release is:
> [ ] Broken - do not release
> [ X ] Stable - go ahead and release as 8.5.13
>

Regards,
Martin


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: svn commit: r1788771 - in /tomcat/trunk/java/org/apache/coyote/http2: LocalStrings.properties Stream.java

2017-03-26 Thread Martin Grigorov
Hi Mark,


On Sun, Mar 26, 2017 at 9:31 PM,  wrote:

> Author: markt
> Date: Sun Mar 26 19:31:25 2017
> New Revision: 1788771
>
> URL: http://svn.apache.org/viewvc?rev=1788771=rev
> Log:
> Additional header validation
> Found with the h2spec tool written by Moto Ishizawa.
>
> Modified:
> tomcat/trunk/java/org/apache/coyote/http2/LocalStrings.properties
> tomcat/trunk/java/org/apache/coyote/http2/Stream.java
>
> Modified: tomcat/trunk/java/org/apache/coyote/http2/LocalStrings.
> properties
> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/
> coyote/http2/LocalStrings.properties?rev=1788771=
> 1788770=1788771=diff
> 
> ==
> --- tomcat/trunk/java/org/apache/coyote/http2/LocalStrings.properties
> (original)
> +++ tomcat/trunk/java/org/apache/coyote/http2/LocalStrings.properties Sun
> Mar 26 19:31:25 2017
> @@ -74,10 +74,12 @@ pingManager.roundTripTime=Connection [{0
>
>  stream.closed=Connection [{0}], Stream [{1}], Unable to write to stream
> once it has been closed
>  stream.header.case=Connection [{0}], Stream [{1}], HTTP header name [{2}]
> must be in lower case
> +stream.header.connection=Connection [{0}], Stream [{1}], HTTP header
> [connection] is not permitted in an HTTP/2 request
>  stream.header.debug=Connection [{0}], Stream [{1}], HTTP header [{2}],
> Value [{3}]
>  stream.header.duplicate=Connection [{0}], Stream [{1}], received
> multiple [{3}] headers
>  stream.header.noPath=Connection [{0}], Stream [{1}], The [:path] pseudo
> header was empty
>  stream.header.required=Connection [{0}], Stream [{1}], One or more
> required headers was missing
> +stream.header.te=Connection [{0}], Stream [{1}], HTTP header [te] is not
> permitted tohave the value [{2}] in an HTTP/2 request
>

Small typo in "tohave" - misses space.


>  stream.header.unexpectedPseudoHeader=Connection [{0}], Stream [{1}],
> Pseudo header [{2}] received after a regular header
>  stream.header.unknownPseudoHeader=Connection [{0}], Stream [{1}],
> Unknown pseudo header [{2}] received
>  stream.notWritable=Connection [{0}], Stream [{1}], This stream is not
> writable
>
> Modified: tomcat/trunk/java/org/apache/coyote/http2/Stream.java
> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/
> coyote/http2/Stream.java?rev=1788771=1788770=1788771=diff
> 
> ==
> --- tomcat/trunk/java/org/apache/coyote/http2/Stream.java (original)
> +++ tomcat/trunk/java/org/apache/coyote/http2/Stream.java Sun Mar 26
> 19:31:25 2017
> @@ -233,6 +233,18 @@ class Stream extends AbstractStream impl
>  getConnectionId(), getIdentifier(), name));
>  }
>
> +if ("connection".equals(name)) {
> +throw new HpackException(sm.getString("
> stream.header.connection",
> +getConnectionId(), getIdentifier()));
> +}
> +
> +if ("te".equals(name)) {
> +if (!"trailers".equals(value)) {
> +throw new HpackException(sm.getString("stream.header.te",
> +getConnectionId(), getIdentifier(), value));
> +}
> +}
> +
>  if (headerStateErrorMsg != null) {
>  // Don't bother processing the header since the stream is
> going to
>  // be reset anyway
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: svn commit: r1788741 - in /tomcat/trunk: java/org/apache/catalina/connector/CoyoteAdapter.java webapps/docs/changelog.xml

2017-03-26 Thread Martin Grigorov
Hi Violeta,

On Sun, Mar 26, 2017 at 6:21 PM,  wrote:

> Author: violetagg
> Date: Sun Mar 26 16:21:03 2017
> New Revision: 1788741
>
> URL: http://svn.apache.org/viewvc?rev=1788741=rev
> Log:
> Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60911
> Ensure NPE will not be thrown when looking for SSL session ID. Based on a
> pacth by Didier Gutacker.
>
> Modified:
> tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java
> tomcat/trunk/webapps/docs/changelog.xml
>
> Modified: tomcat/trunk/java/org/apache/catalina/connector/
> CoyoteAdapter.java
> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/
> catalina/connector/CoyoteAdapter.java?rev=1788741=1788740=1788741&
> view=diff
> 
> ==
> --- tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java
> (original)
> +++ tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java
> Sun Mar 26 16:21:03 2017
> @@ -980,9 +980,11 @@ public class CoyoteAdapter implements Ad
>  SSL_ONLY.equals(request.getServletContext()
>  .getEffectiveSessionTrackingModes()) &&
>  request.connector.secure) {
> -request.setRequestedSessionId(
> -request.getAttribute(SSLSupport.SESSION_ID_KEY).
> toString());
> -request.setRequestedSessionSSL(true);
> +String sessionId = (String) request.getAttribute(
> SSLSupport.SESSION_ID_KEY);
>

Either this cast will lead to ClassCastException...


> +if (sessionId != null) {
> +request.setRequestedSessionId(sessionId.toString());
>

... or this this call to #toString() is not needed.


> +request.setRequestedSessionSSL(true);
> +}
>  }
>  }
>
>
> Modified: tomcat/trunk/webapps/docs/changelog.xml
> URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/
> changelog.xml?rev=1788741=1788740=1788741=diff
> 
> ==
> --- tomcat/trunk/webapps/docs/changelog.xml (original)
> +++ tomcat/trunk/webapps/docs/changelog.xml Sun Mar 26 16:21:03 2017
> @@ -93,6 +93,10 @@
>  single utility class and update the code to use the new utility
> class.
>  (markt)
>
> +  
> +60911: Ensure NPE will not be thrown when looking for
> SSL
> +session ID. Based on a pacth by Didier Gutacker. (violetagg)
> +  
>  
>
>
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 8.0.42

2017-03-13 Thread Martin Grigorov
On Thu, Mar 9, 2017 at 12:05 PM, Mark Thomas  wrote:

> Correcting the subject.
>
> On 08/03/17 20:26, Mark Thomas wrote:
> > The proposed Apache Tomcat 8.0.42 release is now available for voting.
> >
> > The main changes since 8.0.41 are:
> >
> > - Limited relaxation of the HTTP request line validation
> >
> > - Support for Java 9 during annotation scanning
> >
> > - Update Tomcat Native to 1.2.12 to pick up the latest Windows binaries
> >   built with OpenSSL 1.0.2k
> >
> > It can be obtained from:
> > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.42/
> > The Maven staging repo is:
> > https://repository.apache.org/content/repositories/orgapachetomcat-1122/
> > The svn tag is:
> > http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_42/
> >
> > The proposed 8.0.42 release is:
> > [ ] Broken - do not release
> > [ X ] Stable - go ahead and release as 8.0.42
>

Regards,
Martin


> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > For additional commands, e-mail: dev-h...@tomcat.apache.org
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 7.0.76

2017-03-13 Thread Martin Grigorov
On Thu, Mar 9, 2017 at 3:11 PM, Mark Thomas  wrote:

> The proposed Apache Tomcat 7.0.76 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.76/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1123/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_76/
>
> The proposed 7.0.76 release is:
> [ ] Broken - do not release
> [ X ] Stable - go ahead and release as 7.0.76 Stable
>

Regards,
Martin


> Regards,
> Violeta
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 8.5.12

2017-03-13 Thread Martin Grigorov
On Mar 8, 2017 7:56 PM, "Mark Thomas"  wrote:

The proposed Apache Tomcat 8.5.12 release is now available for voting.

The major changes compared to the 8.5.11 release are:

- Updates to the early access version of the Serlet 4.0 API to align it
  with the most recent discussions in the Servlet EG

- Support for Java 9 during annotation scanning

- Update Tomcat Native to 1.2.12 to pick up the latest Windows binaries
  built with OpenSSL 1.0.2k

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.12/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1121/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_12/

The proposed 8.5.12 release is:
[ ] Broken - do not release
[ X ] Stable - go ahead and release as 8.5.12


Regards,
Martin


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org


Re: Read events suspend/resume logic in websocket impl to achieve backpressure

2017-02-06 Thread Martin Grigorov
Hi Violeta,

On Mon, Feb 6, 2017 at 8:55 PM, Violeta Georgieva 
wrote:

> Hi,
>
> Currently JSR356 provides possibility to add message handlers in order to
> receive web socket
> messages but there is no way to instruct the web socket implementation to
> suspend for a while
> the incoming messages (backpressure) so that the application is able to
> process the already delivered messages.
> The other web containers (Jetty, Undertow) supports such functionality so I
> would like to introduce it in Tomcat.
> Here [1] I prepared one possible implementation.
>
> What do you think about this feature and the proposed implementation?
>

It think it would be better to create a Pull Request even if the work is
not complete.
This way others will be able to comment on the changes and everyone here at
dev@ will see the comments.
At the moment it is possible to comment on your commits (in your repo) but
then only you will receive the feedback.
With [2] it is much easier to see the whole diff but it is not possible to
comment on it.


>
> Regards,
> Violeta
> [1] https://github.com/violetagg/tomcat/commits/ws-suspend-resume
>

[2]
https://github.com/apache/tomcat/compare/trunk...violetagg:ws-suspend-resume


Re: Publish snapshots from the Buidlbot

2017-01-24 Thread Martin Grigorov
Hi,

On Mon, Jan 23, 2017 at 11:53 AM, Mark Thomas  wrote:

> I think it would be useful if we configured buildbot to publish
> snapshots (probably as part of the daily build) to repository.a.o.
> Therefore I have requested the appropriate credentials from infra and
> when I have them I'll make the necessary changes tot he buildbot config.
> It might also be necessary to tweak our build scripts.
>

+1
I think Spring Boot folks will find them useful! And anyone else who embeds
Tomcat.



>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [ANN] New committer: Emmanuel Bourg

2017-01-21 Thread Martin Grigorov
On Jan 20, 2017 7:12 PM, "Mark Thomas"  wrote:

On behalf of the Tomcat committers I am pleased to announce that
Emmanuel Bourg (ebourg) has been voted in as a new Tomcat committer.

Please join me in welcoming him.


Welcome, Emmanuel!
And thank you for your work on Debian too!


Regards,

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org


Re: [VOTE] Release Apache Tomcat 8.0.41

2017-01-19 Thread Martin Grigorov
On Thu, Jan 19, 2017 at 12:07 AM, Violeta Georgieva 
wrote:

> The proposed Apache Tomcat 8.0.41 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.41/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1118/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_41/
>
> The proposed 8.0.41 release is:
> [ ] Broken - do not release
> [ X ] Stable - go ahead and release as 8.0.41
>

Regards,
Martin


>
> Regards,
> Violeta
>


Re: [VOTE] Release Apache Tomcat 7.0.75

2017-01-19 Thread Martin Grigorov
On Wed, Jan 18, 2017 at 10:45 PM, Violeta Georgieva 
wrote:

> The proposed Apache Tomcat 7.0.75 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.75/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1117/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_75/
>
> The proposed 7.0.75 release is:
> [ ] Broken - do not release
> [ X ] Stable - go ahead and release as 7.0.75 Stable
>

Regards,
Martin


>
> Regards,
> Violeta
>


Re: [VOTE] Release Apache Tomcat 8.0.40

2017-01-15 Thread Martin Grigorov
On Fri, Jan 13, 2017 at 1:39 PM, Violeta Georgieva 
wrote:

> The proposed Apache Tomcat 8.0.40 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.40/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1116/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_40/
>
> The proposed 8.0.40 release is:
> [ ] Broken - do not release
> [ X ] Stable - go ahead and release as 8.0.40
>

Regards,
Martin


>
> Regards,
> Violeta
>


Re: [VOTE] Release Apache Tomcat 7.0.74

2017-01-15 Thread Martin Grigorov
On Fri, Jan 13, 2017 at 11:55 AM, Violeta Georgieva 
wrote:

> The proposed Apache Tomcat 7.0.74 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.74/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1115/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_74/
>
> The proposed 7.0.74 release is:
> [ ] Broken - do not release
> [ X ] Stable - go ahead and release as 7.0.74 Stable
>

Regards,
Martin


>
> Regards,
> Violeta
>


Re: [VOTE] Release Apache Tomcat 9.0.0.M17

2017-01-12 Thread Martin Grigorov
On Tue, Jan 10, 2017 at 10:28 PM, Mark Thomas  wrote:

> The proposed Apache Tomcat 9.0.0.M17 release is now available for voting.
>
> This is a milestone release for the 9.0.x branch. It should be
> noted that, as a milestone release:
> - Servlet 4.0 is not finalised
> - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0
>
> The major changes compared to the 9.0.0.M15 release are:
>
> - HTTP/2 fixes and improvements
>
> - Improve the logic that selects an address to use to unlock the
>   Acceptor to take account of platforms what do not listen on all
>   local addresses when configured with an address of 0.0.0.0 or ::
>
> - Fix a bug in APR/native socket close handling that resulted in
>   unexpected errors for upgraded connections
>
> Along with lots of other bug fixes and improvements
>
> For full details, see the changelog:
> http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M17/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1112/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M17/
>
> The proposed 9.0.0.M17 release is:
> [ ] Broken - do not release
> [ X ] Alpha - go ahead and release as 9.0.0.M17
>

Regards,
Martin


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 8.5.11

2017-01-12 Thread Martin Grigorov
On Tue, Jan 10, 2017 at 10:28 PM, Mark Thomas  wrote:

> The proposed Apache Tomcat 8.5.11 release is now available for voting.
>
> The major changes compared to the 8.5.9 release are:
>
> - HTTP/2 fixes and improvements
>
> - Improve the logic that selects an address to use to unlock the
>   Acceptor to take account of platforms what do not listen on all
>   local addresses when configured with an address of 0.0.0.0 or ::
>
> - Fix a bug in APR/native socket close handling that resulted in
>   unexpected errors for upgraded connections
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.11/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1113/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_11/
>
> The proposed 8.5.11 release is:
> [ ] Broken - do not release
> [ X ] Stable - go ahead and release as 8.5.11
>

Regards,
Martin


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: Wrong type of the value of javax.servlet.error.exception_type

2017-01-09 Thread Martin Grigorov
Hi Chris,

On Fri, Jan 6, 2017 at 9:49 PM, Christopher Schultz <
ch...@christopherschultz.net> wrote:

> Martin,
>
> On 1/6/17 8:23 AM, Martin Grigorov wrote:
> > I've just upgraded my local/development Tomcat to 8.5.10 and I've hit a
> > problem in Apache Wicket:
> >
> > java.lang.ClassCastException: java.lang.String cannot be cast to
> > java.lang.Class
> > at
> > org.apache.wicket.protocol.http.servlet.ErrorAttributes.
> of(ErrorAttributes.java:152)
> >
> >
> > line 152 is:
> > Class type = (Class > Throwable>)request.getAttribute("javax.servlet.error.exception_type");
> >
> > In a debugger I see that the value is the class name, not the class
> itself.
> >
> > According to
> > http://download.oracle.com/otn-pub/jcp/servlet-3.0-fr-
> eval-oth-JSpec/servlet-3_0-final-spec.pdf,
> > p.10.9.1, table 10-1 the type of the value should be:
> >
> > Request Attributes  Type
> > javax.servlet.error.status_code java.lang.Integer
> > javax.servlet.error.exception_type java.lang.Class   <<< a Class
> > javax.servlet.error.message java.lang.String
> > javax.servlet.error.exception java.lang.Throwable
> > javax.servlet.error.request_uri java.lang.String
> > javax.servlet.error.servlet_name java.lang.String
> >
> >
> > I didn't see any change related to this between 8.5.8 and 8.5.10 so I'm
> not
> > sure whether this should be a stopper for the release of 8.5.10.
>
> I only see a single instance of javax.servlet.error.exception_type in
> 8.5 trunk (in javax/servlet/RequestDispatcher.ERROR_EXCEPTION_TYPE) and
> a single use of ERROR_EXCEPTION_TYPE itself (in
> o.a.c.core.StandardHostValve) and the code is fairly straightforward:
>
> // line 330:
> request.setAttribute(RequestDispatcher.ERROR_EXCEPTION_TYPE,
>   realError.getClass());
>
> The reference "realError" is a java.lang.Throwable, and, presumably,
> realError.getClass will always return a java.lang.Class object.
>
> Can you see where that request attribute is being set in your test? I
> wonder if either Wicket or the application itself is abusing that
> request attribute.
>

Thanks for your answer!
Since Tomcat is not guilty here it must be the middleware! I've found it
easily:
https://github.com/spring-projects/spring-boot/search?utf8=%E2%9C%93=ERROR_EXCEPTION_TYPE
I'll log an issue at Spring Boot!



>
> -chris
>
>


Wrong type of the value of javax.servlet.error.exception_type

2017-01-06 Thread Martin Grigorov
Hi,

I've just upgraded my local/development Tomcat to 8.5.10 and I've hit a
problem in Apache Wicket:

java.lang.ClassCastException: java.lang.String cannot be cast to
java.lang.Class
at
org.apache.wicket.protocol.http.servlet.ErrorAttributes.of(ErrorAttributes.java:152)


line 152 is:
Class type = (Class)request.getAttribute("javax.servlet.error.exception_type");

In a debugger I see that the value is the class name, not the class itself.

According to
http://download.oracle.com/otn-pub/jcp/servlet-3.0-fr-eval-oth-JSpec/servlet-3_0-final-spec.pdf,
p.10.9.1, table 10-1 the type of the value should be:

Request Attributes  Type
javax.servlet.error.status_code java.lang.Integer
javax.servlet.error.exception_type java.lang.Class   <<< a Class
javax.servlet.error.message java.lang.String
javax.servlet.error.exception java.lang.Throwable
javax.servlet.error.request_uri java.lang.String
javax.servlet.error.servlet_name java.lang.String


I didn't see any change related to this between 8.5.8 and 8.5.10 so I'm not
sure whether this should be a stopper for the release of 8.5.10.

Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov


Re: [VOTE] Release Apache Tomcat 8.5.10

2017-01-06 Thread Martin Grigorov
[ X ] Stable - go ahead and release as 8.5.10

Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov

On Fri, Jan 6, 2017 at 12:38 AM, Mark Thomas <ma...@apache.org> wrote:

> The proposed Apache Tomcat 8.5.10 release is now available for voting.
>
> The major changes compared to the 8.5.9 release are:
>
> - HTTP/2 fixes and improvements
>
> - Simpler JSP file encoding detector that delegates XML prolog
>   encoding detection to the JRE rather than using a custom XML
>   parser.
>
> - Improve the logic that selects an address to use to unlock the
>   Acceptor to take account of platforms what do not listen on all
>   local addresses when configured with an address of 0.0.0.0 or ::
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.10/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_10/
>
> The proposed 8.5.10 release is:
> [ ] Broken - do not release
> [ ] Stable - go ahead and release as 8.5.10
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: svn commit: r1774526 - in /tomcat/trunk/java/org/apache/jasper: compiler/EncodingDetector.java security/SecurityClassLoad.java

2016-12-15 Thread Martin Grigorov
Hi Mark,

On Thu, Dec 15, 2016 at 10:34 PM,  wrote:

> Author: markt
> Date: Thu Dec 15 21:34:06 2016
> New Revision: 1774526
>
> URL: http://svn.apache.org/viewvc?rev=1774526=rev
> Log:
> Add a new encoding detector implementation.
> The BoM encoding detection is based in the previous code.
> The prolog encoding detection delegates to the JRE's XM than the custom Jasper parser.
>
> Added:
> tomcat/trunk/java/org/apache/jasper/compiler/EncodingDetector.java
>  (with props)
> Modified:
> tomcat/trunk/java/org/apache/jasper/security/SecurityClassLoad.java
>
> Added: tomcat/trunk/java/org/apache/jasper/compiler/EncodingDetector.java
> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/
> jasper/compiler/EncodingDetector.java?rev=1774526=auto
> 
> ==
> --- tomcat/trunk/java/org/apache/jasper/compiler/EncodingDetector.java
> (added)
> +++ tomcat/trunk/java/org/apache/jasper/compiler/EncodingDetector.java
> Thu Dec 15 21:34:06 2016
> @@ -0,0 +1,214 @@
> +/*
> + * Licensed to the Apache Software Foundation (ASF) under one or more
> + * contributor license agreements.  See the NOTICE file distributed with
> + * this work for additional information regarding copyright ownership.
> + * The ASF licenses this file to You under the Apache License, Version 2.0
> + * (the "License"); you may not use this file except in compliance with
> + * the License.  You may obtain a copy of the License at
> + *
> + *  http://www.apache.org/licenses/LICENSE-2.0
> + *
> + * Unless required by applicable law or agreed to in writing, software
> + * distributed under the License is distributed on an "AS IS" BASIS,
> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
> implied.
> + * See the License for the specific language governing permissions and
> + * limitations under the License.
> + */
> +package org.apache.jasper.compiler;
> +
> +import java.io.BufferedInputStream;
> +import java.io.IOException;
> +import java.io.InputStream;
> +
> +import javax.xml.stream.XMLInputFactory;
> +import javax.xml.stream.XMLStreamException;
> +import javax.xml.stream.XMLStreamReader;
> +
> +/*
> + * The BoM detection is derived from:
> + * http://svn.us.apache.org/viewvc/tomcat/trunk/java/org/
> apache/jasper/xmlparser/XMLEncodingDetector.java?annotate=1742248
> + */
> +class EncodingDetector {
> +
> +private static final XMLInputFactory XML_INPUT_FACTORY;
> +static {
> +XML_INPUT_FACTORY = XMLInputFactory.newFactory();
> +}
> +
> +private final BomResult bomResult;
> +private final String prologEncoding;
> +
> +
> +/*
> + * TODO: Refactor Jasper InputStream creation and handling so the
> + *   InputStream passed to this method is buffered and therefore
> saves
> + *   on multiple opening and re-opening of the same file.
> + */
> +EncodingDetector(InputStream is) throws IOException {
> +// Keep buffer size to a minimum here. BoM will be no more than 4
> bytes
> +// so that is the maximum we need to buffer
> +BufferedInputStream bis = new BufferedInputStream(is, 4);
> +bis.mark(4);
> +
> +bomResult = processBom(bis);
> +
> +// Reset the stream back to the start to allow the XML prolog
> detection
> +// to work. Skip any BoM we discovered.
> +bis.reset();
> +if (bomResult != null) {
> +for (int i = 0; i < bomResult.skip; i++) {
> +is.read();
> +}
> +}
> +
> +prologEncoding = getPrologEncoding(bis);
> +}
> +
> +
> +String getBomEncoding() {
> +return bomResult.encoding;
> +}
> +
> +
> +Boolean getBigEndian() {
> +return bomResult.bigEndian;
> +}
> +
> +
> +int getSkip() {
> +return bomResult.skip;
> +}
> +
> +
> +String getPrologEncoding() {
> +return prologEncoding;
> +}
> +
> +
> +private String getPrologEncoding(InputStream stream) {
> +String encoding = null;
> +try {
> +XMLStreamReader xmlStreamReader = XML_INPUT_FACTORY.
> createXMLStreamReader(stream);
> +encoding = xmlStreamReader.getCharacterEncodingScheme();
> +} catch (XMLStreamException e) {
> +// Ignore
> +}
> +return encoding;
> +}
> +
> +
> +private BomResult processBom(InputStream stream) {
> +// Read first four bytes (or as many are available) and determine
> +// encoding
> +try {
> +final byte[] b4 = new byte[4];
> +int count = 0;
> +int singleByteRead;
> +while (count < 4) {
> +singleByteRead = stream.read();
> +if (singleByteRead == -1) {
> +break;
> +}
> +b4[count] = (byte) singleByteRead;
> +count++;
> +}
> +
> +return 

Re: [VOTE] Release Apache Tomcat 7.0.73

2016-11-10 Thread Martin Grigorov
[ X ] Stable - go ahead and release as 7.0.73 Stable

Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov

On Mon, Nov 7, 2016 at 11:15 PM, Violeta Georgieva <violet...@apache.org>
wrote:

> The proposed Apache Tomcat 7.0.73 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.73/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1106/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_73/
>
> The proposed 7.0.73 release is:
> [ ] Broken - do not release
> [ ] Stable - go ahead and release as 7.0.73 Stable
>
> Regards,
> Violeta
>


Re: [VOTE] Release Apache Tomcat 8.0.39

2016-11-10 Thread Martin Grigorov
[ X ] Stable - go ahead and release as 8.0.39

On Wed, Nov 9, 2016 at 10:41 AM, Violeta Georgieva 
wrote:

> The proposed Apache Tomcat 8.0.39 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.39/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1107/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_39/
>
> The proposed 8.0.39 release is:
> [ ] Broken - do not release
> [ ] Stable - go ahead and release as 8.0.39
>
> Regards,
> Violeta
>


Re: [VOTE] Release Apache Tomcat 8.5.8

2016-11-07 Thread Martin Grigorov
On Thu, Nov 3, 2016 at 10:50 PM, Mark Thomas  wrote:

> The proposed Apache Tomcat 8.5.8 release is now available for voting.
>
> 8.5.8 corrects a regression 8.5.7.
>
> The major changes compared to the 8.5.6 release are:
>
> - Implement header limits for HTTP/2
>
> - Improve handling of I/O errors with async processing
>
> - Fail earlier on invalid HTTP requests
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.8/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1104/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_8/
>
> The proposed 8.5.8 release is:
> [ ] Broken - do not release
> [ X ] Stable - go ahead and release as 8.5.8
>

Tested my daily job app and Apache Wicket Native WebSocket demo app


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 6.0.47

2016-10-15 Thread Martin Grigorov
On Thu, Oct 13, 2016 at 12:51 PM, Violeta Georgieva 
wrote:

> The proposed Apache Tomcat 6.0.47 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-6/v6.0.47/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1100/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc6.0.x/tags/TOMCAT_6_0_47/
>
> The proposed 6.0.47 release is:
> [ ] Broken - do not release
> [ X ] Stable - go ahead and release as 6.0.47 Stable
>
> Regards,
> Violeta
>


Re: svn commit: r1764897 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/core/ java/org/apache/catalina/startup/ java/org/apache/catalina/valves/rewrite/ test/org/apache/tomcat/

2016-10-15 Thread Martin Grigorov
On Sat, Oct 15, 2016 at 5:26 PM, Rémy Maucherat <r...@apache.org> wrote:

> 2016-10-15 11:17 GMT+02:00 Martin Grigorov <mgrigo...@apache.org>:
>
> > Hi Remy,
> >
> > On Fri, Oct 14, 2016 at 3:46 PM, <r...@apache.org> wrote:
> > >  return (logger);
> > > -logger = LogFactory.getLog(logName());
> > > +logger = LogFactory.getLog(getLogName());
> > >
> >
> > What would be the behavior here if #getLogName() returns null ?
> >
>
> It's bad and would cause NPEs.
>
> >
> > >  @Override
> > > +public String getLogName() { return null; }
> > >
> >
> > Maybe it is better to return something like "FailedContextLog" instead ?!
> > This is related to the first question above.
> >
>
> It's not used, and if it is it will cause a NPE like getLogger.
>

If it is never used then it is OK!
Thanks!


>
> Rémy
>


Re: svn commit: r1764897 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/core/ java/org/apache/catalina/startup/ java/org/apache/catalina/valves/rewrite/ test/org/apache/tomcat/

2016-10-15 Thread Martin Grigorov
Hi Remy,

On Fri, Oct 14, 2016 at 3:46 PM,  wrote:

> Author: remm
> Date: Fri Oct 14 13:46:45 2016
> New Revision: 1764897
>
> URL: http://svn.apache.org/viewvc?rev=1764897=rev
> Log:
> Inspired by 60161: Allow creating subcategories from the container logger
> name. The configuration remains compatible, but some possibly logging
> intensive components get their own playground. Use it for the rewrite valve.
>
> Modified:
> tomcat/trunk/java/org/apache/catalina/Container.java
> tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java
> tomcat/trunk/java/org/apache/catalina/startup/FailedContext.java
> tomcat/trunk/java/org/apache/catalina/valves/rewrite/RewriteValve.java
> tomcat/trunk/test/org/apache/tomcat/unittest/TesterContext.java
> tomcat/trunk/test/org/apache/tomcat/unittest/TesterHost.java
> tomcat/trunk/webapps/docs/changelog.xml
>
> Modified: tomcat/trunk/java/org/apache/catalina/Container.java
> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/
> catalina/Container.java?rev=1764897=1764896=1764897=diff
> 
> ==
> --- tomcat/trunk/java/org/apache/catalina/Container.java (original)
> +++ tomcat/trunk/java/org/apache/catalina/Container.java Fri Oct 14
> 13:46:45 2016
> @@ -123,6 +123,13 @@ public interface Container extends Lifec
>
>
>  /**
> + * Return the logger name that the container will use.
> + * @return the abbreviated name of this container for logging messages
> + */
> +public String getLogName();
> +
> +
> +/**
>   * Obtain the JMX name for this container.
>   *
>   * @return the JMX name associated with this container.
>
> Modified: tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java
> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/
> catalina/core/ContainerBase.java?rev=1764897=1764896&
> r2=1764897=diff
> 
> ==
> --- tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java
> (original)
> +++ tomcat/trunk/java/org/apache/catalina/core/ContainerBase.java Fri Oct
> 14 13:46:45 2016
> @@ -357,13 +357,41 @@ public abstract class ContainerBase exte
>
>  if (logger != null)
>  return (logger);
> -logger = LogFactory.getLog(logName());
> +logger = LogFactory.getLog(getLogName());
>

What would be the behavior here if #getLogName() returns null ?


>  return (logger);
>
>  }
>
>
>  /**
> + * @return the abbreviated name of this container for logging messages
> + */
> +@Override
> +public String getLogName() {
> +
> +if (logName != null) {
> +return logName;
> +}
> +String loggerName = null;
> +Container current = this;
> +while (current != null) {
> +String name = current.getName();
> +if ((name == null) || (name.equals(""))) {
> +name = "/";
> +} else if (name.startsWith("##")) {
> +name = "/" + name;
> +}
> +loggerName = "[" + name + "]"
> ++ ((loggerName != null) ? ("." + loggerName) : "");
> +current = current.getParent();
> +}
> +logName = ContainerBase.class.getName() + "." + loggerName;
> +return logName;
> +
> +}
> +
> +
> +/**
>   * Return the Cluster with which this Container is associated.  If
> there is
>   * no associated Cluster, return the Cluster associated with our
> parent
>   * Container (if any); otherwise return null.
> @@ -1183,33 +1211,6 @@ public abstract class ContainerBase exte
>  }
>
>
> -/**
> - * @return the abbreviated name of this container for logging messages
> - */
> -protected String logName() {
> -
> -if (logName != null) {
> -return logName;
> -}
> -String loggerName = null;
> -Container current = this;
> -while (current != null) {
> -String name = current.getName();
> -if ((name == null) || (name.equals(""))) {
> -name = "/";
> -} else if (name.startsWith("##")) {
> -name = "/" + name;
> -}
> -loggerName = "[" + name + "]"
> -+ ((loggerName != null) ? ("." + loggerName) : "");
> -current = current.getParent();
> -}
> -logName = ContainerBase.class.getName() + "." + loggerName;
> -return logName;
> -
> -}
> -
> -
>  //  JMX and Registration  
>
>  @Override
>
> Modified: tomcat/trunk/java/org/apache/catalina/startup/FailedContext.java
> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/
> catalina/startup/FailedContext.java?rev=1764897=1764896=1764897&
> view=diff
> 

Re: 8.5.6 @ central

2016-10-12 Thread Martin Grigorov
Hi,

I've just released 8.0.38, 8.5.6 and 9.0.0.M11 from Apache Nexus to Maven
Central.
They must be publicly available in few hours.

Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov

On Wed, Oct 12, 2016 at 7:54 AM, Romain Manni-Bucau <rmannibu...@gmail.com>
wrote:

> Hi guys,
>
> seems 8.5.6 didnt hit central yet and is still in staging even if the
> announce was sent, as it intended?
>
> PS: I'm interested in 8.5.6 but other "co-"votes are in the same state I
> think
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> <https://blog-rmannibucau.rhcloud.com> | Old Wordpress Blog
> <http://rmannibucau.wordpress.com> | Github <https://github.com/
> rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber
> <http://www.tomitribe.com> | JavaEE Factory
> <https://javaeefactory-rmannibucau.rhcloud.com>
>


Re: [VOTE] Release Apache Tomcat 9.0.0.M11

2016-10-08 Thread Martin Grigorov
On Thu, Oct 6, 2016 at 9:51 PM, Mark Thomas  wrote:

> The proposed Apache Tomcat 9.0.0.M11 release is now available for voting.
>
> This is a milestone release for the 9.0.x branch. It should be
> noted that, as a milestone release:
> - Servlet 4.0 is not finalised
> - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0
>
> The major changes compared to the 9.0.0.M10 release are:
>
> - Refactoring the non-container thread Async complete()/dispatch()
>   handling to remove the possibility of deadlock
>
> - Update the packaged version of the Tomcat Native Library to
>   1.2.10 to pick up the latest Windows binaries built with
>   OpenSSL 1.0.2j
>
> - Improved UTF-8 handling for the RewriteValve
>
> Along with lots of other bug fixes and improvements
>
> For full details, see the changelog:
> http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M11/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1096/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M11/
>
> The proposed 9.0.0.M11 release is:
> [ ] Broken - do not release
> [ X ] Alpha - go ahead and release as 9.0.0.M11
>

+1 to release


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 8.5.6

2016-10-07 Thread Martin Grigorov
Hi Mark,

On Fri, Oct 7, 2016 at 6:39 PM, Mark Thomas <ma...@apache.org> wrote:

> On 07/10/2016 15:51, Mark Thomas wrote:
> > On 07/10/2016 14:50, Martin Grigorov wrote:
> >> On Thu, Oct 6, 2016 at 10:33 PM, Mark Thomas <ma...@apache.org> wrote:
> >>
> >>> The proposed Apache Tomcat 8.5.6 release is now available for voting.
> >>>
> >>> The major changes compared to the 8.5.5 release are:
> >>>
> >>> - Refactoring the non-container thread Async complete()/dispatch()
> >>>   handling to remove the possibility of deadlock
> >>>
> >>> - Update the packaged version of the Tomcat Native Library to
> >>>   1.2.10 to pick up the latest Windows binaries built with
> >>>   OpenSSL 1.0.2j
> >>>
> >>> - Improved UTF-8 handling for the RewriteValve
> >>>
> >>>
> >>> It can be obtained from:
> >>> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.6/
> >>> The Maven staging repo is:
> >>> https://repository.apache.org/content/repositories/
> orgapachetomcat-1097/
> >>> The svn tag is:
> >>> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_6/
> >>>
> >>> The proposed 8.5.6 release is:
> >>> [ ] Broken - do not release
> >>> [ ] Alpha  - go ahead and release as 8.5.6
> >>> [ ] Beta   - go ahead and release as 8.5.6
> >>> [ X ] Stable - go ahead and release as 8.5.6
> >>>
> >>
> >> The only thing that bothers me a bit is that I have a lot of those
> during
> >> start:
> >>
> >> 07-Oct-2016 15:27:58.342 WARNING [RMI TCP Connection(4)-127.0.0.1]
> >> org.apache.catalina.webresources.Cache.getResource Unable to add the
> >> resource at [/WEB-INF/lib/lucene-memory-5.5.2.jar] to the cache because
> >> there was insufficient free space available after evicting expired cache
> >> entries - consider increasing the maximum size of the cache
> >
> > I suspect that this is the cause:
> >
> > https://bz.apache.org/bugzilla/show_bug.cgi?id=60146
> >
> > We might need to tweak the caching algorithm and/or config.
>
> I haven't been able to reproduce this with a simple test. Can you do
> some debugging and see what code path is triggering the loading of the
> JAR files this way.
>

Here is the stacktrace: http://imgur.com/a/ioRY4
I use the sources of the voted 8.5.6, not the latest 8.5.x.


>
> >> I believe there is an entry for each library of my applications and for
> >> (all ?!) .properties and .xml files in the classpath.
> >>
> >> If this is normal then the message could be improved to say which cache
> I
> >> need to touch.
> >
> > The message could be improved regardless.
>
> Done.
>

It is still not clear to me.
Where I can change the maxSize of this cache ?
https://tomcat.apache.org/tomcat-8.5-doc/index.html doesn't mention
"cache". It is not searchable in the content of the linked pages. Also
Google doesn't give me good results - it finds the javadoc of this class
but this doesn't tell me as a user what should I do.
Is it a good idea to add more details in the log message like "...increase
the max size at $CATALINA_BASE/conf/some.xml > Host > Cache" ?


>
> Mark
>
>
> >
> > Mark
> >
> >
> >>
> >> The only thing I've changed in the default configuration was to enable
> the
> >> HTTP2 connector:
> >>
> >> 07-Oct-2016 15:13:07.634 INFO [main]
> >> org.apache.catalina.core.AprLifecycleListener.lifecycleEvent Loaded APR
> >> based Apache Tomcat Native library 1.2.10 using APR version 1.5.2.
> >> 07-Oct-2016 15:13:07.634 INFO [main]
> >> org.apache.catalina.core.AprLifecycleListener.lifecycleEvent APR
> >> capabilities: IPv6 [true], sendfile [true], accept filters [false],
> random
> >> [true].
> >> 07-Oct-2016 15:13:07.634 INFO [main]
> >> org.apache.catalina.core.AprLifecycleListener.lifecycleEvent
> APR/OpenSSL
> >> configuration: useAprConnector [false], useOpenSSL [true]
> >> 07-Oct-2016 15:13:07.637 INFO [main]
> >> org.apache.catalina.core.AprLifecycleListener.initializeSSL OpenSSL
> >> successfully initialized (OpenSSL 1.0.2e 3 Dec 2015)
> >> 07-Oct-2016 15:13:07.756 INFO [main]
> >> org.apache.coyote.AbstractProtocol.init Initializing ProtocolHandler
> >> ["http-nio-8

Re: [VOTE] Release Apache Tomcat 8.5.6

2016-10-07 Thread Martin Grigorov
On Thu, Oct 6, 2016 at 10:33 PM, Mark Thomas  wrote:

> The proposed Apache Tomcat 8.5.6 release is now available for voting.
>
> The major changes compared to the 8.5.5 release are:
>
> - Refactoring the non-container thread Async complete()/dispatch()
>   handling to remove the possibility of deadlock
>
> - Update the packaged version of the Tomcat Native Library to
>   1.2.10 to pick up the latest Windows binaries built with
>   OpenSSL 1.0.2j
>
> - Improved UTF-8 handling for the RewriteValve
>
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.6/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1097/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_6/
>
> The proposed 8.5.6 release is:
> [ ] Broken - do not release
> [ ] Alpha  - go ahead and release as 8.5.6
> [ ] Beta   - go ahead and release as 8.5.6
> [ X ] Stable - go ahead and release as 8.5.6
>

The only thing that bothers me a bit is that I have a lot of those during
start:

07-Oct-2016 15:27:58.342 WARNING [RMI TCP Connection(4)-127.0.0.1]
org.apache.catalina.webresources.Cache.getResource Unable to add the
resource at [/WEB-INF/lib/lucene-memory-5.5.2.jar] to the cache because
there was insufficient free space available after evicting expired cache
entries - consider increasing the maximum size of the cache

I believe there is an entry for each library of my applications and for
(all ?!) .properties and .xml files in the classpath.

If this is normal then the message could be improved to say which cache I
need to touch.

The only thing I've changed in the default configuration was to enable the
HTTP2 connector:

07-Oct-2016 15:13:07.634 INFO [main]
org.apache.catalina.core.AprLifecycleListener.lifecycleEvent Loaded APR
based Apache Tomcat Native library 1.2.10 using APR version 1.5.2.
07-Oct-2016 15:13:07.634 INFO [main]
org.apache.catalina.core.AprLifecycleListener.lifecycleEvent APR
capabilities: IPv6 [true], sendfile [true], accept filters [false], random
[true].
07-Oct-2016 15:13:07.634 INFO [main]
org.apache.catalina.core.AprLifecycleListener.lifecycleEvent APR/OpenSSL
configuration: useAprConnector [false], useOpenSSL [true]
07-Oct-2016 15:13:07.637 INFO [main]
org.apache.catalina.core.AprLifecycleListener.initializeSSL OpenSSL
successfully initialized (OpenSSL 1.0.2e 3 Dec 2015)
07-Oct-2016 15:13:07.756 INFO [main]
org.apache.coyote.AbstractProtocol.init Initializing ProtocolHandler
["http-nio-8080"]
07-Oct-2016 15:13:07.769 INFO [main]
org.apache.tomcat.util.net.NioSelectorPool.getSharedSelector Using a shared
selector for servlet write/read
07-Oct-2016 15:13:07.773 INFO [main]
org.apache.coyote.http11.AbstractHttp11Protocol.configureUpgradeProtocol
The ["https-openssl-apr-8443"] connector has been configured to support
negotiation to [h2] via ALPN
07-Oct-2016 15:13:07.773 INFO [main]
org.apache.coyote.AbstractProtocol.init Initializing ProtocolHandler
["https-openssl-apr-8443"]











>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: Deploying Tomcat on Snappy Ubuntu Core

2016-09-20 Thread Martin Grigorov
Hi Chris,

On Tue, Sep 20, 2016 at 10:51 PM, Christopher Schultz <
ch...@christopherschultz.net> wrote:

> Martin,
>
> On 9/20/16 3:28 PM, Martin Grigorov wrote:
> > Hi Michael,
> >
> > On Tue, Sep 20, 2016 at 9:11 PM, Michael Hall <mhall...@gmail.com>
> wrote:
> >
> >> Hi Martin,
> >>
> >>
> >> On 09/20/2016 02:56 PM, Martin Grigorov wrote:
> >>> Hi Michael,
> >>>
> >>> On Tue, Sep 20, 2016 at 3:10 PM, Michael Hall <mhall...@gmail.com>
> >> wrote:
> >>>
> >>>> Hi Coty,
> >>>>
> >>>> Have you had an opportunity to try this yet? If you need help please
> let
> >>>> me know, or you could find help on #snappy on Freenode or
> >>>> https://gitter.im/ubuntu/snappy-playpen (a new slack-like service
> >>>> connected to github)
> >>>>
> >>>
> >>> I am an Ubuntu user and I've tried once Snap.
> >>> I've installed the featured Notes application and I was amazed to see
> >> that
> >>> it downloaded 60Mb for such a simple application! After being unzipped
> it
> >>> is 196MB !!
> >>> Then I removed it.
> >>> I hope Canonical will keep .deb around for the near future!
> >>>
> >>
> >> .deb package aren't going away, snaps are just a new option that bring a
> >>
> >
> > Yes, I know that .deb isn't going away.
> > I just said it to express my frustration with those 196MB.
> >
> >
> >> lot of benefit. Desktop apps like Notes are currently quite large
> >> because they bundle the whole GUI toolkit that they use. This is
> >> something that has a solution underway, but it won't affect services
> >> like tomcat nearly as much,
> >>
> >> The Tomcat snap does include a JRE though, so you always know that one
> >> is available and that Tomcat will work with it. Even with that the
> >>
> >
> > What if I need different combination of Tomcat and JRE versions than what
> > your Snap versions provide ?
> > Let's say I experience some bug in the bundled JRE version (e.g. X) and
> > your next Snap version bundles JRE X+1 but also Tomcat Y+1.
> > What if I need JRE X+1 and Tomcat Y because there is a regression in Y+1
> ?
> > Just thinking loud here.
> >
> >
> >> resulting snap is only 48MB. Snaps are never "unzipped", instead they
> >> are loop-mounted into your filesystem, so the download size is the
> >>
> >
> > I haven't read about squashfs, so I'm not sure how exactly it works.
> > 196MB is what "du" program reports.
> > If it is not disk size then I hope this 60MB download is not unzipped in
> > the RAM.
> > http://snapcraft.io/ says "That directory will be compressed into a
> > squashfs - a zipped directory - and then it will be mounted at
> > /snap//current when the snap is installed."
>
> It's like an executable JAR file, except that the kernel loads the thing
> as a filesystem. So 'du' will tell you it's bigger than it actually is
> (it's bigger on the inside than it is on the outside).


> That 60MiB download isn't being uncompressed elsewhere on the disk or
> into RAM. It's being decompressed on the fly as necessary, just like a
> remotely-mounted filesystem isn't copied locally whenever you access
> files. Sore, a file or two might have some parts cached locally, but you
> aren't sucking-down your entire multi-petabyte SAN contents when you
> login to your corporate network.
>

Thanks for the explanation!
But I think the example with reading data from SAN is not exactly the same
as executing a process in the kernel.
To start the process the kernel needs to load (big?!) part of the zipped
bundle. Everything else might be loaded if needed later.

1) Dealing with compressed data is definitely slower than dealing with
uncompressed data, and this is valid both for startup time and runtime.
2) Snaps share nothing, by design. So if more than one app needs the same
dependency then it is not just about the disk space but also duplicated
stuff in memory. This is advertized as Pros but for me is Cons.
3) I cannot find any information about a running Notes app (I've installed
it again for the testing!) neither with 'ps', nor with 'htop', nor with
'snap'. All I can find is a parent 'snapd' process with several forks. If I
need to install a spy software I'll pack it as a Snap :-)

So far I see more drawbacks than benefits. But I am a developer with a
desktop. I guess the points above might not be a problem for server
administrators.


>
> -chris
>
>


Re: Deploying Tomcat on Snappy Ubuntu Core

2016-09-20 Thread Martin Grigorov
Hi Michael,

On Tue, Sep 20, 2016 at 9:11 PM, Michael Hall <mhall...@gmail.com> wrote:

> Hi Martin,
>
>
> On 09/20/2016 02:56 PM, Martin Grigorov wrote:
> > Hi Michael,
> >
> > On Tue, Sep 20, 2016 at 3:10 PM, Michael Hall <mhall...@gmail.com>
> wrote:
> >
> >> Hi Coty,
> >>
> >> Have you had an opportunity to try this yet? If you need help please let
> >> me know, or you could find help on #snappy on Freenode or
> >> https://gitter.im/ubuntu/snappy-playpen (a new slack-like service
> >> connected to github)
> >>
> >
> > I am an Ubuntu user and I've tried once Snap.
> > I've installed the featured Notes application and I was amazed to see
> that
> > it downloaded 60Mb for such a simple application! After being unzipped it
> > is 196MB !!
> > Then I removed it.
> > I hope Canonical will keep .deb around for the near future!
> >
>
> .deb package aren't going away, snaps are just a new option that bring a
>

Yes, I know that .deb isn't going away.
I just said it to express my frustration with those 196MB.


> lot of benefit. Desktop apps like Notes are currently quite large
> because they bundle the whole GUI toolkit that they use. This is
> something that has a solution underway, but it won't affect services
> like tomcat nearly as much,
>
> The Tomcat snap does include a JRE though, so you always know that one
> is available and that Tomcat will work with it. Even with that the
>

What if I need different combination of Tomcat and JRE versions than what
your Snap versions provide ?
Let's say I experience some bug in the bundled JRE version (e.g. X) and
your next Snap version bundles JRE X+1 but also Tomcat Y+1.
What if I need JRE X+1 and Tomcat Y because there is a regression in Y+1 ?
Just thinking loud here.


> resulting snap is only 48MB. Snaps are never "unzipped", instead they
> are loop-mounted into your filesystem, so the download size is the
>

I haven't read about squashfs, so I'm not sure how exactly it works.
196MB is what "du" program reports.
If it is not disk size then I hope this 60MB download is not unzipped in
the RAM.
http://snapcraft.io/ says "That directory will be compressed into a
squashfs - a zipped directory - and then it will be mounted at
/snap//current when the snap is installed."


> installed size.
>
> > About your package:
> > I see it uses "plugs: [network-bind]" to be able to bind the ports, but
> > does this also allow to make connections to external resources like a
> > remote DB for example ?
> >
>
> I would have to double check. There is a "network" interface that allows
> only out-bound connection, which can be added if "network-bind" doesn't
> already do that.
>

Thanks!


>
> >
> > Martin Grigorov
> > Wicket Training and Consulting
> > https://twitter.com/mtgrigorov
> >
> >
> >
> >>
> >> Michael Hall
> >> mhall...@gmail.com
> >>
> >> On 09/15/2016 10:06 AM, Michael Hall wrote:
> >>> Hi Coty,
> >>>
> >>> To learn more about snaps in general and how to make them you can go to
> >>> http://snapcraft.io/
> >>>
> >>> The tl;dr is that they are self-contained application bundles,
> including
> >>> dependencies, that are packed into a squashfs that is then loop-mounted
> >>> when installed. This means that the application's own files are
> >>> read-only and isolated from other apps and the system, which makes
> >>> updating them safe and simple. For Tomcat this means it includes a JRE,
> >>> OpenSSL, and anything else needed for Tomcat to run.
> >>>
> >>> I have attached the files needed to build a Tomcat snap using the the
> >>> Snapcraft tool (only available on Ubuntu currently), just run
> "snapcraft
> >>> snap" in the same directory as these files. The snapcrafy.yaml will
> pull
> >>> Tomcat 8.5.5 binary tarball as it's source, so no re-compiling is
> >>> needed. The run.sh simply sets some environment variables to their
> >>> proper snap-environment locations, copies the server.xml into
> >>> CATALINE_BASE (if it's not there), and starts Tomcat.
> >>>
> >>> Because the snapcraft.yaml declares this to be a daemon, it will create
> >>> a systemd service file upon installation and start it automatically.
> >>> Then you can copy a .war files into $CATALINA_BASE/webapps/ and Tomcat
> >>> will pick it up. I tested with the sample.war from
> >>> https://tomcat.a

Re: Deploying Tomcat on Snappy Ubuntu Core

2016-09-20 Thread Martin Grigorov
Hi Michael,

On Tue, Sep 20, 2016 at 3:10 PM, Michael Hall <mhall...@gmail.com> wrote:

> Hi Coty,
>
> Have you had an opportunity to try this yet? If you need help please let
> me know, or you could find help on #snappy on Freenode or
> https://gitter.im/ubuntu/snappy-playpen (a new slack-like service
> connected to github)
>

I am an Ubuntu user and I've tried once Snap.
I've installed the featured Notes application and I was amazed to see that
it downloaded 60Mb for such a simple application! After being unzipped it
is 196MB !!
Then I removed it.
I hope Canonical will keep .deb around for the near future!

About your package:
I see it uses "plugs: [network-bind]" to be able to bind the ports, but
does this also allow to make connections to external resources like a
remote DB for example ?


Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov



>
> Michael Hall
> mhall...@gmail.com
>
> On 09/15/2016 10:06 AM, Michael Hall wrote:
> > Hi Coty,
> >
> > To learn more about snaps in general and how to make them you can go to
> > http://snapcraft.io/
> >
> > The tl;dr is that they are self-contained application bundles, including
> > dependencies, that are packed into a squashfs that is then loop-mounted
> > when installed. This means that the application's own files are
> > read-only and isolated from other apps and the system, which makes
> > updating them safe and simple. For Tomcat this means it includes a JRE,
> > OpenSSL, and anything else needed for Tomcat to run.
> >
> > I have attached the files needed to build a Tomcat snap using the the
> > Snapcraft tool (only available on Ubuntu currently), just run "snapcraft
> > snap" in the same directory as these files. The snapcrafy.yaml will pull
> > Tomcat 8.5.5 binary tarball as it's source, so no re-compiling is
> > needed. The run.sh simply sets some environment variables to their
> > proper snap-environment locations, copies the server.xml into
> > CATALINE_BASE (if it's not there), and starts Tomcat.
> >
> > Because the snapcraft.yaml declares this to be a daemon, it will create
> > a systemd service file upon installation and start it automatically.
> > Then you can copy a .war files into $CATALINA_BASE/webapps/ and Tomcat
> > will pick it up. I tested with the sample.war from
> > https://tomcat.apache.org/tomcat-8.0-doc/appdev/sample/ and it works
> > with the servlet portion, but not the JSP (I suspect the JSP compilation
> > is trying write to use a read-only space, but haven't dug too far into
> it).
> >
> > If you don't run Ubuntu the easiest way to build the snap is in a VM or
> > container that has Ubuntu 16.04, just install the snapcraft package from
> > the archive. If you just want to try a pre-built binary, you can
> > download mine from http://people.ubuntu.com/~mhall119/snaps/
> >
> > You can install it on Ubuntu 16.04 or a derivative right away with "snap
> > install $snapfile --force-dangerous". The --force-dangerous is required
> > because the resulting snap won't be signed. On non-Ubuntu distros you
> > can get snaps running by following the instructions on
> > http://snapcraft.io/docs/core/install
> >
> >
> > Michael Hall
> > mhall...@ubuntu.com
> >
> > On 09/14/2016 11:23 PM, Coty Sutherland wrote:
> >> Hi Micheal,
> >>
> >> I hadn't heard of snaps (or used Ubuntu much) but the concept seems
> >> interesting to me. Would you be able to send me links to what you have
> >> so far so I can check it out? I have a few questions, but I'll reserve
> >> those until I get a chance to review what you have.
> >>
> >> Thanks!
> >>
> >>
> >> On Sep 14, 2016 3:51 PM, "Michael Hall" <mhall...@ubuntu.com
> >> <mailto:mhall...@ubuntu.com>> wrote:
> >>
> >> Hi everyone,
> >>
> >> Ubuntu has developed a new platform for deploying applications using
> >> bundled packages called "snaps". These make it easier to deploy and
> >> update on Ubuntu independently of it's release cycle (and on
> non-Ubuntu
> >> distros too for that matter). I would like to make Tomcat available
> in
> >> this format so it can be more easily used on lightweight cloud
> instances
> >> or devices like the Raspberry Pi.
> >>
> >> I have a working example of Tomcat as a snap, and it works really
> well
> >> with a separate read-only CATALINE_HOME and a writable, versioned
> >> CATALINA_BASE that will allow for atomic

Re: How could I get involved into tomcat development?

2016-09-20 Thread Martin Grigorov
Hi,

On Tue, Sep 20, 2016 at 5:50 PM, Tiramisu Ling  wrote:

> How could I take it if I do interest in that bug and want to work on it? I
> see those bugs been assigned to mail list already.
>

You can add a comment that you are working on it.
If you have any questions about the functionality you can ask them here
(dev@) or at us...@tomcat.apache.org if the answer could be known by a
non-committer, e.g. related to configuration, deployment, etc.

If you plan to hang around for longer time I'd recommend to read
https://wiki.apache.org/tomcat/FAQ/Tomcat_User too.

Have fun!

Martin


>
> > 在 2016年9月20日,下午11:22,Mark Thomas  写道:
> >
> >> On 20/09/2016 15:40, Tiramisu Ling wrote:
> >> Hey Mark, thank you for your help :) Do you mean
> >> https://bz.apache.org/bugzilla/show_bug.cgi?id=60008 above instead of
> bug
> >> 6008? Because it tells me bug id is unavailable for
> https://bz.apache.org/
> >> bugzilla/show_bug.cgi?id=6008.
> >
> > Sorry, I meant
> > https://bz.apache.org/bugzilla/show_bug.cgi?id=60087
> >
> > The last digit was lost in the copy/paste.
> >
> > Mark
> >
> >
> >>
> >> 2016-09-20 21:06 GMT+08:00 Mark Thomas :
> >>
>  On 20/09/2016 13:28, Tiramisu Ling wrote:
>  hello everyone,
> 
>  I'm a newbie in tomcat and I would like to get involved into it. Could
> >>> you
>  tell me where to start with it? How could I find something like 'good
> >>> first
>  bug'? Thank you very much :)
> >>>
> >>> A good bug to get started on is usually one that you care about and/or
> >>> are interested in so you are motivated to fix it.
> >>>
> >>> Some possibilities:
> >>> https://bz.apache.org/bugzilla/show_bug.cgi?id=55969
> >>> I'd recommend starting with item 3, then 2 and finally 1.
> >>>
> >>> https://bz.apache.org/bugzilla/show_bug.cgi?id=6008
> >>> Not sure how complex fixing this would be. Just having a clear
> >>> explanation of what is going on would be useful.
> >>>
> >>> Other than that, take a look at the open bugs and pick one you think is
> >>> interesting. Even if you can't fix it, if you can put together a patch
> >>> that adds a test case that demonstrates it that would be a huge help.
> >>>
> >>> Mark
> >>>
> >>>
> >>> -
> >>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> >>> For additional commands, e-mail: dev-h...@tomcat.apache.org
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > For additional commands, e-mail: dev-h...@tomcat.apache.org
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 7.0.72

2016-09-14 Thread Martin Grigorov
On Wed, Sep 14, 2016 at 3:01 PM, Violeta Georgieva 
wrote:

> The proposed Apache Tomcat 7.0.72 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.72/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1095/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_72/
>
> The proposed 7.0.72 release is:
> [ ] Broken - do not release
> [ X ] Stable - go ahead and release as 7.0.72 Stable
>

+1 to release!


>
> Regards,
> Violeta
>


Re: [VOTE] Release Apache Tomcat 7.0.71

2016-09-09 Thread Martin Grigorov
On Wed, Sep 7, 2016 at 1:00 PM, Violeta Georgieva 
wrote:

> The proposed Apache Tomcat 7.0.71 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.71/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1094/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_71/
>
> The proposed 7.0.71 release is:
> [ ] Broken - do not release
> [ X ] Stable - go ahead and release as 7.0.71 Stable
>

Tested our main application and Apache Wicket WebSocket integration.


Just one minor thingy:

==> logs/catalina.out <==
Sep 09, 2016 9:59:56 PM org.apache.catalina.core.StandardServer await
WARNING: StandardServer.await: Invalid command '' received

I haven't noticed such log entry before.


>
> Regards,
> Violeta
>


Re: [VOTE] Release Apache Tomcat 8.0.37

2016-09-03 Thread Martin Grigorov
On Sep 1, 2016 1:57 PM, "Mark Thomas"  wrote:
>
> The proposed Apache Tomcat 8.0.37 release is now available for voting.
>
> The main changes since 8.0.36 are:
>
> - treat paths used to obtain a request dispatcher as encoded
>   (configurable)
>
> - update the packaged version of the Tomcat Native Library to 1.2.8
>
> - various jdbc-pool fixes
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.37/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1093/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_37/
>
> The proposed 8.0.37 release is:
> [ ] Broken - do not release
> [ X ] Stable - go ahead and release as 8.0.37

Tested with our main application.

>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>


Re: The magic phrase to auto-close the PR in github

2016-08-31 Thread Martin Grigorov
Hi,


On Wed, Aug 31, 2016 at 10:25 AM, Violeta Georgieva 
wrote:

> 2016-08-31 11:17 GMT+03:00 Mark Thomas :
> >
> > On 31/08/2016 09:16, Violeta Georgieva wrote:
> > > 2016-08-31 10:59 GMT+03:00 Mark Thomas :
> > >>
> > >> On 31/08/2016 08:47, Violeta Georgieva wrote:
> > >>> Hi Mark,
> > >>>
> > >>> 2016-08-10 14:38 GMT+03:00 Violeta Georgieva :
> > 
> > 
> > 
> >  2016-08-10 14:08 GMT+03:00 Mark Thomas :
> > >
> > > On 10/08/2016 11:45, violet...@apache.org wrote:
> > >> Author: violetagg
> > >> Date: Wed Aug 10 10:45:42 2016
> > >> New Revision: 1755717
> > >>
> > >> URL: http://svn.apache.org/viewvc?rev=1755717=rev
> > >> Log:
> > >> MBeans Descriptors How-To is moved to
> mbeans-descriptors-howto.html.
> > >>> Patch provided by Radoslav Husar. This solves Github PR#33
> > >
> > > The magic phrase to auto-close the PR is:
> > >>>
> > >>> Will the magic phrase auto-close the PR when it is not against trunk?
> > >>> https://github.com/apache/tomcat80/pull/6
> > >>
> > >> GitHub integration is only configured for trunk. I can set it up for
> the
> > >> other branches if that is what we want.
> > >
> > > With "trunk" I meant Tomcat 9 repo https://github.com/apache/tomcat
> > >
> > > Is it configured only for Tomcat 9?
> >
> > Currently it is only configured for Tomcat 9.
> >
> > > If yes should we ask the people to prepare the patches against Tomcat 9
> > > only or we can extend this integration for other Tomcat versions?
> >
> > Either is an option. Generally patches are applied to trunk and
> > back-ported but we can't prevent pull requests against earlier versions.
> >
> > I have no preference. What do others think?
>

3rd option: merge all GitHub repos into one.
Currently each SVN branch has its own GitHub repositoty.
Is there a reason for that ?
There could be just one GitHub repo with the same branches as in Apache SVN.
IMO this will simplify the things for the contributors too.


>
> +1 for integration with the other Tomcat versions.
>
> > Mark
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > For additional commands, e-mail: dev-h...@tomcat.apache.org
> >
>


Re: The magic phrase to auto-close the PR in github

2016-08-31 Thread Martin Grigorov
Hi Violeta,

On Wed, Aug 31, 2016 at 9:47 AM, Violeta Georgieva 
wrote:

> Hi Mark,
>
> 2016-08-10 14:38 GMT+03:00 Violeta Georgieva :
> >
> >
> >
> > 2016-08-10 14:08 GMT+03:00 Mark Thomas :
> > >
> > > On 10/08/2016 11:45, violet...@apache.org wrote:
> > > > Author: violetagg
> > > > Date: Wed Aug 10 10:45:42 2016
> > > > New Revision: 1755717
> > > >
> > > > URL: http://svn.apache.org/viewvc?rev=1755717=rev
> > > > Log:
> > > > MBeans Descriptors How-To is moved to mbeans-descriptors-howto.html.
> Patch provided by Radoslav Husar. This solves Github PR#33
> > >
> > > The magic phrase to auto-close the PR is:
>
> Will the magic phrase auto-close the PR when it is not against trunk?
> https://github.com/apache/tomcat80/pull/6


I think if you merge the commit in tomcat80 branch it should work.
Both https://github.com/apache/tomcat and https://github.com/apache/tomcat80
have their own "trunk" branch in GitHub.


>
> Thanks a lot,
> Violeta
>


Re: svn commit: r1757353 - in /tomcat/trunk: java/org/apache/catalina/filters/CorsFilter.java webapps/docs/changelog.xml

2016-08-23 Thread Martin Grigorov
Hi Mark,

On Tue, Aug 23, 2016 at 12:54 PM,  wrote:

> Author: markt
> Date: Tue Aug 23 10:54:28 2016
> New Revision: 1757353
>
> URL: http://svn.apache.org/viewvc?rev=1757353=rev
> Log:
> Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60008
> When processing CORs requests, treat any origin with a URI scheme of file
> as a valid origin.
>
> Modified:
> tomcat/trunk/java/org/apache/catalina/filters/CorsFilter.java
> tomcat/trunk/webapps/docs/changelog.xml
>
> Modified: tomcat/trunk/java/org/apache/catalina/filters/CorsFilter.java
> URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/
> catalina/filters/CorsFilter.java?rev=1757353=1757352&
> r2=1757353=diff
> 
> ==
> --- tomcat/trunk/java/org/apache/catalina/filters/CorsFilter.java
> (original)
> +++ tomcat/trunk/java/org/apache/catalina/filters/CorsFilter.java Tue Aug
> 23 10:54:28 2016
> @@ -826,8 +826,14 @@ public final class CorsFilter extends Ge
>  return true;
>  }
>
> -URI originURI;
> +// RFC6454, section 4. "If uri-scheme is file, the implementation
> MAY
> +// return an implementation-defined value.". No limits are okaced
> on
>

There is a typo in "okaced"


> +// that value so treat all file URIs as valid origins.
> +if (origin.startsWith("file://")) {
> +return true;
> +}
>
> +URI originURI;
>  try {
>  originURI = new URI(origin);
>  } catch (URISyntaxException e) {
>
> Modified: tomcat/trunk/webapps/docs/changelog.xml
> URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/
> changelog.xml?rev=1757353=1757352=1757353=diff
> 
> ==
> --- tomcat/trunk/webapps/docs/changelog.xml (original)
> +++ tomcat/trunk/webapps/docs/changelog.xml Tue Aug 23 10:54:28 2016
> @@ -191,6 +191,10 @@
>  Ensure that Semaphore.release is called in all
> cases. Even
>  when there is an exception. (violetagg)
>
> +  
> +60008: When processing CORs requests, treat any origin
> with a
> +URI scheme of file as a valid origin. (markt)
> +  
>  
>
>
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 8.5.4

2016-07-11 Thread Martin Grigorov
On Wed, Jul 6, 2016 at 11:42 AM, Mark Thomas  wrote:

> The proposed Apache Tomcat 8.5.4 release is now available for voting.
>
> The major changes compared to the 8.5.3 release are:
>
> - Correct a regression in the embedded packaging
>
> - Add the ability to control the degree of concurrency when processing
>   HTTP/2 connections
>
> - Update to Tomcat Native 1.2.8
>
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.4/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1090/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_4/
>
> The proposed 8.5.4 release is:
> [ ] Broken - do not release
> [ ] Alpha  - go ahead and release as 8.5.4
> [ ] Beta   - go ahead and release as 8.5.4
>

[ X ] Stable - go ahead and release as 8.5.4


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 9.0.0.M9

2016-07-05 Thread Martin Grigorov
On Mon, Jul 4, 2016 at 9:03 PM, Mark Thomas  wrote:

> The proposed Apache Tomcat 9.0.0.M9 release is now available for voting.
>
> This is a milestone release for the 9.0.x branch. It should be
> noted that, as a milestone release:
> - Servlet 4.0 is not finalised
> - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0
>
> The major changes compared to the 9.0.0.M8 release are:
>
> For full details, see the changelog:
> http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M9/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1089/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M9/
>
> The proposed 9.0.0.M9 release is:
> [ ] Broken - do not release
>

[ X ] Alpha - go ahead and release as 9.0.0.M9


> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 7.0.70

2016-06-17 Thread Martin Grigorov
On Wed, Jun 15, 2016 at 9:47 PM, Violeta Georgieva 
wrote:

> The proposed Apache Tomcat 7.0.70 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.70/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1088/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_70/
>
> The proposed 7.0.70 release is:
> [ ] Broken - do not release
> [ ] Stable - go ahead and release as 7.0.70 Stable
>

[ X ] Stable - go ahead and release as 7.0.70 Stable

Tested our main application and Apache Wicket WebSockets integration.


>
> Regards,
> Violeta
>


Re: Using modern development tools for friendlier environment for newcomers

2016-06-17 Thread Martin Grigorov
Hi Chris,

On Fri, Jun 17, 2016 at 12:51 PM, Christopher Schultz <
ch...@christopherschultz.net> wrote:

> Martin,
>
> On 6/8/16 3:25 AM, Martin Grigorov wrote:
> > On Tue, Jun 7, 2016 at 11:33 AM, Mark Thomas <ma...@apache.org> wrote:
> >
> >> On 07/06/2016 10:17, Martin Grigorov wrote:
> >>> Hi devs,
> >>>
> >>> Recently a colleague of mine asked me what it takes to become an Apache
> >>> committer.
> >>> I've explained him that he has to choose a project that is interesting
> to
> >>> him and start participating in the mailing lists (helping others at
> >> users@,
> >>> giving opinion and testing releases at dev@), providing patches for
> open
> >>> issues, etc.
> >>> Few days later he came back with the following questions:
> >>>
> >>> 1) Why Tomcat still uses SVN?
> >>> I've told him that this is the SCM tool most of the committers have
> >>> experience with and there were some discussions to move to Git several
> >>> months back.
> >>> I've recommended him to use GitHub's Pull Requests for the time being -
> >> PRs
> >>> are monitored and merged if approved. Even if Tomcat was using Git,
> >> Apache
> >>> Infra doesn't provide tool with Pull Request support (GitLab, Gerrit,
> or
> >>> similar) anyway so there is no big difference from a contributor point
> of
> >>> view.
> >>
> >> If I recall correctly, the consensus last time around was that there was
> >> merit in exploring the options for using git further with a view to
> >> migrating if the majority were convinced there was a benefit to the
> move.
> >>
> >> There is an outstanding task (I need to chase it up) for the infra team
> >> to look at if we could move to a single git repo for multiple branches
> >> or would need multiple repos.
> >>
> >
> > One repo should be possible.
> > Even if there are some problems with the initial conversion from SVN to
> Git
> > the person dealing with it could create N Git repos and then with the
> help
> > of "git remote add" combine them into one with N branches and finally
> push
> > those branches into a single repository.
> >
> >
> >>
> >>> 2) Why Tomcat uses Bugzilla?
> >>> It is archaic and its UI is unfriendly - he said.
> >>> To be honest I didn't have a good answer here. I also don't like
> >> Bugzilla.
> >>> Everybody knows how to use JIRA! It is hard to explain that Apache JIRA
> >>> runs on Tomcat, but Tomcat project itself uses Perl software for issue
> >>> tracking (no matter how good Bugzilla is).
> >>
> >> My personal view is Jira is overly complex and horribly slow. Bugzilla
> >>
> >
> > I think JIRA is slower because the majority of the projects are there.
> > But I guess it would be an overkill for Infra to maintain several
> instances
> > of JIRA (e.g. sharded by project name).
>
> I think it's slower because it's a sledgehammer where a screwdriver will
> do the job. I've never liked JIRA, but as was previously said "tools are
> tools".
>

At my $dailyJob JIRA is not slow at all.
It is Apache JIRA installation problem, not every JIRA installation.
If you are subscribed to infra@ you will see that people complain
relatively often that it is either down or slow. Last such mail is from
yesterday!
IMO Apache JIRA should be split into several instances.
But here is not the place to discuss this topic!

What I was trying to explain is that Tomcat looks like an ageing product
from a tooling point of view: Bugzilla, SVN, ANT, Gump.
It is hard to make Tomcat development attractive to work with tools from
the 90s (figuratively said).

I am not saying that by changing the tooling suddenly a lot of developers
will want to contribute!
I just share the opinion that many developers consider these things when
trying to find an OSS to contribute to.


> >> just works. We don't need any of the extra features Jira offers. Do we
> >> want any of them? None come to mind. Others may have a different view.
> >>
> >
> > I personally like the JIRA plugins that integrate with the SCM tools.
> > Committing with "PROJECT_NAME-1234" in the commit message automatically
> > adds a comment to the respective ticket with a link to Git/SVN repo. It
> is
> > very easy to explore the history of a ticket.
>
> All of this can be done with svn + bugzilla, too. I guess just nobody
> bothered to do it @ASF until JIRA came along.
>
&

Re: [VOTE] Release Apache Tomcat 9.0.0.M8

2016-06-10 Thread Martin Grigorov
On Tue, Jun 7, 2016 at 6:02 PM, Mark Thomas  wrote:

> The proposed Apache Tomcat 9.0.0.M8 release is now available for voting.
>
> This is a milestone release for the 9.0.x branch. It should be
> noted that, as a milestone release:
> - Servlet 4.0 is not finalised
> - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0
>
> The major changes compared to the 9.0.0.M6 release are:
> - Improvements to memory leak detection and prevention including the
>   change RMI memory leaks are now correctly treated as application bugs
>   rather than a JRE bug
> - Fix a couple of memory leaks found in Tomcat
> - The HTTP Server header is no longer set by default
>
> For full details, see the changelog:
> http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M8/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1085/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M8/
>
> The proposed 9.0.0.M8 release is:
> [ ] Broken - do not release
> [ ] Alpha - go ahead and release as 9.0.0.M8
>

[ X ] Alpha - go ahead and release as 9.0.0.M8

Regards,
Martin



>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: Using modern development tools for friendlier environment for newcomers

2016-06-08 Thread Martin Grigorov
Hi,


On Tue, Jun 7, 2016 at 11:33 AM, Mark Thomas <ma...@apache.org> wrote:

> On 07/06/2016 10:17, Martin Grigorov wrote:
> > Hi devs,
> >
> > Recently a colleague of mine asked me what it takes to become an Apache
> > committer.
> > I've explained him that he has to choose a project that is interesting to
> > him and start participating in the mailing lists (helping others at
> users@,
> > giving opinion and testing releases at dev@), providing patches for open
> > issues, etc.
> > Few days later he came back with the following questions:
> >
> > 1) Why Tomcat still uses SVN?
> > I've told him that this is the SCM tool most of the committers have
> > experience with and there were some discussions to move to Git several
> > months back.
> > I've recommended him to use GitHub's Pull Requests for the time being -
> PRs
> > are monitored and merged if approved. Even if Tomcat was using Git,
> Apache
> > Infra doesn't provide tool with Pull Request support (GitLab, Gerrit, or
> > similar) anyway so there is no big difference from a contributor point of
> > view.
>
> If I recall correctly, the consensus last time around was that there was
> merit in exploring the options for using git further with a view to
> migrating if the majority were convinced there was a benefit to the move.
>
> There is an outstanding task (I need to chase it up) for the infra team
> to look at if we could move to a single git repo for multiple branches
> or would need multiple repos.
>

One repo should be possible.
Even if there are some problems with the initial conversion from SVN to Git
the person dealing with it could create N Git repos and then with the help
of "git remote add" combine them into one with N branches and finally push
those branches into a single repository.


>
> > 2) Why Tomcat uses Bugzilla?
> > It is archaic and its UI is unfriendly - he said.
> > To be honest I didn't have a good answer here. I also don't like
> Bugzilla.
> > Everybody knows how to use JIRA! It is hard to explain that Apache JIRA
> > runs on Tomcat, but Tomcat project itself uses Perl software for issue
> > tracking (no matter how good Bugzilla is).
>
> My personal view is Jira is overly complex and horribly slow. Bugzilla
>

I think JIRA is slower because the majority of the projects are there.
But I guess it would be an overkill for Infra to maintain several instances
of JIRA (e.g. sharded by project name).


> just works. We don't need any of the extra features Jira offers. Do we
> want any of them? None come to mind. Others may have a different view.
>

I personally like the JIRA plugins that integrate with the SCM tools.
Committing with "PROJECT_NAME-1234" in the commit message automatically
adds a comment to the respective ticket with a link to Git/SVN repo. It is
very easy to explore the history of a ticket.
Also it has a proper "Fix version" field. With it it is much easier to
create a changelog. No need to maintain one manually.


>
> > I know that SVN, Git, JIRA, Bugzilla are just tools. We can do our work
> > with any of them.
> > Maybe there are more (and more important!) reasons why my colleague
> didn't
> > start contributing to Tomcat yet but I also agree with him that by moving
> > to more modern tools Tomcat will become easier and friendlier for
> newcomers.
>
> The Tomcat community tends to change development technology when it can
> see some direct benefit from the change. It doesn't change just to use
> the latest shiny new toy.
>

I totally agree with "see some benefit"!
I don't agree with "new" :-) Both Git and JIRA are on the market for quite
some time.


>
> git does have some benefits but also some potential complications. My
> view is we are around the tipping point for svn -> git.
>
> Mark
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Using modern development tools for friendlier environment for newcomers

2016-06-07 Thread Martin Grigorov
Hi devs,

Recently a colleague of mine asked me what it takes to become an Apache
committer.
I've explained him that he has to choose a project that is interesting to
him and start participating in the mailing lists (helping others at users@,
giving opinion and testing releases at dev@), providing patches for open
issues, etc.
Few days later he came back with the following questions:

1) Why Tomcat still uses SVN?
I've told him that this is the SCM tool most of the committers have
experience with and there were some discussions to move to Git several
months back.
I've recommended him to use GitHub's Pull Requests for the time being - PRs
are monitored and merged if approved. Even if Tomcat was using Git, Apache
Infra doesn't provide tool with Pull Request support (GitLab, Gerrit, or
similar) anyway so there is no big difference from a contributor point of
view.

2) Why Tomcat uses Bugzilla?
It is archaic and its UI is unfriendly - he said.
To be honest I didn't have a good answer here. I also don't like Bugzilla.
Everybody knows how to use JIRA! It is hard to explain that Apache JIRA
runs on Tomcat, but Tomcat project itself uses Perl software for issue
tracking (no matter how good Bugzilla is).

I know that SVN, Git, JIRA, Bugzilla are just tools. We can do our work
with any of them.
Maybe there are more (and more important!) reasons why my colleague didn't
start contributing to Tomcat yet but I also agree with him that by moving
to more modern tools Tomcat will become easier and friendlier for newcomers.


Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov


Re: memory leak in Tomcat 8.0.9

2016-05-20 Thread Martin Grigorov
Hi,


On Fri, May 20, 2016 at 2:55 PM, Sanka, Ambica  wrote:

> Support Team,
>
> We have been using Tomcat 8.0.9 for our applications. We noticed below
> memo= ry leak error and out tomcat could not stopped. We had to kill the
> process = manually. I was reading articles in the internet and this got
> address after=  tomcat 6. But we found error in higher versions. We are not
> sure where to = fix this? Below is the error we are getting
>
> 2016-05-19 14:03:31,161 [localhost-startStop-2] WARN
> org.apache.catalina.l=
>
> oader.WebappClassLoader- The web application [/fmDirectoryService] appears
> = to have started a thread named [Thread-6] but has failed to stop it. This
> i= s very likely to create a memory leak. Stack trace of thread:
>
> java.lang.Thread.sleep(Native Method)
>
> net.atpco.cluster.support.BaseLocator$AdminTask.run(BaseLocator.java:141)
>
> 2016-05-19 14:03:31,197 [localhost-startStop-2] INFO
> org.apache.catalina.c=
>
> ore.ContainerBase.[Catalina].[localhost].[/fmbootstrap]- Destroying Spring
> = FrameworkServlet 'dispatcherServlet'
>
> 2016-05-19 14:03:31,210 [localhost-startStop-2] INFO
> org.apache.catalina.c=
>
> ore.ContainerBase.[Catalina].[localhost].[/fmbootstrap]- Closing Spring
> roo= t WebApplicationContext
>
> 2016-05-19 14:03:31,210 [localhost-startStop-2] INFO
> org.springframework.b=
>
> oot.context.embedded.AnnotationConfigEmbeddedWebApplicationContext-
> Closing=
> org.springframework.boot.context.embedded.AnnotationConfigEmbeddedWebAppli=
>
> cationContext@5e119034 org.springframework.boot.context.embedded.Ann cationContext@5e119034
> %3cmailto:org.springframework.boot.context.embedded.Ann>=
>
> otationConfigEmbeddedWebApplicationContext@5e119034>: startup date [Thu
> May=
>
> 19 08:17:39 EDT 2016]; root of context hierarchy May 19, 2016 2:03:31 PM
> com.mongodb.util.management.jmx.JMXMBeanServer unre= gisterMBean
>
> WARNING: Unable to register MBean
> org.mongodb.driver:type=3DConnectionPool,=
>
> clusterId=3D1,host=3Dlocalhost,port=3D27017
>
> javax.management.InstanceNotFoundException:
> org.mongodb.driver:type=3DConne=
>
> ctionPool,clusterId=3D1,host=3Dlocalhost,port=3D27017
>
> at
> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getMBean(D=
>
> efaultMBeanServerInterceptor.java:1095)
>
> at
> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.exclusiveU=
>
> nregisterMBean(DefaultMBeanServerInterceptor.java:427)
>
> at
> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.unregister=
>
> MBean(DefaultMBeanServerInterceptor.java:415)
>
> at
> com.sun.jmx.mbeanserver.JmxMBeanServer.unregisterMBean(JmxMBeanS=
>
> erver.java:546)
>
> at
> com.mongodb.util.management.jmx.JMXMBeanServer.unregisterMBean(J=
>
> MXMBeanServer.java:52)
>
> at
> com.mongodb.JMXConnectionPoolListener.connectionPoolClosed(JMXCo=
>
> nnectionPoolListener.java:68)
>
> at
> com.mongodb.PooledConnectionProvider.close(PooledConnectionProvi=
>
> der.java:107)
>
>
>
> Any kind of help is appreciated.
>

To get some free support please ask at us...@tomcat.apache.org mailing list.
Also please update to latest version of Tomcat (8.0.35) and try again.


>
> Thanks
>
> Ambica.
>
>


Re: Regarding files generated by "JJTree"

2016-05-20 Thread Martin Grigorov
Hi,

I guess your question is related to
http://markmail.org/message/kw4erakv272hsy3o where someone else already
told you about JavaCC.
AFAIK JavaCC is the only tool used by Tomcat that generates classes.
The number of classes depends on the parser rules so it could be N today
and M tomorrow.
Just grep the sources for this header and use the returned number.


On Fri, May 20, 2016 at 12:01 PM, sangeeta lal <sangeeta.6...@gmail.com>
wrote:

> Dear Sir,
>
> *Thanks for your reply!*
>
> Could you please tell me,  if there is any listing about all the  auto-
> generated files. I have manually identified 59 files in the folder "
> *tomcat\java\org\apache\el\parser*" which are auto generated.
>
> I have following two questions:
>
> 1. Can tomcat project have auto-generated files in some other folder also?
> 2. Is the "JavaCC" only tool which is used to auto-generate the files ? or
> there are some other tools as well?
>
>
> I highly *appreciate your help* and time!
>
> Thank You
> Sangeeta
>
> On Fri, May 20, 2016 at 3:14 PM, Martin Grigorov <mgrigo...@apache.org>
> wrote:
>
> > Hello Sangeeta,
> >
> > Yes, those files are auto-generated by a tool: https://javacc.java.net/.
> >
> >
> > On Fri, May 20, 2016 at 11:41 AM, sangeeta lal <sangeeta.6...@gmail.com>
> > wrote:
> >
> > > Dear Dev Team,
> > >
> > > Can anyone please give me little information about these files?
> > >
> > > Thank You
> > >
> > > On Thu, May 19, 2016 at 8:22 PM, sangeeta lal <sangeeta.6...@gmail.com
> >
> > > wrote:
> > >
> > > >
> > > > Dear Dev Team,
> > > >
> > > >
> > > > I am Sangeeta. I am a PhD Scholar in the area of automated software
> > > > engineering. I am currently studying source code of Apache Tomcat
> > > project.
> > > > While studying the source code. I noticed a folder in Apache Tomcat
> > > project
> > > > consisting of 58 files having following line written in them:
> > > >
> > > >
> > > > "/* *Generated By:JJTree: Do not edit this line.
> > AstLambdaExpression.java
> > > > Version 4.3 */"*
> > > >
> > > >
> > > > Can anyone please explain me little about the meaning of this line?
> Are
> > > > all such files  generated by this tool have no contribution from the
> > > human
> > > > developers?
> > > >
> > > > I highly appreciate your help!
> > > >
> > > > Thanks You
> > > > Sangeeta
> > > >
> > > > --
> > > > Regards...
> > > > Sangeeta
> > > > Assistant Professor
> > > > CSE Department @JIIT Noida
> > > >
> > > >
> > >
> > >
> > > --
> > > Regards...
> > > Sangeeta
> > > Assistant Professor
> > > CSE Department @JIIT Noida
> > >
> >
>
>
>
> --
> Regards...
> Sangeeta
> Assistant Professor
> CSE Department @JIIT Noida
>


Re: Regarding files generated by "JJTree"

2016-05-20 Thread Martin Grigorov
Hello Sangeeta,

Yes, those files are auto-generated by a tool: https://javacc.java.net/.


On Fri, May 20, 2016 at 11:41 AM, sangeeta lal 
wrote:

> Dear Dev Team,
>
> Can anyone please give me little information about these files?
>
> Thank You
>
> On Thu, May 19, 2016 at 8:22 PM, sangeeta lal 
> wrote:
>
> >
> > Dear Dev Team,
> >
> >
> > I am Sangeeta. I am a PhD Scholar in the area of automated software
> > engineering. I am currently studying source code of Apache Tomcat
> project.
> > While studying the source code. I noticed a folder in Apache Tomcat
> project
> > consisting of 58 files having following line written in them:
> >
> >
> > "/* *Generated By:JJTree: Do not edit this line. AstLambdaExpression.java
> > Version 4.3 */"*
> >
> >
> > Can anyone please explain me little about the meaning of this line? Are
> > all such files  generated by this tool have no contribution from the
> human
> > developers?
> >
> > I highly appreciate your help!
> >
> > Thanks You
> > Sangeeta
> >
> > --
> > Regards...
> > Sangeeta
> > Assistant Professor
> > CSE Department @JIIT Noida
> >
> >
>
>
> --
> Regards...
> Sangeeta
> Assistant Professor
> CSE Department @JIIT Noida
>


Re: [VOTE] Release Apache Tomcat 8.5.2

2016-05-13 Thread Martin Grigorov
On Thu, May 12, 2016 at 12:22 AM, Mark Thomas  wrote:

> The proposed Apache Tomcat 8.5.2 release is now available for voting.
>
> 8.5.2 corrects a regression found in 8.5.1.
>
> The major changes compared to the 8.5.0 release are:
> - Add the org.apache.catalina.servlet4preview package that can be
>   used to gain early access to Servlet 4.0 features. Note that this
>   package will not be present in Tomcat 9.
> - Make default TLS configuration more secure
> - Add direct HTTP/2 connection support
> - Update the packaged version of the Tomcat Native Library to 1.2.7 to
>   pick up the Windows binaries that are based on OpenSSL 1.0.2h and
>   APR 1.5.2.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.2/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1081/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_2/
>
> The proposed 8.5.2 release is:
> [ ] Broken - do not release
> [ ] Alpha  - go ahead and release as 8.5.2
> [X] Beta   - go ahead and release as 8.5.2
> [ ] Stable - go ahead and release as 8.5.2
>

Tested Apache Wicket WebSocket


>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: Looking for mentor

2016-04-16 Thread Martin Grigorov
Hi,

On Sat, Apr 16, 2016 at 9:34 PM, Abdessamed MANSOURI 
wrote:

> Thank you for your response and your time, i checkouted svn trunk and built
> Tomcat successfully, its works fine, i also run ant test, for unit testing,
> but it ended with some errors (i've used IBM J9), now i completed this
> step, what do you suggests me to do now?? :)
>

Out of curiosity: Why do you use J9 ?
I guess your first task could be to make all Tomcat tests running on J9 ;-)


>
> I can't find Tomcat on Jira, why?? :)
>

Tomcat is using Bugzilla.
Check http://tomcat.apache.org/bugreport.html


>
> Thank you for your time again.
>
> 2016-04-16 16:25 GMT+01:00 Mark Thomas :
>
> > On 15/04/2016 17:59, Abdessamed MANSOURI wrote:
> > > Hello all,
> > >
> > > I'm newcomer and i want to contribute to Tomcat developement, i have
> some
> > > free time (alots of time), so i want to be useful in this world better
> > than
> > > sleeping all the day, so i'm looking for applying Apache mentoring
> > program,
> > > i'm not guru in Java but not totaly a newbie, so i want to try all my
> > best
> > > to help you guys, who want to be my mentor??
> >
> > Welcome to the Tomcat development community. Feel free to ask any
> > questions you have on this list.
> >
> > > Note : i still student, but i'm not looking to do Tomcat as my final
> > > project (i already have a final project), i wan't to help you (as much
> > as i
> > > can).
> > >
> > > Thank you all for your time.
> >
> > The first step is to make sure you can build Tomcat locally. Follow the
> > instructions in [1] to checkout the latest Tomcat source and and build
> it.
> >
> > Note that the URL you'll need to checkout Tomcat trunk is:
> > https://svn.apache.org/viewvc/tomcat/trunk
> >
> > If you have any questions, just ask.
> >
> > Mark
> >
> >
> > [1] https://svn.apache.org/viewvc/tomcat/trunk/BUILDING.txt?view=markup
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > For additional commands, e-mail: dev-h...@tomcat.apache.org
> >
> >
>


Re: [VOTE] Release Apache Tomcat 7.0.69

2016-04-12 Thread Martin Grigorov
On Mon, Apr 11, 2016 at 12:55 PM, Violeta Georgieva 
wrote:

> The proposed Apache Tomcat 7.0.69 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.69/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1074/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_69/
>
> The proposed 7.0.69 release is:
> [ ] Broken - do not release
> [ ] Stable - go ahead and release as 7.0.69 Stable
>

[X] Stable - go ahead and release as 7.0.69 Stable

Tested Apache Wicket native web socket examples.


> Regards,
> Violeta
>


Re: Maven snapshot builds

2016-04-01 Thread Martin Grigorov
On Fri, Apr 1, 2016 at 10:07 PM, Martin Grigorov <mgrigo...@apache.org>
wrote:

> Hi,
>
> Does anyone know what is the reason for the missing -SNAPSHOT builds at
> https://repository.apache.org/content/repositories/snapshots/org/apache/tomcat/tomcat-catalina/
> (RAO) ?
>
> https://tomcat.apache.org/tomcat-8.5-doc/maven-jars.html says that the
> snapshots should be at
> http://people.apache.org/repo/m2-snapshot-repository/org/apache/tomcat/
> but this gives 404.
>
> The last 8.0-SNAPSHOT at RAO is from Feb 23th.
> I actually need 8.5-SNAPSHOT with the fix for ClassCastException when
> trying to get the ApplicationPushBuilder.
>
> Another option for me is to build and install the Maven jars locally. Any
> hints for the Ant commands to do this ?
>

I didn't find a way to install them just locally so I've uploaded
8.5-SNAPSHOT at
https://repository.apache.org/content/repositories/snapshots/org/apache/tomcat/tomcat-catalina/8.5-SNAPSHOT/
by following the steps at res/maven/README.txt.


>
> Thank you!
>
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
>


Maven snapshot builds

2016-04-01 Thread Martin Grigorov
Hi,

Does anyone know what is the reason for the missing -SNAPSHOT builds at
https://repository.apache.org/content/repositories/snapshots/org/apache/tomcat/tomcat-catalina/
(RAO) ?

https://tomcat.apache.org/tomcat-8.5-doc/maven-jars.html says that the
snapshots should be at
http://people.apache.org/repo/m2-snapshot-repository/org/apache/tomcat/ but
this gives 404.

The last 8.0-SNAPSHOT at RAO is from Feb 23th.
I actually need 8.5-SNAPSHOT with the fix for ClassCastException when
trying to get the ApplicationPushBuilder.

Another option for me is to build and install the Maven jars locally. Any
hints for the Ant commands to do this ?

Thank you!

Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov


Re: [VOTE] Release Apache Tomcat 8.0.33

2016-03-23 Thread Martin Grigorov
On Fri, Mar 18, 2016 at 9:55 PM, Mark Thomas  wrote:

> The proposed Apache Tomcat 8.0.33 release is now available for voting.
>
> The main changes since 8.0.32 are:
>
> - Correct a false positive warning for ThreadLocal related memory
>   leaks when the key class but not the value class has been loaded
>   by the web application class loader.
>
> - Improve the performance of
>   javax.servlet.jsp.el.ScopedAttributeELResolver when resolving
>   attributes that do not exist.
>
> - Update the packaged version of the Tomcat Native Library to 1.2.5
>   to pick up the Windows binaries that are based on OpenSSL 1.0.2g
>   and APR 1.5.1.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.33/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1067/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_33/
>
> The proposed 8.0.33 release is:
> [ ] Broken - do not release
> [ ] Stable - go ahead and release as 8.0.33
>

[ X ] Stable - go ahead and release as 8.0.33


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: [VOTE] Release Apache Tomcat 8.5.0

2016-03-19 Thread Martin Grigorov
On Thu, Mar 17, 2016 at 9:00 PM, Mark Thomas  wrote:

> The proposed Apache Tomcat 8.5.0 release is now available for voting.
>
> This is the first release of the 8.5.x branch. The release is, in essence:
> - Based on a copy of the 9.0.0.M4 tag
> - All 9.0.x changes to the specification APIs have been reverted. The
>   specification APIs should match 8.0.x exactly
> - Java 8 specific code has been re-written for Java 7
> - Tomcat and specification versions have been set
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.0/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1066/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_0/
>
> The proposed 8.5.0 release is:
> [ ] Broken - do not release
> [ ] Alpha  - go ahead and release as 8.5.0
> [ ] Beta   - go ahead and release as 8.5.0
> [ ] Stable - go ahead and release as 8.5.0
>
>
[ X ] Beta   - go ahead and release as 8.5.0


> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


  1   2   >