Re: Same request object passed to two threads

2016-12-12 Thread Matthew Bellew
-08 3:48 GMT+02:00 Matthew Bellew <matth...@labkey.com>: > >> > >> I have narrowed this down quite a lot. This bug is caused by the same > >> Http11Processor being pushed on to the recycledProcessors stack twice. > I > >> discovered this by add a duplicat

Re: Same request object passed to two threads

2016-12-07 Thread Matthew Bellew
not check the return result from connections.remove(). Maybe a) ConnectionHandler.process() should only call release(processor) if the connections.remove(socket)==processor? or b) release(socket) shouldn't call recycledProcessors.push()? Matt On Tue, Dec 6, 2016 at 3:53 PM, Matthew Bellew <ma

Re: Same request object passed to two threads

2016-12-06 Thread Matthew Bellew
not guessing about that. I added debugging code to my app and managed to stop in the debugger, and I could see two http-nio-8080-exec- threads with the same object. Matt On Tue, Dec 6, 2016 at 2:58 PM, Caldarale, Charles R < chuck.caldar...@unisys.com> wrote: > From: Matthew Bellew [mai

Re: Same request object passed to two threads

2016-12-06 Thread Matthew Bellew
Just realized that in the case above, I couldn't have hit the quoted code, since neither call to AuthFilter.doFilter() had returned. I can build and debug Tomcat, so any advice would be very welcome. Matt On Tue, Dec 6, 2016 at 2:20 PM, Matthew Bellew <matth...@labkey.com> wrote: &g

Same request object passed to two threads

2016-12-06 Thread Matthew Bellew
I have an intermittent bug that I've been trying to trying to track down for a long time. The symptom is that the same tomcat request object is being processed by two different threads. The symptom is a random crash when one thread returns and recycles the request, and the other thread access