Re: [tomcat] branch master updated: Simpler way to determine Graal runtime

2020-07-22 Thread Rémy Maucherat
tional check for the system property since it is a good override. It would be a transition when https://github.com/oracle/graal/issues/2395 is fixed as well. Rémy > > > Filip > > > > *From:* Rémy Maucherat > *Sent:* Wednesday, July 22, 2020 12:10 AM > *To:* Tomcat De

Re: Jakarta EE APIs

2020-07-22 Thread Rémy Maucherat
On Wed, Jul 22, 2020 at 5:10 PM Mark Thomas wrote: > Hi all, > > We currently have implementations for all of the Jakarta APIs that ship > with Tomcat and partial implementations for 5 additional Jakarta APIs that > are compile time only dependencies. > > I was checking those partial

Re: [tomcat] branch master updated: Simpler way to determine Graal runtime

2020-07-22 Thread Rémy Maucherat
On Tue, Jul 21, 2020 at 11:16 PM wrote: > This is an automated email from the ASF dual-hosted git repository. > > fhanik pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > The following commit(s) were added to refs/heads/master by this push: >

Re: Native Image - Reflectionless Concept

2020-07-17 Thread Rémy Maucherat
ithub.com/rmannibucau> | LinkedIn > <https://www.linkedin.com/in/rmannibucau> | Book > <https://www.packtpub.com/application-development/java-ee-8-high-performance> > > > Le jeu. 16 juil. 2020 à 14:31, Rémy Maucherat a écrit : > >> On Mon, Jul 13, 2020 at 11:59

Re: Native Image - Reflectionless Concept

2020-07-16 Thread Rémy Maucherat
On Mon, Jul 13, 2020 at 11:59 PM Filip Hanik wrote: > for discussion, all feedback and questions welcome: > > > I've created a concept of having Apache Tomcat, embedded, run without > reflection in a native image. > This concept creates a jar, tomcat-embedded-programmatic.jar, that can be > fine

Re: Improving SameSite support

2020-07-08 Thread Rémy Maucherat
On Wed, Jul 8, 2020 at 8:55 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Rémy, > > On 7/8/20 11:47, Rémy Maucherat wrote: > > On Wed, Jul 8, 2020 at 5:10 PM Christopher Schultz > > &g

Re: Improving SameSite support

2020-07-08 Thread Rémy Maucherat
On Wed, Jul 8, 2020 at 5:10 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Rémy, > > On 7/8/20 10:35, Rémy Maucherat wrote: > > On Wed, Jul 8, 2020 at 4:26 PM Christopher Schultz > > &g

Re: Improving SameSite support

2020-07-08 Thread Rémy Maucherat
On Wed, Jul 8, 2020 at 4:26 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > >> Clearly, no, with multiple elements, the digester rules added to > >> ContextRuleSet would be something like (in addition to the > >> unchanged ones for CookieProcessor): > > > >

Re: Improving SameSite support

2020-07-08 Thread Rémy Maucherat
On Wed, Jul 8, 2020 at 4:14 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Rémy, > > On 7/8/20 04:16, Rémy Maucherat wrote: > > On Tue, Jul 7, 2020 at 4:26 PM Christopher Schultz > > &g

Re: Improving SameSite support

2020-07-08 Thread Rémy Maucherat
On Tue, Jul 7, 2020 at 4:26 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Rémy, > > On 7/7/20 03:10, Rémy Maucherat wrote: > > On Mon, Jul 6, 2020 at 9:27 PM Christopher Schultz > > &g

Re: Improving SameSite support

2020-07-07 Thread Rémy Maucherat
On Mon, Jul 6, 2020 at 9:27 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > All, > > Jakarta EE 5.0 does not appear to include support for SameSite > cookies. Tomcat's CookieProcessor allows an administrator to set the >

Re: [VOTE] Release Apache Tomcat 7.0.105

2020-07-06 Thread Rémy Maucherat
On Thu, Jul 2, 2020 at 3:08 PM Violeta Georgieva wrote: > The proposed Apache Tomcat 7.0.105 release is now available for voting. > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.105/ > The Maven staging repo is: >

Re: [tomcat] branch master updated: Direct use of the ALPN API

2020-07-03 Thread Rémy Maucherat
On Fri, Jul 3, 2020 at 10:38 AM wrote: > This is an automated email from the ASF dual-hosted git repository. > > remm pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > The following commit(s) were added to refs/heads/master by this push: >

Re: [tomcat] branch master updated: Add support for ALPN on Java 8

2020-07-02 Thread Rémy Maucherat
On Sat, May 9, 2020 at 4:53 PM Rémy Maucherat wrote: > On Fri, May 8, 2020 at 6:36 PM wrote: > >> This is an automated email from the ASF dual-hosted git repository. >> >> remm pushed a commit to branch master >> in repository https://gitbox.a

Re: [VOTE] Release Apache Tomcat 8.5.57

2020-07-01 Thread Rémy Maucherat
On Wed, Jul 1, 2020 at 12:14 AM Mark Thomas wrote: > The proposed Apache Tomcat 8.5.57 release is now available for voting. > > The notable changes compared to the 8.5.56 release are: > > - Implement a significant portion of the TLS environment variables > for the rewrite valve. > > - Reduce

Re: [VOTE] Release Apache Tomcat 9.0.37

2020-07-01 Thread Rémy Maucherat
On Tue, Jun 30, 2020 at 10:41 PM Mark Thomas wrote: > The proposed Apache Tomcat 9.0.37 release is now available for voting. > > The notable changes compared to the 9.0.36 release are: > > - Implement a significant portion of the TLS environment variables > for the rewrite valve. > > -

Re: [VOTE] Release Apache Tomcat 10.0.0-M7

2020-07-01 Thread Rémy Maucherat
On Tue, Jun 30, 2020 at 8:16 PM Mark Thomas wrote: > The proposed Apache Tomcat 10.0.0-M7 release is now available for > voting. > > Apache Tomcat 10.x implements Jakarta EE 9 and, as such, the primary > package for all the specification APIs has changed from javax.* to > jakarta.* >

Re: Changing the name of the default branch in our git repos

2020-06-26 Thread Rémy Maucherat
On Fri, Jun 26, 2020 at 4:48 PM Mark Thomas wrote: > Hi, > > Picking up this thread again I see a range of views. "main" seems to be > the most popular although several folks suggested "10.0.x" and "use > whatever GitHub use". There was also interest in "trunk". Particularly > with the

Re: flaky HTTP2 test

2020-06-25 Thread Rémy Maucherat
On Thu, Jun 25, 2020 at 3:28 AM Raymond Auge wrote: > Sorry folks, but here are two more intermittent Http2 test failures: > > 2020-06-25T01:09:24.3494270Z[concat] Testsuites with failed tests: > 2020-06-25T01:09:24.3496415Z[concat] >

Re: [tomcat] branch master updated: Fix IDE nags

2020-06-23 Thread Rémy Maucherat
On Tue, Jun 23, 2020 at 1:08 PM wrote: > This is an automated email from the ASF dual-hosted git repository. > > markt pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > The following commit(s) were added to refs/heads/master by this push: >

Re: [tomcat] branch master updated: Various improvements to code generation

2020-06-23 Thread Rémy Maucherat
On Tue, Jun 23, 2020 at 12:03 PM wrote: > This is an automated email from the ASF dual-hosted git repository. > > remm pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > The following commit(s) were added to refs/heads/master by this push: >

Re: Bootstrap and modules

2020-06-11 Thread Rémy Maucherat
On Thu, Jun 11, 2020 at 9:01 PM Mark Thomas wrote: > Hi, > > As discussed in PR#298 [1], properly/fully/correctly supporting JPMS / > OSGi gets trickier than necessary with the bootstrap JAR because of the > way we currently package it with the minimum that it needs and duplicate > some classes.

Re: buildbot failure in on tomcat-85-trunk

2020-06-10 Thread Rémy Maucherat
On Wed, Jun 10, 2020 at 2:02 PM Martin Grigorov wrote: > Hi, > > The build of 8.5.x passes here but it failed at > https://ci.apache.org/builders/tomcat-85-trunk/builds/2349. > But without access to the file system I cannot find what is the reason. > How do you investigate such problems at

Re: [tomcat] branch master updated: Ignore exception getting content length

2020-06-08 Thread Rémy Maucherat
On Fri, Jun 5, 2020 at 5:59 PM Mark Thomas wrote: > On 05/06/2020 13:21, r...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > > > remm pushed a commit to branch master > > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > > > > The

Re: [VOTE][RESULT] Release Apache Tomcat 10.0.0-M6

2020-06-07 Thread Rémy Maucherat
On Sun, Jun 7, 2020 at 8:47 PM Mark Thomas wrote: > The following votes were cast: > > Binding: > +1: remm, mgrigorov, markt > The lack of interest for the Jakarta branch seems to be creeping up ... Rémy > > Non-binding: > +1: Nicolò Boschi > > The vote therefore passes. > > Thank you to

Re: Usage of SynchronizedStack/Queue

2020-06-05 Thread Rémy Maucherat
On Fri, Jun 5, 2020 at 3:08 PM Martin Grigorov wrote: > Hi, > > On Thu, Jun 4, 2020 at 9:28 PM Rémy Maucherat wrote: > >> On Thu, Jun 4, 2020 at 6:16 PM Mark Thomas wrote: >> >>> On 04/06/2020 16:33, Martin Grigorov wrote: >>> > Hi team, >&g

Re: [VOTE] Release Apache Tomcat migration tool for Jakarta EE 0.0.2

2020-06-04 Thread Rémy Maucherat
On Thu, Jun 4, 2020 at 3:08 PM Emmanuel Bourg wrote: > I'd like to call for a vote to release the version 0.0.2 of the > Jakarta EE migration tool. > > This will be a "tag only" release with no distribution of the binaries > (neither from Apache nor from Maven Central). > > The notable changes

Re: Usage of SynchronizedStack/Queue

2020-06-04 Thread Rémy Maucherat
On Thu, Jun 4, 2020 at 6:16 PM Mark Thomas wrote: > On 04/06/2020 16:33, Martin Grigorov wrote: > > Hi team, > > > > I am profiling our application and I've found that Tomcat uses its own > > Synchronized Queue/Stack implementations which synchronize on instance > > level, i.e. their methods are

Re: [VOTE] Release Apache Tomcat 8.5.56

2020-06-04 Thread Rémy Maucherat
On Wed, Jun 3, 2020 at 10:51 PM Mark Thomas wrote: > The proposed Apache Tomcat 8.5.56 release is now available for voting. > > The notable changes compared to the 8.5.55 release are: > > - Add support for ALPN on recent OpenJDK 8 releases. > > - Add support for the CATALINA_OUT_CMD environment

Re: [VOTE] Release Apache Tomcat 9.0.36

2020-06-04 Thread Rémy Maucherat
On Wed, Jun 3, 2020 at 8:06 PM Mark Thomas wrote: > The proposed Apache Tomcat 9.0.36 release is now available for voting. > > The notable changes compared to the 9.0.35 release are: > > - Add support for ALPN on recent OpenJDK 8 releases. > > - Add support for the CATALINA_OUT_CMD environment

Re: [VOTE] Release Apache Tomcat 10.0.0-M6

2020-06-03 Thread Rémy Maucherat
On Wed, Jun 3, 2020 at 5:14 PM Mark Thomas wrote: > The proposed Apache Tomcat 10.0.0-M6 release is now available for > voting. > > Apache Tomcat 10.x implements Jakarta EE 9 and, as such, the primary > package for all the specification APIs has changed from javax.* to > jakarta.* > Applications

Re: June releases

2020-06-02 Thread Rémy Maucherat
On Tue, Jun 2, 2020 at 4:01 PM Mark Thomas wrote: > Hi all, > > It is the start of the month again so I intend to start the next round > of releases. All the open issues appear to be resolved / waiting for > info so I plan to run the unit tests locally and, assuming they pass > cleanly, tag

Re: [tomcat] 01/04: WIP for more TLS env resolution

2020-05-31 Thread Rémy Maucherat
On Sun, May 31, 2020 at 2:53 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Rémy, > > On 5/29/20 11:25, r...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git > > repository. > > > > remm pushed a

Re: [tomcat] branch 8.5.x updated: Switch to Maven Resolver Ant tasks

2020-05-29 Thread Rémy Maucherat
On Fri, May 29, 2020 at 9:05 PM wrote: > > +<<< HEAD > +=== > + > +>>> 5db7d814d0... Switch to Maven Resolver Ant tasks > > > The CI run complained and indeed there's a merge conflict here. Rémy

Re: Maven uploads and hashes

2020-05-29 Thread Rémy Maucherat
On Fri, May 29, 2020 at 8:55 PM Mark Thomas wrote: > On 29/05/2020 19:42, Michael Osipov wrote: > > Am 2020-05-29 um 16:48 schrieb Mark Thomas: > >> On 29/05/2020 15:23, Michael Osipov wrote: > >>> Am 2020-05-29 um 14:05 schrieb Mark Thomas: > Hi, > > Currently we use the (very

Re: buildbot failure in on tomcat-trunk

2020-05-26 Thread Rémy Maucherat
On Tue, May 26, 2020 at 1:25 PM Mark Thomas wrote: > On 26/05/2020 12:22, build...@apache.org wrote: > > The Buildbot has detected a new failure on builder tomcat-trunk while > building tomcat. Full details are available at: > > https://ci.apache.org/builders/tomcat-trunk/builds/5196 > > > >

Re: [VOTE] Release Apache Tomcat 7.0.104

2020-05-15 Thread Rémy Maucherat
On Thu, May 7, 2020 at 10:17 PM Violeta Georgieva wrote: > The proposed Apache Tomcat 7.0.104 release is now available for voting. > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.104/ > The Maven staging repo is: >

Re: Session serialization uses wrapper objects instead of primitives

2020-05-15 Thread Rémy Maucherat
On Fri, May 15, 2020 at 12:00 AM Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Mark, > > On 5/14/20 14:21, Mark Thomas wrote: > > On 14/05/2020 18:41, Christopher Schultz wrote: > >> Mark, > >> > >> On 5/14/20 12:53, Mark Thomas

Re: [tomcat] 02/02: Avoid waste of resources due to reconstruction of objects

2020-05-13 Thread Rémy Maucherat
On Thu, May 14, 2020 at 12:20 AM Mark Thomas wrote: > On 13/05/2020 19:23, Rémy Maucherat wrote: > > On Mon, May 4, 2020 at 4:43 PM > <mailto:ma...@apache.org>> wrote: > > > > This is an automated email from the ASF dual-hosted git repository. > >

Re: [tomcat] 02/02: Avoid waste of resources due to reconstruction of objects

2020-05-13 Thread Rémy Maucherat
On Mon, May 4, 2020 at 4:43 PM wrote: > This is an automated email from the ASF dual-hosted git repository. > > markt pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > commit 1719b71374d57d59bdcd99537bf13348cdaf87c7 > Author: KangZhiDong >

Re: [tomcat] branch master updated: Add a constant for invalid URI

2020-05-13 Thread Rémy Maucherat
On Wed, May 13, 2020 at 11:30 AM Michael Osipov wrote: > Am 2020-05-13 um 11:18 schrieb Rémy Maucherat: > > On Wed, May 13, 2020 at 11:08 AM Michael Osipov > wrote: > > > >> Am 2020-05-13 um 09:45 schrieb r...@apache.org: > >>> This is an automated email

Re: [tomcat] branch master updated: Add a constant for invalid URI

2020-05-13 Thread Rémy Maucherat
On Wed, May 13, 2020 at 11:08 AM Michael Osipov wrote: > Am 2020-05-13 um 09:45 schrieb r...@apache.org: > > This is an automated email from the ASF dual-hosted git repository. > > > > remm pushed a commit to branch master > > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > >

Re: [tomcat] branch master updated: Add support for ALPN on Java 8

2020-05-09 Thread Rémy Maucherat
On Fri, May 8, 2020 at 6:36 PM wrote: > This is an automated email from the ASF dual-hosted git repository. > > remm pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > The following commit(s) were added to refs/heads/master by this push: >

Re: [VOTE] Release Apache Tomcat 8.5.55

2020-05-06 Thread Rémy Maucherat
On Wed, May 6, 2020 at 12:38 AM Mark Thomas wrote: > The proposed Apache Tomcat 8.5.55 release is now available for voting. > > The major changes compared to the 8.5.54 release are: > > - Improve the handling of requests that use an expectation. Do not > disable keep-alive where the response

Re: [VOTE] Release Apache Tomcat 9.0.35

2020-05-06 Thread Rémy Maucherat
On Tue, May 5, 2020 at 11:41 PM Mark Thomas wrote: > The proposed Apache Tomcat 9.0.35 release is now available for voting. > > The major changes compared to the 9.0.34 release are: > > - Improve the handling of requests that use an expectation. Do not > disable keep-alive where the response

Re: [VOTE] Release Apache Tomcat 10.0.0-M5

2020-05-06 Thread Rémy Maucherat
On Tue, May 5, 2020 at 9:34 PM Mark Thomas wrote: > The proposed Apache Tomcat 10.0.0-M5 release is now available for > voting. > > Apache Tomcat 10.x implements Jakarta EE 9 and, as such, the primary > package for all the specification APIs has changed from javax.* to > jakarta.* > Applications

Re: Plans for 10.0.0-M5 etc

2020-05-05 Thread Rémy Maucherat
On Tue, May 5, 2020 at 10:45 AM Mark Thomas wrote: > Hi all, > > I am planning to start the monthly release cycle later today. I have a > few bits and bobs of clean-up that I want to get done before tagging as > well as my usual unit test run. I'll probably be in a position to tag > towards the

Re: Remove org.apache.catalina.tribes.transport.bio

2020-04-29 Thread Rémy Maucherat
On Tue, Apr 28, 2020 at 7:18 PM Mark Thomas wrote: > On 28/04/2020 17:30, Rémy Maucherat wrote: > > Hi, > > > > I'm still looking at things to remove or refactor in 10 following the > > rearchitecting failure for the Connector. One candidate could be the >

Remove org.apache.catalina.tribes.transport.bio

2020-04-28 Thread Rémy Maucherat
Hi, I'm still looking at things to remove or refactor in 10 following the rearchitecting failure for the Connector. One candidate could be the Tribes transport, since NIO is the default and BIO is probably never used. Can it be removed ? There are a few classes here and there that could go too,

Re: git-fu is (still) weak

2020-04-27 Thread Rémy Maucherat
On Tue, Apr 28, 2020 at 12:21 AM Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > All, > > I tried again to commit to tc10 branch, got commit id > 8dddc11512fbd3b91ed9d737a42e4b8415458ddf. > > Moving to tc9 branch: > > $ git

Re: buildbot failure in on tomcat-9-trunk

2020-04-23 Thread Rémy Maucherat
On Thu, Apr 23, 2020 at 12:02 PM Mark Thomas wrote: > On 22/04/2020 22:53, build...@apache.org wrote: > > The Buildbot has detected a new failure on builder tomcat-9-trunk while > building tomcat. Full details are available at: > > https://ci.apache.org/builders/tomcat-9-trunk/builds/193 > >

Re: [tomcat] branch 9.0.x updated: Use empty arrays for Collections.toArray()

2020-04-22 Thread Rémy Maucherat
On Wed, Apr 22, 2020 at 3:13 PM wrote: > This is an automated email from the ASF dual-hosted git repository. > > markt pushed a commit to branch 9.0.x > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > The following commit(s) were added to refs/heads/9.0.x by this push: >

Re: StoreConfig and creating context.xml files

2020-04-21 Thread Rémy Maucherat
On Tue, Apr 21, 2020 at 9:27 AM Mark Thomas wrote: > On 20/04/2020 23:01, Rémy Maucherat wrote: > > On Mon, Apr 20, 2020 at 9:46 PM Mark Thomas > <mailto:ma...@apache.org>> wrote: > > > > Hi, > > > > I'm working in the issue reported on users

Re: StoreConfig and creating context.xml files

2020-04-20 Thread Rémy Maucherat
On Mon, Apr 20, 2020 at 9:46 PM Mark Thomas wrote: > Hi, > > I'm working in the issue reported on users@ > > I've fixed the errors described there and have got to the point where > StoreConfig.store(Context) is being called but the call fails if the > Context doesn't already have a configuration

Re: [tomcat] branch 7.0.x updated: Remove redundant sole path/URI from error page message on SC_NOT_FOUND

2020-04-20 Thread Rémy Maucherat
On Mon, Apr 20, 2020 at 10:58 AM Michael Osipov wrote: > Am 2020-04-20 um 10:05 schrieb Mark Thomas: > > On 18/04/2020 20:59, micha...@apache.org wrote: > >> This is an automated email from the ASF dual-hosted git repository. > >> > >> michaelo pushed a commit to branch 7.0.x > >> in repository

Re: [tomcat] branch master updated: Proposed Connector API and XML refactoring

2020-04-17 Thread Rémy Maucherat
On Fri, Apr 17, 2020 at 2:19 PM Michael Osipov wrote: > Isn't that obvious a soon as I provide > sslImplementationName/? > With the new config SSLHostConfig, SSLEnabled seems to be derivable from that since it's mandatory. This wasn't practical before. However, I see code that also checks the

Re: [tomcat] branch master updated: Proposed Connector API and XML refactoring

2020-04-17 Thread Rémy Maucherat
On Fri, Apr 17, 2020 at 11:51 AM Michael Osipov wrote: > Am 2020-04-15 um 23:05 schrieb r...@apache.org: > > This is an automated email from the ASF dual-hosted git repository. > > > > remm pushed a commit to branch master > > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > >

Re: API Change - Connector.java Constructor

2020-04-16 Thread Rémy Maucherat
> <https://rmannibucau.metawerx.net/> | Old Blog > <http://rmannibucau.wordpress.com> | Github > <https://github.com/rmannibucau> | LinkedIn > <https://www.linkedin.com/in/rmannibucau> | Book > <https://www.packtpub.com/application-development

Re: [tomcat] branch master updated: Proposed Connector API and XML refactoring

2020-04-16 Thread Rémy Maucherat
On Thu, Apr 16, 2020 at 10:52 AM Mark Thomas wrote: > On 15/04/2020 22:05, r...@apache.org wrote: > > > > > Proposed Connector API and XML refactoring > > My first impression is that the cost for users is going to be high. > Simple Connector configurations are more complicated. > > Is there

Re: API Change - Connector.java Constructor

2020-04-15 Thread Rémy Maucherat
On Fri, Apr 10, 2020 at 6:32 PM Filip Hanik wrote: > > > On Fri, Apr 10, 2020 at 1:28 AM Rémy Maucherat wrote: > >> >> >>> This configuration gives the impression that the Endpoint is a child of >>> the Connector. >>> But the Conne

Re: [tomcat] branch 9.0.x updated (a7c132d -> 6ed7648)

2020-04-14 Thread Rémy Maucherat
On Tue, Apr 14, 2020 at 1:50 AM wrote: > This is an automated email from the ASF dual-hosted git repository. > > fhanik pushed a change to branch 9.0.x > in repository https://gitbox.apache.org/repos/asf/tomcat.git. > > > from a7c132d Add 9.0.34 release date > new 2e94898 Include

Re: API Change - Connector.java Constructor

2020-04-10 Thread Rémy Maucherat
On Thu, Apr 9, 2020 at 7:54 PM Filip Hanik wrote: > Thanks Remy, > > On Wed, Apr 8, 2020 at 8:48 AM Rémy Maucherat wrote: > >> >>> >> If we want to improve on the Connector situation regarding duplication >> and reflection abuse, the only solution is to e

Re: API Change - Connector.java Constructor

2020-04-08 Thread Rémy Maucherat
On Tue, Apr 7, 2020 at 8:42 PM Mark Thomas wrote: > On 07/04/2020 19:03, Filip Hanik wrote: > > > > > > On Tue, Apr 7, 2020 at 9:35 AM Rémy Maucherat > <mailto:r...@apache.org>> wrote: > > > > > > Does the connector need to know about

Re: API Change - Connector.java Constructor

2020-04-07 Thread Rémy Maucherat
On Tue, Apr 7, 2020 at 8:42 PM Mark Thomas wrote: > On 07/04/2020 19:03, Filip Hanik wrote: > > > > > > On Tue, Apr 7, 2020 at 9:35 AM Rémy Maucherat > <mailto:r...@apache.org>> wrote: > > > > > > Does the connector need to know about

Re: API Change - Connector.java Constructor

2020-04-07 Thread Rémy Maucherat
On Tue, Apr 7, 2020 at 5:22 PM Filip Hanik wrote: > On Tue, Apr 7, 2020 at 8:15 AM Rémy Maucherat wrote: > >> On Tue, Apr 7, 2020 at 10:16 AM Mark Thomas wrote: >> >>> > Noted, I think a compromise may be in order. Where we simply add a >>> >

Re: API Change - Connector.java Constructor

2020-04-07 Thread Rémy Maucherat
On Tue, Apr 7, 2020 at 10:16 AM Mark Thomas wrote: > > Noted, I think a compromise may be in order. Where we simply add a > > constructor that avoids the Class.forName > > and that allows the developer to explicitly invoke a constructor that > > avoids it. > > My thinking was more along the

Re: API Change - Connector.java Constructor

2020-04-07 Thread Rémy Maucherat
On Tue, Apr 7, 2020 at 10:16 AM Mark Thomas wrote: > My thinking was more along the following lines... > > Rewrite the Connector (and possibly some/all other components) so that > If we're talking about embedded, then the other components don't have the problem. For example to create a context

Re: Jakarta EE migration tool improvements

2020-04-07 Thread Rémy Maucherat
On Tue, Apr 7, 2020 at 11:54 AM Emmanuel Bourg wrote: > Hi, > > So I've started working on the Jakarta EE migration tool. I've some > enhancements in mind but I'd like to ensure there is a consensus before > proceeding. > > Here are my suggestions: > > - Turn the tool into a plugin for the main

Re: [tomcat-jakartaee-migration] 01/03: Replaced NonClosing{In, Out}putStream with the equivalent classes from Commons IO

2020-04-07 Thread Rémy Maucherat
On Tue, Apr 7, 2020 at 11:05 AM Emmanuel Bourg wrote: > Le 07/04/2020 à 09:41, Rémy Maucherat a écrit : > > > Reimplemeting ... It was already done, and this was a better trivial > > solution. This is a veto (unlike Mark I will not withdraw it), so please > > reve

Re: [tomcat-jakartaee-migration] 01/03: Replaced NonClosing{In, Out}putStream with the equivalent classes from Commons IO

2020-04-07 Thread Rémy Maucherat
On Mon, Apr 6, 2020 at 3:45 PM Emmanuel Bourg wrote: > Le 06/04/2020 à 15:38, Rémy Maucherat a écrit : > > > commit 29ea1891489060f3b3e40259098def5ae47645ef > > Author: Emmanuel Bourg mailto:ebo...@apache.org > >> > > AuthorDate: Mon Apr 6 15:24:35 20

Re: [tomcat-jakartaee-migration] 01/03: Replaced NonClosing{In, Out}putStream with the equivalent classes from Commons IO

2020-04-06 Thread Rémy Maucherat
On Mon, Apr 6, 2020 at 3:34 PM wrote: > This is an automated email from the ASF dual-hosted git repository. > > ebourg pushed a commit to branch master > in repository > https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git > > commit 29ea1891489060f3b3e40259098def5ae47645ef >

Re: [tomcat] branch master updated: Use a separate mbean type for SocketProperties

2020-04-06 Thread Rémy Maucherat
On Mon, Apr 6, 2020 at 1:36 PM wrote: > This is an automated email from the ASF dual-hosted git repository. > > remm pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > The following commit(s) were added to refs/heads/master by this push: >

Re: [tomcat-native] branch BZ-63671 created (now b73ecc1)

2020-04-06 Thread Rémy Maucherat
On Mon, Apr 6, 2020 at 1:22 PM wrote: > This is an automated email from the ASF dual-hosted git repository. > > michaelo pushed a change to branch BZ-63671 > in repository https://gitbox.apache.org/repos/asf/tomcat-native.git. > > > at b73ecc1 BZ 63671: libtcnative does not compile with

Re: [VOTE] Release Apache Tomcat 8.5.54

2020-04-06 Thread Rémy Maucherat
On Fri, Apr 3, 2020 at 4:30 PM Mark Thomas wrote: > The proposed Apache Tomcat 8.5.54 release is now available for voting. > > The major changes compared to the 8.5.53 release are: > > - Add support for default values when using ${...} property replacement > in configuration files. Based on a

Re: [VOTE] Release Apache Tomcat 9.0.34

2020-04-03 Thread Rémy Maucherat
On Fri, Apr 3, 2020 at 2:49 PM Mark Thomas wrote: > The proposed Apache Tomcat 9.0.34 release is now available for voting. > > The major changes compared to the 9.0.34 release are: > > - Add support for default values when using ${...} property replacement > in configuration files. Based on a

Re: [VOTE] Release Apache Tomcat 10.0.0-M4

2020-04-03 Thread Rémy Maucherat
On Fri, Apr 3, 2020 at 1:28 PM Mark Thomas wrote: > The proposed Apache Tomcat 10.0.0-M4 release is now available for > voting. > > Apache Tomcat 10.x implements Jakarta EE 9 and, as such, the primary > package for all the specification APIs has changed from javax.* to > jakarta.* > Applications

Re: Remaining Tomcat 10 items

2020-04-02 Thread Rémy Maucherat
On Fri, Mar 27, 2020 at 6:13 PM Mark Thomas wrote: > On 26/03/2020 16:47, Rémy Maucherat wrote: > > On Mon, Mar 23, 2020 at 10:37 AM Rémy Maucherat > <mailto:r...@apache.org>> wrote: > > > > - Remove the use of system properties to control configuration >

Re: [tomcat] 02/02: Add space before and after ':' as required by French grammar

2020-03-30 Thread Rémy Maucherat
On Mon, Mar 30, 2020 at 2:47 PM wrote: > This is an automated email from the ASF dual-hosted git repository. > > markt pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > commit 589664c1cfc978a445710455e380507a160f75ff > Author: Mark Thomas >

Re: Remaining Tomcat 10 items

2020-03-27 Thread Rémy Maucherat
On Fri, Mar 27, 2020 at 6:13 PM Mark Thomas wrote: > On 26/03/2020 16:47, Rémy Maucherat wrote: > > On Mon, Mar 23, 2020 at 10:37 AM Rémy Maucherat > <mailto:r...@apache.org>> wrote: > > > > - Remove the use of system properties to control configuration >

Re: Remaining Tomcat 10 items

2020-03-27 Thread Rémy Maucherat
On Fri, Mar 27, 2020 at 4:54 PM Mark Thomas wrote: > On 25/03/2020 13:43, Rémy Maucherat wrote: > > On Mon, Mar 23, 2020 at 11:11 AM Mark Thomas > <mailto:ma...@apache.org>> wrote: > > > > > - Reduce instances of setters and getters fo

Re: Tomcat Version 7.0.100: Service Loader no logging statements

2020-03-27 Thread Rémy Maucherat
On Fri, Mar 27, 2020 at 9:19 AM Martin Grigorov wrote: > Hi, > > On Thu, Mar 26, 2020 at 11:23 PM Rémy Maucherat wrote: > >> On Thu, Mar 26, 2020 at 9:16 PM Christopher O'Connell < >> coconnel...@gmail.com> wrote: >> >>> The Tomcat release ve

Re: Tomcat Version 7.0.100: Service Loader no logging statements

2020-03-26 Thread Rémy Maucherat
On Thu, Mar 26, 2020 at 9:16 PM Christopher O'Connell wrote: > The Tomcat release version 7.0.100 introduced a bug that prevented > ServiceLoaders from being started. This was fixed by the ticket: > https://bz.apache.org/bugzilla/show_bug.cgi?id=64191 (Thank you for > the fix) > > This problem

Re: Remaining Tomcat 10 items

2020-03-26 Thread Rémy Maucherat
On Mon, Mar 23, 2020 at 10:37 AM Rémy Maucherat wrote: > - Remove the use of system properties to control configuration wherever > possible. > I still don't see the point for quite a few of them. For others however, > using sys props was a mistake, example the facade rec

Re: [tomcat] branch master updated: Remove two system properties used for configuration

2020-03-25 Thread Rémy Maucherat
On Wed, Mar 25, 2020 at 8:20 PM Mark Thomas wrote: > On 25/03/2020 16:58, r...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > > > remm pushed a commit to branch master > > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > > > > The

Re: Remaining Tomcat 10 items

2020-03-25 Thread Rémy Maucherat
On Mon, Mar 23, 2020 at 11:11 AM Mark Thomas wrote: > > - Reduce instances of setters and getters for the same property existing > > on an object and its parent. This may require new objects to be exposed > > via JMX. > > Fixed enough ? > > From memory, this was primarily on the Connectors. That

Re: Remaining Tomcat 10 items

2020-03-23 Thread Rémy Maucherat
On Mon, Mar 23, 2020 at 11:11 AM Mark Thomas wrote: > On 23/03/2020 09:37, Rémy Maucherat wrote: > > Hi, > > > > I'm looking at the TODO list, in addition to some extra items. In order > ... > > > > - Java 11. > > I suppose Jakarta EE 9 will require Java

Re: Request line parsing

2020-03-23 Thread Rémy Maucherat
On Mon, Mar 23, 2020 at 2:01 PM Mark Thomas wrote: > Hi, > > I am currently looking at the request line parsing. I'll try and set out > each issue in turn. > > End of line parsing > === > > Prior to the recent changes, Tomcat allowed CRLF or LF to mark the end > of a line. The

Remaining Tomcat 10 items

2020-03-23 Thread Rémy Maucherat
Hi, I'm looking at the TODO list, in addition to some extra items. In order ... - Java 11. I suppose Jakarta EE 9 will require Java 11, is Java 11 [going to be] required for Tomcat 10 ? It could be better to do it in 10.1. - Remove the use of system properties to control configuration wherever

Re: buildbot failure in on tomcat-trunk

2020-03-20 Thread Rémy Maucherat
On Fri, Mar 20, 2020 at 11:39 AM wrote: > The Buildbot has detected a new failure on builder tomcat-trunk while > building tomcat. Full details are available at: > https://ci.apache.org/builders/tomcat-trunk/builds/5040 > > Buildbot URL: https://ci.apache.org/ > > Buildslave for this Build:

Re: [tomcat] branch master updated: Remove sync

2020-03-17 Thread Rémy Maucherat
On Tue, Mar 17, 2020 at 6:06 PM wrote: > This is an automated email from the ASF dual-hosted git repository. > > remm pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > The following commit(s) were added to refs/heads/master by this push: >

Re: [VOTE] Release Apache Tomcat 7.0.103

2020-03-17 Thread Rémy Maucherat
On Mon, Mar 16, 2020 at 10:13 AM Violeta Georgieva wrote: > The proposed Apache Tomcat 7.0.103 release is now available for voting. > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.103/ > The Maven staging repo is: >

Re: [tomcat-jakartaee-migration] branch master updated: Add javax.(decorator|enterprise|inject) as ones which should be migrated

2020-03-13 Thread Rémy Maucherat
On Fri, Mar 13, 2020 at 12:50 PM Mark Thomas wrote: > On 13/03/2020 11:36, Martin Grigorov wrote: > > > > > You neither explain a breaking use case nor modules/owb has any > > documentation :-/ > > But I will take your word and revert my change. > > > > If we should follow Romain's suggestion

Re: [tomcat-jakartaee-migration] branch master updated: Add javax.(decorator|enterprise|inject) as ones which should be migrated

2020-03-13 Thread Rémy Maucherat
On Fri, Mar 13, 2020 at 11:00 AM Martin Grigorov wrote: > Hi Rémy, > > On Thu, Mar 12, 2020 at 6:58 PM Rémy Maucherat wrote: > >> On Thu, Mar 12, 2020 at 3:10 PM wrote: >> >>> This is an automated email from the ASF dual-hosted git repository. >>> >

Re: [tomcat-jakartaee-migration] branch master updated: Add javax.(decorator|enterprise|inject) as ones which should be migrated

2020-03-12 Thread Rémy Maucherat
On Thu, Mar 12, 2020 at 3:10 PM wrote: > This is an automated email from the ASF dual-hosted git repository. > > mgrigorov pushed a commit to branch master > in repository > https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git > > > The following commit(s) were added to

Re: [VOTE] Release Apache Tomcat 7.0.102

2020-03-12 Thread Rémy Maucherat
On Thu, Mar 12, 2020 at 1:39 PM Violeta Georgieva wrote: > The proposed Apache Tomcat 7.0.102 release is now available for voting. > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.102/ > The Maven staging repo is: >

Re: [VOTE] Release Apache Tomcat 8.5.53

2020-03-11 Thread Rémy Maucherat
On Wed, Mar 11, 2020 at 12:18 PM Mark Thomas wrote: > The proposed Apache Tomcat 8.5.53 release is now available for voting. > > The major changes compared to the 8.5.51 release are: > > - Add new attribute persistAuthentication to both StandardManager and > PersistentManager to support

Re: [VOTE] Release Apache Tomcat 9.0.33

2020-03-11 Thread Rémy Maucherat
On Wed, Mar 11, 2020 at 10:51 AM Mark Thomas wrote: > The proposed Apache Tomcat 9.0.33 release is now available for voting. > > The major changes compared to the 9.0.31 release are: > > - Add new attribute persistAuthentication to both StandardManager and > PersistentManager to support

Re: [VOTE] Release Apache Tomcat 10.0.0-M3

2020-03-11 Thread Rémy Maucherat
On Wed, Mar 11, 2020 at 12:39 AM Mark Thomas wrote: > The proposed Apache Tomcat 10.0.0-M3 release is now available for > voting. > > Apache Tomcat 10.x implements Jakarta EE 9 and, as such, the primary > package for all the specification APIs has changed from javax.* to > jakarta.* >

Re: [Bug 64210] parsing request headers fail

2020-03-10 Thread Rémy Maucherat
On Tue, Mar 10, 2020 at 1:52 PM Mark Thomas wrote: > On 10/03/2020 10:14, bugzi...@apache.org wrote: > > https://bz.apache.org/bugzilla/show_bug.cgi?id=64210 > > > > --- Comment #3 from Mark Thomas --- > > Thanks. I'm able to reproduce this. I'm working on some additional test > cases > > and a

Re: [VOTE] Release Apache Tomcat 8.5.52

2020-03-06 Thread Rémy Maucherat
On Fri, Mar 6, 2020 at 12:52 PM Mark Thomas wrote: > The proposed Apache Tomcat 8.5.52 release is now available for voting. > > The major changes compared to the 8.5.51 release are: > > - Add new attribute persistAuthentication to both StandardManager and > PersistentManager to support

  1   2   3   4   5   6   7   8   9   10   >