Re: CI is back

2019-07-19 Thread Rémy Maucherat
ttps.protocols=TLSv1 > > (not sure that's needed) > > For the above TC 7 download steps, I also add to ANT_OPTS: > > -Dno.build.dbcp=true > > With that build recent versions worked for me. > > Regards, > > Rainer > > Am 19.07.2019 um 11:49 schrieb Rémy Ma

Re: CI is back

2019-07-19 Thread Rémy Maucherat
On Fri, Jul 19, 2019 at 12:05 PM Emmanuel Bourg wrote: > Le 16/07/2019 à 10:39, Mark Thomas a écrit : > > On July 15, 2019 11:08:22 PM UTC, "Rémy Maucherat" > wrote: > > > > That is by design. NSIS 3.x wasn't compatible with the version of WINE > availa

Re: CI is back

2019-07-19 Thread Rémy Maucherat
On Tue, Jul 16, 2019 at 11:10 PM Rémy Maucherat wrote: > On Tue, Jul 16, 2019 at 10:56 PM Mark Thomas wrote: > >> We need to ask infra to add wine to the list of packages installed on >> that box. That will need an INFRA jira ticket. >> > > Ok. > https://is

Re: CI is back

2019-07-16 Thread Rémy Maucherat
On Tue, Jul 16, 2019 at 10:56 PM Mark Thomas wrote: > We need to ask infra to add wine to the list of packages installed on that > box. That will need an INFRA jira ticket. > Ok. https://issues.apache.org/jira/browse/INFRA-18759 Rémy

Re: CI is back

2019-07-16 Thread Rémy Maucherat
On Tue, Jul 16, 2019 at 5:51 PM Mark Thomas wrote: > On July 16, 2019 1:17:15 PM UTC, "Rémy Maucherat" wrote: > >On Tue, Jul 16, 2019 at 10:39 AM Mark Thomas wrote: > > > >> On July 15, 2019 11:08:22 PM UTC, "Rémy Maucherat" > >> wrote: &

Re: Http11NioProtocol deadlocks with useAsyncIO="true" and HTTPS/2.0

2019-07-16 Thread Rémy Maucherat
please use the user list. This is not a "deadlock", but rather a request not completing properly for some reason. Rémy > > - Manuel Dominguez Sarmiento > > On 16/07/2019 05:42, Mark Thomas wrote: > > On July 16, 2019 7:20:28 AM UTC, "Rémy Maucherat" >

Re: CI is back

2019-07-16 Thread Rémy Maucherat
On Tue, Jul 16, 2019 at 10:39 AM Mark Thomas wrote: > On July 15, 2019 11:08:22 PM UTC, "Rémy Maucherat" > wrote: > >Hi, > > > >It seems CI is back up :) Great news ! > > > >However, there's something odd with the build: > > > https:

Re: Http11NioProtocol deadlocks with useAsyncIO="true" and HTTPS/2.0

2019-07-16 Thread Rémy Maucherat
On Mon, Jul 15, 2019 at 11:30 PM Manuel Dominguez Sarmiento wrote: > Hi, we had been running Tomcat 9.0.17 for quite some time on our high-load > production servers, using the attached server.xml configuration. > > Upon upgrading to 9.0.21 we started experiencing many random deadlocks. We > run

CI is back

2019-07-15 Thread Rémy Maucherat
Hi, It seems CI is back up :) Great news ! However, there's something odd with the build: https://ci.apache.org/builders/tomcat-trunk/builds/4485/steps/compile/logs/stdio It's downloading NSIS 2.51 while it should be using 3.04. CI might be using some old properties here, right ? This should

Re: Graal and Tomcat Native

2019-07-15 Thread Rémy Maucherat
On Fri, Jul 12, 2019 at 11:21 AM Rémy Maucherat wrote: > In the native code, it crashes on: > https://github.com/apache/tomcat-native/blob/master/native/src/ssl.c#L635 > > I modified the code to: > double d = (((double)(rand()%RAND_MAX)/RAND_MAX)*(h-l)); > apr_snprin

Re: [VOTE] Release Apache Tomcat 7.0.95

2019-07-15 Thread Rémy Maucherat
On Thu, Jul 11, 2019 at 8:39 PM Violeta Georgieva wrote: > The proposed Apache Tomcat 7.0.95 release is now available for voting. > > For full details, see the changelog: > https://ci.apache.org/projects/tomcat/tomcat7/docs/changelog.html > > It can be obtained from: >

Re: [tomcat] 02/02: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63524 part 2 of 2

2019-07-12 Thread Rémy Maucherat
On Fri, Jul 12, 2019 at 5:35 PM wrote: > This is an automated email from the ASF dual-hosted git repository. > > markt pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > commit f1a93f0945cd4d90ea8e63d700c7cc5d70ae16e1 > Author: Mark Thomas >

Re: Graal and Tomcat Native

2019-07-12 Thread Rémy Maucherat
On Thu, Jul 11, 2019 at 11:01 PM Rainer Jung wrote: > Am 11.07.2019 um 22:10 schrieb Rémy Maucherat: > > On Thu, Jul 11, 2019 at 8:42 PM Rainer Jung > <mailto:rainer.j...@kippdata.de>> wrote: > > > > Hi Rémy, > > > > When one looks up t

Re: Graal and Tomcat Native

2019-07-11 Thread Rémy Maucherat
On Thu, Jul 11, 2019 at 8:42 PM Rainer Jung wrote: > Hi Rémy, > > Am 11.07.2019 um 18:35 schrieb Rémy Maucherat: > > On Thu, Jul 11, 2019 at 4:36 PM Rainer Jung > <mailto:rainer.j...@kippdata.de>> wrote: > > > > Probably not very helup, but

Re: Graal and Tomcat Native

2019-07-11 Thread Rémy Maucherat
On Thu, Jul 11, 2019 at 4:36 PM Rainer Jung wrote: > Probably not very helup, but to make sure, the GetEnv is failing, I > would add a little code to native/src/jnilib.c in JNI_OnLoad() that > creates an observable side effect while executing int he function. E.g. > on Unix/Linux you could add

Re: Graal and Tomcat Native

2019-07-11 Thread Rémy Maucherat
sn't work. However, the rest works as I expected. Rémy > > Regards, > > Rainer > > Am 10.07.2019 um 20:42 schrieb Rémy Maucherat: > > Hi, > > > > I'm a bit stumped there, as I'm trying to get native to work in that > > rather special environment. > > >

Re: Graal and Tomcat Native

2019-07-10 Thread Rémy Maucherat
On Wed, Jul 10, 2019 at 9:10 PM Igal Sapir wrote: > Rémy, > > At the risk of pointing out the obvious as I'm sure that you are much > more familiar with this than I am: > > On 7/10/2019 11:42 AM, Rémy Maucherat wrote: > > Hi, > > > > I'm a bit stumped there,

Graal and Tomcat Native

2019-07-10 Thread Rémy Maucherat
Hi, I'm a bit stumped there, as I'm trying to get native to work in that rather special environment. JNI_OnLoad fails with: WARNING: The APR based Apache Tomcat Native library failed to load. The error reported was [Unsupported JNI version 0x, required by bin/libtcnative-1.so.0.2.23]

Re: [tomcat] branch mark-forwarded-request/8.5.x created (now 644af22)

2019-07-09 Thread Rémy Maucherat
On Tue, Jul 9, 2019 at 3:55 PM wrote: > This is an automated email from the ASF dual-hosted git repository. > > michaelo pushed a change to branch mark-forwarded-request/8.5.x > in repository https://gitbox.apache.org/repos/asf/tomcat.git. > > > at 644af22 Better attribute name > > This

Re: [VOTE] Release Apache Tomcat 8.5.43

2019-07-08 Thread Rémy Maucherat
On Thu, Jul 4, 2019 at 11:19 PM Mark Thomas wrote: > The proposed Apache Tomcat 8.5.43 release is now available for voting. > > The major changes compared to the 8.5.42 release are: > > - Add the ability for a UserDatabase to monitor the backing XML file > for changes and reload the source

Re: [VOTE] Release Apache Tomcat 9.0.22

2019-07-04 Thread Rémy Maucherat
On Thu, Jul 4, 2019 at 9:33 PM Mark Thomas wrote: > The proposed Apache Tomcat 9.0.22 release is now available for voting. > > The major changes compared to the 9.0.21 release are: > > - Add user buildable optional modules for easier CDI 2 and JAX-RS > support. Also include a new documentation

Re: [tomcat] branch master updated: Quick fix for poller issue reported on users list

2019-07-04 Thread Rémy Maucherat
On Wed, Jul 3, 2019 at 10:42 PM Mark Thomas wrote: > On 03/07/2019 20:46, ma...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > > > markt pushed a commit to branch master > > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > > > >

Re: [VOTE] Release Apache Tomcat Native 1.2.23

2019-07-01 Thread Rémy Maucherat
On Wed, Jun 26, 2019 at 3:20 PM Mark Thomas wrote: > Version 1.2.23 includes the following changes compared to 1.2.21 > > - Fix crashes associated with the use of a CRL > > - Add support for TLS key logging. Patch provided by John Kelly. > > - Make Windows 7 the default build target on Windows >

New OWB and CXF modules

2019-06-26 Thread Rémy Maucherat
Hi, To pick up the discussion where it was left off last time and propose a plan ... I'm proposing to add two optional modules in the Tomcat repository (in /modules/ next to jdbc-pool) as they look to me a decent way to use some microprofile specs (notably health and metrics, both of which are

Re: Tomcat-Native - Time to move to git?

2019-06-17 Thread Rémy Maucherat
On Mon, Jun 17, 2019 at 6:56 PM Mark Thomas wrote: > Hi, > > I'm starting to look at OCSP stapling for our OpenSSL based connectors > and I suspect a Tomcat Native release will be required. Even if it isn't > for this, it has been a while since the last Tomcat Native release so I > expect we'll

Re: CDI support improvements

2019-06-17 Thread Rémy Maucherat
On Mon, Jun 17, 2019 at 10:52 AM Romain Manni-Bucau wrote: > Hi Rémy, > > Great progression! Congrats! > > I have a few (details) notes - guess i'm opening an open door but just to > ensure: > > 1. Is it intended to bind cxf to /rest/* in any case? I tend to see it > bound on on /api but

Re: JDK 13 enters Rampdown Phase One

2019-06-17 Thread Rémy Maucherat
On Sun, Jun 16, 2019 at 8:01 AM Rory O'Donnell wrote: > Hi Mark, > > *JDK 13 Early Access build **25 is now available **at : - > jdk.java.net/13/ * > > >- Per the JDK 13 schedule [1], we are now in Rampdown Phase One. > - For more details , see Mark Reinhold's

Re: CDI support improvements

2019-06-17 Thread Rémy Maucherat
Hi Romain, On Thu, Jun 13, 2019 at 6:52 PM Romain Manni-Bucau wrote: > > https://github.com/apache/cxf/blob/master/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/utils/JAXRSUtils.java#L1412 > is likely the one but looks like johnzon was not scanned nor registered > programmatically > >

Re: CDI support improvements

2019-06-13 Thread Rémy Maucherat
On Thu, Jun 13, 2019 at 6:52 PM Romain Manni-Bucau wrote: > > https://github.com/apache/cxf/blob/master/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/utils/JAXRSUtils.java#L1412 > is likely the one but looks like johnzon was not scanned nor registered > programmatically > > Maybe code

Re: CDI support improvements

2019-06-13 Thread Rémy Maucherat
.com> | Github > <https://github.com/rmannibucau> | LinkedIn > <https://www.linkedin.com/in/rmannibucau> | Book > <https://www.packtpub.com/application-development/java-ee-8-high-performance> > > > Le jeu. 13 juin 2019 à 17:26, Rémy Maucherat a écrit : >

Re: CDI support improvements

2019-06-13 Thread Rémy Maucherat
On Wed, Jun 12, 2019 at 8:32 AM Romain Manni-Bucau wrote: > Joke apart, and assuming you grabbed the spec yourself (geronimo, javax or > jakarta jars) you just need: > > org.apache.cxf:cxf-core:3.3.2 > org.apache.cxf:cxf-rt-security:3.3.2 > org.apache.cxf:cxf-rt-transports-http:3.3.2 >

Re: [Bug 58768] Add Logging to Response.sendRedirect

2019-06-12 Thread Rémy Maucherat
On Wed, Jun 12, 2019 at 5:51 PM Mark Thomas wrote: > On 12/06/2019 16:17, bugzi...@apache.org wrote: > > https://bz.apache.org/bugzilla/show_bug.cgi?id=58768 > > > > --- Comment #2 from david --- > > Sigh. The idiot is back with a different email address. > > Account locked, spam cleaned up,

Re: CDI support improvements

2019-06-12 Thread Rémy Maucherat
t; makes sense? > > txs and LieGrue, > strub > > > > > Am 12.06.2019 um 08:31 schrieb Romain Manni-Bucau >: > > > > Hell Rémy, > > > > I commented inline > > > > Le mar. 11 juin 2019 à 23:29, Rémy Maucherat a écrit : > > On Tue, Jun

Re: CDI support improvements

2019-06-12 Thread Rémy Maucherat
On Wed, Jun 12, 2019 at 8:32 AM Romain Manni-Bucau wrote: > Hell Rémy, > > I commented inline > > Le mar. 11 juin 2019 à 23:29, Rémy Maucherat a écrit : > >> On Tue, Jun 11, 2019 at 9:49 PM Romain Manni-Bucau >> wrote: >> >>> My 2cts would be that

Re: CDI support improvements

2019-06-11 Thread Rémy Maucherat
bucau.wordpress.com> | Github > <https://github.com/rmannibucau> | LinkedIn > <https://www.linkedin.com/in/rmannibucau> | Book > <https://www.packtpub.com/application-development/java-ee-8-high-performance> > > > Le mar. 11 juin 2019 à 21:22, Rémy Maucherat a écrit :

Re: CDI support improvements

2019-06-11 Thread Rémy Maucherat
f specs. > Rémy > > > -- > David Blevins > http://twitter.com/dblevins > http://www.tomitribe.com > > > On Jun 11, 2019, at 8:06 AM, Romain Manni-Bucau > wrote: > > > > > > > > Le mar. 11 juin 2019 à 16:57, Rémy Maucherat a écrit : > >

Re: CDI support improvements

2019-06-11 Thread Rémy Maucherat
On Thu, May 30, 2019 at 9:35 AM Romain Manni-Bucau wrote: > Once done it can be hosted on both side.Owb has the advantage to be know > by users, tomcat to be a more natural home for an integration. At the end > it is mainly synchronizing both projects for a consistent communication and > code

Re: [tomcat] branch master updated: Follow-up to e967bbc. Provide a sync but on a different object.

2019-06-07 Thread Rémy Maucherat
On Fri, Jun 7, 2019 at 12:57 PM wrote: > This is an automated email from the ASF dual-hosted git repository. > > markt pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > The following commit(s) were added to refs/heads/master by this push: >

Re: [tomcat] 02/02: Remove a source of potential deadlocks

2019-06-07 Thread Rémy Maucherat
On Fri, Jun 7, 2019 at 11:00 AM Mark Thomas wrote: > On 06/06/2019 22:51, Mark Thomas wrote: > > > > > I haven't quite tracked down the other deadlock yet. The timing gap is > > narrower so it is harder to capture. I have some ideas to work on > tomorrow. > > This is the stack trace: > >

Re: [tomcat] 02/02: Remove a source of potential deadlocks

2019-06-06 Thread Rémy Maucherat
On Thu, Jun 6, 2019 at 10:46 PM wrote: > This is an automated email from the ASF dual-hosted git repository. > > markt pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > commit e967bbc7f106f8ec5384a294d98d5cbc44b474f1 > Author: Mark Thomas >

Re: [VOTE] Release Apache Tomcat 8.5.42

2019-06-05 Thread Rémy Maucherat
On Tue, Jun 4, 2019 at 11:06 PM Mark Thomas wrote: > The proposed Apache Tomcat 8.5.42 release is now available for voting. > > The major changes compared to the 8.5.41 release are: > > - Fix various concurrency and stability issues for HTTP/2. > > - Add support for same-site cookie attribute.

Re: [VOTE] Release Apache Tomcat 9.0.21

2019-06-04 Thread Rémy Maucherat
On Tue, Jun 4, 2019 at 10:50 PM Mark Thomas wrote: > The proposed Apache Tomcat 9.0.21 release is now available for voting. > > The major changes compared to the 9.0.20 release are: > > - Fix various concurrency and stability issues for HTTP/2. > > - Add support for same-site cookie attribute.

Re: [tomcat] branch master updated: Add fake parameters on two tests which (rarely) fail for me

2019-06-04 Thread Rémy Maucherat
On Tue, Jun 4, 2019 at 3:46 PM Mark Thomas wrote: > On 04/06/2019 12:25, Mark Thomas wrote: > > On 04/06/2019 12:17, r...@apache.org wrote: > >> This is an automated email from the ASF dual-hosted git repository. > >> > >> remm pushed a commit to branch master > >> in repository

Re: Tagging 9.0.x and 8.5.x

2019-06-04 Thread Rémy Maucherat
On Mon, Jun 3, 2019 at 11:40 PM Mark Thomas wrote: > http://people.apache.org/~markt/patches/2019-06-03-h2-v1.patch I'm testing extensively, and this patch http://people.apache.org/~markt/patches/2019-06-03-h2-v2.patch looks good to me. Rémy

Re: Tagging 9.0.x and 8.5.x

2019-06-03 Thread Rémy Maucherat
On Mon, Jun 3, 2019 at 11:40 PM Mark Thomas wrote: > On 03/06/2019 22:29, Rémy Maucherat wrote: > > > How about this as an idea: > > > > --- a/java/org/apache/coyote/AbstractProtocol.java > > +++ b/java/org/apache/coyote/AbstractProtocol.

Re: Tagging 9.0.x and 8.5.x

2019-06-03 Thread Rémy Maucherat
On Mon, Jun 3, 2019 at 11:06 PM Mark Thomas wrote: > On 03/06/2019 21:45, Rémy Maucherat wrote: > > On Mon, Jun 3, 2019 at 10:05 PM Mark Thomas > <mailto:ma...@apache.org>> wrote: > > > > On 03/06/2019 19:54, Rémy Maucherat wrote: > > > >

Re: Tagging 9.0.x and 8.5.x

2019-06-03 Thread Rémy Maucherat
On Mon, Jun 3, 2019 at 10:05 PM Mark Thomas wrote: > On 03/06/2019 19:54, Rémy Maucherat wrote: > > > > > Ok, that's completely different ;) I tried to be careful with that, but > > the algorithm changes to non blocking, so obviously there were some > > risks in

Re: Tagging 9.0.x and 8.5.x

2019-06-03 Thread Rémy Maucherat
On Mon, Jun 3, 2019 at 8:36 PM Mark Thomas wrote: > On 03/06/2019 16:43, Mark Thomas wrote: > > On 03/06/2019 14:15, Rémy Maucherat wrote: > > > > >> I think I have found at least one more edge case around the > >> Stream/Connection allocation

Re: Tagging 9.0.x and 8.5.x

2019-06-03 Thread Rémy Maucherat
On Mon, Jun 3, 2019 at 1:21 PM Mark Thomas wrote: > Hi, > > It is the start of another month so I intend to tag 9.0.x and 8.5.x > shortly. Or at least I did until I found a handful of HTTP/2 related > failures when I ran the unit tests on Windows for 9.0.x. > Bad news :( I haven't run into it.

Re: CDI support improvements

2019-05-29 Thread Rémy Maucherat
all 3 libs for smaller bundles ;). > Ok. > > Feel free to shout if you need help or more precise pointers. > Rémy > > > Le mer. 29 mai 2019 à 18:26, Rémy Maucherat a écrit : > >> Hi, >> >> This was on my hackaton todo list, I guess I'm a bit late,

CDI support improvements

2019-05-29 Thread Rémy Maucherat
Hi, This was on my hackaton todo list, I guess I'm a bit late, but getting to it now ... CDI is the building brick for many other popular libraries and frameworks, including JAX-RS (Apache CXF), Eclipse Microprofile, etc. Looking at the CDI implementation from the ASF, I am not fully satisfied

Re: buildbot failure in on tomcat-trunk

2019-05-29 Thread Rémy Maucherat
On Wed, May 29, 2019 at 4:54 PM wrote: > The Buildbot has detected a new failure on builder tomcat-trunk while > building tomcat. Full details are available at: > https://ci.apache.org/builders/tomcat-trunk/builds/4401 > > Buildbot URL: https://ci.apache.org/ > > Buildslave for this Build:

Re: [tomcat] branch master updated: Follow-up to c2d6278. NPE->ClosedChannelException for closed socket

2019-05-29 Thread Rémy Maucherat
On Wed, May 29, 2019 at 3:11 PM wrote: > This is an automated email from the ASF dual-hosted git repository. > > markt pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > The following commit(s) were added to refs/heads/master by this push: >

Re: [tomcat] branch master updated: Move ADD_CHILD_EVENT to before the optional container start

2019-05-29 Thread Rémy Maucherat
On Wed, May 29, 2019 at 12:26 PM Mark Thomas wrote: > On 29/05/2019 08:46, r...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > > > remm pushed a commit to branch master > > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > > > > The

Re: [tomcat] branch master updated: Add utility Server listener

2019-05-28 Thread Rémy Maucherat
On Tue, May 28, 2019 at 11:04 PM Rémy Maucherat wrote: > On Tue, May 28, 2019 at 10:47 PM Mark Thomas wrote: > >> On 28/05/2019 15:40, r...@apache.org wrote: >> > This is an automated email from the ASF dual-hosted git repository. >> > >> >

Re: [tomcat] branch master updated: Add utility Server listener

2019-05-28 Thread Rémy Maucherat
On Tue, May 28, 2019 at 10:47 PM Mark Thomas wrote: > On 28/05/2019 15:40, r...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > > > remm pushed a commit to branch master > > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > > > > The

Re: [tomcat] branch master updated: Sync on socketWrapper like the non async code does

2019-05-28 Thread Rémy Maucherat
On Fri, May 24, 2019 at 10:17 AM wrote: > This is an automated email from the ASF dual-hosted git repository. > > remm pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > The following commit(s) were added to refs/heads/master by this push: >

Re: NIO changes

2019-05-21 Thread Rémy Maucherat
On Tue, May 21, 2019 at 5:57 PM Mark Thomas wrote: > On 21/05/2019 14:57, Rémy Maucherat wrote: > > Hi, > > > > In preparation for HTTPx in the future, I was looking at how to start > > adding UDP, and: > > - NIO2 and APR don't have datagram support, the first o

NIO changes

2019-05-21 Thread Rémy Maucherat
Hi, In preparation for HTTPx in the future, I was looking at how to start adding UDP, and: - NIO2 and APR don't have datagram support, the first one is hopeless and the second one is legacy. - It would be better to avoid duplicating the whole NIO connector, but rather add a datagram mode to it. -

Re: [tomcat] 02/02: Silence false positive IDE warning

2019-05-19 Thread Rémy Maucherat
On Sat, May 18, 2019 at 5:03 PM wrote: > This is an automated email from the ASF dual-hosted git repository. > > markt pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > commit 99e36dc2c38518f7eeef2295852836aa88df5f1e > Author: Mark Thomas >

Re: [tomcat] branch master updated: Add comment to unreachable code

2019-05-17 Thread Rémy Maucherat
On Fri, May 17, 2019 at 6:27 PM Mark Thomas wrote: > On 17/05/2019 17:25, ma...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > > > markt pushed a commit to branch master > > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > > > >

Re: [tomcat] branch master updated: Fix build

2019-05-15 Thread Rémy Maucherat
On Wed, May 15, 2019 at 2:25 PM Mark Thomas wrote: > On 15/05/2019 12:56, r...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > > > remm pushed a commit to branch master > > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > > > > The

Re: [tomcat] branch master updated: Make sure timeout elapses before calling a timeout

2019-05-10 Thread Rémy Maucherat
On Fri, May 10, 2019 at 8:01 PM Mark Thomas wrote: > I've just pushed a fix. The tests seem more stable now locally but I am > going to keep running them. Thanks for the pointer. The issue was > obvious as soon as I read your email. > > Given the issue has been there for a while, unless anyone

Re: [tomcat] branch master updated: Make sure timeout elapses before calling a timeout

2019-05-10 Thread Rémy Maucherat
On Fri, May 10, 2019 at 5:41 PM Mark Thomas wrote: > On 10/05/2019 16:26, Rémy Maucherat wrote: > > On Fri, May 10, 2019 at 11:14 AM Mark Thomas wrote: > > > >> On 09/05/2019 21:53, Mark Thomas wrote: > >>> On 05/05/2019 09:37, r...@apache.org wrote: &g

Re: [tomcat] branch master updated: Make sure timeout elapses before calling a timeout

2019-05-10 Thread Rémy Maucherat
On Fri, May 10, 2019 at 11:14 AM Mark Thomas wrote: > On 09/05/2019 21:53, Mark Thomas wrote: > > On 05/05/2019 09:37, r...@apache.org wrote: > >> This is an automated email from the ASF dual-hosted git repository. > >> > >> remm pushed a commit to branch master > >> in repository

Re: Multi threaded accept and polling

2019-05-09 Thread Rémy Maucherat
On Thu, May 9, 2019 at 6:44 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Rémy and Mark, > > On 5/9/19 12:32, Rémy Maucherat wrote: > > On Thu, May 9, 2019 at 4:47 PM Mark Thomas > > wrote

Re: Multi threaded accept and polling

2019-05-09 Thread Rémy Maucherat
On Thu, May 9, 2019 at 4:47 PM Mark Thomas wrote: > On 09/05/2019 14:38, Rémy Maucherat wrote: > > > > >> +1 to hard-coding to a single acceptor thread and removing the plumbing > >> that supports more than that. > > > > Ok, done. > > Great. &

Re: Multi threaded accept and polling

2019-05-09 Thread Rémy Maucherat
On Thu, May 9, 2019 at 2:36 PM Mark Thomas wrote: > accept() is effectively synchronized at the OS level. > > I recall doing some testing on this and there was a small gain in > throughput when testing on localhost without keep-alive if I used two > accept threads. Essentially, one thread was

Multi threaded accept and polling

2019-05-09 Thread Rémy Maucherat
Hi, A long time ago (in this galaxy, not another one), Tomcat has added the capability to have multiple accept threads. I have no idea what test revealed that Tomcat was somehow not accepting sockets fast enough, and maybe it could be the case in crazy microbenchmarks, but this is not going to

Re: javax.tools based JSP compiler

2019-05-08 Thread Rémy Maucherat
On Wed, May 8, 2019 at 10:31 PM Emmanuel Bourg wrote: > Hi all, > > I've rebased the javax.tools JSP compiler on top of the current master > branch : > > https://github.com/ebourg/tomcat/tree/jasper-javax-tools-support > > Please let me know how you feel about this stuff and if it's worth

Re: More Vector -> ArrayList

2019-05-08 Thread Rémy Maucherat
On Wed, May 8, 2019 at 10:06 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > All, > > It seems that Vector is used a lot in Tomcat code. > > Since the JSP engine is riddled with uses, I figured I'd start > elsewhere with my

Re: [OT] Jakarta package change

2019-05-08 Thread Rémy Maucherat
On Wed, May 8, 2019 at 6:22 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Mark, > > On 5/7/19 06:31, Mark Thomas wrote: > > Rather than announcing a solution, how about we announce that we > > will continue to support the

Re: Jakarta package change

2019-05-07 Thread Rémy Maucherat
t at all, but this is completely undecided at this point. And I agree with Mark (T) that there are too many unknowns and it's too early to make a decision. Rémy > > LieGrue, > strub > > > Am 07.05.2019 um 14:09 schrieb Rémy Maucherat : > > > > On Tue, May 7

Re: Jakarta package change

2019-05-07 Thread Rémy Maucherat
On Tue, May 7, 2019 at 12:31 PM Mark Thomas wrote: > On 07/05/2019 08:05, Rémy Maucherat wrote: > > Hi, > > > > Background information: > > https://eclipse-foundation.blog/2019/05/03/jakarta-ee-java-trademarks/ > > > > So this is obviously a large

Re: Jakarta package change

2019-05-07 Thread Rémy Maucherat
On Tue, May 7, 2019 at 10:31 AM Emmanuel Bourg wrote: > Le 07/05/2019 à 09:05, Rémy Maucherat a écrit : > > > - Maintain a Tomcat 9.x "forever" with Servlet 4.0. As a result, all the > > APIs in Tomcat 9 can remain javax.* and users with "old" applicatio

Jakarta package change

2019-05-07 Thread Rémy Maucherat
Hi, Background information: https://eclipse-foundation.blog/2019/05/03/jakarta-ee-java-trademarks/ So this is obviously a large breaking change. While there are plenty of options, there is a simple one too: - Maintain a Tomcat 9.x "forever" with Servlet 4.0. As a result, all the APIs in Tomcat 9

Re: [VOTE] Release Apache Tomcat 9.0.20

2019-05-04 Thread Rémy Maucherat
On Sat, May 4, 2019 at 12:13 PM Rémy Maucherat wrote: > On Sat, May 4, 2019 at 12:52 AM Mark Thomas wrote: > >> The proposed Apache Tomcat 9.0.20 release is now available for voting. >> >> The major changes compared to the 9.0.19 release are: >> >>

Re: [VOTE] Release Apache Tomcat 8.5.41

2019-05-04 Thread Rémy Maucherat
On Sat, May 4, 2019 at 11:57 AM Mark Thomas wrote: > The proposed Apache Tomcat 8.5.41 release is now available for voting. > > The major changes compared to the 8.5.40 release are: > > - Stack traces written by the OneLineFormatter are fully indented. The > entire stack trace is now indented

Re: [VOTE] Release Apache Tomcat 9.0.20

2019-05-04 Thread Rémy Maucherat
On Sat, May 4, 2019 at 12:52 AM Mark Thomas wrote: > The proposed Apache Tomcat 9.0.20 release is now available for voting. > > The major changes compared to the 9.0.19 release are: > > - The useAsyncIO boolean attribute on the Connector element value now > defaults to true. > > - Stack traces

Re: Tagging 9.0.x and 8.5.x

2019-05-02 Thread Rémy Maucherat
On Wed, May 1, 2019 at 11:23 PM Mark Thomas wrote: > Hi, > > Just a heads up that I'm intended to tag these soon. Possibly tomorrow > but certainly by the end of the week. I just have a few things I want to > look at first. > Should I leave the async IO code enabled, or should it remain

Re: Remote attendance at Hackathon

2019-05-02 Thread Rémy Maucherat
On Thu, May 2, 2019 at 11:15 AM Mark Thomas wrote: > On 02/05/2019 10:05, Rémy Maucherat wrote: > > On Wed, May 1, 2019 at 11:03 PM Mark Thomas wrote: > > > >> Hi all, > >> > >> What to folks think about setting up a #Tomcat channel on the A

Re: Remote attendance at Hackathon

2019-05-02 Thread Rémy Maucherat
On Wed, May 1, 2019 at 11:03 PM Mark Thomas wrote: > Hi all, > > What to folks think about setting up a #Tomcat channel on the ASF slack > instance and using it during the hackathon to interact with folks that > want to be involved but can't travel? > > It would allow general chat as well as

Re: catalina.nonblocking.TestNonBlockingAPI

2019-05-01 Thread Rémy Maucherat
On Tue, Apr 30, 2019 at 2:13 PM Mark Thomas wrote: > On 30/04/2019 12:48, Rémy Maucherat wrote: > > Hi, > > > > There's something odd with this test: > > > https://ci.apache.org/projects/tomcat/tomcat9/logs/4265/TEST-org.apache.catalina.nonblocking.TestNonB

catalina.nonblocking.TestNonBlockingAPI

2019-04-30 Thread Rémy Maucherat
Hi, There's something odd with this test: https://ci.apache.org/projects/tomcat/tomcat9/logs/4265/TEST-org.apache.catalina.nonblocking.TestNonBlockingAPI.APR.txt https://ci.apache.org/projects/tomcat/tomcat9/logs/4265/TEST-org.apache.catalina.nonblocking.TestNonBlockingAPI.NIO.txt

Re: [tomcat] branch master updated: Better error for empty header name

2019-04-29 Thread Rémy Maucherat
On Mon, Apr 29, 2019 at 1:53 PM Mark Thomas wrote: > On 29/04/2019 12:30, r...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > > > remm pushed a commit to branch master > > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > > > > The

Re: [tomcat] branch master updated: Use async by default for now

2019-04-29 Thread Rémy Maucherat
On Fri, Apr 12, 2019 at 6:15 PM wrote: > This is an automated email from the ASF dual-hosted git repository. > > remm pushed a commit to branch master > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > The following commit(s) were added to refs/heads/master by this push: >

Re: Becoming graalvm friendly?

2019-04-26 Thread Rémy Maucherat
On Thu, Apr 25, 2019 at 3:07 PM Rémy Maucherat wrote: > On Wed, Apr 24, 2019 at 6:29 PM Romain Manni-Bucau > wrote: > >> Awesome news Rémy, thanks for sharing! >> > > Next roadblock is https://github.com/oracle/graal/issues/684 > It's probably not 100% mandatory

Re: Becoming graalvm friendly?

2019-04-25 Thread Rémy Maucherat
On Wed, Apr 24, 2019 at 6:29 PM Romain Manni-Bucau wrote: > Awesome news Rémy, thanks for sharing! > Next roadblock is https://github.com/oracle/graal/issues/684 It's probably not 100% mandatory but I'd rather have a minimum of flexibility (I'm not a big believer of Java only embedding since

Re: Becoming graalvm friendly?

2019-04-24 Thread Rémy Maucherat
On Thu, Mar 28, 2019 at 3:38 PM Rémy Maucherat wrote: > On Wed, Mar 20, 2019 at 4:45 PM Romain Manni-Bucau > wrote: > >> Most of the time monitoring is done through a custom exporter in practise >> based on other impl - sigar, library integration like >> hibernate

Re: Finally getting around to switching to Git

2019-04-23 Thread Rémy Maucherat
On Tue, Apr 23, 2019 at 4:29 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > Rémy, > > On 4/23/19 10:07, Rémy Maucherat wrote: > > On Tue, Apr 23, 2019 at 3:54 PM Christopher Schultz < > &

Re: Finally getting around to switching to Git

2019-04-23 Thread Rémy Maucherat
On Tue, Apr 23, 2019 at 3:54 PM Christopher Schultz < ch...@christopherschultz.net> wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > All, > > I haven't updated my local working copies of Tomcat source since the > move to Git. I'm going to do that, now, and I'm looking for advice. >

Re: buildbot failure in on tomcat-trunk

2019-04-18 Thread Rémy Maucherat
On Thu, Apr 18, 2019 at 10:28 AM wrote: > The Buildbot has detected a new failure on builder tomcat-trunk while > building tomcat. Full details are available at: > https://ci.apache.org/builders/tomcat-trunk/builds/4230 > > Buildbot URL: https://ci.apache.org/ > > Buildslave for this Build:

Re: buildbot failure in on tomcat-85-trunk

2019-04-17 Thread Rémy Maucherat
On Wed, Apr 17, 2019 at 3:33 PM wrote: > The Buildbot has detected a new failure on builder tomcat-85-trunk while > building tomcat. Full details are available at: > https://ci.apache.org/builders/tomcat-85-trunk/builds/1739 > > Buildbot URL: https://ci.apache.org/ > > Buildslave for this

Re: [VOTE][RESULT] Release Apache Tomcat 9.0.19

2019-04-14 Thread Rémy Maucherat
On Sun, Apr 14, 2019 at 12:26 AM Mark Thomas wrote: > Given the extensive testing of the 9.0.18 release candidate, the minimal > changes between 9.0.18 and 9.0.19 and CVE-2019-0232 I am ending this > vote early in order to get the 9.0.19 release out faster. > > The following votes were cast: > >

Re: [tomcat] branch master updated (1a4bfa2 -> 49f1b8a)

2019-04-12 Thread Rémy Maucherat
On Fri, Apr 12, 2019 at 5:21 PM wrote: > This is an automated email from the ASF dual-hosted git repository. > > markt pushed a change to branch master > in repository https://gitbox.apache.org/repos/asf/tomcat.git. > > > from 1a4bfa2 9.0.18 was not release > new dda11ac Increment

Re: [VOTE] Release Apache Tomcat 9.0.19

2019-04-12 Thread Rémy Maucherat
On Fri, Apr 12, 2019 at 4:48 PM Mark Thomas wrote: > The proposed Apache Tomcat 9.0.19 release is now available for voting. > 9.0.19 corrects a regression and a number of packaging errors in 9.0.18. > > The major changes compared to the 9.0.17 release are: > > - Fix for CVE-2019-0232 a RCE

Re: [VOTE][CANCELLED] Release Apache Tomcat 9.0.18

2019-04-12 Thread Rémy Maucherat
On Fri, Apr 12, 2019 at 3:02 PM Mark Thomas wrote: > This vote is cancelled due to the regression with missing JMX MBean > attributes. > The object name (as a String) was registered in JMX, rather than the object itself, so everything is 100% wrong (except the object name of the registration,

Re: [VOTE] Release Apache Tomcat 9.0.18

2019-04-11 Thread Rémy Maucherat
On Thu, Apr 11, 2019 at 4:15 PM Mark Thomas wrote: > Anything else? > Fix the gitbox <-> github sync. Rémy > > Mark > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail:

Re: [VOTE] Release Apache Tomcat 9.0.18

2019-04-11 Thread Rémy Maucherat
On Thu, Apr 11, 2019 at 4:15 PM Mark Thomas wrote: > On 11/04/2019 15:11, Rémy Maucherat wrote: > > > I already made the fix but the commit emails is stuck. > > > https://github.com/apache/tomcat/commit/4c6c3e9f434ca1a5cecf04f1b9148fb221b3af37 > > Great. Thanks. >

Re: [VOTE] Release Apache Tomcat 9.0.18

2019-04-11 Thread Rémy Maucherat
On Thu, Apr 11, 2019 at 4:08 PM Mark Thomas wrote: > On 11/04/2019 14:52, Mark Thomas wrote: > > On 11/04/2019 14:31, Rainer Jung wrote: > >> Am 11.04.2019 um 14:51 schrieb Rémy Maucherat: > >>> On Thu, Apr 11, 2019 at 2:00 PM Rainer Jung > >>> wrote: &

  1   2   3   4   5   6   7   8   9   10   >